On Fri, 7 Oct 2022 21:11:39 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> This patch rewrites some BigInteger and curve point operations used in EC > calculations: > - coefficient * 2^power is equivalent to coefficient << power > - number mod 2^n is equivalent to number & (2^n-1) > - pair of IntegerModuloP operations: > t2 = t1+t1 > t1 = t1+t2 > is equivalent to t1=t1*3, which is now implemented more efficiently. > > Benchmarked the code using not-yet-merged benchmark from #10544. Results on > x64 before: > > Benchmark (messageLength) Mode Cnt Score Error Units > Signatures.sign 64 thrpt 15 1578.907 ± 1.522 ops/s > > After: > > Benchmark (messageLength) Mode Cnt Score Error Units > Signatures.sign 64 thrpt 15 1679.495 ± 3.883 ops/s > > Greatest part of the improvement is related to ECOperations changes; > BigInteger modifications provide only marginal gains (1584 ops/s without > ECOperations changes). > > Tier1-3 tests continue to pass. In src/java.base/share/classes/sun/security/provider/DSAParameterGenerator.java there a still some mod(Biginteger.TWO.pow(...)) type subexpressions, e.g. in lines 214, 220, 231, 240 (not that it matters much). ------------- PR: https://git.openjdk.org/jdk/pull/10614
