On Tue, 6 Sep 2022 14:36:57 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more refactoring.
>
> src/java.base/share/classes/java/security/Security.java line 919:
>
>> 917: }
>> 918:
>> 919: private static boolean isKnownComposite(String attr) {
>
> You can move this method and the next method inside the `Criteria` class. In
> fact, I think the `isConstraintSatisfied` method can be combined into the
> `isCriterionSatisfied` method.
Yes, good idea.
-------------
PR: https://git.openjdk.org/jdk/pull/10008
