On Thu, 1 Sep 2022 14:31:53 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comments from Sean and Max
>
> src/java.base/share/classes/sun/security/x509/AlgIdDSA.java line 50:
>
>> 48: * operations. The following is an example of how this may be done
>> assuming
>> 49: * that we have a certificate called <code>currentCert</code> which
>> doesn't
>> 50: * contain DSS/DSA parameters, and we need to derive DSS/DSA parameters
>
> Comma seems misleading. This is all about "an example".
Removing the comma.
> src/java.base/share/classes/sun/security/x509/AlgorithmId.java line 311:
>
>> 309: } else {
>> 310: String n = aliasOidsTable().get(oidStr);
>> 311: return Objects.requireNonNullElseGet(n, () ->
>> algid.toString());
>
> Maybe `?:`.
Fixed.
> src/java.base/share/classes/sun/security/x509/CertificateExtensions.java line
> 266:
>
>> 264: public Map<String,Extension> getUnparseableExtensions() {
>> 265: return Objects.requireNonNullElse(unparseableExtensions,
>> 266: Collections.emptyMap());
>
> `?:`
Fixed.
> src/java.base/share/classes/sun/security/x509/IPAddressName.java line 214:
>
>> 212:
>> 213: // copy mask bytes into mask portion of address
>> 214: System.arraycopy(maskArray, 0, address, 16, MASKSIZE);
>
> Please use `MASKSIZE` instead of `16`.
Fixed.
> src/java.base/share/classes/sun/security/x509/IssuingDistributionPointExtension.java
> line 143:
>
>> 141:
>> 142: if (hasOnlyUserCerts && (hasOnlyCACerts ||
>> hasOnlyAttributeCerts) ||
>> 143: hasOnlyCACerts && hasOnlyAttributeCerts) {
>
> Honestly I don't understand the new check. The original one seems more clear.
Using original check.
> src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 700:
>
>> 698:
>> 699: if (id.equalsIgnoreCase(INFO)) {
>> 700: //reset this as certificate data has changed
>
> Duplicated?
Line has been removed.
-------------
PR: https://git.openjdk.org/jdk/pull/9972
