On Sun, 14 Aug 2022 06:39:58 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but >> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which >> is actually 1 on Windows, not -1. Can be safely commented out as it isn't >> used anywhere, except for in a call to ExitProcess which has also been >> commented out as well. > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'openjdk:master' into patch-2 > - Merge branch 'openjdk:master' into patch-2 > - Merge branch 'openjdk:master' into patch-2 > - Comment out EXIT_FAILURE redefinition I don't think a library should call `ExitProcess` anyway. If you do want to keep it, I'd suggest modify that `EXIT_FAILURE` argument to -1, which is what the original author meant. Or, move the useless `#define EXIT_FAILURE -1` line there and also comment it out. This way we keep the history. ------------- PR: https://git.openjdk.org/jdk/pull/9678
