On Thu, 7 Jul 2022 17:35:08 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Mark Powers has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits since the last revision: >> >> - Merge >> - comments from Valerie and Max >> - aw shucks - another one >> - Max comments continued >> - Max comments >> - Valerie fix continued >> - Valerie fix >> - mo polish >> - polish >> - Merge >> - ... and 3 more: https://git.openjdk.org/jdk/compare/ca0ee471...54310a1a > > src/java.base/share/classes/javax/crypto/CryptoAllPermission.java line 98: > >> 96: * >> 97: * @return a new {@code PermissionCollection} object suitable for >> 98: * storing {@code CryptoAllPermissions} objects. > > typo: CryptoAllPermissions -> CryptoAllPermission? Fixed. > src/java.base/share/classes/javax/crypto/CryptoAllPermission.java line 126: > >> 124: >> 125: /** >> 126: * Create an empty {@code CryptoAllPermission} object. > > typo: CryptoAllPermissions -> CryptoAllPermission? It's already fixed. > src/java.base/share/classes/javax/crypto/MacSpi.java line 96: > >> 94: /** >> 95: * Processes {@code input.remaining()} bytes in the ByteBuffer >> 96: * {@code input}, starting at {@code input.position()}. > > Hmm, should these be {@code input}.remaining() and {@code input}.position()? No. > src/java.base/share/classes/javax/crypto/SealedObject.java line 43: > >> 41: * confidentiality with a cryptographic algorithm. >> 42: * >> 43: * <p> Given any Serializable object, one can create a {@code >> SealedObject} > > add {@code } to Serializable? Fixed. > src/java.base/share/classes/javax/crypto/SealedObject.java line 125: > >> 123: * encoded in the default format. >> 124: * <p> >> 125: * That is, {@code cipher.getParameters().getEncoded()}. > > cipher -> Cipher? Fixed. > src/java.base/share/classes/javax/crypto/SealedObject.java line 132: > >> 130: >> 131: /** >> 132: * Constructs a {@code SealedObject} from any Serializable object. > > add {@code } to Serializable? Fixed. > src/java.base/share/classes/javax/crypto/SealedObject.java line 227: > >> 225: * the sealing operation. >> 226: * If the default provider package provides an implementation of >> that >> 227: * algorithm, an instance of {@code Cipher} object containing that > > "an instance of" seems redundant now that you added "object" Fixed. ------------- PR: https://git.openjdk.org/jdk/pull/9282
