On 2024-11-13 10:38, Alessandro Zucchelli wrote:
This addresses violations of MISRA C:2012 Rule 5.4 which states as
following: Macro identifiers shall be distinct.
This deviation aims to address violations of Rule 5.4 regarding
identifiers XLAT_hvm_altp2m_set_mem_access_multi_HNDL_pfn_list and
X
On 2024-08-06 03:03, Stefano Stabellini wrote:
On Sat, 3 Aug 2024, Nicola Vetrini wrote:
On 2024-08-02 00:06, Stefano Stabellini wrote:
> The ECLAIR jobs part of the Gitlab CI pipeline fail reliably when the
> pipeline is started from a merge request. This is the error:
>
> Unexpected event pull
On 2024-08-06 20:25, Stefano Stabellini wrote:
On Tue, 6 Aug 2024, Simone Ballarin wrote:
On 2024-08-06 03:03, Stefano Stabellini wrote:
> On Sat, 3 Aug 2024, Nicola Vetrini wrote:
> > On 2024-08-02 00:06, Stefano Stabellini wrote:
> > > The ECLAIR jobs part of the Gitla
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Luca Fancellu
Reviewe
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
Changes in v3:
- change 'S
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
From: Gianluca Luparini
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline
states:
"A 'u' or 'U' suffix shall be applied to all integer constants that are
represented in an unsigned type".
These violations are caused by the missing "u" or "U" suffix in unsigned
integer c
als with unsigned type.
For the sake of uniformity, the following changes are made:
- add the 'U' suffix to all first macro's arguments in 'boot.c'
- add the 'U' suffix near '0x3fff' in 'runtime.c'
Signed-off-by: Gianluca Luparini
Signed-off-b
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
als with unsigned type.
For the sake of uniformity, the following changes are made:
- add the 'U' suffix to integer constants before the '?' operator
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Juergen Gross
Reviewed-by: Stefano Stabellini
-
s near 'INTR_INFO_VALID_MASK'
macro in 'vmx.h'
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
---
Changes in v3:
- change 'Signed-off-by' ordering
- change commit message
- remove unnecessary changes in 'vvmx.
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
--
als with unsigned type.
Fot the sake of uniformity, the following changes are made:
- add the 'U' suffix to all integer constants before the
'?' operator in 'bitops.h'
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
als with unsigned type.
For the sake of uniformity, the following changes are made:
- add the 'U' suffix to all first macro's arguments in 'cper.h'
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
Changes in v3:
- create this commit for 'cper.h&#
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
Changes in v3:
- create this co
in 'stdvga.c'
- add the 'U' suffix to macros in 'pci.h'
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
Changes in v3:
- change 'Signed-off-by' ordering
- change commit message
- add 'UL' in 'extable.c'
- fix indentation i
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
--
/origin/staging/X86_64-Set1/149/PROJECT.ecd;/by_service/MC3R1.R19.1.html
>
> Hmm, gives me "Unauthorized".
>
Please try again, now it should work.
Simone Ballarin, M.Sc.
Field Application Engineer, BUGSENG (https://bugseng.com
<http://bugseng.com>)
by BUGSENG.
Signed-off-by: Simone Ballarin
---
.gitlab-ci.yml| 2 ++
automation/gitlab-ci/analyze.yaml | 38 +++
automation/scripts/eclair | 26 +
3 files changed, 66 insertions(+)
create mode 100644 automation/gi
SSH_COMMAND="ssh -o StrictHostKeyChecking=no"
> > +[ -d ECLAIR_scripts ] || git clone ssh://
> g...@git.bugseng.com/eclair/scripts/XEN ECLAIR_scripts
> > +(cd ECLAIR_scripts; git pull --rebase)
> > +
> > +ECLAIR_DIR=ECLAIR_scripts/ECLAIR
> > +ECLAIR_OUTPUT_DIR=$(realpath "${ECLAIR_OUTPUT_DIR}")
> > +
> > +ECLAIR_scripts/prepare.sh "${VARIANT}"
> > +
> > +ex=0
> > +"${ECLAIR_DIR}/analyze.sh" "${VARIANT}" "${RULESET}" || ex=$?
> > +"${ECLAIR_DIR}/action_log.sh" ANALYSIS_LOG \
> > + "ECLAIR analysis log" \
> > + "${ECLAIR_OUTPUT_DIR}/ANALYSIS.log" \
> > + "${ex}"
> > +"${ECLAIR_DIR}/action_log.sh" REPORT_LOG \
> > + "ECLAIR report log" \
> > + "${ECLAIR_OUTPUT_DIR}/REPORT.log" \
> > + "${ex}"
> > +[ "${ex}" = 0 ] || exit "${ex}"
> > +"${ECLAIR_DIR}/action_push.sh" "${WTOKEN}" "${ECLAIR_OUTPUT_DIR}"
> > +
> > +rm -rf "${ECLAIR_OUTPUT_DIR}/.data"
> > --
> > 2.34.1
> >
>
--
Simone Ballarin, M.Sc.
Field Application Engineer, BUGSENG (https://bugseng.com
<http://bugseng.com>)
of guidelines tagged as
clean:added. The list of clean guidelines are maintained in
automation/eclair_analysis/ECLAIR/tagging.ecl.
Signed-off-by: Simone Ballarin
--
Changes in v2:
- add ECLAIR configuration files (before they were fetched from a separate
repository);
- now the pipeline fa
to read a masked variable
named WTOKEN with the token provided by BUGSENG, otherwise the pipeline
will fail.
The analysis fails if it contains violations of guidelines tagged as
clean:added. The list of clean guidelines are maintained in
automation/eclair_analysis/ECLAIR/tagging.ecl.
Simone
-off-by: Simone Ballarin
--
Changes in v3:
- split ECLAIR configurations and scripts in a separate patch;
- remove references to "Task (a): Xen Coding Guidelines v1.0".
Changes in v2:
- add ECLAIR configuration files (before they were fetched from a separate
repository);
- now the pipe
; the prepare.sh script is instead intended
to perform all the required operations for building xen
that are not supposed to be analyzed: e.g. dependencies
build.
Signed-off-by: Simone Ballarin
--
Changes in v3:
- split build definitions in a separate patch.
Changes in v2:
- add ECLAIR
of guidelines tagged as
clean:added. The list of clean guidelines are maintained in
automation/eclair_analysis/ECLAIR/tagging.ecl.
Signed-off-by: Simone Ballarin
--
Changes in v3:
- split definitions of the ECLAIR pipelines in a separate patch;
- if the WTOKEN variable is missing now the analys
Signed-off-by: Simone Ballarin
--
Changes in v3:
- split maintainer add in a separate patch;
- substitute blanks with tabs;
- fix file paths;
- change role from maintainer to reviewer.
Changes in v2:
- add ECLAIR configuration files (before they were fetched from a separate
repository);
- now
t;
> BTW I really like the graphics output, e.g.:
>
> https://saas.eclairit.com:3787/fs/var/local/eclair/xen-project.ecdf/xen-project/people/sstabellini/xen/ECLAIR_normal/ppp2/ARM64/4732041018/PROJECT.ecd;/by_service.html#service/first_file&kind
>
> Very nice and clear!
>
>
--
Simone Ballarin, M.Sc.
Field Application Engineer, BUGSENG (https://bugseng.com
<http://bugseng.com>)
s near 'INTR_INFO_VALID_MASK'
macro in 'vmx.h'
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
Reviewed-by: Jan Beulich
---
Changes in v4:
- change commit headline
Changes in v3:
- change 'Signed-off-by' ordering
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
---
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline
states:
"A 'u' or 'U' suffix shall be applied to all integer constants that are
represented in an unsigned type".
These violations are caused by the missing "u" or "U" suffix in unsigned
integer constants, such as:
xen/ar
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
---
d.c'
- add 'U' suffixes to 'mask16' in 'stdvga.c'
- add the 'U' suffix to macros in 'pci.h'
- use _AC() for macros near 'X86_CR0_PG'
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
Il giorno mer 26 lug 2023 alle ore 14:02 Jan Beulich ha
scritto:
> On 26.07.2023 13:03, Simone Ballarin wrote:
> > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> headline
> > states:
> > "A 'u' or 'U' suffix shall be applied
v4:
- move link to the analysis results at the end of the console log
- avoid git warning
- avoid undesired git logs
- remove undesired blanks in MAINTAINERS
Simone Ballarin (4):
automation: Add ECLAIR utilities and settings
automation: Add xen builds for the ECLAIR analyses
automation: Add
of guidelines tagged as
clean:added. The list of clean guidelines are maintained in
automation/eclair_analysis/ECLAIR/tagging.ecl.
Signed-off-by: Simone Ballarin
--
Changes in v4:
- move link to the analysis results at the end of the console log
Changes in v3:
- split definitions of the E
Signed-off-by: Simone Ballarin
Acked-by: Stefano Stabellini
--
Changes in v4:
- add 'Acked-by'
- remove undesired blanks
Changes in v3:
- split maintainer add in a separate patch;
- substitute blanks with tabs;
- change role from maintainer to reviewer.
Changes in v2:
-
-off-by: Simone Ballarin
Acked-by: Stefano Stabellini
--
Changes in v4:
- avoid warning from git fetch
- add --quit to git fetch
- add 'Acked-by'
Changes in v3:
- split ECLAIR configurations and scripts in a separate patch;
- remove references to "Task (a): Xen Coding Guidelines v1.
; the prepare.sh script is instead intended
to perform all the required operations for building xen
that are not supposed to be analyzed: e.g. dependencies
build.
Signed-off-by: Simone Ballarin
Reviewed-by: Stefano Stabellini
--
Changes in v4:
- add 'Reviewed-by'
Changes in v3:
- s
series avoids failures when a merge point with xen-project/xen(staging)
is not found.
Simone Ballarin (4):
automation/eclair: add support for tag pipelines
automation/eclair: add direct link to reports
automation/eclair: add scheduled pipelines
automation/eclair: avoid failure in case of missing
The ECLAIR jobs fail when triggered by tag pipelines (e.g.
xen-project/patchew/xen).
This patch extends the integration to support such pipelines.
Signed-off-by: Simone Ballarin
---
.../eclair_analysis/ECLAIR/action.settings| 24 ---
1 file changed, 15 insertions(+), 9
This patch introduces six new ECLAIR jobs that run only
when triggered by a GitLab scheduled pipeline.
Signed-off-by: Simone Ballarin
---
.../eclair_analysis/ECLAIR/action.settings| 2 +-
automation/gitlab-ci/analyze.yaml | 65 +--
2 files changed, 62 insertions
This patch adds direct links to the analysis findings in the
console log.
Signed-off-by: Simone Ballarin
---
.../eclair_analysis/ECLAIR/action.helpers | 84 ++-
1 file changed, 65 insertions(+), 19 deletions(-)
diff --git a/automation/eclair_analysis/ECLAIR/action.helpers
In the context of an auto pull request, when a common merge point
is not found the integration will continue the analysis without
failing.
Signed-off-by: Simone Ballarin
---
automation/eclair_analysis/ECLAIR/action.settings | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
Il 02/08/2023 02:08 Stefano Stabellini ha scritto:
On Wed, 2 Aug 2023, Marek Marczykowski-Górecki wrote:
On Tue, Aug 01, 2023 at 03:55:20PM -0700, Stefano Stabellini wrote:
> On Tue, 1 Aug 2023, Simone Ballarin wrote:
> > This patch introduces six new ECLAIR jobs that run only
Il 02/08/2023 00:54 Stefano Stabellini ha scritto:
On Tue, 1 Aug 2023, Simone Ballarin wrote:
The ECLAIR jobs fail when triggered by tag pipelines (e.g.
xen-project/patchew/xen).
This patch extends the integration to support such pipelines.
Signed-off-by: Simone Ballarin
Acked-by: Stefano
This series aims to address some violations ofMISRA C:2012 Rule 7.3:
"The lowercase character 'l' shall not be used in a literal suffix".
This patch replaces "l" suffixes with "L", to comply with the rule.
If the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
Gianluca L
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/drivers/passthrough/amd/iommu_guest.c | 2 +-
xen/drivers/passthrough/a
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/arch/arm/include/asm/processor.h | 6 +++---
xen/arch/arm/vtimer.
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/common/mem_access.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/drivers/passthrough/x86/iommu.c | 8
1 file changed, 4 insertion
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/arch/x86/hvm/svm/svm.c | 4 ++--
1 file changed, 2 insertions(+), 2 de
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/common/ioreq.c | 2 +-
xen/include/xen/ioreq.h | 2 +-
2 files chang
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/drivers/vpci/header.c | 2 +-
xen/drivers/vpci/msi.c| 2 +-
xe
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/arch/x86/hvm/emulate.c | 2 +-
xen/arch/x86/hvm/io.c | 2 +-
2 fil
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/arch/x86/mm/p2m-pt.c | 6 +++---
xen/arch/x86/mm/p2m.c | 20
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/arch/x86/hvm/viridian/synic.c | 2 +-
xen/arch/x86/hvm/viridian/
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/arch/x86/cpu-policy.c| 4 ++--
xen/arch/x86/dom0_build.c
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/common/page_alloc.c | 6 +++---
xen/common/rangeset.c | 2 +-
xen/com
the "u" suffix is used near "L", use the "U" suffix instead, for consistency.
The changes in this patch are mechanical.
Signed-off-by: Gianluca Luparini
Signed-off-by: Simone Ballarin
---
xen/include/xen/bitops.h | 8
xen/include/xen/tasklet.h | 4 ++--
x
This series contains new ECL configurations and adds some build options
in the ARM64 build.
Simone Ballarin (3):
automation/eclair: update clean guidelines
automation/eclair: add ECL deviations
automation/eclair: update analyzed builds
.../eclair_analysis/ECLAIR/deviations.ecl | 34
following clean guidelines have been added:
- MC3R1.R1.1;
- MC3R1.R1.3;
- MC3R1.R3.1;
- MC3R1.R4.1;
- MC3R1.R17.4;
- MC3R1.R22.6;
- MC3R1.D4.3 (just x86_64);
- MC3R1.R5.3 (just arm64);
- MC3R1.R7.2 (just arm64);
- MC3R1.R8.6 (just arm64);
- MC3R1.R9.3 (just arm64).
Signed-off-by: Simone Ballarin
This patch adds some deviations for the following guidelines:
Rule 2.1, Rule 5.3 and Rule 8.2.
Signed-off-by: Simone Ballarin
---
.../eclair_analysis/ECLAIR/deviations.ecl | 34 ---
1 file changed, 15 insertions(+), 19 deletions(-)
diff --git a/automation/eclair_analysis
The xen build for ARM64 now has new configuration options which
require to be defined: this patch defines them.
In both configuration files some no longer true comments have been removed.
Signed-off-by: Simone Ballarin
---
automation/eclair_analysis/xen_arm_config | 14
Il giorno mer 26 lug 2023 alle ore 13:04 Simone Ballarin <
simone.balla...@bugseng.com> ha scritto:
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline
> states:
> "A 'u' or 'U' suffix shall be applied to all integer constants th
On 09/08/2023 11:15, Jan Beulich wrote:
On 09.08.2023 10:58, Simone Ballarin wrote:
Il giorno mer 26 lug 2023 alle ore 13:04 Simone Ballarin <
simone.balla...@bugseng.com> ha scritto:
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
headline
states:
"A '
This patch avoids the execution of pipelines in the
following branches:
- master
- smoke
- coverirty-tested/.*
- stable-.*
The job-level exclusions have been removed as they are
pointless with this new workspace-level exclusion.
Signed-off-by: Simone Ballarin
---
.gitlab-ci.yml | 6 ++
1
With this patch, ECLAIR jobs will need to be manually
started for "people/.*" pipelines.
This avoids occupying the runner on analyzes that might
not be used by developers.
If developers want to analyze their own repositories
they need to launch them from GitLab.
Signed-off-by: Simon
This series aims to reduce the analyses performed by the ECLAIR
runner by avoiding some branches already excluded by other jobs
and requiring analyses on people/.* to be manually triggered.
Simone Ballarin (2):
automation: avoid pipelines on specific branches
automation/eclair: avoid
On 12/08/2023 00:04, Stefano Stabellini wrote:
On Fri, 11 Aug 2023, Simone Ballarin wrote:
With this patch, ECLAIR jobs will need to be manually
started for "people/.*" pipelines.
This avoids occupying the runner on analyzes that might
not be used by developers.
If developers want
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/drivers/passthrough/amd/iommu-defs.h | 122 +++-
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/arch/x86/cpu/vpmu_intel.c | 4 ++--
xen/arch/x86/hvm/
xplicitly state when an integer constant
is represented in an unsigned type.
Signed-off-by: Simone Ballarin
---
xen/common/device_tree.c| 4 ++--
xen/include/xen/libfdt/fdt.h| 2 +-
xen/include/xen/libfdt/libfdt.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/arch/x86/monitor.c | 6 +++---
1 file changed, 3 insertions(+)
xplicitly state when an integer constant
is represented in an unsigned type.
Signed-off-by: Simone Ballarin
---
xen/drivers/vpci/msi.c | 2 +-
xen/drivers/vpci/msix.c | 2 +-
xen/drivers/vpci/vpci.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/drivers/v
xplicitly state when an integer constant
is represented in an unsigned type.
Signed-off-by: Simone Ballarin
---
xen/arch/x86/hvm/svm/asid.c | 2 +-
xen/arch/x86/hvm/svm/svm.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/arch/x86/include/asm/x86_64/efibind.h | 10 +-
xen/c
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/arch/x86/acpi/cpufreq/powernow.c | 14 +++---
xen
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/arch/arm/domain_build.c | 2 +-
xen/arch/arm/efi
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/drivers/passthrough/pci.c | 4 ++--
1 file changed, 2
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/arch/x86/apic.c | 2 +-
xen/arch/x86
From: Gianluca Luparini
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline
states:
"A "u" or "U" suffix shall be applied to all integer constants that are
represented in an unsigned type".
These violations are caused by the missing "u" or "U" suffix in unsigned
intege
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/common/gunzip.c | 2 +-
xen/common/xmalloc_tlsf.c
xplicitly state when an integer constant
is represented in an unsigned type.
For homogeneity, I also added the "U" suffix in some cases that the tool didn't
report as violations.
Signed-off-by: Simone Ballarin
---
xen/include/public/io/ring.h | 10 +-
1 file changed, 5
Hi,
Il giorno mar 20 giu 2023 alle ore 13:03 Julien Grall ha
scritto:
> Hi,
>
> On 20/06/2023 11:34, Simone Ballarin wrote:
> > From: Gianluca Luparini
>
> Is this person the original author of this patch? If so...
>
> >
> > The xen sources contains viola
Hi,
Il giorno mar 20 giu 2023 alle ore 15:20 Jan Beulich ha
scritto:
> On 20.06.2023 12:35, Simone Ballarin wrote:
> > --- a/xen/common/gunzip.c
> > +++ b/xen/common/gunzip.c
> > @@ -11,7 +11,7 @@ static unsigned char *__initdata window;
> > static memptr __initdat
Il giorno mar 20 giu 2023 alle ore 14:43 Jan Beulich ha
scritto:
> On 20.06.2023 12:34, Simone Ballarin wrote:
> > From: Gianluca Luparini
> >
> > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> headline states:
> > "A "u"
Il giorno mar 20 giu 2023 alle ore 14:51 Jan Beulich ha
scritto:
> On 20.06.2023 12:34, Simone Ballarin wrote:
> > --- a/xen/arch/x86/cpu/vpmu_intel.c
> > +++ b/xen/arch/x86/cpu/vpmu_intel.c
> > @@ -950,10 +950,10 @@ const struct arch_vpmu_ops *__init
&
Hi,
Il giorno mar 20 giu 2023 alle ore 15:00 Jan Beulich ha
scritto:
> On 20.06.2023 12:35, Simone Ballarin wrote:
> > --- a/xen/include/public/io/ring.h
> > +++ b/xen/include/public/io/ring.h
> > @@ -36,11 +36,11 @@
> > typedef unsigned int RING_IDX;
> >
Il giorno mer 21 giu 2023 alle ore 09:06 Jan Beulich ha
scritto:
> On 20.06.2023 22:56, Stefano Stabellini wrote:
> > On Tue, 20 Jun 2023, Jan Beulich wrote:
> >> On 20.06.2023 12:34, Simone Ballarin wrote:
> >>> From: Gianluca Luparini
> >>>
> >&
Il giorno mar 20 giu 2023 alle ore 22:41 Stefano Stabellini <
sstabell...@kernel.org> ha scritto:
> On Tue, 20 Jun 2023, Luca Fancellu wrote:
> > > On 20 Jun 2023, at 13:39, Jan Beulich wrote:
> > >
> > > On 20.06.2023 12:34, Simone Ballarin wrote:
> >
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Simone Ballarin
Signed-off-by: Gianluca Luparini
Acked-by: Stefano Stabellini
---
From: Gianluca Luparini
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline
states:
"A 'u' or 'U' suffix shall be applied to all integer constants that are
represented in an unsigned type".
These violations are caused by the missing "u" or "U" suffix in unsigned
integer c
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Simone Ballarin
Signed-off-by: Gianluca Luparini
---
Changes in v2:
- change commi
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Simone Ballarin
Signed-off-by: Gianluca Luparini
---
Changes in v2:
- minor change
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Simone Ballarin
Signed-off-by: Gianluca Luparini
---
Changes in v2:
- change commit
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Simone Ballarin
Signed-off-by: Gianluca Luparini
Reviewed-by: Stefano Stabellini
---
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Simone Ballarin
Signed-off-by: Gianluca Luparini
---
Changes in v2:
- minor change
als with unsigned type and also to other
literals used in the same contexts or near violations, when their positive
nature is immediately clear. The latter changes are done for the sake of
uniformity.
Signed-off-by: Simone Ballarin
Signed-off-by: Gianluca Luparini
Reviewed-by: Stefano Stabellini
---
1 - 100 of 325 matches
Mail list logo
