Hello,
Dongli Zhang, le lun. 18 févr. 2019 08:09:56 +0800, a ecrit:
> On 2/18/19 5:29 AM, Samuel Thibault wrote:
> >>>>> On 2/10/19 12:35 AM, Samuel Thibault wrote:
> >>>>>> Oh! That could be it indeed. I'm wondering what could be monopolizing
>
From: Sacha
To: xen-de...@lists.xen.org
Subject: [admin] [BUG] task jbd2/xvda4-8:174 blocked for more than 120 seconds.
Hi,
On Debian GNU/Linux 9.7 (stretch) amd64, we have a bug on the last Xen
Hypervisor version:
xen-hypervisor-4.8-amd64 4.8.5+shim4.10.2+xsa282
The rollback on the previ
From: Samuel Thibault
To: xen-de...@lists.xen.org, x...@packages.debian.org
Subject: Re: [admin] [BUG] task jbd2/xvda4-8:174 blocked for more than 120
seconds.
Hello,
Sacha, le ven. 08 févr. 2019 18:00:22 +0100, a ecrit:
> On Debian GNU/Linux 9.7 (stretch) amd64, we have a bug on the last
; Apparently,
> x...@packages.debian.org
> results in a message to
> pkg-xen-de...@lists.alioth.debian.org
Yes, since that's the maintainer of the package.
> On 2/8/19 6:13 PM, Samuel Thibault wrote:
> >
> > Sacha, le ven. 08 févr. 2019 18:00:22 +0100, a ecrit:
> >> On D
Hello,
Sacha, le ven. 08 févr. 2019 18:00:22 +0100, a ecrit:
> On Debian GNU/Linux 9.7 (stretch) amd64, we have a bug on the last Xen
> Hypervisor version:
>
> xen-hypervisor-4.8-amd64 4.8.5+shim4.10.2+xsa282
(Read: 4.8.5+shim4.10.2+xsa282-1+deb9u11)
> The rollback on the previous package
Hello,
Hans van Kranenburg, le sam. 09 févr. 2019 17:01:55 +0100, a ecrit:
> > I have forwarded the original mail: all VM I/O get stuck, and thus the
> > VM becomes unusable.
>
> These are in many cases the symptoms of running out of "grant frames".
Oh! That could be it indeed. I'm wondering w
Hello,
Dongli Zhang, le lun. 11 févr. 2019 09:37:43 +0800, a ecrit:
> On 2/10/19 12:35 AM, Samuel Thibault wrote:
> > Hello,
> >
> > Hans van Kranenburg, le sam. 09 févr. 2019 17:01:55 +0100, a ecrit:
> >>> I have forwarded the original mail: all VM I/O get stu
Hans van Kranenburg, le lun. 11 févr. 2019 22:59:11 +0100, a ecrit:
> On 2/11/19 2:37 AM, Dongli Zhang wrote:
> >
> > On 2/10/19 12:35 AM, Samuel Thibault wrote:
> >>
> >> Hans van Kranenburg, le sam. 09 févr. 2019 17:01:55 +0100, a ecrit:
> >>>> I
Hello,
Dongli Zhang, le mar. 12 févr. 2019 12:11:20 +0800, a ecrit:
> On 02/12/2019 06:10 AM, Samuel Thibault wrote:
> > Hans van Kranenburg, le lun. 11 févr. 2019 22:59:11 +0100, a ecrit:
> >> On 2/11/19 2:37 AM, Dongli Zhang wrote:
> >>>
> >>>
Dongli Zhang, le lun. 18 févr. 2019 08:09:56 +0800, a ecrit:
>
>
> On 2/18/19 5:29 AM, Samuel Thibault wrote:
> > Hello,
> >
> > Dongli Zhang, le mar. 12 févr. 2019 12:11:20 +0800, a ecrit:
> >> On 02/12/2019 06:10 AM, Samuel Thibault wrote:
> >>&g
Samuel Thibault, le dim. 13 oct. 2019 18:20:39 +0200, a ecrit:
> Olaf Hering, le mer. 02 oct. 2019 19:05:36 +0200, a ecrit:
> > The function read_vtpmblk uses printf(3), but stdio.h is not included
> > in this file. This results in a warning from gcc-7:
> >
>
ation of
> 'printf'
>
> Signed-off-by: Olaf Hering
> cked-by: Daniel De Graaf
Reviewed-by: Samuel Thibault
> ---
> stubdom/vtpm/vtpmblk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/stubdom/vtpm/vtpmblk.c b/stubdom/vtpm/vtpmblk.c
Olaf Hering, le dim. 13 oct. 2019 18:50:32 +0200, a ecrit:
> Am Sun, 13 Oct 2019 18:21:27 +0200
> schrieb Samuel Thibault :
>
> > > > cked-by: Daniel De Graaf
> >
> > Note that you miss an 'A' at the beginning of the line there.
>
> Thanks for
that uses it so
> > that the files are never generated.
> >
> > Signed-off-by: Doug Goldstein
>
> Acked-by: Wei Liu
Reviewed-by: Samuel Thibault
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Olaf Hering, le lun. 18 juin 2018 14:55:36 +0200, a ecrit:
> gcc8 spotted this error:
> error: 'memcmp' reading 20 bytes from a region of size 8
> [-Werror=stringop-overflow=]
>
> Signed-off-by: Olaf Hering
Indeed!
Reviewed-by: Samuel Thibault
b.patches. This
> > means that there are now no longer any GFDL-licenced grub docs in
> > xen.git.
> >
> > There is no user impact, and Debian is helped. This change would
> > complicate any attempts to update to a new version of upstream grub1,
> &g
t;
> Signed-off-by: Bruno Alvisio
Reviewed-by: Samuel Thibault
> ---
> include/x86/x86_32/hypercall-x86_32.h | 4 ++--
> include/x86/x86_64/hypercall-x86_64.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/x86/x86_32/hypercall-x86_32.h
-off-by: Bruno Alvisio
Reviewed-by: Samuel Thibault
> ---
> arch/x86/traps.c | 17 +++--
> include/x86/os.h | 3 +++
> 2 files changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/traps.c b/arch/x86/traps.c
> index aa17da3..a7388a5 100644
>
nvoked to
> suspend/resume each of the modules.
>
> Signed-off-by: Bruno Alvisio
Reviewed-by: Samuel Thibault
> ---
> arch/x86/setup.c | 10 ++
> include/kernel.h | 2 ++
> include/x86/os.h | 4 ++--
> kernel.c | 10 ++
> 4 files changed, 24 ins
o Alvisio
Reviewed-by: Samuel Thibault
> ---
> include/xenbus.h | 1 +
> xenbus/xenbus.c | 10 +-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/include/xenbus.h b/include/xenbus.h
> index 12391b9..b2d5072 100644
> --- a/include/xenbus.h
> +++
Bruno Alvisio, on mar. 19 déc. 2017 15:42:00 -0800, wrote:
> + * NEC Europe Ltd. PROPRIETARY INFORMATION
> + *
> + * This software is supplied under the terms of a license agreement
> + * or nondisclosure agreement with NEC Europe Ltd. and may not be
> + * copied or disclosed except in acc
nd at:
>
> https://github.com/balvisio/mini-os/tree/feature/mini-os-suspend-support
I got commit 3869ff5bf4e88d708fb62c16fbe8eb9c0eee9d45 from there, and
you can consider it
Reviewed-by: Samuel Thibault
Samuel
___
Xen-devel mailing list
Xen-devel@lis
a_mapping((unsigned
> long)HYPERVISOR_shared_info,
For coherency, I'd say use shared_info there too.
Apart from that,
Reviewed-by: Samuel Thibault
> +__pte((virt_to_mfn(shared_info)< UVMF_INVLPG)) )
> +{
> +printk("Failed to unmap
eplaced with PFNs:
> canonicalization.
>
> PVH guests are auto-translated so no memory operation is needed.
>
> Signed-off-by: Bruno Alvisio
Reviewed-by: Samuel Thibault
> ---
> arch/x86/mm.c | 14 ++
> include/x86/arch_mm.h | 3 +++
> 2 files chan
Bruno Alvisio, on mar. 19 déc. 2017 15:42:04 -0800, wrote:
> Signed-off-by: Bruno Alvisio
Reviewed-by: Samuel Thibault
> ---
> kernel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel.c b/kernel.c
> index 1cd40e8..782eb79 100644
>
Bruno Alvisio, on mar. 19 déc. 2017 15:42:05 -0800, wrote:
> Signed-off-by: Bruno Alvisio
> +void resume_time(void)
> +{
> +port = bind_virq(VIRQ_TIMER, &timer_handler, NULL);
> +unmask_evtchn(port);
> +}
I'd say rather factorize it with init_time.
(you could even just remove the printf
Again, I didn't find patch 11, so I got it from here
Bruno Alvisio, on mar. 19 déc. 2017 15:41:55 -0800, wrote:
> https://github.com/balvisio/mini-os/tree/feature/mini-os-suspend-support
There are indentation oddities bringing spurious hunks. Apart from that,
Reviewed-by: Samuel
Bruno Alvisio, on mar. 19 déc. 2017 15:42:07 -0800, wrote:
> Signed-off-by: Bruno Alvisio
Reviewed-by: Samuel Thibault
> ---
> events.c | 5 +
> include/events.h | 1 +
> kernel.c | 2 ++
> 3 files changed, 8 insertions(+)
>
> diff --git a/eve
Bruno Alvisio, on mar. 19 déc. 2017 15:42:08 -0800, wrote:
> +void suspend_gnttab(void)
> +{
> +#ifdef CONFIG_PARAVIRT
> +int i;
> +
> +for (i = 0; i < NR_GRANT_FRAMES; i++) {
> +HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table)
> + PAGE_SIZE*i),
> +
uct watch so that watches can be
> re-registered
> during xenbus resume.
>
> Signed-off-by: Bruno Alvisio
Again, there are spurious hunks in this patch due to oddities in
indentation, please remove them. Apart from that,
Reviewed-by: Samuel Thibault
> ---
> include/
->next != NULL; list = list->next)
;
to make it explicit that the loop is empty.
Also,
*ip = malloc(strlen(ldev->ip) + 1);
strncpy(*ip, ldev->ip, strlen(ldev->ip) + 1);
can be a mere *ip = strdup(ldev->ip), can't it?
Apart from that,
Reviewed
About patch 16,
"Replace xenstore and console pfns with the correspondent mfns"
seems exactly contrary to what the code does.
Apart from that,
Reviewed-by: Samuel Thibault
Samuel
___
Xen-devel mailing list
Xen-devel@lists.xenproject
Hello,
Jason Long, le ven. 04 sept. 2020 22:01:42 +, a ecrit:
> Can anyone tell me about the goal and features of Mini-OS?
https://wiki.xen.org/wiki/Mini-OS
Samuel
Jason Long, le sam. 05 sept. 2020 21:02:16 +, a ecrit:
> What is the difference with Unikraft?
Unikraft is originally based on MiniOS, and AIUI is actively being
worked on while MiniOS is mostly only maintained.
Samuel
stubdom/vtpmmgr/vtpmmgr.a(vtpm_cmd_handler.o):(.bss+0x0):
> multiple definition of `tpm_version';
> /home/abuild/rpmbuild/BUILD/xen-4.14.20200616T103126.3625b04991/non-dbg/stubdom/vtpmmgr/vtpmmgr.a(vtpmmgr.o):(.bss+0x0):
> first defined here
>
> Signed-off-by: Olaf He
dom,
> too.
>
> So instead of tightly coupling Mini-OS and Xen build via this interface
> modification undo this change of init_netfront() and add two other
> functions for retrieving the netmask and gateway for a network device.
>
> Signed-off-by: Juergen Gross
Reviewe
Fixes: d225f4012d69a1 ("Save/Restore Support: Add suspend/restore support for
> netfront")
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> netfront.c | 162 ++---
> 1 file changed, 67 insertions(+), 95 del
Juergen Gross, le mer. 23 sept. 2020 08:45:41 +0200, a ecrit:
> Add a PVH xenstore stubdom in order to support a Xenstore stubdom on
> a hypervisor built without PV-support.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> .gitignore
t; Coverity-ID: 1433637
> Fixes: d225f4012d69a19 ("Save/Restore Support: Add suspend/restore support
> for netfront")
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> netfront.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/netfront.c b/netf
1433640
> Fixes: 973ad0c4de1b48 ("Save/Restore Support: Add suspend/restore support for
> xenbus")
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> xenbus/xenbus.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff -
it.
>
> Fix that by either adding the needed calls of free().
>
> Coverity-ID: 1433632
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> blkfront.c | 4 ++--
> console/xenbus.c | 2 +-
> fbfront.c| 4 ++--
> ne
to a little bit more than 1000.
>
> So raise the number of event channels to 4096 in 64-bit builds.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/events.c b/e
Juergen Gross, le jeu. 16 avril 2020 14:27:48 +0200, a ecrit:
> Provide a mini-os binary stripped from debug information in order to
> have a smaller resulting kernel file. The binary with debug
> information is kept with the suffix "-debug".
>
> Signed-off-by: Juergen Gr
Juergen Gross, le jeu. 16 avril 2020 14:27:31 +0200, a ecrit:
> Using the standard -m elf_x86_64 for 64-bit mini-os results in the
> first section (.text) to start only at offset 2MB in the binary file.
? I'm not seeing this on my system:
0 .text 0001933a 00
le."
Ok, I see, I had indeed guessed that the 2M rounding probably had
something to do with 2M pages.
I'm afraid it may bite us back some day, but I'd say it is fine enough
for now to include it, so
Reviewed-by: Samuel Thibault
with the information quoted above put in the changelog, please :)
Samuel
re tcgetattr and tcsetattr behavior when .dev is NULL equivalent to
> unsupported_function as it was before c96c22f1d94.
>
> Signed-off-by: Jason Andryuk
Reviewed-by: Samuel Thibault
Thanks!
> ---
> I can't get ioemu-stubdom to start without this. With this, the guest
>
there...
Reviewed-by: Samuel Thibault
> ---
> Cc: Samuel Thibault
> Cc: minios-de...@lists.xenproject.org
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8a4c869704b0..e3748167550c 100644
> --- a/MAI
Hello,
Jan Beulich, le mer. 13 mai 2020 16:11:00 +0200, a ecrit:
> On 13.05.2020 15:55, Andrew Cooper wrote:
> > Users of EMBEDDED_EXTRA_CFLAGS already use -fno-asynchronous-unwind-tables,
> > or
> > ought to.
>
> It's not really well defined what they're supposed to be used for
> (and where it'
Jan Beulich, le lun. 18 mai 2020 09:09:14 +0200, a ecrit:
> Some gcc versions get pretty unhappy without.
>
> Signed-off-by: Jan Beulich
That was an easy one :)
Reviewed-by: Samuel Thibault
>
> --- a/console/console.c
> +++ b/console/console.c
> @@ -174,4 +174,4 @@ voi
Ian Jackson, le mer. 15 juil. 2020 17:25:00 +0100, a ecrit:
> From: Juergen Gross
>
> stubdom/mini-os.mk should contain paths used by Mini-OS when built as
> stubdom.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> stubdom/mini-os.mk | 17 +++
Juergen Gross, le lun. 13 juil. 2020 10:42:30 +0200, a ecrit:
> Mini-OS shouldn't use Xen internal paths for building. Import the
> needed paths from Xen and fall back to the current values only if
> the import was not possible.
>
> Signed-off-by: Juergen Gross
Reviewed
s/libs.
>
> So carve out libxenctrl from tools/libxc and move it into
> tools/libs/ctrl.
>
> Signed-off-by: Juergen Gross
> stubdom/Makefile | 29 +-
> stubdom/mini-os.mk| 2 +-
For that part,
Reviewed-by: Samuel Thibault
it requires a page fault when writing to a
> read-only page.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> arch/x86/x86_hvm.S| 2 +-
> include/x86/arch_mm.h | 18 --
> include/x86/os.h | 1 +
> 3 files changed, 14 ins
Juergen Gross, le sam. 15 août 2020 13:12:57 +0200, a ecrit:
> In case ov PVH dom_map_frames() is missing to increment the virtual
> address. This leads to writing only the first page table entry multiple
> times.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
&g
Hello,
Juergen Gross, le lun. 17 août 2020 11:49:06 +0200, a ecrit:
> The stubdom Makefile is missing several dependencies between Xen
> libraries. Add them.
> @@ -405,6 +405,7 @@ libs-$(XEN_TARGET_ARCH)/toollog/libxentoollog.a:
> mk-headers-$(XEN_TARGET_ARCH) $
>
> .PHONY: libxenevtchn
> li
.b1387df3f8 100644
> --- a/stubdom/mini-os.mk
> +++ b/stubdom/mini-os.mk
For these,
Reviewed-by: Samuel Thibault
Juergen Gross, le dim. 23 août 2020 11:34:48 +0200, a ecrit:
> The stubdom Makefile is missing several dependencies between Xen
> libraries. Add them.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
In case another round of review is needed, perhaps you can ju
reviewing :)
> Even if not needed right now add the possibility for defining
> additional dependencies for a library.
So I fully agree :)
Reviewed-by: Samuel Thibault
> Signed-off-by: Juergen Gross
> ---
> stubdom/Makefile | 120 ++---
viewed-by: Samuel Thibault
> ---
> .gitignore| 16 +-
> stubdom/Makefile | 34 +--
> stubdom/grub/Makefile | 2 +-
> stubdom/mini-os.mk| 2
Costin Lupu, le jeu. 27 août 2020 19:47:08 +0300, a ecrit:
> On 8/27/20 7:07 PM, Jan Beulich wrote:
> > On 27.08.2020 17:49, osstest service owner wrote:
> >> flight 152898 xen-unstable-smoke real [real]
> >> http://logs.test-lab.xenproject.org/osstest/logs/152898/
> >>
> >> Regressions :-(
> >>
>
> the ip parameter because (a) it is not used anywhere and (b) it wastes
> memory since it would reference a dynamically allocated string.
>
> Signed-off-by: Costin Lupu
Reviewed-by: Samuel Thibault
> ---
> stubdom/grub/mini-os.c | 4 +---
> 1 file changed, 1 insertion(+), 3
Hello,
Andrew Cooper via Libc-alpha, le mer. 27 mai 2020 14:39:00 +0100, a ecrit:
> Why does the MSB make any difference? %gs still needs to remain intact
> so the thread pointer can be pulled out, so there is nothing that Xen or
> Linux can do in the way of lazy loading.
>
> Beyond that, its st
>
> Reviewed-by: Jason Andryuk
Acked-by: Samuel Thibault
Thanks!
Olaf Hering, le mer. 17 juin 2020 08:13:49 +0200, a ecrit:
> int hw_is_tpm2(void)
> {
> -return (hardware_version.hw_version == TPM2_HARDWARE) ? 1 : 0;
> +return hardware_version == 2 ? 1 : 0;
> }
Or even
return hardware_version == 2;
?
Either case,
Acked-by:
Hello,
Every month, we are getting a RAID check at the same time as VMs backing
up their data. Yes, probably not a good thing to do, but that should
still be working, and what we see is the whole system gets overly
sluggish since we mark all of these idle-prioritized.
The RAID check is happening
Hello,
Jürgen Groß, le mar. 08 oct. 2024 11:22:11 +0200, a ecrit:
> On 08.10.24 00:13, Samuel Thibault wrote:
> > Juergen Gross, le lun. 07 oct. 2024 12:34:56 +0200, a ecrit:
> > > CONFIG_XC is no longer needed with individual CONFIG_LIBXEN support.
> >
> > I don&#x
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> V2:
> - merge patches of the V1 series (Samuel Thibault)
>
> Note: do not apply to the tree until the related Xen series
> "stubdom: prepare more fine grained Xen library usage" has
dencies instead.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> stubdom/Makefile | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 6ed4253b25..2a81af28a1 100644
> --- a
> diff --git a/stubdom/grub/minios.cfg b/stubdom/grub/minios.cfg
> index 8df49092cd..5145b357e0 100644
> --- a/stubdom/grub/minios.cfg
> +++ b/stubdom/grub/minios.cfg
> @@ -1,3 +1,4 @@
> -CONFIG_START_NETWORK=n
> +CONFIG_LIBC=y
> +CONFIG_LWIP=n
> CONFIG_SPARSE_BSS=n
> CONFIG_TPMFRONT=y
Grub does
Juergen Gross, le lun. 07 oct. 2024 12:34:56 +0200, a ecrit:
> CONFIG_XC is no longer needed with individual CONFIG_LIBXEN support.
I don't really see why in the previous patch you introduced
compatibility and here you remove it?
Samuel
> Remove it, while disabling the CONFIG_LIBXEN items by def
Jürgen Groß, le mar. 08 oct. 2024 11:18:26 +0200, a ecrit:
> On 07.10.24 23:50, Samuel Thibault wrote:
> > > diff --git a/stubdom/grub/minios.cfg b/stubdom/grub/minios.cfg
> > > index 8df49092cd..5145b357e0 100644
> > > --- a/stubdom/grub/minios.cfg
>
, add
> them to the related stubdom Mini-OS config files.
>
> While at it remove the CONFIG_START_NETWORK setting from config files
> disabling lwip, as CONFIG_START_NETWORK requires lwip for becoming
> effective.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thib
Natanael Copa
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> arch/x86/mm.c| 1 +
> arch/x86/setup.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/x86/mm.c b/arch/x86/mm.c
> index 572e762e..3ba6d917 100644
> --- a/arch/x86/m
s been Acked,
> as otherwise it should either be dropped (in case the approach of
> adding a new library is being rejected) or changed (in case the name
> of the new library needs to be modified)!
For the positive case,
Reviewed-by: Samuel Thibault
>
> Config.mk | 2 ++
default setting of CONFIG_XC
> depending on libc being available.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
Thanks!
> ---
> Config.mk | 3 ++-
> arch/x86/testbuild/all-yes| 3 ++-
> arch/x86/testbuild/newxen-yes | 3 ++-
> 3 f
CHN
> and CONFIG_LIBXENGNTTAB config options.
>
> In case CONFIG_XC was specified in the Mini-OS config explicitly, set
> the three new variables to the specified value.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
Thanks!
> ---
> Config.mk | 7
Juergen Gross, le ven. 27 janv. 2023 08:33:46 +0100, a ecrit:
> The test code in xenbus.c can easily be moved into test.c.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> test.c | 108 +++-
&g
Juergen Gross, le ven. 27 janv. 2023 08:32:44 +0100, a ecrit:
> The SUBDIRS make variable has some stale entries, remove them.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Hello,
Juergen Gross, le ven. 03 févr. 2023 10:18:03 +0100, a ecrit:
> +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir,
> + const char *node, unsigned int *value)
> +{
> +char path[BUFFER_SIZE];
> +char *msg;
> +char *str;
> +
> +xenb
e/lib.h, as it is missing
> today.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
Thanks!
> ---
> include/lib.h | 9 ++
> lib/sys.c | 80 +++
> 2 files changed, 70 insertions(+), 19 deletions(-)
>
&
trast to device specific data.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> include/lib.h | 5 +
> lib/sys.c | 50 +-
> 2 files changed, 54 insertions(+), 1 deletion(-)
>
> diff --git
Juergen Gross, le ven. 03 févr. 2023 10:18:04 +0100, a ecrit:
> +int open(const char *pathname, int flags, ...)
> +{
> +unsigned int m, mlen;
> +struct mount_point *mnt;
> +mode_t mode = 0;
> +va_list ap;
> +
> +if ( flags & O_CREAT )
> +{
> +va_start(ap, flags);
> +
Juergen Gross, le ven. 03 févr. 2023 10:18:06 +0100, a ecrit:
> +void *init_9pfront(unsigned int id, const char *mnt)
> +{
[...]
> +free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events));
Better check for errors, otherwise the rest will hang without useful
feedback.
> +for (
Juergen Gross, le ven. 03 févr. 2023 10:18:07 +0100, a ecrit:
> +/*
> + * Using an opportunistic approach for receiving data: in case multiple
> + * requests are outstanding (which is very unlikely), we nevertheless need
> + * to consume all data available until we reach the desired request.
> + *
Juergen Gross, le lun. 06 févr. 2023 10:22:10 +0100, a ecrit:
> On 06.02.23 10:01, Samuel Thibault wrote:
> > Juergen Gross, le ven. 03 févr. 2023 10:18:06 +0100, a ecrit:
> > > +void *init_9pfront(unsigned int id, const char *mnt)
> > > +{
> > [...]
> > >
Juergen Gross, le ven. 03 févr. 2023 10:18:08 +0100, a ecrit:
> +static unsigned int get_fid(struct dev_9pfs *dev)
> +{
> +unsigned int fid;
> +
> +fid = ffs(dev->fid_mask);
> +if ( fid )
> +dev->fid_mask &= 1ULL << (fid - 1);
Isn't that missing a ~ ?
> @@ -459,6 +522,134 @@ s
Juergen Gross, le ven. 03 févr. 2023 10:18:09 +0100, a ecrit:
> This patch is missing the limitation of read/write messages to stay
> below the max. supported message size.
It should at least be asserted.
> +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset,
> +
Hello,
Juergen Gross, le ven. 03 févr. 2023 10:18:02 +0100, a ecrit:
> This series is adding minimal support to use 9pfs in Mini-OS. It is
> adding a PV 9pfs frontend and the ability to open, close, read and
> write files.
Nice, thanks! :)
Samuel
Juergen Gross, le lun. 06 févr. 2023 11:17:27 +0100, a ecrit:
> On 06.02.23 11:13, Samuel Thibault wrote:
> >
> > Juergen Gross, le ven. 03 févr. 2023 10:18:09 +0100, a ecrit:
> > > This patch is missing the limitation of read/write messages to stay
> > > belo
Juergen Gross, le ven. 10 févr. 2023 13:14:20 +0100, a ecrit:
> On 10.02.23 12:43, Andrew Cooper wrote:
> > On 10/02/2023 10:46 am, Juergen Gross wrote:
> > > diff --git a/lib/sys.c b/lib/sys.c
> > > index 2f33c937..dc8a8c69 100644
> > > --- a/lib/sys.c
> > > +++ b/lib/sys.c
> > > @@ -339,7 +339,14
: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> V2:
> - check sscanf() return value (Samuel Thibault)
> ---
> include/xenbus.h | 6 ++
> xenbus.c | 40 +---
> 2 files changed, 43 insertions(+), 3 deletions(-)
>
&g
e/lib.h, as it is missing
> today.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> V2:
> - pass path below mount point to open callbacks (Samuel Thibault)
> ---
> include/lib.h | 9 ++
> lib/sys.c | 80 +++--
ility to access files) the whole code is guarded
> by "#ifdef HAVE_LIBC".
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> V2:
> - add better error handling to version parsing (Samuel Thibault)
> ---
> 9pfront.c | 28
sts of the 9pfs
> protocol when mounting a new 9pfs device. For the version use the
> "9P2000.u" variant, as it is the smallest subset supported by the qemu
> based backend.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> V2:
> - add more comm
Juergen Gross, le ven. 10 févr. 2023 11:46:27 +0100, a ecrit:
> +static bool path_canonical(const char *pathname)
> +{
> +unsigned int len = strlen(pathname);
> +const char *c;
> +
> +/* Empty path is allowed. */
> +if ( !len )
> +return true;
> +
> +/* No trailing '/'.
Juergen Gross, le ven. 10 févr. 2023 11:46:28 +0100, a ecrit:
> +while ( len )
> +{
> +count = len;
> +if ( count > dev->msize_max - 24 )
> +count = dev->msize_max - 24;
24 should be detailed, to include e.g. sizeof(p9_header) and the sum of
sizes of the fields
Juergen Gross, le lun. 13 févr. 2023 09:44:11 +0100, a ecrit:
> Add the open() and close() support to the 9pfs frontend. This requires
> to split the path name and to walk to the desired directory level.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
>
Juergen Gross, le lun. 13 févr. 2023 09:44:12 +0100, a ecrit:
> Add support to read from and write to a file handled by 9pfsfront.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
> ---
> V2:
> - add check for max message size
> - return EAGAIN in case no fre
orting the 9P2000.u variant,
> as qemu doesn't support the basic 9P2000 protocol).
>
> The needed fixed values of the protocol have been taken from [2].
>
> [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html
> [2]: https://github.com/0intro/libixp
>
> Changes in V2:
Hello,
Juergen Gross, le sam. 18 juin 2022 12:48:16 +0200, a ecrit:
> @@ -124,7 +126,7 @@ void arch_mm_preinit(void *p)
> do_exit();
> }
>
> -last_free_pfn = e820_get_maxpfn(ret);
> +last_free_pfn = e820_get_maxpfn(ret - e820_initial_reserved_pfns);
Mmm, but the reserved p
1 - 100 of 297 matches
Mail list logo
