[PATCH v3 03/12] xen/arm: Pass struct kernel_info parameter to make_{resv,shm}_memory_node

2024-04-18 Thread Luca Fancellu
. Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel --- v3: - Fix commit title/msg, add Michal R-by v2: - new patch --- --- xen/arch/arm/dom0less-build.c | 3 +-- xen/arch/arm/domain_build.c | 3 +-- xen/arch/arm/include/asm/static-shmem.h | 9 - xen/arch/arm

[PATCH v3 01/12] xen/arm: remove stale addr_cells/size_cells in assign_shared_memory

2024-04-18 Thread Luca Fancellu
From: Penny Zheng Function parameters {addr_cells,size_cells} are stale parameters in assign_shared_memory, so we shall remove them. Signed-off-by: Penny Zheng Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel --- v2: - no change v1: - This is this patch: https://patchwork.kernel.org

[PATCH v3 06/12] xen/arm: Avoid code duplication in find_unallocated_memory

2024-04-18 Thread Luca Fancellu
be introduced as a separate structure from reserved memory. Take the occasion to add the error code to the error message in case 'rangeset_remove_range' fails. Signed-off-by: Luca Fancellu --- v3: - Fixed the wrong logic, now the function correctly adds the available ram to the ra

[PATCH v3 08/12] xen/arm: Introduce helper for static memory pages

2024-04-18 Thread Luca Fancellu
banks will be removed from reserved_mem. Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel --- v2: - Add Michal R-by - Changed commit msg v1: - new patch --- --- xen/arch/arm/include/asm/static-memory.h | 13 + xen/arch/arm/static-memory.c | 12 +--- 2 files

[PATCH v3 07/12] xen/arm: Avoid code duplication in check_reserved_regions_overlap

2024-04-18 Thread Luca Fancellu
The function check_reserved_regions_overlap is calling 'meminfo_overlap_check' on the same type of structure, this code can be written in a way to avoid code duplication, so rework the function to do that. Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel --- v3: - add Mich

[PATCH v3 10/12] xen/arm: remove shm holes from extended regions

2024-04-18 Thread Luca Fancellu
shm info from "kinfo", we use "remove_shm_from_rangeset" to remove static shm. For direct-map domain with iommu off, as static shm has already been taken care of through find_unallocated_memory, we do nothing. Signed-off-by: Penny Zheng Signed-off-by: Luca Fancellu --- v3: - Put size -1

[PATCH v3 09/12] xen/arm: Reduce struct membank size on static shared memory

2024-04-18 Thread Luca Fancellu
membanks common' of 'struct shared_meminfo'. The last part of this work is to move the allocation of the static shared memory banks from the 'reserved_mem' to a new 'shmem' member of the 'struct bootinfo'. Change also the 'shm_mem' member type

[PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-18 Thread Luca Fancellu
to remove the unused struct domain parameter. Signed-off-by: Luca Fancellu --- v3: - removed previous patch that was merging the intervals, rebase changes. v2: - try to use make_memory_node, don't add overlapping ranges of memory, commit message changed. v1: - new patch --- --

Re: [PATCH v2 12/13] xen/device_tree: Introduce function to merge overlapping intervals

2024-04-18 Thread Luca Fancellu
> On 18 Apr 2024, at 07:28, Jan Beulich wrote: > > On 09.04.2024 13:45, Luca Fancellu wrote: >> --- a/xen/arch/x86/extable.c >> +++ b/xen/arch/x86/extable.c >> @@ -23,7 +23,8 @@ static inline unsigned long ex_cont(const struct >> exception_table_ent

[PATCH v3 11/12] xen/arm: fix duplicate /reserved-memory node in Dom0

2024-04-18 Thread Luca Fancellu
make_shm_resv_memory_node to make clear it produces childs for /reserved-memory. Signed-off-by: Penny Zheng Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel --- v2: - fix comment, remove function signature change, fixed commit msg - rename make_shm_memory_node to make_shm_resv_memory_node in

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Luca Fancellu
Hi Michal, >> +for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells += >> reg_size ) >> +{ >> +u64 start = dt_read_number(cells, addrcells); > We should no longer use Linux derived types like u64. Use uint64_t. > >> +u64 size = dt_read_number(cells + addrcells, si

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Luca Fancellu
> On 22 Apr 2024, at 11:24, Julien Grall wrote: > > Hi, > > On 22/04/2024 10:26, Michal Orzel wrote: >> On 22/04/2024 10:07, Luca Fancellu wrote: >>> >>> >>> Hi Michal, >>> >>>>> +for ( c

[PATCH v3.2 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Luca Fancellu
to remove the unused struct domain parameter. Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel --- v3.2: - changed u64 to uint64_t and used %u as format specifier for var i in make_memory_node, changed u64 to paddr_t in shm_mem_node_fill_reg_range, add Michal R-by v3: - removed prev

[PATCH 1/7] xen/arm: Lookup bootinfo shm bank during the mapping

2024-04-23 Thread Luca Fancellu
e bank doesn't need to be allocated, however it will be convinient later to use it as an argument for assign_shared_memory when dealing with the use case where the Host physical address is not supplied by the user. Signed-off-by: Luca Fancellu --- xen/arch/arm/static-shmem.c | 105 ++

[PATCH 0/7] Static shared memory followup v2 - pt2

2024-04-23 Thread Luca Fancellu
/xen-devel/patch/20240422110207.204968-1-luca.fance...@arm.com/ Luca Fancellu (5): xen/arm: Lookup bootinfo shm bank during the mapping xen/arm: Wrap shared memory mapping code in one function xen/arm: Parse xen,shared-mem when host phys address is not provided xen/arm: Rework heap page

[PATCH 6/7] xen/arm: Implement the logic for static shared memory from Xen heap

2024-04-23 Thread Luca Fancellu
om the heap and if it is, then assign_pages is called for every bank. When the bank is already allocated, for every bank allocated with the corresponding shm_id, handle_shared_mem_bank is called and the mapping are done. Signed-off-by: Luca Fancellu --- xen/arch/arm/static-shmem.c | 193 ++

[PATCH 4/7] xen/arm: Parse xen,shared-mem when host phys address is not provided

2024-04-23 Thread Luca Fancellu
's unlikely for these bank to have the start address as INVALID_PADDR. The change holds because of this consideration. Signed-off-by: Luca Fancellu --- xen/arch/arm/setup.c| 3 +- xen/arch/arm/static-shmem.c | 129 +--- 2 files changed, 93 inserti

[PATCH 7/7] xen/docs: Describe static shared memory when host address is not provided

2024-04-23 Thread Luca Fancellu
From: Penny Zheng This commit describe the new scenario where host address is not provided in "xen,shared-mem" property and a new example is added to the page to explain in details. Take the occasion to fix some typos in the page. Signed-off-by: Penny Zheng Signed-off-by: Luc

[PATCH 2/7] xen/arm: Wrap shared memory mapping code in one function

2024-04-23 Thread Luca Fancellu
Wrap the code and logic that is calling assign_shared_memory and map_regions_p2mt into a new function 'handle_shared_mem_bank', it will become useful later when the code will allow the user to don't pass the host physical address. Signed-off-by: Luca Fancellu --- xen/arch/arm

[PATCH 3/7] xen/p2m: put reference for superpage

2024-04-23 Thread Luca Fancellu
helping put extra references for foreign superpages. Signed-off-by: Penny Zheng Signed-off-by: Luca Fancellu --- v1: - patch from https://patchwork.kernel.org/project/xen-devel/patch/20231206090623.1932275-9-penny.zh...@arm.com/ --- xen/arch/arm/mmu/p2m.c | 58

[PATCH 5/7] xen/arm: Rework heap page allocation outside allocate_bank_memory

2024-04-23 Thread Luca Fancellu
change the signature of allocate_bank_memory and remove the 'struct domain' parameter, which can be retrieved from 'struct kernel_info'. No functional changes is intended. Signed-off-by: Luca Fancellu --- xen/arch/arm/dom0less-build.c | 4 +- xen/arch/arm/domain_buil

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-24 Thread Luca Fancellu
Hi Julien, > > Rest LGTM: > Reviewed-by: Michal Orzel Thanks, I will send the next one shortly. >>> I don't think there is a need to respin the whole series just for these >>> fixes. >>> You should wait for the committers opinion. >> AFAICT, there are multiple cha

[RFC PATCH 1/2] xen/arm: Add DT reserve map regions to bootinfo.reserved_mem

2024-04-25 Thread Luca Fancellu
. Signed-off-by: Luca Fancellu --- xen/arch/arm/arm32/mmu/mm.c | 29 + xen/arch/arm/bootfdt.c | 51 ++ xen/arch/arm/domain_build.c | 3 +- xen/arch/arm/include/asm/setup.h | 5 +++ xen/arch/arm/setup.c | 53

[RFC PATCH 0/2] xen/arm: Remove recursion from dt_unreserved_regions

2024-04-25 Thread Luca Fancellu
and have just a loop that can go through all the different structures. Comments are welcome. Luca Fancellu (2): xen/arm: Add DT reserve map regions to bootinfo.reserved_mem xen/arm: Rework dt_unreserved_regions to avoid recursion xen/arch/arm/arm32/mmu/mm.c | 29

[RFC PATCH 2/2] xen/arm: Rework dt_unreserved_regions to avoid recursion

2024-04-25 Thread Luca Fancellu
iterative algorithm with the same result. The function was taking an additional parameter 'first', but given the rework and given that the function was always initially called with this parameter as zero, remove the parameter and update the codebase to reflect the change. Signed-off-by: Luc

Re: [XEN PATCH] automation/eclair: reorganize pipelines

2024-04-26 Thread Luca Fancellu
t; Is this patch safe to commit now? Or would it cause gitlab-ci breakage? >> Yes, it is safe because the ECLAIR analysis is still allowed to fail. >> Committing this patch wouldn't break the CI but it will highlight some >> regressions with the orange badge and the followi

[PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-04-30 Thread Luca Fancellu
t rid the open-coding shm_mem.common access. Fixes: 2209c1e35b47 ("xen/arm: Introduce a generic way to access memory bank structures") Signed-off-by: Luca Fancellu --- xen/arch/arm/acpi/domain_build.c| 2 +- xen/arch/arm/domain_build.c | 6 +++--- xen/arch/arm/incl

[PATCH 0/2] Fix MISRA regression about flexible array member not at the end

2024-04-30 Thread Luca Fancellu
serie. [1] https://lore.kernel.org/all/8be082b6d22d61c0b14910680d383...@bugseng.com/ Luca Fancellu (2): xen/kernel.h: Import __struct_group from Linux xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end xen/arch/arm/acpi/domain_build.c| 2 +- xen/arc

[PATCH 1/2] xen/kernel.h: Import __struct_group from Linux

2024-04-30 Thread Luca Fancellu
our on the struct foo. This construct will become useful in order to have some generalized interfaces that shares some common members. Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 50d7bd38c3aa Signed-off-by: Luca Fancellu --- xen/include/xen/kernel.h | 21 ++

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-22 Thread Luca Fancellu
> On 21 Nov 2023, at 20:41, Andrew Cooper wrote: > > On 21/11/2023 8:33 pm, Luca Fancellu wrote: >> + CC henry >> >>> On 21 Nov 2023, at 20:15, Andrew Cooper wrote: >>> >>> -Wwrite-strings is unhappy with assigning "xen" to a mutable

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-23 Thread Luca Fancellu
> On 22 Nov 2023, at 18:03, Andrew Cooper wrote: > > On 22/11/2023 3:49 pm, Luca Fancellu wrote: >> >>> On 21 Nov 2023, at 20:41, Andrew Cooper wrote: >>> >>> On 21/11/2023 8:33 pm, Luca Fancellu wrote: >>>> + CC henry >

Re: [PATCH] xen/efi: Drop image_name from efi_arch_handle_cmdline()

2023-11-23 Thread Luca Fancellu
Monné > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Michal Orzel > --- > xen/arch/arm/efi/efi-boot.h | 3 +-- Tested on ARM board Tested-by: Luca Fancellu

Clang-format configuration discussion - pt 2

2023-11-23 Thread Luca Fancellu
Hi all, Let’s continue the discussion about clang-format configuration, this is part 2, previous discussions are: - https://lists.xenproject.org/archives/html/xen-devel/2023-11/msg00498.html You can find the serie introducing clang-format here: https://patchwork.kernel.org/project/xen-devel/co

[PATCH v6 2/5] xen/arm: Add asm/domain.h include to kernel.h

2023-11-24 Thread Luca Fancellu
to avoid relying on it. So add the include in 'asm/domain.h'. Signed-off-by: Luca Fancellu Acked-by: Julien Grall --- Changes from v2: - add Ack-by Julien Changes from v1: - Rephrased commit message (Julien) --- xen/arch/arm/include/asm/kernel.h | 1 + 1 file changed, 1 insertion(+) dif

[PATCH v6 4/5] xen/arm: Move static memory build code in separate modules

2023-11-24 Thread Luca Fancellu
functional changes are intended. Signed-off-by: Luca Fancellu --- Changes from v5: - removed init_staticmem_pages prototype from setup.h, add static-memory.h include in arm{32,64}/mmu/mm.c, dropped Michal R-by given the changes Changes from v4: - Removed header from static-*.{c,h} files, f

[PATCH v6 1/5] arm/gicv2: make GICv2 driver and vGICv2 optional

2023-11-24 Thread Luca Fancellu
optional and can be deselected if the user doesn't want to offer the v2 emulation to domains or maybe its GICv3 hardware can't offer the GICv2 compatible mode. Signed-off-by: Luca Fancellu Reviewed-by: Julien Grall Reviewed-by: Michal Orzel --- Changes from v2: - No changes --- xe

[PATCH v6 5/5] arm/dom0less: introduce Kconfig for dom0less feature

2023-11-24 Thread Luca Fancellu
code when the Kconfig is not enabled, do the same for allocate_bank_memory inside domain_build.c that currently is used only by dom0less-build.c module, but it's kept there provisioning its usage by dom0 code. Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel --- Changes from v5: - styl

[PATCH v6 0/5] Fine granular configuration

2023-11-24 Thread Luca Fancellu
there and do the proper rework. Luca Fancellu (5): arm/gicv2: make GICv2 driver and vGICv2 optional xen/arm: Add asm/domain.h include to kernel.h arm/dom0less: put dom0less feature code in a separate module xen/arm: Move static memory build code in separate modules arm/dom0less: introdu

[PATCH v6 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-11-24 Thread Luca Fancellu
.c in case that in the future the dom0 code can use it. Where spotted, fix code style issues. No functional change is intended. Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel --- Changes from v5: - remove unneeded include (Michal) - rebase on staging Changes from v4: - fixed na

Re: [PATCH v6 0/5] Fine granular configuration

2023-11-24 Thread Luca Fancellu
+ CC Maintainers > On 24 Nov 2023, at 09:48, Luca Fancellu wrote: > > This serie aims to add more modularity to some feature that can be excluded > without issues from the build. > > The first patch is already reviewed. > > v2 update: So I've tried to see how to

Re: Clang-format configuration discussion - pt 2

2023-11-24 Thread Luca Fancellu
> On 24 Nov 2023, at 11:12, George Dunlap wrote: > > On Thu, Nov 23, 2023 at 2:48 PM Luca Fancellu wrote: >> AlignConsecutiveAssignments: None >> >> --- >> This one is disabled because of feedbacks from Stefano and Alejandro about >> some weird behavi

Re: Clang-format configuration discussion - pt 2

2023-11-24 Thread Luca Fancellu
> On 24 Nov 2023, at 12:24, Jan Beulich wrote: > > On 24.11.2023 12:59, Luca Fancellu wrote: >> @@ -,19 +3318,18 @@ static int __init alloc_domain_evtchn(struct >> dt_device_node *node) >> rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); >> if (

Re: Clang-format configuration discussion - pt 2

2023-11-24 Thread Luca Fancellu
> On 24 Nov 2023, at 12:47, Jan Beulich wrote: > > On 23.11.2023 15:47, Luca Fancellu wrote: >> Hi all, >> >> Let’s continue the discussion about clang-format configuration, this is part >> 2, previous discussions are: >> >> - https://lists.x

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Luca Fancellu
> On 27 Nov 2023, at 12:20, Jan Beulich wrote: > > On 24.11.2023 15:52, Luca Fancellu wrote: >>> On 24 Nov 2023, at 12:47, Jan Beulich wrote: >>> On 23.11.2023 15:47, Luca Fancellu wrote: >>>> Let’s continue the discussion about clang-format config

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Luca Fancellu
> On 27 Nov 2023, at 15:13, Jan Beulich wrote: > > On 27.11.2023 15:58, Luca Fancellu wrote: >>> On 27 Nov 2023, at 12:20, Jan Beulich wrote: >>> On 24.11.2023 15:52, Luca Fancellu wrote: >>>>> On 24 Nov 2023, at 12:47, Jan Beulich wrote: >

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Luca Fancellu
> On 27 Nov 2023, at 15:55, Jan Beulich wrote: > > On 27.11.2023 16:37, Luca Fancellu wrote: >> >> >>> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >>> >>> On 27.11.2023 15:58, Luca Fancellu wrote: >>>>> On 27 Nov 2023, at 12:2

Re: [PATCH v6 0/5] Fine granular configuration

2023-11-28 Thread Luca Fancellu
> On 24 Nov 2023, at 09:59, Luca Fancellu wrote: > > + CC Maintainers > >> On 24 Nov 2023, at 09:48, Luca Fancellu wrote: >> >> This serie aims to add more modularity to some feature that can be excluded >> without issues from the build. >&g

Re: Clang-format configuration discussion - pt 2

2023-11-28 Thread Luca Fancellu
> On 27 Nov 2023, at 15:37, Luca Fancellu wrote: > > > >> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >> >> On 27.11.2023 15:58, Luca Fancellu wrote: >>>> On 27 Nov 2023, at 12:20, Jan Beulich wrote: >>>> On 24.11.2023 15:52, Luc

Re: Clang-format configuration discussion - pt 2

2023-11-28 Thread Luca Fancellu
> On 28 Nov 2023, at 11:27, Jan Beulich wrote: > > On 28.11.2023 11:55, Luca Fancellu wrote: >> >> >>> On 27 Nov 2023, at 15:37, Luca Fancellu wrote: >>> >>> >>> >>>> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >&

Re: [PATCH v6 0/5] Fine granular configuration

2023-11-28 Thread Luca Fancellu
> On 28 Nov 2023, at 12:38, Michal Orzel wrote: > > Hi Luca, > > On 28/11/2023 11:36, Luca Fancellu wrote: >> >> >>> On 24 Nov 2023, at 09:59, Luca Fancellu wrote: >>> >>> + CC Maintainers >>> >>>> On 24 Nov 2

Re: [PATCH v6 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-11-28 Thread Luca Fancellu
> On 28 Nov 2023, at 18:25, Julien Grall wrote: > > Hi, > > On 24/11/2023 12:01, Michal Orzel wrote: >> On 24/11/2023 10:48, Luca Fancellu wrote: >>> >>> >>> Currently the dom0less feature code is mostly inside domain_build.c >>&g

Re: [PATCH v2] xen/arm: Move static event channel feature to a separate module

2023-11-30 Thread Luca Fancellu
; Signed-off-by: Michal Orzel > --- Hi Michal, FWIW because it is already Ack-ed. Reviewed-by: Luca Fancellu

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-04 Thread Luca Fancellu
> On 1 Dec 2023, at 18:49, Julien Grall wrote: > > > > On 01/12/2023 18:47, Julien Grall wrote: >> From: Julien Grall >> Several maintainers have expressed a stronger preference >> to use '-' when in filename and option that contains multiple >> words. >> So document it in CODING_STYLE. >> S

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-04 Thread Luca Fancellu
> On 4 Dec 2023, at 11:31, Julien Grall wrote: > > Hi Luca, > > On 04/12/2023 11:20, Luca Fancellu wrote: >>> On 1 Dec 2023, at 18:49, Julien Grall wrote: >>> >>> >>> >>> On 01/12/2023 18:47, Julien Grall wrote: >>>>

SAF-* comment at the end of the line

2023-12-05 Thread Luca Fancellu
Hi all, I’m writing this mail to collect thoughts about the need to improve the SAF-* comments. I think we reached a point where we need to use deviations for some violation that we want to keep in the code with a proper justification and an issue was raised when the comment cannot be put on a

Re: Clang-format configuration discussion - pt 2

2023-12-05 Thread Luca Fancellu
> On 23 Nov 2023, at 14:47, Luca Fancellu wrote: > > Hi all, > > Let’s continue the discussion about clang-format configuration, this is part > 2, previous discussions are: > > - https://lists.xenproject.org/archives/html/xen-devel/2023-11/msg00498.html >

Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json

2023-12-19 Thread Luca Fancellu
, >>>> +{ >>>> + "rel_path": "include/acpi/acmacros.h", >>>> + "comment": "Imported from Linux, ignore for now" >>>> +}, >>> Together with what's already there (in context), wouldn't it

Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json

2023-12-20 Thread Luca Fancellu
> On 20 Dec 2023, at 08:41, Jan Beulich wrote: > > On 20.12.2023 01:17, Stefano Stabellini wrote: >> On Tue, 19 Dec 2023, Luca Fancellu wrote: >>>> On 19 Dec 2023, at 11:05, Nicola Vetrini >>>> wrote: >>>> On 2023-12-19 11:51, Nicola Ve

Re: [PATCH v2 0/3] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-20 Thread Luca Fancellu
Hi Ayan, > On 18 Dec 2023, at 20:29, Ayan Kumar Halder wrote: > > Hi, > > Refer > https://lore.kernel.org/all/alpine.DEB.2.22.394.2312071341540.1265976@ubuntu-linux-20-04-desktop/T/ > for the previous discussion on this issue. > > Also, the linux earlycon hvc driver has been fixed. > See > h

Re: [PATCH v2 1/3] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-20 Thread Luca Fancellu
> On 18 Dec 2023, at 20:32, michal.or...@amd.com wrote: > > From: Michal Orzel > > Currently if user enables HVC_DCC config option in Linux, it invokes > access to debug data transfer registers (ie MDCCSR_EL0 on arm64, > DBGDTRTXINT on arm32). As these registers are not emulated, Xen injects >

Re: [PATCH v2 0/3] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-20 Thread Luca Fancellu
> On 20 Dec 2023, at 09:29, Luca Fancellu wrote: > > Hi Ayan, > >> On 18 Dec 2023, at 20:29, Ayan Kumar Halder >> wrote: >> >> Hi, >> >> Refer >> https://lore.kernel.org/all/alpine.DEB.2.22.394.2312071341540.1265976@ubuntu-linux-2

Re: [PATCH v2 0/3] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-20 Thread Luca Fancellu
> > I wanted to keep Michal's change for the arm64 as it is. And introduce > Kconfig and command line in separate patches. > > But I agree, it does not look clean. > > > I am fine to follow your suggestion ie (Option 1) > > Patch 1 ---> arm64 changes + Kconfig + cmd_line (authored by Michal)

Re: Clang-format configuration discussion - pt 2

2024-01-08 Thread Luca Fancellu
> I found the way we dealt with MISRA rules quite helpful. We had a weekly meeting to discuss some of the rules and then the outcome was posted on the ML. Maybe we should do the same here? Any other suggestion how to move? >>> >>> I have mixed feelings with meetings like the M

[PATCH 2/3] xen-analysis.py: Substitute only the comment instead of the line

2024-01-31 Thread Luca Fancellu
Change the code in tag_database.py to substitute only the SAF-* comment instead of replacing the line. Signed-off-by: Luca Fancellu --- xen/scripts/xen_analysis/tag_database.py | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/xen/scripts/xen_analysis

[PATCH 3/3] xen-analysis.py: Accept deviation comment at the end of the line

2024-01-31 Thread Luca Fancellu
straighforward, but the other tool needs to translate an occurrence of the tag into a suppressino comment at the end of the previous line, this will have a corner case where the line number 1 of the file can't be deviated in this way for such tools. Updated documentation. Signed-off-by: Luca Fan

[PATCH 0/3] xen-analysis.py: Enable Xen deviation tag at the end of the line

2024-01-31 Thread Luca Fancellu
ine: if ( (expression) && ((expression with violation) || /* SAF--safe deviate the bla bla bla */ (expression) ) { [...] } This clearly brings up the question about the code style line length, which in this case needs to be amended for Xen deviation tags that goes above the limit.

[PATCH 1/3] xen-analysis.py: Use named group for tag regex

2024-01-31 Thread Luca Fancellu
Use named group for the regex matching a tag identifier, this is done to ease retrieving the matching group instead of using an index. Signed-off-by: Luca Fancellu --- xen/scripts/xen_analysis/cppcheck_analysis.py | 4 ++-- xen/scripts/xen_analysis/tag_database.py | 24

Re: [PATCH] xen/arm: Fix UBSAN failure in start_xen()

2024-02-08 Thread Luca Fancellu
. > > Signed-off-by: Michal Orzel > --- Hi Michal, I’ve tested this change with qemu for arm32 and arm64, looks good to me: Reviewed-by: Luca Fancellu Tested-by: Luca Fancellu

Re: [PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

2024-02-13 Thread Luca Fancellu
> On 13 Feb 2024, at 15:27, Jan Beulich wrote: > > On 13.02.2024 16:08, Petr Beneš wrote: >>> On Tue, Feb 13, 2024 at 4:02 PM Jan Beulich wrote: >>> >>> On 13.02.2024 15:56, Petr Beneš wrote: From: Petr Beneš It's located in libxl_domain_build_info, not libxl_domain_create_in

Re: [PATCH] xen/arm: Make hwdom vUART optional feature

2024-02-15 Thread Luca Fancellu
with and without vuart on qemu arm64. Reviewed-by: Luca Fancellu Tested-by: Luca Fancellu

Re: [PATCH] docs/misra/rules.rst: Fix entry for 20.12 rule

2024-03-01 Thread Luca Fancellu
doc.py: > No summary for rule 20.12 > > Fixes: 4cac80e22600 ("docs/misra/rules.rst: add rule 16.6 and 20.12") > Signed-off-by: Michal Orzel > --- > Failed pipeline: > https://gitlab.com/xen-project/xen/-/pipelines/1196428827 > --- Reviewed-by: Luca Fancellu

[PATCH] xen/arm: Add workaround for Cortex-A53 erratum #843419

2020-12-10 Thread Luca Fancellu
workaround is to enable the linker flag --fix-cortex-a53-843419 if present, to check and fix the affected sequence. Otherwise print a warning that Xen may be susceptible to this errata Signed-off-by: Luca Fancellu --- docs/misc/arm/silicon-errata.txt | 1 + xen/arch/arm/Kconfig | 19

[RFC PATCH] xen/design: Add design for EFI dom0less system start

2021-09-06 Thread Luca Fancellu
Add a design describing a proposal to improve the EFI configuration file, adding keywords to describe domU guests and allowing to start a dom0less system. Signed-off-by: Luca Fancellu --- docs/designs/efi-arm-dom0less.md | 105 +++ 1 file changed, 105 insertions

Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start

2021-09-07 Thread Luca Fancellu
> On 7 Sep 2021, at 10:24, Jan Beulich wrote: > > On 07.09.2021 11:17, Julien Grall wrote: >> On 07/09/2021 09:33, Jan Beulich wrote: >>> I'd like to suggest a different scheme, not the least because I expect >>> the individual domains being independent of e.g. hypervisor command >>> line opti

Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start

2021-09-07 Thread Luca Fancellu
> On 7 Sep 2021, at 10:35, Julien Grall wrote: > > Hi Luca, > > On 07/09/2021 07:52, Luca Fancellu wrote: >> Add a design describing a proposal to improve the EFI >> configuration file, adding keywords to describe domU >> guests and allowing to start a dom0le

Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start

2021-09-07 Thread Luca Fancellu
> On 7 Sep 2021, at 13:30, Julien Grall wrote: > > > > On 07/09/2021 12:51, Luca Fancellu wrote: >>> On 7 Sep 2021, at 10:35, Julien Grall wrote: >>> >>> Hi Luca, >>> >>> On 07/09/2021 07:52, Luca Fancellu wrote

Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start

2021-09-07 Thread Luca Fancellu
> On 7 Sep 2021, at 15:18, Julien Grall wrote: > > Hi Luca, > > On 07/09/2021 14:30, Luca Fancellu wrote: >>> On 7 Sep 2021, at 13:30, Julien Grall wrote: >>> On 07/09/2021 12:51, Luca Fancellu wrote: >>>>> On 7 Sep 2021, at 10:35, Julien Gra

Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start

2021-09-07 Thread Luca Fancellu
> On 8 Sep 2021, at 02:09, Stefano Stabellini wrote: > > On Tue, 7 Sep 2021, Julien Grall wrote: >> On 07/09/2021 12:51, Luca Fancellu wrote: >>>> On 7 Sep 2021, at 10:35, Julien Grall wrote: >>>> >>>> Hi Luca, >>>> &g

Re: Xen Booting Problem on ARM Machine

2021-09-08 Thread Luca Fancellu
> On 8 Sep 2021, at 11:46, Sai Kiran wrote: > > > > Hello, > > I have Xen-4.15.0 on an ARM Machine, with Debian 11 installed on it. I am > able to do “make world” and “make install”, after “./configure”, as specified > in README file. When I reboot the system, I get the following message

[PATCH 0/2] arm/efi: Add dom0less support to UEFI boot

2021-09-15 Thread Luca Fancellu
cture. Luca Fancellu (2): xen/efi: Restrict check for DT boot modules on EFI boot arm/efi: Use dom0less configuration when using EFI boot docs/misc/efi.pandoc| 37 + xen/arch/arm/efi/efi-boot.h | 274 +++- xen/common/efi/boot.c | 20 ++- 3

[PATCH 1/2] xen/efi: Restrict check for DT boot modules on EFI boot

2021-09-15 Thread Luca Fancellu
When Xen is started as EFI application, it is checking the presence of multiboot,module in the DT, if any is found, the configuration file is skipped. Restrict this check to just any multiboot,module that is a direct child of the /chosen node. Signed-off-by: Luca Fancellu --- xen/arch/arm/efi

[PATCH 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-15 Thread Luca Fancellu
quot;xen,domain" compatible nodes. The property holds a string containing the file name of the binary that shall be loaded by the uefi loader from the filesystem. Update efi documentation about how to start a dom0less setup using UEFI Signed-off-by: Luca Fancellu --- docs/misc/efi.pandoc

Re: [PATCH v2] xen/sched: fix sched_move_domain() for domain without vcpus

2021-09-15 Thread Luca Fancellu
; Fix that by tolerating vcpus not being allocated yet. > > Fixes: 70fadc41635b9b6 ("xen/cpupool: support moving domain between cpupools > with different granularity") > Reported-by: Bertrand Marquis > Signed-off-by: Juergen Gross Reviewed-by: Luca Fancellu > --- &g

Re: [PATCH 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-16 Thread Luca Fancellu
> On 16 Sep 2021, at 07:50, Jan Beulich wrote: > > On 16.09.2021 03:16, Stefano Stabellini wrote: >> On Wed, 15 Sep 2021, Luca Fancellu wrote: >>> +static void __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle, >>> +

Re: [PATCH 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-16 Thread Luca Fancellu
> On 16 Sep 2021, at 09:46, Jan Beulich wrote: > > A number of nits, sorry: > > On 15.09.2021 16:26, Luca Fancellu wrote: >> --- a/xen/arch/arm/efi/efi-boot.h >> +++ b/xen/arch/arm/efi/efi-boot.h >> @@ -8,9 +8,39 @@ >> #include >> #include

Re: [PATCH 1/2] xen/efi: Restrict check for DT boot modules on EFI boot

2021-09-16 Thread Luca Fancellu
> On 16 Sep 2021, at 01:16, Stefano Stabellini wrote: > > Adding Jan for an opinion on the EFI common code changes. See below. > > > On Wed, 15 Sep 2021, Luca Fancellu wrote: >> When Xen is started as EFI application, it is checking >> the presence of multibo

Re: [PATCH 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-16 Thread Luca Fancellu
> On 16 Sep 2021, at 02:16, Stefano Stabellini wrote: > > On Wed, 15 Sep 2021, Luca Fancellu wrote: >> This patch introduces the support for dom0less configuration >> when using UEFI boot on ARM, it permits the EFI boot to >> continue if no dom0 kernel is specified

Re: [PATCH 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-16 Thread Luca Fancellu
> On 16 Sep 2021, at 13:15, Jan Beulich wrote: > > On 16.09.2021 13:28, Luca Fancellu wrote: >>> On 16 Sep 2021, at 09:46, Jan Beulich wrote: >>> On 15.09.2021 16:26, Luca Fancellu wrote: >>>> --- a/xen/arch/arm/efi/efi-boot.h >>>> +

Re: [PATCH 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-17 Thread Luca Fancellu
> On 16 Sep 2021, at 21:16, Stefano Stabellini wrote: > > On Thu, 16 Sep 2021, Jan Beulich wrote: >> On 16.09.2021 17:07, Luca Fancellu wrote: >>> I explain here my understanding on dom0less, this feature is used to start >>> domUs at >>> Xen boot

Re: [PATCH 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-21 Thread Luca Fancellu
> On 17 Sep 2021, at 23:33, Stefano Stabellini wrote: > > On Fri, 17 Sep 2021, Luca Fancellu wrote: >>> On 16 Sep 2021, at 21:16, Stefano Stabellini wrote: >>> >>> On Thu, 16 Sep 2021, Jan Beulich wrote: >>>> On 16.09.2021 17:07, Luca Fancellu

Re: [PATCH 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-22 Thread Luca Fancellu
> On 21 Sep 2021, at 22:34, Stefano Stabellini wrote: > > On Tue, 21 Sep 2021, Luca Fancellu wrote: >>> On 17 Sep 2021, at 23:33, Stefano Stabellini wrote: >>> On Fri, 17 Sep 2021, Luca Fancellu wrote: >>>>> On 16 Sep 2021, at 21:16, Stefano Stabell

[PATCH v2 1/2] arm/efi: Introduce uefi,cfg-load DT property

2021-09-22 Thread Luca Fancellu
needed. Signed-off-by: Luca Fancellu --- v2 changes: - Introduced uefi,cfg-load property - Add documentation about the property --- docs/misc/efi.pandoc| 2 ++ xen/arch/arm/efi/efi-boot.h | 28 +++- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a

[PATCH v2 0/2] arm/efi: Add dom0less support to UEFI boot

2021-09-22 Thread Luca Fancellu
cture. Luca Fancellu (2): arm/efi: Introduce uefi,cfg-load DT property arm/efi: Use dom0less configuration when using EFI boot docs/misc/arm/device-tree/booting.txt | 21 ++ docs/misc/efi.pandoc | 205 ++ xen/arch/arm/efi/efi-boot.h

[PATCH v2 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-22 Thread Luca Fancellu
quot;xen,domain" compatible nodes. The property holds a string containing the file name of the binary that shall be loaded by the uefi loader from the filesystem. Update efi documentation about how to start a dom0less setup using UEFI Signed-off-by: Luca Fancellu --- Changes in v2: - remove

Re: [PATCH v2 1/2] arm/efi: Introduce uefi,cfg-load DT property

2021-09-23 Thread Luca Fancellu
> On 22 Sep 2021, at 22:19, Stefano Stabellini wrote: > > On Wed, 22 Sep 2021, Luca Fancellu wrote: >> Introduce the uefi,cfg-load DT property of /chosen >> node for ARM whose presence decide whether to force >> the load of the UEFI Xen configuration file. >

Re: [PATCH v2 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-23 Thread Luca Fancellu
> On 22 Sep 2021, at 22:51, Stefano Stabellini wrote: > > On Wed, 22 Sep 2021, Luca Fancellu wrote: >> This patch introduces the support for dom0less configuration >> when using UEFI boot on ARM, it permits the EFI boot to >> continue if no dom0 kernel is specified

Re: [PATCH v2 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-24 Thread Luca Fancellu
> On 23 Sep 2021, at 17:59, Stefano Stabellini wrote: > > On Thu, 23 Sep 2021, Luca Fancellu wrote: >>>> +/* >>>> + * Binaries will be translated into bootmodules, the maximum number for >>>> them is >>>> + * MAX_MODULES

Re: [PATCH v2 2/2] arm/efi: Use dom0less configuration when using EFI boot

2021-09-24 Thread Luca Fancellu
> On 24 Sep 2021, at 15:02, Jan Beulich wrote: > > On 22.09.2021 16:13, Luca Fancellu wrote: >> +static unsigned int __init allocate_dom0less_file(EFI_FILE_HANDLE >> dir_handle, >> +

Re: [XEN PATCH v4] xen: rework `checkpolicy` detection when using "randconfig"

2021-09-28 Thread Luca Fancellu
> On 28 Sep 2021, at 09:39, Anthony PERARD wrote: > > This will help prevent the CI loop from having build failures when > `checkpolicy` isn't available when doing "randconfig" jobs. > > To prevent "randconfig" from selecting XSM_FLASK_POLICY when > `checkpolicy` isn't available, we will actu

Re: [XEN PATCH v5] xen: rework `checkpolicy` detection when using "randconfig"

2021-09-28 Thread Luca Fancellu
icy" is missing. > > This patch allows to easily add more override which depends on the > environment. > > Also, move the check out of Config.mk and into xen/ build system. > Nothing in tools/ is using that information as it's done by > ./configure. > > We na

<    5   6   7   8   9   10   11   12   13   14   >