Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-21 Thread Luca Fancellu
> On 21 Mar 2022, at 09:10, Jan Beulich wrote: > > On 18.03.2022 16:25, Luca Fancellu wrote: >> --- a/xen/common/Makefile >> +++ b/xen/common/Makefile >> @@ -1,5 +1,6 @@ >> obj-$(CONFIG_ARGO) += argo.o >> obj-y += bitmap.o >> +obj-$(CONFIG_BOOT_

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-21 Thread Luca Fancellu
> On 18 Mar 2022, at 16:12, Julien Grall wrote: > > Hi Luca, > > I only skimmed through the series. I have one question below: > > On 18/03/2022 15:25, Luca Fancellu wrote: >> +void __init btcpupools_allocate_pools(void) >> +{ >> +unsigned int i;

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Luca Fancellu
>> +- cpupool-sched (optional) >> + >> +Must be a string having the name of a Xen scheduler, it has no effect >> when >> +used in conjunction of a cpupool-id equal to zero, in that case the >> +default Xen scheduler is selected (sched=<...> boot argument). >> +Check the sched=<...

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-22 Thread Luca Fancellu
>>> >>> Can you document why this is necessary on x86 but not on other >>> architectures? >> Hi Julien, >> I received the warning by Juergen here: >> https://patchwork.kernel.org/comment/24740762/ that at least on x86 there >> could be >> some problems if cpu0 is not in cpupool0, I tested it on

Re: [PATCH v3 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-03-22 Thread Luca Fancellu
+ maintainer golang, libs, ocaml, python bindings > On 18 Mar 2022, at 16:18, Julien Grall wrote: > > Hi, > > On 18/03/2022 15:25, Luca Fancellu wrote: >> Introduce domain-cpupool property of a xen,domain device tree node, >> that specifies the cpupool device tree h

Re: [PATCH] build: provide and export ADDR2LINE

2022-03-23 Thread Luca Fancellu
> On 22 Mar 2022, at 15:23, Jan Beulich wrote: > > Now that x86'es check-endbr.sh script uses it, also make it available > consistently with other tool chain components. > > Signed-off-by: Jan Beulich Reviewed-by: Luca Fancellu Cheers, Luca > > --- a/co

Re: [PATCH v2] include/public: add command result definitions to vscsiif.h

2022-03-23 Thread Luca Fancellu
T_HOST_NEXUS_FAILURE 17 > +/* Space allocation on device failed */ > +#define XEN_VSCSIIF_RSLT_HOST_ALLOC_FAILURE 18 > +/* Medium error */ > +#define XEN_VSCSIIF_RSLT_HOST_MEDIUM_ERROR19 > +/* Transport marginal errors */ > +#define XEN_VSCSIIF_RSLT_HOST_TRANSPO

Re: [PATCH v2] include/public: add command result definitions to vscsiif.h

2022-03-23 Thread Luca Fancellu
> On 23 Mar 2022, at 11:10, Luca Fancellu wrote: > > > >> On 23 Mar 2022, at 08:58, Juergen Gross wrote: >> >> The result field of struct vscsiif_response is lacking a detailed >> definition. Today the Linux kernel internal scsi definitions are being &g

Re: [PATCH v3 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-23 Thread Luca Fancellu
> On 22 Mar 2022, at 14:01, Julien Grall wrote: > > Hi, > > On 22/03/2022 09:52, Luca Fancellu wrote: >>>>> >>>>> Can you document why this is necessary on x86 but not on other >>>>> architectures? >>>

[PATCH v4 0/6] Boot time cpupools

2022-03-24 Thread Luca Fancellu
= <&cp1>; module@9200 { compatible = "multiboot,kernel", "multiboot,module"; reg = <0x9200 0x1ff>; bootargs = "..."; }; }; }; [...] The example DT is instructing Xen to have two cpu pools, the

[PATCH v4 2/6] xen/sched: create public function for cpupools creation

2022-03-24 Thread Luca Fancellu
Create new public function to create cpupools, can take as parameter the scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu --- Changes in v4: - no changes Changes in v3: - Fixed comment (Andrew) Changes in v2: - cpupool_create_pool

[PATCH v4 1/6] tools/cpupools: Give a name to unnamed cpupools

2022-03-24 Thread Luca Fancellu
hange, remove the check for poolid == 0 from libxl_cpupoolid_to_name(...). Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v4: - no changes Changes in v3: - no changes, add R-by Changes in v2: - Remove unused variable, moved xc_cpupool_infofree ahead to simplify the code

[PATCH v4 3/6] xen/sched: retrieve scheduler id by name

2022-03-24 Thread Luca Fancellu
scheduler_init. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v4: - no changes Changes in v3: - add R-by Changes in v2: - replace open coded scheduler search in scheduler_init (Juergen) --- xen/common/sched/core.c | 40 ++-- xen/include/xen

[PATCH v4 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-03-24 Thread Luca Fancellu
XEN_DOMCTL_INTERFACE_VERSION version is bumped. Add public function to retrieve a pool id from the device tree cpupool node. Update documentation about the property. Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v4: - no changes - add R-by Changes in v3: - Use

[PATCH v4 6/6] xen/cpupool: Allow cpupool0 to use different scheduler

2022-03-24 Thread Luca Fancellu
cated). Signed-off-by: Luca Fancellu --- Changes in v4: - no changes Changes in v3: - fix typo in commit message (Juergen) - rebase changes Changes in v2: - new patch --- xen/common/boot_cpupools.c | 5 - xen/common/sched/cpupool.c | 8 +--- xen/include/xen/sched.h| 5 - 3 files chang

[PATCH v4 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-24 Thread Luca Fancellu
specification of the cpupools from the device tree to build pools and assign cpus to them. Documentation is created to explain the feature. Signed-off-by: Luca Fancellu --- Changes in v4: - modify Makefile to put in *.init.o, fixed stubs and macro (Jan) - fixed docs, fix brakets (Stefano) - keep

Re: [PATCH v4 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-28 Thread Luca Fancellu
>> + >> +if ( !dt_property_read_string(phandle_node, "cpupool-sched", > > This should be "node", not phandle_node Hi Stefano, Yes sorry about that, I didn’t notice it because in my last test I was creating pools with default scheduler, I will pay more attention next time, same applies

Re: [PATCH v2] Grab the EFI System Resource Table and check it

2022-03-31 Thread Luca Fancellu
Hi, > > diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h > index 458cfbbed4..398a2411a1 100644 > --- a/xen/arch/arm/efi/efi-boot.h > +++ b/xen/arch/arm/efi/efi-boot.h > @@ -187,7 +187,8 @@ static bool __init meminfo_add_bank(struct meminfo *mem, > > static EFI_STATUS __init

Re: [PATCH v2] Grab the EFI System Resource Table and check it

2022-03-31 Thread Luca Fancellu
> On 31 Mar 2022, at 12:57, Demi Marie Obenour > wrote: > > On Thu, Mar 31, 2022 at 07:04:34AM +, Luca Fancellu wrote: >> Hi, >> >>> >>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h >>> index 458cfbbed4..398a

Re: [PATCH v4 3/8] x86/EFI: retrieve EDID

2022-04-01 Thread Luca Fancellu
t of the spec since 2.5. > > Signed-off-by: Jan Beulich Hi Jan, For the arm and common part, the changes looks good to me. Reviewed-by: Luca Fancellu I tested also the whole serie in the sense that it boots properly on arm, unfortunately I could not test the functionality. Cheers, Luca

Re: [PATCH v4 9/9] docs: document dom0less + PV drivers

2022-04-01 Thread Luca Fancellu
> On 1 Apr 2022, at 01:38, Stefano Stabellini wrote: > > From: Stefano Stabellini > > Document how to use the feature and how the implementation works. > > Signed-off-by: Stefano Stabellini Hi Stefano, Reviewed-by: Luca Fancellu

Re: [PATCH v4 2/9] xen/arm: implement domU extended regions

2022-04-01 Thread Luca Fancellu
ode style issue, the if needs a space before and after the condition With this fixed: Reviewed-by: Luca Fancellu Cheers, Luca

Re: [PATCH v2] Grab the EFI System Resource Table and check it

2022-04-04 Thread Luca Fancellu
> On 2 Apr 2022, at 00:14, Demi Marie Obenour > wrote: > > The EFI System Resource Table (ESRT) is necessary for fwupd to identify > firmware updates to install. According to the UEFI specification §23.4, > the table shall be stored in memory of type EfiBootServicesData. > Therefore, Xen must

[PATCH v5 2/6] xen/sched: create public function for cpupools creation

2022-04-05 Thread Luca Fancellu
Create new public function to create cpupools, can take as parameter the scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu --- Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - Fixed comment (Andrew) Changes in

[PATCH v5 0/6] Boot time cpupools

2022-04-05 Thread Luca Fancellu
= <&cp1>; module@9200 { compatible = "multiboot,kernel", "multiboot,module"; reg = <0x9200 0x1ff>; bootargs = "..."; }; }; }; [...] The example DT is instructing Xen to have two cpu pools, the on

[PATCH v5 1/6] tools/cpupools: Give a name to unnamed cpupools

2022-04-05 Thread Luca Fancellu
hange, remove the check for poolid == 0 from libxl_cpupoolid_to_name(...). Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - no changes, add R-by Changes in v2: - Remove unused variable, moved xc_cpupool_infofree ahe

[PATCH v5 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-05 Thread Luca Fancellu
specification of the cpupools from the device tree to build pools and assign cpus to them. Documentation is created to explain the feature. Signed-off-by: Luca Fancellu --- Changes in v5: - Fixed wrong variable name, swapped schedulers, add scheduler info in the printk (Stefano) - introduce

[PATCH v5 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-04-05 Thread Luca Fancellu
XEN_DOMCTL_INTERFACE_VERSION version is bumped. Add public function to retrieve a pool id from the device tree cpupool node. Update documentation about the property. Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v5: - no changes Changes in v4: - no changes - add R-by

[PATCH v5 3/6] xen/sched: retrieve scheduler id by name

2022-04-05 Thread Luca Fancellu
scheduler_init. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - add R-by Changes in v2: - replace open coded scheduler search in scheduler_init (Juergen) --- xen/common/sched/core.c | 40

[PATCH v5 6/6] xen/cpupool: Allow cpupool0 to use different scheduler

2022-04-05 Thread Luca Fancellu
cated). Signed-off-by: Luca Fancellu --- Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - fix typo in commit message (Juergen) - rebase changes Changes in v2: - new patch --- xen/common/boot_cpupools.c | 5 - xen/common/sched/cpupool.c | 8 +--- xen/include/xen/sc

Re: [PATCH v2] Grab the EFI System Resource Table and check it

2022-04-05 Thread Luca Fancellu
> On 5 Apr 2022, at 20:21, Stefano Stabellini wrote: > > On Mon, 4 Apr 2022, Luca Fancellu wrote: >>> On 2 Apr 2022, at 00:14, Demi Marie Obenour >>> wrote: >>> >>> The EFI System Resource Table (ESRT) is necessary for fwupd to identify >&

Re: [PATCH v5 2/6] xen/sched: create public function for cpupools creation

2022-04-07 Thread Luca Fancellu
> On 7 Apr 2022, at 07:07, Juergen Gross wrote: > > On 05.04.22 10:57, Luca Fancellu wrote: >> Create new public function to create cpupools, can take as parameter >> the scheduler id or a negative value that means the default Xen >> scheduler will be used. >

Re: [PATCH v5 1/6] tools/cpupools: Give a name to unnamed cpupools

2022-04-07 Thread Luca Fancellu
> Could you rework this loop so that "goto out" is always the right things > to do in case of error? That is the function would always free() > "pool_path" and "pool_name" regardless of their values, and we only need > to make sure both are NULL when they are already free. This is to avoid > hav

Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-07 Thread Luca Fancellu
> On 7 Apr 2022, at 09:58, Julien Grall wrote: > > Hi Luca, > > On 05/04/2022 09:57, Luca Fancellu wrote: >> Introduce a way to create different cpupools at boot time, this is >> particularly useful on ARM big.LITTLE system where there might be the >> need to

[PATCH v6 3/6] xen/sched: retrieve scheduler id by name

2022-04-08 Thread Luca Fancellu
scheduler_init. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v6: - no changes Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - add R-by Changes in v2: - replace open coded scheduler search in scheduler_init (Juergen) --- xen/common/sched/core.c | 40

[PATCH v6 1/6] tools/cpupools: Give a name to unnamed cpupools

2022-04-08 Thread Luca Fancellu
hange, remove the check for poolid == 0 from libxl_cpupoolid_to_name(...). Signed-off-by: Luca Fancellu --- Changes in v6: - Reworked loop to have only one error path (Anthony) Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - no changes, add R-by Changes in v2: - Remove u

[PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-08 Thread Luca Fancellu
specification of the cpupools from the device tree to build pools and assign cpus to them. ACPI is not supported for this feature. Documentation is created to explain the feature. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v6: - Changed docs, return if booted with ACPI

[PATCH v6 0/6] Boot time cpupools

2022-04-08 Thread Luca Fancellu
= <&cp1>; module@9200 { compatible = "multiboot,kernel", "multiboot,module"; reg = <0x9200 0x1ff>; bootargs = "..."; }; }; }; [...] The example DT is instructing Xen to have two cpu pools, the on

[PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-04-08 Thread Luca Fancellu
XEN_DOMCTL_INTERFACE_VERSION version is bumped. Add public function to retrieve a pool id from the device tree cpupool node. Update documentation about the property. Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v6: - no changes Changes in v5: - no changes Changes in

[PATCH v6 6/6] xen/cpupool: Allow cpupool0 to use different scheduler

2022-04-08 Thread Luca Fancellu
cated). Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v6: - Add R-by Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - fix typo in commit message (Juergen) - rebase changes Changes in v2: - new patch --- xen/common/boot_cpupools.c | 5 - xen/c

[PATCH v6 2/6] xen/sched: create public function for cpupools creation

2022-04-08 Thread Luca Fancellu
Create new public function to create cpupools, can take as parameter the scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v6: - add R-by Changes in v5: - no changes Changes in v4: - no

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-08 Thread Luca Fancellu
> On 8 Apr 2022, at 09:56, Jan Beulich wrote: > > On 08.04.2022 10:45, Luca Fancellu wrote: >> Introduce a way to create different cpupools at boot time, this is >> particularly useful on ARM big.LITTLE system where there might be the >> need to have different cpu

Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-04-08 Thread Luca Fancellu
> On 8 Apr 2022, at 10:10, Jan Beulich wrote: > > On 08.04.2022 10:45, Luca Fancellu wrote: >> @@ -106,6 +106,8 @@ struct xen_domctl_createdomain { >> /* Per-vCPU buffer size in bytes. 0 to disable. */ >> uint32_t vmtrace_size; >> >> +uint3

Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()

2022-04-08 Thread Luca Fancellu
and hence on large systems lock contention here isn't very > difficult to observe. > > Signed-off-by: Jan Beulich I’ve tested this patch on a Juno board, starting Dom0, creating/destroying few guests, doing some networking from guests of different cpu pool and everything w

Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-04-08 Thread Luca Fancellu
> On 8 Apr 2022, at 11:24, Jan Beulich wrote: > > On 08.04.2022 11:39, Luca Fancellu wrote: >> >> >>> On 8 Apr 2022, at 10:10, Jan Beulich wrote: >>> >>> On 08.04.2022 10:45, Luca Fancellu wrote: >>>> @@ -106,6 +106,8 @@ stru

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-08 Thread Luca Fancellu
> On 8 Apr 2022, at 10:01, Jan Beulich wrote: > > On 08.04.2022 10:45, Luca Fancellu wrote: >> --- >> docs/misc/arm/device-tree/cpupools.txt | 140 + >> xen/arch/arm/include/asm/smp.h | 3 + >> xen/common/Kconfig

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-11 Thread Luca Fancellu
> On 11 Apr 2022, at 07:15, Jan Beulich wrote: > > On 08.04.2022 22:25, Stefano Stabellini wrote: >> On Fri, 8 Apr 2022, Jan Beulich wrote: >>> On 08.04.2022 13:37, Luca Fancellu wrote: >>>> >>>> >>>>> On 8 Apr 2022, at 10

Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-04-11 Thread Luca Fancellu
> On 8 Apr 2022, at 13:10, Jan Beulich wrote: > > On 08.04.2022 13:15, Luca Fancellu wrote: >> >> >>> On 8 Apr 2022, at 11:24, Jan Beulich wrote: >>> >>> On 08.04.2022 11:39, Luca Fancellu wrote: >>>> >>>> >>

Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-04-11 Thread Luca Fancellu
> On 11 Apr 2022, at 10:08, Jan Beulich wrote: > > On 11.04.2022 10:54, Luca Fancellu wrote: >>> On 8 Apr 2022, at 13:10, Jan Beulich wrote: >>> On 08.04.2022 13:15, Luca Fancellu wrote: >>>>> On 8 Apr 2022, at 11:24, Jan Beulich wrote: >

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-11 Thread Luca Fancellu
> On 11 Apr 2022, at 11:58, Julien Grall wrote: > > Hi Luca, > > On 08/04/2022 09:45, Luca Fancellu wrote: >> diff --git a/docs/misc/arm/device-tree/cpupools.txt >> b/docs/misc/arm/device-tree/cpupools.txt >> new file mode 100644 >> index .

[PATCH v7 0/7] Boot time cpupools

2022-04-11 Thread Luca Fancellu
nstructing Xen to have two cpu pools, one having two phisical cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses the null scheduler and from the /chosen node we can see that a dom0less guest will be started on that cpu pool. In this particular case Xen must boot with different ty

[PATCH v7 2/7] xen/sched: create public function for cpupools creation

2022-04-11 Thread Luca Fancellu
Create new public function to create cpupools, can take as parameter the scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v7: - no changes Changes in v6: - add R-by Changes in v5: - no

[PATCH v7 5/7] xen/cpupool: Don't allow removing cpu0 from cpupool0

2022-04-11 Thread Luca Fancellu
Cpu0 must remain in cpupool0, otherwise some operations like moving cpus between cpupools, cpu hotplug, destroying cpupools, shutdown of the host, might not work in a sane way. Signed-off-by: Luca Fancellu --- Changes in v7: - new patch --- xen/common/sched/cpupool.c | 8 +++- 1 file

[PATCH v7 6/7] arm/dom0less: assign dom0less guests to cpupools

2022-04-11 Thread Luca Fancellu
XEN_DOMCTL_INTERFACE_VERSION version is bumped. Add public function to retrieve a pool id from the device tree cpupool node. Update documentation about the property. Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v7: - Add comment for cpupool_id struct member. (Jan

[PATCH v7 1/7] tools/cpupools: Give a name to unnamed cpupools

2022-04-11 Thread Luca Fancellu
hange, remove the check for poolid == 0 from libxl_cpupoolid_to_name(...). Signed-off-by: Luca Fancellu Reviewed-by: Anthony PERARD --- Changes in v7: - Add R-by from Anthony Changes in v6: - Reworked loop to have only one error path (Anthony) Changes in v5: - no changes Changes in v4: - no changes Ch

[PATCH v7 3/7] xen/sched: retrieve scheduler id by name

2022-04-11 Thread Luca Fancellu
scheduler_init. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross Reviewed-by: Dario Faggioli --- Changes in v7: - Add R-by (Dario) Changes in v6: - no changes Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - add R-by Changes in v2: - replace open coded scheduler search in

[PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time

2022-04-11 Thread Luca Fancellu
the feature. Signed-off-by: Luca Fancellu --- Changes in v7: - rename xen/common/boot_cpupools.c to xen/common/sched/boot-cpupool.c (Jan) - reverted xen/common/Makefile, add entry in xen/common/sched/Makefile - changed line in MAINTAINERS under CPU POOLS section (Dario) - Fix documentation, update

[PATCH v7 7/7] xen/cpupool: Allow cpupool0 to use different scheduler

2022-04-11 Thread Luca Fancellu
cated). Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v7: - no changes Changes in v6: - Add R-by Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - fix typo in commit message (Juergen) - rebase changes Changes in v2: - new patch --- xen/common/sched

Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time

2022-04-12 Thread Luca Fancellu
>> --- >> MAINTAINERS | 2 +- >> docs/misc/arm/device-tree/cpupools.txt | 140 + >> xen/arch/arm/domain_build.c | 5 +- >> xen/arch/arm/include/asm/smp.h | 3 + >> xen/common/Kconfig | 7 + > > For consistency, should the addition here - with ... > >> xen/common/sched/Makefile | 1 + >

Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time

2022-04-13 Thread Luca Fancellu
>> >> No, I'm not suggesting a new menu. I was merely wondering whether the >> Kconfig contents wouldn't location-wise better match where the >> respective source file lives. > > It could be in xen/common/sched/Kconfig at the beginning of the file > before creating the new "Schedulers" menu, e.

Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time

2022-04-20 Thread Luca Fancellu
> On 13 Apr 2022, at 08:22, Jan Beulich wrote: > > On 13.04.2022 09:15, Luca Fancellu wrote: >> >>>> >>>> No, I'm not suggesting a new menu. I was merely wondering whether the >>>> Kconfig contents wouldn't location-wise better m

Re: [PATCH v7 5/7] xen/cpupool: Don't allow removing cpu0 from cpupool0

2022-04-20 Thread Luca Fancellu
> On 11 Apr 2022, at 16:20, Luca Fancellu wrote: > > Cpu0 must remain in cpupool0, otherwise some operations like moving cpus > between cpupools, cpu hotplug, destroying cpupools, shutdown of the host, > might not work in a sane way. > > Signed-off-by: Luca Fancellu

[PATCH v8 0/7] Boot time cpupools

2022-04-21 Thread Luca Fancellu
nstructing Xen to have two cpu pools, one having two phisical cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses the null scheduler and from the /chosen node we can see that a dom0less guest will be started on that cpu pool. In this particular case Xen must boot with different ty

[PATCH v8 5/7] xen/cpupool: Don't allow removing cpu0 from cpupool0

2022-04-21 Thread Luca Fancellu
Cpu0 must remain in cpupool0, otherwise some operations like moving cpus between cpupools, cpu hotplug, destroying cpupools, shutdown of the host, might not work in a sane way. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v8: - Add R-by (Juergen) Changes in v7: - new

[PATCH v8 1/7] tools/cpupools: Give a name to unnamed cpupools

2022-04-21 Thread Luca Fancellu
hange, remove the check for poolid == 0 from libxl_cpupoolid_to_name(...). Signed-off-by: Luca Fancellu Reviewed-by: Anthony PERARD --- Changes in v8: - no changes Changes in v7: - Add R-by from Anthony Changes in v6: - Reworked loop to have only one error path (Anthony) Changes in v5: - no changes Ch

[PATCH v8 2/7] xen/sched: create public function for cpupools creation

2022-04-21 Thread Luca Fancellu
Create new public function to create cpupools, can take as parameter the scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v8: - no changes Changes in v7: - no changes Changes in v6: - add R

[PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools

2022-04-21 Thread Luca Fancellu
XEN_DOMCTL_INTERFACE_VERSION version is bumped. Add public function to retrieve a pool id from the device tree cpupool node. Update documentation about the property. Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v8: - no changes Changes in v7: - Add comment for

[PATCH v8 3/7] xen/sched: retrieve scheduler id by name

2022-04-21 Thread Luca Fancellu
scheduler_init. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross Reviewed-by: Dario Faggioli --- Changes in v8: - no changes Changes in v7: - Add R-by (Dario) Changes in v6: - no changes Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - add R-by Changes in v2: - replace open

[PATCH v8 7/7] xen/cpupool: Allow cpupool0 to use different scheduler

2022-04-21 Thread Luca Fancellu
cated). Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v8: - no changes Changes in v7: - no changes Changes in v6: - Add R-by Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - fix typo in commit message (Juergen) - rebase changes Changes in v2: - new

[PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time

2022-04-21 Thread Luca Fancellu
the feature. Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v8: - moved Kconfig parameter from xen/common/Kconfig to xen/common/sched/Kconfig (Jan) - Add R-by (Stefano) Changes in v7: - rename xen/common/boot_cpupools.c to xen/common/sched/boot-cpupool.c (Jan

Re: [PATCH v4 1/3] arm/efi: Introduce xen,uefi-cfg-load DT property

2021-10-07 Thread Luca Fancellu
> On 6 Oct 2021, at 19:32, Julien Grall wrote: > > Hi Luca, > > Sorry for jumping late in the conversation. While skimming through what has > been committed, I noticed one potential issue in this patch and have also a > question. > > On 30/09/2021 16:28, Luca F

Re: [PATCH v4 2/3] arm/efi: Use dom0less configuration when using EFI boot

2021-10-08 Thread Luca Fancellu
> On 7 Oct 2021, at 08:15, Jan Beulich wrote: > > On 01.10.2021 17:13, Luca Fancellu wrote: >> >> >>> On 1 Oct 2021, at 15:22, Jan Beulich wrote: >>> >>> On 01.10.2021 15:55, Luca Fancellu wrote: >>>>> On 1 Oct 2021, at 12:0

[PATCH] arm/efi: Fix null pointer dereference

2021-10-11 Thread Luca Fancellu
Fix for commit 60649d443dc395243e74d2b3e05594ac0c43cfe3 that introduces a null pointer dereference when the fdt_node_offset_by_compatible is called with "fdt" argument null. Reported-by: Julien Grall Fixes: 60649d443d ("arm/efi: Introduce xen,uefi-cfg-load DT property")

[PATCH v5 0/2] arm/efi: Add dom0less support to UEFI boot

2021-10-11 Thread Luca Fancellu
cture. This serie was originally formed by 3 patch, the first one was merged. Luca Fancellu (2): arm/efi: Use dom0less configuration when using EFI boot arm/efi: load dom0 modules from DT using UEFI docs/misc/arm/device-tree/booting.txt | 29 +++ docs/misc/efi.pandoc

[PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Luca Fancellu
itectures that don't support device tree don't have to provide this function. Update efi documentation about how to start a dom0less setup using UEFI Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Reviewed-by: Stefano Stabellini --- Changes in v5: - Removed unneeded variable

[PATCH v5 2/2] arm/efi: load dom0 modules from DT using UEFI

2021-10-11 Thread Luca Fancellu
Add support to load Dom0 boot modules from the device tree using the xen,uefi-binary property. Update documentation about that. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich --- Changes in v5: - renamed missing uefi,binary

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Luca Fancellu
> On 11 Oct 2021, at 09:11, Jan Beulich wrote: > > On 11.10.2021 10:03, Luca Fancellu wrote: >> This patch introduces the support for dom0less configuration >> when using UEFI boot on ARM, it permits the EFI boot to >> continue if no dom0 kernel is specified but at

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Luca Fancellu
> On 11 Oct 2021, at 10:39, Julien Grall wrote: > > Hi Luca, > Hi Julien, > On 11/10/2021 09:03, Luca Fancellu wrote: >> +static bool __init is_boot_module(int dt_module_offset) >> +{ >> +if ( (fdt_node_check

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Luca Fancellu
> On 11 Oct 2021, at 12:32, Julien Grall wrote: > > Hi Luca, > > On 11/10/2021 12:23, Luca Fancellu wrote: >>> On 11 Oct 2021, at 10:39, Julien Grall wrote: >>> >>> Hi Luca, >>> >> Hi Julien, >>> On 11/10/2021 09:03

[PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI

2021-10-11 Thread Luca Fancellu
Add support to load Dom0 boot modules from the device tree using the xen,uefi-binary property. Update documentation about that. Signed-off-by: Luca Fancellu --- Changes in v6: - given the changes to is_boot_module() in previous patch, a check to avoid declaration of xsm in DT and cfg file is

[PATCH v6 0/2] arm/efi: Add dom0less support to UEFI boot

2021-10-11 Thread Luca Fancellu
cture. This serie was originally formed by 3 patch, the first one was merged. Luca Fancellu (2): arm/efi: Use dom0less configuration when using EFI boot arm/efi: load dom0 modules from DT using UEFI docs/misc/arm/device-tree/booting.txt | 29 +++ docs/misc/efi.pandoc

[PATCH v6 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Luca Fancellu
itectures that don't support device tree don't have to provide this function. Update efi documentation about how to start a dom0less setup using UEFI Signed-off-by: Luca Fancellu --- Changes in v6: - change is_boot_module() to check for every multiboot,module instead of multiboot,{kerne

Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI

2021-10-11 Thread Luca Fancellu
> On 11 Oct 2021, at 20:53, Stefano Stabellini wrote: > > On Mon, 11 Oct 2021, Luca Fancellu wrote: >> Add support to load Dom0 boot modules from >> the device tree using the xen,uefi-binary property. >> >> Update documentation about that. >> >>

Re: [PATCH v6 2/2] arm/efi: load dom0 modules from DT using UEFI

2021-10-12 Thread Luca Fancellu
> On 12 Oct 2021, at 02:31, Stefano Stabellini wrote: > > On Mon, 11 Oct 2021, Julien Grall wrote: >> Hi Stefano, >> >> On 11/10/2021 22:24, Stefano Stabellini wrote: diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index 840728d6c0..076b827bdd 100644 ---

Re: [PATCH v6 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-12 Thread Luca Fancellu
> On 12 Oct 2021, at 09:45, Jan Beulich wrote: > > On 11.10.2021 20:15, Luca Fancellu wrote: >> --- a/xen/common/efi/boot.c >> +++ b/xen/common/efi/boot.c >> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s) >> StdErr-

[PATCH] arm/docs: Clarify legacy DT bindings on UEFI

2021-10-13 Thread Luca Fancellu
Legacy compatible strings for dom0 modules are not supported when booting using UEFI, the documentation doesn't mention that. Add a phrase to docs/misc/arm/device-tree/booting.txt to clarify it. Signed-off-by: Luca Fancellu --- docs/misc/arm/device-tree/booting.txt | 2 ++ 1 file chang

Re: [PATCH] arm/docs: Clarify legacy DT bindings on UEFI

2021-10-13 Thread Luca Fancellu
> On 13 Oct 2021, at 14:27, Julien Grall wrote: > > Hi Luca, > > On 13/10/2021 13:19, Luca Fancellu wrote: >> Legacy compatible strings for dom0 modules are not >> supported when booting using UEFI, the documentation >> doesn't mention that. > >

Re: [PATCH] arm/docs: Clarify legacy DT bindings on UEFI

2021-10-13 Thread Luca Fancellu
> On 13 Oct 2021, at 15:30, Julien Grall wrote: > > Hi Luca, > > On 13/10/2021 15:06, Luca Fancellu wrote: >>> On 13 Oct 2021, at 14:27, Julien Grall wrote: >>> >>> Hi Luca, >>> >>> On 13/10/2021 13:19, Luca Fancellu wr

[PATCH v2] arm/docs: Clarify legacy DT bindings on UEFI

2021-10-13 Thread Luca Fancellu
/misc/arm/device-tree/booting.txt to clarify it. Signed-off-by: Luca Fancellu Acked-by: Julien Grall --- Changes in v2: - dropped redundant wording in docs/misc/arm/device-tree/booting.txt - Add more details to the commit message --- docs/misc/arm/device-tree/booting.txt | 2 ++ 1 file changed, 2

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Luca Fancellu
> On 15 Oct 2021, at 10:52, Bertrand Marquis wrote: > > Hi Roger, > >> On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: >> >> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: >>> From: Rahul Singh >>> >>> The existing VPCI support available for X86 is adapted for Arm. >>>

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Luca Fancellu
> On 15 Oct 2021, at 14:47, Roger Pau Monné wrote: > > On Fri, Oct 15, 2021 at 10:48:41AM +, Bertrand Marquis wrote: >> Hi Jan, >> >>> On 15 Oct 2021, at 11:41, Jan Beulich wrote: >>> >>> On 15.10.2021 12:33, Bertrand Marquis wrote: > On 15 Oct 2021, at 11:24, Jan Beulich wrote: >>

Re: [PATCH for-4.16] tools/xenstored: Ignore domain we were unable to restore

2021-10-21 Thread Luca Fancellu
rs for a socket connection may close the fd. However, > ignore_connection() will close a socket connection directly. So it is > fine to do the re-order. > > Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu > > --- > > This issue was originally found when deve

[PATCH] xen/efi: Fix Grub2 boot on arm64

2021-11-02 Thread Luca Fancellu
guration when using EFI boot") Signed-off-by: Luca Fancellu --- Justification for integration in 4.16: Upside: allow booting xen from grub on arm64 when the stub doesn't load any module. Downside: It's affecting the EFI boot path. Risk: It's not affecting x86 arch that wor

Re: [PATCH] xen/efi: Fix Grub2 boot on arm64

2021-11-02 Thread Luca Fancellu
+ Ian Jackson for 4.16 release > On 2 Nov 2021, at 14:45, Jan Beulich wrote: > > On 02.11.2021 15:05, Luca Fancellu wrote: >> The code introduced by commit a1743fc3a9fe9b68c265c45264dddf214fd9b882 >> ("arm/efi: Use dom0less configuration when using EFI boot") is &

Arm EFI boot issue for Dom0 module listed inside subnode of chosen

2021-11-02 Thread Luca Fancellu
Hi all, We recently discovered that there is a way to list Dom0 modules that is not supported by the EFI boot, It’s happened browsing some Wiki pages like this one: https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions/Lager In that page the Dom0 modules are listed inside a sub

Re: [PATCH] xen/efi: Fix Grub2 boot on arm64

2021-11-03 Thread Luca Fancellu
> On 3 Nov 2021, at 08:20, Jan Beulich wrote: > > On 02.11.2021 18:12, Luca Fancellu wrote: >>> On 2 Nov 2021, at 14:45, Jan Beulich wrote: >>> On 02.11.2021 15:05, Luca Fancellu wrote: >>>> The code introduced by commit a1743fc3a9fe9b68c265c45264dddf

Re: [PATCH] xen/efi: Fix Grub2 boot on arm64

2021-11-03 Thread Luca Fancellu
> On 2 Nov 2021, at 23:17, Stefano Stabellini wrote: > > On Tue, 2 Nov 2021, Luca Fancellu wrote: >> The code introduced by commit a1743fc3a9fe9b68c265c45264dddf214fd9b882 >> ("arm/efi: Use dom0less configuration when using EFI boot") is >> introducing a p

Re: [PATCH] xen/efi: Fix Grub2 boot on arm64

2021-11-03 Thread Luca Fancellu
> On 3 Nov 2021, at 11:28, Jan Beulich wrote: > > On 03.11.2021 11:20, Luca Fancellu wrote: >> >> >>> On 3 Nov 2021, at 08:20, Jan Beulich wrote: >>> >>> On 02.11.2021 18:12, Luca Fancellu wrote: >>>>> On 2 Nov 2021, at 14:4

Re: [PATCH] xen/efi: Fix Grub2 boot on arm64

2021-11-03 Thread Luca Fancellu
> On 3 Nov 2021, at 14:30, Jan Beulich wrote: > > On 03.11.2021 15:09, Luca Fancellu wrote: >>> On 3 Nov 2021, at 11:28, Jan Beulich wrote: >>> On 03.11.2021 11:20, Luca Fancellu wrote: >>>>> On 3 Nov 2021, at 08:20, Jan Beulich wrote: >

Re: [PATCH] xen/efi: Fix Grub2 boot on arm64

2021-11-03 Thread Luca Fancellu
> On 3 Nov 2021, at 15:30, Jan Beulich wrote: > > On 03.11.2021 16:16, Luca Fancellu wrote: >> >> >>> On 3 Nov 2021, at 14:30, Jan Beulich wrote: >>> >>> On 03.11.2021 15:09, Luca Fancellu wrote: >>>>> On 3 Nov 2021, at 11:2

<    1   2   3   4   5   6   7   8   9   10   >