Hi Stefano,
> +#define ALIGN_UP_TO_2MB(x) (((x) + MB(2) - 1) & (~(MB(2) - 1)))
> +
> +static int __init find_domU_holes(const struct kernel_info *kinfo,
> + struct meminfo *ext_regions)
> +{
> + unsigned int i;
> + uint64_t bankend[GUEST_RAM_BANKS];
> + const uint64_t bankbase[] = GUEST_RAM_BANK_BASES;
> + const uint64_t banksize[] = GUEST_RAM_BANK_SIZES;
> +
> + for ( i = 0; i < GUEST_RAM_BANKS; i++ )
> + {
> + ext_regions->bank[ext_regions->nr_banks].start =
> + ALIGN_UP_TO_2MB(bankbase[i] + kinfo->mem.bank[i].size);
> +
> + bankend[i] = ~0ULL >> (64 - p2m_ipa_bits);
> + bankend[i] = min(bankend[i], bankbase[i] + banksize[i] - 1);
> + if (bankend[i] > ext_regions->bank[ext_regions->nr_banks].start)
Just a code style issue, the if needs a space before and after the condition
With this fixed:
Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
Cheers,
Luca
