Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Bail out if gicv3_cpu_init fail

2017-12-08 Thread Julien Grall
Hi Stefano, On 07/12/17 23:05, Stefano Stabellini wrote: On Wed, 6 Dec 2017, Julien Grall wrote: From: Julien Grall When system registers are not enabled, all the access to them will trap ^ accesses in EL2. In Xen, system registers will be

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-08 Thread Julien Grall
Hi Stefano, On 07/12/17 23:01, Stefano Stabellini wrote: On Wed, 6 Dec 2017, Julien Grall wrote: Hi Stefano, On 12/06/2017 01:22 AM, Stefano Stabellini wrote: On Thu, 23 Nov 2017, Julien Grall wrote: The only differences between copy_to_guest and access_guest_memory_by_ipa are: - The

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-08 Thread Julien Grall
Hi, On 06/12/17 12:27, Julien Grall wrote: On 12/06/2017 01:26 AM, Stefano Stabellini wrote: On Thu, 23 Nov 2017, Julien Grall wrote: Hi Andrew, On 23/11/17 18:49, Andrew Cooper wrote: On 23/11/17 18:32, Julien Grall wrote: This new function will be used in a follow-up patch to copy data to

Re: [Xen-devel] [PATCH v2 02/10] ARM: vGIC: fix nr_irq definition

2017-12-08 Thread Julien Grall
starting at 8192, so 0 is a good invalid case. */ #define INVALID_LPI 0 -#define nr_irqs NR_IRQS +extern unsigned int nr_irqs; #define nr_static_irqs NR_IRQS #define arch_hwdom_irqs(domid) NR_IRQS Cheers -- Julien Grall ___ Xen-de

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-08 Thread Julien Grall
On 8 Dec 2017 22:26, "Stefano Stabellini" wrote: On Fri, 8 Dec 2017, Julien Grall wrote: > On 06/12/17 12:27, Julien Grall wrote: > > On 12/06/2017 01:26 AM, Stefano Stabellini wrote: > > > On Thu, 23 Nov 2017, Julien Grall wrote: > > > > Hi Andrew, &

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-11 Thread Julien Grall
Hi, On 12/10/2017 03:22 PM, Tim Deegan wrote: At 14:38 + on 08 Dec (1512743913), Julien Grall wrote: On 08/12/17 08:03, Tim Deegan wrote: +1 for avoiding the full majesty of PoD if you don't need it. It should be possible to do something like the misconfigured-entry bit tri

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-11 Thread Julien Grall
S/W are not easily virtualizable, I take that as a hint for "All the features may not be available when using S/W in a guest". Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-11 Thread Julien Grall
then it is the price to pay. It is better than not been able to boot current kernel or randomly crashing. Cheers, -- Julien Grall, ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 for-next 0/4] xen: Convert __page_to_mfn and _mfn_to_page to use typesafe MFN

2017-12-11 Thread Julien Grall
fully drop __page_to_mfn/__mfn_to_page. Not sure I will resend it though. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-11 Thread Julien Grall
Hi Stefano, On 12/08/2017 10:43 PM, Stefano Stabellini wrote: On Fri, 8 Dec 2017, Julien Grall wrote: On 8 Dec 2017 22:26, "Stefano Stabellini" wrote: On Fri, 8 Dec 2017, Julien Grall wrote: > On 06/12/17 12:27, Julien Grall wrote: > > On 12/06/201

[Xen-devel] [v2 03/16] xen/arm: Extend copy_to_guest to support copying from guest VA and use it

2017-12-12 Thread Julien Grall
the direction of the copy. Lastly, reimplement raw_copy_from_guest using copy_to_guest. Signed-off-by: Julien Grall --- Changes in v2: - Use vaddr_t --- xen/arch/arm/guestcopy.c | 46 +- 1 file changed, 13 insertions(+), 33 deletions

[Xen-devel] [v2 01/16] xen/arm: raw_copy_to_guest_helper: Rename flush_dcache to flags

2017-12-12 Thread Julien Grall
In a follow-up patch, it will be necessary to pass more flags to the function. Rename flush_dcache to flags and introduce a define to tell whether the cache needs to be flushed after the copy. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add

[Xen-devel] [v2 08/16] xen/arm: kernel: Rework kernel_zimage_load to use the generic copy helper

2017-12-12 Thread Julien Grall
logic in page-tables (such support for Populate On Demand). The new copy_to_guest_phys_flush_dcache could be used here by temporarily mapping the full kernel in the virtual space. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's rev

[Xen-devel] [v2 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-12 Thread Julien Grall
This new function will be used in a follow-up patch to copy data to the guest using the IPA (aka guest physical address) and then clean the cache. Signed-off-by: Julien Grall --- Changes in v2: - Use the new interface --- xen/arch/arm/guestcopy.c | 9 + xen

[Xen-devel] [v2 13/16] xen/arm: p2m: Fold p2m_tlb_flush into p2m_force_tlb_flush_sync

2017-12-12 Thread Julien Grall
flushing and avoid misusage in the P2M code. So update p2m_alloc_table to use p2m_force_tlb_flush_sync and fold p2m_tlb_flush in p2m_force_tlb_flush_sync. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/

[Xen-devel] [v2 11/16] xen/arm: p2m: Rename p2m_flush_tlb and p2m_flush_tlb_sync

2017-12-12 Thread Julien Grall
to shared with. For p2m_flush_tlb_sync, the 'force' was added because the TLBs are flush unconditionally. A follow-up patch will add an helper to flush TLBs only in certain cases. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano&#

[Xen-devel] [v2 10/16] xen/arm: domain_build: Use copy_to_guest_phys_flush_dcache in dtb_load

2017-12-12 Thread Julien Grall
. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/domain_build.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c

[Xen-devel] [v2 05/16] xen/arm: guest_copy: Extend the prototype to pass the vCPU

2017-12-12 Thread Julien Grall
-off-by: Julien Grall --- Changes in v2: - Encapsulate the vCPU in an union. - Rework the commit message --- xen/arch/arm/guestcopy.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/guestcopy.c b/xen/arch/arm

[Xen-devel] [v2 12/16] xen/arm: p2m: Introduce p2m_tlb_flush_sync, export it and use it

2017-12-12 Thread Julien Grall
Multiple places in the code requires to flush the TLBs only when p2m->need_flush is set. Rather than open-coding it, introduce a new helper p2m_tlb_flush_sync to do it. Note that p2m_tlb_flush_sync is exported as it might be used by other part of Xen. Signed-off-by: Julien Grall Reviewed

[Xen-devel] [v2 00/16] xen/arm: Stage-2 handling cleanup

2017-12-12 Thread Julien Grall
Hi all, This patch series is a collection of cleanup around stage-2 handling. They are consolidating different pieces of the hypervisor. This will make easier to maintain and update stage-2 change in the future. For all the changes see in each patch. Cheers, Julien Grall (16): xen/arm

[Xen-devel] [v2 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-12 Thread Julien Grall
: Julien Grall --- Changes in v2: - Rework the patch after the interface changes in the previous patch. - Use uint64_t rather than paddr_t in translate_get_page - Add a BUILD_BUG_ON to check whether paddr_t fits in uint64_t --- xen/arch/arm/guestcopy.c | 91

[Xen-devel] [v2 16/16] xen/arm: traps: Merge do_trap_instr_abort_guest and do_trap_data_abort_guest

2017-12-12 Thread Julien Grall
maintain stage-2 abort handling. So consolidate the two helpers in a new helper do_trap_stage2_abort. Signed-off-by: Julien Grall --- Changes in v2 - Fix the way to compute npfec.write_access --- xen/arch/arm/traps.c | 133 --- 1 file

[Xen-devel] [v2 04/16] xen/arm: Extend copy_to_guest to support zeroing guest VA and use it

2017-12-12 Thread Julien Grall
The function copy_to_guest can easily be extended to support zeroing guest VA. To avoid using a new bit, it is considered that a NULL buffer (i.e buf == NULL) means the guest memory will be zeroed. Lastly, reimplement raw_clear_guest using copy_to_guest. Signed-off-by: Julien Grall

[Xen-devel] [v2 15/16] xen/arm: traps: Move the definition of mmio_info_t in try_handle_mmio

2017-12-12 Thread Julien Grall
mmio_info_t is currently filled by do_trap_data_guest_abort but only important when emulation an MMIO region. A follow-up patch will merge stage-2 prefetch abort and stage-2 data abort in a single helper. To prepare that, mmio_info_t is now filled by try_handle_mmio. Signed-off-by: Julien Grall

[Xen-devel] [v2 09/16] xen/arm: domain_build: Rework initrd_load to use the generic copy helper

2017-12-12 Thread Julien Grall
logic in page-tables (such support for Populate On Demand). The new copy_to_guest_phys_flush_dcache could be used here by temporarily mapping the full initrd in the virtual space. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's review

[Xen-devel] [v2 02/16] xen/arm: raw_copy_to_guest_helper: Rework the prototype and rename it

2017-12-12 Thread Julien Grall
. Signed-off-by: Julien Grall --- Changes in v2: - Use vaddr_t - Use uint64_t for addr in copy_guest - Add a BUILD_BUG_ON to make sure vaddr_t fit in uint64_t. --- xen/arch/arm/guestcopy.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff

[Xen-devel] [v2 14/16] xen/arm: traps: Remove the field gva from mmio_info_t

2017-12-12 Thread Julien Grall
mmio_info_t is used to gather information in order do emulation of a region. Guest virtual address is unlikely to be a useful information and not currently used. So remove the field gva from mmio_info_t and replace by a local variable. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini

Re: [Xen-devel] [PATCH] docs/process/xen-release-management: Lesson to learn

2017-12-13 Thread Julien Grall
would need to get the tree completely frozen 2-3 weeks before the actual date. Cheers, Evidently our docs makes it insufficiently clear not to do that. CC: Lars Kurth CC: Julien Grall CC: Juergen Gross Signed-off-by: Ian Jackson --- docs/process/xen-release-management.pandoc | 5 + 1

[Xen-devel] Please welcome our new release manager

2017-12-14 Thread Julien Grall
loper at Suse and maintainer of Xen subsystem in Linux as well as parvirtualization. He also expressed desire to work with greater Xen community and make bigger impact. All in all, we believe Jurgen will do a good job in managing the next release. Thanks Jurgen for stepping up. Regards, Julien

Re: [Xen-devel] Xen release cycle revisited

2017-12-14 Thread Julien Grall
10/msg00263.html Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] Xen 4.10.0 is released

2017-12-14 Thread Julien Grall
pened without all the awesome contributions from around the globe. Regards, Julien Grall (on behalf of the Xen Project Hypervisor team) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] Xen release cycle revisited

2017-12-14 Thread Julien Grall
On 14/12/17 11:38, Juergen Gross wrote: On 14/12/17 12:28, Julien Grall wrote: On 14/12/17 07:56, Juergen Gross wrote: Hi all, Hi Juergen, I would recommend to CC committers on that thread, so your thread don't get lost in the xen-devel meanders :). with 4.10 more or less finish

Re: [Xen-devel] Memory usage on Aarch64

2017-12-15 Thread Julien Grall
h/arm/domain_build.c. Further below, it mentions that each domU has an artificial memory map. But I'm not sure what this looks like in memory. Could someone clarify how this is done? I am not sure to understand what you mean by "what this looks like in memory". Could you clarify? Chee

Re: [Xen-devel] [OSSTEST PATCH v2 07/19] ts-host-install: don't use the new nic naming scheme

2017-12-15 Thread Julien Grall
On 12/12/17 15:15, Julien Grall wrote: Hi Wei/Ian, Hi, I have tried this series on Arm64 hardware. I am able to boot and install Debian on AMD Seattle (laxton{0,1}). But I don't get network when using Cavium Thunder-X (rochester{0,1}) after reboot. Looking into more details

Re: [Xen-devel] [RFC v3 2/4] xen/linux_compat: Add a Linux compat header

2017-12-15 Thread Julien Grall
On 15/12/2017 22:32, Goel, Sameer wrote: On 12/5/2017 5:31 AM, Julien Grall wrote: Hi Sameer, On 05/12/17 03:59, Sameer Goel wrote: For porting files from Linux it is useful to have a Linux API to Xen API mapping header at a common location. This file adds common API functions and other

Re: [Xen-devel] [PATCH v1] x86/altp2m: Add hypercall to create a new view and set sve bits

2019-09-05 Thread Julien Grall
bits per new default that can be encoded in 1-bit. Cheers -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v8 2/6] domain: introduce XEN_DOMCTL_CDF_iommu flag

2019-09-05 Thread Julien Grall
s the code clearer. Signed-off-by: Paul Durrant Reviewed-by: "Roger Pau Monné" Acked-by: Jan Beulich --- Cc: Christian Lindig Cc: David Scott Cc: Ian Jackson Cc: Wei Liu Cc: Andrew Cooper Cc: George Dunlap Cc: Julien Grall Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc:

Re: [Xen-devel] [PATCH v8 3/6] use is_iommu_enabled() where appropriate...

2019-09-05 Thread Julien Grall
om_iommu(d); ^~ Signed-off-by: Paul Durrant Reviewed-by: "Roger Pau Monné" Reviewed-by: Kevin Tian Acked-by: Daniel De Graaf Reviewed-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall ___ Xe

Re: [Xen-devel] [PATCH v8 5/6] iommu: tidy up iommu_use_hap_pt() and need_iommu_pt_sync() macros

2019-09-05 Thread Julien Grall
Beulich --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Julien Grall Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu Cc: Volodymyr Babchuk Cc: "Roger Pau Monné" Previously part of https://lists.xenproject.org/archives/html/xen-devel/20

Re: [Xen-devel] [PATCH v8 6/6] introduce a 'passthrough' configuration option to xl.cfg...

2019-09-05 Thread Julien Grall
u_enabled(d) && iommu_hap_pt_share) +#define iommu_use_hap_pt(d) (dom_iommu(d)->hap_pt_share) /* Does the IOMMU pagetable need to be kept synchronized with the P2M */ #ifdef CONFIG_HAS_PASSTHROUGH Cheers, -- Julien Grall ___ Xen-

Re: [Xen-devel] [PATCH v8 2/6] domain: introduce XEN_DOMCTL_CDF_iommu flag

2019-09-05 Thread Julien Grall
al to CDF_hvm_guest | CDF_hap. So after this patch, it will not be possible to create any domain when CDF_iommu is set. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v8 1/6] x86/domain: remove the 'oos_off' flag

2019-09-05 Thread Julien Grall
. However, it occurred to me that patch #2 will break domain creation on Arm as setting CDF_iommu will be prevented. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v8 4/6] remove late (on-demand) construction of IOMMU page tables

2019-09-05 Thread Julien Grall
t;,MemKB), +("iommu_memkb", MemKB), I think you want a corresponding LIBXL_HAVE in libxl.h to tell external toolstack whether the field exist. ("rtc_timeoffset", uint32), ("exec_ssidref",uint32), ("exec_ssid_label", string

Re: [Xen-devel] [PATCH v8 6/6] introduce a 'passthrough' configuration option to xl.cfg...

2019-09-05 Thread Julien Grall
to set the overhead to zero in the 'share_pt' case because the toolstack has no means of knowing whether the hardware actually supports IOMMU page table sharing. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Ian Jackson Cc: Wei Liu Cc: Andrew Coo

Re: [Xen-devel] [PATCH v8 5/6] iommu: tidy up iommu_use_hap_pt() and need_iommu_pt_sync() macros

2019-09-06 Thread Julien Grall
Hi Paul, On 9/6/19 8:59 AM, Paul Durrant wrote: -Original Message- From: Julien Grall Sent: 05 September 2019 20:38 To: Paul Durrant ; xen-devel@lists.xenproject.org Cc: Jan Beulich ; Andrew Cooper ; George Dunlap ; Ian Jackson ; Konrad Rzeszutek Wilk ; Stefano Stabellini ; Tim

Re: [Xen-devel] [PATCH v8 6/6] introduce a 'passthrough' configuration option to xl.cfg...

2019-09-06 Thread Julien Grall
Hi Paul, On 9/6/19 9:08 AM, Paul Durrant wrote: -Original Message- From: Julien Grall Sent: 05 September 2019 21:28 To: Paul Durrant ; xen-devel@lists.xenproject.org Cc: Jan Beulich ; Ian Jackson ; Wei Liu ; Andrew Cooper ; George Dunlap ; Konrad Rzeszutek Wilk ; Stefano Stabellini

Re: [Xen-devel] [PATCH v2 00/12] livepatch: new features and fixes

2019-09-06 Thread Julien Grall
expectations.c create mode 100644 xen/test/livepatch/xen_expectations_fail.c create mode 100644 xen/test/livepatch/xen_prepost_hooks.c create mode 100644 xen/test/livepatch/xen_prepost_hooks_fail.c -- Julien Grall ___ Xen-devel mailing list X

Re: [Xen-devel] [PATCH v2 00/12] livepatch: new features and fixes

2019-09-06 Thread Julien Grall
. I believe all the modifications are under in livepatch.c files. So your Ack should be sufficient here :). Anyway, feel free to add mine on Arm specific modifications. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function

2019-09-07 Thread Julien Grall
hence why I think this was unnoticed. I will see if I can reproduce it and send a patch. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 14/28] xen/arm32: head: Rework and document check_cpu_mode()

2019-09-07 Thread Julien Grall
Hi Stefano, On 8/22/19 6:14 PM, Stefano Stabellini wrote: On Mon, 12 Aug 2019, Julien Grall wrote: A branch in the success case can be avoided by inverting the branch condition. At the same time, remove a pointless comment as Xen can only run at Hypervisor Mode. Lastly, document the behavior

Re: [Xen-devel] Looking for Semester long Project

2019-09-09 Thread Julien Grall
this project in terms of difficulty, potential estimate on time required. Andrew also mentioned a slighter bigger xen/linux project and we would like to know more detail about this one as well. Cheers, -- Julien Grall ___ Xen-dev

Re: [Xen-devel] [PATCH v3 1/2] sysctl: report existing physcaps on ARM

2019-09-09 Thread Julien Grall
PHYSCAP_hvm is always reported, and Ditto. setting PHYSCAP_directio has been moved to common code since the same logic to set it is used by x86 and ARM. Ditto. Signed-off-by: Roger Pau Monné Reviewed-by: Paul Durrant Acked-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall

Re: [Xen-devel] [PATCH v3 2/2] sysctl/libxl: choose a sane default for HAP

2019-09-09 Thread Julien Grall
cked-by: Jan Beulich For the Arm bits: Acked-by: Julien Grall Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 0/2] libxl: choose a sane default for HAP

2019-09-09 Thread Julien Grall
r Pau Monne (2): sysctl: report existing physcaps on ARM I have committed this patch. sysctl/libxl: choose a sane default for HAP This one requires an Ack from the tools maintainers. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-

Re: [Xen-devel] [PATCH V3 1/8] iommu/arm: Add iommu_helpers.c file to keep common for IOMMUs stuff

2019-09-09 Thread Julien Grall
u_helpers.c for the upcoming IPMMU driver to be able to re-use them. Signed-off-by: Oleksandr Tyshchenko CC: Julien Grall [...] static __init const struct arm_smmu_device *find_smmu(const struct device *dev) diff --git a/xen/include/asm-arm/iommu.h b/xen/include/asm-arm/iommu.h index 9

Re: [Xen-devel] [PATCH V3 2/8] iommu/arm: Add ability to handle deferred probing request

2019-09-09 Thread Julien Grall
nless it breaks the compilation without it. Signed-off-by: Oleksandr Tyshchenko CC: Julien Grall --- Changes V2 -> V3: - removed deferred_probe field from struct dt_device_node, re-used domain_list instead - documented domain_list usage - added ASSERT to check that n

Re: [Xen-devel] [PATCH V3 6/8] iommu: Add of_xlate callback

2019-09-09 Thread Julien Grall
ately. I have stated my preference before, but this is not a strong one nor a must. If this is your condition to get the series accepted, then Oleksandr should follow your requested. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-

Re: [Xen-devel] [PATCH V3 5/8] iommu/arm: Add lightweight iommu_fwspec support

2019-09-09 Thread Julien Grall
on which version of Linux this is based on. So if there is a critical bug in Linux we can port it. The rest of the patch looks good to me. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH V3 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-09 Thread Julien Grall
. The later can be called from dom0. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/iommu/iommu.txt Signed-off-by: Oleksandr Tyshchenko CC: Julien Grall --- Changes V2 -> V3: - clarified patch description - clarified comments in code - modified to provide DT

Re: [Xen-devel] [PATCH V3 8/8] iommu/arm: Add Renesas IPMMU-VMSA support

2019-09-09 Thread Julien Grall
n ret; +} + +iommu_set_ops(&ipmmu_iommu_ops); + +return 0; +} + +DT_DEVICE_START(ipmmu, "Renesas IPMMU-VMSA", DEVICE_IOMMU) +.dt_match = ipmmu_dt_match, +.init = ipmmu_init, +DT_DEVICE_END + +/* + * Local variables: + * mode: C + * c-file-style: "BSD&q

Re: [Xen-devel] [PATCH 5/5] xen/arm: optee: remove experimental status

2019-09-09 Thread Julien Grall
On 8/23/19 8:20 PM, Volodymyr Babchuk wrote: Hi Julien, Hi, Apologies for the delay. Julien Grall writes: Hi, On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: As all TODOs and potential security issues are resolved now, remove experimental status from OP-TEE mediator. Looking at

Re: [Xen-devel] [PATCH 1/5] xen/arm: optee: impose limit on shared buffer size

2019-09-09 Thread Julien Grall
) looks random. So either you want to have a different version of the comment or you want to move the BUILD_BUG_ON() to somewhere else. page = get_domain_ram_page(gaddr_to_gfn(guest_data->pages_list[idx])); if ( !page ) Cheers, -- Julien Grall __

Re: [Xen-devel] [PATCH 2/5] xen/arm: optee: check for preemption while freeing shared buffers

2019-09-09 Thread Julien Grall
e. In this case, the hypercall_preempt_check() before the loop could be dropped. +return -ERESTART; + free_optee_shm_buf(ctx, optee_shm_buf->cookie); +} if ( hypercall_preempt_check() ) return -ERESTART; Cheers, -- Ju

Re: [Xen-devel] [PATCH 4/5] xen/arm: optee: handle share buffer translation error

2019-09-10 Thread Julien Grall
return; +} +break; +case OPTEE_RPC_CMD_SHM_FREE: +free_optee_shm_buf(ctx, shm_rpc->xen_arg->params[0].u.value.b); + if ( call->rpc_data_cookie == + shm_rpc->xen_arg->params[0].u.value.b ) +

Re: [Xen-devel] [PATCH v3 04/12] xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm

2019-09-10 Thread Julien Grall
y the Ocaml/C ABI checking." or something suitable. With the commit message updated: Acked-by: Julien Grall Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH V3 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-10 Thread Julien Grall
well? Yes. Somehow I thought add_device was implemented for the SMMU driver, but I got confused with the Linux IOMMU ops. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH V3 8/8] iommu/arm: Add Renesas IPMMU-VMSA support

2019-09-10 Thread Julien Grall
Hi, On 9/10/19 12:04 PM, Oleksandr wrote: On 10.09.19 00:24, Julien Grall wrote:   ---help---   Enable all the required drivers for Renesas RCar3   diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig index a3c0649..47eadb4 100644 --- a/xen/drivers

Re: [Xen-devel] [PATCH] [RFC V2] xen/arm: Restrict "p2m_ipa_bits" according to the IOMMU requirements

2019-09-10 Thread Julien Grall
least 40-bits before overriding it. Signed-off-by: Oleksandr Tyshchenko CC: Julien Grall --- Still RFC: 1. Patch assumes that IPMMU support is already in. 2. Not checked for the SMMU. Changes since RFC V1 [1]: - Don't update p2m_ipa_bits by the IOMMU drivers directly, introdu

Re: [Xen-devel] [PATCH v4 1/3] Remove hardcoding from scripts/add_maintainers.pl

2019-09-10 Thread Julien Grall
Hi Lars, On 9/4/19 12:30 PM, Lars Kurth wrote: Instead of using a hardcoded location, inherit the location from $0 Signed-off-by: Lars Kurth Acked-by: Julien Grall Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

2019-09-10 Thread Julien Grall
: */ V: xen-maintainers-1 Signed-off-by: Lars Kurth Acked-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

2019-09-10 Thread Julien Grall
Hi, Actually, I have one question about the template (my ack still stands). On 9/10/19 4:18 PM, Julien Grall wrote: Hi Lars, On 9/4/19 12:30 PM, Lars Kurth wrote: This change provides sufficient information to allow get_maintainer.pl / add_maintainers.pl scripts to be run on xen sister

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

2019-09-10 Thread Julien Grall
Hi Lars, On 9/10/19 4:35 PM, Lars Kurth wrote: On 10/09/2019, 16:31, "Julien Grall" wrote: Hi, Actually, I have one question about the template (my ack still stands). On 9/10/19 4:18 PM, Julien Grall wrote: > Hi Lars, > > On 9/

Re: [Xen-devel] [PATCH] [RFC V2] xen/arm: Restrict "p2m_ipa_bits" according to the IOMMU requirements

2019-09-10 Thread Julien Grall
Hi, On 9/10/19 5:24 PM, Oleksandr wrote: On 10.09.19 18:11, Julien Grall wrote: Hi Oleksandr, Hi, Julien On 8/23/19 8:34 PM, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko There is a strict requirement for the IOMMU which wants to share the P2M table with the CPU. The IOMMU&#

Re: [Xen-devel] [PATCH v4 1/8] xen/arm: introduce handle_device_interrupts

2019-09-10 Thread Julien Grall
Hi Stefano, On 8/21/19 4:53 AM, Stefano Stabellini wrote: Move the interrupt handling code out of handle_device to a new function so that it can be reused for dom0less VMs (it will be used in later patches). Signed-off-by: Stefano Stabellini Acked-by: Julien Grall Cheers, --- Changes in

Re: [Xen-devel] [PATCH v4 2/8] xen/arm: export device_tree_get_reg and device_tree_get_u32

2019-09-10 Thread Julien Grall
cribe all the function implemented by common/device_tree.c. Most likely you want to declare the prototype in asm-arm/setup.h as this is done for all the others function exported in bootfdt.c. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-

Re: [Xen-devel] [PATCH v4 3/8] xen/arm: introduce kinfo->guest_phandle_gic

2019-09-10 Thread Julien Grall
00) 2) Use cpu_to_be32(GUEST_PHANDLE_GIC) It would be good to agree how GUEST_PHANDLE_GIC is used so we have the same behavior when the DT is created by Xen and libxl. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 3/8] xen/arm: introduce kinfo->guest_phandle_gic

2019-09-11 Thread Julien Grall
Hi, On 9/10/19 10:14 PM, Julien Grall wrote: diff --git a/xen/include/asm-arm/kernel.h b/xen/include/asm-arm/kernel.h index 33f3e72b11..760434369b 100644 --- a/xen/include/asm-arm/kernel.h +++ b/xen/include/asm-arm/kernel.h @@ -36,6 +36,9 @@ struct kernel_info {   /* Enable pl011 emulation

Re: [Xen-devel] [PATCH v4 4/8] xen/arm: copy dtb fragment to guest dtb

2019-09-11 Thread Julien Grall
fo { paddr_t gnttab_size; /* boot blob load addresses */ -const struct bootmodule *kernel_bootmodule, *initrd_bootmodule; +const struct bootmodule *kernel_bootmodule, *initrd_bootmodule, *dtb_bootmodule; const char* cmdline; paddr_t dtb_paddr; paddr_t initrd_paddr; Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 5/8] xen/arm: assign devices to boot domains

2019-09-11 Thread Julien Grall
0 ) +return res; +} +/* copy all other properties */ +else +{ +res = fdt_property(fdt, fdt_string(pfdt, nameoff), prop->data, + fdt32_to_cpu(prop->len)); +if ( res ) +retu

Re: [Xen-devel] [PATCH v4 6/8] xen/arm: handle "multiboot, device-tree" compatible nodes

2019-09-11 Thread Julien Grall
Stabellini Acked-by: Julien Grall Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 7/8] xen/arm: introduce nr_spis

2019-09-11 Thread Julien Grall
instance, if you were to expose 256 interrupts for 4 domains, this will roughly use 80KB of memory. I don't think this is what you had in mind as "low footprint". Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen

Re: [Xen-devel] [PATCH v4 8/8] xen/arm: add dom0-less device assignment info to docs

2019-09-11 Thread Julien Grall
upt-parent = <&gic>; +interrupts = <0x0 0x3f 0x4 0x0 0x3f 0x4>; +xen,path = "/amba/ethernet@ff0e"; +xen,reg = <0x0 0xff0e 0x1000 0x0 0xff0e>; + +phy@c { + reg = <0

Re: [Xen-devel] [PATCH v2 35/48] xen/sched: add fall back to idle vcpu when scheduling unit

2019-09-11 Thread Julien Grall
lling check_for_livepatch_work is needed. Signed-off-by: Juergen Gross I haven't looked at the full patch. The arm change is quite minimal, so for just arm-bits: Acked-by: Julien Grall Cheers, -- Julien Grall ___ Xen-devel mailing list

[Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()

2019-09-11 Thread Julien Grall
One line in process_multiboot_node() is using hard tab rather than soft tab. So fix it! Signed-off-by: Julien Grall --- xen/arch/arm/bootfdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 258b057f00..623173bc7f 100644

[Xen-devel] [PATCH] xen/arm: setup: Relocate the Device-Tree later on in the boot

2019-09-11 Thread Julien Grall
ff-by: Julien Grall --- xen/arch/arm/setup.c | 58 1 file changed, 22 insertions(+), 36 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1b303bde34..ebbfad94e4 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/se

Re: [Xen-devel] [PATCH] [RFC V2] xen/arm: Restrict "p2m_ipa_bits" according to the IOMMU requirements

2019-09-11 Thread Julien Grall
Hi, On 9/11/19 5:34 PM, Oleksandr wrote: On 10.09.19 21:55, Julien Grall wrote: Hi, Hi Julien On 9/10/19 5:24 PM, Oleksandr wrote: On 10.09.19 18:11, Julien Grall wrote: Hi Oleksandr, Hi, Julien On 8/23/19 8:34 PM, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko There

Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()

2019-09-11 Thread Julien Grall
On Wed, 11 Sep 2019, 18:36 Volodymyr Babchuk, wrote: > > Julien Grall writes: > > > One line in process_multiboot_node() is using hard tab rather than soft > > tab. So fix it! > > > > Signed-off-by: Julien Grall > Reviewed-by: Volodymyr Babchuk > > So

Re: [Xen-devel] [RFC 4/9] arm64: utilize time accounting

2019-09-12 Thread Julien Grall
On Thu, 12 Sep 2019, 13:10 Andrii Anisov, wrote: > Hello Volodymyr, > > On 11.09.19 20:48, Volodymyr Babchuk wrote: > > > > Hi Andrii, > > > > As we agreed, I'll wipe out debugging remains as well as cleanup coding > style nits and resend the series. This an RFC and I am sure there current stat

Re: [Xen-devel] [PATCH] Update my MAINTAINERS entries

2019-09-12 Thread Julien Grall
Hi Paul, On 9/12/19 3:18 PM, Paul Durrant wrote: My Citrix email address will expire shortly. Good luck for the future! Signed-off-by: Paul Durrant Acked-by: Julien Grall Cheers, --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Konrad

Re: [Xen-devel] [PATCH 4/5] xen/arm: optee: handle share buffer translation error

2019-09-12 Thread Julien Grall
Hi Volodymyr, On 9/11/19 7:32 PM, Volodymyr Babchuk wrote: Julien Grall writes: Hi Volodymyr, On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: There is a case possible, when OP-TEE asks guest to allocate shared buffer, but Xen for some reason can't translate buffer's addresse

Re: [Xen-devel] [PATCH 5/5] xen/arm: optee: remove experimental status

2019-09-12 Thread Julien Grall
Hi Volodymyr, On 9/11/19 7:41 PM, Volodymyr Babchuk wrote: Julien Grall writes: On 8/23/19 8:20 PM, Volodymyr Babchuk wrote: Hi Julien, Hi, Apologies for the delay. It is okay. I myself was busy a bit. Julien Grall writes: Hi, On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: As

Re: [Xen-devel] [PATCH 1/5] xen/arm: optee: impose limit on shared buffer size

2019-09-12 Thread Julien Grall
Hi Volodymyr, On 9/11/19 7:48 PM, Volodymyr Babchuk wrote: Julien Grall writes: Hi Volodymyr, On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: We want to limit number of calls to lookup_and_pin_guest_ram_addr() per one request. There are two ways to do this: either preempt translate_noncontig

Re: [Xen-devel] [PATCH 2/5] xen/arm: optee: check for preemption while freeing shared buffers

2019-09-12 Thread Julien Grall
Hi Volodymyr, On 9/11/19 7:53 PM, Volodymyr Babchuk wrote: Julien Grall writes: Hi Volodymyr, On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: Now we have limit for one shared buffer size, so we can be sure that one call to free_optee_shm_buf() will not free all MAX_TOTAL_SMH_BUF_PG pages at

Re: [Xen-devel] [PATCH 1/5] xen/arm: optee: impose limit on shared buffer size

2019-09-12 Thread Julien Grall
Hi, On 9/12/19 8:45 PM, Volodymyr Babchuk wrote: Hi Julien, Julien Grall writes: Hi Volodymyr, On 9/11/19 7:48 PM, Volodymyr Babchuk wrote: Julien Grall writes: Hi Volodymyr, On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: We want to limit number of calls to

Re: [Xen-devel] [PATCH] xen: fix arm build with debugtrace configured

2019-09-13 Thread Julien Grall
mentioning the offending commit and/or by naming the specific build problem. It would have been nice you the commit message was at least updated before committing. With the current one it is unclear why it is necessary so it feels quite random. Cheers, -- Julien Grall

[Xen-devel] [PATCH for-4.13] xen/arm: Add Skeleton for using configuring early printk using Kconfig

2019-09-13 Thread Julien Grall
: Julien Grall --- I have sent it as RFC because this is not complete. I will convert the rest once we agree the approach is correct. --- xen/Kconfig.debug | 2 ++ xen/arch/arm/Kconfig.debug | 40 ++ xen/arch/arm/Rules.mk

Re: [Xen-devel] [PATCH] xen/arm: platform: additional Raspberry Pi compatible string

2019-09-13 Thread Julien Grall
n/arch/arm/platforms/brcm-raspberry-pi.c @@ -21,6 +21,7 @@ static const char *const brcm_bcm2838_dt_compat[] __initconst = { +"brcm,bcm2711", If a new compatible is added, then you likely need to rename the different structure within this file. "brcm,bcm2838"

[Xen-devel] dom/xen heap and boot allocator (WAS Re: [xen-unstable-smoke test] 141333: regressions - FAIL)

2019-09-15 Thread Julien Grall
RATE_XENHEAP=y. It feels to me that imposing to give a xenheap page to the boot allocator is quite ugly. As the boot allocator will be used in most of the case, statically allocating bootmem_region_list maybe the best. Any thoughts? Regarding alloc_boot_pages(), I am a bit unsure how to proce

Re: [Xen-devel] [PATCH v12 6/6] introduce a 'passthrough' configuration option to xl.cfg...

2019-09-17 Thread Julien Grall
: The 'iommu_memkb' overhead in libxl_domain_build_info will now only be set if passthrough is 'sync_pt' (or xl has chosen this mode as a default). Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich Acked-by: Christian Lindig --- Cc: Ian Jackson Cc: Wei L

Re: [Xen-devel] [PATCH v11 1/6] domain: introduce XEN_DOMCTL_CDF_iommu flag

2019-09-17 Thread Julien Grall
Hi Paul, On 9/16/19 9:34 AM, Paul Durrant wrote: I guess this still needs ARM and toolstack acks? For Arm bits: Acked-by: Julien Grall I am adding Anthony for the libxl. Cheers, -Original Message- From: Paul Durrant Sent: 13 September 2019 11:58 To: xen-devel

<    1   2   3   4   5   6   7   8   9   10   >