Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-03-20 Thread Frediano Ziglio
On Thu, Mar 20, 2025 at 3:15 PM Jan Beulich wrote: > > On 20.03.2025 15:33, Frediano Ziglio wrote: > > On Thu, Mar 6, 2025 at 3:02 PM Frediano Ziglio > > wrote: > >> > >> On Thu, Mar 6, 2025 at 2:26 PM Jan Beulich wrote: > >>> > >>> On 26.02.2025 19:54, Marek Marczykowski-Górecki wrote: > O

[PATCH v2 4/4] x86/traps: Introduce early_traps_init() and simplify setup

2025-03-20 Thread Andrew Cooper
Something I overlooked when last cleaning up exception handling is that a TSS is not necessary if IST isn't configured, and IST isn't necessary until we're running guest code. Introduce early_traps_init(), and rearrange the existing logic between this and traps_init() later on boot, to allow defer

Re: [PATCH v3 2/3] PCI: vmd: Disable MSI remapping bypass under Xen

2025-03-20 Thread Bjorn Helgaas
On Wed, Feb 19, 2025 at 10:20:56AM +0100, Roger Pau Monne wrote: > MSI remapping bypass (directly configuring MSI entries for devices on the > VMD bus) won't work under Xen, as Xen is not aware of devices in such bus, > and hence cannot configure the entries using the pIRQ interface in the PV > cas

Re: [XEN PATCH v1 4/4] x86:hvm: make nestedhvm support optional

2025-03-20 Thread Denis Mukhin
Hi, On Thursday, March 20th, 2025 at 3:40 AM, Sergiy Kibrik wrote: > > > Introduce NESTEDHVM config option that controls nested virtualization in both > SVM & VMX code. The option is for reduction of dead code on systems that > aren't intended to run in nested mode. > > Signed-off-by: Sergiy

[XEN PATCH v1 3/4] x86:hvm: guard calls to nestedhvm routines

2025-03-20 Thread Sergiy Kibrik
Check whether nested HVM is enabled for domain before calling nestedhvm_vcpu_*() and other not already guarded nestedhvm functions. Signed-off-by: Sergiy Kibrik --- xen/arch/x86/hvm/hvm.c | 6 -- xen/arch/x86/hvm/svm/asid.c | 2 +- xen/arch/x86/hvm/svm/svm.c | 6 +++--- 3 files changed

Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op

2025-03-20 Thread Oleksandr Tyshchenko
On 20.03.25 09:30, Jan Beulich wrote: Hello Jan, Mykyta, all On 19.03.2025 21:42, Oleksandr Tyshchenko wrote: On 19.03.25 14:37, Jan Beulich wrote: On 19.03.2025 13:05, Mykyta Poturai wrote: On 18.03.25 16:26, Jan Beulich wrote: On 18.03.2025 14:31, Mykyta Poturai wrote: On 18.03.25 12

Re: [PATCH v1] x86: make Viridian support optional

2025-03-20 Thread Jan Beulich
On 20.03.2025 16:18, Alejandro Vallejo wrote: > On Thu Mar 20, 2025 at 9:39 AM GMT, Sergiy Kibrik wrote: >> hi Alejandro, >> >> 17.03.25 11:19, Alejandro Vallejo: >> [..] >>>  endif >>> >>> +config HVM_VIRIDIAN >>> +       bool "Viridian enlightenments support" if EXPERT >>> +     

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-20 Thread Jan Beulich
On 20.03.2025 16:17, Marek Marczykowski-Górecki wrote: > On Thu, Mar 20, 2025 at 02:35:59PM +, Anthony PERARD wrote: >> On Thu, Mar 20, 2025 at 02:59:04PM +0100, Marek Marczykowski-Górecki wrote: >>> On Thu, Mar 20, 2025 at 02:49:27PM +0100, Jan Beulich wrote: On 20.03.2025 13:51, Marek Ma

[PATCH v2 2/4] automation/cirrus-ci: build XTF

2025-03-20 Thread Roger Pau Monne
In preparation for using the XTF selftests to smoke test the FreeBSD based Xen builds. Signed-off-by: Roger Pau Monné --- Changes since v1: - Use production version. --- .cirrus.yml | 24 1 file changed, 24 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 95d

Re: [PATCH v3] x86/vga: fix mapping of the VGA text buffer

2025-03-20 Thread Jan Beulich
On 20.03.2025 16:11, Roger Pau Monne wrote: > The call to ioremap_wc() in video_init() will always fail, because > video_init() is called ahead of vm_init_type(), and so the underlying > __vmap() call will fail to allocate the linear address space. > > Fix by reverting to the previous behavior and

Re: [PATCH v1] x86: make Viridian support optional

2025-03-20 Thread Alejandro Vallejo
On Thu Mar 20, 2025 at 3:22 PM GMT, Jan Beulich wrote: > On 20.03.2025 16:18, Alejandro Vallejo wrote: > > On Thu Mar 20, 2025 at 9:39 AM GMT, Sergiy Kibrik wrote: > >> hi Alejandro, > >> > >> 17.03.25 11:19, Alejandro Vallejo: > >> [..] > >>>  endif > >>> > >>> +config HVM_VIRIDIAN > >>>

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-20 Thread Marek Marczykowski-Górecki
On Thu, Mar 20, 2025 at 04:21:18PM +0100, Jan Beulich wrote: > On 20.03.2025 16:17, Marek Marczykowski-Górecki wrote: > > On Thu, Mar 20, 2025 at 02:35:59PM +, Anthony PERARD wrote: > >> On Thu, Mar 20, 2025 at 02:59:04PM +0100, Marek Marczykowski-Górecki wrote: > >>> On Thu, Mar 20, 2025 at 02

[PATCH 2/3] Xen: Update compiler checks

2025-03-20 Thread Andrew Cooper
We didn't really have a Clang check before, so add one while adjusting the GCC check. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monné CC: Stefano Stabellini CC: Oleksii Kurochko --- xen/include/xen/compiler.h | 16 +

[PATCH 0/3] Xen: CI changes for new toolchain baseline

2025-03-20 Thread Andrew Cooper
Prep work to allow us to start making changes based on the toolchain requirements. https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1726628670 https://cirrus-ci.com/build/5232741505040384 Andrew Cooper (3): CI: Update build tests based on new minimum toolchain requirements Xen: U

Re: [PATCH 2/3] Xen: Update compiler checks

2025-03-20 Thread Jan Beulich
On 20.03.2025 16:32, Andrew Cooper wrote: > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -1,18 +1,10 @@ > #ifndef __LINUX_COMPILER_H > #define __LINUX_COMPILER_H > > -#if !defined(__GNUC__) || (__GNUC__ < 4) > -#error Sorry, your compiler is too old/not recognized. >

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Andrew Cooper
On 20/03/2025 10:18 am, Jan Beulich wrote: > On 20.03.2025 10:53, Jan Beulich wrote: >> On 20.03.2025 09:34, Jan Beulich wrote: >>> On 20.03.2025 09:14, Roger Pau Monné wrote: I wonder how this worked then, as I've tested with the xen.efi smoke test in gitlab CI. Maybe ovmf doesn't ackno

Re: [PATCH 08/16] xen/arm: add watchdog domain suspend/resume helpers

2025-03-20 Thread Grygorii Strashko
On 05.03.25 11:11, Mykola Kvach wrote: From: Mykola Kvach This patch implements suspend/resume helpers for the watchdog. While a domain is suspended its watchdogs must be paused. Otherwise, if the domain stays in the suspend state for a longer period of time compared to the watchdog period,

Re: [PATCH v2 2/2] x86/PVH: account for module command line length

2025-03-20 Thread Jan Beulich
On 20.03.2025 11:39, Andrew Cooper wrote: > On 20/03/2025 9:28 am, Jan Beulich wrote: >> As per observation in practice, initrd->cmdline_pa is not normally zero. >> Hence so far we always appended at least one byte. That alone may >> already render insufficient the "allocation" made by find_memory(

[PATCH] process/release: mention MAINTAINER adjustments

2025-03-20 Thread Jan Beulich
For many major releases I've been updating ./MAINTAINERS _after_ the respective branch was handed over to me. That update, however, is relevant not only from the .1 minor release onwards, but right from the .0 release. Hence it ought to be done as one of the last things before tagging the tree for

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-20 Thread Marek Marczykowski-Górecki
On Thu, Mar 20, 2025 at 02:35:59PM +, Anthony PERARD wrote: > On Thu, Mar 20, 2025 at 02:59:04PM +0100, Marek Marczykowski-Górecki wrote: > > On Thu, Mar 20, 2025 at 02:49:27PM +0100, Jan Beulich wrote: > > > On 20.03.2025 13:51, Marek Marczykowski-Górecki wrote: > > > > On Thu, Mar 20, 2025 at

Re: [PATCH v1] x86: make Viridian support optional

2025-03-20 Thread Alejandro Vallejo
On Thu Mar 20, 2025 at 9:39 AM GMT, Sergiy Kibrik wrote: > hi Alejandro, > > 17.03.25 11:19, Alejandro Vallejo: > [..] > >  endif > > > > +config HVM_VIRIDIAN > > +       bool "Viridian enlightenments support" if EXPERT > > +       depends on HVM > > +       default y > >

[PATCH v2] x86/irq: introduce APIC_VECTOR_VALID()

2025-03-20 Thread dmkhn
Add new macro APIC_VECTOR_VALID() to validate the interrupt vector range as per [1]. This macro replaces hardcoded checks against the open-coded value 16 in LAPIC and virtual LAPIC code and simplifies the code a bit. [1] Intel SDM volume 3A Chapter "ADVANCED PROGRAMMABLE INTERRUPT CONTROLLER"

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-03-20 Thread Jan Beulich
On 20.03.2025 21:10, Frediano Ziglio wrote: > On Thu, Mar 20, 2025 at 3:15 PM Jan Beulich wrote: >> >> On 20.03.2025 15:33, Frediano Ziglio wrote: >>> On Thu, Mar 6, 2025 at 3:02 PM Frediano Ziglio >>> wrote: On Thu, Mar 6, 2025 at 2:26 PM Jan Beulich wrote: > > On 26.02.2025 1

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Roger Pau Monné
On Wed, Mar 19, 2025 at 11:46:22AM +0100, Jan Beulich wrote: > On 19.03.2025 11:32, Jan Beulich wrote: > > On 18.03.2025 18:35, Roger Pau Monne wrote: > >> Relocations are now applied after having moved the trampoline, > > > > That's two entirely different sets of relocations, isn't it? Right, t

Re: [PATCH v2 1/2] x86/PVH: don't open-code elf_round_up()

2025-03-20 Thread Andrew Cooper
On 20/03/2025 9:28 am, Jan Beulich wrote: > Signed-off-by: Jan Beulich > --- > I was wondering whether in elf_round_up() itself we might better use > ROUNDUP(). I did wonder that too.  It's probably easier to arrange now we've got xen-tools/common-macros.h. Reviewed-by: Andrew Cooper

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-20 Thread Anthony PERARD
On Wed, Mar 19, 2025 at 02:40:33PM +0100, Marek Marczykowski-Górecki wrote: > There are clearly some build path embedding left. And > -ffile-prefix-map=/-fdebug-prefix-map= doesn't work correctly with > XEN_ROOT having xen/.. at the end. > BTW, would it be acceptable to have this? > > $(call cc

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Jan Beulich
On 20.03.2025 10:53, Jan Beulich wrote: > On 20.03.2025 09:34, Jan Beulich wrote: >> On 20.03.2025 09:14, Roger Pau Monné wrote: >>> I wonder how this worked then, as I've tested with the xen.efi smoke >>> test in gitlab CI. Maybe ovmf doesn't acknowledge the RX sections and >>> unconditionally se

Re: [PATCH v1] x86: make Viridian support optional

2025-03-20 Thread Sergiy Kibrik
hi Alejandro, 17.03.25 11:19, Alejandro Vallejo: [..]  endif +config HVM_VIRIDIAN +       bool "Viridian enlightenments support" if EXPERT +       depends on HVM +       default y + I don't see why this should be gated by EXPERT, provided a suitable (now absent) help

Re: [PATCH 02/16] xen/x86: Move freeze/thaw_domains into common files

2025-03-20 Thread Mykola Kvach
On Wed, Mar 19, 2025 at 2:47 PM Jan Beulich wrote: > > On 19.03.2025 13:03, Mykola Kvach wrote: > > On Wed, Mar 5, 2025 at 6:48 PM Jan Beulich wrote: > >> > >> On 05.03.2025 10:11, Mykola Kvach wrote: > >>> From: Mirela Simonovic > >>> > >>> These functions will be reused by suspend/resume suppo

[PATCH v2 0/2] x86/PVH: initial space allocation

2025-03-20 Thread Jan Beulich
Going on top of "x86/boot: Simplify the expression for extra allocation space", first some tidying and then a bug fix. 1: don't open-code elf_round_up() 2: account for module command line length Jan

[PATCH v2 2/2] x86/PVH: account for module command line length

2025-03-20 Thread Jan Beulich
As per observation in practice, initrd->cmdline_pa is not normally zero. Hence so far we always appended at least one byte. That alone may already render insufficient the "allocation" made by find_memory(). Things would be worse when there's actually a (perhaps long) command line. Skip setup when

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Jan Beulich
On 20.03.2025 09:14, Roger Pau Monné wrote: > On Wed, Mar 19, 2025 at 11:46:22AM +0100, Jan Beulich wrote: >> On 19.03.2025 11:32, Jan Beulich wrote: >>> On 18.03.2025 18:35, Roger Pau Monne wrote: Relocations are now applied after having moved the trampoline, >>> >>> That's two entirely diffe

Re: [PATCH v1 3/4] xen/riscv: implement basic aplic_preinit()

2025-03-20 Thread Jan Beulich
On 19.03.2025 17:58, Oleksii Kurochko wrote: > > On 3/17/25 4:40 PM, Jan Beulich wrote: >> On 11.03.2025 17:19, Oleksii Kurochko wrote: >>> Based on the code from [1] provided by Romain Caritey from Microchip >>> with some minor changes(): >> "Based on", to me at least, suggests an import from som

Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-03-20 Thread Jan Beulich
On 20.03.2025 01:57, Stefano Stabellini wrote: > On Wed, 19 Mar 2025, Jan Beulich wrote: >> What about xenctl_bitmap_to_bitmap()? > > Let me see first if I managed to handle bitmap_to_xenctl_bitmap well. Well, the code looks correct to me, but the description now has gone stale. I also wonder wh

Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op

2025-03-20 Thread Jan Beulich
On 19.03.2025 21:42, Oleksandr Tyshchenko wrote: > On 19.03.25 14:37, Jan Beulich wrote: >> On 19.03.2025 13:05, Mykyta Poturai wrote: >>> On 18.03.25 16:26, Jan Beulich wrote: On 18.03.2025 14:31, Mykyta Poturai wrote: > On 18.03.25 12:11, Jan Beulich wrote: >> On 18.03.2025 10:10, My

Re: [PATCH] tools/arm: Fix nr_spis handling v2

2025-03-20 Thread Alejandro Vallejo
On Wed Mar 19, 2025 at 2:05 PM GMT, Andrew Cooper wrote: > On 19/03/2025 2:01 pm, Alejandro Vallejo wrote: > > On Tue Mar 18, 2025 at 9:00 AM GMT, Michal Orzel wrote: > >> We are missing a way to detect whether a user provided a value for > >> nr_spis equal to 0 or did not provide any value (defaul

[MINI-OS PATCH 1/2] 9pfs: add fstat file operation hook

2025-03-20 Thread Juergen Gross
Add a file operations fstat hook to the 9pfs frontend. Signed-off-by: Juergen Gross --- 9pfront.c | 29 + 1 file changed, 29 insertions(+) diff --git a/9pfront.c b/9pfront.c index 1741d600..a65fe26d 100644 --- a/9pfront.c +++ b/9pfront.c @@ -85,6 +85,8 @@ struct file

[MINI-OS PATCH 2/2] 9pfs: add lseek file operation hook

2025-03-20 Thread Juergen Gross
Add a file operations lseek hook to the 9pfs frontend. Just use the lseek_default() implementation. Signed-off-by: Juergen Gross --- 9pfront.c | 1 + 1 file changed, 1 insertion(+) diff --git a/9pfront.c b/9pfront.c index a65fe26d..837e404b 100644 --- a/9pfront.c +++ b/9pfront.c @@ -1325,6 +132

[MINI-OS PATCH 0/2] 9pfs: add some file operation hooks

2025-03-20 Thread Juergen Gross
For being able to store the Xenstore state in preparation of a live update operation, 9pfront is needing support for fstat and lseek. Juergen Gross (2): Mini-OS: 9pfs: add fstat file operation hook Mini-OS: 9pfs: add lseek file operation hook 9pfront.c | 30 ++ 1

RE: [PATCH v1 03/19] xen/sysctl: wrap around XEN_SYSCTL_readconsole

2025-03-20 Thread Penny, Zheng
[Public] Hi, Sorry for the late reply, got side-tracked for a while > -Original Message- > From: Alejandro Vallejo > Sent: Thursday, March 13, 2025 8:03 PM > To: Penny, Zheng ; xen-devel@lists.xenproject.org > Cc: Huang, Ray ; Andrew Cooper > ; Anthony PERARD ; > Orzel, Michal ; Jan Beu

Re: [PATCH v3 6/7] xen: introduce Kconfig ARCH_PAGING_MEMPOOL

2025-03-20 Thread Jan Beulich
On 19.03.2025 17:31, Oleksii Kurochko wrote: > > On 3/19/25 12:35 PM, Jan Beulich wrote: >> On 18.03.2025 14:05, Oleksii Kurochko wrote: >>> On 3/17/25 9:07 PM, Luca Fancellu wrote: From: Penny Zheng ARM MPU system doesn't need to use paging memory pool, as MPU memory mapping t

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Jan Beulich
On 20.03.2025 09:34, Jan Beulich wrote: > On 20.03.2025 09:14, Roger Pau Monné wrote: >> I wonder how this worked then, as I've tested with the xen.efi smoke >> test in gitlab CI. Maybe ovmf doesn't acknowledge the RX sections and >> unconditionally sets all mappings as writable? > > Possible. An

Re: [PATCH 03/16] xen/arm: introduce a separate struct for watchdog timers

2025-03-20 Thread Mykola Kvach
Hi, On Thu, Mar 13, 2025 at 5:27 PM Jan Beulich wrote: > > On 05.03.2025 10:11, Mykola Kvach wrote: > > From: Mirela Simonovic > > > > Introduce a separate struct for watchdog timers. It is needed to properly > > implement the suspend/resume actions for the watchdog timers. To be able > > to res

[XEN PATCH v1 0/4] make nested virtualization support optional

2025-03-20 Thread Sergiy Kibrik
Here're a couple of patches that introduce a Kconfig control for user to be able to remove nested HVM code from the build and hence to tune their system in case nested VMs aren't required. The first two patches are minor fixes and not directly related to nested HVM, but since they also modify the

Re: [PATCH 03/16] xen/arm: introduce a separate struct for watchdog timers

2025-03-20 Thread Mykola Kvach
Hi, On Wed, Mar 19, 2025 at 6:14 PM Grygorii Strashko wrote: > > > > On 05.03.25 11:11, Mykola Kvach wrote: > > From: Mirela Simonovic > > > > Introduce a separate struct for watchdog timers. It is needed to properly > > implement the suspend/resume actions for the watchdog timers. To be able >

Re: [PATCH 03/16] xen/arm: introduce a separate struct for watchdog timers

2025-03-20 Thread Jan Beulich
On 20.03.2025 11:31, Jan Beulich wrote: > On 20.03.2025 11:25, Mykola Kvach wrote: >> On Thu, Mar 13, 2025 at 5:27 PM Jan Beulich wrote: >>> On 05.03.2025 10:11, Mykola Kvach wrote: From: Mirela Simonovic Introduce a separate struct for watchdog timers. It is needed to properly >>>

[XEN PATCH v1 1/4] x86:svm: use nsvm_efer_svm_enabled() to check guest's EFER.SVME

2025-03-20 Thread Sergiy Kibrik
There's a macro for this, might improve readability a bit & save a bit of space. Signed-off-by: Sergiy Kibrik --- xen/arch/x86/hvm/svm/nestedsvm.c | 2 +- xen/arch/x86/hvm/svm/svm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xe

[XEN PATCH v1 2/4] x86:svm: rename svm/nestedhvm.h -> svm/nestedsvm.h

2025-03-20 Thread Sergiy Kibrik
This is private header for SVM code, comment in header and file's changelog suggest that intended name was svm/nestedsvm.h, so perhaps a small mistake here. Signed-off-by: Sergiy Kibrik --- xen/arch/x86/hvm/svm/intr.c | 2 +- xen/arch/x86/hvm/svm/{nestedhvm.h => nestedsvm.h

Re: [PATCH 03/16] xen/arm: introduce a separate struct for watchdog timers

2025-03-20 Thread Jan Beulich
On 20.03.2025 11:25, Mykola Kvach wrote: > On Thu, Mar 13, 2025 at 5:27 PM Jan Beulich wrote: >> On 05.03.2025 10:11, Mykola Kvach wrote: >>> From: Mirela Simonovic >>> >>> Introduce a separate struct for watchdog timers. It is needed to properly >>> implement the suspend/resume actions for the w

Re: [PATCH v9 2/8] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2025-03-20 Thread Jan Beulich
On 20.03.2025 11:47, Mykyta Poturai wrote: > On 19.03.25 17:28, Jan Beulich wrote: >> On 19.03.2025 16:21, Mykyta Poturai wrote: >>> On 17.03.25 16:56, Jan Beulich wrote: On 14.03.2025 14:34, Mykyta Poturai wrote: > From: Oleksandr Tyshchenko > > The main purpose of this patch is

Re: [XEN PATCH v1 4/4] x86:hvm: make nestedhvm support optional

2025-03-20 Thread Andrew Cooper
On 20/03/2025 10:40 am, Sergiy Kibrik wrote: > Introduce NESTEDHVM config option that controls nested virtualization in both > SVM & VMX code. The option is for reduction of dead code on systems that > aren't intended to run in nested mode. > > Signed-off-by: Sergiy Kibrik I know you're trying to

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-20 Thread Marek Marczykowski-Górecki
On Thu, Mar 20, 2025 at 02:49:27PM +0100, Jan Beulich wrote: > On 20.03.2025 13:51, Marek Marczykowski-Górecki wrote: > > On Thu, Mar 20, 2025 at 10:18:28AM +, Anthony PERARD wrote: > >> On Wed, Mar 19, 2025 at 02:40:33PM +0100, Marek Marczykowski-Górecki wrote: > >>> There are clearly some bui

Re: [PATCH] x86/boot: Untangle the trampoline copying/entry logic

2025-03-20 Thread Andrew Cooper
On 19/03/2025 9:05 am, Roger Pau Monné wrote: > On Tue, Mar 18, 2025 at 08:10:33PM +, Andrew Cooper wrote: >> The LRET is detached from the PUSHes which set it up, and this is about to >> get >> worse with the changes to trampoline relocation. For the sake of one >> variable >> read, the com

Re: [PATCH -next v6 1/8] entry: Split generic entry into generic exception and syscall entry

2025-03-20 Thread Linus Walleij
> Currently CONFIG_GENERIC_ENTRY enables both the generic exception > entry logic and the generic syscall entry logic, which are otherwise > loosely coupled. > > Introduce separate config options for these so that archtiectures can > select the two independently. This will make it easier for > arch

Re: [XEN PATCH v1 2/4] x86:svm: rename svm/nestedhvm.h -> svm/nestedsvm.h

2025-03-20 Thread Jan Beulich
On 20.03.2025 11:36, Sergiy Kibrik wrote: > This is private header for SVM code, comment in header and file's changelog > suggest that intended name was svm/nestedsvm.h, so perhaps a small mistake > here. > > Signed-off-by: Sergiy Kibrik > --- > xen/arch/x86/hvm/svm/intr.c

Re: [MINI-OS PATCH 1/2] 9pfs: add fstat file operation hook

2025-03-20 Thread Jason Andryuk
On 2025-03-20 03:49, Juergen Gross wrote: Add a file operations fstat hook to the 9pfs frontend. Signed-off-by: Juergen Gross --- @@ -950,6 +952,32 @@ static int write_9pfs(struct file *file, const void *buf, size_t nbytes) return ret; } +static int fstat_9pfs(struct file *file,

[XEN PATCH v1 4/4] x86:hvm: make nestedhvm support optional

2025-03-20 Thread Sergiy Kibrik
Introduce NESTEDHVM config option that controls nested virtualization in both SVM & VMX code. The option is for reduction of dead code on systems that aren't intended to run in nested mode. Signed-off-by: Sergiy Kibrik --- xen/arch/x86/Kconfig | 5 + xen/arch/x86/hvm/Mak

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Jan Beulich
On 20.03.2025 12:00, Andrew Cooper wrote: > On 20/03/2025 10:18 am, Jan Beulich wrote: >> On 20.03.2025 10:53, Jan Beulich wrote: >>> On 20.03.2025 09:34, Jan Beulich wrote: On 20.03.2025 09:14, Roger Pau Monné wrote: > I wonder how this worked then, as I've tested with the xen.efi smoke >

Re: [PATCH v1 03/19] xen/sysctl: wrap around XEN_SYSCTL_readconsole

2025-03-20 Thread Jan Beulich
On 20.03.2025 09:02, Penny, Zheng wrote: >> -Original Message- >> From: Alejandro Vallejo >> Sent: Thursday, March 13, 2025 8:03 PM >> >> Ok, so readconsole is done here. I see how if you're also removing the >> console >> handler for the sysctl that's a bit unwiledly to do in one go. >>

Re: [PATCH] process/release: mention MAINTAINER adjustments

2025-03-20 Thread Jan Beulich
On 20.03.2025 13:47, Andrew Cooper wrote: > On 20/03/2025 12:12 pm, Jan Beulich wrote: >> For many major releases I've been updating ./MAINTAINERS _after_ the >> respective branch was handed over to me. That update, however, is >> relevant not only from the .1 minor release onwards, but right from

Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-03-20 Thread Frediano Ziglio
On Thu, Mar 6, 2025 at 3:02 PM Frediano Ziglio wrote: > > On Thu, Mar 6, 2025 at 2:26 PM Jan Beulich wrote: > > > > On 26.02.2025 19:54, Marek Marczykowski-Górecki wrote: > > > On Mon, Feb 24, 2025 at 02:31:00PM +, Frediano Ziglio wrote: > > >> On Mon, Feb 24, 2025 at 1:16 PM Marek Marczykows

Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op

2025-03-20 Thread Mykyta Poturai
On 20.03.25 15:07, Oleksandr Tyshchenko wrote: >>> If I got correctly what is wrote in current thread (and in RFC version >>> where it was an attempt to create just Arm64's counterpart of >>> XEN_DMOP_inject_msi), my understanding (maybe not precise/correct, since >>> I am not quite familiar with x

Re: [PATCH] process/release: mention MAINTAINER adjustments

2025-03-20 Thread Julien Grall
Hi Jan, On 20/03/2025 13:45, Jan Beulich wrote: On 20.03.2025 13:47, Andrew Cooper wrote: On 20/03/2025 12:12 pm, Jan Beulich wrote: For many major releases I've been updating ./MAINTAINERS _after_ the respective branch was handed over to me. That update, however, is relevant not only from the

Re: [PATCH] process/release: mention MAINTAINER adjustments

2025-03-20 Thread Julien Grall
Hi Jan, On 20/03/2025 12:12, Jan Beulich wrote: For many major releases I've been updating ./MAINTAINERS _after_ the respective branch was handed over to me. That update, however, is relevant not only from the .1 minor release onwards, but right from the .0 release. Hence it ought to be done as

Re: [PATCH v3] x86/vga: fix mapping of the VGA text buffer

2025-03-20 Thread Roger Pau Monné
On Thu, Mar 20, 2025 at 04:25:25PM +0100, Jan Beulich wrote: > On 20.03.2025 16:11, Roger Pau Monne wrote: > > The call to ioremap_wc() in video_init() will always fail, because > > video_init() is called ahead of vm_init_type(), and so the underlying > > __vmap() call will fail to allocate the lin

Re: [PATCH v3] x86/vga: fix mapping of the VGA text buffer

2025-03-20 Thread Jan Beulich
On 20.03.2025 17:15, Roger Pau Monné wrote: > On Thu, Mar 20, 2025 at 04:25:25PM +0100, Jan Beulich wrote: >> On 20.03.2025 16:11, Roger Pau Monne wrote: >>> --- a/xen/drivers/video/vga.c >>> +++ b/xen/drivers/video/vga.c >>> @@ -71,7 +71,7 @@ void __init video_init(void) >>> { >>> case X

Re: [PATCH v2 4/5] xen/arm: ffa: Add indirect message between VM

2025-03-20 Thread Bertrand Marquis
Hi Jens, > On 20 Mar 2025, at 16:53, Jens Wiklander wrote: > > Hi Bertrand, > > On Mon, Mar 10, 2025 at 3:51 PM Bertrand Marquis > wrote: >> >> Add support for indirect messages between VMs. >> This is only enabled if CONFIG_FFA_VM_TO_VM is selected. >> >> Signed-off-by: Bertrand Marquis >>

Re: [PATCH v3 0/3] xen: Fix usage of devices behind a VMD bridge

2025-03-20 Thread Roger Pau Monné
Ping x2? Thanks, Roger. On Thu, Mar 06, 2025 at 09:48:07AM +0100, Roger Pau Monné wrote: > Hello, > > I've attempted to ping Nirmal directly on the VMD patch, but got no > reply so far. > > First version of this series was posted on 10/01, yet there hasn't > been any feedback from Nirmal. Woul

Re: [PATCH] xen: add kconfig for event_fifo

2025-03-20 Thread Jan Beulich
On 19.03.2025 00:40, Stefano Stabellini wrote: > Evtchn fifos are not needed on smaller systems; the older interface is > lightweight and sufficient. Make it possible to disable evtchn fifo. > > Signed-off-by: Stefano Stabellini Let me ask a more general question, before considering whether to a

Re: [PATCH v2 2/5] xen/arm: ffa: Introduce VM to VM support

2025-03-20 Thread Jens Wiklander
Hi, On Thu, Mar 20, 2025 at 4:47 PM Bertrand Marquis wrote: > > Hi Jens, > > Thanks a lot for the review. > > > On 20 Mar 2025, at 15:20, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Mon, Mar 10, 2025 at 3:51 PM Bertrand Marquis > > wrote: > >> > >> Create a CONFIG_FFA_VM_TO_VM paramet

Re: [PATCH] tools/arm: Fix nr_spis handling v2

2025-03-20 Thread Anthony PERARD
On Tue, Mar 18, 2025 at 10:00:13AM +0100, Michal Orzel wrote: > We are missing a way to detect whether a user provided a value for > nr_spis equal to 0 or did not provide any value (default is also 0) which > can cause issues when calculated nr_spis is > 0 and the value from domain > config is 0. F

Re: [PATCH for-4.20 0/2] docs/process: Update the branching checklist

2025-03-20 Thread Julien Grall
Hi, On 06/12/2024 19:40, Julien Grall wrote: From: Julien Grall Hi all, As we approach Xen 4.20, update the branching checklist to match the current state of affair. Cheers, Julien Grall (2): docs/process: branching-checklist: Update the steps to generate the docs docs/process: b

[PATCH v3] x86/vga: fix mapping of the VGA text buffer

2025-03-20 Thread Roger Pau Monne
The call to ioremap_wc() in video_init() will always fail, because video_init() is called ahead of vm_init_type(), and so the underlying __vmap() call will fail to allocate the linear address space. Fix by reverting to the previous behavior and use __va() for the VGA text buffer, as it's below the

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-20 Thread Jan Beulich
On 20.03.2025 15:36, Anthony PERARD wrote: > On Thu, Mar 20, 2025 at 02:59:04PM +0100, Marek Marczykowski-Górecki wrote: >> On Thu, Mar 20, 2025 at 02:49:27PM +0100, Jan Beulich wrote: >>> On 20.03.2025 13:51, Marek Marczykowski-Górecki wrote: On Thu, Mar 20, 2025 at 10:18:28AM +, Anthony

Re: Discussion on unexpected behavior of ARINC653 scheduler

2025-03-20 Thread Andrew Cooper
On 13/03/2025 9:27 am, Choi, Anderson wrote: > May I know when you think it would be mainlined? And will it be applied to > all branches, like 4.19 and 4.20? FYI, backports of this and the xfree() bug have just happened, back to 4.18. ~Andrew

Re: [PATCH v2 3/5] xen/arm: ffa: Add buffer full notification support

2025-03-20 Thread Bertrand Marquis
Hi Jens, > On 20 Mar 2025, at 15:51, Jens Wiklander wrote: > > Hi Bertrand, > > On Mon, Mar 10, 2025 at 3:51 PM Bertrand Marquis > wrote: >> >> Add support to raise a Rx buffer full notification to a VM. >> This function will be used for indirect message support between VM and >> is only acti

Re: [PATCH v2 4/5] xen/arm: ffa: Add indirect message between VM

2025-03-20 Thread Jens Wiklander
Hi Bertrand, On Mon, Mar 10, 2025 at 3:51 PM Bertrand Marquis wrote: > > Add support for indirect messages between VMs. > This is only enabled if CONFIG_FFA_VM_TO_VM is selected. > > Signed-off-by: Bertrand Marquis > --- > Changes in v2: > - Switch ifdef to IS_ENABLED > --- > xen/arch/arm/tee/f

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-20 Thread Marek Marczykowski-Górecki
On Thu, Mar 20, 2025 at 04:48:02PM +0100, Jan Beulich wrote: > On 20.03.2025 16:32, Marek Marczykowski-Górecki wrote: > > On Thu, Mar 20, 2025 at 04:21:18PM +0100, Jan Beulich wrote: > >> On 20.03.2025 16:17, Marek Marczykowski-Górecki wrote: > >>> On Thu, Mar 20, 2025 at 02:35:59PM +, Anthony

Re: [PATCH v1 1/4] xen/riscv: introduce preinit_xen_time()

2025-03-20 Thread Jan Beulich
On 19.03.2025 18:29, Oleksii Kurochko wrote: > > On 3/17/25 4:24 PM, Jan Beulich wrote: >> On 11.03.2025 17:19, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/time.c >>> @@ -0,0 +1,38 @@ >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +unsigned long __ro_a

[PATCH 2/3] Xen: Update compiler checks

2025-03-20 Thread Andrew Cooper
We didn't really have a Clang check before, so add one while adjusting the GCC check. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monné CC: Stefano Stabellini CC: Oleksii Kurochko --- xen/include/xen/compiler.h | 16 +

[PATCH 3/3] CHANGELOG: Minimum toolchain requirements

2025-03-20 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monné CC: Stefano Stabellini CC: Oleksii Kurochko --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9a5919585d43..4e33

[PATCH RESEND 0/3] Xen: CI changes for new toolchain baseline

2025-03-20 Thread Andrew Cooper
Prep work to allow us to start making changes based on the toolchain requirements. https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1726628670 https://cirrus-ci.com/build/5232741505040384 Andrew Cooper (3): CI: Update build tests based on new minimum toolchain requirements Xen: U

Re: [PATCH v3 1/3] drivers: Change amd_iommu struct to contain pci_sbdf_t, simplify code

2025-03-20 Thread Jan Beulich
On 18.03.2025 16:30, Andrii Sultanov wrote: > Following on from 250d87dc3ff9 ("x86/msi: Change __msi_set_enable() to > take pci_sbdf_t"), struct amd_iommu has its seg and bdf fields > backwards with relation to pci_sbdf_t. This being backwards isn't relevant anymore, is it? > Instead of regenerat

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-20 Thread Jan Beulich
On 20.03.2025 16:32, Marek Marczykowski-Górecki wrote: > On Thu, Mar 20, 2025 at 04:21:18PM +0100, Jan Beulich wrote: >> On 20.03.2025 16:17, Marek Marczykowski-Górecki wrote: >>> On Thu, Mar 20, 2025 at 02:35:59PM +, Anthony PERARD wrote: On Thu, Mar 20, 2025 at 02:59:04PM +0100, Marek Ma

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-20 Thread Anthony PERARD
On Thu, Mar 20, 2025 at 02:59:04PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Mar 20, 2025 at 02:49:27PM +0100, Jan Beulich wrote: > > On 20.03.2025 13:51, Marek Marczykowski-Górecki wrote: > > > On Thu, Mar 20, 2025 at 10:18:28AM +, Anthony PERARD wrote: > > >> On Wed, Mar 19, 2025 at