On 20.03.2025 17:15, Roger Pau Monné wrote:
> On Thu, Mar 20, 2025 at 04:25:25PM +0100, Jan Beulich wrote:
>> On 20.03.2025 16:11, Roger Pau Monne wrote:
>>> --- a/xen/drivers/video/vga.c
>>> +++ b/xen/drivers/video/vga.c
>>> @@ -71,7 +71,7 @@ void __init video_init(void)
>>> {
>>> case XEN_VGATYPE_TEXT_MODE_3:
>>> if ( page_is_ram_type(paddr_to_pfn(0xB8000),
>>> RAM_TYPE_CONVENTIONAL) ||
>>> - ((video = ioremap_wc(0xB8000, 0x8000)) == NULL) )
>>> + ((video = __va(0xB8000)) == NULL) )
>>
>> Without having a good suggestion, find such dependencies upon the low
>> 1Mb always being mapped (in case we wanted to revisit this, for example)
>> is going to be moderately hard. It might be good to somehow mark them.
>
> Hm, if we where to change this, we should likely go over all the
> usages of ioremap() and __va() to find them?
Going over the ioremap()s ought to be fine. There may be many __va() though,
plus that one has further aliases iirc (e.g. maddr_to_virt()).
> I assume you are fine with this going in as-is.
Yes, as said - short of having any good suggestion.
Jan
