Re: lib32 followup (visibility issue and/or toolchain bug?)

2024-10-17 Thread Frediano Ziglio
On Wed, Oct 16, 2024 at 3:53 PM Frediano Ziglio wrote: > > On Wed, Oct 16, 2024 at 2:30 PM Andrew Cooper > wrote: > > > > Hello, > > > > Preempting some future work I'm expecting to arrive, I had a go at using > > __builtin_*() in obj32. > > > > This is formed of 2 patches on top of this series:

Re: [PATCH 09/13] ata: Use always-managed version of pci_intx()

2024-10-17 Thread Niklas Cassel
On Tue, Oct 15, 2024 at 08:51:19PM +0200, Philipp Stanner wrote: > pci_intx() is a hybrid function which can sometimes be managed through > devres. To remove this hybrid nature from pci_intx(), it is necessary to > port users to either an always-managed or a never-managed version. > > All users in

[ovmf test] 188152: all pass - PUSHED

2024-10-17 Thread osstest service owner
flight 188152 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/188152/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e19cc32bce466fb1c175f7d44708c2ebb45802a7 baseline version: ovmf b7342074a649599078553

[xen-unstable test] 188128: tolerable FAIL - PUSHED

2024-10-17 Thread osstest service owner
flight 188128 xen-unstable real [real] flight 188151 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188128/ http://logs.test-lab.xenproject.org/osstest/logs/188151/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh

[linux-linus test] 188132: regressions - FAIL

2024-10-17 Thread osstest service owner
flight 188132 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/188132/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 6 kernel-build fail REGR. vs. 188098 Tests which did not

Re: [PATCH v4 2/6] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-17 Thread Andrew Cooper
On 17/10/2024 11:58 am, Frediano Ziglio wrote: > On Wed, Oct 16, 2024 at 4:05 PM Frediano Ziglio > wrote: >> On Wed, Oct 16, 2024 at 12:25 PM Anthony PERARD >> wrote: >>> On Wed, Oct 16, 2024 at 09:33:32AM +0100, Frediano Ziglio wrote: On Tue, Oct 15, 2024 at 2:51 PM Anthony PERARD wr

[ovmf test] 188156: regressions - FAIL

2024-10-17 Thread osstest service owner
flight 188156 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/188156/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 188152 build-i386-pvops

Re: [PATCH v4 2/6] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-17 Thread Anthony PERARD
On Wed, Oct 16, 2024 at 04:05:00PM +0100, Frediano Ziglio wrote: > On Wed, Oct 16, 2024 at 12:25 PM Anthony PERARD > > wrote: > > On Wed, Oct 16, 2024 at 09:33:32AM +0100, Frediano Ziglio wrote: > > > On Tue, Oct 15, 2024 at 2:51 PM Anthony PERARD > > > wrote: > > > > I can think of one example

Re: lib32 followup (visibility issue and/or toolchain bug?)

2024-10-17 Thread Jan Beulich
On 16.10.2024 16:53, Frediano Ziglio wrote: > On Wed, Oct 16, 2024 at 2:30 PM Andrew Cooper > wrote: >> >> Hello, >> >> Preempting some future work I'm expecting to arrive, I had a go at using >> __builtin_*() in obj32. >> >> This is formed of 2 patches on top of this series: >> https://xenbits.x

[PATCH v6 2/5] x86/boot: Reuse code to relocate trampoline

2024-10-17 Thread Frediano Ziglio
Move code from efi-boot.h to a separate, new, reloc-trampoline.c file. Reuse this new code, compiling it for 32bit as well, to replace assembly code in head.S doing the same thing. Signed-off-by: Frediano Ziglio Reviewed-by: Andrew Cooper --- Changes since v3: - fixed a typo in comment; - added

[PATCH v6 4/5] x86/boot: Use trampoline_phys variable directly from C code

2024-10-17 Thread Frediano Ziglio
No more need to pass from assembly code. Signed-off-by: Frediano Ziglio Reviewed-by: Andrew Cooper --- Changes since v1: - split the 2 variable changes into 2 commits. Changes since v2: - revert commit order; - avoid useless casts. --- xen/arch/x86/boot/head.S | 6 +- xen/arch/x86/boot/re

[PATCH v6 5/5] x86/boot: Clarify comment

2024-10-17 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/reloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c index e50e161b27..e725cfb6eb 100644 --- a/xen/arch/x86/boot/reloc.c +++ b/xen/arch/x86/boot/reloc.c @@ -65,7 +65,7

[PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-17 Thread Frediano Ziglio
The current method to include 32 bit C boot code is: - compile each function we want to use into a separate object file; - each function is compiled with -fpic option; - convert these object files to binary files. This operation removes GOP which we don't want in the executable; - a small assembl

[PATCH v6 0/5] Reuse 32 bit C code more safely

2024-10-17 Thread Frediano Ziglio
This series attempt to: - use more C code, that is replace some assembly code with C; - avoid some code duplication between C and assembly; - prevent some issues having relocations in C code. The idea is extending the current C to binary code conversion done for 32 bit C code called from head.S ma

[PATCH v6 3/5] x86/boot: Use boot_vid_info variable directly from C code

2024-10-17 Thread Frediano Ziglio
No more need to pass from assembly code. Signed-off-by: Frediano Ziglio Reviewed-by: Andrew Cooper --- Changes since v1: - split the 2 variable changes into 2 commits. Changes since v2: - revert commit order. --- xen/arch/x86/boot/build32.lds.S | 1 + xen/arch/x86/boot/head.S| 10 +---

Re: [PATCH v4 2/6] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-17 Thread Frediano Ziglio
On Wed, Oct 16, 2024 at 4:05 PM Frediano Ziglio wrote: > > On Wed, Oct 16, 2024 at 12:25 PM Anthony PERARD > wrote: > > > > On Wed, Oct 16, 2024 at 09:33:32AM +0100, Frediano Ziglio wrote: > > > On Tue, Oct 15, 2024 at 2:51 PM Anthony PERARD > > > wrote: > > > > On Mon, Oct 14, 2024 at 05:32:26

Re: [PATCH v5 2/3] xen/pci: introduce PF<->VF links

2024-10-17 Thread Jan Beulich
On 16.10.2024 18:50, Stewart Hildebrand wrote: > On 10/16/24 05:52, Jan Beulich wrote: >> On 11.10.2024 17:27, Stewart Hildebrand wrote: >>> Add links between a VF's struct pci_dev and its associated PF struct >>> pci_dev. Move the calls to pci_get_pdev()/pci_add_device() down to avoid >>> dropping

[libvirt test] 188148: regressions - FAIL

2024-10-17 Thread osstest service owner
flight 188148 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/188148/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 188108 test-amd64-amd64-libvir

Re: [XEN PATCH v1 0/3] automation: add x86_64 test (linux argo)

2024-10-17 Thread Andrew Cooper
On 17/10/2024 6:18 pm, victorm.l...@amd.com wrote: > From: Victor Lira > > Add x86_64 hardware test that creates a Xen Argo communication > connection between two PVH domains. > > To accomplish this, add new build artifacts for Linux and Argo, and > update the xilinx x86_64 test script. > > Victor

[ovmf test] 188188: regressions - FAIL

2024-10-17 Thread osstest service owner
flight 188188 ovmf real [real] flight 188194 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188188/ http://logs.test-lab.xenproject.org/osstest/logs/188194/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

Re: [PATCH v6 07/44] x86/boot: move headroom to boot modules

2024-10-17 Thread Jason Andryuk
On 2024-10-17 13:02, Daniel P. Smith wrote: The purpose of struct boot_module is to encapsulate the state of boot module as it is processed by Xen. Locating boot module state struct boot_module reduces the number of global variables as well as the number of state variables that must be passed aro

[linux-linus test] 188158: regressions - FAIL

2024-10-17 Thread osstest service owner
flight 188158 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/188158/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 6 kernel-build fail in 188132 REGR. vs. 188098 Tests which are fai

Re: [PATCH v6 07/44] x86/boot: move headroom to boot modules

2024-10-17 Thread Andrew Cooper
On 17/10/2024 6:02 pm, Daniel P. Smith wrote: > diff --git a/xen/arch/x86/include/asm/bootinfo.h > b/xen/arch/x86/include/asm/bootinfo.h > index d19473d8941e..5fe4f1387d03 100644 > --- a/xen/arch/x86/include/asm/bootinfo.h > +++ b/xen/arch/x86/include/asm/bootinfo.h > @@ -17,6 +17,19 @@ > struct

Re: [PATCH v6 10/44] x86/boot: introduce boot module flags

2024-10-17 Thread Andrew Cooper
On 17/10/2024 6:02 pm, Daniel P. Smith wrote: > diff --git a/xen/arch/x86/include/asm/bootinfo.h > b/xen/arch/x86/include/asm/bootinfo.h > index 18281d80fa97..e8ba9390a51f 100644 > --- a/xen/arch/x86/include/asm/bootinfo.h > +++ b/xen/arch/x86/include/asm/bootinfo.h > @@ -39,6 +39,9 @@ struct boot

Re: [PATCH v6 05/44] x86/boot: introduce struct boot_module

2024-10-17 Thread Daniel P. Smith
On 10/17/24 17:02, Andrew Cooper wrote: On 17/10/2024 6:02 pm, Daniel P. Smith wrote: diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f7ea482920ef..d8ee5741740a 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -284,6 +284,8 @@ static struct boot_info *__init multib

Re: [PATCH v6 07/44] x86/boot: move headroom to boot modules

2024-10-17 Thread Daniel P. Smith
On 10/17/24 17:39, Andrew Cooper wrote: On 17/10/2024 6:02 pm, Daniel P. Smith wrote: diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index d19473d8941e..5fe4f1387d03 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.

Re: [PATCH v6 03/44] x86/boot: move cmdline to boot info

2024-10-17 Thread Andrew Cooper
On 17/10/2024 6:02 pm, Daniel P. Smith wrote: > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index eac0954f42b8..037cdd17386c 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -1035,11 +1043,7 @@ void asmlinkage __init noreturn __start_xen(unsigned > long mbi_p) >

Re: [PATCH v6 09/44] x86/boot: introduce boot module types

2024-10-17 Thread Jason Andryuk
On 2024-10-17 13:02, Daniel P. Smith wrote: This commit introduces module types of xen, kernel, and ramdisk to allow boot module detect code to tag the purpose of a boot module. This reduces the need for hard coded order assumptions and global variables to be used by consumers of boot modules, su

[xen-unstable-smoke test] 188192: tolerable all pass - PUSHED

2024-10-17 Thread osstest service owner
flight 188192 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/188192/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v6 11/44] x86/boot: add start and size fields to struct boot_module

2024-10-17 Thread Jason Andryuk
On 2024-10-17 13:02, Daniel P. Smith wrote: This commit introduces the start and size fields to struct boot_module and assigns their value during boot_info construction. The EFI entry point special cased itself, and pre-converted mod_start and mod_end to mfn and size respectively. This required

Re: [PATCH v6 12/44] x86/boot: update struct boot_module on module relocation

2024-10-17 Thread Jason Andryuk
On 2024-10-17 13:02, Daniel P. Smith wrote: When a boot module is relocated, ensure struct boot_module start and size fields are updated along with early_mod. Signed-off-by: Daniel P. Smith --- Changes since v5: - corrected conversion function for a missed switch from mfn to maddr/paddr --- x

Re: [PATCH v6 02/44] x86/boot: move boot loader name to boot info

2024-10-17 Thread Jason Andryuk
On 2024-10-17 13:02, Daniel P. Smith wrote: Transition the incoming boot loader name to be held in struct boot_info. No functional change intended. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk

Re: [PATCH v6 03/44] x86/boot: move cmdline to boot info

2024-10-17 Thread Daniel P. Smith
On 10/17/24 16:35, Andrew Cooper wrote: On 17/10/2024 6:02 pm, Daniel P. Smith wrote: diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index eac0954f42b8..037cdd17386c 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1035,11 +1043,7 @@ void asmlinkage __init noreturn __st

Re: [PATCH v6 01/44] x86/boot: move x86 boot module counting into a new boot_info struct

2024-10-17 Thread Daniel P. Smith
On 10/17/24 15:50, Andrew Cooper wrote: On 17/10/2024 6:02 pm, Daniel P. Smith wrote: diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index a6e77c9ed9fc..6201ca0fad19 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -274,16 +275,28 @@ static int __init cf_check parse_acpi

Re: [PATCH v6 00/44] Boot modules for Hyperlaunch

2024-10-17 Thread Andrew Cooper
On 17/10/2024 6:02 pm, Daniel P. Smith wrote: > Christopher Clark (1): > x86/boot: move x86 boot module counting into a new boot_info struct > > Daniel P. Smith (42): > x86/boot: move boot loader name to boot info > x86/boot: move cmdline to boot info > x86/boot: move mmap info to boot info

Re: [PATCH v6 08/44] x86/boot: convert mod refs to boot_module mod

2024-10-17 Thread Jason Andryuk
On 2024-10-17 13:02, Daniel P. Smith wrote: To allow a slow conversion of x86 over to struct boot_module, start with replacing all references to module_t mod, only in setup.c, to the mod element of struct boot_module. These serves twofold, first to allow the incremental transition from module_t f

Re: [XEN PATCH v1 3/3] CI: Refresh and upgrade the Fedora container

2024-10-17 Thread Stefano Stabellini
On Thu, 17 Oct 2024, Anthony PERARD wrote: > On Thu, Oct 17, 2024 at 05:20:21PM +0100, Javi Merino wrote: > > From: Andrew Cooper > > > > Fedora 29 is long out of date. Move forward 5 years to Fedora 40. > > > > Include all the usual improvements. Rework the container to be non-root, > > use

Re: [XEN PATCH v1 1/3] automation: Fix URL to the gitlab container registry documentation

2024-10-17 Thread Stefano Stabellini
On Thu, 17 Oct 2024, Anthony PERARD wrote: > On Thu, Oct 17, 2024 at 05:20:19PM +0100, Javi Merino wrote: > > The gitlab documentation is now at > > https://docs.gitlab.com/ee/administration/packages/container_registry.html > > This link seems to be for self-managed instance of gitlab, but the lin

Re: [PATCH v6 05/44] x86/boot: introduce struct boot_module

2024-10-17 Thread Andrew Cooper
On 17/10/2024 6:02 pm, Daniel P. Smith wrote: > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index f7ea482920ef..d8ee5741740a 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -284,6 +284,8 @@ static struct boot_info *__init > multiboot_fill_boot_info(unsigned lon

Re: [PATCH v6 17/44] x86/boot: convert microcode loading to consume struct boot_info

2024-10-17 Thread Andrew Cooper
On 17/10/2024 6:02 pm, Daniel P. Smith wrote: > diff --git a/xen/arch/x86/cpu/microcode/core.c > b/xen/arch/x86/cpu/microcode/core.c > index 8564e4d2c94c..22fea80bc97e 100644 > --- a/xen/arch/x86/cpu/microcode/core.c > +++ b/xen/arch/x86/cpu/microcode/core.c > @@ -178,16 +177,16 @@ static void __i

Re: [PATCH v6 01/44] x86/boot: move x86 boot module counting into a new boot_info struct

2024-10-17 Thread Andrew Cooper
On 17/10/2024 6:02 pm, Daniel P. Smith wrote: > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index a6e77c9ed9fc..6201ca0fad19 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -274,16 +275,28 @@ static int __init cf_check parse_acpi_param(const char > *s) > custo

Re: [PATCH v6 11/44] x86/boot: add start and size fields to struct boot_module

2024-10-17 Thread Andrew Cooper
On 17/10/2024 6:02 pm, Daniel P. Smith wrote: > This commit introduces the start and size fields to struct boot_module and > assigns their value during boot_info construction. > > The EFI entry point special cased itself, and pre-converted mod_start and > mod_end to mfn and size respectively. This

Re: [PATCH v6 08/44] x86/boot: convert mod refs to boot_module mod

2024-10-17 Thread Daniel P. Smith
On 10/17/24 19:02, Jason Andryuk wrote: On 2024-10-17 13:02, Daniel P. Smith wrote: To allow a slow conversion of x86 over to struct boot_module, start with replacing all references to module_t mod, only in setup.c, to the mod element of struct boot_module. These serves twofold, first to allow

Re: [PATCH v6 13/44] x86/boot: transition relocation calculations to struct boot_module

2024-10-17 Thread Jason Andryuk
On 2024-10-17 13:02, Daniel P. Smith wrote: Use struct boot_module fields, start and size, when calculating the relocation address and size. It also ensures that early_mod references are kept in sync. Signed-off-by: Daniel P. Smith --- Changes since v5: - removed unnecessary paddr_to_pfn, allow

Re: [PATCH v6 10/44] x86/boot: introduce boot module flags

2024-10-17 Thread Daniel P. Smith
On 10/17/24 19:58, Andrew Cooper wrote: On 17/10/2024 6:02 pm, Daniel P. Smith wrote: diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index 18281d80fa97..e8ba9390a51f 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.

[linux-6.1 test] 188169: tolerable FAIL - PUSHED

2024-10-17 Thread osstest service owner
flight 188169 linux-6.1 real [real] flight 188214 linux-6.1 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188169/ http://logs.test-lab.xenproject.org/osstest/logs/188214/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd6

[ovmf test] 188197: regressions - FAIL

2024-10-17 Thread osstest service owner
flight 188197 ovmf real [real] flight 188213 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188197/ http://logs.test-lab.xenproject.org/osstest/logs/188213/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

Re: [XEN PATCH v1 0/3] automation: add x86_64 test (linux argo)

2024-10-17 Thread Stefano Stabellini
On Thu, 17 Oct 2024, Andrew Cooper wrote: > On 17/10/2024 6:18 pm, victorm.l...@amd.com wrote: > > From: Victor Lira > > > > Add x86_64 hardware test that creates a Xen Argo communication > > connection between two PVH domains. > > > > To accomplish this, add new build artifacts for Linux and Argo

Re: [PATCH v2] MAINTAINERS: minor file line update

2024-10-17 Thread Bertrand Marquis
Hi, > On 17 Oct 2024, at 18:53, Volodymyr Babchuk > wrote: > > Jan Beulich writes: > > Hi > >> On 04.10.2024 13:11, Frediano Ziglio wrote: >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -517,7 +517,7 @@ F: stubdom/ >>> TEE MEDIATORS >>> M: Volodymyr Babchuk >>> S: Supported >>> -F: xen/

Re: [PATCH v6 13/44] x86/boot: transition relocation calculations to struct boot_module

2024-10-17 Thread Jan Beulich
On 18.10.2024 02:42, Jason Andryuk wrote: > On 2024-10-17 13:02, Daniel P. Smith wrote: >> @@ -1686,12 +1682,12 @@ void asmlinkage __init noreturn __start_xen(unsigned >> long mbi_p) >> >> for ( i = 0; i < bi->nr_modules; ++i ) >> { >> -set_pdx_range(bi->mods[i].mod->mod_sta

[xen-unstable-smoke test] 188209: tolerable all pass - PUSHED

2024-10-17 Thread osstest service owner
flight 188209 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/188209/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v5 1/3] x86/msi: harden stale pdev handling

2024-10-17 Thread Stewart Hildebrand
On 10/15/24 02:58, Jan Beulich wrote: > On 11.10.2024 17:27, Stewart Hildebrand wrote: >> --- a/xen/arch/x86/msi.c >> +++ b/xen/arch/x86/msi.c >> @@ -1243,7 +1243,12 @@ int pci_reset_msix_state(struct pci_dev *pdev) >> { >> unsigned int pos = pci_find_cap_offset(pdev->sbdf, PCI_CAP_ID_MSIX);

Re: [PATCH] xen/arm: dom0less: cope with missing /gic phandle

2024-10-17 Thread Julien Grall
Hi, On 11/10/2024 22:28, Stefano Stabellini wrote: On Fri, 11 Oct 2024, Stewart Hildebrand wrote: If a partial DT has a /gic node, but no references to it, dtc may omit the phandle property. With the phandle property missing, fdt_get_phandle() returns 0, leading Xen to generate a malformed domU

[XEN PATCH v1 2/3] ocaml/libs: Fill build failure due to unused variable in ocaml macro

2024-10-17 Thread Javi Merino
On Fedora 40, the build fails with: gcc -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-but-set-variable -Wno-unused-local-typedefs -Werror -O2 -fomit-frame-pointer -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MP -MF .domain_get

[XEN PATCH v1 1/3] automation: Fix URL to the gitlab container registry documentation

2024-10-17 Thread Javi Merino
The gitlab documentation is now at https://docs.gitlab.com/ee/administration/packages/container_registry.html Signed-off-by: Javi Merino --- automation/build/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/build/README.md b/automation/build/README.md inde

[XEN PATCH v1 3/3] CI: Refresh and upgrade the Fedora container

2024-10-17 Thread Javi Merino
From: Andrew Cooper Fedora 29 is long out of date. Move forward 5 years to Fedora 40. Include all the usual improvements. Rework the container to be non-root, use heredocs for legibility, and switch to the new naming scheme. Signed-off-by: Andrew Cooper Signed-off-by: Javi Merino --- autom

[XEN PATCH v1 0/3] CI: Upgrade the Fedora container and fix build failure

2024-10-17 Thread Javi Merino
Hi, Continuing Andrew's work on refreshing containers in GitLab CI. With Fedora 40, there was a build failure in the ocaml builds. It is due to an unused variable in an ocaml macro when building with "-Werror" . Patch 2 solves the build failure, but I'm unsure if it is the best approach. Ideas

Re: [PATCH v2] MAINTAINERS: minor file line update

2024-10-17 Thread Julien Grall
Hi Jan, On 08/10/2024 12:48, Jan Beulich wrote: On 04.10.2024 13:11, Frediano Ziglio wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -517,7 +517,7 @@ F: stubdom/ TEE MEDIATORS M:Volodymyr Babchuk S:Supported -F: xen/arch/arm/include/asm/tee +F: xen/arch/arm/include/asm/tee

Re: [PATCH v2] MAINTAINERS: minor file line update

2024-10-17 Thread Volodymyr Babchuk
Jan Beulich writes: Hi > On 04.10.2024 13:11, Frediano Ziglio wrote: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -517,7 +517,7 @@ F: stubdom/ >> TEE MEDIATORS >> M: Volodymyr Babchuk >> S: Supported >> -F: xen/arch/arm/include/asm/tee >> +F: xen/arch/arm/include/asm/tee/ >> F:

[ovmf test] 188161: regressions - FAIL

2024-10-17 Thread osstest service owner
flight 188161 ovmf real [real] flight 188178 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188161/ http://logs.test-lab.xenproject.org/osstest/logs/188178/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

Re: [XEN PATCH v1 1/3] automation: Fix URL to the gitlab container registry documentation

2024-10-17 Thread Anthony PERARD
On Thu, Oct 17, 2024 at 05:20:19PM +0100, Javi Merino wrote: > The gitlab documentation is now at > https://docs.gitlab.com/ee/administration/packages/container_registry.html This link seems to be for self-managed instance of gitlab, but the link in the patch looks fine. > Signed-off-by: Javi Mer

[PATCH v6 00/44] Boot modules for Hyperlaunch

2024-10-17 Thread Daniel P. Smith
The Boot Modules for Hyperlaunch series is an effort to split out preliminary changes necessary for the introduction of the Hyperlaunch domain builder logic. These preliminary changes revolve around introducing the struct boot_module and struct boot_domain structures. This includes converting the d

[PATCH v6 01/44] x86/boot: move x86 boot module counting into a new boot_info struct

2024-10-17 Thread Daniel P. Smith
From: Christopher Clark An initial step towards a non-multiboot internal representation of boot modules for common code, starting with x86 setup and converting the fields that are accessed for the startup calculations. Introduce a new header, , and populate it with a new boot_info structure init

Re: [XEN PATCH v1 3/3] CI: Refresh and upgrade the Fedora container

2024-10-17 Thread Anthony PERARD
On Thu, Oct 17, 2024 at 05:20:21PM +0100, Javi Merino wrote: > From: Andrew Cooper > > Fedora 29 is long out of date. Move forward 5 years to Fedora 40. > > Include all the usual improvements. Rework the container to be non-root, use > heredocs for legibility, and switch to the new naming sche

[PATCH v6 02/44] x86/boot: move boot loader name to boot info

2024-10-17 Thread Daniel P. Smith
Transition the incoming boot loader name to be held in struct boot_info. No functional change intended. Signed-off-by: Daniel P. Smith --- Changes since v5: - reorder struct boot_module fields - code style changes --- xen/arch/x86/include/asm/bootinfo.h | 2 ++ xen/arch/x86/setup.c

[xen-unstable test] 188153: regressions - FAIL

2024-10-17 Thread osstest service owner
flight 188153 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/188153/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 188128 build-arm64

Re: [PATCH v1 2/5] xen/riscv: implement maddr_to_virt()

2024-10-17 Thread Jan Beulich
On 16.10.2024 11:15, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/mm.h > +++ b/xen/arch/riscv/include/asm/mm.h > @@ -25,8 +25,12 @@ > > static inline void *maddr_to_virt(paddr_t ma) > { > -BUG_ON("unimplemented"); > -return NULL; > +/* Offset in the direct map, account

Re: [PATCH v6 2/5] x86/boot: Reuse code to relocate trampoline

2024-10-17 Thread Marek Marczykowski-Górecki
On Thu, Oct 17, 2024 at 02:31:20PM +0100, Frediano Ziglio wrote: > Move code from efi-boot.h to a separate, new, reloc-trampoline.c file. > Reuse this new code, compiling it for 32bit as well, to replace assembly > code in head.S doing the same thing. > > Signed-off-by: Frediano Ziglio > Reviewed

Re: [PATCH] device-tree: Move dt-overlay.c to common/device-tree/

2024-10-17 Thread Julien Grall
Hi, On 10/10/2024 20:48, Stefano Stabellini wrote: On Thu, 10 Oct 2024, Michal Orzel wrote: The code is DT specific and as such should be placed under common directory for DT related files. Update MAINTAINERS file accordingly and drop the line with a path from a top-level comment in dt-overlay.

Re: [PATCH v1 1/5] xen/riscv: add stub for share_xen_page_with_guest()

2024-10-17 Thread Jan Beulich
On 16.10.2024 11:15, Oleksii Kurochko wrote: > To avoid the following linkage fail the stub for share_xen_page_with_guest() > is introduced: What do you intend to express with "is introduced"? Is there a problem now? Would there be a problem with subsequent changes? I'm entirely fine with adding t

Re: [PATCH v1 4/5] xen/riscv: initialize the VMAP_DEFAULT virtual range

2024-10-17 Thread Jan Beulich
On 16.10.2024 11:15, Oleksii Kurochko wrote: > Call vm_init() to initialize the VMAP_DEFAULT virtual range. > > To support this, introduce the populate_pt_range() and > arch_vmap_virt_end() functions, which are used by > vm_init()->vm_init_type(). > > Signed-off-by: Oleksii Kurochko Acked-by: J

Re: [PATCH v1 3/5] xen/riscv: introduce setup_mm()

2024-10-17 Thread Jan Beulich
On 16.10.2024 11:15, Oleksii Kurochko wrote: > @@ -423,3 +424,95 @@ void * __init early_fdt_map(paddr_t fdt_paddr) > > return fdt_virt; > } > + > +#ifndef CONFIG_RISCV_32 > +/* Map the region in the directmap area. */ > +static void __init setup_directmap_mappings(unsigned long nr_mfns) > +

Re: [PATCH v1 5/5] xen/riscv: finalize boot allocator and transition to boot state

2024-10-17 Thread Jan Beulich
On 16.10.2024 11:15, Oleksii Kurochko wrote: > Add a call to end_boot_allocator() in start_xen() to finalize the > boot memory allocator, moving free pages to the domain sub-allocator. > > After initializing the memory subsystem, update `system_state` from > `SYS_STATE_early_boot` to `SYS_STATE_bo

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-17 Thread Anthony PERARD
On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote: > +$(obj)/build32.base.lds: AFLAGS-y += -DGAP=$(text_gap) > -DTEXT_DIFF=$(text_diff) > +$(obj)/build32.offset.lds: AFLAGS-y += -DGAP=$(text_gap) > -DTEXT_DIFF=$(text_diff) -DFINAL I was somehow expecting "base" and "offset" to be t

[PATCH v6 17/44] x86/boot: convert microcode loading to consume struct boot_info

2024-10-17 Thread Daniel P. Smith
Convert the microcode loading functions to take struct boot_info, and then using struct boot_module to map and check for microcode. To keep the changes focused, continue using the struct mod to hold the reference to the microcode that is used by the late microcode logic. To support loading the mic

[PATCH v6 14/44] x86/boot: introduce boot module interator

2024-10-17 Thread Daniel P. Smith
Provide an iterator to go through boot module array searching based on type. Signed-off-by: Daniel P. Smith --- Changes since v5: - documented help next_boot_module_index - switch to unsigned int for next_boot_module_index - changes identified that BOOTMOD_XEN was not supported, so added support

[PATCH v6 13/44] x86/boot: transition relocation calculations to struct boot_module

2024-10-17 Thread Daniel P. Smith
Use struct boot_module fields, start and size, when calculating the relocation address and size. It also ensures that early_mod references are kept in sync. Signed-off-by: Daniel P. Smith --- Changes since v5: - removed unnecessary paddr_to_pfn, allowing condition to collapse to one line - correc

[PATCH v6 11/44] x86/boot: add start and size fields to struct boot_module

2024-10-17 Thread Daniel P. Smith
This commit introduces the start and size fields to struct boot_module and assigns their value during boot_info construction. The EFI entry point special cased itself, and pre-converted mod_start and mod_end to mfn and size respectively. This required an additional test in the coversion loop to no

[PATCH v6 18/44] x86/boot: convert late microcode loading to struct boot_module

2024-10-17 Thread Daniel P. Smith
Remove the use of struct mod to hold the reference for the microcode, converting the code to work with a struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/x86/cpu/microcode/core.c | 31 +++ 1 file changed, 15 insertions(+), 16

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-17 Thread Andrew Cooper
On 17/10/2024 2:31 pm, Frediano Ziglio wrote: > The current method to include 32 bit C boot code is: > - compile each function we want to use into a separate object file; > - each function is compiled with -fpic option; > - convert these object files to binary files. This operation removes GOP >

[PATCH v6 35/44] x86/boot: remove usage of mod_end by discard_initial_images

2024-10-17 Thread Daniel P. Smith
This eliminates usage of early_mod by discard_initial_images Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/x86/setup.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f8b9c164c1cb..4d53292aa444 1

[PATCH v6 30/44] x86/boot: convert dom0_construct_pv initrd param to struct boot_module

2024-10-17 Thread Daniel P. Smith
This changes the type for the initrd parameter of dom0_construct_pv to be struct boot_module. This conversion requires several adjustments throughout dom0_construct_pv to account for the type change. Removes the usage of early_mod field for ramdisk module. Signed-off-by: Daniel P. Smith Reviewe

[PATCH v6 26/44] x86/boot: convert construct_dom0 to use struct boot_module

2024-10-17 Thread Daniel P. Smith
The construct_dom0 function is converted to consume struct boot_module instances for the kernel and ramdisk. With this change, it is no longer necessary for the internal use of struct mod by create_dom0, so they are changed to struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason

[PATCH v6 25/44] x86/boot: convert create_dom0 to use boot info

2024-10-17 Thread Daniel P. Smith
This commit changes create_dom0 to no longer take the individual components and take struct boot_info instead. Internally, it is changed to locate the kernel and ramdisk details from struct boot_info. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - change headro

[PATCH v6 44/44] x86/boot: convert dom0_construct_pvh to struct boot_domain

2024-10-17 Thread Daniel P. Smith
With construct_dom0 consuming struct boot_domain, continue passing the structure down to dom0_construct_pvh. Signed-off-by: Daniel P. Smith --- Changes since v5: - revert back to using *d as local reference for struct domain --- xen/arch/x86/dom0_build.c | 2 +- xen/arch/x86/hvm/dom0

[PATCH v6 38/44] x86/boot: introduce boot domain

2024-10-17 Thread Daniel P. Smith
To begin moving toward allowing the hypervisor to construct more than one domain at boot, a container is needed for a domain's build information. Introduce a new header, , that contains the initial struct boot_domain that encapsulate the build information for a domain. No functional change intend

[PATCH v6 21/44] x86/boot: convert ramdisk locating to struct boot_module

2024-10-17 Thread Daniel P. Smith
Locate the first unclaimed struct boot_module and mark it as ramdisk. If there are any remaining unclaimed struct boot_module instances, report to the console. In the change, the new boot module iterator is used to find the initrd index, which returns a signed int. Switch initrdidx from unsigned to

[PATCH v6 34/44] x86/boot: drop the use of initial_images unit global

2024-10-17 Thread Daniel P. Smith
Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - coding style changes --- xen/arch/x86/setup.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f5cd7eeb157c..f8b9c164c1cb 10064

[PATCH v6 36/44] x86/boot: remove remaining module_t references

2024-10-17 Thread Daniel P. Smith
Any direct usages of module_t have been transitioned, remove the remaining references to the mod field. This also removes any external use of bootstrap_map(), dropping from setup.h and making it static. Signed-off-by: Daniel P. Smith --- Changes since v5: - commit message rewrite - coding style c

[PATCH v6 37/44] x86/boot: remove mod from struct boot_module

2024-10-17 Thread Daniel P. Smith
With all references to mod field removed, remove the mod field from struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/x86/include/asm/bootinfo.h | 3 --- xen/arch/x86/setup.c| 2 -- 2 files changed, 5 deletions(-) diff --git a/xen/arch/x

[PATCH v6 23/44] x86/boot: remove module_map usage from xsm policy loading

2024-10-17 Thread Daniel P. Smith
Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - adjust comment to coding style --- xen/arch/x86/setup.c | 2 +- xen/include/xsm/xsm.h | 9 +++-- xen/xsm/xsm_core.c| 6 ++ xen/xsm/xsm_policy.c | 9 ++--- 4 files changed, 8 insertions(+), 18 dele

[PATCH v6 39/44] x86/boot: introduce domid field to struct boot_domain

2024-10-17 Thread Daniel P. Smith
Add a domid field to struct boot_domain to hold the assigned domain id for the domain. During initialization, ensure all instances of struct boot_domain have the invalid domid to ensure that the domid must be set either by convention or configuration. Signed-off-by: Daniel P. Smith Reviewed-by: J

[XEN PATCH v1 1/3] automation: add linux 6.6.56 artifact

2024-10-17 Thread victorm.lira
From: Victor Lira Add dockerfile for building container image that holds linux 6.6.56 bzImage for x86_64, using the same build process as the current 6.1.19 image Signed-off-by: Victor Lira --- Cc: Doug Goldstein Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org --- .../tests-artifac

[XEN PATCH v1 3/3] automation: add x86_64 test (linux argo)

2024-10-17 Thread victorm.lira
From: Victor Lira Add x86_64 hardware test that creates a Xen Argo communication connection between two PVH domains. In the test, dom0 creates a domU and listens for messages sent by the domU through Argo. To accomplish this, add Xen build jobs to export Linux and argo artifacts, and build Xen w

[XEN PATCH v1 2/3] automation: add linux argo test artifacts

2024-10-17 Thread victorm.lira
From: Victor Lira Add dockerfile for building container image that holds test binaries for Xen Argo test on Linux 6.6.56 x86_64 The build produces the following: - xen-argo.ko Linux kernel module - lib/libargo* Linux shared library - argo-exec Linux user test program Signed-o

[PATCH v6 20/44] x86/boot: convert xsm policy loading to struct boot_module

2024-10-17 Thread Daniel P. Smith
Iterate through the unclaimed struct boot_module to see if any are an XSM FLASK policy. If one is located, mark it as an xsm policy. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - replaced bootstrap_map with bootstrap_map_bm - make init function definitions con

[PATCH v6 22/44] x86/boot: remove module_map usage from microcode loading

2024-10-17 Thread Daniel P. Smith
With all consumers of module_map converted, remove usage of it by the microcode loading logic. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - dropped unnecessary parens --- xen/arch/x86/cpu/microcode/core.c| 22 +- xen/arch/x86/include/

[XEN PATCH v1 0/3] automation: add x86_64 test (linux argo)

2024-10-17 Thread victorm.lira
From: Victor Lira Add x86_64 hardware test that creates a Xen Argo communication connection between two PVH domains. To accomplish this, add new build artifacts for Linux and Argo, and update the xilinx x86_64 test script. Victor Lira (3): automation: add linux 6.6.56 artifact automation: a

[PATCH v6 28/44] x86/boot: add cmdline to struct boot_module

2024-10-17 Thread Daniel P. Smith
Add a char pointer field, cmdline, to struct boot_module to hold the address pointed to by the string field of struct mod. This removes the need to use the early_mod field to get to the dom0 kernel command line. Signed-off-by: Daniel P. Smith --- Changes since v5: - changed boot_module element cm

[PATCH v6 29/44] x86/boot: convert dom0_construct_pv image param to struct boot_module

2024-10-17 Thread Daniel P. Smith
This changes the type for the image parameter of dom0_construct_pv to be struct boot_module. Removing the usage of early_mod field for kernel module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- Changes since v5: - replaced bootstrap_map(NULL) with bootstrap_map_bm --- xen/arch

  1   2   >