Re: [PATCH v5 26/44] x86/boot: convert construct_dom0 to use struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: The construct_dom0 function is converted to consume struct boot_module instances for the kernel and ramdisk. With this change, it is no longer necessary for the internal use of struct mod by create_dom0, so they are changed to struct boot_module. Signe

Re: [PATCH] MAINTAINERS: add myself as maintainer for arm tee

2024-10-08 Thread Volodymyr Babchuk
Bertrand Marquis writes: > With Tee mediators now containing Optee and FF-A implementations, add > myself as maintainers to have someone handling the FF-A side. > > Signed-off-by: Bertrand Marquis Acked-by: Volodymyr Babchuk -- WBR, Volodymyr

Re: [PATCH v5 36/44] x86/boot: remove remaining early_mod references

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Any direct usages of struct mod have been transitioned, remove the remaining references to early_mod fields. This is unclear, please try to re-word. "struct mod" and "early_mod" don't exist. Signed-off-by: Daniel P. Smith --- xen/arch/x86/setu

Re: [PATCH v5 37/44] x86/boot: remove mod from struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: With all references to mod field removed, remove the mod field from struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk

[PATCH] tools/xg: increase LZMA_BLOCK_SIZE for uncompressing the kernel

2024-10-08 Thread Marek Marczykowski-Górecki
Linux 6.12-rc2 fails to decompress with the current 128MiB, contrary to the code comment. It results in a failure like this: domainbuilder: detail: xc_dom_kernel_file: filename="/var/lib/qubes/vm-kernels/6.12-rc2-1.1.fc37/vmlinuz" domainbuilder: detail: xc_dom_malloc_filemap: 12104 kB

Re: [PATCH v5 28/44] x86/boot: add cmdline to struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Add a char pointer field, cmdline, to struct boot_module to hold the address pointed to by the string field of struct mod. This removes the need to use the early_mod field to get to the dom0 kernel command line. Signed-off-by: Daniel P. Smith --- xe

Re: [PATCH v5 33/44] x86/boot: convert initial_images to struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: The variable initial_images is used for tracking the boot modules passed in by the boot loader. Convert to a struct boot_module and adjust the code that uses it accordingly. Signed-off-by: Daniel P. Smith --- xen/arch/x86/setup.c | 15 +-

Re: [PATCH v5 34/44] x86/boot: drop the use of initial_images unit global

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Signed-off-by: Daniel P. Smith --- xen/arch/x86/setup.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 30a139074833..b3b6e6f38622 100644 --- a/xen/arch/x86/setup.c

Re: [PATCH v5 35/44] x86/boot: remove usage of mod_end by discard_initial_images

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: This eliminates usage of early_mod by discard_initial_images Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk

Re: [PATCH] CI: Stop building QEMU in general

2024-10-08 Thread Andrew Cooper
On 08/10/2024 7:54 pm, Stefano Stabellini wrote: > On Tue, 8 Oct 2024, Andrew Cooper wrote: >> On 08/10/2024 5:27 pm, Anthony PERARD wrote: >>> On Tue, Oct 08, 2024 at 04:50:23PM +0100, Andrew Cooper wrote: diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml >>

[xen-unstable-smoke test] 188015: tolerable all pass - PUSHED

2024-10-08 Thread osstest service owner
flight 188015 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/188015/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v4 1/2] x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu

2024-10-08 Thread Frediano Ziglio
On Mon, Oct 7, 2024 at 4:52 PM Alejandro Vallejo wrote: > > fpu_ctxt is either a pointer to the legacy x87/SSE save area (used by FXSAVE) > or > a pointer aliased with xsave_area that points to its fpu_sse subfield. Such > subfield is at the base and is identical in size and layout to the legacy

Re: [PATCH v3 2/2] x86/fpu: Split fpu_setup_fpu() in three

2024-10-08 Thread Jan Beulich
On 07.10.2024 17:59, Alejandro Vallejo wrote: > On Fri Oct 4, 2024 at 7:08 AM BST, Jan Beulich wrote: >> On 03.10.2024 15:54, Alejandro Vallejo wrote: >>> On Tue Aug 13, 2024 at 5:33 PM BST, Alejandro Vallejo wrote: On Tue Aug 13, 2024 at 3:32 PM BST, Jan Beulich wrote: > On 13.08.2024 16:

Re: [PATCH] x86/msr: add log messages to MSR state load error paths

2024-10-08 Thread Roger Pau Monné
On Tue, Oct 08, 2024 at 08:29:23AM +0200, Jan Beulich wrote: > On 07.10.2024 17:32, Roger Pau Monné wrote: > > On Mon, Oct 07, 2024 at 03:16:47PM +0100, Andrew Cooper wrote: > >> On 07/10/2024 3:03 pm, Roger Pau Monne wrote: > >>> Some error paths in the MSR state loading logic don't contain error

Re: [PATCH v2 1/7] x86: Introduce x86_decode_lite()

2024-10-08 Thread Jan Beulich
On 07.10.2024 19:17, Andrew Cooper wrote: > On 07/10/2024 1:56 pm, Jan Beulich wrote: >> On 02.10.2024 17:27, Andrew Cooper wrote: >>> --- /dev/null >>> +++ b/xen/arch/x86/x86_emulate/decode-lite.c >>> @@ -0,0 +1,311 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> + >>> +#include "private.h

Re: [PATCH v3] types: replace remaining uses of s64

2024-10-08 Thread Julien Grall
Hi Jan, On 01/10/2024 14:30, Jan Beulich wrote: --- a/xen/arch/arm/include/asm/arm64/cpufeature.h +++ b/xen/arch/arm/include/asm/arm64/cpufeature.h This file needs to stick with Linux coding style. I don't think it is a problem to include "xen/linux-compat.h" here because the header is only

[PATCH] x86/domctl: fix maximum number of MSRs in XEN_DOMCTL_{get,set}_vcpu_msrs

2024-10-08 Thread Roger Pau Monne
Since the addition of the MSR_AMD64_DR{1-4}_ADDRESS_MASK MSRs to the msrs_to_send array, the calculations for the maximum number of MSRs that the hypercall can handle is off by 4. Remove the addition of 4 to the maximum number of MSRs that XEN_DOMCTL_{set,get}_vcpu_msrs supports, as those are alre

[PATCH v2] x86/msr: add log messages to MSR state load error paths

2024-10-08 Thread Roger Pau Monne
Some error paths in the MSR state loading logic don't contain error messages, which makes debugging them quite hard without adding extra patches to print the information. Add two new log messages to the MSR state load path that print information about the entry that failed to load, for both PV and

Re: Linux 6.12-rc2: xen-privcmd cannot be loaded in domU anymore

2024-10-08 Thread Chen, Jiqian
On 2024/10/9 08:36, Marek Marczykowski-Górecki wrote: > Hi, > > It looks like xen-privcmd now depends on xen-pciback, and the latter > (expectedly) fails to load in domU with -ENODEV. But that prevents > loading xen-privcmd too. And that's bad. Sorry for introducing that and thank you for reportin

Re: [PATCH v5 40/44] x86/boot: add cmdline to struct boot_domain

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Add a container for the "cooked" command line for a domain. Signed-off-by: Daniel P. Smith --- xen/arch/x86/include/asm/bootdomain.h | 4 xen/arch/x86/setup.c | 18 -- 2 files changed, 12 insertions(+), 10 de

[xen-unstable test] 188009: tolerable FAIL

2024-10-08 Thread osstest service owner
flight 188009 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/188009/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-pygrub 19 guest-localmigrate/x10 fail in 188000 pass in 188009 test-armhf-armhf-xl-qcow220

Re: [PATCH v5 00/44] Boot modules for Hyperlaunch

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: The Boot Modules for Hyperlaunch series is an effort to split out preliminary changes necessary for the introduction of the Hyperlaunch domain builder logic. These preliminary changes revolve around introducing the struct boot_module and struct boot_dom

Re: [MINI-OS PATCH 2/2] drop CONFIG_XC support

2024-10-08 Thread Samuel Thibault
Hello, Jürgen Groß, le mar. 08 oct. 2024 11:22:11 +0200, a ecrit: > On 08.10.24 00:13, Samuel Thibault wrote: > > Juergen Gross, le lun. 07 oct. 2024 12:34:56 +0200, a ecrit: > > > CONFIG_XC is no longer needed with individual CONFIG_LIBXEN support. > > > > I don't really see why in the previous

Re: [PATCH v5 36/44] x86/boot: remove remaining early_mod references

2024-10-08 Thread Jan Beulich
On 08.10.2024 21:15, Jason Andryuk wrote: > On 2024-10-06 17:49, Daniel P. Smith wrote: >> Any direct usages of struct mod have been transitioned, remove the remaining >> references to early_mod fields. > > This is unclear, please try to re-word. "struct mod" and "early_mod" > don't exist. > >>

Re: [PATCH v5 39/44] x86/boot: introduce domid field to struct boot_domain

2024-10-08 Thread Jan Beulich
On 08.10.2024 21:36, Jason Andryuk wrote: > On 2024-10-06 17:49, Daniel P. Smith wrote: >> Add a domid field to struct boot_domain to hold the assigned domain id for >> the >> domain. During initialization, ensure all instances of struct boot_domain >> have >> the invalid domid to ensure that the

[ovmf test] 188020: all pass - PUSHED

2024-10-08 Thread osstest service owner
flight 188020 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/188020/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 06da7daab1eb129a1bf3eb93ed74c102d1587071 baseline version: ovmf 550c38a29961ab1c9cc4f

[PATCH] xen: Remove config dependency in XEN_PRIVCMD definition

2024-10-08 Thread Jiqian Chen
Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak reverse dependency to the config XEN_PRIVCMD definition, its purpose is to pass the combination of compilation that CONFIG_XEN_PRIVCMD=y and CONFIG_XEN_PCIDEV_BACKEND=m, because in that combination, xen-pciback is

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-08 Thread Bertrand Marquis
Hi Stefano, > On 9 Oct 2024, at 00:46, Stefano Stabellini wrote: > > On Tue, 8 Oct 2024, Oleksandr Tyshchenko wrote: On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Add common requirements for a physical device assignment to Arm64

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-08 Thread Bertrand Marquis
Hi Oleksandr, > On 8 Oct 2024, at 20:53, Oleksandr Tyshchenko wrote: > > > > On 08.10.24 09:17, Bertrand Marquis wrote: >> Hi, > > Hello Bertrand > > >>> On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: >>> >>> From: Oleksandr Tyshchenko >>> >>> Add common requirements for a physica

Re: [PATCH v5 27/44] x86/boot: relocate kextra into boot info

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Move kextra into struct boot_info, thus no longer needed to be passed as a parameter to create_dom0. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk

Re: [PATCH v5 32/44] x86/boot: convert pvh_load_kernel to struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: This changes both the kernel and ramdisk parameters over to struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk

Re: [PATCH] x86: restore semicolon after explicit DS prefix

2024-10-08 Thread Jan Beulich
On 08.10.2024 18:37, Andrew Cooper wrote: > On 08/10/2024 5:00 pm, Jan Beulich wrote: >> It's not unnecessary (as the earlier commit claimed): The integrated >> assembler of Clang up to 11 complains about an "invalid operand for >> instruction". >> >> Fixes: b42cf31d1165 ("x86: use alternative_inpu

Re: Linux 6.12-rc2: xen-privcmd cannot be loaded in domU anymore

2024-10-08 Thread Jürgen Groß
On 09.10.24 05:41, Chen, Jiqian wrote: On 2024/10/9 08:36, Marek Marczykowski-Górecki wrote: Hi, It looks like xen-privcmd now depends on xen-pciback, and the latter (expectedly) fails to load in domU with -ENODEV. But that prevents loading xen-privcmd too. And that's bad. Sorry for introducin

Re: [PATCH v2] x86/msr: add log messages to MSR state load error paths

2024-10-08 Thread Jan Beulich
On 08.10.2024 10:39, Roger Pau Monne wrote: > Some error paths in the MSR state loading logic don't contain error messages, > which makes debugging them quite hard without adding extra patches to print > the > information. > > Add two new log messages to the MSR state load path that print informa

Re: [PATCH v5 17/44] x86/boot: convert microcode loading to consume struct boot_info

2024-10-08 Thread Jason Andryuk
On 2024-10-07 17:22, Jason Andryuk wrote: On 2024-10-06 17:49, Daniel P. Smith wrote: Convert the microcode loading functions to take struct boot_info, and then using struct boot_module to map and check for microcode. To keep the changes focused, continue using the struct mod to hold the refere

Re: [XEN PATCH v2 1/3] EFI: address a violation of MISRA C Rule 13.6

2024-10-08 Thread Roberto Bagnara
On 2024-10-08 07:59, Jan Beulich wrote: On 02.10.2024 08:54, Roberto Bagnara wrote: On 2024-10-02 08:09, Jan Beulich wrote: On 01.10.2024 23:36, Stefano Stabellini wrote: On Tue, 1 Oct 2024, Jan Beulich wrote: On 01.10.2024 07:25, Roberto Bagnara wrote: On 2024-09-30 15:07, Jan Beulich wrote

Re: [PATCH v5 18/44] x86/boot: convert late microcode loading to struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Remove the use of struct mod to hold the reference for the microcode, converting the code to work with a struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk

Re: [XEN PATCH v2 1/3] EFI: address a violation of MISRA C Rule 13.6

2024-10-08 Thread Marek Marczykowski-Górecki
On Tue, Oct 08, 2024 at 02:49:52PM +0200, Roberto Bagnara wrote: > On 2024-10-08 07:59, Jan Beulich wrote: > > On 02.10.2024 08:54, Roberto Bagnara wrote: > > > On 2024-10-02 08:09, Jan Beulich wrote: > > > > On 01.10.2024 23:36, Stefano Stabellini wrote: > > > > > On Tue, 1 Oct 2024, Jan Beulich w

[xen-unstable-smoke test] 188011: tolerable all pass - PUSHED

2024-10-08 Thread osstest service owner
flight 188011 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/188011/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v2] x86/msr: add log messages to MSR state load error paths

2024-10-08 Thread Roger Pau Monne
Some error paths in the MSR state loading logic don't contain error messages, which makes debugging them quite hard without adding extra patches to print the information. Add two new log messages to the MSR state load path that print information about the entry that failed to load, for both PV and

[PATCH] x86: Use standard C types in multiboot2.h header

2024-10-08 Thread Frediano Ziglio
The header already uses standard types for many fields, extend their usage. No functional change. Signed-off-by: Frediano Ziglio --- xen/include/xen/multiboot2.h | 62 ++-- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/xen/include/xen/multiboot2.

Re: [PATCH] x86/domctl: fix maximum number of MSRs in XEN_DOMCTL_{get,set}_vcpu_msrs

2024-10-08 Thread Jan Beulich
On 08.10.2024 10:37, Roger Pau Monne wrote: > Since the addition of the MSR_AMD64_DR{1-4}_ADDRESS_MASK MSRs to the > msrs_to_send array, the calculations for the maximum number of MSRs that > the hypercall can handle is off by 4. > > Remove the addition of 4 to the maximum number of MSRs that > XE

Re: [PATCH] x86: Use standard C types in multiboot2.h header

2024-10-08 Thread Jan Beulich
On 08.10.2024 10:41, Frediano Ziglio wrote: > The header already uses standard types for many fields, extend > their usage. > No functional change. > > Signed-off-by: Frediano Ziglio Acked-by: Jan Beulich

Re: [XEN PATCH v2 1/3] EFI: address a violation of MISRA C Rule 13.6

2024-10-08 Thread Jan Beulich
On 08.10.2024 14:49, Roberto Bagnara wrote: > On 2024-10-08 07:59, Jan Beulich wrote: >> On 02.10.2024 08:54, Roberto Bagnara wrote: >>> On 2024-10-02 08:09, Jan Beulich wrote: On 01.10.2024 23:36, Stefano Stabellini wrote: > On Tue, 1 Oct 2024, Jan Beulich wrote: >> On 01.10.2024 07:2

Re: [PATCH v2] x86/APIC: Switch flat driver to use phys dst for ext ints

2024-10-08 Thread Jan Beulich
On 07.10.2024 16:34, Matthew Barnes wrote: > --- a/xen/arch/x86/include/asm/genapic.h > +++ b/xen/arch/x86/include/asm/genapic.h > @@ -44,29 +44,11 @@ extern const struct genapic apic_bigsmp; > void cf_check send_IPI_self_legacy(uint8_t vector); > > void cf_check init_apic_ldr_flat(void); > -un

Re: [PATCH v5 21/44] x86/boot: convert ramdisk locating to struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Locate the first unclaimed struct boot_module and mark it as ramdisk. If there are any remaining unclaimed struct boot_module instances, report to the console. In the change, the new boot module iterator is used to find the initrd index, which returns a

Re: [PATCH] CI: Stop building QEMU in general

2024-10-08 Thread Anthony PERARD
On Tue, Oct 08, 2024 at 04:50:23PM +0100, Andrew Cooper wrote: > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index c668736bdc2f..c83e0bdbe119 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -339,6 +339,7 @@ alpine-3.18

Re: [PATCH] CI: Stop building QEMU in general

2024-10-08 Thread Andrew Cooper
On 08/10/2024 5:27 pm, Anthony PERARD wrote: > On Tue, Oct 08, 2024 at 04:50:23PM +0100, Andrew Cooper wrote: >> diff --git a/automation/gitlab-ci/build.yaml >> b/automation/gitlab-ci/build.yaml >> index c668736bdc2f..c83e0bdbe119 100644 >> --- a/automation/gitlab-ci/build.yaml >> +++ b/automation

Re: [PATCH v5 22/44] x86/boot: remove module_map usage from microcode loading

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: With all consumers of module_map converted, remove usage of it by the microcode loading logic. Signed-off-by: Daniel P. Smith @@ -202,19 +201,18 @@ static void __init microcode_scan_module( } } -static void __init microcode_grab_module(

Re: [PATCH v2 1/3] xen/riscv: implement virt_to_maddr()

2024-10-08 Thread oleksii . kurochko
On Fri, 2024-10-04 at 18:04 +0200, Oleksii Kurochko wrote: > Implement the virt_to_maddr() function to convert virtual addresses > to machine addresses, including checks for address ranges such as > the direct mapping area (DIRECTMAP_VIRT_START) and the Xen virtual > address space. To implement thi

Re: [PATCH v2 6/7] x86/alternative: Relocate all insn-relative fields

2024-10-08 Thread Jan Beulich
On 02.10.2024 17:27, Andrew Cooper wrote: > Right now, relocation of displacements is restricted to finding 0xe8/e9 as the > first byte of the replacement, but this is overly restrictive. > > Use x86_decode_lite() to find and adjust all insn-relative fields. > > As with disp8's not leaving the re

Re: [PATCH v3 10/19] xen: Update header guards - I/O MMU

2024-10-08 Thread Jan Beulich
On 04.10.2024 10:17, Frediano Ziglio wrote: > Updated headers related to I/O MMU. > > Signed-off-by: Frediano Ziglio Acked-by: Jan Beulich

[PATCH v4] types: replace remaining uses of s64

2024-10-08 Thread Jan Beulich
... and move the type itself to linux-compat.h. An exception being arch/arm/arm64/cpufeature.c and arch/arm/include/asm/arm64/cpufeature.h, which are to use linux-compat.h instead (the former by including the latter). While doing so - correct the type of union uu's uq field in lib/divmod.c, - swit

[linux-linus test] 188002: tolerable FAIL - PUSHED

2024-10-08 Thread osstest service owner
flight 188002 linux-linus real [real] flight 188010 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188002/ http://logs.test-lab.xenproject.org/osstest/logs/188010/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-

[PATCH] iommu/amd-vi: do not error if device referenced in IVMD is not behind any IOMMU

2024-10-08 Thread Roger Pau Monne
IVMD table contains restrictions about memory which must be mandatory assigned to devices (and which permissions it should use), or memory that should be never accessible to devices. Some hardware however contains ranges in IVMD that reference devices outside of the IVHD tables (in other words, de

Re: [PATCH v2 0/6] Reuse 32 bit C code more safely

2024-10-08 Thread Andrew Cooper
On 07/10/2024 3:15 pm, Frediano Ziglio wrote: > Frediano Ziglio (6): > .gitignore: Remove not generated files > x86/boot: Rationalise .gitignore These two are trivial so I've taken them. ~Andrew

Re: [PATCH] iommu/amd-vi: do not error if device referenced in IVMD is not behind any IOMMU

2024-10-08 Thread Jan Beulich
On 08.10.2024 12:47, Roger Pau Monne wrote: > IVMD table contains restrictions about memory which must be mandatory assigned > to devices (and which permissions it should use), or memory that should be > never accessible to devices. > > Some hardware however contains ranges in IVMD that reference

Re: [PATCH] MAINTAINERS: add myself as maintainer for arm tee

2024-10-08 Thread Jan Beulich
On 08.10.2024 15:54, Bertrand Marquis wrote: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -516,6 +516,7 @@ F:stubdom/ > > TEE MEDIATORS > M: Volodymyr Babchuk > +M: Bertrand Marquis > S: Supported > F: xen/arch/arm/include/asm/tee > F: xen/arch/arm/tee/ Like for Frediano

[PATCH] MAINTAINERS: add myself as maintainer for arm tee

2024-10-08 Thread Bertrand Marquis
With Tee mediators now containing Optee and FF-A implementations, add myself as maintainers to have someone handling the FF-A side. Signed-off-by: Bertrand Marquis --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb0ebf093965..2450b0f9ff9e 10064

Re: [PATCH v2] x86/APIC: Switch flat driver to use phys dst for ext ints

2024-10-08 Thread Matthew Barnes
On Tue, Oct 08, 2024 at 03:47:41PM +0200, Jan Beulich wrote: > On 07.10.2024 16:34, Matthew Barnes wrote: > > --- a/xen/arch/x86/include/asm/genapic.h > > +++ b/xen/arch/x86/include/asm/genapic.h > > @@ -44,29 +44,11 @@ extern const struct genapic apic_bigsmp; > > void cf_check send_IPI_self_legac

Re: [PATCH v3 03/19] xen: Update header guards - ACPI

2024-10-08 Thread Jan Beulich
On 04.10.2024 10:16, Frediano Ziglio wrote: > Updated headers related to ACPI. > > Signed-off-by: Frediano Ziglio > --- > xen/drivers/acpi/apei/apei-internal.h | 4 ++-- > xen/include/acpi/acconfig.h | 6 +++--- > xen/include/acpi/acexcep.h| 6 +++--- > xen/incl

Re: [PATCH v6 02/11] x86/vlapic: Move lapic migration checks to the check hooks

2024-10-08 Thread Jan Beulich
On 01.10.2024 14:37, Alejandro Vallejo wrote: > While doing this, factor out checks common to architectural and hidden > state. > > Signed-off-by: Alejandro Vallejo > Reviewed-by: Roger Pau Monné > -- > Last reviewed in the topology series v3. Fell under the cracks. > > https://lore.kernel.or

[PATCH] CI: Stop building QEMU in general

2024-10-08 Thread Andrew Cooper
We spend an awful lot of CI time building QEMU, even though most changes don't touch the subset of tools/libs/ used by QEMU. Some numbers taken at a time when CI was otherwise quiet: With Without Alpine: 13m38s 6m04s Debian 12: 10m05s 8m10

Re: [PATCH v5 19/44] x86/boot: use consumed boot module flag for microcode

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: To track if the microcode boot module was loaded, a copy of the boot module is kept. The size element of this copy is set to zero as the indicator that the microcode was loaded. A side effect is that the modules have to be rescanned to find the boot mod

Re: [PATCH v5 1/6] xen: introduce DECL_SECTION_WITH_LADDR

2024-10-08 Thread oleksii . kurochko
Hello Shawn, On Fri, 2024-09-27 at 18:32 +0200, Oleksii Kurochko wrote: > Introduce DECL_SECTION_WITH_LADDR in order to signal whether > DECL_SECTION() should specify a load address or not. > > Update {ppc,x86}/xen.lds.S to use DECL_SECTION_WITH_LADDR. > > Signed-off-by: Oleksii Kurochko > Acke

Re: [PATCH v5 0/6] Move {acpi_}device_init() and device_get_class() to common code

2024-10-08 Thread oleksii . kurochko
On Tue, 2024-10-08 at 17:30 +0200, Jan Beulich wrote: > On 08.10.2024 17:25, oleksii.kuroc...@gmail.com wrote: > > Except the comments ( which Jan wrote could be adjusted while > > committing ) for patch 1 everything is properly Acked/Reviewed ( if > > I > > am not missing something ). > > I didn'

[PATCH] x86: restore semicolon after explicit DS prefix

2024-10-08 Thread Jan Beulich
It's not unnecessary (as the earlier commit claimed): The integrated assembler of Clang up to 11 complains about an "invalid operand for instruction". Fixes: b42cf31d1165 ("x86: use alternative_input() in cache_flush()") Signed-off-by: Jan Beulich --- a/xen/arch/x86/flushtlb.c +++ b/xen/arch/x86

[PATCH] MAINTAINERS: Add myself as a reviewer for RISC-V

2024-10-08 Thread Oleksii Kurochko
As an active contributor to Xen's RISC-V port, so add myself to the list of reviewers. Signed-off-by: Oleksii Kurochko --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb0ebf0939..6b0b5654d6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -485,6 +

Re: [PATCH v4] types: replace remaining uses of s64

2024-10-08 Thread Julien Grall
Hi Jan, On 08/10/2024 15:56, Jan Beulich wrote: ... and move the type itself to linux-compat.h. An exception being arch/arm/arm64/cpufeature.c and arch/arm/include/asm/arm64/cpufeature.h, which are to use linux-compat.h instead (the former by including the latter). While doing so - correct the

Re: [PATCH] MAINTAINERS: Add myself as a reviewer for RISC-V

2024-10-08 Thread Jan Beulich
On 08.10.2024 18:03, Oleksii Kurochko wrote: > As an active contributor to Xen's RISC-V port, so add myself > to the list of reviewers. > > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich

Re: [PATCH v5 20/44] x86/boot: convert xsm policy loading to struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Iterate through the unclaimed struct boot_module to see if any are an XSM FLASK policy. If one is located, mark it as an xsm policy. Signed-off-by: Daniel P. Smith @@ -161,6 +162,14 @@ int __init xsm_multiboot_init( } ret = xsm_core_

Re: [PULL v2 2/5] hw/xen: Expose handle_bufioreq in xen_register_ioreq

2024-10-08 Thread Edgar E. Iglesias
On Mon, Oct 07, 2024 at 04:42:49PM +0100, Peter Maydell wrote: > On Thu, 3 Oct 2024 at 19:57, Edgar E. Iglesias > wrote: > > > > From: "Edgar E. Iglesias" > > > > Expose handle_bufioreq in xen_register_ioreq(). > > This is to allow machines to enable or disable buffered ioreqs. > > > > No functi

Re: [PATCH v4 1/2] x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu

2024-10-08 Thread Alejandro Vallejo
On Tue Oct 8, 2024 at 8:47 AM BST, Frediano Ziglio wrote: > On Mon, Oct 7, 2024 at 4:52 PM Alejandro Vallejo > wrote: > > > > fpu_ctxt is either a pointer to the legacy x87/SSE save area (used by > > FXSAVE) or > > a pointer aliased with xsave_area that points to its fpu_sse subfield. Such > > su

Re: [PATCH v3 11/19] xen: Update header guards - Kconfig

2024-10-08 Thread Jan Beulich
On 04.10.2024 10:17, Frediano Ziglio wrote: > Updated headers related to Kconfig. > > Signed-off-by: Frediano Ziglio > --- > xen/tools/kconfig/expr.h | 6 +++--- > xen/tools/kconfig/images.h | 6 +++--- > xen/tools/kconfig/list.h | 4 ++-- > xen/tools/kconfig/lkc.h| 6 +++--- > 4 files c

Re: [PATCH v3 15/19] xen: Update header guards - RISC-V

2024-10-08 Thread Jan Beulich
On 04.10.2024 10:17, Frediano Ziglio wrote: > Updated headers related to RISC-V. > > Signed-off-by: Frediano Ziglio Acked-by: Jan Beulich > --- > xen/arch/riscv/include/asm/acpi.h | 6 +++--- > xen/arch/riscv/include/asm/asm.h| 6 +++--- > xen/arch/riscv/include/asm/atom

Re: [RFC PATCH 05/28] x86: Define the stack protector guard symbol explicitly

2024-10-08 Thread Brian Gerst
On Fri, Oct 4, 2024 at 9:15 AM Ard Biesheuvel wrote: > > On Sat, 28 Sept 2024 at 15:41, Brian Gerst wrote: > > > > On Wed, Sep 25, 2024 at 2:33 PM Uros Bizjak wrote: > > > > > > On Wed, Sep 25, 2024 at 5:02 PM Ard Biesheuvel > > > wrote: > > > > > > > > From: Ard Biesheuvel > > > > > > > > Sp

Re: [PATCH v3 09/19] xen: Update header guards - Intel TXT

2024-10-08 Thread Jan Beulich
On 04.10.2024 10:17, Frediano Ziglio wrote: > Updated headers related to Intel trusted execution technology. > > Signed-off-by: Frediano Ziglio Acked-by: Jan Beulich

Re: [PATCH v2 1/3] xen/riscv: implement virt_to_maddr()

2024-10-08 Thread Jan Beulich
On 08.10.2024 12:26, oleksii.kuroc...@gmail.com wrote: > On Fri, 2024-10-04 at 18:04 +0200, Oleksii Kurochko wrote: >> @@ -28,7 +29,21 @@ static inline void *maddr_to_virt(paddr_t ma) >> return NULL; >>  } >>   >> -#define virt_to_maddr(va) ({ BUG_ON("unimplemented"); 0; }) >> +static inline u

Re: [PATCH v2 3/3] xen/riscv: register Xen's load address as a boot module

2024-10-08 Thread Jan Beulich
On 04.10.2024 18:04, Oleksii Kurochko wrote: > Avoid using BOOTMOD_XEN region for other purposes or boot modules > which could result in memory corruption or undefined behaviour. > > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich

Re: [PATCH v2 2/3] xen/riscv: switch LINK_TO_LOAD() to virt_to_maddr()

2024-10-08 Thread Jan Beulich
On 04.10.2024 18:04, Oleksii Kurochko wrote: > Use virt_to_maddr() instead of LINK_TO_LOAD as virt_to_maddr() > covers all the cases where LINK_TO_LOAD() is used. > > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich

Re: [PATCH v2] x86/msr: add log messages to MSR state load error paths

2024-10-08 Thread Roger Pau Monné
I've wrongly send this together with "x86/domctl: fix maximum number of MSRs in XEN_DOMCTL_{get,set}_vcpu_msrs". There's a separate email with just "[PATCH v2] x86/msr: add log messages to MSR state load error paths". Both have the same contents. Roger.

Re: [PATCH 2/4] stubdom: explcitly add libc and lwip Mini-OS config options

2024-10-08 Thread Jürgen Groß
On 07.10.24 23:50, Samuel Thibault wrote: diff --git a/stubdom/grub/minios.cfg b/stubdom/grub/minios.cfg index 8df49092cd..5145b357e0 100644 --- a/stubdom/grub/minios.cfg +++ b/stubdom/grub/minios.cfg @@ -1,3 +1,4 @@ -CONFIG_START_NETWORK=n +CONFIG_LIBC=y +CONFIG_LWIP=n CONFIG_SPARSE_BSS=n CO

Re: [PATCH v4 2/2] x86/fpu: Rework fpu_setup_fpu() uses to split it in two

2024-10-08 Thread Alejandro Vallejo
On Tue Oct 8, 2024 at 7:37 AM BST, Jan Beulich wrote: > On 07.10.2024 17:52, Alejandro Vallejo wrote: > > It was trying to do too many things at once and there was no clear way of > > defining what it was meant to do. This commit splits the function in two. > > > > 1. A function to return the FP

Re: [PATCH v5 23/44] x86/boot: remove module_map usage from xsm policy loading

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Signed-off-by: Daniel P. Smith --- xen/arch/x86/setup.c | 2 +- xen/include/xsm/xsm.h | 9 +++-- xen/xsm/xsm_core.c| 6 ++ xen/xsm/xsm_policy.c | 5 + 4 files changed, 7 insertions(+), 15 deletions(-) diff --git a/xen/xsm/xs

Re: [PATCH] x86: restore semicolon after explicit DS prefix

2024-10-08 Thread Andrew Cooper
On 08/10/2024 5:00 pm, Jan Beulich wrote: > It's not unnecessary (as the earlier commit claimed): The integrated > assembler of Clang up to 11 complains about an "invalid operand for > instruction". > > Fixes: b42cf31d1165 ("x86: use alternative_input() in cache_flush()") > Signed-off-by: Jan Beuli

Re: [PATCH v5 24/44] x86/boot: remove module_map usage by ramdisk loading

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: The ramdisk loading is the last user of module_map, remove its usage and any remaining remnants of module_map. Signed-off-by: Daniel P. Smith --- xen/arch/x86/setup.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/x

Linux 6.12-rc2: xen-privcmd cannot be loaded in domU anymore

2024-10-08 Thread Marek Marczykowski-Górecki
Hi, It looks like xen-privcmd now depends on xen-pciback, and the latter (expectedly) fails to load in domU with -ENODEV. But that prevents loading xen-privcmd too. And that's bad. The dependency looks to be introduced by this commit: commit 2fae6bb7be320270801b3c3b040189bd7daa8056 Author: Jiqia

Re: [PATCH v5 25/44] x86/boot: convert create_dom0 to use boot info

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: This commit changes create_dom0 to no longer take the individual components and take struct boot_info instead. Internally, it is changed to locate the kernel and ramdisk details from struct boot_info. Signed-off-by: Daniel P. Smith --- xen/arch/x86/

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-08 Thread Stefano Stabellini
On Tue, 8 Oct 2024, Oleksandr Tyshchenko wrote: > > > On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: > > > > > > From: Oleksandr Tyshchenko > > > > > > Add common requirements for a physical device assignment to Arm64 > > > and AMD64 PVH domains. > > > > > > Signed-off-by: Oleksandr Tysh

[libvirt test] 188008: regressions - FAIL

2024-10-08 Thread osstest service owner
flight 188008 libvirt real [real] flight 188014 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188008/ http://logs.test-lab.xenproject.org/osstest/logs/188014/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-

Re: [PATCH v5 30/44] x86/boot: convert dom0_construct_pv initrd param to struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: This changes the type for the initrd parameter of dom0_construct_pv to be struct boot_module. This conversion requires several adjustments throughout dom0_construct_pv to account for the type change. Removes the usage of early_mod field for ramdisk mo

Re: [PATCH v5 31/44] x86/boot: convert dom0_construct_pvh to struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: This changes both the kernel and ramdisk parameters over to struct boot_module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk

Re: [PATCH v5 00/44] Boot modules for Hyperlaunch

2024-10-08 Thread Andrew Cooper
On 08/10/2024 9:07 pm, Jason Andryuk wrote: > On 2024-10-06 17:49, Daniel P. Smith wrote: >> The Boot Modules for Hyperlaunch series is an effort to split out >> preliminary >> changes necessary for the introduction of the Hyperlaunch domain builder >> logic. These preliminary changes revolve aroun

Re: [PATCH] docs: fusa: Add requirements for Device Passthrough

2024-10-08 Thread Oleksandr Tyshchenko
On 08.10.24 09:17, Bertrand Marquis wrote: Hi, Hello Bertrand On 7 Oct 2024, at 20:55, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Add common requirements for a physical device assignment to Arm64 and AMD64 PVH domains. Signed-off-by: Oleksandr Tyshchenko --- Based on:

Re: [PATCH] CI: Stop building QEMU in general

2024-10-08 Thread Stefano Stabellini
On Tue, 8 Oct 2024, Andrew Cooper wrote: > On 08/10/2024 5:27 pm, Anthony PERARD wrote: > > On Tue, Oct 08, 2024 at 04:50:23PM +0100, Andrew Cooper wrote: > >> diff --git a/automation/gitlab-ci/build.yaml > >> b/automation/gitlab-ci/build.yaml > >> index c668736bdc2f..c83e0bdbe119 100644 > >> ---

Re: [PATCH v2 5/8] xen/arm: platforms: Add NXP S32CC platform code

2024-10-08 Thread Andrei Cherechesu
Hi Julien, On 04/10/2024 19:24, Julien Grall wrote: > > > On 04/10/2024 16:37, Andrei Cherechesu wrote: >> Hi Julien, Stefano, > > Hi Andrei, > >> >> On 01/10/2024 13:01, Julien Grall wrote: >>> Hi Andrei, >>> >>> On 30/09/2024 12:47, Andrei Cherechesu (OSS) wrote: From: Andrei Cherechesu >>

Re: [PATCH v5 29/44] x86/boot: convert dom0_construct_pv image param to struct boot_module

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: This changes the type for the image parameter of dom0_construct_pv to be struct boot_module. Removing the usage of early_mod field for kernel module. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk

Re: [PATCH v5 38/44] x86/boot: introduce boot domain

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: To begin moving toward allowing the hypervisor to construct more than one domain at boot, a container is needed for a domain's build information. Introduce a new header, , that contains the initial struct boot_domain that encapsulate the build informat

Re: [PATCH v2 5/8] xen/arm: platforms: Add NXP S32CC platform code

2024-10-08 Thread Julien Grall
Hi, On 08/10/2024 20:01, Andrei Cherechesu wrote: Hi Julien, On 04/10/2024 19:24, Julien Grall wrote: On 04/10/2024 16:37, Andrei Cherechesu wrote: Hi Julien, Stefano, Hi Andrei, On 01/10/2024 13:01, Julien Grall wrote: Hi Andrei, On 30/09/2024 12:47, Andrei Cherechesu (OSS) wrote:

Re: [PATCH v5 39/44] x86/boot: introduce domid field to struct boot_domain

2024-10-08 Thread Jason Andryuk
On 2024-10-06 17:49, Daniel P. Smith wrote: Add a domid field to struct boot_domain to hold the assigned domain id for the domain. During initialization, ensure all instances of struct boot_domain have the invalid domid to ensure that the domid must be set either by convention or configuration.

  1   2   >