On 08/10/2024 5:27 pm, Anthony PERARD wrote: > On Tue, Oct 08, 2024 at 04:50:23PM +0100, Andrew Cooper wrote: >> diff --git a/automation/gitlab-ci/build.yaml >> b/automation/gitlab-ci/build.yaml >> index c668736bdc2f..c83e0bdbe119 100644 >> --- a/automation/gitlab-ci/build.yaml >> +++ b/automation/gitlab-ci/build.yaml >> @@ -339,6 +339,7 @@ alpine-3.18-gcc-debug: >> extends: .gcc-x86-64-build-debug >> variables: >> CONTAINER: alpine:3.18 >> + QEMU: y > Could you use a different name for the variable? This is exposed as an > environment variable, it could easily be used in a build system already, > like used to store a path to a QEMU to use. > > We don't really have a name space for CI variable, but maybe > BUILD_QEMU or BUILD_QEMU_XEN would be less likely to clash with other > usages. > > Otherwise patch looks fine.
A can switch to BUILD_QEMU, but I don't plan to repost just for that. ~Andrew
