Re: [PATCH] pmstat: Limit hypercalls under HWP

2024-01-23 Thread Jan Beulich
On 22.01.2024 20:09, Jason Andryuk wrote: > When HWP is active, the cpufreq P-state information is not updated. In > that case, return -ENODEV instead of bogus, incomplete info. The xenpm > command already supports skipping results when -ENODEV is returned, so > it is re-used when -EOPNOTSUPP mig

Re: Xen 4.18rc/ARM64 on Raspberry Pi 4B: Traffic in DomU crashing Dom0 when using VLANs

2024-01-23 Thread Bertrand Marquis
Hi, will try to explain some of the messages here after but I am not sure of the reason of the crash so I will just set some pointers... > On 22 Jan 2024, at 11:46, George Dunlap wrote: > > On Fri, Jan 19, 2024 at 8:32 PM Elliott Mitchell wrote: >> >> On Sun, Jan 14, 2024 at 10:54:24PM +010

Re: [PATCH 1/3] x86/entry: Fix ELF metadata for NMI and handle_ist_exception

2024-01-23 Thread Jan Beulich
On 22.01.2024 19:17, Andrew Cooper wrote: > handle_ist_exception isn't part of the NMI handler, just like handle_exception > isn't part of #PF. > > Fixes: b3a9037550df ("x86: annotate entry points with type and size") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich It's a matter of con

Re: [PATCH 2/3] x86/entry: Make #PF/NMI/INT0x82 more amenable to livepatching

2024-01-23 Thread Jan Beulich
On 22.01.2024 19:17, Andrew Cooper wrote: > It is bad form to have inter-function fallthrough. It only functions right > now because alignment padding bytes are NOPs. But that's a requirement anyway in executable sections. > --- a/xen/arch/x86/x86_64/compat/entry.S > +++ b/xen/arch/x86/x86_64/co

Re: [PATCH v5] x86/livepatch: align functions to ensure minimal distance between entry points

2024-01-23 Thread Roger Pau Monné
On Tue, Jan 23, 2024 at 08:53:15AM +0100, Jan Beulich wrote: > On 22.01.2024 18:27, Roger Pau Monné wrote: > > On Mon, Jan 22, 2024 at 12:21:47PM +0100, Jan Beulich wrote: > >> On 22.01.2024 12:02, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/xen.lds.S > >>> +++ b/xen/arch/x86/xen.lds.S > >>> @@

Re: [PATCH 3/3] x86/entry: Make intra-funciton symbols properly local

2024-01-23 Thread Jan Beulich
On 22.01.2024 19:17, Andrew Cooper wrote: > Each of these symbols are local to their main function. By not having them > globally visible, livepatch's binary diffing logic can reason about the > functions properly. I'm not happy with this, and not only because of the way you're putting things: "g

Re: [PATCH v5] x86/livepatch: align functions to ensure minimal distance between entry points

2024-01-23 Thread Jan Beulich
On 23.01.2024 10:32, Roger Pau Monné wrote: > On Tue, Jan 23, 2024 at 08:53:15AM +0100, Jan Beulich wrote: >> On 22.01.2024 18:27, Roger Pau Monné wrote: >>> On Mon, Jan 22, 2024 at 12:21:47PM +0100, Jan Beulich wrote: I'm further curious why .text.__x86_indirect_thunk_* is left past the

Re: [RFC KERNEL PATCH v4 3/3] PCI/sysfs: Add gsi sysfs for pci_dev

2024-01-23 Thread Chen, Jiqian
On 2024/1/23 07:37, Bjorn Helgaas wrote: > On Fri, Jan 05, 2024 at 02:22:17PM +0800, Jiqian Chen wrote: >> There is a need for some scenarios to use gsi sysfs. >> For example, when xen passthrough a device to dumU, it will >> use gsi to map pirq, but currently userspace can't get gsi >> number. >>

Re: [PATCH v3 13/34] xen/riscv: introduce cmpxchg.h

2024-01-23 Thread Oleksii
On Mon, 2024-01-22 at 17:27 +0100, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/cmpxchg.h > > @@ -0,0 +1,496 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* Copyright (C) 2014 Regents of the University of Califo

Re: [PATCH v3 15/34] xen/riscv: introduce atomic.h

2024-01-23 Thread Oleksii
On Mon, 2024-01-22 at 17:56 +0100, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/atomic.h > > @@ -0,0 +1,384 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * Taken and modified from Linux. > > + * > > + *

[xen-unstable test] 184429: tolerable FAIL

2024-01-23 Thread osstest service owner
flight 184429 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184429/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184426 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH v3 13/34] xen/riscv: introduce cmpxchg.h

2024-01-23 Thread Jan Beulich
On 23.01.2024 11:15, Oleksii wrote: > On Mon, 2024-01-22 at 17:27 +0100, Jan Beulich wrote: >> On 22.12.2023 16:12, Oleksii Kurochko wrote: >>> +    : "=r" (ret__), "+A" (*ptr__) \ >>> +    : "r" (new__) \ >>> +    : "memory" ); \ >>> +    break; \ >>> +    case 8: \ >>>

Re: [PATCH v3 15/34] xen/riscv: introduce atomic.h

2024-01-23 Thread Jan Beulich
On 23.01.2024 11:21, Oleksii wrote: > On Mon, 2024-01-22 at 17:56 +0100, Jan Beulich wrote: >> On 22.12.2023 16:12, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/fence.h >>> @@ -0,0 +1,13 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >>> +#ifndef _ASM_RISC

Re: Thoughts on current Xen EDAC/MCE situation

2024-01-23 Thread Jan Beulich
On 22.01.2024 21:53, Elliott Mitchell wrote: > I've been mentioning this on a regular basis, but the state of MCE > handling with Xen seems poor. I certainly agree here. > I find the present handling of MCE in Xen an odd choice. Having Xen do > most of the handling of MCE events is a behavior ma

[PATCH v2] x86/CPU: convert vendor hook invocations to altcall

2024-01-23 Thread Jan Beulich
While not performance critical, these hook invocations still want converting: This way all pre-filled struct cpu_dev instances can become __initconst_cf_clobber, thus allowing to eliminate further 8 ENDBR during the 2nd phase of alternatives patching (besides moving previously resident data to .ini

Re: [PATCH v3 16/34] xen/lib: introduce generic find next bit operations

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/fence.h > +++ b/xen/arch/riscv/include/asm/fence.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* SPDX-License-Identifier: GPL-2.0-only */ > #ifndef _ASM_RISCV_FENCE_H > #define _ASM_RISCV_

Re: [PATCH v3 19/34] xen/riscv: introduce guest_access.h

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > All necessary dummiy implementation of functions in this header > will be introduced in stubs.c > > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich

Re: [PATCH v3 20/34] xen/riscv: introduce irq.h

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > +static inline void arch_move_irqs(struct vcpu *v) > +{ > +BUG(); > +} As I think you said you're doing the conversion already - with this becoming the "canonical" BUG_ON("unimplemented"): Acked-by: Jan Beulich Jan

Re: [PATCH v3 34/34] xen/README: add compiler and binutils versions for RISC-V64

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - new patch > --- > README | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/README b/README > index c8a108449e..1015a285c0 100644 > --- a/README > +++ b/README > @@ -48,6 +48,9 @

Re: [PATCH v3 27/34] xen/riscv: define an address of frame table

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > Also, the patch adds some helpful macros that assist in avoiding > the redefinition of memory layout for each MMU mode. > > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - drop OFFSET_BITS, and use PAGE_SHIFT instead. > - code style fixe

Re: [PATCH v3 28/34] xen/riscv: add required things to current.h

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote:> --- a/xen/arch/riscv/include/asm/current.h > +++ b/xen/arch/riscv/include/asm/current.h > @@ -3,6 +3,21 @@ > #ifndef __ASM_CURRENT_H > #define __ASM_CURRENT_H > > +#include > +#include > +#include > + > +#ifndef __ASSEMBLY__ > + > +/* Which VCPU

Re: [PATCH v3 29/34] xen/riscv: add minimal stuff to page.h to build full Xen

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > Acked-by: Jan Beulich > --- > Changes in V3: > - update the commit message Once again I find this puzzling, considering there's no commit message at all. Jan

Re: [PATCH v3 30/34] xen/riscv: add minimal stuff to processor.h to build full Xen

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - Update the commit message ??? (again) > @@ -53,6 +56,18 @@ struct cpu_user_regs > unsigned long pregs; > }; > > +/* TODO: need to implement */ > +#define cpu_to_core(cpu) (0) > +#

Re: [PATCH v5 09/13] xen: add cache coloring allocator for domains

2024-01-23 Thread Julien Grall
Hi Carlo, On 18/01/2024 14:27, Carlo Nonato wrote: On Tue, Jan 9, 2024 at 11:33 AM Jan Beulich wrote: On 09.01.2024 11:28, Jan Beulich wrote: On 02.01.2024 10:51, Carlo Nonato wrote: v5: - Carlo Nonato as the new author - the colored allocator balances color usage for each domain and it sea

Re: [PATCH v3 13/34] xen/riscv: introduce cmpxchg.h

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 11:28 +0100, Jan Beulich wrote: > On 23.01.2024 11:15, Oleksii wrote: > > On Mon, 2024-01-22 at 17:27 +0100, Jan Beulich wrote: > > > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > > > +    : "=r" (ret__), "+A" (*ptr__) \ > > > > +    : "r" (new__) \ > > > >

Re: [PATCH v3 15/34] xen/riscv: introduce atomic.h

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 11:30 +0100, Jan Beulich wrote: > On 23.01.2024 11:21, Oleksii wrote: > > On Mon, 2024-01-22 at 17:56 +0100, Jan Beulich wrote: > > > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > > > --- /dev/null > > > > +++ b/xen/arch/riscv/include/asm/fence.h > > > > @@ -0,0 +1,13 @@ >

Re: [PATCH v3 20/34] xen/riscv: introduce irq.h

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 12:18 +0100, Jan Beulich wrote: > On 22.12.2023 16:13, Oleksii Kurochko wrote: > > +static inline void arch_move_irqs(struct vcpu *v) > > +{ > > +    BUG(); > > +} > > As I think you said you're doing the conversion already - with this > becoming the "canonical" BUG_ON("unimp

Re: [PATCH v3 16/34] xen/lib: introduce generic find next bit operations

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 12:14 +0100, Jan Beulich wrote: > On 22.12.2023 16:13, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/include/asm/fence.h > > +++ b/xen/arch/riscv/include/asm/fence.h > > @@ -1,4 +1,4 @@ > > -/* SPDX-License-Identifier: GPL-2.0-or-later */ > > +/* SPDX-License-Identifier: GP

[libvirt test] 184431: tolerable all pass - PUSHED

2024-01-23 Thread osstest service owner
flight 184431 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/184431/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184409 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH v3 31/34] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - update the commit message ??? (yet again) > --- a/xen/arch/riscv/include/asm/mm.h > +++ b/xen/arch/riscv/include/asm/mm.h > @@ -3,8 +3,251 @@ > #ifndef _ASM_RISCV_MM_H > #define _ASM_RISC

Re: [PATCH v3 32/34] xen/rirscv: add minimal amount of stubs to build full Xen

2024-01-23 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/early_printk.c > +++ b/xen/arch/riscv/early_printk.c > @@ -40,171 +40,3 @@ void early_printk(const char *str) > str++; > } > } > - > -/* > - * The following #if 1 ... #endif should be removed after printk > - * and r

Re: [PATCH v3 13/34] xen/riscv: introduce cmpxchg.h

2024-01-23 Thread Jan Beulich
On 23.01.2024 13:18, Oleksii wrote: > On Tue, 2024-01-23 at 11:28 +0100, Jan Beulich wrote: >> On 23.01.2024 11:15, Oleksii wrote: >>> On Mon, 2024-01-22 at 17:27 +0100, Jan Beulich wrote: On 22.12.2023 16:12, Oleksii Kurochko wrote: > +static inline unsigned long __xchg(volatile void *ptr

Re: [PATCH v3 15/34] xen/riscv: introduce atomic.h

2024-01-23 Thread Jan Beulich
On 23.01.2024 13:24, Oleksii wrote: > On Tue, 2024-01-23 at 11:30 +0100, Jan Beulich wrote: >> On 23.01.2024 11:21, Oleksii wrote: >>> On Mon, 2024-01-22 at 17:56 +0100, Jan Beulich wrote: On 22.12.2023 16:12, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/f

Re: [PATCH v3 16/34] xen/lib: introduce generic find next bit operations

2024-01-23 Thread Jan Beulich
On 23.01.2024 13:34, Oleksii wrote: > On Tue, 2024-01-23 at 12:14 +0100, Jan Beulich wrote: >> On 22.12.2023 16:13, Oleksii Kurochko wrote: >>> --- a/xen/common/Kconfig >>> +++ b/xen/common/Kconfig >>> @@ -47,6 +47,9 @@ config ARCH_MAP_DOMAIN_PAGE >>>  config GENERIC_BUG_FRAME >>>   bool >>>   >>

Re: [PATCH 2/3] x86/entry: Make #PF/NMI/INT0x82 more amenable to livepatching

2024-01-23 Thread Roger Pau Monné
On Tue, Jan 23, 2024 at 10:22:10AM +0100, Jan Beulich wrote: > On 22.01.2024 19:17, Andrew Cooper wrote: > > It is bad form to have inter-function fallthrough. It only functions right > > now because alignment padding bytes are NOPs. > > But that's a requirement anyway in executable sections. Re

Re: [PATCH 2/3] x86/entry: Make #PF/NMI/INT0x82 more amenable to livepatching

2024-01-23 Thread Jan Beulich
On 23.01.2024 14:37, Roger Pau Monné wrote: > On Tue, Jan 23, 2024 at 10:22:10AM +0100, Jan Beulich wrote: >> On 22.01.2024 19:17, Andrew Cooper wrote: >>> It is bad form to have inter-function fallthrough. It only functions right >>> now because alignment padding bytes are NOPs. >> >> But that's

Re: [PATCH v12.2 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-23 Thread Jan Beulich
On 15.01.2024 20:43, Stewart Hildebrand wrote: > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -468,7 +468,7 @@ int msixtbl_pt_register(struct domain *d, struct pirq > *pirq, uint64_t gtable) > struct msixtbl_entry *entry, *new_entry; > int r = -EINVAL; > > -AS

Re: [PATCH v12.2 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-23 Thread Jan Beulich
On 15.01.2024 20:43, Stewart Hildebrand wrote: > @@ -1043,11 +1043,11 @@ static int __pci_enable_msix(struct pci_dev *pdev, > struct msi_info *msi, > { > struct msi_desc *old_desc; > > -ASSERT(pcidevs_locked()); > - > if ( !pdev || !pdev->msix ) > return -ENODEV; > > +

[xen-unstable-smoke test] 184433: tolerable all pass - PUSHED

2024-01-23 Thread osstest service owner
flight 184433 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184433/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v12.2 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-23 Thread Jan Beulich
On 15.01.2024 20:43, Stewart Hildebrand wrote: > @@ -2888,6 +2888,8 @@ int allocate_and_map_msi_pirq(struct domain *d, int > index, int *pirq_p, > { > int irq, pirq, ret; > > +ASSERT(pcidevs_locked() || rw_is_locked(&d->pci_lock)); If either lock is sufficient to hold here, ... > ---

Re: [PATCH v12 03/15] vpci: add hooks for PCI device assign/de-assign

2024-01-23 Thread Jan Beulich
On 09.01.2024 22:51, Stewart Hildebrand wrote: > From: Oleksandr Andrushchenko > > When a PCI device gets assigned/de-assigned we need to > initialize/de-initialize vPCI state for the device. > > Also, rename vpci_add_handlers() to vpci_assign_device() and > vpci_remove_device() to vpci_deassign

Re: [PATCH v3 34/34] xen/README: add compiler and binutils versions for RISC-V64

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 12:22 +0100, Jan Beulich wrote: > On 22.12.2023 16:13, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > >  Changes in V3: > >   - new patch > > --- > >  README | 3 +++ > >  1 file changed, 3 insertions(+) > > > > diff --git a/README b/README > > index c8

Re: [PATCH v12.2 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-23 Thread Roger Pau Monné
On Tue, Jan 23, 2024 at 03:32:12PM +0100, Jan Beulich wrote: > On 15.01.2024 20:43, Stewart Hildebrand wrote: > > @@ -2888,6 +2888,8 @@ int allocate_and_map_msi_pirq(struct domain *d, int > > index, int *pirq_p, > > { > > int irq, pirq, ret; > > > > +ASSERT(pcidevs_locked() || rw_is_lo

Re: [PATCH v12.2 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-23 Thread Roger Pau Monné
On Tue, Jan 23, 2024 at 03:26:26PM +0100, Jan Beulich wrote: > On 15.01.2024 20:43, Stewart Hildebrand wrote: > > --- a/xen/arch/x86/hvm/vmsi.c > > +++ b/xen/arch/x86/hvm/vmsi.c > > @@ -468,7 +468,7 @@ int msixtbl_pt_register(struct domain *d, struct pirq > > *pirq, uint64_t gtable) > > struc

Re: [RFC KERNEL PATCH v4 3/3] PCI/sysfs: Add gsi sysfs for pci_dev

2024-01-23 Thread Bjorn Helgaas
On Tue, Jan 23, 2024 at 10:13:52AM +, Chen, Jiqian wrote: > On 2024/1/23 07:37, Bjorn Helgaas wrote: > > On Fri, Jan 05, 2024 at 02:22:17PM +0800, Jiqian Chen wrote: > >> There is a need for some scenarios to use gsi sysfs. > >> For example, when xen passthrough a device to dumU, it will > >> u

Re: [PATCH v3 27/34] xen/riscv: define an address of frame table

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 12:32 +0100, Jan Beulich wrote: > On 22.12.2023 16:13, Oleksii Kurochko wrote: > > Also, the patch adds some helpful macros that assist in avoiding > > the redefinition of memory layout for each MMU mode. > > > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > >

Re: [PATCH v3 28/34] xen/riscv: add required things to current.h

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 12:35 +0100, Jan Beulich wrote: > On 22.12.2023 16:13, Oleksii Kurochko wrote:> --- > a/xen/arch/riscv/include/asm/current.h > > +++ b/xen/arch/riscv/include/asm/current.h > > @@ -3,6 +3,21 @@ > >  #ifndef __ASM_CURRENT_H > >  #define __ASM_CURRENT_H > >   > > +#include > > +

Re: [PATCH v3 29/34] xen/riscv: add minimal stuff to page.h to build full Xen

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 12:36 +0100, Jan Beulich wrote: > On 22.12.2023 16:13, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich > > --- > > Changes in V3: > >  - update the commit message > > Once again I find this puzzling, considering there's no commit > mess

Re: Sketch of an idea for handling the "mixed workload" problem

2024-01-23 Thread Demi Marie Obenour
On Mon, Jan 22, 2024 at 11:54:14AM +, George Dunlap wrote: > On Mon, Jan 22, 2024 at 12:31 AM Demi Marie Obenour > wrote: > > > > On Fri, Sep 29, 2023 at 05:42:16PM +0100, George Dunlap wrote: > > > The basic credit2 algorithm goes something like this: > > > > > > 1. All vcpus start with the s

Re: [PATCH v3 34/34] xen/README: add compiler and binutils versions for RISC-V64

2024-01-23 Thread Jan Beulich
On 23.01.2024 15:49, Oleksii wrote: > On Tue, 2024-01-23 at 12:22 +0100, Jan Beulich wrote: >> On 22.12.2023 16:13, Oleksii Kurochko wrote: >>> Signed-off-by: Oleksii Kurochko >>> --- >>>  Changes in V3: >>>   - new patch >>> --- >>>  README | 3 +++ >>>  1 file changed, 3 insertions(+) >>> >>> dif

Re: [PATCH v3 30/34] xen/riscv: add minimal stuff to processor.h to build full Xen

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 12:39 +0100, Jan Beulich wrote: > On 22.12.2023 16:13, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > >  - Update the commit message > > ??? (again) The same as with previous. asm/processor.h was changed to processor.h > > > @@ -53

Re: [PATCH v3 31/34] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 14:03 +0100, Jan Beulich wrote: > On 22.12.2023 16:13, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > >  - update the commit message > > ??? (yet again) asm/mm.h was changed to mm.h > > > --- a/xen/arch/riscv/include/asm/mm.h > > ++

Re: [PATCH v3 32/34] xen/rirscv: add minimal amount of stubs to build full Xen

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 14:20 +0100, Jan Beulich wrote: > On 22.12.2023 16:13, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/early_printk.c > > +++ b/xen/arch/riscv/early_printk.c > > @@ -40,171 +40,3 @@ void early_printk(const char *str) > > str++; > > } > >  } > > - > > -/* > > - *

Re: [PATCH v3 34/34] xen/README: add compiler and binutils versions for RISC-V64

2024-01-23 Thread Oleksii
On Tue, 2024-01-23 at 18:05 +0100, Jan Beulich wrote: > On 23.01.2024 15:49, Oleksii wrote: > > On Tue, 2024-01-23 at 12:22 +0100, Jan Beulich wrote: > > > On 22.12.2023 16:13, Oleksii Kurochko wrote: > > > > Signed-off-by: Oleksii Kurochko > > > > --- > > > >  Changes in V3: > > > >   - new patch

[xen-unstable-smoke test] 184436: tolerable all pass - PUSHED

2024-01-23 Thread osstest service owner
flight 184436 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184436/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 184438: all pass - PUSHED

2024-01-23 Thread osstest service owner
flight 184438 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184438/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d97f3a1d80fc4880da9726d9a5d7504d3c31da70 baseline version: ovmf 313f9f01552227138e08a

[PATCH] x86/ucode: Fix stability of the Raw CPU Policy rescan

2024-01-23 Thread Andrew Cooper
Always run microcode_update_helper() on the BSP, so the the updated Raw CPU policy doesn't get non-BSP topology details included. Have calculate_raw_cpu_policy() clear the instantanious XSTATE sizes. The value XCR0 | MSR_XSS had when we scanned the policy isn't terribly interesting to report. Wh

Re: [PATCH 80/82] xen-netback: Refactor intentional wrap-around test

2024-01-23 Thread Kees Cook
On Tue, Jan 23, 2024 at 08:55:44AM +0100, Jan Beulich wrote: > On 23.01.2024 01:27, Kees Cook wrote: > > --- a/drivers/net/xen-netback/hash.c > > +++ b/drivers/net/xen-netback/hash.c > > @@ -345,7 +345,7 @@ u32 xenvif_set_hash_mapping(struct xenvif *vif, u32 > > gref, u32 len, > > .fla

Re: Community Process Group - Proposal

2024-01-23 Thread Stefano Stabellini
On Tue, 23 Jan 2024, Jan Beulich wrote: > On 22.01.2024 23:47, Stefano Stabellini wrote: > > On Mon, 22 Jan 2024, Jan Beulich wrote: > >> What definitely needs clarifying is what "review" is: Are R-b tags > >> counted, or is it the number of replies sent commenting on patches? > > > > Yes, I think

Re: Thoughts on current Xen EDAC/MCE situation

2024-01-23 Thread Elliott Mitchell
On Tue, Jan 23, 2024 at 11:44:03AM +0100, Jan Beulich wrote: > On 22.01.2024 21:53, Elliott Mitchell wrote: > > > I find the present handling of MCE in Xen an odd choice. Having Xen do > > most of the handling of MCE events is a behavior matching a traditional > > stand-alone hypervisor. Yet Xen

[xen-unstable-smoke test] 184440: tolerable all pass - PUSHED

2024-01-23 Thread osstest service owner
flight 184440 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184440/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 184441: all pass - PUSHED

2024-01-23 Thread osstest service owner
flight 184441 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184441/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 417ebe6d1d6052b6cf023332da07558363d7fd08 baseline version: ovmf d97f3a1d80fc4880da972

Re: [PATCH] xen: Drop out of coroutine context xen_invalidate_map_cache_entry

2024-01-23 Thread Stefano Stabellini
On Tue, 16 Jan 2024, Peng Fan (OSS) wrote: > From: Peng Fan > > xen_invalidate_map_cache_entry is not expected to run in a > coroutine. Without this, there is crash: > > signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44 > threadid=) at pthread_kill.c:78 > at /usr/src/d

Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op

2024-01-23 Thread Stefano Stabellini
On Sun, 14 Jan 2024, Mykyta Poturai wrote: > Add the second version of inject_msi DM op, which allows to specify > the source_id of an MSI interrupt. This is needed for correct MSI > injection on ARM. > > It would not be safe to include the source_id in the original inject_msi > in the pad field,

Re: [PATCH 1/2] arm: vgic: Add the ability to trigger MSIs from the Hypervisor

2024-01-23 Thread Stefano Stabellini
On Sun, 14 Jan 2024, Mykyta Poturai wrote: > Add the vgic_its_trigger_msi() function to the vgic interface. This > function allows to inject MSIs from the Hypervisor to the guest. > Which is useful for userspace PCI backend drivers. > > Signed-off-by: Mykyta Poturai > --- > xen/arch/arm/include/

[PATCH V2] xen: Drop out of coroutine context xen_invalidate_map_cache_entry

2024-01-23 Thread Peng Fan (OSS)
From: Peng Fan xen_invalidate_map_cache_entry is not expected to run in a coroutine. Without this, there is crash: signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44 threadid=) at pthread_kill.c:78 at /usr/src/debug/glibc/2.38+git-r0/sysdeps/posix/raise.c:26 fmt=0xf

Re: [PATCH V2] xen: Drop out of coroutine context xen_invalidate_map_cache_entry

2024-01-23 Thread Stefano Stabellini
On Wed, 24 Jan 2024, Peng Fan (OSS) wrote: > From: Peng Fan > > xen_invalidate_map_cache_entry is not expected to run in a > coroutine. Without this, there is crash: > > signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44 > threadid=) at pthread_kill.c:78 > at /usr/src/d

[linux-linus test] 184432: tolerable FAIL - PUSHED

2024-01-23 Thread osstest service owner
flight 184432 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184432/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184427 test-amd64-amd64-xl-qemut-win7-amd64

Re: ACPI VFCT table too short on PVH dom0 (was: Re: E820 memory allocation issue on Threadripper platforms)

2024-01-23 Thread Patrick Plenefisch
On Sat, Jan 20, 2024 at 8:33 PM Patrick Plenefisch wrote: > > > On Fri, Jan 19, 2024 at 6:06 AM Roger Pau Monné > wrote: > >> On Fri, Jan 19, 2024 at 02:44:35AM -0500, Patrick Plenefisch wrote: >> > On Thu, Jan 18, 2024 at 7:41 AM Roger Pau Monné >> > wrote: >> > >> > > >> > > From that environ

Re: [PATCH] consolidate do_bug_frame() / bug_fn_t

2024-01-23 Thread Stefano Stabellini
Hi Jan, Andrew, I managed to get back to read the mailing list and noticed this patch. Is it still relevant and needs to be reviewed? Are there any outstanding disagreements between maintainers on the approach to take here? Or should I just go ahead and review it? On Tue, 9 Jan 2024, Jan Beul

[ovmf test] 184442: all pass - PUSHED

2024-01-23 Thread osstest service owner
flight 184442 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184442/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7f72c2829fa29d2b4451c9a60e904df4c6a5df6c baseline version: ovmf 417ebe6d1d6052b6cf023

[ovmf test] 184444: all pass - PUSHED

2024-01-23 Thread osstest service owner
flight 18 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/18/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1063665fa5466ece0814a3e764ee3382656956a1 baseline version: ovmf 7f72c2829fa29d2b4451c

Re: [PATCH v12.2 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-23 Thread Stewart Hildebrand
On 1/23/24 10:07, Roger Pau Monné wrote: > On Tue, Jan 23, 2024 at 03:32:12PM +0100, Jan Beulich wrote: >> On 15.01.2024 20:43, Stewart Hildebrand wrote: >>> @@ -2888,6 +2888,8 @@ int allocate_and_map_msi_pirq(struct domain *d, int >>> index, int *pirq_p, >>> { >>> int irq, pirq, ret; >>>

Re: [PATCH v12.2 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-23 Thread Stewart Hildebrand
On 1/23/24 09:29, Jan Beulich wrote: > On 15.01.2024 20:43, Stewart Hildebrand wrote: >> @@ -1043,11 +1043,11 @@ static int __pci_enable_msix(struct pci_dev *pdev, >> struct msi_info *msi, >> { >> struct msi_desc *old_desc; >> >> -ASSERT(pcidevs_locked()); >> - >> if ( !pdev || !p

Re: Thoughts on current Xen EDAC/MCE situation

2024-01-23 Thread Jan Beulich
On 23.01.2024 23:52, Elliott Mitchell wrote: > On Tue, Jan 23, 2024 at 11:44:03AM +0100, Jan Beulich wrote: >> On 22.01.2024 21:53, Elliott Mitchell wrote: >> >>> I find the present handling of MCE in Xen an odd choice. Having Xen do >>> most of the handling of MCE events is a behavior matching a

Re: [PATCH] consolidate do_bug_frame() / bug_fn_t

2024-01-23 Thread Jan Beulich
On 24.01.2024 02:34, Stefano Stabellini wrote: > I managed to get back to read the mailing list and noticed this patch. > > Is it still relevant and needs to be reviewed? > > Are there any outstanding disagreements between maintainers on the > approach to take here? Or should I just go ahead and