Re: [PATCH v2 05/15] x86: amend cpu_has_xen_[ibt,shstk}

On 24.11.2023 14:52, Andrew Cooper wrote: > In the subject, [ -> { > > ? Right, noticed (sadly) just after sending, and already corrected locally. > On 24/11/2023 8:38 am, Jan Beulich wrote: >> ... to evaluate to false at compile-time when the respective Kconfig >> control is off, thus allowing

Re: [PATCH v2 06/15] x86/HVM: improve CET-IBT pruning of ENDBR

On 24.11.2023 23:28, Andrew Cooper wrote: > On 24/11/2023 8:39 am, Jan Beulich wrote: >> __init{const,data}_cf_clobber can have an effect only for pointers >> actually populated in the respective tables. While not the case for SVM >> right now, VMX installs a number of pointers only under certain >

Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

On Fri, Nov 24, 2023 at 05:15:34PM -0800, Elliott Mitchell wrote: > On Thu, Nov 23, 2023 at 10:39:37AM +0100, Roger Pau Monné wrote: > > On Tue, Nov 21, 2023 at 04:56:47PM -0800, Elliott Mitchell wrote: > > > It was insisted that full logs be sent to xen-devel. Perhaps I am > > > paranoid, but I d

Re: [EXTERNAL] [PATCH v3 2/5] xen: backends: don't overwrite XenStore nodes created by toolstack

On Fri, 2023-11-24 at 23:24 +, Volodymyr Babchuk wrote: > Xen PV devices in QEMU can be created in two ways: either by QEMU > itself, if they were passed via command line, or by Xen toolstack. In > the latter case, QEMU scans XenStore entries and configures devices > accordingly. > > In the se

Re: [PATCH v4] xen/x86: On x2APIC mode, derive LDR from APIC ID

On 23.11.2023 18:30, Alejandro Vallejo wrote: > @@ -1498,27 +1511,36 @@ static int cf_check lapic_save_regs(struct vcpu *v, > hvm_domain_context_t *h) > */ > static void lapic_load_fixup(struct vlapic *vlapic) > { > -uint32_t id = vlapic->loaded.id; > +uint32_t good_ldr = x2apic_ldr_fr

Re: [RFC PATCH v3 3/5] xen: add option to disable legacy backends

On Fri, 2023-11-24 at 23:24 +, Volodymyr Babchuk wrote: > This patch makes legacy backends optional. As was discussed at [1] > this is a solution to a problem when we can't run QEMU as a device > model in a non-privileged domain. This is because legacy backends > assume that they are always run

Re: [RFC PATCH v3 3/5] xen: add option to disable legacy backends

Hi David, "Woodhouse, David" writes: > [[S/MIME Signed Part:Undecided]] > On Fri, 2023-11-24 at 23:24 +, Volodymyr Babchuk wrote: >> This patch makes legacy backends optional. As was discussed at [1] >> this is a solution to a problem when we can't run QEMU as a device >> model in a non-pr

[PATCH v3 00/32] Mini-OS: hide mini-os internal symbols

In order to avoid conflicts due to symbols with the same name when linking Mini-OS with an application, hide all Mini9-OS internal symbols from the application by linking the Mini-OS kernel individually and then removing all symbols which should be used internally only. Changes in V2: - added more

[PATCH v3 02/32] Mini-OS: explicitly mark symbols to be visible for apps

Add an EXPORT_SYMBOL() macro to explicitly mark a symbol to be visible for an app or library linked with Mini-OS. This prepares hiding all other symbols from external components, avoiding any problems with duplicate symbol names. Signed-off-by: Juergen Gross --- V3: - new patch --- .gitignore

[PATCH v3 04/32] Mini-OS: add EXPORT_SYMBOL() instances to hypervisor.c

Add the needed instances of EXPORT_SYMBOL() to hypervisor.c. Signed-off-by: Juergen Gross --- V3: - new patch --- hypervisor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hypervisor.c b/hypervisor.c index d3857e70..f2cbbc1c 100644 --- a/hypervisor.c +++ b/hypervisor.c @@ -31,6 +31,8

[PATCH v3 01/32] Mini-OS: link kernel separately

Add an additional link step with linking all Mini-OS kernel binaries into a single object file. This is done in preparation of hiding Mini-OS internal symbols before linking the kernel with libraries and an application. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- Makefile | 7

[PATCH v3 03/32] Mini-OS: add EXPORT_SYMBOL() instances to kernel.c

Add the needed instances of EXPORT_SYMBOL() to kernel.c. Signed-off-by: Juergen Gross --- V3: - new patch --- kernel.c | 5 + 1 file changed, 5 insertions(+) diff --git a/kernel.c b/kernel.c index 1f97d8dd..0b444940 100644 --- a/kernel.c +++ b/kernel.c @@ -50,6 +50,9 @@ #include #include

[PATCH v3 05/32] Mini-OS: add EXPORT_SYMBOL() instances to sched.c

Add the needed instances of EXPORT_SYMBOL() to sched.c. Signed-off-by: Juergen Gross --- V3: - new patch --- arch/x86/sched.c | 5 + sched.c | 7 +++ 2 files changed, 12 insertions(+) diff --git a/arch/x86/sched.c b/arch/x86/sched.c index e7b6954e..dabe6fd6 100644 --- a/arch/x8

[PATCH v3 20/32] Mini-OS: add EXPORT_SYMBOL() instances to lock.c

Add the needed instances of EXPORT_SYMBOL() to lock.c. Signed-off-by: Juergen Gross --- V3: - new patch --- lock.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lock.c b/lock.c index 61194e5d..8f58344f 100644 --- a/lock.c +++ b/lock.c @@ -17,6 +17,7 @@ int ___lock_i

[PATCH v3 19/32] Mini-OS: add EXPORT_SYMBOL() instances to ioremap.c

Add the needed instances of EXPORT_SYMBOL() to ioremap.c. Signed-off-by: Juergen Gross --- V3: - new patch --- arch/x86/ioremap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/ioremap.c b/arch/x86/ioremap.c index 4384b1c0..fda74d5d 100644 --- a/arch/x86/iorema

[PATCH v3 21/32] Mini-OS: add EXPORT_SYMBOL() instances to time.c

Add the needed instances of EXPORT_SYMBOL() to time.c. Signed-off-by: Juergen Gross --- V3: - new patch --- arch/arm/time.c | 1 + arch/x86/time.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/time.c b/arch/arm/time.c index a088981e..3483511a 100644 --- a/arch/ar

[PATCH v3 24/32] Mini-OS: add EXPORT_SYMBOL() instances to blkfront.c

Add the needed instances of EXPORT_SYMBOL() to blkfront.c. Signed-off-by: Juergen Gross --- V3: - new patch --- blkfront.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/blkfront.c b/blkfront.c index 8f140896..b0fc80d1 100644 --- a/blkfront.c +++ b/blkfront.c @@

[PATCH v3 30/32] Mini-OS: add EXPORT_SYMBOL() instances to tpm_tis.c

Add the needed instances of EXPORT_SYMBOL() to tpm_tis.c. Signed-off-by: Juergen Gross --- V3: - new patch --- tpm_tis.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tpm_tis.c b/tpm_tis.c index c3998f2d..ad95e289 100644 --- a/tpm_tis.c +++ b/tpm_tis.c @@ -673,6 +673,7 @@ int tpm_tis_

[PATCH v3 11/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/ctype.c

Add the needed instances of EXPORT_SYMBOL() to lib/ctype.c. Signed-off-by: Juergen Gross --- V3: - new patch --- lib/ctype.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ctype.c b/lib/ctype.c index 3f3bdb00..309ebbc9 100644 --- a/lib/ctype.c +++ b/lib/ctype.c @@ -1,5 +1,6 @@ #ifnde

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

+(xen-devel and Arm maintainers, including Julien) > On Nov 27, 2023, at 18:03, Mario Marietto wrote: > > Hello. > We have just virtualized Debian 12 on our arm (32 bit) Chromebook model > xe303c12 . As host / dom0 we have chosen Devuan 5,and for guest / domU,Debian > 12. It works great. But o

[PATCH v3 13/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/xs.c

Add the needed instances of EXPORT_SYMBOL() to lib/xs.c. Signed-off-by: Juergen Gross --- V3: - new patch --- lib/xs.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/xs.c b/lib/xs.c index 7fe9b03e..ff0768c1 100644 --- a/lib/xs.c +++ b/lib/xs.c @@ -64,6 +64,7 @@ struct xs_han

[PATCH v3 25/32] Mini-OS: add EXPORT_SYMBOL() instances to fbfront.c

Add the needed instances of EXPORT_SYMBOL() to fbfront.c. Signed-off-by: Juergen Gross --- V3: - new patch --- fbfront.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fbfront.c b/fbfront.c index 1b67f527..d4e28d0c 100644 --- a/fbfront.c +++ b/fbfront.c @@ -201,6

[PATCH v3 07/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/sys.c

Add the needed instances of EXPORT_SYMBOL() to lib/sys.c. Signed-off-by: Juergen Gross --- V3: - new patch --- lib/sys.c | 92 --- 1 file changed, 87 insertions(+), 5 deletions(-) diff --git a/lib/sys.c b/lib/sys.c index 118fc441..481067f7 100

[PATCH v3 12/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/xmalloc.c

Add the needed instances of EXPORT_SYMBOL() to lib/xmalloc.c. Signed-off-by: Juergen Gross --- V3: - new patch --- lib/xmalloc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/xmalloc.c b/lib/xmalloc.c index e16f161a..cc5db11e 100644 --- a/lib/xmalloc.c +++ b/lib/xmalloc.c @@ -271,6

[PATCH v3 14/32] Mini-OS: add EXPORT_SYMBOL() instances to main.c

Add the needed instances of EXPORT_SYMBOL() to main.c. Signed-off-by: Juergen Gross --- V3: - new patch --- main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/main.c b/main.c index a93bc9d6..c5c1c420 100644 --- a/main.c +++ b/main.c @@ -38,10 +38,12 @@ int main(int argc, char *argv[],

Re: [PATCH v2] xen: remove

Hello Shawn, Could you kindly review the patch when you have a moment? It can help with merging other patch series. Thanks in advance. ~ Oleksii On Tue, 2023-10-31 at 16:28 +0200, Oleksii Kurochko wrote: > only declares udelay() function so udelay() > declaration was moved to xen/delay.h. > >

[PATCH v3 06/32] Mini-OS: add EXPORT_SYMBOL() instances to mm.c

Add the needed instances of EXPORT_SYMBOL() to mm.c. Signed-off-by: Juergen Gross --- V3: - new patch --- arch/arm/mm.c | 2 ++ arch/x86/mm.c | 5 + mm.c | 4 3 files changed, 11 insertions(+) diff --git a/arch/arm/mm.c b/arch/arm/mm.c index 11962f8b..c269ab14 100644 --- a/arc

[PATCH v3 09/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/math.c

Add the needed instances of EXPORT_SYMBOL() to lib/math.c. Signed-off-by: Juergen Gross --- V3: - new patch --- lib/math.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/math.c b/lib/math.c index b98cc1d2..9ee9fcdb 100644 --- a/lib/math.c +++ b/lib/math.c @@ -338,6 +338,7 @@ __qdi

[PATCH v3 26/32] Mini-OS: add EXPORT_SYMBOL() instances to netfront.c

Add the needed instances of EXPORT_SYMBOL() to netfront.c. Signed-off-by: Juergen Gross --- V3: - new patch --- netfront.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/netfront.c b/netfront.c index 164fdc66..7de2498a 100644 --- a/netfront.c +++ b/netfront.c @@ -370,16 +370,19 @@ ou

[PATCH v3 18/32] Mini-OS: add EXPORT_SYMBOL() instances to gnttab.c

Add the needed instances of EXPORT_SYMBOL() to gnttab.c. Signed-off-by: Juergen Gross --- V3: - new patch --- gnttab.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/gnttab.c b/gnttab.c index 6978a9bc..8168ed5d 100644 --- a/gnttab.c +++ b/gnttab.c @@ -80,6 +80,7 @@ gnttab_grant_access

[PATCH v3 15/32] Mini-OS: add EXPORT_SYMBOL() instances to console.c

Add the needed instances of EXPORT_SYMBOL() to console.c. Signed-off-by: Juergen Gross --- V3: - new patch --- console.c | 5 + 1 file changed, 5 insertions(+) diff --git a/console.c b/console.c index 5d205c7d..0107b685 100644 --- a/console.c +++ b/console.c @@ -125,6 +125,7 @@ void console

[PATCH v3 10/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/printf.c

Add the needed instances of EXPORT_SYMBOL() to lib/printf.c. Signed-off-by: Juergen Gross --- V3: - new patch --- lib/printf.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/printf.c b/lib/printf.c index f9e9d682..0e054957 100644 --- a/lib/printf.c +++ b/lib/pr

[PATCH v3 29/32] Mini-OS: add EXPORT_SYMBOL() instances to tpmfront.c

Add the needed instances of EXPORT_SYMBOL() to tpmfront.c. Signed-off-by: Juergen Gross --- V3: - new patch --- tpmfront.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tpmfront.c b/tpmfront.c index f4864d61..83768d07 100644 --- a/tpmfront.c +++ b/tpmfront.c @@ -338,6 +338,8 @@ error

[PATCH v3 32/32] Mini-OS: hide all symbols not exported via EXPORT_SYMBOLS()

When doing the final linking of the Mini-OS kernel only keep the symbols visible which have been marked via EXPORT_SYMBOL(). Signed-off-by: Juergen Gross --- V3: - new patch --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 588496cb..456aed0b 100644 --- a

[PATCH v3 16/32] Mini-OS: add EXPORT_SYMBOL() instances to events.c

Add the needed instances of EXPORT_SYMBOL() to events.c. Signed-off-by: Juergen Gross --- V3: - new patch --- events.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/events.c b/events.c index 4683e8e1..9f3dbf05 100644 --- a/events.c +++ b/events.c @@ -119,6 +119,7 @@ void unbind_evtc

[PATCH v3 31/32] Mini-OS: add EXPORT_SYMBOL() instances to xenbus.c

Add the needed instances of EXPORT_SYMBOL() to xenbus.c. Signed-off-by: Juergen Gross --- V3: - new patch --- xenbus.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/xenbus.c b/xenbus.c index 8bfd5bd4..eb9af055 100644 --- a/xenbus.c +++ b/xenbus.c @@ -123,6 +123,7 @

[PATCH v3 23/32] Mini-OS: add EXPORT_SYMBOL() instances to 9pfront.c

Add the needed instances of EXPORT_SYMBOL() to 9pfront.c. Signed-off-by: Juergen Gross --- V3: - new patch --- 9pfront.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/9pfront.c b/9pfront.c index 35c5552b..315089bc 100644 --- a/9pfront.c +++ b/9pfront.c @@ -1243,6 +1243,7 @@ void *init_9p

[PATCH v3 08/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/string.c

Add the needed instances of EXPORT_SYMBOL() to lib/string.c. Signed-off-by: Juergen Gross --- V3: - new patch --- lib/string.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/string.c b/lib/string.c index 8b241464..b0b628c6 100644 --- a/lib/string.c +++ b/lib/string.c

[PATCH v3 22/32] Mini-OS: add EXPORT_SYMBOL() instances to lwip-*.c

Add the needed instances of EXPORT_SYMBOL() to lwip-*.c. Most added symbols are in LWIP, but we can't add the EXPORT_SYMBOL() instances easily there. Signed-off-by: Juergen Gross --- V3: - new patch --- lwip-arch.c | 9 + lwip-net.c | 2 +- 2 files changed, 10 insertions(+), 1 deletion

[PATCH v3 17/32] Mini-OS: add EXPORT_SYMBOL() instances to gntmap.c

Add the needed instances of EXPORT_SYMBOL() to gntmap.c. Signed-off-by: Juergen Gross --- V3: - new patch --- gntmap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/gntmap.c b/gntmap.c index 3422ab23..5f57d6b3 100644 --- a/gntmap.c +++ b/gntmap.c @@ -106,6 +106,7 @@ gntmap_set_max_gra

[PATCH v3 27/32] Mini-OS: add EXPORT_SYMBOL() instances to pcifront.c

Add the needed instances of EXPORT_SYMBOL() to pcifront.c. Signed-off-by: Juergen Gross --- V3: - new patch --- pcifront.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/pcifront.c b/pcifront.c index 56423562..f1d69396 100644 --- a/pcifront.c +++ b/pcifront.c @@

[PATCH v3 28/32] Mini-OS: add EXPORT_SYMBOL() instances to tpmback.c

Add the needed instances of EXPORT_SYMBOL() to tpmback.c. Signed-off-by: Juergen Gross --- V3: - new patch --- tpmback.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tpmback.c b/tpmback.c index 22adbd32..ab0df127 100644 --- a/tpmback.c +++ b/tpmback.c @@ -804,6 +804,7 @@ void

Re: [XEN PATCH v2 2/3] xen/arm: add SAF deviation for debugging and logging effects

On 24.11.2023 18:29, Simone Ballarin wrote: > Rule 13.1: Initializer lists shall not contain persistent side effects > > Effects caused by debug/logging macros and functions (like ASSERT, > __bad_atomic_size, > LOG, etc ...) that crash execution or produce logs are not dangerous in > initializer

Re: [XEN PATCH v2 3/3] xen: address violations of MISRA C:2012 Rule 13.1

On 24.11.2023 18:29, Simone Ballarin wrote: > Rule 13.1: Initializer lists shall not contain persistent side effects > > The assignment operation in: > > .irq = rc = uart->irq, > > is a persistent side effect in a struct initializer list. > > This patch avoids rc assignment and directly uses ua

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

On Mon, Nov 27, 2023 at 10:28:13AM +, Henry Wang wrote: > +(xen-devel and Arm maintainers, including Julien) > > > On Nov 27, 2023, at 18:03, Mario Marietto > > wrote: > > > > Hello. We have just virtualized Debian 12 on our arm (32 bit) > > Chromebook model xe303c12 . As host / dom0 we hav

Re: [PATCH v3 11/14] xen/asm-generic: introduce stub header numa.h

Hello Michal, On Fri, 2023-11-24 at 14:03 +0100, Michal Orzel wrote: > > On 17/11/2023 13:24, Oleksii Kurochko wrote: > > > > > > is common through some archs so it is moved > > to asm-generic. > > > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > >  - Remove old header inclus

Re: [Xen-devel] PV guest with PCI passthrough crash on Xen 4.8.3 inside KVM when booted through OVMF

On Mon, Nov 27, 2023 at 11:20:36AM +, Frediano Ziglio wrote: > On Sun, Nov 26, 2023 at 2:51 PM Marek Marczykowski-Górecki > wrote: > > > > On Mon, Feb 19, 2018 at 06:30:14PM +0100, Juergen Gross wrote: > > > On 16/02/18 20:02, Andrew Cooper wrote: > > > > On 16/02/18 18:51, Marek Marczykowski-

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

On Fri, 2023-11-24 at 14:18 +0100, Jan Beulich wrote: > On 24.11.2023 14:00, Michal Orzel wrote: > > On 17/11/2023 13:24, Oleksii Kurochko wrote: > > > --- a/xen/arch/arm/include/asm/altp2m.h > > > +++ /dev/null > > > @@ -1,39 +0,0 @@ > > > -/* > > > - * Alternate p2m > > > - * > > > - * Copyright

Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

On 24/11/2023 7:54 pm, Neowutran wrote: > Hi, > I did some more tests and research, indeed this patch improved/solved my > specific case. > > Starting point: > > I am using Xen version 4.17.2 (exactly this source > https://github.com/QubesOS/qubes-vmm-xen). > In the bios (a Asus motherboard),

[xen-unstable test] 183866: trouble: blocked/broken

flight 183866 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183866/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-prev

Re: [PATCH v2 2/2] Mini-OS: keep a positive list of externally visible symbols

On 23/11/2023 11:45 am, Juergen Gross wrote: > diff --git a/mini-os.map b/mini-os.map > new file mode 100644 > index ..58a3a0ee > --- /dev/null > +++ b/mini-os.map > @@ -0,0 +1,295 @@ > +# Mini-OS symbols being externally visible \n > +# entry point > +_start \n etc.  A few blank lines

Re: [PATCH v4] xen/x86: On x2APIC mode, derive LDR from APIC ID

On 24/11/2023 22:05, Andrew Cooper wrote: diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 5cb87f8649..cd4701c5a2 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1061,13 +1061,26 @@ static const struct hvm_mmio_ops vlapic_mmio_ops = { .writ

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

On 27.11.2023 12:48, Oleksii wrote: > On Fri, 2023-11-24 at 14:18 +0100, Jan Beulich wrote: >> On 24.11.2023 14:00, Michal Orzel wrote: >>> On 17/11/2023 13:24, Oleksii Kurochko wrote: --- a/xen/arch/arm/include/asm/altp2m.h +++ /dev/null @@ -1,39 +0,0 @@ -/* - * Alternate

Re: [PATCH v2 2/2] Mini-OS: keep a positive list of externally visible symbols

On 27.11.23 13:07, Andrew Cooper wrote: On 23/11/2023 11:45 am, Juergen Gross wrote: diff --git a/mini-os.map b/mini-os.map new file mode 100644 index ..58a3a0ee --- /dev/null +++ b/mini-os.map @@ -0,0 +1,295 @@ +# Mini-OS symbols being externally visible \n +# entry point +_start

Re: [PATCH v4] xen/x86: On x2APIC mode, derive LDR from APIC ID

On 27/11/2023 08:40, Jan Beulich wrote: On 23.11.2023 18:30, Alejandro Vallejo wrote: @@ -1498,27 +1511,36 @@ static int cf_check lapic_save_regs(struct vcpu *v, hvm_domain_context_t *h) */ static void lapic_load_fixup(struct vlapic *vlapic) { -uint32_t id = vlapic->loaded.id; +u

Re: Clang-format configuration discussion - pt 2

On 24.11.2023 15:52, Luca Fancellu wrote: >> On 24 Nov 2023, at 12:47, Jan Beulich wrote: >> On 23.11.2023 15:47, Luca Fancellu wrote: >>> Let’s continue the discussion about clang-format configuration, this is >>> part 2, previous discussions are: >>> >>> - https://lists.xenproject.org/archives/

Re: [PATCH v4] xen/x86: On x2APIC mode, derive LDR from APIC ID

On 27/11/2023 12:08 pm, Alejandro Vallejo wrote: > On 24/11/2023 22:05, Andrew Cooper wrote: >>> diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c >>> index 5cb87f8649..cd4701c5a2 100644 >>> --- a/xen/arch/x86/hvm/vlapic.c >>> +++ b/xen/arch/x86/hvm/vlapic.c >>> @@ -1061,13 +1061,2

Re: [PATCH v4] xen/x86: On x2APIC mode, derive LDR from APIC ID

On 27.11.2023 13:17, Alejandro Vallejo wrote: > On 27/11/2023 08:40, Jan Beulich wrote: >> On 23.11.2023 18:30, Alejandro Vallejo wrote: >>> @@ -1498,27 +1511,36 @@ static int cf_check lapic_save_regs(struct vcpu *v, >>> hvm_domain_context_t *h) >>>*/ >>> static void lapic_load_fixup(struct

Re: [PATCH v2 08/15] VMX: convert vmx_basic_msr

On 24.11.2023 23:41, Andrew Cooper wrote: > On 24/11/2023 8:41 am, Jan Beulich wrote: >> ... to a struct field, which is then going to be accompanied by other >> capability/control data presently living in individual variables. As >> this structure isn't supposed to be altered post-boot, put it in

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

@Chuck Zmudzinski : Stay tuned. They want to help us. The xen developers are great. Very good support for us. I'm sure that you can give a good contribution to understand what's our problem and how to implement a fix with the help of all those good guys. On Mon, Nov 27, 2023 at 11:56 AM Roger Pau

[PATCH] xen/events: fix error codes in xen_bind_pirq_msi_to_irq()

The error code needs to be set on these error paths. Fixes: 5dd9ad32d775 ("xen/events: drop xen_allocate_irqs_dynamic()") Fixes: d2ba3166f23b ("xen/events: move drivers/xen/events.c into drivers/xen/events/") Signed-off-by: Dan Carpenter --- Are we going to backport these to stable? Should I sp

Re: [PATCH block/for-next v2 01/16] block: add a new helper to get inode from block_device

Hi, 在 2023/11/27 15:21, Christoph Hellwig 写道: On Mon, Nov 27, 2023 at 02:21:01PM +0800, Yu Kuai wrote: From: Yu Kuai block_devcie is allocated from bdev_alloc() by bdev_alloc_inode(), and currently block_device contains a pointer that point to the address of inode, while such inode is allocat

Re: [PATCH] xen/events: fix error codes in xen_bind_pirq_msi_to_irq()

On 27.11.23 13:57, Dan Carpenter wrote: The error code needs to be set on these error paths. Fixes: 5dd9ad32d775 ("xen/events: drop xen_allocate_irqs_dynamic()") Fixes: d2ba3166f23b ("xen/events: move drivers/xen/events.c into drivers/xen/events/") Please drop the last Fixes: tag. Said patch

Re: [XEN PATCH v4 1/2] x86/mm: preparation work to uniform modify_xen_mappings* interfaces

On 22.11.2023 23:20, Stefano Stabellini wrote: > On Wed, 22 Nov 2023, Federico Serafini wrote: >> The objective is to use parameter name "nf" to denote "new flags" >> in all the modify_xen_mappings* functions. >> Since modify_xen_mappings_lite() is currently using "nf" as identifier >> for a local

Re: [XEN PATCH v4 2/2] xen/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3

On 22.11.2023 23:22, Stefano Stabellini wrote: > On Wed, 22 Nov 2023, Federico Serafini wrote: >> Add missing parameter names and uniform the interfaces of >> modify_xen_mappings() and modify_xen_mappings_lite(). >> >> No functional change. >> >> Signed-off-by: Federico Serafini > > Reviewed-by:

Re: [PATCH v4] xen/x86: On x2APIC mode, derive LDR from APIC ID

On 27/11/2023 12:20, Andrew Cooper wrote: > On 27/11/2023 12:08 pm, Alejandro Vallejo wrote: >> On 24/11/2023 22:05, Andrew Cooper wrote: diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 5cb87f8649..cd4701c5a2 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/

Re: [PATCH v4] xen/x86: On x2APIC mode, derive LDR from APIC ID

On 27/11/2023 12:24, Jan Beulich wrote: > On 27.11.2023 13:17, Alejandro Vallejo wrote: >> On 27/11/2023 08:40, Jan Beulich wrote: >>> On 23.11.2023 18:30, Alejandro Vallejo wrote: @@ -1498,27 +1511,36 @@ static int cf_check lapic_save_regs(struct vcpu *v, hvm_domain_context_t *h)

[ovmf test] 183867: trouble: blocked/broken

flight 183867 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183867/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

[PATCH v5] xen/x86: On x2APIC mode, derive LDR from APIC ID

Both Intel and AMD manuals agree that on x2APIC mode, the APIC LDR and ID registers are derivable from each other through a fixed formula. Xen uses that formula, but applies it to vCPU IDs (which are sequential) rather than x2APIC IDs (which are not, at the moment). As I understand it, this is an

Re: [PATCH] xen/events: fix error codes in xen_bind_pirq_msi_to_irq()

On Mon, Nov 27, 2023 at 02:17:05PM +0100, Juergen Gross wrote: > On 27.11.23 13:57, Dan Carpenter wrote: > > The error code needs to be set on these error paths. > > > > Fixes: 5dd9ad32d775 ("xen/events: drop xen_allocate_irqs_dynamic()") > > Fixes: d2ba3166f23b ("xen/events: move drivers/xen/even

Re: [PATCH v5] xen/x86: On x2APIC mode, derive LDR from APIC ID

On 27/11/2023 13:46, Alejandro Vallejo wrote: > Both Intel and AMD manuals agree that on x2APIC mode, the APIC LDR and ID > registers are derivable from each other through a fixed formula. > > Xen uses that formula, but applies it to vCPU IDs (which are sequential) > rather than x2APIC IDs (which

[PATCH] Argo: drop meaningless mfn_valid() check

Holding a valid struct page_info * in hands already means the referenced MFN is valid; there's no need to check that again. Convert the checking logic to a switch(), to help keeping the extra (and questionable) x86- only check in somewhat tidy shape. Signed-off-by: Jan Beulich --- Initially I had

Re: [PATCH v5] xen/x86: On x2APIC mode, derive LDR from APIC ID

On 27.11.2023 14:49, Alejandro Vallejo wrote: > On 27/11/2023 13:46, Alejandro Vallejo wrote: >> Both Intel and AMD manuals agree that on x2APIC mode, the APIC LDR and ID >> registers are derivable from each other through a fixed formula. >> >> Xen uses that formula, but applies it to vCPU IDs (whi

[PATCH v4 00/14] Introduce generic headers

Some headers are common between several architectures, so the current patch series provide them. Another one reason to have them as generic is a simplification of adding support necessary to make a complete Xen build as it was/is being done in the patch series [1] and [2]. Also, instead of prov

[PATCH v4 06/14] xen/asm-generic: introduce generic header percpu.h

The patch introduces generic percpu.h which was based on Arm's version with the following changes: * makes __per_cpu_data_end[] constant * introduce get_per_cpu_offset() for macros this_cpu() and this_cpu_ptr() * add inclustion of as get_per_cpu_offset() is located there. Also it was changed a

[PATCH v4 04/14] xen/asm-generic: introduce generic header iocap.h

iocap.h is common for Arm, PPC and RISC-V architectures thereby it was moved to asm-generic. Also Arm and PPC were switched to asm-generic version of iocap.h. Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich Acked-by: Julien Grall --- Changes in V4: - Added Reviewed-by: Jan Beu

[PATCH v4 01/14] xen/asm-generic: introduce stub header paging.h

The patch introduces generic paging.h header for Arm, PPC and RISC-V. All mentioned above architectures use hardware virt extensions and hardware pagetable extensions thereby it makes sense to set paging_mode_translate and paging_mode_external by default. Also in this patch Arm and PPC architectu

[PATCH v4 08/14] xen/asm-generic: introduce generic div64.h header

All archs have the do_div implementation for BITS_PER_LONG == 64 so do_div64.h is moved to asm-generic. x86 and PPC were switched to asm-generic version of div64.h. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V4: - Added Acked-by: Jan Beulich . - include in Arm's div

[PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

is common between Arm, PPC and RISC-V so it is moved to asm-generic. Drop Arm and PPC's softirq.h and use asm-generic version instead. Signed-off-by: Oleksii Kurochko Reviewed-by: Michal Orzel Added Acked-by: Jan Beulich --- Changes in V4: - Added Reviewed-by: Michal Orzel - Added Acked-by

[PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

The header is shared between several archs so it is moved to asm-generic. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich . --- Changes in V4: - Removed the double blank line. - Added Acked-by: Jan Beulich . - Update the commit message --- Changes in V3: - Use forward-declaration of str

[PATCH v4 03/14] xen/asm-generic: introduce generic hypercall.h

Introduce an empty generic hypercall.h for archs which don't implement it. Drop PPC's hypercall.h and switch to generic one instead. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V4: - Nothing changed. Only rebase. --- Changes in V3: - Drop PPC's hypercall.h and switch

[PATCH v4 02/14] xen/asm-generic: introduce generic device.h

Arm, PPC and RISC-V use the same device.h thereby device.h was moved to asm-generic. Arm's device.h was taken as a base with the following changes: - #ifdef PCI related things. - #ifdef ACPI related things. - Rename #ifdef guards. - Add SPDX tag. - #ifdef CONFIG_HAS_DEVICE_TREE related things.

[PATCH v4 14/14] xen/asm-generic: ifdef inclusion of

ifdefing inclusion of in allows to avoid generation of empty header for the case when !CONFIG_MEM_ACCESS. For Arm it was explicitly added inclusion of for p2m.c and traps.c because they require some functions from which aren't available in case of !CONFIG_MEM_ACCESS. Suggested-by: Jan Beulic

[PATCH v4 11/14] xen/asm-generic: introduce stub header numa.h

is common through some archs so it is moved to asm-generic. Signed-off-by: Oleksii Kurochko Reviewed-by: Michal Orzel --- Changes in V4: - Updated guards name: *ARCH_GENERIC* -> *ASM_GENERIC*. - Moved inclusion of xen/mm-frame.h under "#ifndef CONFIG_NUMA". - Added Reviewed-by: Michal Orzel

[PATCH v4 09/14] xen/asm-generic: introduce generic header altp2m.h

is common between several archs so it is moved to asm-generic. Arm and PPC were switched to asm-generic version of altp2m.h. Signed-off-by: Oleksii Kurochko Acked-by: Michal Orzel Acked-by: Jan Beulich --- Michal asked the following: Shouldn't this copyright be moved to generic header as

[PATCH v4 07/14] xen/asm-generic: introduce generalized hardirq.h

is common through archs thereby it is moved to asm-generic. Arm and PPC were switched to asm generic verstion of hardirq.h. Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich Acked-by: Julien Grall --- Changes in V4: - Added Reviewed-by: Jan Beulich . - Added Acked-by: Julien Grall .

[PATCH v4 13/14] xen: ifdef inclusion of in

Ifdef-ing inclusion of allows to avoid generation of empty for cases when CONFIG_GRANT_TABLE is not enabled. The following changes were done for Arm: should be included directly because it contains gnttab_dom0_frames() macros which is unique for Arm and is used in arch/arm/domain_build.c. is #

[PATCH v4 05/14] xen/asm-generic: introduce stub header

is common for Arm, PPC and RISC-V thereby it is moved to asm-generic. Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich Acked-by: Julien Grall --- Changes in V4: - Added Reviewed-by: Jan Beulich - Added Acked-by: Julien Grall --- Changes in V3: - Drop Arm and PPC's random.h and swi

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

On 27.11.2023 15:13, Oleksii Kurochko wrote: > Arm, PPC and RISC-V use the same device.h thereby device.h > was moved to asm-generic. Arm's device.h was taken as a base with > the following changes: > - #ifdef PCI related things. > - #ifdef ACPI related things. > - Rename #ifdef guards. > - Add

Re: MISRA: Compatible declarations for sort and bsearch

On 2023-11-24 10:40, Nicola Vetrini wrote: Hi all, in xen/lib.h and xen/sort.h there are definitions of the functions bsearch and sort that have no prior declarations, and therefore are subject to a violation of MISRA C Rule 8.4. I'm wondering whether it would be preferred 1. to put a decla

Re: [PATCH v4 06/14] xen/asm-generic: introduce generic header percpu.h

On 27.11.2023 15:13, Oleksii Kurochko wrote: > The patch introduces generic percpu.h which was based on Arm's version > with the following changes: > * makes __per_cpu_data_end[] constant > * introduce get_per_cpu_offset() for macros this_cpu() and this_cpu_ptr() > * add inclustion of as get_pe

Re: [XEN PATCH v2 2/3] xen/arm: add SAF deviation for debugging and logging effects

On 27/11/23 11:46, Jan Beulich wrote: On 24.11.2023 18:29, Simone Ballarin wrote: Rule 13.1: Initializer lists shall not contain persistent side effects Effects caused by debug/logging macros and functions (like ASSERT, __bad_atomic_size, LOG, etc ...) that crash execution or produce logs are

Re: [PATCH v4 11/14] xen/asm-generic: introduce stub header numa.h

On 27.11.2023 15:13, Oleksii Kurochko wrote: > is common through some archs so it is moved > to asm-generic. > > Signed-off-by: Oleksii Kurochko > Reviewed-by: Michal Orzel Acked-by: Jan Beulich

Re: [PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

On 27.11.2023 15:13, Oleksii Kurochko wrote: > is common between Arm, PPC and RISC-V so it is > moved to asm-generic. > > Drop Arm and PPC's softirq.h and use asm-generic version instead. > > Signed-off-by: Oleksii Kurochko > Reviewed-by: Michal Orzel > Added Acked-by: Jan Beulich In case a

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

On 27.11.2023 15:13, Oleksii Kurochko wrote: > --- a/xen/arch/ppc/include/asm/grant_table.h > +++ /dev/null > @@ -1,5 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0-only */ > -#ifndef __ASM_PPC_GRANT_TABLE_H__ > -#define __ASM_PPC_GRANT_TABLE_H__ > - > -#endif /* __ASM_PPC_GRANT_TABLE_H__ */ Remov

[PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt attention to undefined behavior issues, notably during CI test runs, is essential. When enabled, this option causes Xen to panic upon detecting UBSAN failure (as the last step in ubsan_epilogue()). Signed-off-by: Michal Orz

Re: [PATCH v4 14/14] xen/asm-generic: ifdef inclusion of

On 27.11.2023 15:13, Oleksii Kurochko wrote: > --- a/xen/arch/ppc/include/asm/mem_access.h > +++ /dev/null > @@ -1,5 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0-only */ > -#ifndef __ASM_PPC_MEM_ACCESS_H__ > -#define __ASM_PPC_MEM_ACCESS_H__ > - > -#endif /* __ASM_PPC_MEM_ACCESS_H__ */ Same as f

Re: [PATCH 1/2] livepatch-build-tools: remove usage of gawk

On Fri, Nov 24, 2023 at 12:10:57PM +, Alejandro Vallejo wrote: > On 24/11/2023 11:43, Ross Lagerwall wrote: > > On Thu, Nov 23, 2023 at 4:08 PM Roger Pau Monne > wrote: > >> > >> And instead use plain awk. > >> > >> There's no need to use the --non-decimal-data option for gawk, since the > >>

Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

On Mon, Nov 27, 2023 at 11:49:03AM +, Andrew Cooper wrote: > On 24/11/2023 7:54 pm, Neowutran wrote: > > Hi, > > I did some more tests and research, indeed this patch improved/solved my > > specific case. > > > > Starting point: > > > > I am using Xen version 4.17.2 (exactly this source >

Re: [PATCH] x86/xen: fix percpu vcpu_info allocation

On 11/24/23 2:48 AM, Juergen Gross wrote: Today the percpu struct vcpu_info is allocated via DEFINE_PER_CPU(), meaning that it could cross a page boundary. In this case registering it with the hypervisor will fail, resulting in a panic(). This can easily be fixed by using DEFINE_PER_CPU_ALIGN

  1   2   >