Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction

2023-02-21 Thread Juergen Gross
On 20.02.23 19:01, Julien Grall wrote: On 20/02/2023 14:21, Juergen Gross wrote: On 20.02.23 15:15, Julien Grall wrote: On 20/02/2023 13:49, Juergen Gross wrote: On 20.02.23 13:07, Julien Grall wrote: Hi Juergen, On 20/02/2023 11:04, Juergen Gross wrote: On 20.02.23 10:46, Julien Grall wr

Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only

2023-02-21 Thread Juergen Gross
On 20.02.23 23:50, Julien Grall wrote: Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: Instead of modifying accounting data and undo those modifications in case of an error during further processing, add a framework for collecting the needed changes and commit them only when the whole ope

Re: linux-next: duplicate patches in the xen-tip tree

2023-02-21 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Tue, Feb 14, 2023 at 12:47:00PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > The following commits are also in the tip tree as different commits > > (but the same patches): > > > > 415dab3c1796 ("drivers/xen/hypervisor: Expose Xen SIF flags to userspace")

Re: [PATCH v2 08/13] tools/xenstore: add accounting trace support

2023-02-21 Thread Juergen Gross
On 20.02.23 23:57, Julien Grall wrote: Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: Add a new trace switch "acc" and the related trace calls. The "acc" switch is off per default. Signed-off-by: Juergen Gross With one reamrk (see below): Reviewed-by: Julien Grall ---   tools/xe

Re: [PATCH v2 09/13] tools/xenstore: add TDB access trace support

2023-02-21 Thread Juergen Gross
On 20.02.23 23:59, Julien Grall wrote: Hi, On 20/01/2023 10:00, Juergen Gross wrote: Add a new trace switch "tdb" and the related trace calls. The "tdb" switch is off per default. Signed-off-by: Juergen Gross With one remark (see below): Reviewed-by: Julien Grall ---   tools/xenstore/x

Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource

2023-02-21 Thread Juergen Gross
On 21.02.23 06:51, Krister Johansen wrote: On Mon, Feb 20, 2023 at 08:14:40PM -0800, Krister Johansen wrote: On Mon, Feb 20, 2023 at 11:01:18PM +0100, Thomas Gleixner wrote: On Mon, Feb 20 2023 at 09:17, Krister Johansen wrote: @@ -495,8 +496,7 @@ static int __init xen_tsc_safe_clocksource(voi

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-21 Thread Jan Beulich
On 20.02.2023 17:51, Matias Ezequiel Vara Larsen wrote: > On Thu, Feb 16, 2023 at 04:15:29PM +0100, Jan Beulich wrote: >> On 16.02.2023 16:07, Matias Ezequiel Vara Larsen wrote: >>> On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wr

Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource

2023-02-21 Thread Thomas Gleixner
On Mon, Feb 20 2023 at 21:51, Krister Johansen wrote: > On Mon, Feb 20, 2023 at 08:14:40PM -0800, Krister Johansen wrote: >> > static bool __init xen_tsc_safe_clocksource(void) >> > { >> >u32 eax, ebx. ecx, edx; >> > >> >/* Leaf 4, sub-leaf 0 (0x4x03) */ >> >cpuid_count(xen_cpuid_

[xen-unstable test] 177972: tolerable trouble: fail/pass/starved

2023-02-21 Thread osstest service owner
flight 177972 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177972/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 177883 test-amd64-amd64-xl-qemut-win7-amd64

Re: [RFC PATCH 08/10] xen: pci: remove pcidev_[un]lock[ed] calls

2023-02-21 Thread Jan Beulich
On 21.02.2023 00:13, Volodymyr Babchuk wrote: > Stefano Stabellini writes: >> On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >>> As pci devices are refcounted now and all list that store them are >>> protected by separate locks, we can safely drop global pcidevs_lock. >>> >>> Signed-off-by: Volodym

[RFC QEMU] docs: vhost-user: Add custom memory mapping support

2023-02-21 Thread Viresh Kumar
The current model of memory mapping at the back-end works fine with Qemu, where a standard call to mmap() for the respective file descriptor, passed from front-end, is generally all we need to do before the front-end can start accessing the guest memory. There are other complex cases though, where

Re: [Discussion] Xen grants and access permissions

2023-02-21 Thread Viresh Kumar
On 20-02-23, 07:13, Juergen Gross wrote: > There are no permission flags in Xen PV device protocols either. The kind of a > mapping (RO or RW) in the backend is selected via the I/O operation: in case > it > is a write type operation (guest writing data to a device), the related grants > are mappe

Re: [PATCH v4 2/3] Build system: Replace git:// and http:// with https://

2023-02-21 Thread Jan Beulich
On 19.02.2023 03:46, Demi Marie Obenour wrote: > --- a/stubdom/configure > +++ b/stubdom/configure > @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then : > if test "x$extfiles" = "xy"; then : >ZLIB_URL=\$\(XEN_EXTFILES_URL\) > else > - ZLIB_URL="http://www.zlib.net"; > + ZLIB_URL="

Re: [PATCH v1] xen: Work around Clang-IAS macro expansion bug

2023-02-21 Thread Jan Beulich
On 17.02.2023 13:22, Andrew Cooper wrote: > https://github.com/llvm/llvm-project/issues/60792 > > It turns out that Clang-IAS does not expand \@ uniquely in a translaition > unit, and the XSA-426 change tickles this bug: > > :4:1: error: invalid symbol redefinition > .L1_fill_rsb_loop: > ^

Re: [PATCH 1/3] x86/kexec: Drop compatibility_mode_far

2023-02-21 Thread Jan Beulich
On 17.02.2023 18:48, Andrew Cooper wrote: > ljmp is (famously?) incompatible between Intel and AMD CPUs, and while we're > using one of the compatible forms, we've got a good stack and lret is the far > more common way of doing this. > > No functional change. > > Signed-off-by: Andrew Cooper Re

Re: [PATCH 2/3] x86/kexec: Simplify the relocation of compat_mode_gdt_desc

2023-02-21 Thread Jan Beulich
On 17.02.2023 18:48, Andrew Cooper wrote: > Assemble the GDT base relative to kexec_reloc, and simply add the identity map > base address to relocate. > > Adjust a stale comment, and drop the unused matching label. Only kind of - the comment is referencing call_32_bit, and hence wasn't really sta

Re: [PATCH 3/3] x86/kexec: Annotate functions with ELF metadata

2023-02-21 Thread Jan Beulich
On 17.02.2023 18:48, Andrew Cooper wrote: > @@ -90,7 +91,10 @@ ENTRY(kexec_reloc) > push%rax > lretq > > -relocate_pages: > +.type kexec_reloc, @function > +.size kexec_reloc, . - kexec_reloc > + > +ENTRY(relocate_pages) > /* %rdi - indirection page

Re: [PATCH] x86/asm: ELF metadata for simple cases

2023-02-21 Thread Jan Beulich
On 20.02.2023 12:51, Ross Lagerwall wrote: >> --- a/xen/arch/x86/clear_page.S >> +++ b/xen/arch/x86/clear_page.S >> @@ -16,3 +16,6 @@ ENTRY(clear_page_sse2) >>   >> sfence >> ret >> + >> +    .type clear_page_sse2, @function >> +    .size clear_page_sse2, . - clear_page_ss

Re: [PATCH] x86/asm: ELF metadata for simple cases

2023-02-21 Thread Jan Beulich
On 20.02.2023 12:04, Andrew Cooper wrote: > This is generally good practice, and necessary for livepatch binary diffing to > work. > > With this, livepatching of the SVM entry path works. The only complication is > with svm_stgi_label which is only used by oprofile to guestimate (not > completely

Re: [PATCH RFC] xen: Annotate printk() as cold

2023-02-21 Thread Jan Beulich
On 20.02.2023 14:13, Andrew Cooper wrote: > There is no such thing as a fastpath with a printk() on it, making printk() an > excellent heuristic for slowpaths. > > Net delta is: > > add/remove: 595/2 grow/shrink: 56/762 up/down: 70879/-87331 (-16452) > Total: Before=4085425, After=4068973, ch

Re: [PATCH 1/4] x86/svm: cleanup svm.c

2023-02-21 Thread Jan Beulich
On 21.02.2023 08:45, Xenia Ragiadakou wrote: > Hi Andrew, > > On 2/21/23 00:12, Andrew Cooper wrote: >> On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >>> Do not include the headers: >>>xen/irq.h >>>asm/hvm/svm/intr.h >>>asm/io.h >>>asm/mem_sharing.h >>>asm/regs.h >> >> Out of

Re: [PATCH 4/4] x86/vmx: cleanup vmx.h

2023-02-21 Thread Jan Beulich
On 17.02.2023 19:48, Xenia Ragiadakou wrote: > Do not include the headers: > asm/i387.h > asm/hvm/trace.h > asm/processor.h > asm/regs.h > because none of the declarations and macro definitions in them is used in > this file. Sort alphabetically the rest of the headers. > Fix build by inclu

Re: [PATCH 3/4] x86/vmx: cleanup vmx.c

2023-02-21 Thread Jan Beulich
On 17.02.2023 19:48, Xenia Ragiadakou wrote: > Do not include the headers: > asm/hvm/vpic.h > asm/hvm/vpt.h > asm/io.h > asm/mce.h > asm/mem_sharing.h > asm/regs.h > public/arch-x86/cpuid.h > public/hvm/save.h > because none of the declarations and macro definitions in them is used.

Re: [PATCH 3/4] x86/vmx: cleanup vmx.c

2023-02-21 Thread Xenia Ragiadakou
Hi Jan, On 2/21/23 13:26, Jan Beulich wrote: On 17.02.2023 19:48, Xenia Ragiadakou wrote: Do not include the headers: asm/hvm/vpic.h asm/hvm/vpt.h asm/io.h asm/mce.h asm/mem_sharing.h asm/regs.h public/arch-x86/cpuid.h public/hvm/save.h because none of the declarations a

Re: [PATCH 4/4] x86/vmx: cleanup vmx.h

2023-02-21 Thread Xenia Ragiadakou
On 2/21/23 13:23, Jan Beulich wrote: On 17.02.2023 19:48, Xenia Ragiadakou wrote: Do not include the headers: asm/i387.h asm/hvm/trace.h asm/processor.h asm/regs.h because none of the declarations and macro definitions in them is used in this file. Sort alphabetically the rest of t

Re: [PATCH 1/4] x86/svm: cleanup svm.c

2023-02-21 Thread Xenia Ragiadakou
On 2/21/23 13:12, Jan Beulich wrote: On 21.02.2023 08:45, Xenia Ragiadakou wrote: Hi Andrew, On 2/21/23 00:12, Andrew Cooper wrote: On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: Do not include the headers: xen/irq.h asm/hvm/svm/intr.h asm/io.h asm/mem_sharing.h asm/regs

[ImageBuilder][PATCH] uboot-script-gen: Add virtio loader

2023-02-21 Thread Pavel Zhukov
uboot supports virtio-blk drives and can load kernel image from it. Adding option to use '-t virtio' for loading image from virtio device Signed-off-by: Pavel Zhukov --- README.md| 14 +++--- scripts/uboot-script-gen | 3 +++ 2 files changed, 10 insertions(+), 7 deletion

Re: [PATCH 2/3] x86/entry: Rework the exception entrypoints

2023-02-21 Thread Jan Beulich
On 20.02.2023 12:59, Andrew Cooper wrote: > This fixes two issues preventing livepatching. First, that #PF and NMI fall > through into other functions, I thought this was deliberate, aiming at avoiding the unconditional branch for the most commonly taken path each. I'm not really opposed to the c

Re: [PATCH 1/3] x86/traps: Move do_general_protection() earlier

2023-02-21 Thread Jan Beulich
On 20.02.2023 12:59, Andrew Cooper wrote: > ... in order to clean up the declarations without needing to forward declare > it for handle_gdt_ldt_mapping_fault() > > No functional change. > > Signed-off-by: Andrew Cooper This is okay with me as long as the Misra related comment on patch 2 can be

Re: [PATCH v1] xen: Work around Clang-IAS macro expansion bug

2023-02-21 Thread Andrew Cooper
On 21/02/2023 10:31 am, Jan Beulich wrote: > On 17.02.2023 13:22, Andrew Cooper wrote: >> https://github.com/llvm/llvm-project/issues/60792 >> >> It turns out that Clang-IAS does not expand \@ uniquely in a translaition >> unit, and the XSA-426 change tickles this bug: >> >> :4:1: error: invalid

Re: [PATCH v1] xen: Work around Clang-IAS macro expansion bug

2023-02-21 Thread Jan Beulich
On 21.02.2023 13:26, Andrew Cooper wrote: > On 21/02/2023 10:31 am, Jan Beulich wrote: >> On 17.02.2023 13:22, Andrew Cooper wrote: >>> https://github.com/llvm/llvm-project/issues/60792 >>> >>> It turns out that Clang-IAS does not expand \@ uniquely in a translaition >>> unit, and the XSA-426 chang

Re: [PATCH v1] xen: Work around Clang-IAS macro expansion bug

2023-02-21 Thread Andrew Cooper
On 21/02/2023 12:46 pm, Jan Beulich wrote: > On 21.02.2023 13:26, Andrew Cooper wrote: >> On 21/02/2023 10:31 am, Jan Beulich wrote: >>> On 17.02.2023 13:22, Andrew Cooper wrote: https://github.com/llvm/llvm-project/issues/60792 It turns out that Clang-IAS does not expand \@ uniquely

Re: [PATCH 3/3] x86/treewide: Drop the TRAP_* legacy names

2023-02-21 Thread Jan Beulich
On 20.02.2023 12:59, Andrew Cooper wrote: > We have two naming schemes for exceptions - X86_EXC_?? which use the > archtiectural abbreviations, and TRAP_* which is a mix of terminology and > nonstandard abbrevations. Switch to X86_EXC_* uniformly. > > No funcational change, confirmed by diffing t

Re: [PATCH 1/4] x86/svm: cleanup svm.c

2023-02-21 Thread Andrew Cooper
On 21/02/2023 11:42 am, Xenia Ragiadakou wrote: > > On 2/21/23 13:12, Jan Beulich wrote: >> On 21.02.2023 08:45, Xenia Ragiadakou wrote: >>> Hi Andrew, >>> >>> On 2/21/23 00:12, Andrew Cooper wrote: On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: > Do not include the headers: >     xen/

Re: [PATCH 3/4] x86/vmx: cleanup vmx.c

2023-02-21 Thread Jan Beulich
On 21.02.2023 12:35, Xenia Ragiadakou wrote: > On 2/21/23 13:26, Jan Beulich wrote: >> On 17.02.2023 19:48, Xenia Ragiadakou wrote: >>> Do not include the headers: >>>asm/hvm/vpic.h >>>asm/hvm/vpt.h >>>asm/io.h >>>asm/mce.h >>>asm/mem_sharing.h >>>asm/regs.h >>>public/ar

[PATCH v2] x86/MSI: use standard C types in structures/unions

2023-02-21 Thread Jan Beulich
Consolidate this to use exclusively standard types, and change indentation style to Xen's there at the same time (the file already had a mix of styles). While there - switch boolean fields to use bool, - drop the notion of big-endian bitfields being a thing on x86, - drop the names for reserved fi

Re: [PATCH v2] x86/MSI: use standard C types in structures/unions

2023-02-21 Thread Andrew Cooper
On 21/02/2023 1:27 pm, Jan Beulich wrote: > Consolidate this to use exclusively standard types, and change > indentation style to Xen's there at the same time (the file already had > a mix of styles). > > While there > - switch boolean fields to use bool, > - drop the notion of big-endian bitfields

[linux-linus test] 177979: tolerable trouble: fail/pass/starved - PUSHED

2023-02-21 Thread osstest service owner
flight 177979 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177979/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 177860 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [PATCH 1/2] xen/ioapic: Don't use local_irq_restore() to disable irqs

2023-02-21 Thread Jan Beulich
On 20.02.2023 20:47, Andrew Cooper wrote: > Despite its name, the irq{save,restore}() APIs are only intended to > conditionally disable and re-enable interrupts. Are they? Maybe nowadays they indeed are, but I couldn't spot any wording to this effect in Linux'es Documentation/ (and I don't think w

Ping: [PATCH 1/6] x86/Hyper-V: use standard C types in hyperv-tlfs.h

2023-02-21 Thread Jan Beulich
On 09.02.2023 11:38, Jan Beulich wrote: > This is the only file left with a use of an __s type coming from > Linux. Since the file has been using an apparently random mix of all > three classes of fixed-width types (__{s,u}, {s,u}, and > {,u}int_t), consolidate this to use exclusively standard type

Re: [PATCH 2/2] x86/irq: Improve local_irq_restore() code generation and performance

2023-02-21 Thread Jan Beulich
On 20.02.2023 20:47, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/system.h > +++ b/xen/arch/x86/include/asm/system.h > @@ -267,13 +267,8 @@ static inline unsigned long > array_index_mask_nospec(unsigned long index, > }) > #define local_irq_restore(x)

Re: [PATCH v2] x86: Perform mem_sharing teardown before paging teardown

2023-02-21 Thread Jan Beulich
On 15.02.2023 18:07, Tamas K Lengyel wrote: > An assert failure has been observed in p2m_teardown when performing vm > forking and then destroying the forked VM (p2m-basic.c:173). The assert > checks whether the domain's shared pages counter is 0. According to the > patch that originally added the

Re: [PATCH v4 1/2] x86/ucode/AMD: apply the patch early on every logical thread

2023-02-21 Thread Jan Beulich
On 15.02.2023 16:38, Sergey Dyasli wrote: > The original issue has been reported on AMD Bulldozer-based CPUs where > ucode loading loses the LWP feature bit in order to gain the IBPB bit. > LWP disabling is per-SMT/CMT core modification and needs to happen on > each sibling thread despite the share

Re: [PATCH v4 2/2] x86/ucode/AMD: late load the patch on every logical thread

2023-02-21 Thread Jan Beulich
On 15.02.2023 16:38, Sergey Dyasli wrote: > --- a/xen/arch/x86/cpu/microcode/core.c > +++ b/xen/arch/x86/cpu/microcode/core.c > @@ -398,10 +398,16 @@ static int cf_check microcode_nmi_callback( > (!ucode_in_nmi && cpu == primary) ) > return 0; > > -if ( cpu == primary ) > +

[PATCH] livepatch-build: Check compiler version matches

2023-02-21 Thread Ross Lagerwall
For reliable live patch generation, the compiler version used should match the original binary. Check that this is the case and add a --skip-compiler-check option to override this. Signed-off-by: Ross Lagerwall --- livepatch-build | 54 +++-- 1 file ch

[xen-unstable-smoke test] 178016: tolerable trouble: pass/starved - PUSHED

2023-02-21 Thread osstest service owner
flight 178016 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178016/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] livepatch-build: Check compiler version matches

2023-02-21 Thread Andrew Cooper
On 21/02/2023 2:14 pm, Ross Lagerwall wrote: > For reliable live patch generation, the compiler version used should > match the original binary. Check that this is the case and add a > --skip-compiler-check option to override this. > > Signed-off-by: Ross Lagerwall > --- > livepatch-build | 54 ++

Re: [PATCH v2] x86: Perform mem_sharing teardown before paging teardown

2023-02-21 Thread Tamas K Lengyel
On Tue, Feb 21, 2023 at 8:54 AM Jan Beulich wrote: > > On 15.02.2023 18:07, Tamas K Lengyel wrote: > > An assert failure has been observed in p2m_teardown when performing vm > > forking and then destroying the forked VM (p2m-basic.c:173). The assert > > checks whether the domain's shared pages cou

[libvirt test] 177984: tolerable trouble: pass/starved - PUSHED

2023-02-21 Thread osstest service owner
flight 177984 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/177984/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-checkfail never pass test-amd64-amd64-libvirt 15 migrate-s

[XEN PATCH v2 0/7] automation: Update containers to allow HTTPS access to xenbits

2023-02-21 Thread Anthony PERARD
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-containers-update-v2 v2: - Remove CentOS 7.2 - Remove Debian Jessie test, but update container recipe for the benefit of older branches. - Fix CentOS 7 containner recipe to upda

[XEN PATCH v2 2/7] automation: Ensure that all packages are up-to-dates in CentOS 7 container

2023-02-21 Thread Anthony PERARD
This was prompt by the fact that `wget https://xenbits.xenproject.org` fails with expired certificates, which turned out to be an expired root certificates. Updating all packages fix the issue. Signed-off-by: Anthony PERARD --- Notes: v2: - new patch, this replace a change in "Remove exp

[XEN PATCH v2 1/7] automation: Remove CentOS 7.2 containers and builds

2023-02-21 Thread Anthony PERARD
We already have a container which track the latest CentOS 7, no need for this one as well. Also, 7.2 have outdated root certificate which prevent connection to website which use Let's Encrypt. Signed-off-by: Anthony PERARD --- Notes: v2: - new patch automation/build/centos/7.2.dockerf

[XEN PATCH v2 7/7] automation: Remove expired root certificates used to be used by let's encrypt

2023-02-21 Thread Anthony PERARD
While the Let's Encrypt root certificate ISRG_Root_X1.crt is already present, openssl seems to still check for the root certificate DST_Root_CA_X3.crt which has expired. This prevent https connections. Removing DST_Root_CA_X3 fix the issue. Signed-off-by: Anthony PERARD --- Notes: v2: -

[XEN PATCH v2 5/7] automation: Add more aliases in containerize

2023-02-21 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper --- automation/scripts/containerize | 3 +++ 1 file changed, 3 insertions(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 9e508918bf..9b1a302d05 100755 --- a/automation/scripts/containerize +++ b/autom

[XEN PATCH v2 4/7] automation: Use EOL tag for Jessie container

2023-02-21 Thread Anthony PERARD
As Jessie is EOL, the official tag isn't supported anymore. Also, the GPG key for the packages on the repository on the official image are expired and it isn't possible to update or install packages. But we can use the image from "debian/eol" tag which use repositories from archive.debian.org and

[XEN PATCH v2 6/7] automation: Remove testing on Debian Jessie

2023-02-21 Thread Anthony PERARD
Jessie as rearch EOL in 2020. Even if we update the containers, we would still not be able to reach HTTPS webside with Let's Encrypt certificates and thus would need more change to the container. Signed-off-by: Anthony PERARD --- Notes: HTTPS would fail unless we commit "automation: Remove

[XEN PATCH v2 3/7] automation: Remove clang-8 from Debian unstable container

2023-02-21 Thread Anthony PERARD
First, apt complain that it isn't the right way to add keys anymore, but hopefully that's just a warning. Second, we can't install clang-8: The following packages have unmet dependencies: clang-8 : Depends: libstdc++-8-dev but it is not installable Depends: libgcc-8-dev but it is not i

[xen-unstable-smoke test] 178030: tolerable trouble: pass/starved - PUSHED

2023-02-21 Thread osstest service owner
flight 178030 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178030/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource

2023-02-21 Thread Krister Johansen
On Tue, Feb 21, 2023 at 10:14:54AM +0100, Thomas Gleixner wrote: > On Mon, Feb 20 2023 at 21:51, Krister Johansen wrote: > > On Mon, Feb 20, 2023 at 08:14:40PM -0800, Krister Johansen wrote: > >> > static bool __init xen_tsc_safe_clocksource(void) > >> > { > >> > u32 eax, ebx. ecx, edx; > >> > >

Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource

2023-02-21 Thread Krister Johansen
On Tue, Feb 21, 2023 at 09:47:24AM +0100, Juergen Gross wrote: > On 21.02.23 06:51, Krister Johansen wrote: > > On Mon, Feb 20, 2023 at 08:14:40PM -0800, Krister Johansen wrote: > > > On Mon, Feb 20, 2023 at 11:01:18PM +0100, Thomas Gleixner wrote: > > > > On Mon, Feb 20 2023 at 09:17, Krister Joha

Re: [PATCH 2/4] x86/svm: cleanup svm.h

2023-02-21 Thread Andrew Cooper
On 21/02/2023 7:58 am, Xenia Ragiadakou wrote: > > On 2/21/23 01:08, Andrew Cooper wrote: >> On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >>> Remove the forward declaration of struct vcpu because it is not used. >> >> Huh, turns out that was my fault in c/s b158e72abe, shortly after I >> introduc

Re: [XEN PATCH v2 3/7] automation: Remove clang-8 from Debian unstable container

2023-02-21 Thread Andrew Cooper
On 21/02/2023 4:55 pm, Anthony PERARD wrote: > First, apt complain that it isn't the right way to add keys anymore, > but hopefully that's just a warning. > > Second, we can't install clang-8: > The following packages have unmet dependencies: > clang-8 : Depends: libstdc++-8-dev but it is not inst

Re: [XEN PATCH v2 1/7] automation: Remove CentOS 7.2 containers and builds

2023-02-21 Thread Andrew Cooper
On 21/02/2023 4:55 pm, Anthony PERARD wrote: > We already have a container which track the latest CentOS 7, no need > for this one as well. > > Also, 7.2 have outdated root certificate which prevent connection to > website which use Let's Encrypt. > > Signed-off-by: Anthony PERARD Acked-by: Andre

Re: [XEN PATCH v2 2/7] automation: Ensure that all packages are up-to-dates in CentOS 7 container

2023-02-21 Thread Andrew Cooper
On 21/02/2023 4:55 pm, Anthony PERARD wrote: > This was prompt by the fact that `wget https://xenbits.xenproject.org` > fails with expired certificates, which turned out to be an expired > root certificates. Updating all packages fix the issue. > > Signed-off-by: Anthony PERARD Acked-by: Andrew C

Re: [XEN PATCH v2 6/7] automation: Remove testing on Debian Jessie

2023-02-21 Thread Andrew Cooper
On 21/02/2023 4:55 pm, Anthony PERARD wrote: > Jessie as rearch EOL in 2020. > > Even if we update the containers, we would still not be able to reach > HTTPS webside with Let's Encrypt certificates and thus would need more > change to the container. > > Signed-off-by: Anthony PERARD How is this

Re: [XEN PATCH v2 6/7] automation: Remove testing on Debian Jessie

2023-02-21 Thread Andrew Cooper
On 21/02/2023 5:59 pm, Andrew Cooper wrote: > On 21/02/2023 4:55 pm, Anthony PERARD wrote: >> Jessie as rearch EOL in 2020. >> >> Even if we update the containers, we would still not be able to reach >> HTTPS webside with Let's Encrypt certificates and thus would need more >> change to the containe

Debian randconfig failure, Was Re: [XEN PATCH v2 0/7] automation: Update containers to allow HTTPS access to xenbits

2023-02-21 Thread Andrew Cooper
On 21/02/2023 4:55 pm, Anthony PERARD wrote: > Building randconfig on debian unstable seems to be an issue. You're talking about https://gitlab.com/xen-project/people/anthonyper/xen/-/jobs/3769926509 ? + gcc --version gcc (Debian 12.2.0-14) 12.2.0 arch/x86/extable.c: In function 'search_pre_exce

Re: [PATCH 1/2] xen/ioapic: Don't use local_irq_restore() to disable irqs

2023-02-21 Thread Andrew Cooper
On 21/02/2023 1:40 pm, Jan Beulich wrote: > On 20.02.2023 20:47, Andrew Cooper wrote: >> Despite its name, the irq{save,restore}() APIs are only intended to >> conditionally disable and re-enable interrupts. > Are they? Yes, absolutely. And as said before, the potentially dubious naming does not

[xen-unstable-smoke test] 178044: tolerable trouble: pass/starved - PUSHED

2023-02-21 Thread osstest service owner
flight 178044 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178044/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v4 2/2] x86/ucode/AMD: late load the patch on every logical thread

2023-02-21 Thread Sergey Dyasli
On Tue, Feb 21, 2023 at 2:03 PM Jan Beulich wrote: > > On 15.02.2023 16:38, Sergey Dyasli wrote: > > --- a/xen/arch/x86/cpu/microcode/core.c > > +++ b/xen/arch/x86/cpu/microcode/core.c > > @@ -398,10 +398,16 @@ static int cf_check microcode_nmi_callback( > > (!ucode_in_nmi && cpu == prim

Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction

2023-02-21 Thread Julien Grall
Hi Juergen, On 21/02/2023 08:10, Juergen Gross wrote: On 20.02.23 19:01, Julien Grall wrote: So I have recreated an XTF test which I think match what you wrote [1]. It is indeed failing without your patch. But then there are still some weird behavior here. I would expect the creation of the

Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only

2023-02-21 Thread Julien Grall
Hi Juergen, On 21/02/2023 08:37, Juergen Gross wrote: On 20.02.23 23:50, Julien Grall wrote: +    list_del(&cd->list); +    talloc_free(cd); +    } +} + +void acc_commit(struct connection *conn) +{ +    struct changed_domain *cd; +    struct buffered_data *in = conn->in; +    enum accit

Re: [PATCH v2 08/13] tools/xenstore: add accounting trace support

2023-02-21 Thread Julien Grall
Hi Juergen, On 21/02/2023 08:40, Juergen Gross wrote: On 20.02.23 23:57, Julien Grall wrote: Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: Add a new trace switch "acc" and the related trace calls. The "acc" switch is off per default. Signed-off-by: Juergen Gross With one reamrk (

[xen-unstable test] 178027: regressions - trouble: fail/pass/starved

2023-02-21 Thread osstest service owner
flight 178027 xen-unstable real [real] flight 178060 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/178027/ http://logs.test-lab.xenproject.org/osstest/logs/178060/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [GIT PULL] xen: branch for v6.3-rc1

2023-02-21 Thread pr-tracker-bot
The pull request you sent on Sun, 19 Feb 2023 06:33:26 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-6.3-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/239451e90355be68130410ef8fadef8cd130a35d Thank you! -- Deet-doot-dot, I

[linux-linus test] 178042: tolerable trouble: fail/pass/starved - PUSHED

2023-02-21 Thread osstest service owner
flight 178042 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178042/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 177979 test-amd64-amd64-xl-qemuu-win7-amd64