[libvirt test] 175032: tolerable all pass - PUSHED

2022-12-03 Thread osstest service owner
flight 175032 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/175032/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 175018 test-armhf-armhf-libvirt-raw 15 saveresto

[ovmf test] 175033: all pass - PUSHED

2022-12-03 Thread osstest service owner
flight 175033 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175033/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7de1c71dd2f4e04bd832fc7b92c8255161705393 baseline version: ovmf 5d5be45bd7c1e4798

[linux-linus test] 175030: regressions - FAIL

2022-12-03 Thread osstest service owner
flight 175030 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175030/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl

[xen-unstable test] 175031: tolerable FAIL - PUSHED

2022-12-03 Thread osstest service owner
flight 175031 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175031/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 175009 test-armhf-armhf-libvirt 16 save

Re: [PATCH v3 0/9] Arm cache coloring

2022-12-03 Thread Julien Grall
Hi Carlo, Just in case you are waiting on my review before sending a new version. Given that... On 22/10/2022 16:51, Carlo Nonato wrote: Shared caches in multi-core CPU architectures represent a problem for predictability of memory access latency. This jeopardizes applicability of many Arm pl

Re: [XEN v1] xen/Arm: Remove the extra assignment

2022-12-03 Thread Julien Grall
Hi Ayan, Title: It suggests that this is modifying arch/arm whereas you are updating the Arm part of the ns16550 driver. In addition to that, from a reader PoV, it is more important to emphase on the fact the truncation check is removed rather than the extra assignment. So I would suggest

Re: [PATCH] Arm64: make setup_virt_paging()'s pa_range_info[] static

2022-12-03 Thread Julien Grall
On 29/11/2022 16:01, Julien Grall wrote: Hi Jan, On 29/11/2022 15:39, Jan Beulich wrote: While not as inefficient as it would be on x86 (due to suitable constant loading and register pair storing instructions being available to fill some of the fields), having the compiler construct an array

Re: [PATCH] Arm/P2M: reduce locking in p2m_{alloc,free}_page()

2022-12-03 Thread Julien Grall
On 29/11/2022 15:53, Julien Grall wrote: Hi Jan, On 29/11/2022 15:39, Jan Beulich wrote: It is generally preferable to not hold locks around allocation functions. And indeed in the hwdom case there's no point at all to hold the paging lock. Reduce the locked regions to the non-hwdom case, wh

Re: [XEN v4 02/11] xen/Arm: GICv3: Do not calculate affinity level 3 for AArch32

2022-12-03 Thread Julien Grall
Hi, On 28/11/2022 15:56, Ayan Kumar Halder wrote: Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 Affinity level 3 is not present in AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, Affinity level 3 is not present in Armv7 (ie arm32). Thus, any access to affinity level 3 needs

Re: [XEN v4 04/11] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32

2022-12-03 Thread Julien Grall
Hi Ayan, On 28/11/2022 15:56, Ayan Kumar Halder wrote: Refer ARM DDI 0487I.a ID081822, G8-9650, G8.2.113 Aff3 does not exist on AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106 Aff3 does not exist on Armv7 (ie arm32). Thus, access to aff3 has been protected with "#ifdef CONFIG_A

Re: [XEN v4 07/11] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32

2022-12-03 Thread Julien Grall
Hi, On 29/11/2022 14:33, Michal Orzel wrote: @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) if ( v == current ) { for ( i = 0; i < gicv3_info.nr_lrs; i++ ) -printk(" HW_LR[%d]=%lx\n", i, gicv3_ich_read_lr(i)); +printk("

Re: [XEN v1] xen/Arm: Remove the extra assignment

2022-12-03 Thread Ayan Kumar Halder
On 03/12/2022 18:05, Julien Grall wrote: Hi Ayan, Hi Julien, Title: It suggests that this is modifying arch/arm whereas you are updating the Arm part of the ns16550 driver. In addition to that, from a reader PoV, it is more important to emphase on the fact the truncation check is remov

Re: [XEN v1] xen/Arm: Remove the extra assignment

2022-12-03 Thread Julien Grall
Hi Ayan, On 03/12/2022 19:08, Ayan Kumar Halder wrote: On 03/12/2022 18:05, Julien Grall wrote: Hi Ayan, Hi Julien, Title: It suggests that this is modifying arch/arm whereas you are updating the Arm part of the ns16550 driver. In addition to that, from a reader PoV, it is more importa

[linux-linus test] 175034: regressions - FAIL

2022-12-03 Thread osstest service owner
flight 175034 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175034/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl

Re: [XEN v4 07/11] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32

2022-12-03 Thread Ayan Kumar Halder
On 03/12/2022 18:35, Julien Grall wrote: Hi, Hi Julien, On 29/11/2022 14:33, Michal Orzel wrote: @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v)   if ( v == current )   {   for ( i = 0; i < gicv3_info.nr_lrs; i++ ) -    printk("   HW_LR[%d

Re: [XEN v3] Xen: Ensure "xenheap_bits - PAGE_SHIFT" can be used as a rhs operand of shift operator

2022-12-03 Thread Ayan Kumar Halder
Hi Bobby, On 20/11/2022 17:01, Bobby Eshleman wrote: On Fri, Dec 02, 2022 at 12:56:06PM +, Andrew Cooper wrote: On 02/12/2022 12:35, Ayan Kumar Halder wrote: Currently this change will not have any impact on the existing architectures. The following table illustrates PADDR_BITS vs BITS_PER

Re: [XEN v4 10/11] xen/Arm: GICv3: Define macros to read/write 64 bit

2022-12-03 Thread Julien Grall
Hi, On 28/11/2022 15:56, Ayan Kumar Halder wrote: On AArch32, ldrd/strd instructions are not atomic when used to access MMIO. Furthermore, ldrd/strd instructions are not decoded by Arm when running as a guest to access emulated MMIO region. Thus, we have defined readq_relaxed_non_atomic()/writeq

Re: [XEN v4 11/11] xen/Arm: GICv3: Enable GICv3 for AArch32

2022-12-03 Thread Julien Grall
Hi, On 28/11/2022 15:56, Ayan Kumar Halder wrote: One can now use GICv3 on AArch32 systems. However, ITS is not supported. The reason being currently we are trying to validate GICv3 on an AArch32_v8R system. Refer ARM DDI 0568A.c ID110520, B1.3.1, "A Generic Interrupt Controller (GIC) implemente

Re: [XEN v4 07/11] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32

2022-12-03 Thread Julien Grall
Hi, On 03/12/2022 20:02, Ayan Kumar Halder wrote: The definition is different :- In xen/arch/arm/include/asm/arm32/sysregs.h  "#define __CP32(r, coproc, opc1, crn, crm, opc2) coproc, opc1, r, crn, crm, opc2"   (Note:- it takes 6 arguments) And what I have defined in  xen/arch/arm/include/a

Re: [RFC PATCH 08/21] xen/arm: vsmmuv3: Add support for registers emulation

2022-12-03 Thread Julien Grall
Hi Rahul, I have only skimmed through the patch so far. On 01/12/2022 16:02, Rahul Singh wrote: static int vsmmuv3_mmio_write(struct vcpu *v, mmio_info_t *info, register_t r, void *priv) { +struct virt_smmu *smmu = priv; +uint64_t reg; +uint32_t r

[xen-unstable-smoke test] 175035: tolerable all pass - PUSHED

2022-12-03 Thread osstest service owner
flight 175035 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175035/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [RFC PATCH 09/21] xen/arm: vsmmuv3: Add support for cmdqueue handling

2022-12-03 Thread Julien Grall
Hi, On 01/12/2022 16:02, Rahul Singh wrote: Add support for virtual cmdqueue handling for guests This commit message is a bit light given the security implication of this approach. See some of the questions below. [...] +static int arm_vsmmu_handle_cmds(struct virt_smmu *smmu) +{ +str

Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

2022-12-03 Thread Julien Grall
Hi Rahul, On 01/12/2022 16:02, Rahul Singh wrote: This patch adds basic framework for vIOMMU. Signed-off-by: Rahul Singh --- xen/arch/arm/domain.c| 17 +++ xen/arch/arm/domain_build.c | 3 ++ xen/arch/arm/include/asm/viommu.h| 70 ++

Re: [RFC PATCH 00/21] Add SMMUv3 Stage 1 Support for XEN guests

2022-12-03 Thread Julien Grall
Hi Rahul, On 01/12/2022 16:02, Rahul Singh wrote: This patch series is sent as RFC to get the initial feedback from the community. This patch series consists of 21 patches which is a big number for the reviewer to review the patches but to understand the feature end-to-end we thought of sending

[linux-linus test] 175036: regressions - FAIL

2022-12-03 Thread osstest service owner
flight 175036 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175036/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl

[xen-unstable test] 175037: tolerable FAIL - PUSHED

2022-12-03 Thread osstest service owner
flight 175037 xen-unstable real [real] flight 175039 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175037/ http://logs.test-lab.xenproject.org/osstest/logs/175039/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6