Re: [PATCH v3 05/10] automation: Add Arm containers to containerize script

2022-10-20 Thread Michal Orzel
Hi Jiamei, On 20/10/2022 05:00, Jiamei Xie wrote: > > > Hi Michal, > >> -Original Message- >> From: Xen-devel On Behalf Of >> Michal Orzel >> Sent: Tuesday, September 27, 2022 5:47 PM >> To: xen-devel@lists.xenproject.org >> Cc: Michal Orzel ; Doug Goldstein >> ; Stefano Stabellini >>

RE: [PATCH v3 05/10] automation: Add Arm containers to containerize script

2022-10-20 Thread Jiamei Xie
Hi Michal, > -Original Message- > From: Michal Orzel > Sent: Thursday, October 20, 2022 2:59 PM > To: Jiamei Xie ; xen-devel@lists.xenproject.org > Cc: Doug Goldstein ; Stefano Stabellini > > Subject: Re: [PATCH v3 05/10] automation: Add Arm containers to > containerize script > > Hi Ji

Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-20 Thread Bertrand Marquis
Hi Julien, > On 19 Oct 2022, at 23:33, Julien Grall wrote: > > Hi Andrew, > > On 19/10/2022 22:30, Andrew Cooper wrote: >> On 18/10/2022 00:01, Julien Grall wrote: > ... you are hardcoding both p2m_teardown() and p2m_set_allocation(). > IMO this is not an improvement at all. It is just

Re: [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()

2022-10-20 Thread Bertrand Marquis
Hi Henry, > On 18 Oct 2022, at 15:23, Henry Wang wrote: > > Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area > when the domain is created. Considering the worst case of page tables > which requires 6 P2M pages as the two pages will be consecutive but not > necessarily in the

Re: [PATCH v3 05/10] automation: Add Arm containers to containerize script

2022-10-20 Thread Michal Orzel
Hi Jiamei, On 20/10/2022 09:13, Jiamei Xie wrote: > > > Hi Michal, > >> -Original Message- >> From: Michal Orzel >> Sent: Thursday, October 20, 2022 2:59 PM >> To: Jiamei Xie ; xen-devel@lists.xenproject.org >> Cc: Doug Goldstein ; Stefano Stabellini >> >> Subject: Re: [PATCH v3 05/10

Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-20 Thread Jan Beulich
On 20.10.2022 00:33, Julien Grall wrote: > On 19/10/2022 22:30, Andrew Cooper wrote: >> On 18/10/2022 00:01, Julien Grall wrote: > ... you are hardcoding both p2m_teardown() and p2m_set_allocation(). > IMO this is not an improvement at all. It is just making the code more > complex than

RE: [PATCH v3 05/10] automation: Add Arm containers to containerize script

2022-10-20 Thread Jiamei Xie
Hi Michal, > -Original Message- > From: Michal Orzel > Sent: Thursday, October 20, 2022 3:52 PM > To: Jiamei Xie ; xen-devel@lists.xenproject.org > Cc: Doug Goldstein ; Stefano Stabellini > > Subject: Re: [PATCH v3 05/10] automation: Add Arm containers to > containerize script > > Hi Ji

Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller is described in DT

2022-10-20 Thread Xenia Ragiadakou
On 10/19/22 22:41, Oleksandr Tyshchenko wrote: Hi Oleksandr On 19.10.22 11:47, Xenia Ragiadakou wrote: Hello Xenia On 10/19/22 03:58, Stefano Stabellini wrote: On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Use the same "xen-grant-dma" device concept for the

Re: [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()

2022-10-20 Thread Julien Grall
Hi Henry, On 18/10/2022 15:23, Henry Wang wrote: Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area when the domain is created. Considering the worst case of page tables which requires 6 P2M pages as the two pages will be consecutive but not necessarily in the same L3 page tabl

[xen-4.13-testing test] 174106: regressions - trouble: fail/pass/starved

2022-10-20 Thread osstest service owner
flight 174106 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174106/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 172549 test-arm64-arm

Re: [PATCH] Input: xen-kbdfront - drop keys to shrink modalias

2022-10-20 Thread Mattijs Korpershoek
On Wed, Oct 19, 2022 at 16:14, Jason Andryuk wrote: > xen kbdfront registers itself as being able to deliver *any* key since > it doesn't know what keys the backend may produce. > > Unfortunately, the generated modalias gets too large and uevent creation > fails with -ENOMEM. > > This can lead to

[PATCH for-4.17 2/6] test/vpci: fix vPCI test harness to provide pci_get_pdev()

2022-10-20 Thread Roger Pau Monne
Instead of pci_get_pdev_by_domain(), which is no longer present in the hypervisor. While there add parentheses around the define value. Fixes: a37f9ea7a6 ('PCI: fold pci_get_pdev{,_by_domain}()') Signed-off-by: Roger Pau Monné --- tools/tests/vpci/emul.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH for-4.17 3/6] vpci: don't assume that vpci per-device data exists unconditionally

2022-10-20 Thread Roger Pau Monne
It's possible for a device to be assigned to a domain but have no vpci structure if vpci_process_pending() failed and called vpci_remove_device() as a result. The unconditional accesses done by vpci_{read,write}() and vpci_remove_device() to pdev->vpci would then trigger a NULL pointer dereference

[PATCH for-4.17 0/6] (v)pci: fixes related to memory decoding handling

2022-10-20 Thread Roger Pau Monne
Hello, First two patches fix some build isses that showed up on the vpci test harness, following patches attempt to fix the regressions caused by 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned') and the last patch relaxes the check done when attempting to write to BARs with mem

[PATCH for-4.17 1/6] test/vpci: add dummy cfcheck define

2022-10-20 Thread Roger Pau Monne
Some vpci functions got the cfcheck attribute added, but that's not defined in the user-space test harness, so add a dummy define in order for the harness to build. Fixes: 4ed7d5525f ('xen/vpci: CFI hardening') Signed-off-by: Roger Pau Monné --- tools/tests/vpci/emul.h | 1 + 1 file changed, 1 i

[PATCH for-4.17 4/6] vpci: introduce a local vpci_bar variable to modify_decoding()

2022-10-20 Thread Roger Pau Monne
This is done to shorten line length in the function in preparation for adding further usages of the vpci_bar data structure. No functional change. Signed-off-by: Roger Pau Monné --- xen/drivers/vpci/header.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/xen/

[PATCH for-4.17 5/6] pci: do not disable memory decoding for devices

2022-10-20 Thread Roger Pau Monne
Commit 75cc460a1b added checks to ensure the position of the BARs from PCI devices don't overlap with regions defined on the memory map. When there's a collision memory decoding is left disabled for the device, assuming that dom0 will reposition the BAR if necessary and enable memory decoding. Whi

[PATCH for-4.17 6/6] vpci: refuse BAR writes only if the BAR is mapped

2022-10-20 Thread Roger Pau Monne
Writes to the BARs are ignored if memory decoding is enabled for the device, and the same happen with ROM BARs if the write is an attempt to change the position of the BAR without disabling it first. The reason of ignoring such writes is a limitation in Xen, as it would need to unmap the BAR, chan

Re: [PATCH for-4.17 1/6] test/vpci: add dummy cfcheck define

2022-10-20 Thread Andrew Cooper
On 20/10/2022 10:46, Roger Pau Monne wrote: > Some vpci functions got the cfcheck attribute added, but that's not > defined in the user-space test harness, so add a dummy define in order > for the harness to build. > > Fixes: 4ed7d5525f ('xen/vpci: CFI hardening') > Signed-off-by: Roger Pau Monné

[xen-unstable-smoke test] 174124: regressions - FAIL

2022-10-20 Thread osstest service owner
flight 174124 xen-unstable-smoke real [real] flight 174129 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174124/ http://logs.test-lab.xenproject.org/osstest/logs/174129/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

RE: [PATCH for-4.17 0/6] (v)pci: fixes related to memory decoding handling

2022-10-20 Thread Henry Wang
Hi Roger, > -Original Message- > Subject: [PATCH for-4.17 0/6] (v)pci: fixes related to memory decoding > handling > > Hello, > > First two patches fix some build isses that showed up on the vpci test > harness, following patches attempt to fix the regressions caused by > 75cc460a1b ('x

Re: [PATCH v11 17/17] net: stream: add QAPI events to report connection state

2022-10-20 Thread Markus Armbruster
Sorry for the slow replay, too many distractions... Laurent Vivier writes: > On 10/17/22 15:23, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend >>> is connected, and NETDEV_STREAM_EOC when it is disconnected. >>> >>> T

[PATCH for-4.17?] test/vpci: enable by default

2022-10-20 Thread Roger Pau Monne
CONFIG_HAS_PCI is not defined for the tools build, and as a result the vpci harness would never get build. Fix this by building it unconditionally, there's nothing arch specific in it. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- While not strictly a bugfix, I think it's worth

RE: [PATCH for-4.17?] test/vpci: enable by default

2022-10-20 Thread Henry Wang
Hi Roger, > -Original Message- > From: Roger Pau Monne > Subject: [PATCH for-4.17?] test/vpci: enable by default > > CONFIG_HAS_PCI is not defined for the tools build, and as a result the > vpci harness would never get build. Fix this by building it > unconditionally, there's nothing ar

[PATCH 03/21] drm/ingenic: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_mode_config.output_poll_changed. It's used to inform the fbdev console about conncetor changes. But as ingenic uses generic fbdev emulation, the console is being informed by the DRM client helpers already. See the calls to drm_client_dev_hotplug() in drm_probe_helper.c. Signed

[PATCH 02/21] drm/imx: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as imx uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/d

[PATCH 00/21] drm/fb-helper: Untangle fbdev emulation and helpers

2022-10-20 Thread Thomas Zimmermann
Separate generic fbdev emulation from the helper code that is shared among the various fbdev implementations within DRM. Affects many drivers. The goal of this patchset is to improve readability and streamline the fbdev helper code within DRM. In the long term, we want to get to a point where driv

[PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gp

[PATCH 04/21] drm/komeda: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as komeda uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gp

[PATCH 06/21] drm/mcde: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as mcde uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/

[PATCH 05/21] drm/logicvc: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as logicvc uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/g

[PATCH 08/21] drm/vboxvideo: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as vboxvideo uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers

[PATCH 07/21] drm/rockchip: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as rockchip uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/

[PATCH 11/21] drm/fb-helper: Cleanup include statements in header file

2022-10-20 Thread Thomas Zimmermann
Only include what we have to. Signed-off-by: Thomas Zimmermann --- include/drm/drm_fb_helper.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index fddd0d1af6891..e923089522896 100644 --- a/include/drm/drm_fb_he

[PATCH 10/21] drm/tve200: Include

2022-10-20 Thread Thomas Zimmermann
Include for of_match_ptr(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tve200/tve200_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index 04db72e3fa9c2..611785e097576 100644 --- a/drivers/gpu/drm/tve

[PATCH 09/21] drm/panel-ili9341: Include

2022-10-20 Thread Thomas Zimmermann
Include for devm_of_find_backlight(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c index 39dc40cf681f0..b59472c29

[PATCH 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation

2022-10-20 Thread Thomas Zimmermann
Implement the fbdev's read/write helpers with the same functions. Use the generic fbdev's code as template. Convert all drivers. DRM's fb helpers must implement regular I/O functionality in struct fb_ops and possibly perform a damage update. Handle all this in the same functions and convert driver

[PATCH 13/21] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix

2022-10-20 Thread Thomas Zimmermann
Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c| 8 ---

[PATCH 21/21] drm/fb-helper: Remove unnecessary include statements

2022-10-20 Thread Thomas Zimmermann
Remove include statements for where it is not required (i.e., most of them). In a few places include other header files that are required by the source code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

[PATCH 14/21] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix

2022-10-20 Thread Thomas Zimmermann
Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c|

[PATCH 16/21] drm/fb-helper: Call fb_sync in I/O functions

2022-10-20 Thread Thomas Zimmermann
Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the behavior of fbdev. Fbdev implementations of fb_read and fb_write in struct fb_ops invoke fb_sync to synchronize with outstanding operations before I/O. Doing the same in DRM implementations will allow us to use them throughout DRM

[PATCH 12/21] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper

2022-10-20 Thread Thomas Zimmermann
Rename struct drm_fb_helper.fbdev to info. The current name is misleading as it overlaps with generic fbdev naming conventions. Adapt to the usual naming in fbdev drivers by calling the field 'info'. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c

[PATCH 15/21] drm/fb-helper: Disconnect damage worker from update logic

2022-10-20 Thread Thomas Zimmermann
The fbdev helpers implement a damage worker that forwards fbdev updates to the DRM driver. The worker's update logic depends on the generic fbdev emulation. Separate the two via function pointer. The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, a new callback that hides the up

[XEN v2] GICv3: Emulate GICD_IGRPMODR as RAZ / WI

2022-10-20 Thread Ayan Kumar Halder
Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to IGROUPR) is relevant only when the guests run in secure/non-secure mode. As Xen does not implement security extensions for guests, so the registers are emulated as read as zero/write ignore. Signed-off-by: Ayan Kumar Halder

Re: [XEN v1] GICv3: Emulate GICD_IGRPMODR as RAZ / WI

2022-10-20 Thread Ayan Kumar Halder
On 19/10/2022 16:49, Michal Orzel wrote: Hi Ayan, Hi Michal, On 19/10/2022 16:36, Ayan Kumar Halder wrote: Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to IGROUPR) is relevant only when the guests run in secure/non-secure mode. As Xen does not implement security e

[PATCH 18/21] drm/fb_helper: Minimize damage-helper overhead

2022-10-20 Thread Thomas Zimmermann
Pull the test for fb_dirty into the caller to avoid extra work if no callback has been set. In this case no damage handling is required and no damage area needs to be computed. Print a warning if the damage worker runs without getting an fb_dirty callback. Signed-off-by: Thomas Zimmermann --- dr

[PATCH 20/21] drm/fb-helper: Move generic fbdev emulation into separate source file

2022-10-20 Thread Thomas Zimmermann
Move the generic fbdev implementation into its own source and header file. Adapt drivers. No functonal changes, but some of the internal helpers have been renamed to fit into the drm_fbdev_ naming scheme. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Makefile | 2 +-

[PATCH 19/21] drm/fb-helper: Always initialize generic fbdev emulation

2022-10-20 Thread Thomas Zimmermann
Initialize the generic fbdev emulation even if it has been disabled on the kernel command line. The hotplug and mode initialization will fail accordingly. The kernel parameter can still be changed at runtime and the emulation will initialize after hotplugging the connector. Signed-off-by: Thomas

Re: [PATCH 03/21] drm/ingenic: Don't set struct drm_driver.lastclose

2022-10-20 Thread Sergey Shtylyov
Hello! On 10/20/22 1:37 PM, Thomas Zimmermann wrote: > Don't set struct drm_mode_config.output_poll_changed. It's used to > inform the fbdev console about conncetor changes. But as ingenic Connector. :-) > uses generic fbdev emulation, the console is being informed by the > DRM client helper

Intended behavior/usage of SSBD setting

2022-10-20 Thread Roger Pau Monné
Hello, As part of some follow up improvements to my VIRT_SPEC_CTRL series we have been discussing what the usage of SSBD should be for the hypervisor itself. There's currently a `spec-ctrl=ssbd` option [0], that has an out of date description, as now SSBD is always offered to guests on AMD hardwa

Re: [PATCH v12 12/17] net: dgram: add unix socket

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin QAPI schema Acked-by: Markus Armbruster Eventually: Acked-by: Markus Armbruster (QAPI schema) --- net/dgram.c | 54 +

Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional parameters

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Use QIOChannel, QIOChannelSocket and QIONetListener. This allows net/stream to use all the available parameters provided by SocketAddress. Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- meson | 2 +- net/stream.c| 493

Re: [PATCH v12 10/17] net: dgram: make dgram_dst generic

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: dgram_dst is a sockaddr_in structure. To be able to use it with unix socket, use a pointer to a generic sockaddr structure. Rename it dest_addr, and store socket length in dest_len. Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Acked-by: Mi

Re: [PATCH v12 17/17] net: stream: add QAPI events to report connection state

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: The netdev reports NETDEV_STREAM_CONNECTED event when the backend is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected. The NETDEV_STREAM_CONNECTED event includes the URI of the destination address. Signed-off-by: Laurent Vivier Acked-by

Re: Intended behavior/usage of SSBD setting

2022-10-20 Thread Jan Beulich
On 20.10.2022 13:01, Roger Pau Monné wrote: > Hello, > > As part of some follow up improvements to my VIRT_SPEC_CTRL series we > have been discussing what the usage of SSBD should be for the > hypervisor itself. There's currently a `spec-ctrl=ssbd` option [0], > that has an out of date descriptio

Re: [PATCH v12 05/17] net: introduce qemu_set_info_str() function

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Embed the setting of info_str in a function. Signed-off-by: Laurent Vivier Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin --- hw/net/xen_nic.c | 5 ++--- include/net/net.h | 1 + net/l2tpv3.c | 3 +-- net/net.c | 17 ++

Re: [PATCH v12 09/17] net: stream: add unix socket

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio Acked-by: Michael S. Tsirkin QAPI schema Acked-by: Markus Armbruster Eventually: Acked-by: Markus Armbruster (QAPI schema) Reviewed-by: Philippe Mathieu-Daudé --- net/stream.c| 1

[PATCH] x86/xen: simplify sysenter and syscall setup

2022-10-20 Thread Juergen Gross
xen_enable_sysenter() and xen_enable_syscall() can be simplified a lot. Signed-off-by: Juergen Gross --- arch/x86/xen/setup.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index cfa99e8f054b..0f33ed6d3a7b

[PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()

2022-10-20 Thread Juergen Gross
Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr accesses") introduced code resulting in a warning issued by the smatch static checker, claiming to use an uninitialized variable. This is a false positive, but work around the warning nevertheless. Fixes: 8714f7bcd3c2 ("xen/pv: a

[PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update

2022-10-20 Thread Andrew Cooper
tl;dr This hunk was part of the patch emailed to xen-devel, but was missing from what ultimately got committed. https://lore.kernel.org/xen-devel/4164cb728313c3b9fc38cf5e9ecb790ac93a9600.1610748224.git.edvin.to...@citrix.com/ is the patch in question, but was part of a series that had threading is

Re: [PATCH] x86/xen: simplify sysenter and syscall setup

2022-10-20 Thread Borislav Petkov
On Thu, Oct 20, 2022 at 01:36:19PM +0200, Juergen Gross wrote: > xen_enable_sysenter() and xen_enable_syscall() can be simplified a lot. > > Signed-off-by: Juergen Gross > --- > arch/x86/xen/setup.c | 23 ++- > 1 file changed, 6 insertions(+), 17 deletions(-) > > diff --git

Re: [PATCH] x86/xen: simplify sysenter and syscall setup

2022-10-20 Thread Juergen Gross
On 20.10.22 13:39, Borislav Petkov wrote: On Thu, Oct 20, 2022 at 01:36:19PM +0200, Juergen Gross wrote: xen_enable_sysenter() and xen_enable_syscall() can be simplified a lot. Signed-off-by: Juergen Gross --- arch/x86/xen/setup.c | 23 ++- 1 file changed, 6 insertions(+

Re: [PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose

2022-10-20 Thread Christian König
Am 20.10.22 um 12:37 schrieb Thomas Zimmermann: Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose().

[xen-unstable test] 174057: tolerable FAIL

2022-10-20 Thread osstest service owner
flight 174057 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174057/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 173980 test-amd64-i386-xl-qemuu-win7-amd64

[PATCH v2] x86/xen: simplify sysenter and syscall setup

2022-10-20 Thread Juergen Gross
xen_enable_sysenter() and xen_enable_syscall() can be simplified a lot. While at it, switch to use cpu_feature_enabled() instead of boot_cpu_has(). Signed-off-by: Juergen Gross --- V2: - use cpu_feature_enabled() (Borislav Petkov) --- arch/x86/xen/setup.c | 23 ++- 1 file ch

Re: [PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose

2022-10-20 Thread Thomas Zimmermann
Hi Am 20.10.22 um 13:48 schrieb Christian König: Am 20.10.22 um 12:37 schrieb Thomas Zimmermann: Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the ca

Re: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update

2022-10-20 Thread Christian Lindig
On 20 Oct 2022, at 12:38, Andrew Cooper mailto:andrew.coop...@citrix.com>> wrote: tl;dr This hunk was part of the patch emailed to xen-devel, but was missing from what ultimately got committed. https://lore.kernel.org/xen-devel/4164cb728313c3b9fc38cf5e9ecb790ac93a9600.1610748224.git.edvin.to..

Re: [PATCH] Input: xen-kbdfront - drop keys to shrink modalias

2022-10-20 Thread Jason Andryuk
On Thu, Oct 20, 2022 at 4:31 AM Mattijs Korpershoek wrote: > > On Wed, Oct 19, 2022 at 16:14, Jason Andryuk wrote: > > > xen kbdfront registers itself as being able to deliver *any* key since > > it doesn't know what keys the backend may produce. > > > > Unfortunately, the generated modalias gets

Re: [PATCH v11 17/17] net: stream: add QAPI events to report connection state

2022-10-20 Thread Laurent Vivier
On 10/20/22 12:22, Markus Armbruster wrote: Sorry for the slow replay, too many distractions... Laurent Vivier writes: On 10/17/22 15:23, Markus Armbruster wrote: Laurent Vivier writes: The netdev reports NETDEV_STREAM_CONNECTED event when the backend is connected, and NETDEV_STREAM_EOC w

Re: Intended behavior/usage of SSBD setting

2022-10-20 Thread Roger Pau Monné
On Thu, Oct 20, 2022 at 01:22:20PM +0200, Jan Beulich wrote: > On 20.10.2022 13:01, Roger Pau Monné wrote: > > Hello, > > > > As part of some follow up improvements to my VIRT_SPEC_CTRL series we > > have been discussing what the usage of SSBD should be for the > > hypervisor itself. There's curr

RE: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update

2022-10-20 Thread Henry Wang
Hi Andrew, > -Original Message- > From: Andrew Cooper > Subject: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update > > tl;dr This hunk was part of the patch emailed to xen-devel, but was missing > from what ultimately got committed. > > https://lore.kernel.org/xen- > devel/4

[xen-4.14-testing test] 174078: regressions - trouble: fail/pass/starved

2022-10-20 Thread osstest service owner
flight 174078 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174078/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken in 173725 test-arm64-arm64-xl-vhd

Re: [PATCH] Input: xen-kbdfront - drop keys to shrink modalias

2022-10-20 Thread Jason Andryuk
On Thu, Oct 20, 2022 at 8:21 AM Jason Andryuk wrote: > > On Thu, Oct 20, 2022 at 4:31 AM Mattijs Korpershoek > wrote: > > > > On Wed, Oct 19, 2022 at 16:14, Jason Andryuk wrote: > > > > > xen kbdfront registers itself as being able to deliver *any* key since > > > it doesn't know what keys the b

Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional parameters

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Use QIOChannel, QIOChannelSocket and QIONetListener. This allows net/stream to use all the available parameters provided by SocketAddress. Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- meson | 2 +- net/stream.c| 493

Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional parameters

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 13:05, Philippe Mathieu-Daudé wrote: On 20/10/22 11:16, Laurent Vivier wrote: Use QIOChannel, QIOChannelSocket and QIONetListener. This allows net/stream to use all the available parameters provided by SocketAddress. Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin ---  

Re: Policy: A release acks for the release manager's patches (was Re: [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init())

2022-10-20 Thread Jan Beulich
On 19.10.2022 17:28, George Dunlap wrote: > On Tue, Oct 18, 2022 at 3:24 PM Henry Wang wrote: > >> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area >> when the domain is created. Considering the worst case of page tables >> which requires 6 P2M pages as the two pages will be c

Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()

2022-10-20 Thread Jan Beulich
On 20.10.2022 13:37, Juergen Gross wrote: > Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr > accesses") introduced code resulting in a warning issued by the smatch > static checker, claiming to use an uninitialized variable. > > This is a false positive, but work around the wa

Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional parameters

2022-10-20 Thread Daniel P . Berrangé
On Thu, Oct 20, 2022 at 03:09:10PM +0200, Philippe Mathieu-Daudé wrote: > On 20/10/22 11:16, Laurent Vivier wrote: > > Use QIOChannel, QIOChannelSocket and QIONetListener. > > This allows net/stream to use all the available parameters provided by > > SocketAddress. > > > > Signed-off-by: Laurent V

Re: [PATCH for-4.17 1/6] test/vpci: add dummy cfcheck define

2022-10-20 Thread Anthony PERARD
On Thu, Oct 20, 2022 at 11:46:44AM +0200, Roger Pau Monne wrote: > Some vpci functions got the cfcheck attribute added, but that's not > defined in the user-space test harness, so add a dummy define in order > for the harness to build. > > Fixes: 4ed7d5525f ('xen/vpci: CFI hardening') > Signed-off

Re: [PATCH for-4.17 2/6] test/vpci: fix vPCI test harness to provide pci_get_pdev()

2022-10-20 Thread Anthony PERARD
On Thu, Oct 20, 2022 at 11:46:45AM +0200, Roger Pau Monne wrote: > Instead of pci_get_pdev_by_domain(), which is no longer present in the > hypervisor. > > While there add parentheses around the define value. > > Fixes: a37f9ea7a6 ('PCI: fold pci_get_pdev{,_by_domain}()') > Signed-off-by: Roger P

Re: Intended behavior/usage of SSBD setting

2022-10-20 Thread Jan Beulich
On 20.10.2022 14:37, Roger Pau Monné wrote: > On Thu, Oct 20, 2022 at 01:22:20PM +0200, Jan Beulich wrote: >> On 20.10.2022 13:01, Roger Pau Monné wrote: >>> Hello, >>> >>> As part of some follow up improvements to my VIRT_SPEC_CTRL series we >>> have been discussing what the usage of SSBD should b

Re: Policy: A release acks for the release manager's patches (was Re: [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init())

2022-10-20 Thread Julien Grall
Hi Jan, On 20/10/2022 14:12, Jan Beulich wrote: On 19.10.2022 17:28, George Dunlap wrote: On Tue, Oct 18, 2022 at 3:24 PM Henry Wang wrote: Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area when the domain is created. Considering the worst case of page tables which require

Re: [PATCH v12 16/17] tests/qtest: netdev: test stream and dgram backends

2022-10-20 Thread Philippe Mathieu-Daudé
On 20/10/22 11:16, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- tests/qtest/meson.build | 1 + tests/qtest/netdev-socket.c | 417 2 files changed, 418 insertions(+) create mode 100644 tests/qtest/netdev-soc

Xen RTDS scheduler locking

2022-10-20 Thread Juergen Gross
Looking at test failures with RTDS scheduler in Xen [1] I think I've found a major issue with locking in the RTDS scheduler: svc->flags seems to be not protected properly, as different locks are used when doing non-atomic updates: prv->lock (the RTDS global lock), or the per-scheduler-resource sc

Re: [PATCH for-4.17?] test/vpci: enable by default

2022-10-20 Thread Anthony PERARD
On Thu, Oct 20, 2022 at 10:30:26AM +, Henry Wang wrote: > Hi Roger, > > > -Original Message- > > From: Roger Pau Monne > > Subject: [PATCH for-4.17?] test/vpci: enable by default > > > > CONFIG_HAS_PCI is not defined for the tools build, and as a result the > > vpci harness would nev

Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()

2022-10-20 Thread Juergen Gross
On 20.10.22 15:16, Jan Beulich wrote: On 20.10.2022 13:37, Juergen Gross wrote: Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr accesses") introduced code resulting in a warning issued by the smatch static checker, claiming to use an uninitialized variable. This is a false p

Re: Intended behavior/usage of SSBD setting

2022-10-20 Thread Roger Pau Monné
On Thu, Oct 20, 2022 at 03:25:38PM +0200, Jan Beulich wrote: > On 20.10.2022 14:37, Roger Pau Monné wrote: > > On Thu, Oct 20, 2022 at 01:22:20PM +0200, Jan Beulich wrote: > >> On 20.10.2022 13:01, Roger Pau Monné wrote: > >>> Hello, > >>> > >>> As part of some follow up improvements to my VIRT_SPE

[xen-unstable-smoke test] 174131: tolerable all pass - PUSHED

2022-10-20 Thread osstest service owner
flight 174131 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174131/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller is described in DT

2022-10-20 Thread Oleksandr Tyshchenko
On 20.10.22 11:24, Xenia Ragiadakou wrote: > On 10/19/22 22:41, Oleksandr Tyshchenko wrote: > > Hi Oleksandr Hello Xenia > >> >> On 19.10.22 11:47, Xenia Ragiadakou wrote: >> >> Hello Xenia >> >>> On 10/19/22 03:58, Stefano Stabellini wrote: On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote

Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()

2022-10-20 Thread Boris Ostrovsky
On 10/20/22 9:34 AM, Juergen Gross wrote: On 20.10.22 15:16, Jan Beulich wrote: On 20.10.2022 13:37, Juergen Gross wrote: Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr accesses") introduced code resulting in a warning issued by the smatch static checker, claiming to use

Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()

2022-10-20 Thread Juergen Gross
On 20.10.22 16:22, Boris Ostrovsky wrote: On 10/20/22 9:34 AM, Juergen Gross wrote: On 20.10.22 15:16, Jan Beulich wrote: On 20.10.2022 13:37, Juergen Gross wrote: Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr accesses") introduced code resulting in a warning issued by t

Re: [PATCH] Use direct I/O for loop devices

2022-10-20 Thread Marek Marczykowski-Górecki
On Wed, Aug 17, 2022 at 04:46:34PM -0400, Demi Marie Obenour wrote: > This is a huge performance improvement for two reasons: > > 1. It uses the filesystem’s asynchronous I/O support, rather than using >synchronous I/O. > 2. It bypasses the page cache, removing a redundant layer of caching and

[xen-4.16-testing bisection] complete test-armhf-armhf-libvirt-raw

2022-10-20 Thread osstest service owner
branch xen-4.16-testing xenbranch xen-4.16-testing job test-armhf-armhf-libvirt-raw testid debian-di-install Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmwa

Re: [PATCH v12 16/17] tests/qtest: netdev: test stream and dgram backends

2022-10-20 Thread Laurent Vivier
On 10/20/22 15:26, Philippe Mathieu-Daudé wrote: On 20/10/22 11:16, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin ---   tests/qtest/meson.build |   1 +   tests/qtest/netdev-socket.c | 417   2 files changed, 418 inserti

Re: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP

2022-10-20 Thread Anthony PERARD
On Tue, Oct 18, 2022 at 08:13:57AM +, Bertrand Marquis wrote: > Hi, > > Gentil ping on this one as it might be a suitable one for 4.17 Yeah, that might be a good bug fix to have. > > On 3 Oct 2022, at 15:42, Peter Hoyes wrote: > > From: Peter Hoyes > > > > The xendomains script uses the o

Re: [PATCH v12 10/17] net: dgram: make dgram_dst generic

2022-10-20 Thread Laurent Vivier
On 10/20/22 13:17, Philippe Mathieu-Daudé wrote: On 20/10/22 11:16, Laurent Vivier wrote: dgram_dst is a sockaddr_in structure. To be able to use it with unix socket, use a pointer to a generic sockaddr structure. Rename it dest_addr, and store socket length in dest_len. Signed-off-by: Laurent

RE: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP

2022-10-20 Thread Henry Wang
Hi, > -Original Message- > From: Anthony PERARD > Subject: Re: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP > > On Tue, Oct 18, 2022 at 08:13:57AM +, Bertrand Marquis wrote: > > Hi, > > > > Gentil ping on this one as it might be a suitable one for 4.17 > > Yeah, tha

Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars

2022-10-20 Thread Olaf Hering
Tue, 18 Oct 2022 21:53:32 -0700 Denton Liu : > On Tue, Oct 18, 2022 at 04:18:21PM +0200, Olaf Hering wrote: > > Maybe the patch description lacks a specific example how the proposed > > change is supposed to be used in your environment. > My patch description says: > Introduce the GRUB_TO

[xen-4.16-testing test] 174070: regressions - FAIL

2022-10-20 Thread osstest service owner
flight 174070 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174070/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle 14 guest-start fail REGR. vs. 172623 test-armhf-arm

Re: Xen RTDS scheduler locking

2022-10-20 Thread Juergen Gross
On 20.10.22 15:26, Juergen Gross wrote: Looking at test failures with RTDS scheduler in Xen [1] I think I've found a major issue with locking in the RTDS scheduler: svc->flags seems to be not protected properly, as different locks are used when doing non-atomic updates: prv->lock (the RTDS globa

  1   2   >