On 19/10/2022 16:49, Michal Orzel wrote:
Hi Ayan,
Hi Michal,

On 19/10/2022 16:36, Ayan Kumar Halder wrote:

Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to
IGROUPR) is relevant only when the guests run in secure/non-secure mode.
As Xen does not implement security extensions for guests, so the registers
are emulated as read as zero/write ignore.

Signed-off-by: Ayan Kumar Halder <ayank...@amd.com>
---

Observed the issue while running Zephyr on R52.
Also, found that KVM has similar behaviour.

  xen/arch/arm/include/asm/gic.h | 2 ++
  xen/arch/arm/vgic-v3.c         | 4 ++++
  2 files changed, 6 insertions(+)

diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h
index 76e3fa5dc4..998dd62651 100644
--- a/xen/arch/arm/include/asm/gic.h
+++ b/xen/arch/arm/include/asm/gic.h
@@ -48,6 +48,8 @@
  #define GICD_ICFGR1     (0xC04)
  #define GICD_ICFGR2     (0xC08)
  #define GICD_ICFGRN     (0xCFC)
+#define GICD_IGRPMODR   (0xD00)
+#define GICD_IGRPMODRN  (0xD7C)
These registers are GICv3 specific and as such should be defined
in arch/arm/include/asm/gic_v3_defs.h.

Thanks for pointing out. I have fixed this in v2.

- Ayan


~Michal

Reply via email to