Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Peter Zijlstra
On Wed, Aug 31, 2022 at 11:19:48AM +0100, Mel Gorman wrote: > It's also unclear *who* would enable this. It looks like it would mostly > have value during the development stage of an embedded platform to track > kernel memory usage on a per-application basis in an environment where it > may be dif

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Peter Zijlstra
On Wed, Aug 31, 2022 at 11:59:41AM -0400, Kent Overstreet wrote: > Also, ftrace can drop events. Not really ideal if under system load your > memory > accounting numbers start to drift. You could attach custom handlers to tracepoints. If you were to replace these unconditional code hooks of your

Re: [RFC PATCH 27/30] Code tagging based latency tracking

2022-09-01 Thread Peter Zijlstra
On Tue, Aug 30, 2022 at 02:49:16PM -0700, Suren Baghdasaryan wrote: > From: Kent Overstreet > > This adds the ability to easily instrument code for measuring latency. > To use, add the following to calls to your code, at the start and end of > the event you wish to measure: > > code_tag_time_s

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Michal Hocko
On Wed 31-08-22 15:01:54, Kent Overstreet wrote: > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > > On Wed 31-08-22 11:19:48, Mel Gorman wrote: > > > Whatever asking for an explanation as to why equivalent functionality > > > cannot not be created from ftrace/kprobe/eBPF/whatever i

Re: Enable audio virtualization in Xen

2022-09-01 Thread SHARMA, JYOTIRMOY
[AMD Official Use Only - General] Hi Oleksandr, Christopher and others, I am trying to enable audio playback from HVM guest as per discussion above using ALSA as back end. I have compiled and installed libxenbe (https://github.com/xen-troops/libxenbe) and snd_be (https://github.com/xen-troops/

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Daniel Bristot de Oliveira
On 9/1/22 09:05, Peter Zijlstra wrote: >> Also, ftrace can drop events. Not really ideal if under system load your >> memory >> accounting numbers start to drift. > You could attach custom handlers to tracepoints. If you were to replace > these unconditional code hooks of yours with tracepoints th

Re: [RFC PATCH 10/30] mm: enable page allocation tagging for __get_free_pages and alloc_pages

2022-09-01 Thread Peter Zijlstra
On Wed, Aug 31, 2022 at 01:46:29PM -0400, Kent Overstreet wrote: > Because all the counters are statically allocated, without even a pointer > deref > to get to them in the allocation path (one pointer deref to get to them in the > deallocate path), that makes this _much, much_ cheaper than anyth

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Peter Zijlstra
On Thu, Sep 01, 2022 at 09:05:36AM +0200, Peter Zijlstra wrote: > On Wed, Aug 31, 2022 at 11:59:41AM -0400, Kent Overstreet wrote: > > > Also, ftrace can drop events. Not really ideal if under system load your > > memory > > accounting numbers start to drift. > > You could attach custom handlers

Re: [PATCH v11 0/6] populate/unpopulate memory when domain on static allocation

2022-09-01 Thread Julien Grall
Hi Stefano, On 31/08/2022 23:44, Stefano Stabellini wrote: I looked at the series and patches 1-5 are ready to be committed. Patch 6 needs an Ack, preferably from Jan as Jan had questions on this patch in v9. I plan to commit patches 1-5 in the next couple of days (and ideally patch 6 too if a

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread David Hildenbrand
On 31.08.22 21:01, Kent Overstreet wrote: > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: >> On Wed 31-08-22 11:19:48, Mel Gorman wrote: >>> Whatever asking for an explanation as to why equivalent functionality >>> cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable

[ovmf test] 172906: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172906 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172906/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [RFC PATCH 22/30] Code tagging based fault injection

2022-09-01 Thread Dmitry Vyukov
On Wed, 31 Aug 2022 at 19:30, Kent Overstreet wrote: > > > From: Kent Overstreet > > > > > > This adds a new fault injection capability, based on code tagging. > > > > > > To use, simply insert somewhere in your code > > > > > > dynamic_fault("fault_class_name") > > > > > > and check whether i

Re: Enable audio virtualization in Xen

2022-09-01 Thread SHARMA, JYOTIRMOY
[AMD Official Use Only - General] Hi all, Forgot to mention that I am able to play audio from HVM guest with Pulse Audio as back end. Here is the corresponding HVM configuration: vsnd = [[ 'card, backend=Domain-0, buffer-size=65536, short-name=VCard, long-name=Virtual sound card, sample-rates=

[xen-unstable test] 172901: tolerable FAIL - PUSHED

2022-09-01 Thread osstest service owner
flight 172901 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172901/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 buil

[PATCH v3 0/7] xen/evtchn: implement static event channel signaling

2022-09-01 Thread Rahul Singh
The purpose of this patch series is to add the static event channel signaling support to Xen on Arm based on design doc [1]. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-05/msg01160.html Julien Grall (1): xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated R

[PATCH v3 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated

2022-09-01 Thread Rahul Singh
From: Julien Grall Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event channels code assumes that all the buckets below d->valid_evtchns are always allocated. This assumption hold in most of the situation because a guest is not allowed to chose the port. Instead, it will be t

[PATCH v3 2/7] xen/evtchn: Add an helper to reserve/allocate a port

2022-09-01 Thread Rahul Singh
In a follow-up patch we will want to either reserve or allocate a port for various event channel helpers. A new wrapper is introduced to either reserve a given port or allocate a fresh one if zero. Take the opportunity to replace the open-coded version in evtchn_bind_virq(). Signed-off-by: Stani

[PATCH v3 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs

2022-09-01 Thread Rahul Singh
Restrict the maximum number of evtchn supported for domUs to avoid allocating a large amount of memory in Xen. Set the default value of max_evtchn_port to 1023. The value of 1023 should be sufficient for domUs guests because on ARM we don't bind physical interrupts to event channels. The only use

[PATCH v3 6/7] xen/arm: introduce xen-evtchn dom0less property

2022-09-01 Thread Rahul Singh
Introduce a new sub-node under /chosen node to establish static event channel communication between domains on dom0less systems. An event channel will be created beforehand to allow the domains to send notifications to each other. Signed-off-by: Rahul Singh --- Changes in v3: - use device-tree

[PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value

2022-09-01 Thread Rahul Singh
Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to disable xenstore interface for dom0less guests. Signed-off-by: Rahul Singh --- Changes in v3: - new patch in this version --- docs/misc/arm/device-tree/booting.txt | 4 xen/arch/arm/domain_build.c | 10 +

[PATCH v3 5/7] xen/evtchn: modify evtchn_bind_interdomain to support static evtchn

2022-09-01 Thread Rahul Singh
Static event channel support will be added for dom0less domains. Modify evtchn_bind_interdomain to support static evtchn. It is necessary to have access to the evtchn_bind_interdomain function to do that, so make evtchn_bind_interdomain global and also make it __must_check. Currently evtchn_bind_

[PATCH v3 4/7] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port

2022-09-01 Thread Rahul Singh
Currently evtchn_alloc_unbound() always allocates the next available port. Static event channel support for dom0less domains requires allocating a specified port. Modify the evtchn_alloc_unbound() to accept the port number as an argument and allocate the specified port if available. If the port nu

Re: [PATCH v3 2/7] xen/evtchn: Add an helper to reserve/allocate a port

2022-09-01 Thread Julien Grall
Hi Rahul, On 01/09/2022 10:13, Rahul Singh wrote: In a follow-up patch we will want to either reserve or allocate a port for various event channel helpers. A new wrapper is introduced to either reserve a given port or allocate a fresh one if zero. Take the opportunity to replace the open-coded

Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations

2022-09-01 Thread Xenia Ragiadakou
On 9/1/22 01:35, Stefano Stabellini wrote: Patches 1, 4, and 6 are already committed. I plan to commit patches 2, 3 and 5 in the next couple of days. Patch 7 needs further discussions and it is best addressed during the next MISRA C sync-up. I would like to share here, before the next MISRA

[PATCH v3 0/2] xen/pci: implement is_memory_hole for ARM

2022-09-01 Thread Rahul Singh
This patch series is to implement something like is_memory_hole function for ARM. Rahul Singh (2): xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev xen/pci: replace call to is_memory_hole to pci_check_bar xen/arch/arm/include/asm/pci.h | 5 +++- xen/arch/arm/pci/pci

[PATCH v3 1/2] xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev

2022-09-01 Thread Rahul Singh
Modify pci_find_host_bridge_node argument to const pdev to avoid converting the dev to pdev in pci_find_host_bridge_node and also constify the return. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Oleksandr Tyshchenko --- Changes in v3: - no changes --- xen/arch/arm/inc

[PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-01 Thread Rahul Singh
is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementation for ARM which is required for PCI passthrough. On x86, pci_check_bar will call is_memo

Re: [PATCH v3 2/7] xen/evtchn: Add an helper to reserve/allocate a port

2022-09-01 Thread Rahul Singh
Hi Julien, > On 1 Sep 2022, at 10:27 am, Julien Grall wrote: > > Hi Rahul, > > On 01/09/2022 10:13, Rahul Singh wrote: >> In a follow-up patch we will want to either reserve or allocate a port >> for various event channel helpers. >> A new wrapper is introduced to either reserve a given port or

Re: [PATCH 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message

2022-09-01 Thread Rahul Singh
Hi Julien, > On 24 Aug 2022, at 3:58 pm, Julien Grall wrote: > > Hi Rahul, > > On 24/08/2022 14:53, Rahul Singh wrote: >> Backport Linux commit dc898eb84b25c39ea46f28c48a169bdbd0e2c7e0 >> iommu/arm-smmu-v3: Fix l1 stream table size in the error message > > We have a tag for this (see Origin).

[linux-linus test] 172902: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172902 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172902/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172133 build-arm64-libvirt

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Mel Gorman
On Wed, Aug 31, 2022 at 11:59:41AM -0400, Kent Overstreet wrote: > On Wed, Aug 31, 2022 at 11:19:48AM +0100, Mel Gorman wrote: > > On Wed, Aug 31, 2022 at 04:42:30AM -0400, Kent Overstreet wrote: > > > On Wed, Aug 31, 2022 at 09:38:27AM +0200, Peter Zijlstra wrote: > > > > On Tue, Aug 30, 2022 at 0

Re: [PATCH v3 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-09-01 Thread Andrew Cooper
On 16/08/2022 11:13, Juergen Gross wrote: > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c > index f6eed88930..228470ac41 100644 > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -3237,6 +3237,75 @@ out: > return ret; > } > > +/* > + * Allocate all memory

[ovmf test] 172909: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172909 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172909/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH v3 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-09-01 Thread Juergen Gross
On 01.09.22 13:17, Andrew Cooper wrote: On 16/08/2022 11:13, Juergen Gross wrote: diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index f6eed88930..228470ac41 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3237,6 +3237,75 @@ out: return ret; } +/

Re: [PATCH v3 3/3] xen/sched: fix cpu hotplug

2022-09-01 Thread Andrew Cooper
On 01/09/2022 07:11, Juergen Gross wrote: > On 01.09.22 00:52, Andrew Cooper wrote: >> On 16/08/2022 11:13, Juergen Gross wrote: >>> Cpu cpu unplugging is calling schedule_cpu_rm() via stop_machine_run() >> >> Cpu cpu. >> >>> with interrupts disabled, thus any memory allocation or freeing must >>>

Re: [PATCH v3 3/3] xen/sched: fix cpu hotplug

2022-09-01 Thread Juergen Gross
On 01.09.22 14:01, Andrew Cooper wrote: On 01/09/2022 07:11, Juergen Gross wrote: On 01.09.22 00:52, Andrew Cooper wrote: On 16/08/2022 11:13, Juergen Gross wrote: Cpu cpu unplugging is calling schedule_cpu_rm() via stop_machine_run() Cpu cpu. with interrupts disabled, thus any memory allo

[libvirt test] 172907: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172907 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172907/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v3 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated

2022-09-01 Thread Michal Orzel
Hi Rahul, On 01/09/2022 11:13, Rahul Singh wrote: > > From: Julien Grall > > Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event > channels code assumes that all the buckets below d->valid_evtchns are > always allocated. > > This assumption hold in most of the situation bec

Re: [PATCH v3 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated

2022-09-01 Thread Rahul Singh
Hi Michal, > On 1 Sep 2022, at 1:47 pm, Michal Orzel wrote: > > Hi Rahul, > > On 01/09/2022 11:13, Rahul Singh wrote: >> >> From: Julien Grall >> >> Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event >> channels code assumes that all the buckets below d->valid_evtchns ar

Re: [PATCH] acpi: Add TPM2 interface definition and make the TPM version configurable.

2022-09-01 Thread Jason Andryuk
On Tue, Aug 30, 2022 at 4:30 PM Jennifer Herbert wrote: > > This patch introduces an optional TPM 2 interface definition to the ACPI > table, > which is to be used as part of a vTPM 2 implementation. > To enable the new interface - I have made the TPM interface version > configurable in the acpi_

Re: [PATCH] xen-pcifront: Handle missed Connected state

2022-09-01 Thread Jason Andryuk
On Wed, Aug 31, 2022 at 10:35 PM Rich Persaud wrote: > > On Aug 29, 2022, at 11:16 AM, Jason Andryuk wrote: > > > > An HVM guest with linux stubdom and 2 PCI devices failed to start as > > libxl timed out waiting for the PCI devices to be added. It happens > > intermittently but with some regul

Re: [PATCH v11 5/6] xen: rename free_staticmem_pages to unprepare_staticmem_pages

2022-09-01 Thread Julien Grall
Hi Penny, On 31/08/2022 03:40, Penny Zheng wrote: The name of free_staticmem_pages is inappropriate, considering it is the opposite of function prepare_staticmem_pages. Rename free_staticmem_pages to unprepare_staticmem_pages. Signed-off-by: Penny Zheng Acked-by: Jan Beulich Reviewed-by: J

[linux-5.4 test] 172904: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172904 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172904/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172128 build-amd64-libvirt

Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Bertrand Marquis
Hi, > On 1 Sep 2022, at 02:03, Henry Wang wrote: > > Hi Arm maintainers, > >> -Original Message- >> Hi Henry, >> >> On 30/08/2022 08:11, Henry Wang wrote: >>> >>> Hi Michal, >>> >>> Sorry about the late reply - I had a couple of days off. Thank you very >>> much for the review! I wil

Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations

2022-09-01 Thread Bertrand Marquis
Hi Xenia, > On 1 Sep 2022, at 10:27, Xenia Ragiadakou wrote: > > > On 9/1/22 01:35, Stefano Stabellini wrote: >> Patches 1, 4, and 6 are already committed. I plan to commit patches 2, 3 >> and 5 in the next couple of days. >> Patch 7 needs further discussions and it is best addressed during the

RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Henry Wang
Hi Bertrand, > -Original Message- > From: Bertrand Marquis > > On 1 Sep 2022, at 02:03, Henry Wang wrote: > > > > Hi Arm maintainers, > > > >> -Original Message- > >> Hi Henry, > >> > >> On 30/08/2022 08:11, Henry Wang wrote: > >>> > >>> Hi Michal, > >>> > >>> Sorry about the lat

Re: [PATCH v11 6/6] xen: retrieve reserved pages on populate_physmap

2022-09-01 Thread Julien Grall
Hi Penny, On 31/08/2022 03:40, Penny Zheng wrote: +/* + * Acquire a page from reserved page list(resv_page_list), when populating + * memory for static domain on runtime. + */ +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) +{ +struct page_info *page; + +ASSERT_ALLO

Re: [PATCH v3 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs

2022-09-01 Thread Michal Orzel
Hi Rahul, On 01/09/2022 11:13, Rahul Singh wrote: > > Restrict the maximum number of evtchn supported for domUs to avoid > allocating a large amount of memory in Xen. > > Set the default value of max_evtchn_port to 1023. The value of 1023 > should be sufficient for domUs guests because on ARM we

Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Julien Grall
On 30/08/2022 02:04, Stefano Stabellini wrote: size_t estimate_efi_size(unsigned int mem_nr_banks); diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 500307edc0..fe76cf6325 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -73,6 +73,8 @@ integer_param("xenheap_mega

RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > >> +paddr_t reserved_heap_start = ~0, reserved_heap_end = 0, > > > > INVALID_PADDR or ~0ULL > > I would strongly prefer the former. It is more difficult to understand > what's the value means in the latter. Thanks for the input.

Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Julien Grall
On 01/09/2022 15:01, Henry Wang wrote: Hi Julien, -Original Message- From: Julien Grall +paddr_t reserved_heap_start = ~0, reserved_heap_end = 0, INVALID_PADDR or ~0ULL I would strongly prefer the former. It is more difficult to understand what's the value means in the latt

Re: [PATCH 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message

2022-09-01 Thread Julien Grall
On 01/09/2022 11:27, Rahul Singh wrote: Hi Julien, Hi Rahul, On 24 Aug 2022, at 3:58 pm, Julien Grall wrote: Hi Rahul, On 24/08/2022 14:53, Rahul Singh wrote: Backport Linux commit dc898eb84b25c39ea46f28c48a169bdbd0e2c7e0 iommu/arm-smmu-v3: Fix l1 stream table size in the error message

Re: [PATCH] xen/arm: Add xen/arch/arm/efi/stub.c in .gitignore

2022-09-01 Thread Bertrand Marquis
Hi Julien, This one passed through my filtering, sorry for that. > On 12 Aug 2022, at 20:19, Julien Grall wrote: > > From: Julien Grall > > Xen build system the symbolic link xen/arch/arm/efi/stub.c. So we want > to ignore it. > > Fixes: 7f96859b0d00 ("xen: reuse x86 EFI stub functions for A

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 10:05:03AM +0200, David Hildenbrand wrote: > On 31.08.22 21:01, Kent Overstreet wrote: > > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > >> On Wed 31-08-22 11:19:48, Mel Gorman wrote: > >>> Whatever asking for an explanation as to why equivalent functionali

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 09:00:17AM +0200, Peter Zijlstra wrote: > On Wed, Aug 31, 2022 at 11:19:48AM +0100, Mel Gorman wrote: > > > It's also unclear *who* would enable this. It looks like it would mostly > > have value during the development stage of an embedded platform to track > > kernel memor

Re: [RFC PATCH 03/30] Lazy percpu counters

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 08:51:31AM +0200, Peter Zijlstra wrote: > On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > > +static void lazy_percpu_counter_switch_to_pcpu(struct > > raw_lazy_percpu_counter *c) > > +{ > > + u64 __percpu *pcpu_v = alloc_percpu_gfp(u64, GFP_ATOMIC|__

Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-09-01 Thread Julien Grall
Hi Henry, On 24/08/2022 08:31, Henry Wang wrote: This commit introduces the reserved heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. A new boolean field `xen_heap` in `struct membank` is added to store the configuration telling if the memory bank is reser

Re: [RFC PATCH 27/30] Code tagging based latency tracking

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 09:11:17AM +0200, Peter Zijlstra wrote: > On Tue, Aug 30, 2022 at 02:49:16PM -0700, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > This adds the ability to easily instrument code for measuring latency. > > To use, add the following to calls to your code, at th

Re: [RFC PATCH 03/30] Lazy percpu counters

2022-09-01 Thread Steven Rostedt
On Thu, 1 Sep 2022 10:32:19 -0400 Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 08:51:31AM +0200, Peter Zijlstra wrote: > > On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > > > +static void lazy_percpu_counter_switch_to_pcpu(struct > > > raw_lazy_percpu_counter *c) > >

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread David Hildenbrand
On 01.09.22 16:23, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 10:05:03AM +0200, David Hildenbrand wrote: >> On 31.08.22 21:01, Kent Overstreet wrote: >>> On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: On Wed 31-08-22 11:19:48, Mel Gorman wrote: > Whatever asking for an

Push 4.17 Feature freeze and Code freeze one week later

2022-09-01 Thread Bertrand Marquis
Hi, Seeing that we have lots of series quite advanced in review but not already merged, could we push both Feature freeze and Code freeze deadline one week later to have a chance to finish those ? Cheers Bertrand

Re: [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent

2022-09-01 Thread Marek Marczykowski-Górecki
On Wed, Aug 31, 2022 at 05:08:17PM +, SeongJae Park wrote: > On Wed, 31 Aug 2022 16:58:21 + SeongJae Park wrote: > > > Changes from v1 > > (https://lore.kernel.org/xen-devel/20220825161511.94922-1...@kernel.org/) > > - Fix the wrong feature_persistent caching position of blkfront > > - Se

Re: [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent

2022-09-01 Thread Juergen Gross
On 31.08.22 18:58, SeongJae Park wrote: Changes from v1 (https://lore.kernel.org/xen-devel/20220825161511.94922-1...@kernel.org/) - Fix the wrong feature_persistent caching position of blkfront - Set blkfront's feature_persistent field setting with simple '&&' instead of 'if' (Pratyush Yadav)

[qemu-mainline test] 172905: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172905 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172905/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123 build-i386-libvir

[ovmf test] 172912: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172912 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172912/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Julien Grall
Hi Henry, On 24/08/2022 08:31, Henry Wang wrote: This commit firstly adds a global variable `reserved_heap`. This newly introduced global variable is set at the device tree parsing time if the reserved heap ranges are defined in the device tree chosen node. For Arm32, In `setup_mm`, if the rese

Re: Push 4.17 Feature freeze and Code freeze one week later

2022-09-01 Thread Stefano Stabellini
On Thu, 1 Sep 2022, Bertrand Marquis wrote: > Hi, > > Seeing that we have lots of series quite advanced in review but not already > merged, could we push > both Feature freeze and Code freeze deadline one week later to have a chance > to finish those ? +1 On the ARM side we have a higher-than-

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Suren Baghdasaryan
On Thu, Sep 1, 2022 at 12:18 AM Michal Hocko wrote: > > On Wed 31-08-22 15:01:54, Kent Overstreet wrote: > > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > > > On Wed 31-08-22 11:19:48, Mel Gorman wrote: > > > > Whatever asking for an explanation as to why equivalent functionality

[PATCH] xen/grants: prevent integer overflow in gnttab_dma_alloc_pages()

2022-09-01 Thread Dan Carpenter
The change from kcalloc() to kvmalloc() means that arg->nr_pages might now be large enough that the "args->nr_pages << PAGE_SHIFT" can result in an integer overflow. Fixes: b3f7931f5c61 ("xen/gntdev: switch from kcalloc() to kvcalloc()") Signed-off-by: Dan Carpenter --- drivers/xen/grant-table.c

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Suren Baghdasaryan
On Thu, Sep 1, 2022 at 8:07 AM David Hildenbrand wrote: > > On 01.09.22 16:23, Kent Overstreet wrote: > > On Thu, Sep 01, 2022 at 10:05:03AM +0200, David Hildenbrand wrote: > >> On 31.08.22 21:01, Kent Overstreet wrote: > >>> On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > On

Re: [PATCH v6 1/9] xen/arm: introduce static shared memory

2022-09-01 Thread Julien Grall
Hi Penny, On 29/08/2022 07:57, Penny Zheng wrote: -Original Message- From: Julien Grall Sent: Friday, August 26, 2022 9:17 PM To: Penny Zheng ; xen-devel@lists.xenproject.org Cc: Stefano Stabellini ; Bertrand Marquis ; Volodymyr Babchuk Subject: Re: [PATCH v6 1/9] xen/arm: introduce st

Re: [RFC PATCH 03/30] Lazy percpu counters

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 10:48:39AM -0400, Steven Rostedt wrote: > On Thu, 1 Sep 2022 10:32:19 -0400 > Kent Overstreet wrote: > > > On Thu, Sep 01, 2022 at 08:51:31AM +0200, Peter Zijlstra wrote: > > > On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > > > > +static void lazy_

Re: [PATCH v6 1/9] xen/arm: introduce static shared memory

2022-09-01 Thread Bertrand Marquis
Hi, > On 1 Sep 2022, at 16:40, Julien Grall wrote: > > Hi Penny, > > On 29/08/2022 07:57, Penny Zheng wrote: >>> -Original Message- >>> From: Julien Grall >>> Sent: Friday, August 26, 2022 9:17 PM >>> To: Penny Zheng ; xen-devel@lists.xenproject.org >>> Cc: Stefano Stabellini ; Bertran

RE: Push 4.17 Feature freeze and Code freeze one week later

2022-09-01 Thread Henry Wang
Hi Bertrand, > -Original Message- > From: Bertrand Marquis > Subject: Push 4.17 Feature freeze and Code freeze one week later > > Hi, > > Seeing that we have lots of series quite advanced in review but not already > merged, could we push > both Feature freeze and Code freeze deadline on

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 05:07:06PM +0200, David Hildenbrand wrote: > Skimming over the patches (that I was CCed on) and skimming over the > cover letter, I got the impression that everything after patch 7 is > introducing something new instead of refactoring something out. You skimmed over the dyn

RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Henry Wang
Hi Julien, Thanks for your review. > -Original Message- > From: Julien Grall > Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and > heap allocator > > Hi Henry, > > On 24/08/2022 08:31, Henry Wang wrote: > > This commit firstly adds a global variable `reserved_hea

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 12:05:01PM +0100, Mel Gorman wrote: > As pointed out elsewhere, attaching to the tracepoint and recording relevant > state is an option other than trying to parse a raw ftrace feed. For memory > leaks, there are already tracepoints for page allocation and free that could > b

RE: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Stefano Stabellini
On Thu, 1 Sep 2022, Henry Wang wrote: > > -Original Message- > > From: Julien Grall > > Subject: Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and > > heap allocator > > > > Hi Henry, > > > > On 24/08/2022 08:31, Henry Wang wrote: > > > This commit firstly adds a global var

Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-01 Thread Oleksandr
On 01.09.22 12:29, Rahul Singh wrote: Hello Rahul is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementation for ARM which is required for P

Re: [PATCH v6 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated

2022-09-01 Thread Julien Grall
Hi Penny, On 21/07/2022 14:21, Penny Zheng wrote: Borrower domain will fail to get a page ref using the owner domain during allocation, when the owner is created after borrower. So here, we decide to get and add the right amount of reference, which is the number of borrowers, when the owner is

Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Julien Grall
Hi Henry, On 01/09/2022 17:05, Henry Wang wrote: @@ -755,17 +779,21 @@ static void __init setup_mm(void) do { -e = consider_modules(ram_start, ram_end, +e = !reserved_heap ? +consider_modules(ram_start, ram_end, pfn_to_pa

Re: [PATCH 2/2] xen/arm: Handle reserved heap pages in boot and heap allocator

2022-09-01 Thread Julien Grall
Hi Stefano, On 01/09/2022 18:08, Stefano Stabellini wrote: Also, what happen with UEFI? Is it easy to guarantee the region will not be used? For now I think it is not easy to guarantee that, do you have some ideas in mind? I think I can follow this in above follow-up series to improve things.

Re: [PATCH v3 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs

2022-09-01 Thread Julien Grall
Hi, On 01/09/2022 14:53, Michal Orzel wrote: On 01/09/2022 11:13, Rahul Singh wrote: Restrict the maximum number of evtchn supported for domUs to avoid allocating a large amount of memory in Xen. Set the default value of max_evtchn_port to 1023. The value of 1023 should be sufficient for domU

Re: [PATCH v3 6/7] xen/arm: introduce xen-evtchn dom0less property

2022-09-01 Thread Julien Grall
Hi Rahul, On 01/09/2022 10:13, Rahul Singh wrote: Introduce a new sub-node under /chosen node to establish static event channel communication between domains on dom0less systems. An event channel will be created beforehand to allow the domains to send notifications to each other. Signed-off-by

Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value

2022-09-01 Thread Julien Grall
Hi Rahul, On 01/09/2022 10:13, Rahul Singh wrote: Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to disable xenstore interface for dom0less guests. Signed-off-by: Rahul Singh --- Changes in v3: - new patch in this version --- docs/misc/arm/device-tree/booting.txt | 4

Re: [RFC PATCH 03/30] Lazy percpu counters

2022-09-01 Thread Peter Zijlstra
On Thu, Sep 01, 2022 at 10:32:19AM -0400, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 08:51:31AM +0200, Peter Zijlstra wrote: > > On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > > > +static void lazy_percpu_counter_switch_to_pcpu(struct > > > raw_lazy_percpu_counter *c)

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Michal Hocko
On Thu 01-09-22 08:33:19, Suren Baghdasaryan wrote: > On Thu, Sep 1, 2022 at 12:18 AM Michal Hocko wrote: [...] > > So I find Peter's question completely appropriate while your response to > > that not so much! Maybe ftrace is not the right tool for the intented > > job. Maybe there are other ways

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Suren Baghdasaryan
On Thu, Sep 1, 2022 at 12:15 PM Michal Hocko wrote: > > On Thu 01-09-22 08:33:19, Suren Baghdasaryan wrote: > > On Thu, Sep 1, 2022 at 12:18 AM Michal Hocko wrote: > [...] > > > So I find Peter's question completely appropriate while your response to > > > that not so much! Maybe ftrace is not th

[ovmf test] 172917: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172917 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172917/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 12:39:11PM -0700, Suren Baghdasaryan wrote: > kmemleak is known to be slow and it's even documented [1], so I hope I > can skip that part. For page_owner to provide the comparable > information we would have to capture the call stacks for all page > allocations unlike our pr

Re: [RFC PATCH 27/30] Code tagging based latency tracking

2022-09-01 Thread Steven Rostedt
On Tue, 30 Aug 2022 14:49:16 -0700 Suren Baghdasaryan wrote: > From: Kent Overstreet > > This adds the ability to easily instrument code for measuring latency. > To use, add the following to calls to your code, at the start and end of > the event you wish to measure: > > code_tag_time_stats_

Re: [RFC PATCH 27/30] Code tagging based latency tracking

2022-09-01 Thread Steven Rostedt
On Thu, 1 Sep 2022 17:38:44 -0400 Steven Rostedt wrote: > # echo 'hist:keys=comm,prio,delta.buckets=10:sort=delta' > > /sys/kernel/tracing/events/synthetic/wakeup_lat/trigger The above could almost be done with sqlhist (but I haven't implemented "buckets=10" yet because that's a new feature. B

Re: [RFC PATCH 27/30] Code tagging based latency tracking

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 05:38:44PM -0400, Steven Rostedt wrote: > On Tue, 30 Aug 2022 14:49:16 -0700 > Suren Baghdasaryan wrote: > > > From: Kent Overstreet > > > > This adds the ability to easily instrument code for measuring latency. > > To use, add the following to calls to your code, at the

[linux-linus test] 172911: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172911 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172911/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172133 build-arm64-libvirt

Re: [RFC PATCH 27/30] Code tagging based latency tracking

2022-09-01 Thread Steven Rostedt
On Thu, 1 Sep 2022 17:54:38 -0400 Kent Overstreet wrote: > > So this looks like it's gotten better since I last looked, but it's still not > there yet. > > Part of the problem is that the tracepoints themselves are in the wrong place: > your end event is when a task is woken up, but that means s

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 03:27:27PM -0700, Roman Gushchin wrote: > On Wed, Aug 31, 2022 at 01:56:08PM -0700, Yosry Ahmed wrote: > > This is very interesting work! Do you have any data about the overhead > > this introduces, especially in a production environment? I am > > especially interested in me

Re: [RFC PATCH 27/30] Code tagging based latency tracking

2022-09-01 Thread Kent Overstreet
On Thu, Sep 01, 2022 at 06:34:30PM -0400, Steven Rostedt wrote: > On Thu, 1 Sep 2022 17:54:38 -0400 > Kent Overstreet wrote: > > > > So this looks like it's gotten better since I last looked, but it's still > > not > > there yet. > > > > Part of the problem is that the tracepoints themselves ar

[xen-unstable test] 172910: tolerable FAIL - PUSHED

2022-09-01 Thread osstest service owner
flight 172910 xen-unstable real [real] flight 172920 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/172910/ http://logs.test-lab.xenproject.org/osstest/logs/172920/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [RFC PATCH 28/30] Improved symbolic error names

2022-09-01 Thread Joe Perches
On Tue, 2022-08-30 at 14:49 -0700, Suren Baghdasaryan wrote: > From: Kent Overstreet > > This patch adds per-error-site error codes, with error strings that > include their file and line number. > > To use, change code that returns an error, e.g. > return -ENOMEM; > to > return -ERR(ENOM

[ovmf test] 172921: regressions - FAIL

2022-09-01 Thread osstest service owner
flight 172921 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172921/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

  1   2   >