[PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Introduce a per-domain read/write lock to check whether vpci is present, so we are sure there are no accesses to the contents of the vpci struct if not. This lock can be used (and in a few cases is used right away) so that vpci removal can be performed while holding

Re: [PATCH] RFC: Version support policy

2022-02-15 Thread Jan Beulich
On 14.02.2022 22:50, George Dunlap wrote: >> On Aug 19, 2021, at 10:18 AM, Jan Beulich wrote: >> On 13.08.2021 13:37, Ian Jackson wrote: >>> The current policy for minimum supported versions of tools, compilers, >>> etc. is unsatisfactory: For many dependencies no minimum version is >>> specified.

Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Roger Pau Monné
On Mon, Feb 14, 2022 at 02:00:26PM +, Oleksandr Andrushchenko wrote: > /* > * FIXME: apply_map is called from dom0 specific init code when > * system_state < SYS_STATE_active, so there is no race condition > * possible between this code and vpci_process_pending. So, neither > * vpci_process_pen

Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 10:30, Roger Pau Monné wrote: > On Mon, Feb 14, 2022 at 02:00:26PM +, Oleksandr Andrushchenko wrote: >> /* >> * FIXME: apply_map is called from dom0 specific init code when >> * system_state < SYS_STATE_active, so there is no race condition >> * possible between this code and vpci

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 10:11, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > @@ -171,8 +173,24 @@ static int __init apply_map(struct domain *d, const > struct pci_dev *pdev, > struct map_data data = { .d = d, .map = true }; > int rc; > > +ASSERT(rw_is_write_locked(&d

Re: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open coding it

2022-02-15 Thread Benjamin Tissoires
On Tue, Feb 15, 2022 at 2:56 AM Qing Wang wrote: > > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. > > Signed-off-by: Wang Qing > Acked-by: Srinivas Pandruvada FWIW, this one is Acked-by: Benjamin Tissoires Wang, is there any plan

Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it

2022-02-15 Thread Benjamin Tissoires
On Tue, Feb 15, 2022 at 2:57 AM Qing Wang wrote: > > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. > > Signed-off-by: Wang Qing > --- Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/input/serio/ps2-gpio.c | 4 ++-- > 1

RE: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open coding it

2022-02-15 Thread 王擎
  >>On Tue, Feb 15, 2022 at 2:56 AM Qing Wang wrote: >> >> From: Wang Qing >> >> Use the helper function time_is_{before,after}_jiffies() to improve >> code readability. >> >> Signed-off-by: Wang Qing >> Acked-by: Srinivas Pandruvada > >FWIW, this one is >Acked-by: Benjamin Tissoires > >Wang,

[linux-5.4 test] 168112: tolerable FAIL - PUSHED

2022-02-15 Thread osstest service owner
flight 168112 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/168112/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 168060 test-amd64-i386-xl-qemut-win7-amd64 19

[PATCH] rwlock: remove unneeded subtraction

2022-02-15 Thread Roger Pau Monne
There's no need to subtract _QR_BIAS from the lock value for storing in the local cnts variable in the read lock slow path: the users of the value in cnts only care about the writer-related bits and use a mask to get the value. Note that further setting of cnts in rspin_until_writer_unlock already

Re: [PATCH V3 1/13] block: xen: use time_is_before_eq_jiffies() instead of open coding it

2022-02-15 Thread Roger Pau Monné
On Mon, Feb 14, 2022 at 05:55:38PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. > > Signed-off-by: Wang Qing Acked-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-15 Thread Jane Malalane
On 15/02/2022 07:09, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 14.02.2022 18:09, Jane Malalane wrote: >> On 14/02/2022 13:18, Jan Beulich wrote: >>> [CAUTION - EXTERNAL

[ovmf test] 168115: all pass - PUSHED

2022-02-15 Thread osstest service owner
flight 168115 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168115/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1193aa2dfbbd11fa7191d000a0cc166d03a249d2 baseline version: ovmf c9b7c6e0cc7da76b74bcd

[PATCH 0/5] Boot time cpupools

2022-02-15 Thread Luca Fancellu
This serie introduces a feature for Xen to create cpu pools at boot time, the feature is enabled using a configurable that is disabled by default. The boot time cpupool feature relies on the device tree to describe the cpu pools. Another feature is introduced by the serie, the possibility to assign

[PATCH 2/5] xen/sched: create public function for cpupools creation

2022-02-15 Thread Luca Fancellu
Create new public function to create cpupools, it checks for pool id uniqueness before creating the pool and can take a scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu --- xen/common/sched/cpupool.c | 26 ++

[PATCH 3/5] xen/sched: retrieve scheduler id by name

2022-02-15 Thread Luca Fancellu
Add a public function to retrieve the scheduler id by the scheduler name. Signed-off-by: Luca Fancellu --- xen/common/sched/core.c | 11 +++ xen/include/xen/sched.h | 11 +++ 2 files changed, 22 insertions(+) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 8

[PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools

2022-02-15 Thread Luca Fancellu
With the introduction of boot time cpupools, Xen can create many different cpupools at boot time other than cpupool with id 0. Since these newly created cpupools can't have an entry in Xenstore, create the entry using xen-init-dom0 helper with the usual convention: Pool-. Given the change, remove

[PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-15 Thread Luca Fancellu
Introduce an architecture specific way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupools for each type of core, but also systems using NUMA can have different cpu pools for each node. The feature

[PATCH 5/5] arm/dom0less: assign dom0less guests to cpupools

2022-02-15 Thread Luca Fancellu
Introduce domain-cpupool property of a xen,domain device tree node, that specifies the cpupool device tree handle of a xen,cpupool node that identifies a cpupool created at boot time where the guest will be assigned on creation. Add member to the xen_arch_domainconfig public interface so the XEN_D

Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-15 Thread Jan Beulich
On 15.02.2022 11:14, Jane Malalane wrote: > On 15/02/2022 07:09, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On 14.02.2022 18:09, Jane Malalane wrote: >>> On 14/02/2022 13

Re: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools

2022-02-15 Thread Juergen Gross
On 15.02.22 11:15, Luca Fancellu wrote: With the introduction of boot time cpupools, Xen can create many different cpupools at boot time other than cpupool with id 0. Since these newly created cpupools can't have an entry in Xenstore, create the entry using xen-init-dom0 helper with the usual co

Re: [PATCH] rwlock: remove unneeded subtraction

2022-02-15 Thread Jan Beulich
On 15.02.2022 10:39, Roger Pau Monne wrote: > There's no need to subtract _QR_BIAS from the lock value for storing > in the local cnts variable in the read lock slow path: the users of > the value in cnts only care about the writer-related bits and use a > mask to get the value. > > Note that furt

Re: [PATCH 2/5] xen/sched: create public function for cpupools creation

2022-02-15 Thread Juergen Gross
On 15.02.22 11:15, Luca Fancellu wrote: Create new public function to create cpupools, it checks for pool id uniqueness before creating the pool and can take a scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu Reviewed-by: Juergen

Re: [PATCH 3/5] xen/sched: retrieve scheduler id by name

2022-02-15 Thread Juergen Gross
On 15.02.22 11:15, Luca Fancellu wrote: Add a public function to retrieve the scheduler id by the scheduler name. Signed-off-by: Luca Fancellu --- xen/common/sched/core.c | 11 +++ xen/include/xen/sched.h | 11 +++ 2 files changed, 22 insertions(+) diff --git a/xen/common/s

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Roger Pau Monné
On Tue, Feb 15, 2022 at 10:11:35AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Introduce a per-domain read/write lock to check whether vpci is present, > so we are sure there are no accesses to the contents of the vpci struct > if not. This lock can be used (and in a

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-15 Thread Juergen Gross
On 15.02.22 11:15, Luca Fancellu wrote: Introduce an architecture specific way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupools for each type of core, but also systems using NUMA can have diffe

Re: [PATCH 5/5] arm/dom0less: assign dom0less guests to cpupools

2022-02-15 Thread Juergen Gross
On 15.02.22 11:15, Luca Fancellu wrote: Introduce domain-cpupool property of a xen,domain device tree node, that specifies the cpupool device tree handle of a xen,cpupool node that identifies a cpupool created at boot time where the guest will be assigned on creation. Add member to the xen_arch_

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 12:48, Roger Pau Monné wrote: > On Tue, Feb 15, 2022 at 10:11:35AM +0200, Oleksandr Andrushchenko wrote: > @@ -911,7 +914,11 @@ int vpci_msix_arch_print(const struct vpci_msix *msix) >> struct pci_dev *pdev = msix->pdev; >> >> spin_unlock(&msix->pdev->vp

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 12:48, Roger Pau Monné wrote: > On Tue, Feb 15, 2022 at 10:11:35AM +0200, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> Introduce a per-domain read/write lock to check whether vpci is present, >> so we are sure there are no accesses to the contents of the vpci

[PATCH] x86/vmx: remove dead code to create domains without a vLAPIC

2022-02-15 Thread Roger Pau Monne
After the removal of PVHv1 it's no longer supported to create a domain using hardware virtualization extensions and without a local APIC: PVHv2 mandates domains to always have a LAPIC. Remove some stale code in VMCS construction and related helpers that catered for that use-case. No functional cha

Re: [PATCH] tools: remove xenstore entries on vchan server closure

2022-02-15 Thread Oleksandr Andrushchenko
Anthony, could you please take a look? Thank you in advance, Oleksandr On 10.12.21 14:35, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > vchan server creates XenStore entries to advertise its event channel and > ring, but those are not removed after the server quits. > Add ad

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Roger Pau Monné
On Tue, Feb 15, 2022 at 11:12:23AM +, Oleksandr Andrushchenko wrote: > > > On 15.02.22 12:48, Roger Pau Monné wrote: > > On Tue, Feb 15, 2022 at 10:11:35AM +0200, Oleksandr Andrushchenko wrote: > >> From: Oleksandr Andrushchenko > >> > >> Introduce a per-domain read/write lock to check wheth

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 13:39, Roger Pau Monné wrote: > On Tue, Feb 15, 2022 at 11:12:23AM +, Oleksandr Andrushchenko wrote: >> >> On 15.02.22 12:48, Roger Pau Monné wrote: >>> On Tue, Feb 15, 2022 at 10:11:35AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Introduce

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Jan Beulich
On 15.02.2022 12:45, Oleksandr Andrushchenko wrote: > I'm on your side, I just want to hear that we all agree pcidevs > needs to be converted into rwlock according with the plan you > suggested and at least now it seems to be an acceptable solution. I'd like to express worries though about the con

Re: [PATCH] rwlock: remove unneeded subtraction

2022-02-15 Thread Luca Fancellu
> On 15 Feb 2022, at 09:39, Roger Pau Monne wrote: > > There's no need to subtract _QR_BIAS from the lock value for storing > in the local cnts variable in the read lock slow path: the users of > the value in cnts only care about the writer-related bits and use a > mask to get the value. > >

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 13:50, Jan Beulich wrote: > On 15.02.2022 12:45, Oleksandr Andrushchenko wrote: >> I'm on your side, I just want to hear that we all agree pcidevs >> needs to be converted into rwlock according with the plan you >> suggested and at least now it seems to be an acceptable solution. > I'

[linux-linus test] 168113: tolerable FAIL - PUSHED

2022-02-15 Thread osstest service owner
flight 168113 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168113/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 168080 Tests which did not succeed,

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 13:54, Oleksandr Andrushchenko wrote: > > On 15.02.22 13:50, Jan Beulich wrote: >> On 15.02.2022 12:45, Oleksandr Andrushchenko wrote: >>> I'm on your side, I just want to hear that we all agree pcidevs >>> needs to be converted into rwlock according with the plan you >>> suggested an

[qemu-mainline test] 168114: tolerable FAIL - PUSHED

2022-02-15 Thread osstest service owner
flight 168114 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168114/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 168059 test-armhf-armhf-libvirt 16 sav

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Jan Beulich
On 15.02.2022 12:54, Oleksandr Andrushchenko wrote: > On 15.02.22 13:50, Jan Beulich wrote: >> On 15.02.2022 12:45, Oleksandr Andrushchenko wrote: >>> I'm on your side, I just want to hear that we all agree pcidevs >>> needs to be converted into rwlock according with the plan you >>> suggested and

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 14:49, Jan Beulich wrote: > On 15.02.2022 12:54, Oleksandr Andrushchenko wrote: >> On 15.02.22 13:50, Jan Beulich wrote: >>> On 15.02.2022 12:45, Oleksandr Andrushchenko wrote: I'm on your side, I just want to hear that we all agree pcidevs needs to be converted into rwlock

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Jan Beulich
On 15.02.2022 13:44, Oleksandr Andrushchenko wrote: > On 15.02.22 13:54, Oleksandr Andrushchenko wrote: >> On 15.02.22 13:50, Jan Beulich wrote: >>> On 15.02.2022 12:45, Oleksandr Andrushchenko wrote: I'm on your side, I just want to hear that we all agree pcidevs needs to be converted in

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Jan Beulich
On 15.02.2022 13:56, Oleksandr Andrushchenko wrote: > On 15.02.22 14:49, Jan Beulich wrote: >> On 15.02.2022 12:54, Oleksandr Andrushchenko wrote: >>> On 15.02.22 13:50, Jan Beulich wrote: On 15.02.2022 12:45, Oleksandr Andrushchenko wrote: > I'm on your side, I just want to hear that we a

Re: [PATCH] rwlock: remove unneeded subtraction

2022-02-15 Thread Julien Grall
Hi, On 15/02/2022 09:39, Roger Pau Monne wrote: There's no need to subtract _QR_BIAS from the lock value for storing in the local cnts variable in the read lock slow path: the users of the value in cnts only care about the writer-related bits and use a mask to get the value. Note that further s

Re: [PATCH] rwlock: remove unneeded subtraction

2022-02-15 Thread Jan Beulich
On 15.02.2022 14:13, Julien Grall wrote: > On 15/02/2022 09:39, Roger Pau Monne wrote: >> There's no need to subtract _QR_BIAS from the lock value for storing >> in the local cnts variable in the read lock slow path: the users of >> the value in cnts only care about the writer-related bits and use

Re: [PATCH] x86/vmx: remove dead code to create domains without a vLAPIC

2022-02-15 Thread Jan Beulich
On 15.02.2022 12:28, Roger Pau Monne wrote: > After the removal of PVHv1 it's no longer supported to create a domain > using hardware virtualization extensions and without a local APIC: > PVHv2 mandates domains to always have a LAPIC. Remove some stale code > in VMCS construction and related helper

Re: [PATCH v2 34/70] x86/emul: CFI hardening

2022-02-15 Thread Andrew Cooper
On 14/02/2022 13:38, Jan Beulich wrote: > On 14.02.2022 13:50, Andrew Cooper wrote: >> Control Flow Integrity schemes use toolchain and optionally hardware support >> to help protect against call/jump/return oriented programming attacks. >> >> Use cf_check to annotate function pointer targets for t

Re: [PATCH v2 06/70] x86: Introduce support for CET-IBT

2022-02-15 Thread Jan Beulich
On 14.02.2022 13:50, Andrew Cooper wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -39,6 +39,11 @@ config HAS_AS_CET_SS > # binutils >= 2.29 or LLVM >= 6 > def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy) > > +config HAS_CC_CET_IBT > + # GCC >= 9 and binutil

Re: Metadata and signalling channels for Zephyr virtio-backends on Xen

2022-02-15 Thread Vincent Guittot
Hi All, Sorry for the late reply but I was off last week. I will go through the thread and try to answer open point On Mon, 7 Feb 2022 at 11:56, Alex Bennée wrote: > > > Hi Stefano, > > Vincent gave an update on his virtio-scmi work at the last Stratos sync > call and the discussion moved onto n

Re: [PATCH v2 34/70] x86/emul: CFI hardening

2022-02-15 Thread Jan Beulich
On 15.02.2022 14:43, Andrew Cooper wrote: > On 14/02/2022 13:38, Jan Beulich wrote: >> On 14.02.2022 13:50, Andrew Cooper wrote: >>> Control Flow Integrity schemes use toolchain and optionally hardware support >>> to help protect against call/jump/return oriented programming attacks. >>> >>> Use cf

Re: [PATCH] rwlock: remove unneeded subtraction

2022-02-15 Thread Roger Pau Monné
On Tue, Feb 15, 2022 at 02:22:02PM +0100, Jan Beulich wrote: > On 15.02.2022 14:13, Julien Grall wrote: > > On 15/02/2022 09:39, Roger Pau Monne wrote: > >> There's no need to subtract _QR_BIAS from the lock value for storing > >> in the local cnts variable in the read lock slow path: the users of

[libvirt test] 168117: regressions - FAIL

2022-02-15 Thread osstest service owner
flight 168117 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168117/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: Metadata and signalling channels for Zephyr virtio-backends on Xen

2022-02-15 Thread Vincent Guittot
Hi Stefano, On Tue, 8 Feb 2022 at 01:16, Stefano Stabellini wrote: > > On Mon, 7 Feb 2022, Alex Bennée wrote: > > Hi Stefano, > > > > Vincent gave an update on his virtio-scmi work at the last Stratos sync > > call and the discussion moved onto next steps. > > Hi Alex, > > I don't know the specif

Re: [PATCH] tools: remove xenstore entries on vchan server closure

2022-02-15 Thread Jason Andryuk
On Fri, Dec 10, 2021 at 7:35 AM Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > vchan server creates XenStore entries to advertise its event channel and > ring, but those are not removed after the server quits. > Add additional cleanup step, so those are removed, so clients d

Re: [PATCH] rwlock: remove unneeded subtraction

2022-02-15 Thread Jan Beulich
On 15.02.2022 15:16, Roger Pau Monné wrote: > On Tue, Feb 15, 2022 at 02:22:02PM +0100, Jan Beulich wrote: >> On 15.02.2022 14:13, Julien Grall wrote: >>> On 15/02/2022 09:39, Roger Pau Monne wrote: There's no need to subtract _QR_BIAS from the lock value for storing in the local cnts var

Re: Metadata and signalling channels for Zephyr virtio-backends on Xen

2022-02-15 Thread Vincent Guittot
On Sat, 12 Feb 2022 at 00:34, Stefano Stabellini wrote: > > On Fri, 11 Feb 2022, Alex Bennée wrote: > > > FYI, a good and promising approach to handle both SCMI and SCPI is the > > > series recently submitted by EPAM to mediate SCMI and SCPI requests in > > > Xen: https://marc.info/?l=xen-devel&m=

Re: [PATCH] tools: remove xenstore entries on vchan server closure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 16:41, Jason Andryuk wrote: > On Fri, Dec 10, 2021 at 7:35 AM Oleksandr Andrushchenko > wrote: >> From: Oleksandr Andrushchenko >> >> vchan server creates XenStore entries to advertise its event channel and >> ring, but those are not removed after the server quits. >> Add additional

Re: [PATCH v2] tools/libxl: don't allow IOMMU usage with PoD

2022-02-15 Thread Anthony PERARD
On Thu, Feb 03, 2022 at 03:32:11PM +0100, Roger Pau Monne wrote: > if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV && > -d_config->num_pcidevs && pod_enabled) { > +d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED && > +pod_enabled) { > ret = ERROR_I

Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-15 Thread Jane Malalane
On 15/02/2022 10:19, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 15.02.2022 11:14, Jane Malalane wrote: >> On 15/02/2022 07:09, Jan Beulich wrote: >>> [CAUTION - EXTERNAL

Re: [PATCH v2 07/70] x86: Build check for embedded endbr64 instructions

2022-02-15 Thread Jan Beulich
On 14.02.2022 13:50, Andrew Cooper wrote: > From: Marek Marczykowski-Górecki > > Embedded endbr64 instructions mark legal indirect branches as far as the CPU > is concerned, which aren't legal as far as the logic is concerned. I think it would help if it was clarified what "embedded" actually me

Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-15 Thread Jan Beulich
On 15.02.2022 16:10, Jane Malalane wrote: > On 15/02/2022 10:19, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On 15.02.2022 11:14, Jane Malalane wrote: >>> On 15/02/2022 07

[PATCH v2 0/3] xen/vpci: msix: Make VPCI MSI-X code non-x86 specific

2022-02-15 Thread Rahul Singh
This patch series is v2 of preparatory work to make VPCI MSI-X code non-x86 specific. Rahul Singh (3): xen/vpci: msix: move x86 specific code to x86 file xen/vpci: msix: change return value of vpci_msix_{read,write} xen/vpci: msix: move read/write call to MSI-X PBA entry to arch file xen/a

[PATCH v2 1/3] xen/vpci: msix: move x86 specific code to x86 file

2022-02-15 Thread Rahul Singh
vpci/msix.c file will be used for arm architecture when vpci msix support will be added to ARM, but there is x86 specific code in this file. Move x86 specific code to the x86/hvm/vmsi.c file to make sure common code will be used for other architecture. No functional change intended. Signed-off-b

[PATCH v2 2/3] xen/vpci: msix: change return value of vpci_msix_{read,write}

2022-02-15 Thread Rahul Singh
Return value is different for the MMIO handler on ARM and x86 architecture. To make the code common for both architectures change the return value of vpci_msix_{read, write} to bool. Architecture-specific return value will be handled in arch code. Signed-off-by: Rahul Singh --- Changes since v1:

[PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA entry to arch file

2022-02-15 Thread Rahul Singh
{read,write}{l,q} function argument is different for ARM and x86. ARM {read,wrie}(l,q} function argument is pointer whereas X86 {read,wrie}(l,q} function argument is address itself. {read,write}{l,q} is only used in common file to access the MSI-X PBA structure. To avoid impacting other x86 code a

[PATCH v2] xen/arm: vpci: remove PCI I/O ranges property value

2022-02-15 Thread Rahul Singh
PCI I/O space are not mapped to dom0 when PCI passthrough is enabled, also there is no vpci trap handler register for IO bar. Remove PCI I/O ranges property value from dom0 device tree node so that dom0 linux will not allocate I/O space for PCI devices if pci-passthrough is enabled. Signed-off-by

Re: [PATCH] rwlock: remove unneeded subtraction

2022-02-15 Thread Roger Pau Monné
On Tue, Feb 15, 2022 at 03:45:00PM +0100, Jan Beulich wrote: > On 15.02.2022 15:16, Roger Pau Monné wrote: > > I could add to the commit message: > > > > "Originally _QR_BIAS was subtracted from the result of > > atomic_add_return_acquire in order to prevent GCC from emitting an > > unneeded ADD i

Re: [PATCH] tools/xenstore: add error indicator to ring page

2022-02-15 Thread Anthony PERARD
On Thu, Feb 10, 2022 at 12:16:20PM +0100, Juergen Gross wrote: > +The "Connection error indicator" is used to let the server indicate it has > +detected some error that led to deactivation of the connection by the server. > +If the feature has been advertised then the "Connection error indicator" m

Re: [PATCH] tools/xenstore: add error indicator to ring page

2022-02-15 Thread Juergen Gross
On 15.02.22 16:42, Anthony PERARD wrote: On Thu, Feb 10, 2022 at 12:16:20PM +0100, Juergen Gross wrote: +The "Connection error indicator" is used to let the server indicate it has +detected some error that led to deactivation of the connection by the server. +If the feature has been advertised t

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 14:56, Jan Beulich wrote: > On 15.02.2022 13:44, Oleksandr Andrushchenko wrote: >> On 15.02.22 13:54, Oleksandr Andrushchenko wrote: >>> On 15.02.22 13:50, Jan Beulich wrote: On 15.02.2022 12:45, Oleksandr Andrushchenko wrote: > I'm on your side, I just want to hear that we a

[ovmf test] 168119: all pass - PUSHED

2022-02-15 Thread osstest service owner
flight 168119 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168119/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 85589ddbf6f8c6dc75f73aa32e484e3cfd439e7a baseline version: ovmf 1193aa2dfbbd11fa7191d

Re: tools backports

2022-02-15 Thread Anthony PERARD
On Mon, Feb 14, 2022 at 11:18:44AM +0100, Jan Beulich wrote: > I have a couple of simple tool stack backports queued, which - with your > agreement - I would want to put onto the stable tree whenever I get > around to applying the next batch of backports: > > d9d3496e817a tools/libs/light: don't t

Re: tools backports

2022-02-15 Thread Anthony PERARD
On Mon, Feb 14, 2022 at 11:55:26AM +0100, Roger Pau Monné wrote: > On Mon, Feb 14, 2022 at 11:18:44AM +0100, Jan Beulich wrote: > > Anthony, > > > > I have a couple of simple tool stack backports queued, which - with your > > agreement - I would want to put onto the stable tree whenever I get > >

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Jan Beulich
On 15.02.2022 16:46, Oleksandr Andrushchenko wrote: > Question: can anyone please explain why pcidevs is a recursive lock? Well, assuming you did look at the change making it so, can you be a little more specific with your question? Are you perhaps suggesting the original reason has disappeared, a

Re: [PATCH v2 60/70] x86: Use control flow typechecking where possible

2022-02-15 Thread Jan Beulich
On 14.02.2022 13:51, Andrew Cooper wrote: > Now all callees have been annotated, turn on typechecking to catch issues in > the future. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > > RFC. This is still an experimental compiler extention > http

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Oleksandr Andrushchenko
On 15.02.22 18:18, Jan Beulich wrote: > On 15.02.2022 16:46, Oleksandr Andrushchenko wrote: >> Question: can anyone please explain why pcidevs is a recursive lock? > Well, assuming you did look at the change making it so, can you be a > little more specific with your question? Are you perhaps sug

Re: [PATCH v2 64/70] x86: Introduce helpers/checks for endbr64 instructions

2022-02-15 Thread Jan Beulich
On 14.02.2022 13:51, Andrew Cooper wrote: > ... to prevent the optimiser creating unsafe code. See the code comment for > full details. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-15 Thread Jane Malalane
On 15/02/2022 15:21, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 15.02.2022 16:10, Jane Malalane wrote: >> On 15/02/2022 10:19, Jan Beulich wrote: >>> [CAUTION - EXTERNAL

Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure

2022-02-15 Thread Jan Beulich
On 15.02.2022 17:28, Oleksandr Andrushchenko wrote: > On 15.02.22 18:18, Jan Beulich wrote: >> On 15.02.2022 16:46, Oleksandr Andrushchenko wrote: >>> Question: can anyone please explain why pcidevs is a recursive lock? >> Well, assuming you did look at the change making it so, can you be a >> litt

Re: [PATCH v2 68/70] x86/setup: Rework MSR_S_CET handling for CET-IBT

2022-02-15 Thread Jan Beulich
On 14.02.2022 13:51, Andrew Cooper wrote: > CET-SS and CET-IBT can be independently controlled, so the configuration of > MSR_S_CET can't be constant any more. > > Introduce xen_msr_s_cet_value(), mostly because I don't fancy > writing/maintaining that logic in assembly. Use this in the 3 paths w

Re: [PATCH v2 69/70] x86/efi: Disable CET-IBT around Runtime Services calls

2022-02-15 Thread Jan Beulich
On 14.02.2022 13:51, Andrew Cooper wrote: > UEFI Runtime services, at the time of writing, aren't CET-IBT compatible. > Work is ongoing to address this. In the meantime, unconditionally disable IBT. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich > --- a/xen/common/efi/runtime.c > ++

[xen-unstable test] 168118: tolerable FAIL

2022-02-15 Thread osstest service owner
flight 168118 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168118/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 168111 pass in 168118 test-arm64-arm64-xl-thun

Re: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools

2022-02-15 Thread Luca Fancellu
> On 15 Feb 2022, at 10:33, Juergen Gross wrote: > > On 15.02.22 11:15, Luca Fancellu wrote: >> With the introduction of boot time cpupools, Xen can create many >> different cpupools at boot time other than cpupool with id 0. >> Since these newly created cpupools can't have an >> entry in Xens

Re: [PATCH 2/5] xen/sched: create public function for cpupools creation

2022-02-15 Thread Luca Fancellu
> On 15 Feb 2022, at 10:38, Juergen Gross wrote: > > On 15.02.22 11:15, Luca Fancellu wrote: >> Create new public function to create cpupools, it checks for pool id >> uniqueness before creating the pool and can take a scheduler id or >> a negative value that means the default Xen scheduler wi

Re: [PATCH v2 07/70] x86: Build check for embedded endbr64 instructions

2022-02-15 Thread Andrew Cooper
On 15/02/2022 15:12, Jan Beulich wrote: > On 14.02.2022 13:50, Andrew Cooper wrote: >> From: Marek Marczykowski-Górecki >> >> Embedded endbr64 instructions mark legal indirect branches as far as the CPU >> is concerned, which aren't legal as far as the logic is concerned. > I think it would help i

Re: [PATCH 3/5] xen/sched: retrieve scheduler id by name

2022-02-15 Thread Luca Fancellu
> On 15 Feb 2022, at 10:40, Juergen Gross wrote: > > On 15.02.22 11:15, Luca Fancellu wrote: >> Add a public function to retrieve the scheduler id by the scheduler >> name. >> Signed-off-by: Luca Fancellu >> --- >> xen/common/sched/core.c | 11 +++ >> xen/include/xen/sched.h | 11 +++

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-15 Thread Luca Fancellu
> On 15 Feb 2022, at 10:48, Juergen Gross wrote: > > On 15.02.22 11:15, Luca Fancellu wrote: >> Introduce an architecture specific way to create different cpupools >> at boot time, this is particularly useful on ARM big.LITTLE system >> where there might be the need to have different cpupools

Re: [PATCH 5/5] arm/dom0less: assign dom0less guests to cpupools

2022-02-15 Thread Luca Fancellu
> On 15 Feb 2022, at 10:56, Juergen Gross wrote: > > On 15.02.22 11:15, Luca Fancellu wrote: >> Introduce domain-cpupool property of a xen,domain device tree node, >> that specifies the cpupool device tree handle of a xen,cpupool node >> that identifies a cpupool created at boot time where the

Re: [PATCH] MAINTAINERS: make Bertrand ARM maintainer

2022-02-15 Thread Julien Grall
Hi, On 10/02/2022 19:08, Stefano Stabellini wrote: Signed-off-by: Stefano Stabellini Acked-by: Julien Grall The proposal has been for a few days on the ML without any objection. So I will commit it now. Cheers, -- Julien Grall

Re: [PATCH v6 02/11] xen: introduce CDF_directmap

2022-02-15 Thread Julien Grall
(+ Jan) Hi Penny, I am CCing Jan to give him a chance to... On 14/02/2022 03:19, Penny Zheng wrote: diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index cfb0b47f13..24eb4cc7d3 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -31,6 +31,10 @@ void arch_ge

Re: [PATCH v6 03/11] xen/arm: Allow device-passthrough even the IOMMU is off

2022-02-15 Thread Julien Grall
Hi, On 14/02/2022 03:19, Penny Zheng wrote: From: Stefano Stabellini At the moment, we are only supporting device-passthrough when Xen has enabled the IOMMU. There are some use cases where it is not possible to use the IOMMU (e.g. doesn't exist, hardware limitation, performance) yet it would b

Re: [PATCH] docs: add some clarification to xenstore-migration.md

2022-02-15 Thread Julien Grall
Hi Juergen, On 10/02/2022 11:26, Juergen Gross wrote: The Xenstore migration document is missing the specification that a node record must be preceded by the record of its parent node in case of live update. Add that missing part. Signed-off-by: Juergen Gross --- docs/designs/xenstore-migra

Re: [PATCH v2 68/70] x86/setup: Rework MSR_S_CET handling for CET-IBT

2022-02-15 Thread Andrew Cooper
On 15/02/2022 16:46, Jan Beulich wrote: > On 14.02.2022 13:51, Andrew Cooper wrote: >> CET-SS and CET-IBT can be independently controlled, so the configuration of >> MSR_S_CET can't be constant any more. >> >> Introduce xen_msr_s_cet_value(), mostly because I don't fancy >> writing/maintaining that

Re: [PATCH v2] lib: extend ASSERT()

2022-02-15 Thread Julien Grall
(+ Bertrand) Hi Jan, On 27/01/2022 14:34, Jan Beulich wrote: The increasing amount of constructs along the lines of if ( !condition ) { ASSERT_UNREACHABLE(); return; } is not only longer than necessary, but also doesn't produce incident specific console output

Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer

2022-02-15 Thread Julien Grall
Hi Juergen, On 03/02/2022 13:14, Juergen Gross wrote: Add a comment to include/public/grant_table.h that GNTTABOP_transfer is deprecated, in order to discourage new use cases. From the commit message, it is unclear to me why we are discouraging new use cases and indirectly encouraging current

Re: [PATCH v6 00/21] Introduce power-off+restart call chain API

2022-02-15 Thread Dmitry Osipenko
31.01.2022 02:36, Dmitry Osipenko пишет: > Problem > --- > > SoC devices require power-off call chaining functionality from kernel. > We have a widely used restart chaining provided by restart notifier API, > but nothing for power-off. > > Solution > > > Introduce new API that provi

Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it

2022-02-15 Thread Dmitry Torokhov
Hi Wang, On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. I applied changes by Danilo Krummrich converting the driver to use ktime_t (see https://lore.kernel.org/r/2022021516

Re: [PATCH v2 69/70] x86/efi: Disable CET-IBT around Runtime Services calls

2022-02-15 Thread Andrew Cooper
On 15/02/2022 16:53, Jan Beulich wrote: > On 14.02.2022 13:51, Andrew Cooper wrote: >> UEFI Runtime services, at the time of writing, aren't CET-IBT compatible. >> Work is ongoing to address this. In the meantime, unconditionally disable >> IBT. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: J

[qemu-mainline test] 168120: tolerable FAIL - PUSHED

2022-02-15 Thread osstest service owner
flight 168120 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168120/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 168114 test-armhf-armhf-libvirt 16 sav

[xen-unstable-smoke test] 168122: tolerable all pass - PUSHED

2022-02-15 Thread osstest service owner
flight 168122 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/168122/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

  1   2   >