Re: [PATCH] mini-os: netfront: fix initialization without ip address in xenstore

2021-08-19 Thread Samuel Thibault
Juergen Gross, le jeu. 19 août 2021 07:30:56 +0200, a ecrit: > Commit 4821876fcd2ff ("mini-os: netfront: fix suspend/resume handling") > introduced a NULL pointer dereference in the initialization of netfront > in the case of no IP address being set in Xenstore. > > Fix that by testing this condit

Re: [PATCH-4.15] tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table

2021-08-19 Thread Juergen Gross
PING!!! On 16.07.21 08:47, Juergen Gross wrote: Ping? On 02.07.21 16:29, Juergen Gross wrote: The core of a pv linux guest produced via "xl dump-core" is not usable as since kernel 4.14 only the linear p2m table is kept if Xen indicates it is supporting that. Unfortunately xc_core_arch_map_p2m

[PATCH] AMD/IOMMU: don't leave page table mapped when unmapping ...

2021-08-19 Thread Jan Beulich
... an already not mapped page. With all other exit paths doing the unmap, I have no idea how I managed to miss that aspect at the time. Fixes: ad591454f069 ("AMD/IOMMU: don't needlessly trigger errors/crashes when unmapping a page") Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/amd/

[PATCH] AMD/IOMMU: don't increase perms when splitting superpage

2021-08-19 Thread Jan Beulich
The old (super)page's permissions ought to be propagated, rather than blindly allowing both reads and writes. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -231,7 +231,7 @@ static int iommu_pde_from_dfn(struct dom

[PATCH] VT-d: fix caching mode IOTLB flushing

2021-08-19 Thread Jan Beulich
While for context cache entry flushing use of did 0 is indeed correct (after all upon reading the context entry the IOMMU wouldn't know any domain ID if the entry is not present, and hence a surrogate one needs to be used), for IOTLB entries the normal domain ID (from the [present] context entry) g

Re: [PATCH] Arm: relax iomem_access_permitted() check

2021-08-19 Thread Jan Beulich
On 18.08.2021 19:44, Julien Grall wrote: > On 18/08/2021 08:52, Jan Beulich wrote: >> Ranges checked by iomem_access_permitted() are inclusive; to permit a >> mapping there's no need for access to also have been granted for the >> subsequent page. > > Good catch! OOI, how did you find it? In the

Re: Xen 4.16: Proposed release manager and schedule

2021-08-19 Thread Jan Beulich
On 18.08.2021 17:09, Ian Jackson wrote: > We haven't formally appointed a release manager for Xen 4.16. > I was approached and asked if I would do the job, and said yes, > but I think things got stuck there. Taking this as a prima > faciae indication of community confidence, I hereby volunteer to

Re: [PATCH V3 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM

2021-08-19 Thread Christoph Hellwig
On Mon, Aug 16, 2021 at 10:50:26PM +0800, Tianyu Lan wrote: > Hi Christoph: > Sorry to bother you.Please double check with these two patches > " [PATCH V3 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function > for HV IVM" and "[PATCH V3 09/13] DMA: Add dma_map_decrypted/dma_ > unmap_

Re: [PATCH v2 02/13] libxc: split xc_logdirty_control() from xc_shadow_control()

2021-08-19 Thread Juergen Gross
On 05.07.21 17:12, Jan Beulich wrote: For log-dirty operations a 64-bit field is being truncated to become an "int" return value. Seeing the large number of arguments the present function takes, reduce its set of parameters to that needed for all operations not involving the log-dirty bitmap, whi

[linux-5.4 test] 164240: regressions - FAIL

2021-08-19 Thread osstest service owner
flight 164240 linux-5.4 real [real] flight 164250 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164240/ http://logs.test-lab.xenproject.org/osstest/logs/164250/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

Re: [PATCH] RFC: Version support policy

2021-08-19 Thread Jan Beulich
On 13.08.2021 13:37, Ian Jackson wrote: > The current policy for minimum supported versions of tools, compilers, > etc. is unsatisfactory: For many dependencies no minimum version is > specified. For those where a version is stated, updating it is a > decision that has to be explicitly taken for t

Re: [PATCH v2 02/13] libxc: split xc_logdirty_control() from xc_shadow_control()

2021-08-19 Thread Jan Beulich
On 19.08.2021 11:11, Juergen Gross wrote: > On 05.07.21 17:12, Jan Beulich wrote: >> For log-dirty operations a 64-bit field is being truncated to become an >> "int" return value. Seeing the large number of arguments the present >> function takes, reduce its set of parameters to that needed for all

[linux-linus test] 164242: regressions - FAIL

2021-08-19 Thread osstest service owner
flight 164242 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164242/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH v2 02/13] libxc: split xc_logdirty_control() from xc_shadow_control()

2021-08-19 Thread Juergen Gross
On 19.08.21 11:24, Jan Beulich wrote: On 19.08.2021 11:11, Juergen Gross wrote: On 05.07.21 17:12, Jan Beulich wrote: For log-dirty operations a 64-bit field is being truncated to become an "int" return value. Seeing the large number of arguments the present function takes, reduce its set of pa

Re: [PATCH V3 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM

2021-08-19 Thread Tianyu Lan
On 8/19/2021 4:49 PM, Christoph Hellwig wrote: On Mon, Aug 16, 2021 at 10:50:26PM +0800, Tianyu Lan wrote: Hi Christoph: Sorry to bother you.Please double check with these two patches " [PATCH V3 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM" and "[PATCH V3 09

Re: [PATCH V3 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM

2021-08-19 Thread Christoph Hellwig
On Thu, Aug 19, 2021 at 05:59:02PM +0800, Tianyu Lan wrote: > > > On 8/19/2021 4:49 PM, Christoph Hellwig wrote: >> On Mon, Aug 16, 2021 at 10:50:26PM +0800, Tianyu Lan wrote: >>> Hi Christoph: >>>Sorry to bother you.Please double check with these two patches >>> " [PATCH V3 10/13] x86/Swio

[libvirt test] 164249: regressions - FAIL

2021-08-19 Thread osstest service owner
flight 164249 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164249/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

Re: [PATCH V3 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM

2021-08-19 Thread Tianyu Lan
On 8/19/2021 6:02 PM, Christoph Hellwig wrote: On Thu, Aug 19, 2021 at 05:59:02PM +0800, Tianyu Lan wrote: On 8/19/2021 4:49 PM, Christoph Hellwig wrote: On Mon, Aug 16, 2021 at 10:50:26PM +0800, Tianyu Lan wrote: Hi Christoph: Sorry to bother you.Please double check with these two p

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Juergen Gross
On 05.07.21 17:13, Jan Beulich wrote: In send_memory_live() the precise value the dirty_count struct field gets initialized to doesn't matter much (apart from the triggering of the log message in send_dirty_pages(), see below), but it is important that it not be zero on the first iteration (or el

Some questions about virtio-net on Xen x86

2021-08-19 Thread Jiamei Xie
Hi all, I tried to run virtio-net on X86 machine according to the Wiki page https://wiki.xenproject.org/wiki/Virtio_On_Xen. And I Encountered some confusing problems. The Qemu version I used is QEMU emulator version 4.2.1 (Debian 1:4.2-3ubuntu6.17) The content of guest.cfg is as below: type =

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Jan Beulich
On 19.08.2021 12:20, Juergen Gross wrote: > On 05.07.21 17:13, Jan Beulich wrote: >> In send_memory_live() the precise value the dirty_count struct field >> gets initialized to doesn't matter much (apart from the triggering of >> the log message in send_dirty_pages(), see below), but it is importan

Re: meaning and use of IOMMU_FLUSHF_added

2021-08-19 Thread Jan Beulich
On 18.08.2021 16:15, Paul Durrant wrote: > On 18/08/2021 13:09, Jan Beulich wrote: >> On 18.08.2021 12:51, Jan Beulich wrote: >>> back at the time I did already question your intended meaning of >>> this flag. I notice that there's presently no consumer of it being >>> set (apart from yielding non-

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Juergen Gross
On 19.08.21 13:06, Jan Beulich wrote: On 19.08.2021 12:20, Juergen Gross wrote: On 05.07.21 17:13, Jan Beulich wrote: In send_memory_live() the precise value the dirty_count struct field gets initialized to doesn't matter much (apart from the triggering of the log message in send_dirty_pages(),

Re: [PATCH] x86/xstate: reset cached register values on resume

2021-08-19 Thread Marek Marczykowski-Górecki
On Wed, Aug 18, 2021 at 01:44:31PM +0100, Andrew Cooper wrote: > On 18/08/2021 12:30, Marek Marczykowski-Górecki wrote: > > set_xcr0() and set_msr_xss() use cached value to avoid setting the > > register to the same value over and over. But suspend/resume implicitly > > reset the registers and sinc

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Jan Beulich
On 19.08.2021 13:25, Juergen Gross wrote: > On 19.08.21 13:06, Jan Beulich wrote: >> On 19.08.2021 12:20, Juergen Gross wrote: >>> On 05.07.21 17:13, Jan Beulich wrote: In send_memory_live() the precise value the dirty_count struct field gets initialized to doesn't matter much (apart from

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Jan Beulich
On 19.08.2021 13:51, Jan Beulich wrote: > On 19.08.2021 13:25, Juergen Gross wrote: >> On 19.08.21 13:06, Jan Beulich wrote: >>> On 19.08.2021 12:20, Juergen Gross wrote: On 05.07.21 17:13, Jan Beulich wrote: > In send_memory_live() the precise value the dirty_count struct field > gets

Re: [PATCH] RFC: Version support policy

2021-08-19 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH] RFC: Version support policy"): > On 13.08.2021 13:37, Ian Jackson wrote: > > The current policy for minimum supported versions of tools, compilers, > > etc. is unsatisfactory: For many dependencies no minimum version is > > specified. For those where a version is s

Re: [PATCH] RFC: Version support policy

2021-08-19 Thread Jan Beulich
On 19.08.2021 13:55, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH] RFC: Version support policy"): >> On 13.08.2021 13:37, Ian Jackson wrote: >>> In this patch I propose a cutoff of 6 years. >>> Obviously there will be debate about the precise value. >> >> Indeed I consider this way too shor

[PATCH v1 00/14] PCI devices passthrough on Arm

2021-08-19 Thread Rahul Singh
Hello All, The purpose of this patch series is to add PCI passthrough support to Xen on Arm. PCI passthrough support on ARM is the collaboration work between EPAM and ARM. ARM submitted the partial RFC [1][2] last year to get early feedback. We tried to fix all the comments and added more features

[PATCH v1 01/14] xen/pci: Refactor MSI code that implements MSI functionality within XEN

2021-08-19 Thread Rahul Singh
MSI code that implements MSI functionality to support MSI within XEN is not usable on ARM. Move the code under CONFIG_HAS_PCI_MSI flag to gate the code for ARM. No functional change intended. Signed-off-by: Rahul Singh --- xen/arch/x86/Kconfig | 1 + xen/drivers/passthrough/Makefil

[PATCH v1 02/14] xen/pci: solve compilation error on ARM with HAS_PCI enabled

2021-08-19 Thread Rahul Singh
Compilation error is observed when HAS_PCI is enabled for ARM architecture. Add definition for arch_iommu_use_permitted() and arch_pci_clean_pirqs().Implement dummy functions for pci_conf_read*() to fix compilation error. pci.c: In function ‘deassign_device’: pci.c:849:49: error: implicit declara

[PATCH v1 03/14] xen/pci: solve compilation error on ARM with ACPI && HAS_PCI

2021-08-19 Thread Rahul Singh
Compilation error is observed when ACPI and HAS_PCI is enabled for ARM architecture. Move the code under CONFIG_X86 flag to gate the code for ARM. No functional change intended. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH v1 04/14] xen/arm: Add support for PCI init to initialize the PCI driver.

2021-08-19 Thread Rahul Singh
pci_init(..) will be called during xen startup to initialize and probe the PCI host-bridge driver. Signed-off-by: Rahul Singh --- xen/arch/arm/pci/pci.c | 54 xen/include/asm-arm/device.h | 1 + 2 files changed, 55 insertions(+) diff --git a/xen/arch/

Re: [xen-unstable test] 164237: regressions - FAIL

2021-08-19 Thread Jan Beulich
On 19.08.2021 05:07, osstest service owner wrote: > flight 164237 xen-unstable real [real] > flight 164246 xen-unstable real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/164237/ > http://logs.test-lab.xenproject.org/osstest/logs/164246/ > > Regressions :-( > > Tests which did

[PATCH v1 05/14] xen/arm: PCI host bridge discovery within XEN on ARM

2021-08-19 Thread Rahul Singh
XEN during boot will read the PCI device tree node “reg” property and will map the PCI config space to the XEN memory. As of now "pci-host-ecam-generic" compatible board is supported. "linux,pci-domain" device tree property assigns a fixed PCI domain number to a host bridge, otherwise an unstable

[PATCH v1 06/14] xen/arm: Add support for PCI ecam operations

2021-08-19 Thread Rahul Singh
Add support for PCI ecam operations to access the PCI configuration space. Signed-off-by: Rahul Singh --- xen/arch/arm/pci/Makefile | 1 + xen/arch/arm/pci/ecam.c | 63 + xen/arch/arm/pci/pci-access.c | 53 xen/arc

[PATCH v1 07/14] xen/arm: Add support for Xilinx ZynqMP PCI host controller

2021-08-19 Thread Rahul Singh
From: Oleksandr Andrushchenko Add support for Xilinx ZynqMP PCI host controller to map the PCI config space to the XEN memory. Signed-off-by: Oleksandr Andrushchenko --- xen/arch/arm/pci/Makefile | 1 + xen/arch/arm/pci/pci-host-zynqmp.c | 59 ++ 2 files c

[PATCH v1 08/14] xen:arm: Implement pci access functions

2021-08-19 Thread Rahul Singh
Implement generic pci access functions to read/write the configuration space. Signed-off-by: Rahul Singh --- xen/arch/arm/pci/pci-access.c | 31 +- xen/arch/arm/pci/pci-host-common.c | 19 ++ xen/include/asm-arm/pci.h | 2 ++ 3 files cha

[PATCH v1 09/14] xen/arm: Add cmdline boot option "pci=on"

2021-08-19 Thread Rahul Singh
Add cmdline boot option "pci=on" to enable/disable the PCI init during boot. Signed-off-by: Rahul Singh --- xen/arch/arm/pci/pci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c index d1c9cf997d..dc63bbc2a2 1006

[PATCH v1 10/14] xen/arm: Discovering PCI devices and add the PCI devices in XEN.

2021-08-19 Thread Rahul Singh
Hardware domain is in charge of doing the PCI enumeration and will discover the PCI devices and then will communicate to XEN via hyper call PHYSDEVOP_pci_device_add to add the PCI devices in XEN. Signed-off-by: Rahul Singh --- xen/arch/arm/physdev.c | 39 ---

[PATCH v1 11/14] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-08-19 Thread Rahul Singh
The existing VPCI support available for X86 is adapted for Arm. When the device is added to XEN via the hyper call “PHYSDEVOP_pci_device_add”, VPCI handler for the config space access is added to the Xen to emulate the PCI devices config space. A MMIO trap handler for the PCI ECAM space is registe

[PATCH v1 12/14] arm/libxl: Emulated PCI device tree node in libxl

2021-08-19 Thread Rahul Singh
libxl will create an emulated PCI device tree node in the device tree to enable the guest OS to discover the virtual PCI during guest boot. Emulated PCI device tree node will only be created when there is any device assigned to guest. A new area has been reserved in the arm guest physical map at w

[PATCH v1 13/14] xen/arm: Fixed error when PCI device is assigned to guest

2021-08-19 Thread Rahul Singh
XEN_DOMCTL_ioport_permission, PHYSDEVOP_unmap_pirq, PHYSDEVOP_unmap_pirq are unimplemented for ARM. When libxl assigning a PCI device to the guest error is observed related to above functions. Implement dummy functions to fix the error. Signed-off-by: Rahul Singh --- xen/arch/arm/domctl.c | 2

[PATCH v1 14/14] xen/arm: Add linux,pci-domain property for hwdom if not available.

2021-08-19 Thread Rahul Singh
If the property is not present in the device tree node for host bridge, XEN while creating the dtb for hwdom will create this property and assigns the already allocated segment to the host bridge so that XEN and linux will have the same segment for the host bridges. Signed-off-by: Rahul Singh ---

Re: [PATCH v1 09/14] xen/arm: Add cmdline boot option "pci=on"

2021-08-19 Thread Jan Beulich
On 19.08.2021 14:02, Rahul Singh wrote: > Add cmdline boot option "pci=on" to enable/disable the PCI init during > boot. > > Signed-off-by: Rahul Singh > --- > xen/arch/arm/pci/pci.c | 30 ++ > 1 file changed, 30 insertions(+) Any addition or change of a command line

Re: [PATCH v1 13/14] xen/arm: Fixed error when PCI device is assigned to guest

2021-08-19 Thread Jan Beulich
On 19.08.2021 14:02, Rahul Singh wrote: > --- a/xen/arch/arm/domctl.c > +++ b/xen/arch/arm/domctl.c > @@ -173,6 +173,8 @@ long arch_do_domctl(struct xen_domctl *domctl, struct > domain *d, > > return rc; > } > +case XEN_DOMCTL_ioport_permission: > +return 0; I don't th

Re: [PATCH v1 01/14] xen/pci: Refactor MSI code that implements MSI functionality within XEN

2021-08-19 Thread Julien Grall
Hi Rahul, On 19/08/2021 13:02, Rahul Singh wrote: MSI code that implements MSI functionality to support MSI within XEN is not usable on ARM. Move the code under CONFIG_HAS_PCI_MSI flag to gate Can you clarify what you mean by not usable? Is it because we lack of support or we have no plan to

Re: [PATCH v2] tests/xenstore: link in librt if necessary

2021-08-19 Thread Juergen Gross
On 17.08.21 16:18, Jan Beulich wrote: Old enough glibc has clock_gettime() in librt.so, hence the library needs to be specified to the linker. Newer glibc has the symbol available in both libraries, so make sure that libc.so is preferred (to avoid an unnecessary dependency on librt.so). Fixes: 9

Re: [PATCH v1 02/14] xen/pci: solve compilation error on ARM with HAS_PCI enabled

2021-08-19 Thread Julien Grall
Hi Rahul, On 19/08/2021 13:02, Rahul Singh wrote: Compilation error is observed when HAS_PCI is enabled for ARM architecture. To be pedantic, what you are trying to solve is not a compilation error but the fact that the PCI mandates helpers that doesn't yet exist on Arm. So... Add definit

Re: [PATCH v1 09/14] xen/arm: Add cmdline boot option "pci=on"

2021-08-19 Thread Julien Grall
Hi Rahul, On 19/08/2021 13:02, Rahul Singh wrote: Add cmdline boot option "pci=on" to enable/disable the PCI init during boot. I read this as "PCI" will be either disabled/enabled for the platform. Whereas, I think it will be used to decide whether Xen discover PCI and PCI passthrough is sup

Re: [PATCH v1 10/14] xen/arm: Discovering PCI devices and add the PCI devices in XEN.

2021-08-19 Thread Julien Grall
(+ Jan) Hi Rahul, On 19/08/2021 13:02, Rahul Singh wrote: Hardware domain is in charge of doing the PCI enumeration and will discover the PCI devices and then will communicate to XEN via hyper call PHYSDEVOP_pci_device_add to add the PCI devices in XEN. There are other PHYSDEVOP operations to

Re: [PATCH v1 13/14] xen/arm: Fixed error when PCI device is assigned to guest

2021-08-19 Thread Julien Grall
Hi, On 19/08/2021 13:12, Jan Beulich wrote: On 19.08.2021 14:02, Rahul Singh wrote: --- a/xen/arch/arm/domctl.c +++ b/xen/arch/arm/domctl.c @@ -173,6 +173,8 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, return rc; } +case XEN_DOMCTL_ioport_permissi

Re: [xen-unstable test] 164237: regressions - FAIL

2021-08-19 Thread Ian Jackson
Jan Beulich writes ("Re: [xen-unstable test] 164237: regressions - FAIL"): > Looks like this didn't sort itself (yet). Do you continue to be > convinced that it will, eventually? Indeed not. The error message is different now. The guest installer reports 2021-08-18 18:14:09 Z 172.16.146.47:5890

Re: [xen-unstable test] 164237: regressions - FAIL

2021-08-19 Thread Ian Jackson
Jan Beulich writes ("Re: [xen-unstable test] 164237: regressions - FAIL"): > Looks like this didn't sort itself (yet). Do you continue to be > convinced that it will, eventually? Hooray for explanations in commit messages. I will (1) drop this test and (2) force push staging in the meantime. Ian

Re: [PATCH v1 12/14] arm/libxl: Emulated PCI device tree node in libxl

2021-08-19 Thread Julien Grall
Hi Rahul, On 19/08/2021 13:02, Rahul Singh wrote: libxl will create an emulated PCI device tree node in the device tree to enable the guest OS to discover the virtual PCI during guest boot. Emulated PCI device tree node will only be created when there is any device assigned to guest. A new area

Re: [XEN RFC PATCH 02/40] xen/arm: Print a 64-bit number in hex from early uart

2021-08-19 Thread Julien Grall
Hi Wei, On 11/08/2021 11:23, Wei Chen wrote: Current putn function that is using for early print only can print low 32-bit of AArch64 register. This will lose some important messages while debugging with early console. For example: (XEN) Bringing up CPU5 - CPU 00010100 booting - Will be

Re: [xen-unstable test] 164237: regressions - FAIL

2021-08-19 Thread Juergen Gross
On 19.08.21 14:45, Ian Jackson wrote: Jan Beulich writes ("Re: [xen-unstable test] 164237: regressions - FAIL"): Looks like this didn't sort itself (yet). Do you continue to be convinced that it will, eventually? Hooray for explanations in commit messages. I will (1) drop this test and (2) fo

Re: [xen-unstable test] 164237: regressions - FAIL

2021-08-19 Thread Ian Jackson
Juergen Gross writes ("Re: [xen-unstable test] 164237: regressions - FAIL"): > Does this mean we should de-support pvgrub? Or even remove it? I think so. > BTW, I don't see any reason why someone would want to keep using pvgrub > with grub-pv being available... Precisely. Ian.

Re: [xen-unstable test] 164237: regressions - FAIL

2021-08-19 Thread Ian Jackson
Ian Jackson writes ("Re: [xen-unstable test] 164237: regressions - FAIL"): > I will (1) drop this test and (2) force push staging in the meantime. Force pushed xen-unstable staging. osstest commit is below. Ian. >From 8dee6e333622d830b7a9373989f63b526a85cd94 Mon Sep 17 00:00:00 2001 From: Ian J

Re: [xen-unstable test] 164237: regressions - FAIL

2021-08-19 Thread Ian Jackson
Juergen Gross writes ("Re: [xen-unstable test] 164237: regressions - FAIL"): > Does this mean we should de-support pvgrub? Or even remove it? > > BTW, I don't see any reason why someone would want to keep using pvgrub > with grub-pv being available... I went to change its status in SUPPORT.md and

[PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv

2021-08-19 Thread Ian Jackson
We can no longer conveniently even test pv-grub1; osstest tests for this have just been dropped from all Xen branches (by osstest.git#8dee6e333622). This is without prejudice to its eventual removal. We should perhaps proceed cautiously with that since it may be helpful for some old guests. Unde

Re: [XEN RFC PATCH 04/40] xen/arm: return default DMA bit width when platform is not set

2021-08-19 Thread Julien Grall
Hi, On 11/08/2021 11:23, Wei Chen wrote: From: Hongda Deng In current code, arch_get_dma_bitsize will return 32 when platorm or platform->dma_bitsize is not set. It's not resonable, for Arm, s/resonable/reasonable/ we don't require to reserve DMA memory. So we set dma_bitsize always be 0.

Re: [XEN RFC PATCH 05/40] xen/arm: Fix lowmem_bitsize when arch_get_dma_bitsize return 0

2021-08-19 Thread Julien Grall
Hi, I guess this patch may be dropped after my comment on patch #4. I will comment just on the process. On 11/08/2021 11:23, Wei Chen wrote: From: Hongda Deng In previous patch, we make arch_get_dma_bitsize return 0 when dma_bitsize and platform->dma_bitsize are not set. But this will affec

Re: [XEN RFC PATCH 07/40] xen/arm: use !CONFIG_NUMA to keep fake NUMA API

2021-08-19 Thread Julien Grall
Hi Wei, On 11/08/2021 11:23, Wei Chen wrote: Only Arm64 supports NUMA, the CONFIG_NUMA could not be enabled for Arm32. What do you mean by "could not be enabled"? Even in Arm64, users still can disable the CONFIG_NUMA through Kconfig option. In this case, keep current fake NUMA API, will mak

Re: [XEN RFC PATCH 17/40] xen/arm: Introduce DEVICE_TREE_NUMA Kconfig for arm64

2021-08-19 Thread Julien Grall
Hi, On 11/08/2021 11:24, Wei Chen wrote: We need a Kconfig option to distinguish with ACPI based NUMA. So we introduce the new Kconfig option: DEVICE_TREE_NUMA in this patch for Arm64. Signed-off-by: Wei Chen --- xen/arch/arm/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff -

Re: [PATCH v1 10/14] xen/arm: Discovering PCI devices and add the PCI devices in XEN.

2021-08-19 Thread Jan Beulich
On 19.08.2021 14:35, Julien Grall wrote: > On 19/08/2021 13:02, Rahul Singh wrote: >> Hardware domain is in charge of doing the PCI enumeration and will >> discover the PCI devices and then will communicate to XEN via hyper >> call PHYSDEVOP_pci_device_add to add the PCI devices in XEN. > > There

Re: [XEN RFC PATCH 00/40] Add device tree based NUMA support to Arm64

2021-08-19 Thread Julien Grall
Hi Wei, On 11/08/2021 11:23, Wei Chen wrote: Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and sche

Re: [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv

2021-08-19 Thread Juergen Gross
On 19.08.21 15:26, Ian Jackson wrote: We can no longer conveniently even test pv-grub1; osstest tests for this have just been dropped from all Xen branches (by osstest.git#8dee6e333622). This is without prejudice to its eventual removal. We should perhaps proceed cautiously with that since it m

Re: [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv

2021-08-19 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv"): > Probably, yes. OTOH keeping just old binaries should work without > any problem. This might be worth considering. Mmm. > > +### x86/HVM pvgrub1 (aka stubdom pv-grub) > > s/HVM/PV/ Oops, fixed

Re: [XEN RFC PATCH 00/40] Add device tree based NUMA support to Arm64

2021-08-19 Thread Bertrand Marquis
Hi Julien, > On 19 Aug 2021, at 14:42, Julien Grall wrote: > > Hi Wei, > > On 11/08/2021 11:23, Wei Chen wrote: >> Xen memory allocation and scheduler modules are NUMA aware. >> But actually, on x86 has implemented the architecture APIs >> to support NUMA. Arm was providing a set of fake archit

"failed to free memory for the domain" from "xl create"

2021-08-19 Thread Jan Beulich
Hello, besides there not having been any indication what has gone wrong (if anything in the first place), I wonder in how far the operation of freemem() / libxl_wait_for_memory_target() is fully suitable for all possible scenarios. I did create the guest in question on a Dom0 running in strict mod

Re: Some questions about virtio-net on Xen x86

2021-08-19 Thread Anthony PERARD
On Thu, Aug 19, 2021 at 10:38:49AM +, Jiamei Xie wrote: > Hi all, > I tried to run virtio-net on X86 machine according to the Wiki page > https://wiki.xenproject.org/wiki/Virtio_On_Xen. > And I Encountered some confusing problems. > > It seems eth0 is not virtio-net, properly a pv-net. I am

Re: [PATCH v1 01/14] xen/pci: Refactor MSI code that implements MSI functionality within XEN

2021-08-19 Thread Rahul Singh
Hi Julien, > On 19 Aug 2021, at 1:18 pm, Julien Grall wrote: > > Hi Rahul, > > On 19/08/2021 13:02, Rahul Singh wrote: >> MSI code that implements MSI functionality to support MSI within XEN is >> not usable on ARM. Move the code under CONFIG_HAS_PCI_MSI flag to gate > > Can you clarify what y

Re: [PATCH v2 04/13] libxenguest: short-circuit "all-dirty" handling

2021-08-19 Thread Juergen Gross
On 05.07.21 17:13, Jan Beulich wrote: For one it is unnecessary to fill a perhaps large chunk of memory with all ones. Add a new parameter to send_dirty_pages() for callers to indicate so. Then it is further unnecessary to allocate the dirty bitmap altogether when all that's ever going to happen

Re: [PATCH v2 05/13] libxenguest: avoid allocating unused deferred-pages bitmap

2021-08-19 Thread Juergen Gross
On 05.07.21 17:14, Jan Beulich wrote: Like for the dirty bitmap, it is unnecessary to allocate the deferred- pages bitmap when all that's ever going to happen is a single all-dirty run. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Descripti

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Juergen Gross
On 19.08.21 13:51, Jan Beulich wrote: On 19.08.2021 13:25, Juergen Gross wrote: On 19.08.21 13:06, Jan Beulich wrote: On 19.08.2021 12:20, Juergen Gross wrote: On 05.07.21 17:13, Jan Beulich wrote: In send_memory_live() the precise value the dirty_count struct field gets initialized to doesn'

[qemu-mainline test] 164244: regressions - FAIL

2021-08-19 Thread osstest service owner
flight 164244 qemu-mainline real [real] flight 164256 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164244/ http://logs.test-lab.xenproject.org/osstest/logs/164256/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[xen-unstable-smoke test] 164254: tolerable all pass - PUSHED

2021-08-19 Thread osstest service owner
flight 164254 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/164254/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 1/3] x86/spec-ctrl: Split the "Hardware features" diagnostic line

2021-08-19 Thread Jan Beulich
On 17.08.2021 16:30, Andrew Cooper wrote: > Separate the read-only hints from the features requiring active actions on > Xen's behalf. > > Also take the opportunity split the IBRS/IBPB and IBPB mess. More features > with overlapping enumeration are on the way, and and it is not useful to split >

Re: [PATCH 2/3] x86/amd: Enumeration for speculative features/hints

2021-08-19 Thread Jan Beulich
On 17.08.2021 16:30, Andrew Cooper wrote: > There is a step change in speculation protections between the Zen1 and Zen2 > microarchitectures. > > Zen1 and older have no special support. Control bits in non-architectural > MSRs are used to make lfence be dispatch-serialising (Spectre v1), and to >

Re: [PATCH 3/3] x86/amd: Use newer SSBD mechanisms if they exist

2021-08-19 Thread Jan Beulich
On 17.08.2021 16:30, Andrew Cooper wrote: > The opencoded legacy Memory Disambiguation logic in init_amd() neglected > Fam19h for the Zen3 microarchitecture. > > In practice, all Zen2 based system (AMD Fam17h Model >= 0x30 and Hygon Fam18h > Model >= 0x4) have the architectural MSR_SPEC_CTRL and t

Re: Xen 4.16: Proposed release manager and schedule

2021-08-19 Thread Ian Jackson
Jan Beulich writes ("Re: Xen 4.16: Proposed release manager and schedule"): > On 18.08.2021 17:09, Ian Jackson wrote: > > ** DRAFT ** > > > > Friday 17th September Last posting date > > > > Patches adding new features should be posted to the mailing list > > by this cate

preparations for 4.15.1 and 4.13.4 support linear p2m table [and 1 more messages]

2021-08-19 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH-4.15] tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table"): > Ping? Jan Beulich writes ("preparations for 4.15.1 and 4.13.4"): > the releases are due in a couple of weeks time (and 4.14.3 is > supposed to follow another few weeks later). Plea

Re: [PATCH v2 2/2] ns16550: add Exar PCIe UART cards support

2021-08-19 Thread Jan Beulich
On 18.08.2021 14:16, Marek Marczykowski-Górecki wrote: > @@ -169,6 +172,29 @@ static void handle_dw_usr_busy_quirk(struct ns16550 > *uart) > } > } > > +static void enable_exar_enhanced_bits(struct ns16550 *uart) Afaics the parameter can be pointer-to-const. > +{ > +#ifdef NS16550_PCI > +

Re: [PATCH v2 2/2] ns16550: add Exar PCIe UART cards support

2021-08-19 Thread Marek Marczykowski-Górecki
On Thu, Aug 19, 2021 at 05:57:21PM +0200, Jan Beulich wrote: > On 18.08.2021 14:16, Marek Marczykowski-Górecki wrote: > > @@ -169,6 +172,29 @@ static void handle_dw_usr_busy_quirk(struct ns16550 > > *uart) > > } > > } > > > > +static void enable_exar_enhanced_bits(struct ns16550 *uart) >

Re: [PATCH-4.15] tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table

2021-08-19 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH-4.15] tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table"): > PING!!! Sorry. I have reviewed this and I think it is good to backport, so Reviewed-by: Ian Jackson and queued. I'll push it to staging-4.15 later today. Ian.

Re: [PATCH v2 2/2] ns16550: add Exar PCIe UART cards support

2021-08-19 Thread Marek Marczykowski-Górecki
On Thu, Aug 19, 2021 at 06:01:31PM +0200, Marek Marczykowski-Górecki wrote: > On Thu, Aug 19, 2021 at 05:57:21PM +0200, Jan Beulich wrote: > > On 18.08.2021 14:16, Marek Marczykowski-Górecki wrote: > > > @@ -169,6 +172,29 @@ static void handle_dw_usr_busy_quirk(struct ns16550 > > > *uart) > > >

QEMU 6.0+ in 4.15 and 4.14 (Re: preparations for 4.15.1 and 4.13.4)

2021-08-19 Thread Ian Jackson
Anthony PERARD writes ("Re: preparations for 4.15.1 and 4.13.4"): > Can we backport support of QEMU 6.0 to Xen 4.15? I'm pretty sure > distributions are going to want to use the latest QEMU and latest Xen, > without needed to build two different QEMU binaries. I think this is appropriate. Xen 4.1

[PATCH] x86/spec-ctrl: Skip RSB overwriting when safe to do so

2021-08-19 Thread Andrew Cooper
In some configurations, it is safe to not overwrite the RSB on entry to Xen. Both Intel and AMD have guidelines in this area, because of the performance difference it makes for native kernels. A simple microperf test, measuring the amount of time a XENVER_version hypercall takes, shows the followi

Re: preparations for 4.15.1 and 4.13.4 [and 1 more messages]

2021-08-19 Thread Ian Jackson
Jan Beulich writes ("preparations for 4.15.1 and 4.13.4"): > Ian: I did take the liberty to backport Anthony's > > 5d3e4ebb5c71 libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype Thanks. > Beyond this I'd like the following to be considered: > > 6409210a5f51 libxencall: osdep_hypercal

Re: preparations for 4.15.1 and 4.13.4

2021-08-19 Thread Ian Jackson
Olaf Hering writes ("Re: preparations for 4.15.1 and 4.13.4"): > Am Thu, 15 Jul 2021 09:58:24 +0200 > schrieb Jan Beulich : > > > Please point out backports you find missing from the respective staging > > branches, but which you consider relevant. > > Depending on how green the CI is supposed t

Re: preparations for 4.15.1 and 4.13.4

2021-08-19 Thread Ian Jackson
Jan Beulich writes ("Re: preparations for 4.15.1 and 4.13.4"): > On 15.07.2021 09:58, Jan Beulich wrote: > > Beyond this I'd like the following to be considered: > > > > 6409210a5f51 libxencall: osdep_hypercall() should return long > > bef64f2c0019 libxencall: introduce variant of xencall2() retur

Re: preparations for 4.15.1 and 4.13.4 [and 1 more messages]

2021-08-19 Thread Ian Jackson
Ian Jackson writes ("Re: preparations for 4.15.1 and 4.13.4 [and 1 more messages]"): > Jan Beulich writes ("preparations for 4.15.1 and 4.13.4"): > > The ABI called VERS_1.2 must be identical on all older branches to avoid > > binary problems when rebuilding a package against old-xen+updates, and

Re: preparations for 4.15.1 and 4.13.4 [and 1 more messages]

2021-08-19 Thread Andrew Cooper
On 19/08/2021 17:43, Ian Jackson wrote: > Jan Beulich writes ("preparations for 4.15.1 and 4.13.4"): >> Ian: I did take the liberty to backport Anthony's >> >> 5d3e4ebb5c71 libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype > Thanks. > >> Beyond this I'd like the following to be considere

Re: preparations for 4.15.1 and 4.13.4 [and 1 more messages]

2021-08-19 Thread Ian Jackson
Ian Jackson writes ("Re: preparations for 4.15.1 and 4.13.4 [and 1 more messages]"): > I thought of a better way to do this. See below for proposed patch to > xen.git#staging. We discussed this on IRC, and I'm going to drop this patch. Ian. 18:00 <@andyhhp> I'm debating what to say there 18:01

Re: [XEN RFC PATCH 00/40] Add device tree based NUMA support to Arm64

2021-08-19 Thread Julien Grall
On 19/08/2021 15:05, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 19 Aug 2021, at 14:42, Julien Grall wrote: Hi Wei, On 11/08/2021 11:23, Wei Chen wrote: Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to supp

Re: [PATCH] libs/guest: Move the guest ABI check earlier into xc_dom_parse_image()

2021-08-19 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH] libs/guest: Move the guest ABI check earlier into xc_dom_parse_image()"): > On 17/08/2021 16:19, Jane Malalane wrote: > > Xen may not support 32-bit PV guest for a number of reasons (lack of > > CONFIG_PV32, explicit pv=no-32 command line argument, or implicitly

Re: [XEN RFC PATCH 18/40] xen/arm: Keep memory nodes in dtb for NUMA when boot from EFI

2021-08-19 Thread Julien Grall
Hi Wei, On 11/08/2021 11:24, Wei Chen wrote: EFI can get memory map from EFI system table. But EFI system table doesn't contain memory NUMA information, EFI depends on ACPI SRAT or device tree memory node to parse memory blocks' NUMA mapping. But in current code, when Xen is booting from EFI, i

Re: [XEN RFC PATCH 21/40] xen/arm: introduce device_tree_numa as a switch for device tree NUMA

2021-08-19 Thread Julien Grall
Hi Wei, On 11/08/2021 11:24, Wei Chen wrote: Like acpi_numa in x86 as a switch for ACPI based NUMA, we introduce device_tree_numa as a switch for Arm device tree based NUMA. When NUMA information in device tree is invalid, this switch will be set to -1, then NUMA support for Arm will be disabled

Re: [XEN RFC PATCH 22/40] xen/arm: introduce a helper to parse device tree processor node

2021-08-19 Thread Julien Grall
Hi Wei, On 11/08/2021 11:24, Wei Chen wrote: Processor NUMA ID information is stored in device tree's processor node as "numa-node-id". We need a new helper to parse this ID from processor node. If we get this ID from processor node, this ID's validity still need to be checked. Once we got a inv

  1   2   >