On Thu, Aug 19, 2021 at 06:01:31PM +0200, Marek Marczykowski-Górecki wrote: > On Thu, Aug 19, 2021 at 05:57:21PM +0200, Jan Beulich wrote: > > On 18.08.2021 14:16, Marek Marczykowski-Górecki wrote: > > > @@ -169,6 +172,29 @@ static void handle_dw_usr_busy_quirk(struct ns16550 > > > *uart) > > > } > > > } > > > > > > +static void enable_exar_enhanced_bits(struct ns16550 *uart) > > > > Afaics the parameter can be pointer-to-const.
ns_read_reg()/ns_write_reg() lack const, so not really. They could gain a const, though. > Ok, indeed with checking just uart->param - uart_param, I can get rid of > pci_conf_read here entirely. And so the #ifdef won't be necessary > either. #ifdef needs to stay, because uart_param is PCI-only. Not a big deal. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab
signature.asc
Description: PGP signature
