Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks

2021-04-07 Thread Roger Pau Monné
On Thu, Apr 01, 2021 at 01:06:35PM +0200, Jan Beulich wrote: > On 31.03.2021 12:32, Roger Pau Monne wrote: > > EOIs are always executed in guest vCPU context, so there's no reason to > > pass a vCPU parameter around as can be fetched from current. > > While not overly problematic, I'd like to poin

Re: [PATCH 5/5] x86: don't build unused entry code when !PV32

2021-04-07 Thread Jan Beulich
On 06.04.2021 19:34, Andrew Cooper wrote: > On 01/04/2021 15:37, Jan Beulich wrote: >> On 01.04.2021 16:31, Andrew Cooper wrote: >>> On 25/11/2020 08:51, Jan Beulich wrote: @@ -102,19 +102,21 @@ void __dummy__(void) BLANK(); #endif -#ifdef CONFIG_PV +#ifdef CON

Re: [edk2-devel] [PATCH v2 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h

2021-04-07 Thread Laszlo Ersek
On 03/26/21 15:16, Lendacky, Thomas wrote: > On 3/25/21 10:47 AM, Anthony PERARD wrote: >> We are going to use the page table structure in yet another place, >> collect the types and macro that can be used from another module >> rather that making yet another copy. >> >> Ref: https://bugzilla.tiano

Re: [edk2-devel] [PATCH v2 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h

2021-04-07 Thread Laszlo Ersek
On 03/25/21 16:47, Anthony PERARD via groups.io wrote: > We are going to use the page table structure in yet another place, > collect the types and macro that can be used from another module > rather that making yet another copy. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 > Signe

Re: [edk2-devel] [PATCH v2 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h

2021-04-07 Thread Laszlo Ersek
On 03/25/21 16:47, Anthony PERARD via groups.io wrote: > We are going to use the page table structure in yet another place, > collect the types and macro that can be used from another module > rather that making yet another copy. s/rather that/rather than/

Re: [edk2-devel] [PATCH v2 5/7] OvmfPkg/XenPlatformPei: Map extra physical address

2021-04-07 Thread Laszlo Ersek
On 03/25/21 16:47, Anthony PERARD via groups.io wrote: > Some information available in a Xen guest can be mapped anywhere in > the physical address space and they don't need to be backed by RAM. > For example, the shared info page. > > While it's easier to put those pages anywhere, it is better to

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Jan Beulich
On 06.04.2021 23:46, Stefano Stabellini wrote: > On Tue, 6 Apr 2021, Jan Beulich wrote: >> On 06.04.2021 12:36, Luca Fancellu wrote: >>> Modification to include/public/grant_table.h: >>> >>> 1) Change anonymous structure to be named structure, >>>because doxygen can't deal with them. >> >> Espe

Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks

2021-04-07 Thread Jan Beulich
On 07.04.2021 09:41, Roger Pau Monné wrote: > On Thu, Apr 01, 2021 at 01:06:35PM +0200, Jan Beulich wrote: >> On 31.03.2021 12:32, Roger Pau Monne wrote: >>> EOIs are always executed in guest vCPU context, so there's no reason to >>> pass a vCPU parameter around as can be fetched from current. >> >

Re: [PATCH 02/14] xen/sched: Constify name and opt_name in struct scheduler

2021-04-07 Thread Jan Beulich
On 06.04.2021 20:24, Julien Grall wrote: > Hi Jan, > > On 06/04/2021 09:07, Jan Beulich wrote: >> On 05.04.2021 17:57, Julien Grall wrote: >>> From: Julien Grall >>> >>> Both name and opt_name are pointing to literal string. So mark both of >>> the fields as const. >>> >>> Signed-off-by: Julien G

Re: [edk2-devel] [PATCH v2 6/7] OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency

2021-04-07 Thread Laszlo Ersek
On 03/25/21 16:47, Anthony PERARD via groups.io wrote: > Calculate the frequency of the APIC timer that Xen provides. > > Even though the frequency is currently hard-coded, it isn't part of > the public ABI that Xen provides and thus may change at any time. OVMF > needs to determine the frequency

Re: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers

2021-04-07 Thread Jan Beulich
On 06.04.2021 21:34, Julien Grall wrote: > Hi Jan, > > On 01/04/2021 16:23, Jan Beulich wrote: >> On 01.04.2021 16:56, Julien Grall wrote: >>> On 01/04/2021 11:19, Jan Beulich wrote: --- a/xen/common/lib.c +++ b/xen/lib/divmod.c @@ -40,7 +40,6 @@ * OUT OF THE USE OF THIS SO

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Luca Fancellu
> On 7 Apr 2021, at 09:10, Jan Beulich wrote: > > On 06.04.2021 23:46, Stefano Stabellini wrote: >> On Tue, 6 Apr 2021, Jan Beulich wrote: >>> On 06.04.2021 12:36, Luca Fancellu wrote: Modification to include/public/grant_table.h: 1) Change anonymous structure to be named struc

[linux-linus test] 160769: regressions - FAIL

2021-04-07 Thread osstest service owner
flight 160769 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160769/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Jan Beulich
On 07.04.2021 10:42, Luca Fancellu wrote: > Just to be sure that we are in the same page, are you suggesting to modify > the name > In this way? > > struct gnttab_cache_flush { > -union { > +union xen_gnttab_cache_flush_a { > uint64_t dev_bus_addr; > grant_ref_t ref; >

Re: [PATCH 02/14] xen/sched: Constify name and opt_name in struct scheduler

2021-04-07 Thread Julien Grall
Hi Jan, On 07/04/2021 09:22, Jan Beulich wrote: On 06.04.2021 20:24, Julien Grall wrote: Hi Jan, On 06/04/2021 09:07, Jan Beulich wrote: On 05.04.2021 17:57, Julien Grall wrote: From: Julien Grall Both name and opt_name are pointing to literal string. So mark both of the fields as const.

Re: [PATCH] xen/page_alloc: Remove dead code in alloc_domheap_pages()

2021-04-07 Thread Jan Beulich
On 06.04.2021 21:22, Julien Grall wrote: > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -457,6 +457,12 @@ static long total_avail_pages; > static DEFINE_SPINLOCK(heap_lock); > static long outstanding_claims; /* total outstanding claims by all domains */ > > +static void __

Re: [edk2-devel] [PATCH v2 7/7] OvmfPkg/OvmfXen: Set PcdFSBClock

2021-04-07 Thread Laszlo Ersek
On 03/25/21 16:47, Anthony PERARD via groups.io wrote: > Update gEfiMdePkgTokenSpaceGuid.PcdFSBClock so it can have the correct > value when SecPeiDxeTimerLibCpu start to use it for the APIC timer. > > Currently, nothing appear to use the value in PcdFSBClock before > XenPlatformPei had a chance t

[libvirt test] 160783: regressions - FAIL

2021-04-07 Thread osstest service owner
flight 160783 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160783/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH] xen/page_alloc: Don't hold the heap_lock when clearing PGC_need_scrub

2021-04-07 Thread Jan Beulich
On 06.04.2021 21:30, Julien Grall wrote: > From: Julien Grall > > Currently, the heap_lock is held when clearing PGC_need_scrub in > alloc_heap_pages(). However, this is unnecessary because the only caller > (mark_page_offline()) that can concurrently modify the count_info is > using cmpxchg() in

Re: [edk2-devel] [PATCH v2 0/7] OvmfXen: Set PcdFSBClock at runtime

2021-04-07 Thread Laszlo Ersek
On 03/25/21 16:47, Anthony PERARD via groups.io wrote: > Patch series available in this git branch: > git://xenbits.xen.org/people/aperard/ovmf.git br.apic-timer-freq-v2 > > Changes in v2: > - main change is to allow mapping of Xen pages outside of the RAM > see patch: "OvmfPkg/XenPlatformPei: M

[PATCH] docs: release-technician-checklist: update to leaf tree version pinning

2021-04-07 Thread Jan Beulich
Our releases look to flip-flop between keeping or discarding the date and title of the referenced qemu-trad commit. I think with the hash replaced by a tag, the commit's date and title would better also be purged. Signed-off-by: Jan Beulich --- I've been noticing this inconsistency repeatedly bec

[xen-unstable-coverity test] 160790: all pass - PUSHED

2021-04-07 Thread osstest service owner
flight 160790 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/160790/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 19be4d56a1f7aa65eb4d92276fa5d386e9cb2a62 baseline version: xen 0435

Re: [PATCH 2/2] xen/gunzip: Allow perform_gunzip() to be called multiple times

2021-04-07 Thread Jan Beulich
On 02.04.2021 17:21, Julien Grall wrote: > --- a/xen/common/inflate.c > +++ b/xen/common/inflate.c > @@ -238,6 +238,12 @@ STATIC const ush mask_bits[] = { > static unsigned long INITDATA malloc_ptr; > static int INITDATA malloc_count; > > +static void init_allocator(void) > +{ > +malloc_ptr

Re: [PATCH 0/3] Use Doxygen and sphinx for html documentation

2021-04-07 Thread Andrew Cooper
On 06/04/2021 22:24, Stefano Stabellini wrote: > On Tue, 6 Apr 2021, Andrew Cooper wrote: >> On 06/04/2021 11:36, Luca Fancellu wrote: >>> This serie introduce doxygen in the sphinx html docs generation. >>> One benefit is to keep most of the documentation in the source >>> files of xen so that it'

Re: [PATCH] xen/evtchn: Change irq_info lock to raw_spinlock_t

2021-04-07 Thread Wei Liu
On Tue, Apr 06, 2021 at 11:51:04AM +0100, Luca Fancellu wrote: > Unmask operation must be called with interrupt disabled, > on preempt_rt spin_lock_irqsave/spin_unlock_irqrestore > don't disable/enable interrupts, so use raw_* implementation > and change lock variable in struct irq_info from spinlo

Re: [PATCH 0/3] Use Doxygen and sphinx for html documentation

2021-04-07 Thread Bertrand Marquis
Hi Andrew, > On 7 Apr 2021, at 12:15, Andrew Cooper wrote: > > On 06/04/2021 22:24, Stefano Stabellini wrote: >> On Tue, 6 Apr 2021, Andrew Cooper wrote: >>> On 06/04/2021 11:36, Luca Fancellu wrote: This serie introduce doxygen in the sphinx html docs generation. One benefit is to kee

Re: [PATCH 0/3] Use Doxygen and sphinx for html documentation

2021-04-07 Thread Julien Grall
On 06/04/2021 11:36, Luca Fancellu wrote: This serie introduce doxygen in the sphinx html docs generation. One benefit is to keep most of the documentation in the source files of xen so that it's more maintainable, on the other hand there are some limitation of doxygen that must be addressed m

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Julien Grall
Hi, On 06/04/2021 11:36, Luca Fancellu wrote: Modification to include/public/grant_table.h: 1) Change anonymous structure to be named structure, because doxygen can't deal with them. What do you mean by can't deal with them? I had a quick try with doxygen build and couldn't find any fail

Re: [PATCH 0/3] Use Doxygen and sphinx for html documentation

2021-04-07 Thread Luca Fancellu
> On 7 Apr 2021, at 14:07, Julien Grall wrote: > > > > On 06/04/2021 11:36, Luca Fancellu wrote: >> This serie introduce doxygen in the sphinx html docs generation. >> One benefit is to keep most of the documentation in the source >> files of xen so that it's more maintainable, on the other

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Luca Fancellu
> On 7 Apr 2021, at 14:13, Julien Grall wrote: > > Hi, > > On 06/04/2021 11:36, Luca Fancellu wrote: >> Modification to include/public/grant_table.h: >> 1) Change anonymous structure to be named structure, >>because doxygen can't deal with them. > > What do you mean by can't deal with th

[xen-unstable-smoke test] 160792: tolerable all pass - PUSHED

2021-04-07 Thread osstest service owner
flight 160792 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160792/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-unstable test] 160776: regressions - FAIL

2021-04-07 Thread osstest service owner
flight 160776 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160776/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken in 160665 test-armhf-armhf-xl-arndale

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Julien Grall
Hi Luca, On 07/04/2021 14:19, Luca Fancellu wrote: On 7 Apr 2021, at 14:13, Julien Grall wrote: Hi, On 06/04/2021 11:36, Luca Fancellu wrote: Modification to include/public/grant_table.h: 1) Change anonymous structure to be named structure, because doxygen can't deal with them. What

Re: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers

2021-04-07 Thread Julien Grall
On 07/04/2021 09:33, Jan Beulich wrote: On 06.04.2021 21:34, Julien Grall wrote: Hi Jan, On 01/04/2021 16:23, Jan Beulich wrote: On 01.04.2021 16:56, Julien Grall wrote: On 01/04/2021 11:19, Jan Beulich wrote: --- a/xen/common/lib.c +++ b/xen/lib/divmod.c @@ -40,7 +40,6 @@ * OUT OF T

[BUG] usb devices disappear on xl reboot or reboot from inside of HVM DomU

2021-04-07 Thread Petr Fedchenkov
Hi. I have the HVM DomU with usb device assigned to it Config for xl: # This file is automatically generated by domainmgr name = "12e26d98-2f0d-450c-a1ee-d287bd37794c.1.1" type = "hvm" uuid = "12e26d98-2f0d-450c-a1ee-d287bd37794c" vnc = 0 memory = 977 maxmem = 977 vcpus = 1 maxcpus = 1 b

[PATCH 0/3] xen-pciback: a fix, a workaround, and some simplification

2021-04-07 Thread Jan Beulich
The first change completes a several years old but still incomplete change. As mentioned there, reverting the original change may also be an option. The second change works around some odd libxl behavior, as described in [1]. As per a response to that mail addressing the issue in libxl may also be

[PATCH 1/3] xen-pciback: redo VF placement in the virtual topology

2021-04-07 Thread Jan Beulich
The commit referenced below was incomplete: It merely affected what would get written to the vdev- xenstore node. The guest would still find the function at the original function number as long as __xen_pcibk_get_pci_dev() wouldn't be in sync. The same goes for AER wrt __xen_pcibk_get_pcifront_dev

[PATCH 2/3] xen-pciback: reconfigure also from backend watch handler

2021-04-07 Thread Jan Beulich
When multiple PCI devices get assigned to a guest right at boot, libxl incrementally populates the backend tree. The writes for the first of the devices trigger the backend watch. In turn xen_pcibk_setup_backend() will set the XenBus state to Initialised, at which point no further reconfigures woul

[PATCH 3/3] xen-pciback: simplify vpci's find hook

2021-04-07 Thread Jan Beulich
There's no point in comparing SBDF - we can simply compare the struct pci_dev pointers. If they weren't the same for a given device, we'd have bigger problems from having stored a stale pointer. Signed-off-by: Jan Beulich --- a/drivers/xen/xen-pciback/vpci.c +++ b/drivers/xen/xen-pciback/vpci.c

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Luca Fancellu
> On 7 Apr 2021, at 14:56, Julien Grall wrote: > > Hi Luca, > > On 07/04/2021 14:19, Luca Fancellu wrote: >>> On 7 Apr 2021, at 14:13, Julien Grall wrote: >>> >>> Hi, >>> >>> On 06/04/2021 11:36, Luca Fancellu wrote: Modification to include/public/grant_table.h: 1) Change anonymo

Re: [PATCH v3 03/11] x86/vlapic: introduce an EOI callback mechanism

2021-04-07 Thread Jan Beulich
On 31.03.2021 12:32, Roger Pau Monne wrote: > Add a new vlapic_set_irq_callback helper in order to inject a vector > and set a callback to be executed when the guest performs the end of > interrupt acknowledgment. > > Such functionality will be used to migrate the current ad hoc handling > done in

Re: [PATCH v3 04/11] x86/vmsi: use the newly introduced EOI callbacks

2021-04-07 Thread Jan Beulich
On 31.03.2021 12:32, Roger Pau Monne wrote: > Remove the unconditional call to hvm_dpci_msi_eoi in vlapic_handle_EOI > and instead use the newly introduced EOI callback mechanism in order > to register a callback for MSI vectors injected from passed through > devices. > > This avoids having multip

Re: [XEN PATCH for-4.15] libxl: Replace deprecated QMP command by "query-cpus-fast"

2021-04-07 Thread Anthony PERARD
On Thu, Apr 01, 2021 at 04:24:54PM +0200, Olaf Hering wrote: > Am Mon, 22 Mar 2021 14:17:44 + > schrieb Anthony PERARD : > > > We use the deprecated QMP command "query-cpus" > > There is also the already removed "cpu-add" command used, which apparently > has to be replaced by "device_add". >

Re: [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism

2021-04-07 Thread Jan Beulich
On 31.03.2021 12:32, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/vioapic.c > +++ b/xen/arch/x86/hvm/vioapic.c > @@ -394,6 +394,50 @@ static const struct hvm_mmio_ops vioapic_mmio_ops = { > .write = vioapic_write > }; > > +static void eoi_callback(unsigned int vector, void *data) > +{ >

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Ian Jackson
Luca Fancellu writes ("Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h"): > The problem is that Doxygen can’t generate proper documentation for anonymous > union/structure, it ends up with warning and/or producing wrong documentation > like > changing names or giving field

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Bertrand Marquis
Hi Ian, > On 7 Apr 2021, at 16:19, Ian Jackson wrote: > > Luca Fancellu writes ("Re: [PATCH 3/3] docs/doxygen: doxygen documentation > for grant_table.h"): >> The problem is that Doxygen can’t generate proper documentation for >> anonymous union/structure, it ends up with warning and/or produc

Re: [PATCH v3 0/3] Generic SMMU Bindings

2021-04-07 Thread Rahul Singh
Hi Stefano, > On 7 Apr 2021, at 12:59 am, Stefano Stabellini wrote: > > On Mon, 5 Apr 2021, Julien Grall wrote: >> On 26/01/2021 22:58, Stefano Stabellini wrote: >>> Hi all, >> >> Hi Stefano, >> >>> This series introduces support for the generic SMMU bindings to >>> xen/drivers/passthrough/arm

Re: [PATCH v3 06/11] x86/hvm: allowing registering EOI callbacks for GSIs

2021-04-07 Thread Jan Beulich
On 31.03.2021 12:32, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -595,6 +595,69 @@ int hvm_local_events_need_delivery(struct vcpu *v) > return !hvm_interrupt_blocked(v, intack); > } > > +int hvm_gsi_register_callback(struct domain *d, unsigned i

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Jan Beulich
On 07.04.2021 17:29, Bertrand Marquis wrote: >> On 7 Apr 2021, at 16:19, Ian Jackson wrote: >> >> Luca Fancellu writes ("Re: [PATCH 3/3] docs/doxygen: doxygen documentation >> for grant_table.h"): >>> The problem is that Doxygen can’t generate proper documentation for >>> anonymous union/structu

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Julien Grall
On 07/04/2021 16:29, Bertrand Marquis wrote: Hi Ian, On 7 Apr 2021, at 16:19, Ian Jackson wrote: Luca Fancellu writes ("Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h"): The problem is that Doxygen can’t generate proper documentation for anonymous union/structure,

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Bertrand Marquis
Hi Julien, > On 7 Apr 2021, at 16:55, Julien Grall wrote: > > > > On 07/04/2021 16:29, Bertrand Marquis wrote: >> Hi Ian, >>> On 7 Apr 2021, at 16:19, Ian Jackson wrote: >>> >>> Luca Fancellu writes ("Re: [PATCH 3/3] docs/doxygen: doxygen documentation >>> for grant_table.h"): The prob

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Bertrand Marquis
Hi, > On 7 Apr 2021, at 16:54, Jan Beulich wrote: > > On 07.04.2021 17:29, Bertrand Marquis wrote: >>> On 7 Apr 2021, at 16:19, Ian Jackson wrote: >>> >>> Luca Fancellu writes ("Re: [PATCH 3/3] docs/doxygen: doxygen documentation >>> for grant_table.h"): The problem is that Doxygen can’t

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Ian Jackson
Bertrand Marquis writes ("Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h"): > Somehow in the documentation when you have a union you will need to document > that it is a union and the possible entries. I would expect to find the documentation for an anonymous struct or uni

Re: [PATCH v3 03/11] x86/vlapic: introduce an EOI callback mechanism

2021-04-07 Thread Roger Pau Monné
On Wed, Apr 07, 2021 at 04:55:43PM +0200, Jan Beulich wrote: > On 31.03.2021 12:32, Roger Pau Monne wrote: > > Add a new vlapic_set_irq_callback helper in order to inject a vector > > and set a callback to be executed when the guest performs the end of > > interrupt acknowledgment. > > > > Such fu

Re: [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism

2021-04-07 Thread Roger Pau Monné
On Wed, Apr 07, 2021 at 05:19:06PM +0200, Jan Beulich wrote: > On 31.03.2021 12:32, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/vioapic.c > > +++ b/xen/arch/x86/hvm/vioapic.c > > @@ -621,7 +624,43 @@ static int ioapic_load(struct domain *d, > > hvm_domain_context_t *h) > > d->arch.

Re: [PATCH v3 06/11] x86/hvm: allowing registering EOI callbacks for GSIs

2021-04-07 Thread Roger Pau Monné
On Wed, Apr 07, 2021 at 05:51:14PM +0200, Jan Beulich wrote: > On 31.03.2021 12:32, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/irq.c > > +++ b/xen/arch/x86/hvm/irq.c > > +void hvm_gsi_execute_callbacks(unsigned int gsi) > > +{ > > +struct hvm_irq *hvm_irq = hvm_domain_irq(current->domain

[qemu-mainline test] 160779: regressions - FAIL

2021-04-07 Thread osstest service owner
flight 160779 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160779/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i3

Re: [PATCH 2/2] xen/pci: Gate all MSI code in common code with CONFIG_HAS_PCI_MSI

2021-04-07 Thread Rahul Singh
Hi, > On 6 Apr 2021, at 4:58 pm, Roger Pau Monné wrote: > > On Tue, Apr 06, 2021 at 04:09:34PM +0100, Julien Grall wrote: >> >> >> On 06/04/2021 15:59, Roger Pau Monné wrote: >>> On Tue, Apr 06, 2021 at 03:30:01PM +0100, Julien Grall wrote: So I think we want to be able to compile out the

Re: [PATCH 2/2] xen/pci: Gate all MSI code in common code with CONFIG_HAS_PCI_MSI

2021-04-07 Thread Julien Grall
Hi Jan, On 06/04/2021 16:25, Jan Beulich wrote: On 06.04.2021 16:30, Julien Grall wrote: Hi Roger, On 06/04/2021 15:13, Roger Pau Monné wrote: On Tue, Apr 06, 2021 at 12:39:11PM +0100, Rahul Singh wrote: MSI support is not implemented for ARM architecture but it is enabled for x86 architectu

Re: [PATCH 2/2] xen/gunzip: Allow perform_gunzip() to be called multiple times

2021-04-07 Thread Julien Grall
Hi Jan, On 07/04/2021 11:39, Jan Beulich wrote: On 02.04.2021 17:21, Julien Grall wrote: --- a/xen/common/inflate.c +++ b/xen/common/inflate.c @@ -238,6 +238,12 @@ STATIC const ush mask_bits[] = { static unsigned long INITDATA malloc_ptr; static int INITDATA malloc_count; +static void in

[PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7

2021-04-07 Thread Julien Grall
From: Julien Grall The compilation will fail when building Xen with clang and CONFIG_DEBUG=y: make[4]: Leaving directory '/oss/xen/xen/common/libelf' INIT_O gunzip.init.o Error: size of gunzip.o:.text is 0x0019 This is because the function init_allocator() will not be inlined and is not

Re: [PATCH 0/2] Introducing hyperlaunch capability design (formerly: DomB mode of dom0less)

2021-04-07 Thread Christopher Clark
On Tue, Mar 30, 2021 at 7:31 AM Jan Beulich wrote: > > On 16.03.2021 04:56, Daniel P. Smith wrote: > > To assist in reading, please find attached rendered copies of the design > > docs. It should be noted that due to poor rendering by pandoc, we forced > > the tables to stay as ASCII tables in the

Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document

2021-04-07 Thread Christopher Clark
On Thu, Mar 25, 2021 at 9:55 AM Stefano Stabellini wrote: > On Thu, 25 Mar 2021, Roger Pau Monné wrote: > > On Thu, Mar 25, 2021 at 10:14:31AM +0100, George Dunlap wrote: > > > > > > > On Mar 25, 2021, at 8:32 AM, Roger Pau Monne > > > > wrote: > > > > On Wed, Mar 24, 2021 at 05:53:26AM -0700, C

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Stefano Stabellini
On Wed, 7 Apr 2021, Jan Beulich wrote: > On 07.04.2021 10:42, Luca Fancellu wrote: > > Just to be sure that we are in the same page, are you suggesting to modify > > the name > > In this way? > > > > struct gnttab_cache_flush { > > -union { > > +union xen_gnttab_cache_flush_a { > >

Re: [PATCH] xen/evtchn: Change irq_info lock to raw_spinlock_t

2021-04-07 Thread Boris Ostrovsky
On 4/6/21 6:51 AM, Luca Fancellu wrote: > Unmask operation must be called with interrupt disabled, > on preempt_rt spin_lock_irqsave/spin_unlock_irqrestore > don't disable/enable interrupts, so use raw_* implementation > and change lock variable in struct irq_info from spinlock_t > to raw_spinloc

[xen-unstable-smoke test] 160803: tolerable all pass - PUSHED

2021-04-07 Thread osstest service owner
flight 160803 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160803/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-4.12-testing test] 160785: regressions - FAIL

2021-04-07 Thread osstest service owner
flight 160785 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160785/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken in 160709 build-armhf

[linux-linus test] 160788: regressions - FAIL

2021-04-07 Thread osstest service owner
flight 160788 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160788/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[linux-5.4 test] 160794: tolerable FAIL - PUSHED

2021-04-07 Thread osstest service owner
flight 160794 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/160794/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 160557 test-amd64-i386-xl-qemut-win7-amd64 19

[qemu-mainline bisection] complete test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow

2021-04-07 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qem

Re: multiboot2 and module2 boot issues via GRUB2

2021-04-07 Thread Glenn Washburn
On Thu, 1 Apr 2021 20:43:46 +0100 Andrew Cooper via Grub-devel wrote: > On 01/04/2021 09:44, Roger Pau Monné wrote: > > On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: > >> On 01.04.2021 03:06, Roman Shaposhnik wrote: > >>> And the obvious next question: is my EVE usecase esoteric en

Re: [PATCH 0/2] Introducing hyperlaunch capability design (formerly: DomB mode of dom0less)

2021-04-07 Thread Jan Beulich
On 07.04.2021 21:23, Christopher Clark wrote: > On Tue, Mar 30, 2021 at 7:31 AM Jan Beulich wrote: >> >> On 16.03.2021 04:56, Daniel P. Smith wrote: >>> To assist in reading, please find attached rendered copies of the design >>> docs. It should be noted that due to poor rendering by pandoc, we fo

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Jan Beulich
On 07.04.2021 23:26, Stefano Stabellini wrote: > On Wed, 7 Apr 2021, Jan Beulich wrote: >> On 07.04.2021 10:42, Luca Fancellu wrote: >>> Just to be sure that we are in the same page, are you suggesting to modify >>> the name >>> In this way? >>> >>> struct gnttab_cache_flush { >>> -union { >>>

Re: [PATCH 2/2] xen/pci: Gate all MSI code in common code with CONFIG_HAS_PCI_MSI

2021-04-07 Thread Jan Beulich
On 07.04.2021 20:06, Julien Grall wrote: > Hi Jan, > > On 06/04/2021 16:25, Jan Beulich wrote: >> On 06.04.2021 16:30, Julien Grall wrote: >>> Hi Roger, >>> >>> On 06/04/2021 15:13, Roger Pau Monné wrote: On Tue, Apr 06, 2021 at 12:39:11PM +0100, Rahul Singh wrote: > MSI support is not im

Re: [PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7

2021-04-07 Thread Jan Beulich
On 07.04.2021 20:27, Julien Grall wrote: > From: Julien Grall > > The compilation will fail when building Xen with clang and > CONFIG_DEBUG=y: > > make[4]: Leaving directory '/oss/xen/xen/common/libelf' > INIT_O gunzip.init.o > Error: size of gunzip.o:.text is 0x0019 > > This is because

Re: [PATCH v3 03/11] x86/vlapic: introduce an EOI callback mechanism

2021-04-07 Thread Jan Beulich
On 07.04.2021 18:27, Roger Pau Monné wrote: > On Wed, Apr 07, 2021 at 04:55:43PM +0200, Jan Beulich wrote: >> On 31.03.2021 12:32, Roger Pau Monne wrote: >>> Add a new vlapic_set_irq_callback helper in order to inject a vector >>> and set a callback to be executed when the guest performs the end of

Re: [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism

2021-04-07 Thread Jan Beulich
On 07.04.2021 18:46, Roger Pau Monné wrote: > On Wed, Apr 07, 2021 at 05:19:06PM +0200, Jan Beulich wrote: >> On 31.03.2021 12:32, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/vioapic.c >>> +++ b/xen/arch/x86/hvm/vioapic.c >>> @@ -621,7 +624,43 @@ static int ioapic_load(struct domain *d, >>>

Re: [PATCH v3 06/11] x86/hvm: allowing registering EOI callbacks for GSIs

2021-04-07 Thread Jan Beulich
On 07.04.2021 19:08, Roger Pau Monné wrote: > On Wed, Apr 07, 2021 at 05:51:14PM +0200, Jan Beulich wrote: >> On 31.03.2021 12:32, Roger Pau Monne wrote: >>> +bool hvm_gsi_has_callbacks(const struct domain *d, unsigned int gsi) >>> +{ >>> +struct hvm_irq *hvm_irq = hvm_domain_irq(d); >>> +b