On 31.03.2021 12:32, Roger Pau Monne wrote: > Remove the unconditional call to hvm_dpci_msi_eoi in vlapic_handle_EOI > and instead use the newly introduced EOI callback mechanism in order > to register a callback for MSI vectors injected from passed through > devices. > > This avoids having multiple callback functions open-coded in > vlapic_handle_EOI, as there is now a generic framework for registering > such callbacks. It also avoids doing an unconditional call to > hvm_dpci_msi_eoi for each EOI processed by the local APIC. > > Note that now the callback is only registered (and thus executed) when > there's an MSI interrupt originating from a PCI passthrough device > being injected into the guest, so the check in hvm_dpci_msi_eoi can be > removed as it's already done by hvm_dirq_assist which is the only > caller of vmsi_deliver_pirq. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com>