[PATCH v2] piix: fix regression during unplug in Xen HVM domUs

2021-03-17 Thread Olaf Hering
Commit ee358e919e385fdc79d59d0d47b4a81e349cd5c9 causes a regression in Xen HVM domUs which run xenlinux based kernels. If the domU has an USB device assigned, for example with "usbdevice=['tablet']" in domU.cfg, the late unplug of devices will kill the emulated USB host. As a result the khubd thre

Re: [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351

2021-03-17 Thread Roger Pau Monné
On Tue, Mar 16, 2021 at 09:20:10PM +, Andrew Cooper wrote: > On 16/03/2021 16:56, Roger Pau Monné wrote: > > On Tue, Mar 16, 2021 at 04:18:44PM +, Andrew Cooper wrote: > >> Signed-off-by: Andrew Cooper > > Thanks! > > > >> --- > >> CC: Jan Beulich > >> CC: Roger Pau Monné > >> CC: Wei Li

[ovmf test] 160106: all pass - PUSHED

2021-03-17 Thread osstest service owner
flight 160106 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160106/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2e51b27fed31eb7b2a2cb4245806c8c7859207f7 baseline version: ovmf 66a31de7eeed62a7aa68f

Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"

2021-03-17 Thread Roger Pau Monné
On Tue, Mar 16, 2021 at 04:18:42PM +, Andrew Cooper wrote: > In hindsight, this was a poor move. Some of these MSRs require probing for, > causing unhelpful spew into xl dmesg, as well as spew from unit tests > explicitly checking behaviour. > > This restores behaviour close to that of Xen 4.

Re: [PATCH 2/3] x86/msr: Forward port XSA-351 changes from 4.14

2021-03-17 Thread Roger Pau Monné
On Tue, Mar 16, 2021 at 04:18:43PM +, Andrew Cooper wrote: > staging was not impacted by XSA-351 at the time of release, due to c/s > 322ec7c89f and 84e848fd7a which disallows read access by default. > > Forward port the XSA-351 changes to make the code structure consistent between > 4.14 and

Re: [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351

2021-03-17 Thread Jan Beulich
On 16.03.2021 17:18, Andrew Cooper wrote: > @@ -284,6 +283,18 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t > *val) > goto gp_fault; > break; > > +case MSR_RAPL_POWER_UNIT: > +/* > + * This MSR is non-architectural. However, some versions of

[PATCH 0/2] xen/x86: alternative fix for XSA-369

2021-03-17 Thread Roger Pau Monne
Hello, This is a proposal for an alternative fix for XSA-369 that instead of special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG option rather than XEN_BALLOON_MEMORY_HOTPLUG. I think this is safer, as we don'

[PATCH 1/2] xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG

2021-03-17 Thread Roger Pau Monne
The Xen memory hotplug limit should depend on the memory hotplug generic option, rather than the Xen balloon configuration. It's possible to have a kernel with generic memory hotplug enabled, but without Xen balloon enabled, at which point memory hotplug won't work correctly due to the size limitat

[PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"

2021-03-17 Thread Roger Pau Monne
This partially reverts commit 882213990d32fd224340a4533f6318dd152be4b2. There's no need to special case XEN_UNPOPULATED_ALLOC anymore in order to correctly size the p2m. The generic memory hotplug option has already been tied together with the Xen hotplug limit, so enabling memory hotplug should a

[qemu-mainline test] 160104: regressions - FAIL

2021-03-17 Thread osstest service owner
flight 160104 qemu-mainline real [real] flight 160111 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160104/ http://logs.test-lab.xenproject.org/osstest/logs/160111/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[xen-unstable-coverity test] 160110: regressions - ALL FAIL

2021-03-17 Thread osstest service owner
flight 160110 xen-unstable-coverity real [real] flight 160112 xen-unstable-coverity real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160110/ http://logs.test-lab.xenproject.org/osstest/logs/160112/ Regressions :-( Tests which did not succeed and are blocking, including tests wh

Re: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation

2021-03-17 Thread Julien Grall
On 16/03/2021 17:16, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 16 Mar 2021, at 15:27, Julien Grall wrote: On 15/03/2021 13:32, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 13 Mar 2021, at 16:06, Julien Grall wrote: From: Julien Grall Hi all, Last year, Arm re

Re: [PATCH for-4.15] SUPPORT.MD: Mark C XenStored LiveUpdate as Tech Preview

2021-03-17 Thread Julien Grall
Hi Juergen, On 16/03/2021 14:58, Jürgen Groß wrote: On 16.03.21 15:39, Julien Grall wrote: On 16/03/2021 14:36, Jürgen Groß wrote: On 16.03.21 15:35, Julien Grall wrote: Hi, On 15/03/2021 12:17, Andrew Cooper wrote: On 13/03/2021 13:55, Julien Grall wrote: From: Julien Grall Support to

[PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview

2021-03-17 Thread Julien Grall
From: Julien Grall Support to liveupdate C XenStored daemon was added during the 4.15 development cycle. Add a section in SUPPORT.MD to explain what is the support state. For now, it is a tech preview. Signed-off-by: Julien Grall --- CC: Juergen Gross Changes in v2: - Clarify t

Re: [PATCH v3] xen: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped

2021-03-17 Thread Julien Grall
Hi Stefano, On 17/03/2021 00:04, Stefano Stabellini wrote: On Tue, 16 Mar 2021, Jan Beulich wrote: On 15.03.2021 21:01, Stefano Stabellini wrote: On Mon, 15 Mar 2021, Jan Beulich wrote: On 13.03.2021 00:16, Stefano Stabellini wrote: Introduce two feature flags to tell the domain whether it i

Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview

2021-03-17 Thread Jürgen Groß
On 17.03.21 12:27, Julien Grall wrote: From: Julien Grall Support to liveupdate C XenStored daemon was added during the 4.15 development cycle. Add a section in SUPPORT.MD to explain what is the support state. For now, it is a tech preview. Signed-off-by: Julien Grall Reviewed-by: Juergen

Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview

2021-03-17 Thread Andrew Cooper
On 17/03/2021 11:27, Julien Grall wrote: > From: Julien Grall > > Support to liveupdate C XenStored daemon was added during the 4.15 > development cycle. Add a section in SUPPORT.MD to explain what is the > support state. > > For now, it is a tech preview. > > Signed-off-by: Julien Grall What ab

Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview

2021-03-17 Thread Julien Grall
On 17/03/2021 11:49, Andrew Cooper wrote: On 17/03/2021 11:27, Julien Grall wrote: From: Julien Grall Support to liveupdate C XenStored daemon was added during the 4.15 development cycle. Add a section in SUPPORT.MD to explain what is the support state. For now, it is a tech preview. Sign

Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview

2021-03-17 Thread Andrew Cooper
On 17/03/2021 11:54, Julien Grall wrote: > On 17/03/2021 11:49, Andrew Cooper wrote: >> On 17/03/2021 11:27, Julien Grall wrote: >>> From: Julien Grall >>> >>> Support to liveupdate C XenStored daemon was added during the 4.15 >>> development cycle. Add a section in SUPPORT.MD to explain what is t

Re: [PATCH for-4.15 v2] SUPPORT.MD: Mark LiveUpdate of C XenStored daemon as Tech Preview

2021-03-17 Thread Julien Grall
Hi Andrew, On 17/03/2021 11:59, Andrew Cooper wrote: On 17/03/2021 11:54, Julien Grall wrote: On 17/03/2021 11:49, Andrew Cooper wrote: On 17/03/2021 11:27, Julien Grall wrote: From: Julien Grall Support to liveupdate C XenStored daemon was added during the 4.15 development cycle. Add a sec

[PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview

2021-03-17 Thread Julien Grall
From: Julien Grall Support to liveupdate C/OCaml XenStored daemon was added during the 4.15 development cycle. Add two new sections in SUPPORT.MD to explain what is the support state. For now, it is a tech preview. Signed-off-by: Julien Grall --- CC: Juergen Gross Changes in v3:

Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview

2021-03-17 Thread Jürgen Groß
On 17.03.21 13:08, Julien Grall wrote: From: Julien Grall Support to liveupdate C/OCaml XenStored daemon was added during the 4.15 development cycle. Add two new sections in SUPPORT.MD to explain what is the support state. For now, it is a tech preview. Signed-off-by: Julien Grall Reviewed

Re: [PATCH for-4.15 v3] SUPPORT.MD: Mark LiveUpdate of C/OCaml XenStored daemon as Tech Preview

2021-03-17 Thread Andrew Cooper
On 17/03/2021 12:31, Jürgen Groß wrote: > On 17.03.21 13:08, Julien Grall wrote: >> From: Julien Grall >> >> Support to liveupdate C/OCaml XenStored daemon was added during the >> 4.15 development cycle. Add two new sections in SUPPORT.MD to explain >> what is the support state. >> >> For now, it

[linux-linus test] 160105: regressions - FAIL

2021-03-17 Thread osstest service owner
flight 160105 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160105/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"

2021-03-17 Thread Ian Jackson
I have read this thread and with my release manager hat on I feel confused and/or ignorant. Patch 3/ has a good explanation of what the problem is it is addressing and why this is important for 4.15. But then there is Jan's most recent reply starting "I find all of this confusing". Jan, can you

Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure

2021-03-17 Thread Konrad Rzeszutek Wilk
..snip.. > int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int > verbose) > { ..snip.. > /* >* Allocate and initialize the free list array. This array is used >* to find contiguous free memory regions of size up to IO_TLB_SEGSIZE > - * between io_tlb

Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"

2021-03-17 Thread Andrew Cooper
On 17/03/2021 13:37, Ian Jackson wrote: > I have read this thread and with my release manager hat on I feel > confused and/or ignorant. > > Patch 3/ has a good explanation of what the problem is it is > addressing and why this is important for 4.15. But then there is > Jan's most recent reply star

Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure

2021-03-17 Thread Christoph Hellwig
On Wed, Mar 17, 2021 at 01:42:07PM +, Konrad Rzeszutek Wilk wrote: > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); > > - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > - if (!io_tlb_alloc_size) > > - panic("%s: Failed to allocate %zu bytes align=0x

Re: [PATCH for-next v2 0/2] xen/arm: Mitigate straight-line speculation

2021-03-17 Thread Bertrand Marquis
Hi Julien, > On 17 Mar 2021, at 11:20, Julien Grall wrote: > > > > On 16/03/2021 17:16, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >>> On 16 Mar 2021, at 15:27, Julien Grall wrote: >>> >>> >>> >>> On 15/03/2021 13:32, Bertrand Marquis wrote: Hi Julien, >>> >>> Hi Bert

xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10

2021-03-17 Thread Luca Fancellu
Hi all, we've been encountering an issue when using the kernel 5.10 with preempt_rt support for Dom0, the problem is that during the boot of Dom0, it hits a BUG_ON(!irqs_disabled()) from the function evtchn_fifo_unmask defined in events_fifo.c. This is the call stack: [ 17.817018]

Re: [PATCH for-next v2 1/2] xen/arm: Include asm/asm-offsets.h and asm/macros.h on every assembly files

2021-03-17 Thread Bertrand Marquis
Hi Julien, > On 13 Mar 2021, at 16:06, Julien Grall wrote: > > From: Julien Grall > > In a follow-up patch we may want to automatically replace some > mnemonics (such as ret) with a different sequence. > > To ensure all the assembly files will include asm/macros.h it is best to > automatical

Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"

2021-03-17 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()""): > On 17/03/2021 13:37, Ian Jackson wrote: > > AFAICT there is no explanation for why patches 1/ and 2/ deserve to go > > into 4.15. I see now, rereading the thread, that there was a s

Call for tools backports (was Re: preparations for 4.13.3)

2021-03-17 Thread Ian Jackson
Julien Grall writes ("Re: preparations for 4.13.3"): > On 08/03/2021 09:49, Jan Beulich wrote: > > All, > > > > the release is overdue (my apologies). Please point out backports > > you find missing from the respective staging branches, but which > > you consider relevant. > > > Ones that I have q

Re: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction

2021-03-17 Thread Bertrand Marquis
Hi Julien, > On 13 Mar 2021, at 16:06, Julien Grall wrote: > > From: Julien Grall > > Some CPUs can speculate past a RET instruction and potentially perform > speculative accesses to memory before processing the return. > > There is no known gadget available after the RET instruction today. >

Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"

2021-03-17 Thread Roger Pau Monné
On Wed, Mar 17, 2021 at 02:46:20PM +, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH 1/3] Revert "x86/msr: drop compatibility > #GP handling in guest_{rd,wr}msr()""): > > On 17/03/2021 13:37, Ian Jackson wrote: > > > AFAICT there is no explanation for why patches 1/ and 2/ deserve to g

Re: libxl / xen-pciback interaction [and 1 more messages]

2021-03-17 Thread Ian Jackson
Jan Beulich writes ("libxl / xen-pciback interaction"): > while trying to test a pciback fix for how SR-IOV VFs get placed in the > guest PCI topology I noticed that my test VM would only ever see the 1st > out of 3 VFs that I passed to it. As it turns out, the driver watches > its own (backend) no

Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"

2021-03-17 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()""): > On Wed, Mar 17, 2021 at 02:46:20PM +, Ian Jackson wrote: > > Roger, can I get your opinion about the possible downside risks of > > this patch ? > > For patches 1 and 2 the ri

Re: libxl / xen-pciback interaction [and 1 more messages]

2021-03-17 Thread Jan Beulich
On 17.03.2021 16:12, Ian Jackson wrote: > Jan Beulich writes ("libxl / xen-pciback interaction"): >> while trying to test a pciback fix for how SR-IOV VFs get placed in the >> guest PCI topology I noticed that my test VM would only ever see the 1st >> out of 3 VFs that I passed to it. As it turns o

Re: libxl / xen-pciback interaction [and 1 more messages]

2021-03-17 Thread Ian Jackson
Jan Beulich writes ("Re: libxl / xen-pciback interaction [and 1 more messages]"): > On 17.03.2021 16:12, Ian Jackson wrote: > > How does what libxl is doing differ from a setup, immediately followed > > by a hot-add ? > > In the hot-add case libxl drives things through Reconfiguring state. > I'm

Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-03-17 Thread Luca Fancellu
Hi, I’ve checked the common code and the arm part, I can confirm that the domid 0 is never allocated even if the domain 0 is not present, here the only places where domain_create(…) is called using a variable value: 1) xen/arch/arm/domain_build.c d = domain_create(++max_init_domid, &d_cfg, fals

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-17 Thread Leon Romanovsky
On Tue, Mar 16, 2021 at 04:22:21PM +0100, Hsu, Chiahao wrote: > > > Leon Romanovsky 於 2021/3/14 11:04 寫道: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > > > > > >

Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped

2021-03-17 Thread Boris Ostrovsky
On 2/25/21 6:51 PM, Stefano Stabellini wrote: > Newer Xen versions expose two Xen feature flags to tell us if the domain > is directly mapped or not. Only when a domain is directly mapped it > makes sense to enable swiotlb-xen on ARM. > > Introduce a function on ARM to check the new Xen feature f

Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure

2021-03-17 Thread Konrad Rzeszutek Wilk
On Wed, Mar 17, 2021 at 02:53:27PM +0100, Christoph Hellwig wrote: > On Wed, Mar 17, 2021 at 01:42:07PM +, Konrad Rzeszutek Wilk wrote: > > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); > > > - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > > - if (!io_tlb_alloc_s

Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure

2021-03-17 Thread Christoph Hellwig
On Wed, Mar 17, 2021 at 01:51:56PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 17, 2021 at 02:53:27PM +0100, Christoph Hellwig wrote: > > On Wed, Mar 17, 2021 at 01:42:07PM +, Konrad Rzeszutek Wilk wrote: > > > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); > > > > -

Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure

2021-03-17 Thread Konrad Rzeszutek Wilk
On Wed, Mar 17, 2021 at 06:57:42PM +0100, Christoph Hellwig wrote: > On Wed, Mar 17, 2021 at 01:51:56PM -0400, Konrad Rzeszutek Wilk wrote: > > On Wed, Mar 17, 2021 at 02:53:27PM +0100, Christoph Hellwig wrote: > > > On Wed, Mar 17, 2021 at 01:42:07PM +, Konrad Rzeszutek Wilk wrote: > > > > > -

[xen-unstable test] 160109: tolerable FAIL

2021-03-17 Thread osstest service owner
flight 160109 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160109/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 160101 pass in 160109 test-amd64-amd

[ovmf test] 160114: all pass - PUSHED

2021-03-17 Thread osstest service owner
flight 160114 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160114/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e4ff3773b711527ff46759759f34ea1cb9ff2a45 baseline version: ovmf 2e51b27fed31eb7b2a2cb

Re: [PATCH] xen/evtchn: replace if (cond) BUG() with BUG_ON()

2021-03-17 Thread Boris Ostrovsky
On 3/16/21 11:04 PM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/xen/evtchn.c:412:2-5: WARNING: Use BUG_ON instead of if > condition followed by BUG. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/xen/evtchn.c | 3 +-- > 1 file chang

[qemu-mainline test] 160113: regressions - FAIL

2021-03-17 Thread osstest service owner
flight 160113 qemu-mainline real [real] flight 160118 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160113/ http://logs.test-lab.xenproject.org/osstest/logs/160118/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[linux-linus test] 160115: regressions - FAIL

2021-03-17 Thread osstest service owner
flight 160115 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160115/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[ovmf test] 160117: all pass - PUSHED

2021-03-17 Thread osstest service owner
flight 160117 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160117/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 030ba3097a6e7d08b99f8a9d19a322f61409c1f6 baseline version: ovmf e4ff3773b711527ff4675

[linux-5.4 test] 160116: tolerable FAIL - PUSHED

2021-03-17 Thread osstest service owner
flight 160116 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/160116/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 159939 test-amd64-amd64-xl-qemut-win7-amd64 19