[linux-5.4 test] 159238: regressions - FAIL

2021-02-12 Thread osstest service owner
flight 159238 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/159238/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 158387 test-arm64-arm64-xl-x

Re: [PATCH HVM v2 1/1] hvm: refactor set param

2021-02-12 Thread Jan Beulich
On 11.02.2021 21:46, Norbert Manthey wrote: > I agree with the symmetry for get and set. This is what I'd aim for: > >  1. hvmop_set_param and hvmop_get_param (static) both check for the > index, and afterwards use the is_hvm_domain(d) function with its barrier >  2. hvm_set_param (static) and hvm

Re: [PATCH 04/17] x86/PV: harden guest memory accesses against speculative abuse

2021-02-12 Thread Roger Pau Monné
On Thu, Jan 14, 2021 at 04:04:57PM +0100, Jan Beulich wrote: > Inspired by > https://lore.kernel.org/lkml/f12e7d3cecf41b2c29734ea45a393be21d4a8058.1597848273.git.jpoim...@redhat.com/ > and prior work in that area of x86 Linux, suppress speculation with > guest specified pointer values by suitably m

Re: [PATCH HVM v2 1/1] hvm: refactor set param

2021-02-12 Thread Norbert Manthey
On 2/12/21 11:04 AM, Jan Beulich wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 11.02.2021 21:46, Norbert Manthey wrote: >> I agree with the symmetry f

Re: [PATCH 04/17] x86/PV: harden guest memory accesses against speculative abuse

2021-02-12 Thread Jan Beulich
On 12.02.2021 11:41, Roger Pau Monné wrote: > On Thu, Jan 14, 2021 at 04:04:57PM +0100, Jan Beulich wrote: >> @@ -94,6 +106,8 @@ unsigned __copy_from_user_ll(void *to, c >> return n; >> } >> >> +#if GUARD(1) + 0 > > Why do you need the '+ 0' here? I guess it's to prevent the > preprocessor

Re: [PATCH 04/17] x86/PV: harden guest memory accesses against speculative abuse

2021-02-12 Thread Roger Pau Monné
On Fri, Feb 12, 2021 at 01:48:43PM +0100, Jan Beulich wrote: > On 12.02.2021 11:41, Roger Pau Monné wrote: > > On Thu, Jan 14, 2021 at 04:04:57PM +0100, Jan Beulich wrote: > >> @@ -94,6 +106,8 @@ unsigned __copy_from_user_ll(void *to, c > >> return n; > >> } > >> > >> +#if GUARD(1) + 0 > >

Re: [PATCH 04/17] x86/PV: harden guest memory accesses against speculative abuse

2021-02-12 Thread Jan Beulich
On 12.02.2021 14:02, Roger Pau Monné wrote: > On Fri, Feb 12, 2021 at 01:48:43PM +0100, Jan Beulich wrote: >> On 12.02.2021 11:41, Roger Pau Monné wrote: >>> On Thu, Jan 14, 2021 at 04:04:57PM +0100, Jan Beulich wrote: --- a/xen/include/asm-x86/asm-defns.h +++ b/xen/include/asm-x86/asm-de

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-12 Thread Julien Grall
Hi Stefano, On 11/02/2021 20:55, Stefano Stabellini wrote: On Thu, 11 Feb 2021, Julien Grall wrote: On 11/02/2021 13:20, Rahul Singh wrote: On 10 Feb 2021, at 7:52 pm, Julien Grall wrote: On 10/02/2021 18:08, Rahul Singh wrote: Hello Julien, On 10 Feb 2021, at 5:34 pm, Julien Grall wrote:

[xen-4.12-testing test] 159241: tolerable FAIL - PUSHED

2021-02-12 Thread osstest service owner
flight 159241 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/159241/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow219 guest-localmigrate/x10 fail like 158556 test-armhf-armhf-libvirt-raw 15

[ovmf test] 159248: all pass - PUSHED

2021-02-12 Thread osstest service owner
flight 159248 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/159248/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1d27e58e401faea284309039f3962cb3cb4549fc baseline version: ovmf 124f1dd1ee1140b441151

[PATCH 06/10] stubdom/xenstored: Fix uninitialised variables in lu_read_state()

2021-02-12 Thread Andrew Cooper
Various version of gcc, when compiling with -Og, complain: xenstored_control.c: In function ‘lu_read_state’: xenstored_control.c:540:11: error: ‘state.size’ is used uninitialized in this function [-Werror=uninitialized] if (state.size == 0) ~^ xenstored_control.c:543:6:

[PATCH 03/10] tools/libxg: Fix uninitialised variable in meminit()

2021-02-12 Thread Andrew Cooper
Various version of gcc, when compiling with -Og, complain: xg_dom_arm.c: In function 'meminit': xg_dom_arm.c:420:19: error: 'p2m_size' may be used uninitialized in this function [-Werror=maybe-uninitialized] 420 | dom->p2m_size = p2m_size; | ~~^~ Signe

[PATCH 05/10] tools/libxl: Fix uninitialised variable in libxl__write_stub_dmargs()

2021-02-12 Thread Andrew Cooper
Various version of gcc, when compiling with -Og, complain: libxl_dm.c: In function ‘libxl__write_stub_dmargs’: libxl_dm.c:2166:16: error: ‘dmargs’ may be used uninitialized in this function [-Werror=maybe-uninitialized] rc = libxl__xs_write_checked(gc, t, path, dmargs);

[PATCH 07/10] tools: Use -Og for debug builds when available

2021-02-12 Thread Andrew Cooper
The recommended optimisation level for debugging is -Og, and is what tools such as gdb prefer. In practice, it equates to -01 with a few specific optimisations turned off. abi-dumper in particular wants the libraries it inspects in this form. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC

[PATCH 01/10] tools/xl: Fix exit code for `xl vkbattach`

2021-02-12 Thread Andrew Cooper
Various version of gcc, when compiling with -Og, complain: xl_vkb.c: In function 'main_vkbattach': xl_vkb.c:79:12: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized] 79 | return rc; |^~ The dryrun_only path really does leave rc u

[PATCH 09/10] tools/libs: Add rule to generate headers.lst

2021-02-12 Thread Andrew Cooper
abi-dumper needs a list of the public header files for shared objects, and only accepts this in the form of a file. No functional change. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross --- tools/libs/.gitignore | 1 + tools/libs/libs.mk| 9 - 2 fil

[PATCH 02/10] tools/libxg: Fix uninitialised variable in write_x86_cpu_policy_records()

2021-02-12 Thread Andrew Cooper
Various version of gcc, when compiling with -Og, complain: xg_sr_common_x86.c: In function 'write_x86_cpu_policy_records': xg_sr_common_x86.c:92:12: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized] 92 | return rc; |^~ The compl

[PATCH 04/10] tools/libxl: Fix uninitialised variable in libxl__domain_get_device_model_uid()

2021-02-12 Thread Andrew Cooper
Various version of gcc, when compiling with -Og, complain: libxl_dm.c: In function 'libxl__domain_get_device_model_uid': libxl_dm.c:256:12: error: 'kill_by_uid' may be used uninitialized in this function [-Werror=maybe-uninitialized] 256 | if (kill_by_uid) |^

[PATCH 08/10] tools: Check for abi-dumper in ./configure

2021-02-12 Thread Andrew Cooper
This will be optional. No functional change. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross --- config/Tools.mk.in | 1 + tools/configure| 41 + tools/configure.ac | 1 + 3 files changed, 43 insertions(+) diff --g

[PATCH for-4.15 00/10] tools: Support to use abi-dumper on libraries

2021-02-12 Thread Andrew Cooper
The first 6 patches are fixes to build with the -Og optimisation level, which is an expectation of abi-dumper and a good idea generally. There are 2 definite bugfixes, and 4 of more questionable usefulness. All fixes are simple. The next patch switches to -Og by default. This is potentially ris

Re: [PATCH 12/78] dm: use set_capacity_and_notify

2021-02-12 Thread Mike Snitzer
On Mon, Nov 16, 2020 at 10:05 AM Christoph Hellwig wrote: > > Use set_capacity_and_notify to set the size of both the disk and block > device. This also gets the uevent notifications for the resize for free. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke > --- > drivers/md

[PATCH 10/10] tools/libs: Write out an ABI analysis when abi-dumper is available

2021-02-12 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross --- tools/libs/libs.mk | 9 + 1 file changed, 9 insertions(+) diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk index ac68996ab2..2a4ce8a90c 100644 --- a/tools/libs/libs.mk +++ b/tools/libs/libs.mk @@ -4

Re: [PATCH 02/10] tools/libxg: Fix uninitialised variable in write_x86_cpu_policy_records()

2021-02-12 Thread Jan Beulich
On 12.02.2021 16:39, Andrew Cooper wrote: > Various version of gcc, when compiling with -Og, complain: > > xg_sr_common_x86.c: In function 'write_x86_cpu_policy_records': > xg_sr_common_x86.c:92:12: error: 'rc' may be used uninitialized in this > function [-Werror=maybe-uninitialized] >

Re: [PATCH 03/10] tools/libxg: Fix uninitialised variable in meminit()

2021-02-12 Thread Julien Grall
Hi Andrew, On 12/02/2021 15:39, Andrew Cooper wrote: Various version of gcc, when compiling with -Og, complain: xg_dom_arm.c: In function 'meminit': xg_dom_arm.c:420:19: error: 'p2m_size' may be used uninitialized in this function [-Werror=maybe-uninitialized] 420 | dom->p2m_siz

Re: [PATCH 07/10] tools: Use -Og for debug builds when available

2021-02-12 Thread Jan Beulich
On 12.02.2021 16:39, Andrew Cooper wrote: > The recommended optimisation level for debugging is -Og, and is what tools > such as gdb prefer. In practice, it equates to -01 with a few specific > optimisations turned off. > > abi-dumper in particular wants the libraries it inspects in this form. >

Re: [PATCH 06/10] stubdom/xenstored: Fix uninitialised variables in lu_read_state()

2021-02-12 Thread Jürgen Groß
On 12.02.21 16:39, Andrew Cooper wrote: Various version of gcc, when compiling with -Og, complain: xenstored_control.c: In function ‘lu_read_state’: xenstored_control.c:540:11: error: ‘state.size’ is used uninitialized in this function [-Werror=uninitialized] if (state.size == 0)

Re: [PATCH 07/10] tools: Use -Og for debug builds when available

2021-02-12 Thread Andrew Cooper
On 12/02/2021 16:04, Jan Beulich wrote: > On 12.02.2021 16:39, Andrew Cooper wrote: >> The recommended optimisation level for debugging is -Og, and is what tools >> such as gdb prefer. In practice, it equates to -01 with a few specific >> optimisations turned off. >> >> abi-dumper in particular wa

Re: [PATCH 10/10] tools/libs: Write out an ABI analysis when abi-dumper is available

2021-02-12 Thread Jan Beulich
On 12.02.2021 16:39, Andrew Cooper wrote: > --- a/tools/libs/libs.mk > +++ b/tools/libs/libs.mk > @@ -49,6 +49,8 @@ PKG_CONFIG_LOCAL := $(PKG_CONFIG_DIR)/$(PKG_CONFIG) > LIBHEADER ?= $(LIB_FILE_NAME).h > LIBHEADERS = $(foreach h, $(LIBHEADER), $(XEN_INCLUDE)/$(h)) > > +PKG_ABI := > lib$(LIB_FI

Re: [PATCH 07/10] tools: Use -Og for debug builds when available

2021-02-12 Thread Jan Beulich
On 12.02.2021 17:09, Andrew Cooper wrote: > On 12/02/2021 16:04, Jan Beulich wrote: >> On 12.02.2021 16:39, Andrew Cooper wrote: >>> --- a/tools/Rules.mk >>> +++ b/tools/Rules.mk >>> @@ -106,8 +106,9 @@ endif >>> CFLAGS_libxenlight += $(CFLAGS_libxenctrl) >>> >>> ifeq ($(debug),y) >>> -# Disabl

Re: [PATCH 06/10] stubdom/xenstored: Fix uninitialised variables in lu_read_state()

2021-02-12 Thread Andrew Cooper
On 12/02/2021 16:08, Jürgen Groß wrote: > On 12.02.21 16:39, Andrew Cooper wrote: >> Various version of gcc, when compiling with -Og, complain: >> >>    xenstored_control.c: In function ‘lu_read_state’: >>    xenstored_control.c:540:11: error: ‘state.size’ is used >> uninitialized in this >>    fun

Re: [PATCH 10/10] tools/libs: Write out an ABI analysis when abi-dumper is available

2021-02-12 Thread Andrew Cooper
On 12/02/2021 16:12, Jan Beulich wrote: > On 12.02.2021 16:39, Andrew Cooper wrote: >> --- a/tools/libs/libs.mk >> +++ b/tools/libs/libs.mk >> @@ -49,6 +49,8 @@ PKG_CONFIG_LOCAL := $(PKG_CONFIG_DIR)/$(PKG_CONFIG) >> LIBHEADER ?= $(LIB_FILE_NAME).h >> LIBHEADERS = $(foreach h, $(LIBHEADER), $(XEN_

[PATCH v1.1 10/10] tools/libs: Write out an ABI analysis when abi-dumper is available

2021-02-12 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross v2: * Swap XEN_COMPILE_ARCH for XEN_TARGET_ARCH * Swap abi-dumper for $(ABI_DUMPER) --- tools/libs/libs.mk | 9 + 1 file changed, 9 insertions(+) diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk inde

[linux-5.4 bisection] complete test-arm64-arm64-xl-credit1

2021-02-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-arm64-arm64-xl-credit1 testid guest-start Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tr

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-12 Thread Stefano Stabellini
On Fri, 12 Feb 2021, Julien Grall wrote: > On 11/02/2021 20:55, Stefano Stabellini wrote: > > On Thu, 11 Feb 2021, Julien Grall wrote: > > > On 11/02/2021 13:20, Rahul Singh wrote: > > > > > On 10 Feb 2021, at 7:52 pm, Julien Grall wrote: > > > > > On 10/02/2021 18:08, Rahul Singh wrote: > > > > >

Re: [PATCH 03/10] tools/libxg: Fix uninitialised variable in meminit()

2021-02-12 Thread Andrew Cooper
On 12/02/2021 15:55, Julien Grall wrote: > Hi Andrew, > > On 12/02/2021 15:39, Andrew Cooper wrote: >> Various version of gcc, when compiling with -Og, complain: >> >>    xg_dom_arm.c: In function 'meminit': >>    xg_dom_arm.c:420:19: error: 'p2m_size' may be used uninitialized >> in this function

[PATCH v1.1 03/10] tools/libxg: Drop stale p2m logic from ARM's meminit()

2021-02-12 Thread Andrew Cooper
Various version of gcc, when compiling with -Og, complain: xg_dom_arm.c: In function 'meminit': xg_dom_arm.c:420:19: error: 'p2m_size' may be used uninitialized in this function [-Werror=maybe-uninitialized] 420 | dom->p2m_size = p2m_size; | ~~^~ This

Re: [GIT PULL] xen: branch for v5.11-rc8

2021-02-12 Thread pr-tracker-bot
The pull request you sent on Fri, 12 Feb 2021 07:01:11 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-5.11-rc8-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2dbbaae5f7b3855697e2decc5de79c7574403254 Thank you! -- Deet-doot-dot, I

[qemu-mainline test] 159250: regressions - FAIL

2021-02-12 Thread osstest service owner
flight 159250 qemu-mainline real [real] flight 159307 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159250/ http://logs.test-lab.xenproject.org/osstest/logs/159307/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH v2 5/7] docs: move generic-loader documentation into the main manual

2021-02-12 Thread Alistair Francis
On Thu, Feb 11, 2021 at 9:21 AM Alex Bennée wrote: > > We might as well surface this useful information in the manual so > users can find it easily. It is a fairly simple conversion to rst with > the only textual fixes being QemuOps to QemuOpts. > > Signed-off-by: Alex Bennée > Message-Id: <20201

Re: [PATCH v2 6/7] docs: add some documentation for the guest-loader

2021-02-12 Thread Alistair Francis
On Thu, Feb 11, 2021 at 9:20 AM Alex Bennée wrote: > > Signed-off-by: Alex Bennée > Message-Id: <20201105175153.30489-7-alex.ben...@linaro.org> Reviewed-by: Alistair Francis Alistair > > --- > v2 > - add docs and MAINTAINERS > --- > docs/system/guest-loader.rst | 54 +++

[linux-linus test] 159260: regressions - FAIL

2021-02-12 Thread osstest service owner
flight 159260 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159260/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[xen-unstable-smoke test] 159308: tolerable all pass - PUSHED

2021-02-12 Thread osstest service owner
flight 159308 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159308/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[PATCH] automation: add arm32 cross-build tests for Xen

2021-02-12 Thread Stefano Stabellini
Add a debian build container with cross-gcc for arm32 installed. Add build jobs to cross-compile Xen-only for arm32. Signed-off-by: Stefano Stabellini --- .../debian/unstable-arm32-gcc.dockerfile | 24 + automation/gitlab-ci/build.yaml | 50 +++ automat

[PATCH] firmware: don't build hvmloader if it is not needed

2021-02-12 Thread Stefano Stabellini
If rombios, seabios and ovmf are all disabled, don't attempt to build hvmloader. This patches fixes the x86 alpine linux builds currently failing in gitlab-ci. Signed-off-by: Stefano Stabellini --- tools/firmware/Makefile | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff -

[xen-unstable test] 159268: trouble: broken/fail/pass

2021-02-12 Thread osstest service owner
flight 159268 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/159268/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle broken test-arm64-arm64-xl-

[libvirt test] 159284: regressions - FAIL

2021-02-12 Thread osstest service owner
flight 159284 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159284/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt