[xen-4.10-testing test] 155496: trouble: broken/fail/pass

2020-10-07 Thread osstest service owner
flight 155496 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/155496/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-thunderx broken Tests which are

[PATCH v2 1/2] tools: use memcpy instead of strncpy in getBridge

2020-10-07 Thread Bertrand Marquis
Use memcpy in getBridge to prevent gcc warnings about truncated strings. We know that we might truncate it, so the gcc warning here is wrong. Revert previous change changing buffer sizes as bigger buffers are not needed. Signed-off-by: Bertrand Marquis --- Changes in v2: Use MIN between string l

Re: [PATCH v2 1/2] tools: use memcpy instead of strncpy in getBridge

2020-10-07 Thread Jürgen Groß
On 07.10.20 10:28, Bertrand Marquis wrote: Use memcpy in getBridge to prevent gcc warnings about truncated strings. We know that we might truncate it, so the gcc warning here is wrong. Revert previous change changing buffer sizes as bigger buffers are not needed. Signed-off-by: Bertrand Marquis

Re: [PATCH v2 1/2] tools: use memcpy instead of strncpy in getBridge

2020-10-07 Thread Bertrand Marquis
Hi Jurgen, > On 7 Oct 2020, at 09:39, Jürgen Groß wrote: > > On 07.10.20 10:28, Bertrand Marquis wrote: >> Use memcpy in getBridge to prevent gcc warnings about truncated >> strings. We know that we might truncate it, so the gcc warning >> here is wrong. >> Revert previous change changing buffer

Re: [PATCH v2 1/2] tools: use memcpy instead of strncpy in getBridge

2020-10-07 Thread Jürgen Groß
On 07.10.20 10:56, Bertrand Marquis wrote: Hi Jurgen, On 7 Oct 2020, at 09:39, Jürgen Groß wrote: On 07.10.20 10:28, Bertrand Marquis wrote: Use memcpy in getBridge to prevent gcc warnings about truncated strings. We know that we might truncate it, so the gcc warning here is wrong. Revert pr

[libvirt test] 155511: regressions - FAIL

2020-10-07 Thread osstest service owner
flight 155511 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/155511/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

Re: [PATCH v2 1/2] tools: use memcpy instead of strncpy in getBridge

2020-10-07 Thread Bertrand Marquis
> On 7 Oct 2020, at 10:14, Jürgen Groß wrote: > > On 07.10.20 10:56, Bertrand Marquis wrote: >> Hi Jurgen, >>> On 7 Oct 2020, at 09:39, Jürgen Groß wrote: >>> >>> On 07.10.20 10:28, Bertrand Marquis wrote: Use memcpy in getBridge to prevent gcc warnings about truncated strings. We k

[linux-linus test] 155497: regressions - FAIL

2020-10-07 Thread osstest service owner
flight 155497 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/155497/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 6 xen-install fail REGR. vs. 152332 test-amd64-i386-qem

[xen-unstable-coverity test] 155515: all pass - PUSHED

2020-10-07 Thread osstest service owner
flight 155515 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/155515/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 93508595d588afe9dca087f95200effb7cedc81f baseline version: xen 8ef6

Re: [PATCH v2] xen/rpi4: implement watchdog-based reset

2020-10-07 Thread Julien Grall
Hi Stefano, On 02/10/2020 21:47, Stefano Stabellini wrote: The preferred methord to reboot RPi4 is PSCI. If it is not available, s/methord/method/ + +#define PM_PASSWORD 0x5a00 +#define PM_RSTC 0x1c +#define PM_WDOG 0x24 +#define PM

Re: Xen Coding style and clang-format

2020-10-07 Thread Anastasiia Lukianenko
Hi all, On Thu, 2020-10-01 at 10:06 +, George Dunlap wrote: > > On Oct 1, 2020, at 10:06 AM, Anastasiia Lukianenko < > > anastasiia_lukiane...@epam.com> wrote: > > > > Hi, > > > > On Wed, 2020-09-30 at 10:24 +, George Dunlap wrote: > > > > On Sep 30, 2020, at 10:57 AM, Jan Beulich > > >

[PATCH] x86/msr: handle IA32_THERM_STATUS

2020-10-07 Thread Roger Pau Monne
Windows 8 will attempt to read MSR_IA32_THERM_STATUS and panic if a #GP fault is injected as a result: vmx.c:3035:d8v0 RDMSR 0x019c unimplemented d8v0 VIRIDIAN CRASH: 3b c096 f8061de31651 f4088a613720 0 So handle the MSR and return 0 instead. Note that this is done on the generic

Re: [PATCH 2/3] tools/init-xenstore-domain: support xenstore pvh stubdom

2020-10-07 Thread Wei Liu
On Wed, Oct 07, 2020 at 08:54:43AM +0200, Jürgen Groß wrote: > On 30.09.20 17:46, Wei Liu wrote: > > On Wed, Sep 23, 2020 at 08:45:40AM +0200, Juergen Gross wrote: > > > Instead of creating the xenstore-stubdom domain first and parsing the > > > kernel later do it the other way round. This enables

Re: [PATCH V1 13/16] xen/ioreq: Make x86's invalidate qemu mapcache handling common

2020-10-07 Thread Julien Grall
Hi Oleksandr, On 02/10/2020 10:55, Oleksandr wrote: If I got it correctly there won't be a suitable common place where to set qemu_mapcache_invalidate flag anymore as XENMEM_decrease_reservation is not a single place we need to make a decision whether to set it By principle of analogy, on Arm w

Re: [PATCH] libxl: only query VNC when enabled

2020-10-07 Thread Wei Liu
On Thu, Oct 01, 2020 at 07:53:37PM -0400, Jason Andryuk wrote: > QEMU without VNC support (configure --disable-vnc) will return an error > when VNC is queried over QMP since it does not recognize the QMP > command. This will cause libxl to fail starting the domain even if VNC > is not enabled. Th

Re: [PATCH 3/5] tools/libs/store: drop read-only functionality

2020-10-07 Thread Wei Liu
On Fri, Oct 02, 2020 at 05:41:39PM +0200, Juergen Gross wrote: > Today it is possible to open the connection in read-only mode via > xs_daemon_open_readonly(). This is working only with Xenstore running > as a daemon in the same domain as the user. Additionally it doesn't > add any security as acce

Re: [PATCH 3/5] tools/libs/store: drop read-only functionality

2020-10-07 Thread Jürgen Groß
On 07.10.20 12:54, Wei Liu wrote: On Fri, Oct 02, 2020 at 05:41:39PM +0200, Juergen Gross wrote: Today it is possible to open the connection in read-only mode via xs_daemon_open_readonly(). This is working only with Xenstore running as a daemon in the same domain as the user. Additionally it doe

Re: [PATCH] build: always use BASEDIR for xen sub-directory

2020-10-07 Thread Bertrand Marquis
> On 2 Oct 2020, at 13:12, Jan Beulich wrote: > > On 02.10.2020 12:42, Bertrand Marquis wrote: >> Modify Makefiles using $(XEN_ROOT)/xen to use $(BASEDIR) instead. >> >> This is removing the dependency to xen subdirectory preventing using a >> wrong configuration file when xen subdirectory is

[PATCH] xen/arm: print update firmware only once

2020-10-07 Thread Bertrand Marquis
Fix enable_smccc_arch_workaround_1 to only print the warning asking to update the firmware once. Signed-off-by: Bertrand Marquis --- xen/arch/arm/cpuerrata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c index 6c09017515..

Re: [PATCH] build: always use BASEDIR for xen sub-directory

2020-10-07 Thread Wei Liu
On Wed, Oct 07, 2020 at 11:03:37AM +, Bertrand Marquis wrote: > > > > On 2 Oct 2020, at 13:12, Jan Beulich wrote: > > > > On 02.10.2020 12:42, Bertrand Marquis wrote: > >> Modify Makefiles using $(XEN_ROOT)/xen to use $(BASEDIR) instead. > >> > >> This is removing the dependency to xen sub

Re: [PATCH] build: always use BASEDIR for xen sub-directory

2020-10-07 Thread Bertrand Marquis
> On 7 Oct 2020, at 12:10, Wei Liu wrote: > > On Wed, Oct 07, 2020 at 11:03:37AM +, Bertrand Marquis wrote: >> >> >>> On 2 Oct 2020, at 13:12, Jan Beulich wrote: >>> >>> On 02.10.2020 12:42, Bertrand Marquis wrote: Modify Makefiles using $(XEN_ROOT)/xen to use $(BASEDIR) instead.

Re: [PATCH 3/5] tools/libs/store: drop read-only functionality

2020-10-07 Thread Andrew Cooper
On 07/10/2020 11:57, Jürgen Groß wrote: > On 07.10.20 12:54, Wei Liu wrote: >> On Fri, Oct 02, 2020 at 05:41:39PM +0200, Juergen Gross wrote: >>> Today it is possible to open the connection in read-only mode via >>> xs_daemon_open_readonly(). This is working only with Xenstore running >>> as a daem

Re: [PATCH V1 13/16] xen/ioreq: Make x86's invalidate qemu mapcache handling common

2020-10-07 Thread Oleksandr
On 07.10.20 13:38, Julien Grall wrote: Hi Oleksandr, Hi Julien. On 02/10/2020 10:55, Oleksandr wrote: If I got it correctly there won't be a suitable common place where to set qemu_mapcache_invalidate flag anymore as XENMEM_decrease_reservation is not a single place we need to make a d

RE: [PATCH v9 6/8] common/domain: add a domain context record for shared_info...

2020-10-07 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 05 October 2020 11:40 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Ian Jackson > ; Wei Liu ; > George Dunlap ; Jan Beulich ; > Julien Grall > ; Stefano Stabellini > Subject: Re: [PATCH v9 6/8] common/domain:

Re: [PATCH] x86/msr: fix handling of MSR_IA32_PERF_{STATUS/CTL}

2020-10-07 Thread Andrew Cooper
On 06/10/2020 17:23, Roger Pau Monne wrote: > Currently a PV hardware domain can also be given control over the CPU > frequency, and such guest is allowed to write to MSR_IA32_PERF_CTL. This might be how the current logic "works", but its straight up broken. PERF_CTL is thread scope, so unless do

Re: [PATCH 3/5] tools/libs/store: drop read-only functionality

2020-10-07 Thread Jürgen Groß
On 07.10.20 13:50, Andrew Cooper wrote: On 07/10/2020 11:57, Jürgen Groß wrote: On 07.10.20 12:54, Wei Liu wrote: On Fri, Oct 02, 2020 at 05:41:39PM +0200, Juergen Gross wrote: Today it is possible to open the connection in read-only mode via xs_daemon_open_readonly(). This is working only wit

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-07 Thread Thomas Zimmermann
Hi Am 02.10.20 um 11:58 schrieb Daniel Vetter: > On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: >> On Wed, Sep 30, 2020 at 2:34 PM Christian König >> wrote: >>> >>> Am 30.09.20 um 11:47 schrieb Daniel Vetter: On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian König wrote: >>

Re: [PATCH] xen/arm: print update firmware only once

2020-10-07 Thread Julien Grall
Hi Bertrand, On 07/10/2020 12:05, Bertrand Marquis wrote: Fix enable_smccc_arch_workaround_1 to only print the warning asking to update the firmware once. Signed-off-by: Bertrand Marquis --- xen/arch/arm/cpuerrata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arc

[qemu-mainline test] 155509: regressions - FAIL

2020-10-07 Thread osstest service owner
flight 155509 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/155509/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-xsm 12 guest-start fail REGR. vs. 152631 test-armhf-armhf-

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-07 Thread Daniel Vetter
On Wed, Oct 7, 2020 at 2:57 PM Thomas Zimmermann wrote: > > Hi > > Am 02.10.20 um 11:58 schrieb Daniel Vetter: > > On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: > >> On Wed, Sep 30, 2020 at 2:34 PM Christian König > >> wrote: > >>> > >>> Am 30.09.20 um 11:47 schrieb Daniel Vetter

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-07 Thread Thomas Zimmermann
Hi Am 07.10.20 um 15:10 schrieb Daniel Vetter: > On Wed, Oct 7, 2020 at 2:57 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 02.10.20 um 11:58 schrieb Daniel Vetter: >>> On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: On Wed, Sep 30, 2020 at 2:34 PM Christian König wrote:

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-07 Thread Christian König
Am 07.10.20 um 15:20 schrieb Thomas Zimmermann: Hi Am 07.10.20 um 15:10 schrieb Daniel Vetter: On Wed, Oct 7, 2020 at 2:57 PM Thomas Zimmermann wrote: Hi Am 02.10.20 um 11:58 schrieb Daniel Vetter: On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: On Wed, Sep 30, 2020 at 2:34

[PATCH v2 0/2] xen/x86: implement NMI continuation as softirq

2020-10-07 Thread Juergen Gross
Move sending of a virq event for oprofile to the local vcpu from NMI to softirq context. This has been tested with a small test patch using the continuation framework of patch 1 for all NMIs and doing a print to console in the continuation handler. Version 1 of this small series was sent to the s

[PATCH v2 1/2] xen/x86: add nmi continuation framework

2020-10-07 Thread Juergen Gross
Actions in NMI context are rather limited as e.g. locking is rather fragile. Add a generic framework to continue processing in softirq context after leaving NMI processing. This is working for NMIs happening in guest context as NMI exit handling will issue an IPI to itself in case a softirq is pen

[PATCH v2 2/2] xen/oprofile: use set_nmi_continuation() for sending virq to guest

2020-10-07 Thread Juergen Gross
Instead of calling send_guest_vcpu_virq() from NMI context use the NMI continuation framework for that purpose. Signed-off-by: Juergen Gross --- xen/arch/x86/oprofile/nmi_int.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/oprofile/nmi_int.c b/xen/arch/

Re: [PATCH] xen/arm: print update firmware only once

2020-10-07 Thread Bertrand Marquis
> On 7 Oct 2020, at 14:00, Julien Grall wrote: > > Hi Bertrand, > > On 07/10/2020 12:05, Bertrand Marquis wrote: >> Fix enable_smccc_arch_workaround_1 to only print the warning asking to >> update the firmware once. >> Signed-off-by: Bertrand Marquis >> --- >> xen/arch/arm/cpuerrata.c | 2 +

Re: [PATCH 3/5] tools/libs/store: drop read-only functionality

2020-10-07 Thread Wei Liu
On Wed, Oct 07, 2020 at 02:45:29PM +0200, Jürgen Groß wrote: > On 07.10.20 13:50, Andrew Cooper wrote: > > On 07/10/2020 11:57, Jürgen Groß wrote: > > > On 07.10.20 12:54, Wei Liu wrote: > > > > On Fri, Oct 02, 2020 at 05:41:39PM +0200, Juergen Gross wrote: > > > > > Today it is possible to open th

[PATCH v3 1/2] tools/libs/stat: use memcpy instead of strncpy in getBridge

2020-10-07 Thread Bertrand Marquis
Use memcpy in getBridge to prevent gcc warnings about truncated strings. We know that we might truncate it, so the gcc warning here is wrong. Revert previous change changing buffer sizes as bigger buffers are not needed. Signed-off-by: Bertrand Marquis --- Changes in v3: Do a memset 0 on destina

[PATCH v3 2/2] tool/libs/light: Fix libxenlight gcc warning

2020-10-07 Thread Bertrand Marquis
Fix gcc10 compilation warning about uninitialized variable by setting it to 0. Signed-off-by: Bertrand Marquis --- Changes in v3: Rebase --- tools/libs/light/libxl_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_mem.c b/tools/libs/light/libxl_mem.

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-07 Thread Daniel Vetter
On Wed, Oct 7, 2020 at 3:25 PM Christian König wrote: > > Am 07.10.20 um 15:20 schrieb Thomas Zimmermann: > > Hi > > > > Am 07.10.20 um 15:10 schrieb Daniel Vetter: > >> On Wed, Oct 7, 2020 at 2:57 PM Thomas Zimmermann > >> wrote: > >>> Hi > >>> > >>> Am 02.10.20 um 11:58 schrieb Daniel Vetter:

[PATCH v2] build: always use BASEDIR for xen sub-directory

2020-10-07 Thread Bertrand Marquis
Modify Makefiles using $(XEN_ROOT)/xen to use $(BASEDIR) instead. This is removing the dependency to xen subdirectory preventing using a wrong configuration file when xen subdirectory is duplicated for compilation tests. BASEDIR is set in xen/lib/x86/Makefile as this Makefile is directly called f

[xen-unstable-smoke test] 155517: regressions - FAIL

2020-10-07 Thread osstest service owner
flight 155517 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155517/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 155495 Tests which

Re: [PATCH] x86/msr: fix handling of MSR_IA32_PERF_{STATUS/CTL}

2020-10-07 Thread Roger Pau Monné
On Wed, Oct 07, 2020 at 01:06:08PM +0100, Andrew Cooper wrote: > On 06/10/2020 17:23, Roger Pau Monne wrote: > > Currently a PV hardware domain can also be given control over the CPU > > frequency, and such guest is allowed to write to MSR_IA32_PERF_CTL. > > This might be how the current logic "wo

[ovmf test] 155512: all pass - PUSHED

2020-10-07 Thread osstest service owner
flight 155512 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/155512/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c640186ec8aae6164123ee38de6409aed69eab12 baseline version: ovmf 2d8ca4f90eaeb61bd7e99

Re: xen-swiotlb vs phys_to_dma

2020-10-07 Thread Stefano Stabellini
On Wed, 7 Oct 2020, Christoph Hellwig wrote: > On Tue, Oct 06, 2020 at 01:46:12PM -0700, Stefano Stabellini wrote: > > OK, this makes a lot of sense, and I like the patch because it makes the > > swiotlb interface clearer. > > > > Just one comment below. > > > > > > +phys_addr_t swiotlb_tbl_map_

Re: [PATCH] xen/arm: print update firmware only once

2020-10-07 Thread Stefano Stabellini
On Wed, 7 Oct 2020, Julien Grall wrote: > Hi Bertrand, > > On 07/10/2020 12:05, Bertrand Marquis wrote: > > Fix enable_smccc_arch_workaround_1 to only print the warning asking to > > update the firmware once. > > > > Signed-off-by: Bertrand Marquis > > --- > > xen/arch/arm/cpuerrata.c | 2 +- >

[xen-unstable test] 155510: tolerable FAIL - PUSHED

2020-10-07 Thread osstest service owner
flight 155510 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/155510/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 155493 test-amd64-amd64-xl-qemuu-ws16-amd64

[OSSTEST PATCH 03/82] README.planner: Document magic job hostflags

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- README.planner | 60 ++ 1 file changed, 60 insertions(+) diff --git a/README.planner b/README.planner index c33aae11..f134d716 100644 --- a/README.planner +++ b/README.planner @@ -203,6 +203,66 @@

[OSSTEST PATCH 01/82] ms-queuedaemon: Update for newer Tcl's socket channel ids

2020-10-07 Thread Ian Jackson
From: Ian Jackson Now we have things like "sock55599edaf050" where previously we had something like "sock142". So the output is misaligned. Bump the sizes. And with these longer names, when showing the front of the queue only print the full first entry and the start of the next one. Signed-of

[OSSTEST PATCH 00/82] Reuse test hosts

2020-10-07 Thread Ian Jackson
This series arranges to save on host setup by reusing a test host, if the previous test passed. Care is taken to make sure that a host is only reused in this way if the new test would have set it up identically. I have had this branch in preparation since November 2017... -- 2.20.1

[OSSTEST PATCH 02/82] Executive.pm planner: fix typo

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index a0d9f81e..f17e7b70 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -702,7 +702,7 @@ sub pla

[OSSTEST PATCH 04/82] sg-run-job: Minor whitespace (formatting) changes

2020-10-07 Thread Ian Jackson
From: Ian Jackson No functional change. Signed-off-by: Ian Jackson --- sg-run-job | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sg-run-job b/sg-run-job index df3d08d0..3db05b34 100755 --- a/sg-run-job +++ b/sg-run-job @@ -30,12 +30,12 @@ proc per-host-prep {} {

[OSSTEST PATCH 08/82] host reuse: ms-planner: Bring some variables forward

2020-10-07 Thread Ian Jackson
From: Ian Jackson Move the scope of $share earlier in cmd_show_html, and also introduce $shared in the colour computation. This makes the next changes easier. No functional change. Signed-off-by: Ian Jackson --- ms-planner | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) di

[OSSTEST PATCH 07/82] ts-hosts-allocate-Executive: Add a comment about a warning

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive | 4 1 file changed, 4 insertions(+) diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive index 58d2a389..78b94c6d 100755 --- a/ts-hosts-allocate-Executive +++ b/ts-hosts-allocate-Executive @@ -

[OSSTEST PATCH 05/82] sg-run-job: Improve some internal API docs

2020-10-07 Thread Ian Jackson
Signed-off-by: Ian Jackson --- sg-run-job | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sg-run-job b/sg-run-job index 3db05b34..702ed558 100755 --- a/sg-run-job +++ b/sg-run-job @@ -206,12 +206,12 @@ proc recipe-flag {flagname {def 0}} { #general

[PATCH] x86/ucode: Trivial further cleanup

2020-10-07 Thread Andrew Cooper
* Drop unused include in private.h. * Used explicit width integers for Intel header fields. * Adjust comment to better describe the extended header. * Drop unnecessary __packed attribute for AMD header. * Switch mc_patch_data_id to being uint16_t, which is how it is more commonly referred t

[OSSTEST PATCH 09/82] host reuse: ms-planner: Do not show reuse as shared in the plan

2020-10-07 Thread Ian Jackson
From: Ian Jackson If the number of shares is 1, do not show it as shared, and also ignore the Unshare events. This clarifies the display, especially when used with forthcoming test host reuse work. Signed-off-by: Ian Jackson --- ms-planner | 7 +-- 1 file changed, 5 insertions(+), 2 delet

[OSSTEST PATCH 06/82] show_abs_time: Represent undef $timet as

2020-10-07 Thread Ian Jackson
From: Ian Jackson This can happen, for example, if a badly broken flight has steps which are STARTING and have NULL in the start time column, and is then reported using sg-report-flight. Signed-off-by: Ian Jackson --- Osstest.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/Osstest.pm b/

[OSSTEST PATCH 66/82] host lifecycle: Machinery, db, for tracking relevant events

2020-10-07 Thread Ian Jackson
From: Ian Jackson When we reuse test hosts, we want to be able to give a list of the other jobs which might be responsible for any problem. In principle it would be possible to do this by digging into the db's history tables like sg-report-host-history does, but this is quite slow and also I don

[OSSTEST PATCH 57/82] TestSupport: Provide runvar_is_synth

2020-10-07 Thread Ian Jackson
From: Ian Jackson Internally we use an array %r_notsynth. This allows us to avoid adding code to store_runvar etc. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSuppor

[OSSTEST PATCH 46/82] shared/reuse: Use @ for ts-xen-build-prep

2020-10-07 Thread Ian Jackson
From: Ian Jackson Pass @ from sg-run-job. This is the only call site for ts-xen-build-prep, so it can lose the open-coded test for SharedReady. Signed-off-by: Ian Jackson --- sg-run-job| 2 +- ts-xen-build-prep | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/sg-ru

[OSSTEST PATCH 26/82] host allocation: selecthost: allow sort-of-selection of prospective hosts

2020-10-07 Thread Ian Jackson
From: Ian Jackson If one passes a trueish value for $prospective, selecthost does not worry about whether any host has actually been selected. It does a limited amount of prep work. This will be useful if we want to know some of the non-host-specific information selecthost computes - in particu

[OSSTEST PATCH 28/82] host allocation: Support new reuse-* magic hostflag

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is like share-* except it has different MaxTasks and MaxWear parameters. Signed-off-by: Ian Jackson --- README.planner | 7 +++ ts-hosts-allocate-Executive | 15 +++ 2 files changed, 22 insertions(+) diff --git a/README.planner b/README.pla

[OSSTEST PATCH 72/82] resource reporting: Report host reuse/sharing in job report

2020-10-07 Thread Ian Jackson
From: Ian Jackson Compatibility: in principle this might generate erroneous reports which omit sharing/reuse information for allocations made by jobs using older versions of osstest. However, we do not share or reuse hosts across different osstest versions, so this cannot occur. Signed-off-by:

[OSSTEST PATCH 65/82] hsot reuse: Make share type hash more easily greppable

2020-10-07 Thread Ian Jackson
From: Ian Jackson Use - and _ to make up the base64 alphabet instead of + and / Signed-off-by: Ian Jackson --- ts-host-reuse | 1 + 1 file changed, 1 insertion(+) diff --git a/ts-host-reuse b/ts-host-reuse index 701070b2..0ecbb0bd 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@ -75,6 +75,7

[OSSTEST PATCH 12/82] target setup refactoring: Move target_kernkind_check

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is OK because nothing in access() looks at the rootdev or console runvars, which are what target_kernkind_check sets. No functional change other than perhaps to log output. Signed-off-by: Ian Jackson --- ts-debian-fixup | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[OSSTEST PATCH 14/82] target setup refactoring: Merge target_kernkind_*

2020-10-07 Thread Ian Jackson
From: Ian Jackson Combine these two functions. Rename them to a name which doesn't mention "kernkind". No functional change. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 3 +-- Osstest/TestSupport.pm | 11 --- ts-debian-fixup| 3 +-- 3 files changed, 6 insertions

[OSSTEST PATCH 47/82] shared/reuse: Use @ for ts-host-install

2020-10-07 Thread Ian Jackson
From: Ian Jackson Pass @ from sg-run-job. These are all the call sites for ts-host-install-*, so we can lose the open-coded test for SharedReady. Signed-off-by: Ian Jackson --- sg-run-job | 6 +++--- ts-host-install | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/sg

[OSSTEST PATCH 54/82] host reuse: Use literal for the hosts_infraprioritygroup runvar

2020-10-07 Thread Ian Jackson
From: Ian Jackson At some point this might make the database smarter about indexing. It's certainly clearer. Signed-off-by: Ian Jackson --- Osstest/JobDB/Executive.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Execu

[OSSTEST PATCH 55/82] host reuse: Bump host share reuse bonus

2020-10-07 Thread Ian Jackson
From: Ian Jackson In test jobs this is now contending with the variation bonus. If we fail to vary properly this time, we get another go in the next flight, so this is not so critical. This increases the amount of test host reuse. Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive |

[OSSTEST PATCH 58/82] runvar access: Introduce access control machinery

2020-10-07 Thread Ian Jackson
From: Ian Jackson This will allow us to trap accesses, during test host setup, to runvars which weren't included in ithe calculation of the sharing scope. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 53 ++ README | 2 +- 2 fi

[OSSTEST PATCH 69/82] host lifecycle: Record lifecycle in db and runvar

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is just the calls to host_update_lifecycle_info. Now the db table is Needed. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm| 2 ++ schema/host-lifecycle.sql | 2 +- ts-freebsd-host-install | 1 + ts-host-install | 1 + ts-host-reuse | 1

[OSSTEST PATCH 13/82] target setup refactoring: Move target_kernkind_console_inittab

2020-10-07 Thread Ian Jackson
From: Ian Jackson We move this earlier. This is OK because it depends only on the console runvar (inside the sub; this is set by target_kernkind_check), $ho and $gho (which are set by this point); and $mountpoint$ (which is set by access(). No functional change. Signed-off-by: Ian Jackson ---

[OSSTEST PATCH 42/82] host allocation: selecthost(): Support @IDENT for reuse

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is the first part of a central way to control host reuse, rather than having to write code in each ts-* script to check Shared etc. No functional change with existing callers. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 26 -- 1 file

Re: [OSSTEST PATCH 00/82] Reuse test hosts

2020-10-07 Thread Ian Jackson
Ian Jackson writes ("[OSSTEST PATCH 00/82] Reuse test hosts"): > This series arranges to save on host setup by reusing a test host, if > the previous test passed. Care is taken to make sure that a host is > only reused in this way if the new test would have set it up > identically. > > I have had

[OSSTEST PATCH 21/82] sg-run-job: support +! for *only* adding things to TESTID

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- sg-run-job | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sg-run-job b/sg-run-job index 702ed558..3ca725e7 100755 --- a/sg-run-job +++ b/sg-run-job @@ -277,6 +277,10 @@ proc recipe-flag {flagname {def 0}} { #

[OSSTEST PATCH 22/82] sg-run-job: Use +! in per-host-ts implementation

2020-10-07 Thread Ian Jackson
From: Ian Jackson This makes this slightly clearer, even more so in a moment. No functional change. Signed-off-by: Ian Jackson --- sg-run-job | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sg-run-job b/sg-run-job index 3ca725e7..3f44cae7 100755 --- a/sg-run-job +

[OSSTEST PATCH 29/82] host allocation: *_shared_mark_ready: Only prod when $newstate is ready

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index f2d43464..4cd4aa50 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -1092,1

[OSSTEST PATCH 31/82] plan_search: Improve debugging of $share_compat_ok->()

2020-10-07 Thread Ian Jackson
From: Ian Jackson No change other than to debugging output. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index e4bb0868..dfa3710a 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Execut

[OSSTEST PATCH 56/82] subst_netboot_template: Do not use all of %r

2020-10-07 Thread Ian Jackson
From: Ian Jackson Instead of copying all of %r into %v, have the template substitutor fall back to %r from %v. This is going to be important when we have host-reuse-related access control to %r. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 3 ++- 1 file changed, 2 insertions(+), 1

[OSSTEST PATCH 53/82] host reuse: Jiggle the infra-priority a bit, within a flight

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive index a50f8bf3..c1002fc9 100755 --- a/ts-hosts-allocate-Executive +++ b/ts-hosts-al

[OSSTEST PATCH 80/82] tsreadconfig: Change misleading "setting" message

2020-10-07 Thread Ian Jackson
These are the *existing* runvars and it is confusing that we print "setting" for them. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 163862f8..f2d8a0e1 100644 --- a/O

[OSSTEST PATCH 59/82] runvar access: Provide runvar_glob

2020-10-07 Thread Ian Jackson
From: Ian Jackson We will need this because when runvar access is restricted, accessing via %r directly won't work. We want to see what patterns the code is interested in (so that interest in a nonexistent runvar is properly tracked). Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 16

[OSSTEST PATCH 68/82] host lifecycle: Prevent referential integrity violation

2020-10-07 Thread Ian Jackson
From: Ian Jackson We can't use normal constraints for either of these, sadly. We can make the constraints into a single query which says "OK". Signed-off-by: Ian Jackson --- Osstest/JobDB/Executive.pm | 25 + 1 file changed, 25 insertions(+) diff --git a/Osstest/JobDB

[OSSTEST PATCH 30/82] plan_search: Break out $share_compat_ok

2020-10-07 Thread Ian Jackson
From: Ian Jackson No functional change. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index 4cd4aa50..e4bb0868 100644 --- a/Osstest/Executive.pm +++ b

[OSSTEST PATCH 41/82] ts-host-reuse: Add some missing runvars to the host sharing control

2020-10-07 Thread Ian Jackson
From: Ian Jackson Add some missing runvars to the host sharing control. Signed-off-by: Ian Jackson --- ts-host-reuse | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ts-host-reuse b/ts-host-reuse index 67de480f..5bdb07d1 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@ -7

[OSSTEST PATCH 79/82] flight other job reporting: Further improvements to ordering

2020-10-07 Thread Ian Jackson
From: Ian Jackson We want to definitely put these NULLs last. Signed-off-by: Ian Jackson --- sg-report-flight | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sg-report-flight b/sg-report-flight index d8829932..8f99bb69 100755 --- a/sg-report-flight +++ b/sg-report-f

[OSSTEST PATCH 17/82] Debian: osstest-erase-other-disks: Slightly guard against races

2020-10-07 Thread Ian Jackson
From: Ian Jackson Apparently it can happen that something decides to rescan a partition table, removing a partition block device, while it is being zeroed: osstest-erase-other-disks-6081: hd devices present after: /dev/hd* osstest-erase-other-disks-6081: Erasing /dev/sda osstest-erase-other-d

[OSSTEST PATCH 11/82] cr-publish-flight-logs: Fix abs_time calls

2020-10-07 Thread Ian Jackson
From: Ian Jackson There was a missing space in these messages, since they were introduced in 31b7cae19fe1 timing traces: cr-publish-flight-logs: Report more progress Signed-off-by: Ian Jackson --- cr-publish-flight-logs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cr-p

[OSSTEST PATCH 36/82] resource reporting, nfc: Break out report_rogue_task_description

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 14 ++ ms-planner | 6 +- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index 5f59c44e..e3ab1dc3 100644 --- a/Osstest/Executive.pm +++

[OSSTEST PATCH 48/82] shared/reuse: Use @ for freebsd host prep

2020-10-07 Thread Ian Jackson
From: Ian Jackson These are all the relevant call sites for ts-freebsd-host-install and ts-freebsd-build-prep. (There's a ts-freebsd-host-install in ts-memdisk-try-append but that's for host examination and does not uee or want sharing or reuse.) Signed-off-by: Ian Jackson --- sg-run-job

[OSSTEST PATCH 74/82] host reuse: ts-host-reuse: Prepare for argument handling

2020-10-07 Thread Ian Jackson
From: Ian Jackson No functional change. Signed-off-by: Ian Jackson --- ts-host-reuse | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ts-host-reuse b/ts-host-reuse index aad45bdd..21d77500 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@ -48,9 +48,9 @@ use Osstest:

[OSSTEST PATCH 39/82] ts-host-reuse: tolerate unremoveable lv

2020-10-07 Thread Ian Jackson
From: Ian Jackson It might be a symlink in the pair tests. Signed-off-by: Ian Jackson --- ts-host-reuse | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-reuse b/ts-host-reuse index e14a9149..74ac94aa 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@ -112,7 +112,7 @@

[OSSTEST PATCH 61/82] runvar access: Introduce sharing_for_build

2020-10-07 Thread Ian Jackson
From: Ian Jackson Builds don't have so much contingent setup. We don't track the runvars; we just rely on the share-* hostflag set in the job. But selecthost() is going to automatically enable runvar access control for shared/reused hosts. So, provide a way to disable that. Signed-off-by: Ian

[OSSTEST PATCH 51/82] host reuse: Reuse test hosts within a flight

2020-10-07 Thread Ian Jackson
From: Ian Jackson Mark the host shareable, and unshareable, as appropriate. There is still a lot more cleanup and improvement to do. Signed-off-by: Ian Jackson --- sg-run-job | 5 + 1 file changed, 5 insertions(+) diff --git a/sg-run-job b/sg-run-job index af43008d..1e2fcfee 100755 --- a

[OSSTEST PATCH 73/82] host reuse: sg-run-job: Reanme post-test-ok parameter

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is more accurate. No overall functional change. Signed-off-by: Ian Jackson --- sg-run-job| 2 +- ts-host-reuse | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sg-run-job b/sg-run-job index 1e2fcfee..2feb67d9 100755 --- a/sg-run-job +++ b/sg-ru

[OSSTEST PATCH 38/82] ts-host-reuse: New script, to do reuse state changes

2020-10-07 Thread Ian Jackson
From: Ian Jackson This will be made part of the test job recipes. We calculate the sharing scope (sharetype) by reference to a lot of runvars, etc. This version of the script is rather far from the finished working one, but it seems better to preserve the actual history for how it got the way i

[OSSTEST PATCH 81/82] sg-report-flight: Sharing reports: more task finished info

2020-10-07 Thread Ian Jackson
Other steps from jobs affecting this host either started after we are running, and therefore didn't affect the stuff we're reporting, or already in the db. Furthermore, any such effects for steps which have finished must have completed by the max finished time But if there are unfinished steps, w

[OSSTEST PATCH 27/82] host allocation: *_shared_mark_ready: allow alternative $oldtypes

2020-10-07 Thread Ian Jackson
From: Ian Jackson $oldtype may now be a hashref, where keys mapping to truthy values are permitted for the sharetype precondition. No functional change for existing callers. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff -

[OSSTEST PATCH 10/82] hsot reuse: ms-planner: Abbreviate reporting of test shares

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- ms-planner | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ms-planner b/ms-planner index 4e38e4e3..78d27b2f 100755 --- a/ms-planner +++ b/ms-planner @@ -414,11 +414,13 @@ END next if $plan->{Events}{$reskey};

  1   2   >