[PATCH v3] x86/HVM: more consistently set I/O completion

2020-08-27 Thread Jan Beulich
Doing this just in hvm_emulate_one_insn() is not enough. hvm_ud_intercept() and hvm_emulate_one_vm_event() can get invoked for insns requiring one or more continuations, and at least in principle hvm_emulate_one_mmio() could, too. Without proper setting of the field, handle_hvm_io_completion() will

[linux-linus test] 152862: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152862 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152862/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [patch V2 27/46] x86/xen: Rework MSI teardown

2020-08-27 Thread Jürgen Groß
On 26.08.20 13:16, Thomas Gleixner wrote: From: Thomas Gleixner X86 cannot store the irq domain pointer in struct device without breaking XEN because the irq domain pointer takes precedence over arch_*_msi_irqs() fallbacks. XENs MSI teardown relies on default_teardown_msi_irqs() which invokes

Re: [patch V2 28/46] x86/xen: Consolidate XEN-MSI init

2020-08-27 Thread Jürgen Groß
On 26.08.20 13:16, Thomas Gleixner wrote: From: Thomas Gleixner X86 cannot store the irq domain pointer in struct device without breaking XEN because the irq domain pointer takes precedence over arch_*_msi_irqs() fallbacks. To achieve this XEN MSI interrupt management needs to be wrapped into

gcc10 build issue for Arm64

2020-08-27 Thread Jan Beulich
Stefano, Julien, since it was touching code potentially also affecting Arm, prior to my push of a couple of commits a few minutes ago I also wanted to build-test Arm. While as a fallback all went well with gcc 9.3, with my first (default) attempt with 10.2 I ran into ld: prelink.o: in function `_

Re: [patch V2 43/46] genirq/msi: Provide and use msi_domain_set_default_info_flags()

2020-08-27 Thread Marc Zyngier
On 2020-08-26 12:17, Thomas Gleixner wrote: MSI interrupts have some common flags which should be set not only for PCI/MSI interrupts. Move the PCI/MSI flag setting into a common function so it can be reused. Signed-off-by: Thomas Gleixner --- V2: New patch --- drivers/pci/msi.c |7 +-

Re: [PATCH 2/2] arm/xen: Add misuse warning to virt_to_gfn

2020-08-27 Thread Julien Grall
On 27/08/2020 06:21, Jürgen Groß wrote: On 26.08.20 20:37, Julien Grall wrote: "Usually" is a bit gross here. The only generic call site I could find is xenbus_grant_ring(). All other instances (I counted 22) are not generic at all. will only catch one instance and it means we would have to f

Re: [PATCH 2/2] arm/xen: Add misuse warning to virt_to_gfn

2020-08-27 Thread Jürgen Groß
On 27.08.20 10:24, Julien Grall wrote: On 27/08/2020 06:21, Jürgen Groß wrote: On 26.08.20 20:37, Julien Grall wrote: "Usually" is a bit gross here. The only generic call site I could find is xenbus_grant_ring(). All other instances (I counted 22) are not generic at all. will only catch one i

Re: gcc10 build issue for Arm64

2020-08-27 Thread Julien Grall
On 27/08/2020 09:01, Jan Beulich wrote: Stefano, Julien, Hi Jan, since it was touching code potentially also affecting Arm, prior to my push of a couple of commits a few minutes ago I also wanted to build-test Arm. While as a fallback all went well with gcc 9.3, with my first (default) attemp

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

2020-08-27 Thread Wei Liu
On Tue, Aug 18, 2020 at 01:40:18PM +0100, Andrew Cooper wrote: > On 18/08/2020 10:25, Christian Lindig wrote: > > I see little reason to support old OCaml releases and requiring OCaml 4.06 > > would be fine with me but I assume that the project might have its own > > ideas about this. > > > > ___

Re: [PATCH v3 0/8] tools: propogate MTU to vif frontends

2020-08-27 Thread Wei Liu
On Tue, Aug 11, 2020 at 09:01:54AM +0100, Paul Durrant wrote: > From: Paul Durrant > > This is an expansion from v2 of the series to include the facility to set > the MTU in the vif config. > > There is also one cleanup patch to remove the defunct 'vif2' script. > > Paul Durrant (8): > public

Re: gcc10 build issue for Arm64

2020-08-27 Thread Jan Beulich
On 27.08.2020 11:11, Julien Grall wrote: > On 27/08/2020 09:01, Jan Beulich wrote: >> Stefano, Julien, > > Hi Jan, > >> since it was touching code potentially also affecting Arm, prior >> to my push of a couple of commits a few minutes ago I also wanted >> to build-test Arm. While as a fallback a

Re: [PATCH I v2 2/6] tools: switch XEN_LIBXEN* make variables to lower case (XEN_libxen*)

2020-08-27 Thread Wei Liu
On Sat, Aug 15, 2020 at 03:03:37PM +0200, Juergen Gross wrote: > In order to harmonize names of library related make variables switch > XEN_LIBXEN* names to XEN_libxen*, as all other related variables (e.g. > CFLAGS_libxen*, SHDEPS_libxen*, ...) already use this pattern. > > Rename XEN_LIBXC to XE

Re: [PATCH I v2 5/6] tools: define ROUNDUP() in tools/include/xen-tools/libs.h

2020-08-27 Thread Wei Liu
On Sat, Aug 15, 2020 at 03:03:40PM +0200, Juergen Gross wrote: > Today there are multiple copies of the ROUNDUP() macro in various > sources and headers. Define it once in tools/include/xen-tools/libs.h. > > Using xen-tools/libs.h enables removing copies of MIN() and MAX(), too. > > Signed-off-by

Re: [PATCH v3 02/38] tools: switch XEN_LIBXEN* make variables to lower case (XEN_libxen*)

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:43AM +0200, Juergen Gross wrote: > In order to harmonize names of library related make variables switch > XEN_LIBXEN* names to XEN_libxen*, as all other related variables (e.g. > CFLAGS_libxen*, SHDEPS_libxen*, ...) already use this pattern. > > Rename XEN_LIBXC to XE

Re: [PATCH v3 05/38] tools: define ROUNDUP() in tools/include/xen-tools/libs.h

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:46AM +0200, Juergen Gross wrote: > Today there are multiple copies of the ROUNDUP() macro in various > sources and headers. Define it once in tools/include/xen-tools/libs.h. > > Using xen-tools/libs.h enables removing copies of MIN() and MAX(), too. > > Signed-off-by

Re: [PATCH v3 03/38] tools: add a copy of library headers in tools/include

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:44AM +0200, Juergen Gross wrote: > The headers.chk target in tools/Rules.mk tries to compile all headers > stand alone for testing them not to include any internal header. > > Unfortunately the headers tested against are not complete, as any > header for a Xen library

Re: [PATCH v3 04/38] tools: don't call make recursively from libs.mk

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:45AM +0200, Juergen Gross wrote: > During build of a xen library make is called again via libs.mk. This is > not necessary as the same can be achieved by a simple dependency. > > Signed-off-by: Juergen Gross > Reviewed-by: Ian Jackson Acked-by: Wei Liu

Re: [PATCH v3 06/38] tools: generate most contents of library make variables

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:47AM +0200, Juergen Gross wrote: > Library related make variables (CFLAGS_lib*, SHDEPS_lib*, LDLIBS_lib* > and SHLIB_lib*) mostly have a common pattern for their values. Generate > most of this content automatically by adding a new per-library variable > defining on wh

Re: [PATCH v3 09/38] tools: drop explicit path specifications for qemu build

2020-08-27 Thread Wei Liu
Looks fine to me Cc Anthony in case he has any objection. On Sun, Aug 23, 2020 at 11:34:50AM +0200, Juergen Gross wrote: > Since more than three years now qemu is capable to set the needed > include and library paths for the Xen libraries via pkg-config. > > So drop the specification of those pa

Re: [PATCH v3 12/38] tools: fix pkg-config file for libxenguest

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:53AM +0200, Juergen Gross wrote: > The pkg-config file for libxenguest is missing the private dependency > on libxenctrl. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v3 13/38] tools: don't assume libxenguest and libxenctrl to be in same directory

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:54AM +0200, Juergen Gross wrote: > There are quite some places in Makefiles assuming libxenguest and > libxenctrl being built in the same directory via a single Makefile. > > Drop this assumption by specifying the dependencies and path variables > for both libraries c

Re: [PATCH v3 14/38] tools/misc: don't use libxenctrl internals from xen-hptool

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:55AM +0200, Juergen Gross wrote: > xen-hptool is including private headers from tools/libxc without any > need. Switch it to use official headers only. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v3 15/38] tools/misc: don't include xg_save_restore.h from xen-mfndump.c

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:56AM +0200, Juergen Gross wrote: > xen-mfndump.c is including the libxc private header xg_save_restore.h. > Avoid that by moving the definition of is_mapped() to xen-mfndump.c > (it is used there only) and by duplicating the definition of > M2P_SIZE() in xen-mfndump.c.

Re: [PATCH v3 17/38] tools/misc: drop all libxc internals from xen-mfndump.c

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:58AM +0200, Juergen Gross wrote: > The last libxc internal used by xen-mfndump.c is the ERROR() macro. > Add a simple definition for that macro to xen-mfndump.c and replace > the libxc private header includes by official ones. > > Signed-off-by: Juergen Gross Acked-

Re: [PATCH v3 16/38] tools/misc: replace PAGE_SIZE with XC_PAGE_SIZE in xen-mfndump.c

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:57AM +0200, Juergen Gross wrote: > The definition of PAGE_SIZE comes from xc_private.h, which shouldn't be > used by xen-mfndump.c. Replace PAGE_SIZE by XC_PAGE_SIZE, as > xc_private.h contains: > > #define PAGE_SIZE XC_PAGE_SIZE > > For the same reason PAGE_SHIFT_X8

Re: [PATCH v3 18/38] tools/libxc: remove unused headers xc_efi.h and xc_elf.h

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:59AM +0200, Juergen Gross wrote: > Remove xc_efi.h and xc_elf.h as they aren't used anywhere. > > Signed-off-by: Juergen Gross I haven't checked if they are really unused, but that should be easy to find out if it is not the case. Acked-by: Wei Liu

Re: [PATCH v3 19/38] tools/libxc: move xc_[un]map_domain_meminfo() into new source xg_domain.c

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:00AM +0200, Juergen Gross wrote: > Move xc_[un]map_domain_meminfo() functions to new source xg_domain.c as > they are defined in include/xenguest.h and should be in libxenguest. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

[PATCH] gitignore: ignore ebmalloc.c soft link

2020-08-27 Thread Wei Liu
A previous commit split ebmalloc to its own translation unit but forgot to modify gitignore. Fixes: 8856a914bffd ("build: also check for empty .bss.* in .o -> .init.o conversion") Signed-off-by: Wei Liu --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore i

[xen-unstable-smoke test] 152887: tolerable all pass - PUSHED

2020-08-27 Thread osstest service owner
flight 152887 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152887/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3 10/38] tools: tweak tools/libs/libs.mk for being able to support libxenctrl

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:51AM +0200, Juergen Gross wrote: > tools/libs/libs.mk needs to be modified for being able to support > building libxenctrl, as the pkg-config file of that library is not > following the same conventions as those of the other libraries. > > So add support for specifyin

Re: [PATCH v3 20/38] tools/libxc: rename all libxenguest sources to xg_*

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:01AM +0200, Juergen Gross wrote: > Some sources of libxenguest are named xg_*.c and some xc_*.c. Rename > the xc_*.c files to xg_*.c. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v3 22/38] tools/misc: rename xc_dom.h do xenctrl_dom.h

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:03AM +0200, Juergen Gross wrote: > For being able to disentangle lixenctrl and libxenguest headers > xc_dom.h will need to be public. Prepare that by renaming xc_dom.h > to xenctrl_dom.h. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH] gitignore: ignore ebmalloc.c soft link

2020-08-27 Thread Jan Beulich
On 27.08.2020 12:48, Wei Liu wrote: > A previous commit split ebmalloc to its own translation unit but forgot > to modify gitignore. > > Fixes: 8856a914bffd ("build: also check for empty .bss.* in .o -> .init.o > conversion") > Signed-off-by: Wei Liu Acked-by: Jan Beulich Thanks, and I'm sorr

Re: [PATCH v3 21/38] tools/libxc: rename libxenguest internal headers

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:02AM +0200, Juergen Gross wrote: > Rename the header files private to libxenguest from xc_*.h to xg_*.h. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v3 00/38] tools: move most libraries into tools/libs

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:34:41AM +0200, Juergen Gross wrote: > Move most remaining libraries under tools/libs, including libxenctrl > and libxl. This is resulting in a lot of cleanup work regarding > building libs and restructuring of the tools directory. > One thing to point out is that libs w

Re: [PATCH v3 23/38] tools/libxc: untangle libxenctrl from libxenguest

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:04AM +0200, Juergen Gross wrote: > Sources of libxenctrl and libxenguest are completely entangled. In > practice libxenguest is a user of libxenctrl, so don't let any source > libxenctrl include xg_private.h. > > This can be achieved by moving all definitions used by

Re: [PATCH v3 00/38] tools: move most libraries into tools/libs

2020-08-27 Thread Jürgen Groß
On 27.08.20 13:07, Wei Liu wrote: On Sun, Aug 23, 2020 at 11:34:41AM +0200, Juergen Gross wrote: Move most remaining libraries under tools/libs, including libxenctrl and libxl. This is resulting in a lot of cleanup work regarding building libs and restructuring of the tools directory. One thi

Re: [PATCH v3 25/38] tools/xenpaging: remove libxc internals

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:06AM +0200, Juergen Gross wrote: > xenpaging is using libxc internals. Fix that. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v3 24/38] tools/xcutils: use official headers in readnotes

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:05AM +0200, Juergen Gross wrote: > readnotes.c is including xg_private.h. Now that the xenctrl headers > are structured better this is no longer needed. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v3 27/38] tools/libxc: move libxenguest to tools/libs/guest

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:08AM +0200, Juergen Gross wrote: > tools/libxc now contains libxenguest only. Move it to tools/libs/guest. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v3 26/38] tools: move libxenctrl below tools/libs

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:07AM +0200, Juergen Gross wrote: > Today tools/libxc needs to be built after tools/libs as libxenctrl is > depending on some libraries in tools/libs. This in turn blocks moving > other libraries depending on libxenctrl below tools/libs. > > So carve out libxenctrl fro

Re: [PATCH v3 29/38] tools: split libxenvchan into new tools/libs/vchan directory

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:10AM +0200, Juergen Gross wrote: > There is no reason why libvchan is not placed in the tools/libs > directory. > > At the same time move libxenvchan.h to a dedicated include directory > in tools/libs/vchan in order to follow the same pattern as the other > libraries

Re: [PATCH v3 28/38] tools: split libxenstore into new tools/libs/store directory

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:09AM +0200, Juergen Gross wrote: > There is no reason why libxenstore is not placed in the tools/libs > directory. > > The common files between libxenstore and xenstored are kept in the > tools/xenstore directory to be easily accessible by xenstore-stubdom > which nee

Re: [PATCH v3 31/38] tools/libxl: fix dependencies of libxl tests

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:12AM +0200, Juergen Gross wrote: > Today building the libxl internal tests depends on libxlutil having > been built, in spite of the tests not using any functionality og og -> of > libxlutil. Fix this by dropping the dependency. > > Signed-off-by: Juergen Gross Ac

Re: [PATCH v3 30/38] tools: split libxenstat into new tools/libs/stat directory

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:11AM +0200, Juergen Gross wrote: > There is no reason why libxenstat is not placed in the tools/libs > directory. > > At the same time move xenstat.h to a dedicated include directory > in tools/libs/stat in order to follow the same pattern as the other > libraries in

Re: [PATCH v3 32/38] tools/libxl: don't include libxl_osdeps.h from libxlutil sources

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:13AM +0200, Juergen Gross wrote: > There is no need for the sources of libxlutil to include libxl_osdeps.h > as the only dependency is the leading > > #define _GNU_SOURCE > > in libxl_osdeps.h. So replace including libxl_osdeps.h by the needed > define. > > Signed-o

Re: [PATCH v3 33/38] tools/libxl: add missing items to clean target

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:14AM +0200, Juergen Gross wrote: > Some generated files are not removed by "make clean". Add them. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v3 34/38] tools/libxl: move xl parsing checks to tools/xl

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:15AM +0200, Juergen Gross wrote: > check-xl-* scripts and data are not libxl- but xl-specific. Move them > from tools/libxl/ to tools/xl/. I think those should've been moved while the splitting of libxl / xl happened. My bad. > > Signed-off-by: Juergen Gross Acked-

Re: [PATCH v3 35/38] tools/xl: don't assume libxl and libxlutil are in one directory

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:16AM +0200, Juergen Gross wrote: > Add the correct flags for both, libxenlight and libxlutil, when > building xl. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v3 36/38] tools/libxl: move libxenlight to tools/libs/light

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:17AM +0200, Juergen Gross wrote: > Carve out all libxenlight related sources and move them to > tools/libs/light in order to use the generic library build environment. > > The closely related sources for libxl-save-helper and the libxl test > environment are being mov

Re: [PATCH v3 37/38] tools: add support for library names other than libxen*

2020-08-27 Thread Wei Liu
On Sun, Aug 23, 2020 at 11:35:18AM +0200, Juergen Gross wrote: > All Xen libraries but one (libxlutil) are named libxen... > It this can potentially make your life easier, I think renaming the library to libxenlightutil to conform to the library naming scheme is acceptable to me -- obviously we w

Re: [PATCH v3 37/38] tools: add support for library names other than libxen*

2020-08-27 Thread Jürgen Groß
On 27.08.20 13:55, Wei Liu wrote: On Sun, Aug 23, 2020 at 11:35:18AM +0200, Juergen Gross wrote: All Xen libraries but one (libxlutil) are named libxen... It this can potentially make your life easier, I think renaming the library to libxenlightutil to conform to the library naming scheme is

[xen-unstable test] 152877: tolerable FAIL

2020-08-27 Thread osstest service owner
flight 152877 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152877/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-seattle 7 xen-boot fail pass in 152849 Tests which did not succeed, but

[xen-unstable-smoke test] 152892: tolerable all pass - PUSHED

2020-08-27 Thread osstest service owner
flight 152892 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152892/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: qemu-xen and bridge (xen 4.11)

2020-08-27 Thread Manuel Bouyer
On Mon, Aug 24, 2020 at 11:24:06AM -0700, Roman Shaposhnik wrote: > On Mon, Aug 24, 2020 at 11:12 AM Manuel Bouyer wrote: > > > > Hello, > > with the recent XSA about qemu, I'm trying to switch the NetBSD port from > > qemu-xen-traditional to qemu-xen (in Xen 4.11 for now, I'll look at > > 4.13 la

Various problems for the Xen for XenGT code and guide.

2020-08-27 Thread Mario Marietto
Hello. I would like to pass the integrated gpu from the host os (ubuntu 20.04) to the windows 10 guest os with xen. This is because xen works great for me,better than qemu-kvm for my specific needs and because I have only two graphic cards. The nvidia rtx 2080 ti that I have already passed to the

Re: [PATCH v1 0/6] tools/ocaml/xenstored: simplify code

2020-08-27 Thread Edwin Torok
On Thu, 2020-08-27 at 09:41 +, Wei Liu wrote: > On Tue, Aug 18, 2020 at 01:40:18PM +0100, Andrew Cooper wrote: > > On 18/08/2020 10:25, Christian Lindig wrote: > > > I see little reason to support old OCaml releases and requiring > > > OCaml 4.06 would be fine with me but I assume that the proj

Re: [PATCH v4 2/2] xen/arm: Throw messages for unknown FP/SIMD implement ID

2020-08-27 Thread Bertrand Marquis
> On 25 Aug 2020, at 17:06, Wei Chen wrote: > > Arm ID_AA64PFR0_EL1 register provides two fields to describe CPU > FP/SIMD implementations. Currently, we exactly know the meaning of > 0x0, 0x1 and 0xf of these fields. Xen treats value < 8 as FP/SIMD > features presented. If there is a value 0x

Re: [PATCH 1/3] tools/hotplug: Fix hostname setting in vif-nat

2020-08-27 Thread Bertrand Marquis
> On 20 Aug 2020, at 11:58, Diego Sueiro wrote: > > Setting the hostname is failing because the "$XENBUS_PATH/domain" > doesn't exist anymore. To fix this we set it to dom$domid > > Signed-off-by: Diego Sueiro Reviewed-by: Bertrand Marquis > --- > tools/hotplug/Linux/vif-nat | 2 +- > 1 fil

Re: [PATCH 2/3] tools/hotplug: Fix dhcpd symlink removal in vif-nat

2020-08-27 Thread Bertrand Marquis
> On 20 Aug 2020, at 12:00, Diego Sueiro wrote: > > Copy temp files used to add/remove dhcpd configurations to avoid > replacing potential symlinks. > > Signed-off-by: Diego Sueiro Reviewed-by: Bertrand Marquis > --- > tools/hotplug/Linux/vif-nat | 12 +++- > 1 file changed, 7 inser

Re: [PATCH 3/3] tools/hotplug: Extend dhcpd conf, init and arg files search

2020-08-27 Thread Bertrand Marquis
> On 20 Aug 2020, at 12:01, Diego Sueiro wrote: > > Newer versions of the ISC dhcp server expect the dhcpd.conf file > to be located at /etc/dhcp directory. > > Also, some distributions and Yocto based ones have these installation > paths by default: /etc/init.d/{isc-dhcp-server,dhcp-server}

Re: [PATCH v6 09/11] x86/domctl: add XEN_DOMCTL_vmtrace_op

2020-08-27 Thread Jan Beulich
On 07.07.2020 21:39, Michał Leszczyński wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -1136,6 +1136,30 @@ struct xen_domctl_vuart_op { > */ > }; > > +/* XEN_DOMCTL_vmtrace_op: Perform VM tracing related operation */ > +#if d

Re: [patch V2 01/46] iommu/amd: Prevent NULL pointer dereference

2020-08-27 Thread Joerg Roedel
On Wed, Aug 26, 2020 at 01:16:29PM +0200, Thomas Gleixner wrote: > From: Thomas Gleixner > > Dereferencing irq_data before checking it for NULL is suboptimal. > > Signed-off-by: Thomas Gleixner Acked-by: Joerg Roedel Reviewed-by: Joerg Roedel

Re: [PATCH v2 2/8] x86/svm: silently drop writes to SYSCFG and related MSRs

2020-08-27 Thread Jan Beulich
On 20.08.2020 17:08, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -1917,6 +1917,21 @@ static int svm_msr_read_intercept(unsigned int msr, > uint64_t *msr_content) > goto gpf; > break; > > +case MSR_K8_TOP_MEM1: > +

Re: [PATCH 2/8] x86/svm: silently drop writes to SYSCFG and related MSRs

2020-08-27 Thread Jan Beulich
On 18.08.2020 16:53, Andrew Cooper wrote: > On 17/08/2020 16:57, Roger Pau Monne wrote: >> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c >> index ca3bbfcbb3..671cdcb724 100644 >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -1917,6 +1917,13 @@ st

Re: [PATCH v2 4/8] x86/svm: drop writes to BU_CFG on revF chips

2020-08-27 Thread Jan Beulich
On 20.08.2020 17:08, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -2125,6 +2125,12 @@ static int svm_msr_write_intercept(unsigned int msr, > uint64_t msr_content) > nsvm->ns_msr_hsavepa = msr_content; > break; > > +case M

[qemu-mainline test] 152878: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152878 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152878/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-amd 10 redhat-install fail REGR. vs. 152631 test-amd64-amd64-

[xen-unstable-smoke test] 152898: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152898 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152898/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 152892 Tests which

Re: [PATCH v2 5/8] x86/pv: allow reading FEATURE_CONTROL MSR

2020-08-27 Thread Jan Beulich
On 20.08.2020 17:08, Roger Pau Monne wrote: > @@ -181,6 +182,18 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t > *val) > /* Not offered to guests. */ > goto gp_fault; > > +case MSR_IA32_FEATURE_CONTROL: > +if ( !(cp->x86_vendor & X86_VENDOR_INTEL) ) > +

Re: [PATCH 2/2] arm/xen: Add misuse warning to virt_to_gfn

2020-08-27 Thread Stefano Stabellini
On Thu, 27 Aug 2020, Jürgen Groß wrote: > On 27.08.20 10:24, Julien Grall wrote: > > > > > > On 27/08/2020 06:21, Jürgen Groß wrote: > > > On 26.08.20 20:37, Julien Grall wrote: > > > "Usually" is a bit gross here. The only generic call site I could find > > > is xenbus_grant_ring(). All other in

Re: [xen-unstable-smoke test] 152898: regressions - FAIL

2020-08-27 Thread Jan Beulich
On 27.08.2020 17:49, osstest service owner wrote: > flight 152898 xen-unstable-smoke real [real] > http://logs.test-lab.xenproject.org/osstest/logs/152898/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-amd64

Re: [PATCH v4 2/2] xen/arm: Throw messages for unknown FP/SIMD implement ID

2020-08-27 Thread Julien Grall
Hi, On 25/08/2020 17:06, Wei Chen wrote: Arm ID_AA64PFR0_EL1 register provides two fields to describe CPU FP/SIMD implementations. Currently, we exactly know the meaning of 0x0, 0x1 and 0xf of these fields. Xen treats value < 8 as FP/SIMD features presented. If there is a value 0x2 bumped in the

Re: [PATCH v3 00/74] qom: Automated conversion of type checking boilerplate

2020-08-27 Thread Eduardo Habkost
On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote: > git tree for this series: > https://github.com/ehabkost/qemu-hacks/tree/work/qom-macros-autoconvert > > This is an extension of the series previously submitted by > Daniel[1], including a script that will convert existing type > ch

Re: [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable

2020-08-27 Thread Bjorn Helgaas
[+cc Rob, cover https://lore.kernel.org/r/20200826111628.794979...@linutronix.de/ this https://lore.kernel.org/r/20200826112333.992429...@linutronix.de/] On Wed, Aug 26, 2020 at 01:17:02PM +0200, Thomas Gleixner wrote: > From: Thomas Gleixner > > The arch_.*_msi_irq[s] fallbacks are compiled in

[xen-unstable test] 152896: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152896 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152896/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 152877 build-amd64-xsm

Re: [xen-unstable-smoke test] 152898: regressions - FAIL

2020-08-27 Thread Samuel Thibault
Costin Lupu, le jeu. 27 août 2020 19:47:08 +0300, a ecrit: > On 8/27/20 7:07 PM, Jan Beulich wrote: > > On 27.08.2020 17:49, osstest service owner wrote: > >> flight 152898 xen-unstable-smoke real [real] > >> http://logs.test-lab.xenproject.org/osstest/logs/152898/ > >> > >> Regressions :-( > >> >

[xen-unstable-smoke test] 152910: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152910 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152910/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 152892 Tests which

Re: [PATCH] stubdom/grub: Update init_netfront() call for mini-os

2020-08-27 Thread Samuel Thibault
Costin Lupu, le jeu. 27 août 2020 22:12:57 +0300, a ecrit: > This patch updates the call of init_netfront() function according to its > recently updated declaration which can also include parameters for gateway > and netmask addresses. While we are here, the patch also removes passing > the ip para

[PATCH] stubdom/grub: Update init_netfront() call for mini-os

2020-08-27 Thread Costin Lupu
This patch updates the call of init_netfront() function according to its recently updated declaration which can also include parameters for gateway and netmask addresses. While we are here, the patch also removes passing the ip parameter because (a) it is not used anywhere and (b) it wastes memory

[qemu-mainline test] 152911: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152911 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152911/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3866 xen-buildfail REGR. vs. 152631 build-amd64-xsm

[ovmf test] 152915: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152915 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152915/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

Re: [PATCH] stubdom/grub: Update init_netfront() call for mini-os

2020-08-27 Thread Costin Lupu
Hi Samuel, Sorry for spamming. I resent the patch because I wasn't subscribed to xen-devel when I sent the first one and I know there might be some issues with the patches arriving on the list for authors who aren't subscribed. Cheers, Costin On 8/27/20 10:16 PM, Samuel Thibault wrote: > Costin

[linux-linus test] 152886: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152886 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152886/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-boot fail REGR. vs. 152332 test-amd64-i386-xl-

[ovmf test] 152924: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152924 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152924/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[ovmf test] 152930: regressions - FAIL

2020-08-27 Thread osstest service owner
flight 152930 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152930/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[PATCH v4 3/4] tools/ocaml/xenstored: use more efficient node trees

2020-08-27 Thread Edwin Török
This changes the output of xenstore-ls to be sorted. Previously the keys were listed in the order in which they were inserted in. docs/misc/xenstore.txt doesn't specify in what order keys are listed. Map.update is used to retain semantics with replace_child: only an existing child is replaced, if

[PATCH v4 1/4] tools/ocaml/xenstored: replace hand rolled GC with weak GC references

2020-08-27 Thread Edwin Török
The code here is attempting to reduce memory usage by sharing common substrings in the tree: it replaces strings with ints, and keeps a string->int map that gets manually garbage collected using a hand-rolled mark and sweep algorithm. This is unnecessary: OCaml already has a mark-and-sweep Garbage

[PATCH v4 2/4] Map: backport find_opt/update from 4.06

2020-08-27 Thread Edwin Török
We are currently on OCaml 4.02 as minimum version. To make the followup optimizations compile backport these functions from OCaml 4.06. This implementation is less efficient than the one in the 4.06 standard library which has access to the internals of the Map. Signed-off-by: Edwin Török --- Cha

[PATCH v4 0/4] tools/ocaml/xenstored: simplify code

2020-08-27 Thread Edwin Török
This refreshes the V3 patches to work with OCaml 4.02. Upgrading to 4.06 will come as a separate series. This patch is new in V4, the other patches were already acked in V3: [PATCH v4 2/4] Map: backport find_opt/update from 4.06 A git tree with this and other series is available at: https://gitla

[PATCH v4 4/4] tools/ocaml/xenstored: use more efficient tries

2020-08-27 Thread Edwin Török
No functional change, just an optimization. Signed-off-by: Edwin Török Acked-by: Christian Lindig --- Changes since V3: * none, repost after previous commits fix compatibility with OCaml 4.02 --- tools/ocaml/xenstored/connections.ml | 2 +- tools/ocaml/xenstored/symbol.ml | 6 +-- tools/

[PATCH v1 7/9] tools/ocaml/xenstored: don't store domU's mfn of ring page

2020-08-27 Thread Edwin Török
This is a port of the following C xenstored commit 122b52230aa5b79d65e18b8b77094027faa2f8e2 tools/xenstore: don't store domU's mfn of ring page in xenstored Backwards compat: accept a domain dump both with and without MFN. CC: Signed-off-by: Juergen Gross Signed-off-by: Edwin Török --- tools/

[PATCH v1 5/9] tools/ocaml: safer Xenmmap interface

2020-08-27 Thread Edwin Török
Xenmmap.mmap_interface is created from multiple places: * via mmap(), which needs to be unmap()-ed * xc_map_foreign_range * xengnttab_map_grant_ref Signed-off-by: Edwin Török --- tools/ocaml/libs/mmap/xenmmap.ml | 14 -- tools/ocaml/libs/mmap/xenmmap.mli | 11 --- tools/ocam

[PATCH v1 6/9] tools/ocaml/xenstored: use gnttab instead of xenctrl's foreign_map_range

2020-08-27 Thread Edwin Török
This is an oxenstored port of the following C xenstored commit: 38eeb3864de40aa568c48f9f26271c141c62b50b tools/xenstored: Drop mapping of the ring via foreign map Now only Xenctrl.domain_getinfo remains as the last use of unstable xenctrl interface in oxenstored. Depends on: tools/ocaml: safer

[PATCH v1 2/9] tools/ocaml/libs/mmap: allocate correct number of bytes

2020-08-27 Thread Edwin Török
OCaml memory allocation functions use words as units, unless explicitly documented otherwise. Thus we were allocating more memory than necessary, caml_alloc should've been called with the parameter '2', but was called with a lot more. To account for future changes in the struct keep using sizeof, b

[PATCH v1 3/9] tools/ocaml/libs/mmap: Expose stub_mmap_alloc

2020-08-27 Thread Edwin Török
This also handles mmap errors better by using the `uerror` helper to raise a proper exception using `errno`. Changed type of `len` from `int` to `size_t`: at construction time we ensure the length is >= 0, so we can reflect this by using an unsigned type. The type is unsigned at the C API level, a

[PATCH v1 4/9] tools/ocaml/libs/xb: import gnttab stubs from mirage

2020-08-27 Thread Edwin Török
Upstream URL: https://github.com/mirage/ocaml-gnt Mirage is part of the Xen project and the license is compatible, copyright headers are retained. Changes from upstream: * cut down dependencies: dropped Lwt, replaced Io_page with Xenmmap * only import Gnttab and not Gntshr This is for xenstored's

[PATCH v1 9/9] tools/ocaml/libs/mmap: Clean up unused read/write

2020-08-27 Thread Edwin Török
Xenmmap is only modified by the ring functions, these functions are unused. Signed-off-by: Edwin Török --- tools/ocaml/libs/mmap/xenmmap.ml | 5 tools/ocaml/libs/mmap/xenmmap.mli | 4 --- tools/ocaml/libs/mmap/xenmmap_stubs.c | 41 --- 3 files changed, 50

[PATCH v1 1/9] tools/ocaml: use common macros for manipulating mmap_interface

2020-08-27 Thread Edwin Török
Signed-off-by: Edwin Török --- tools/ocaml/libs/mmap/mmap_stubs.h| 7 +++ tools/ocaml/libs/mmap/xenmmap_stubs.c | 2 -- tools/ocaml/libs/xb/xs_ring_stubs.c | 14 +- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/tools/ocaml/libs/mmap/mmap_stubs.h b/tools

[PATCH v1 0/9] tools/ocaml: use gnttab instead of map_foreign_range

2020-08-27 Thread Edwin Török
oxenstored currently depends on 2 unstable interfaces from libxenctrl: * Xenctrl.map_foreign_range * Xenctrl.domain_getinfo It is desirable to reduce the use of unstable APIs in xenstored, so that an update to the hypervisor doesn't break xenstored. The C version of xenstored has dropped the usag

  1   2   >