> -Original Message-
> From: Wei Liu
> Sent: 03 July 2020 21:11
> To: Anthony PERARD
> Cc: Paul Durrant ; xen-devel@lists.xenproject.org; Roger Pau
> Monné
> ; Ian Jackson ; Wei Liu
>
> Subject: Re: [XEN PATCH for-4.14] Config: Update QEMU
>
> On Fri, Jul 03, 2020 at 02:55:33PM +0100,
> -Original Message-
> From: Andrew Cooper
> Sent: 03 July 2020 16:03
> To: Jan Beulich ; Roger Pau Monné
> Cc: xen-devel@lists.xenproject.org; Wei Liu ; Paul Durrant
>
> Subject: Re: vPT rework (and timer mode)
>
> On 03/07/2020 15:50, Jan Beulich wrote:
> > On 01.07.2020 11:02, Roger
flight 151656 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151656/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install
fail REGR. vs. 15106
Philippe Mathieu-Daudé writes:
> On 7/3/20 11:08 AM, Vladimir Sementsov-Ogievskiy wrote:
>> If we want to add some info to errp (by error_prepend() or
>> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
>> Otherwise, this info will not be added when errp == &error_fatal
>> (the pr
04.07.2020 19:36, Philippe Mathieu-Daudé wrote:
On 7/3/20 11:08 AM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &error_fatal
(th
On 05.07.2020 21:11, Michał Leszczyński wrote:
> - 5 lip 2020 o 20:54, Michał Leszczyński michal.leszczyn...@cert.pl
> napisał(a):
>> --- a/xen/arch/x86/domain.c
>> +++ b/xen/arch/x86/domain.c
>> @@ -2199,6 +2199,25 @@ int domain_relinquish_resources(struct domain *d)
>> altp2m
On Mon, Jul 06, 2020 at 08:03:50AM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Andrew Cooper
> > Sent: 03 July 2020 16:03
> > To: Jan Beulich ; Roger Pau Monné
> > Cc: xen-devel@lists.xenproject.org; Wei Liu ; Paul Durrant
> >
> > Subject: Re: vPT rework (and timer mode)
On 05.07.2020 20:58, Michał Leszczyński wrote:
> - 5 lip 2020 o 20:55, Michał Leszczyński michal.leszczyn...@cert.pl
> napisał(a):
>> --- /dev/null
>> +++ b/tools/proctrace/proctrace.c
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +#include
>> +#include
>> +#include
>> +
>
On Sun, Jul 05, 2020 at 08:54:59PM +0200, Michał Leszczyński wrote:
> From: Michal Leszczynski
>
> Implement necessary changes in common code/HVM to support
> processor trace features. Define vmtrace_pt_* API and
> implement trace buffer allocation/deallocation in common
> code.
>
> Signed-off-b
On 04.07.2020 19:23, Julien Grall wrote:
> Hi,
>
> On 03/07/2020 11:11, Roger Pau Monné wrote:
>> On Fri, Jul 03, 2020 at 11:56:38AM +0200, Jan Beulich wrote:
>>> On 03.07.2020 11:44, Roger Pau Monné wrote:
On Thu, Jul 02, 2020 at 06:23:28PM +0200, Michał Leszczyński wrote:
> - 2 lip
> -Original Message-
> From: Roger Pau Monné
> Sent: 06 July 2020 09:32
> To: p...@xen.org
> Cc: 'Andrew Cooper' ; 'Jan Beulich'
> ; xen-
> de...@lists.xenproject.org; 'Wei Liu'
> Subject: Re: vPT rework (and timer mode)
>
> On Mon, Jul 06, 2020 at 08:03:50AM +0100, Paul Durrant wrote:
On 06/07/2020 09:33, Jan Beulich wrote:
> On 05.07.2020 20:58, Michał Leszczyński wrote:
>> - 5 lip 2020 o 20:55, Michał Leszczyński michal.leszczyn...@cert.pl
>> napisał(a):
>>> --- /dev/null
>>> +++ b/tools/proctrace/proctrace.c
>>> +#include
>>> +#include
>>> +#include
>>> +#include
>>>
- 6 lip 2020 o 10:42, Roger Pau Monné roger@citrix.com napisał(a):
> On Sun, Jul 05, 2020 at 08:54:59PM +0200, Michał Leszczyński wrote:
>> From: Michal Leszczynski
>>
>> Implement necessary changes in common code/HVM to support
>> processor trace features. Define vmtrace_pt_* API and
>>
- 5 lip 2020 o 20:54, Michał Leszczyński michal.leszczyn...@cert.pl
napisał(a):
> From: Michal Leszczynski
>
> Add vmtrace_pt_size domain parameter in live domain and
> vmtrace_pt_order parameter in xen_domctl_createdomain.
>
> Signed-off-by: Michal Leszczynski
> ---
> xen/common/domain.c
- 6 lip 2020 o 11:47, Andrew Cooper andrew.coop...@citrix.com napisał(a):
> On 06/07/2020 09:33, Jan Beulich wrote:
>> On 05.07.2020 20:58, Michał Leszczyński wrote:
>>> - 5 lip 2020 o 20:55, Michał Leszczyński michal.leszczyn...@cert.pl
>>> napisał(a):
--- /dev/null
+++ b/tools/
Hi,
On 05/07/2020 19:55, Michał Leszczyński wrote:
From: Michal Leszczynski
Allow to map processor trace buffer using
acquire_resource().
Signed-off-by: Michal Leszczynski
---
xen/common/memory.c | 28
xen/include/public/memory.h | 1 +
2 files chang
Hi Michal,
On 05/07/2020 19:55, Michał Leszczyński wrote:
+/* XEN_DOMCTL_vmtrace_op: Perform VM tracing related operation */
+#if defined(__XEN__) || defined(__XEN_TOOLS__)
+
+struct xen_domctl_vmtrace_op {
+/* IN variable */
+uint32_t cmd;
+/* Enable/disable external vmtrace for given d
- 6 lip 2020 o 10:31, Jan Beulich jbeul...@suse.com napisał(a):
> On 05.07.2020 21:11, Michał Leszczyński wrote:
>> - 5 lip 2020 o 20:54, Michał Leszczyński michal.leszczyn...@cert.pl
>> napisał(a):
>>> --- a/xen/arch/x86/domain.c
>>> +++ b/xen/arch/x86/domain.c
>>> @@ -2199,6 +2199,25 @@
On 06.07.2020 12:31, Julien Grall wrote:
> On 05/07/2020 19:55, Michał Leszczyński wrote:
>> +/* XEN_DOMCTL_vmtrace_op: Perform VM tracing related operation */
>> +#if defined(__XEN__) || defined(__XEN_TOOLS__)
>> +
>> +struct xen_domctl_vmtrace_op {
>> +/* IN variable */
>> +uint32_t cmd;
On 06/07/2020 11:37, Jan Beulich wrote:
On 06.07.2020 12:31, Julien Grall wrote:
On 05/07/2020 19:55, Michał Leszczyński wrote:
+/* XEN_DOMCTL_vmtrace_op: Perform VM tracing related operation */
+#if defined(__XEN__) || defined(__XEN_TOOLS__)
+
+struct xen_domctl_vmtrace_op {
+/* IN vari
Hi,
On 05/07/2020 19:54, Michał Leszczyński wrote:
From: Michal Leszczynski
Add vmtrace_pt_size domain parameter in live domain and
vmtrace_pt_order parameter in xen_domctl_createdomain.
Signed-off-by: Michal Leszczynski
---
xen/common/domain.c | 12
xen/include/publi
Hi,
On 05/07/2020 20:02, Michał Leszczyński wrote:
- 5 lip 2020 o 20:54, Michał Leszczyński michal.leszczyn...@cert.pl
napisał(a):
From: Michal Leszczynski
Allow to specify the size of per-vCPU trace buffer upon
domain creation. This is zero by default (meaning: not enabled).
Signed-of
On 06.07.2020 12:38, Julien Grall wrote:
> On 06/07/2020 11:37, Jan Beulich wrote:
>> On 06.07.2020 12:31, Julien Grall wrote:
>>> On 05/07/2020 19:55, Michał Leszczyński wrote:
+/* XEN_DOMCTL_vmtrace_op: Perform VM tracing related operation */
+#if defined(__XEN__) || defined(__XEN_TOOLS
flight 151661 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151661/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-amd64-examine4 memdisk-try-append fail in 151635 pass in 151661
test-amd64-i386-libvirt-xsm 18
flight 151671 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151671/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-arm64-arm64-xl-xsm 7 xen-boot fail REGR. vs. 151535
Tests which
flight 151665 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151665/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-libvirt-pair 22 guest-migrate/src_host/dst_host fail REGR.
vs. 151496
test-amd64-i38
A pair of patches which helps me debug an issue with block
drive already attached.
Suggestions to correctly/better use the Error API welcome, in
particular in qdev-properties-system::set_drive_helper().
Philippe Mathieu-Daudé (2):
block/block-backend: Trace blk_attach_dev()
block/block-backen
Let blk_attach_dev() take an Error* object to return helpful
information. Adapt the callers.
$ qemu-system-arm -M n800
qemu-system-arm: sd_init failed: cannot attach blk 'sd0' to device 'sd-card'
because it is already attached by device 'omap2-mmc'
Drive 'sd0' is already in use because it h
Add a trace event to follow devices attaching block drives:
$ qemu-system-arm -M n800 -trace blk_\*
9513@1594040428.738162:blk_attach_dev attaching blk 'sd0' to device
'omap2-mmc'
9513@1594040428.738189:blk_attach_dev attaching blk 'sd0' to device 'sd-card'
qemu-system-arm: sd_init failed
On Mon, Jul 06, 2020 at 12:09:02PM +0200, Michał Leszczyński wrote:
> - 6 lip 2020 o 10:42, Roger Pau Monné roger@citrix.com napisał(a):
>
> > On Sun, Jul 05, 2020 at 08:54:59PM +0200, Michał Leszczyński wrote:
> >> From: Michal Leszczynski
> >>
> >> Implement necessary changes in common
flight 151662 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151662/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl-cubietruck broken
test-armhf-armhf-xl-cubietruck 4 host-i
AMD CPUs that we classify as X86_BUG_FPU_PTRS don't touch the selector/
offset portion of the save image during FXSAVE unless an unmasked
exception is pending. Hence the selector zapping done between the
initial FXSAVE and the emulated FXRSTOR needs to be mirrored onto the
second FXSAVE, output of
On 06/07/2020 16:14, Jan Beulich wrote:
> AMD CPUs that we classify as X86_BUG_FPU_PTRS don't touch the selector/
> offset portion of the save image during FXSAVE unless an unmasked
> exception is pending. Hence the selector zapping done between the
> initial FXSAVE and the emulated FXRSTOR needs t
> -Original Message-
> From: Andrew Cooper
> Sent: 06 July 2020 16:47
> To: Jan Beulich ; xen-devel@lists.xenproject.org
> Cc: Wei Liu ; Roger Pau Monné ; Paul
> Durrant
> Subject: Re: [PATCH] x86emul: fix FXRSTOR test for most AMD CPUs
>
> On 06/07/2020 16:14, Jan Beulich wrote:
> > AM
# Design Session Notes - "How best to upstream Bareflank's implementation
of the Xen VMM into the Xen Project"
## Design Session Description
Assured Information Security, Inc. has been working on a new implementation
of the Xen VMM (i.e., just the root component of the Xen hypervisor) using
Barefla
flight 151679 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151679/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
Patchew URL:
https://patchew.org/QEMU/20200706162300.1084753-1-dinec...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] trivial: Remove trailing whitespaces
Type: series
Message-id: 20200706162300.1084753-1-dinec...
On Sat, Jul 4, 2020 at 7:53 AM Philippe Mathieu-Daudé wrote:
>
> We only use these register definitions in files under the
> hw/usb/ directory. Keep that header local by moving it there.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> {include/hw => h
On Sat, Jul 4, 2020 at 7:51 AM Philippe Mathieu-Daudé wrote:
>
> This file doesn't access anything from "hw/usb.h", remove its
> inclusion.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/arm/sbsa-ref.c | 1 -
> 1 file changed, 1 deletion(-)
>
> di
On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathieu-Daudé wrote:
>
> This file uses pci_create_simple() and PCI_DEVFN() which are both
> declared in "hw/pci/pci.h". This include is indirectly included
> by an USB header. As we want to reduce the USB header inclusions
> later, include the PCI header no
On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathieu-Daudé wrote:
>
> Commit a5d2f7273c ("qdev/usb: make qemu aware of usb busses")
> removed the last use of VM_USB_HUB_SIZE, 11 years ago. Time
> to drop it.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
>
On Sat, Jul 4, 2020 at 7:52 AM Philippe Mathieu-Daudé wrote:
>
> "exec/memory.h" is only required by "hw/usb/hcd-musb.h".
> Include it there directly.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> include/hw/usb.h | 1 -
> include/hw/usb/hc
On Sat, Jul 4, 2020 at 7:53 AM Philippe Mathieu-Daudé wrote:
>
> "qemu/error-report.h" and "qemu/main-loop.h" are not used.
> Remove them.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/usb/hcd-dwc2.c | 2 --
> 1 file changed, 2 deletions(-)
>
> d
On Sat, Jul 4, 2020 at 7:52 AM Philippe Mathieu-Daudé wrote:
>
> This header uses the USBPacket and USBDevice types which are
> forward declared in "hw/usb.h".
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/usb/desc.h | 1 +
> 1 file changed, 1 in
On Sat, Jul 4, 2020 at 7:52 AM Philippe Mathieu-Daudé wrote:
>
> The header "usb/hcd-dwc2.h" doesn't need to include "qemu/timer.h",
> "sysemu/dma.h", "hw/irq.h" (the types required are forward declared).
> Include them in the source file which is the only one requiring the
> function declarations
On Sat, Jul 4, 2020 at 7:55 AM Philippe Mathieu-Daudé wrote:
>
> As "qemu/main-loop.h" is not used, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/usb/hcd-ehci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/usb/hcd-ehci.c
On Sat, Jul 4, 2020 at 7:54 AM Philippe Mathieu-Daudé wrote:
>
> This header uses the USBPort type which is forward declared
> by "hw/usb.h".
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/usb/hcd-xhci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
On Sat, Jul 4, 2020 at 7:56 AM Philippe Mathieu-Daudé wrote:
>
> "hcd-musb.h" is only required by USB device implementions.
> As we keep these implementations in the hw/usb/ directory,
> move the header there.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
>
On Sat, Jul 4, 2020 at 7:53 AM Philippe Mathieu-Daudé wrote:
>
> Move definitions only useful for hcd-ehci.c to this source file.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/usb/hcd-ehci.h | 11 ---
> hw/usb/hcd-ehci.c | 12
On Sat, Jul 4, 2020 at 7:59 AM Philippe Mathieu-Daudé wrote:
>
> USBDescString is forward-declared. Only bus.c uses the
> usb_device_get_product_desc() and usb_device_get_usb_desc()
> function. Move all that to the "desc.h" header to reduce
> the big "hw/usb.h" header a bit.
>
> Signed-off-by: Phi
On Sat, Jul 4, 2020 at 7:58 AM Philippe Mathieu-Daudé wrote:
>
> This file is not a header, but contains source code which is
> included and compiled once. We use the '.inc.c' suffix in few
> other cases in the repository. Follow the same convention with
> this file.
>
> Signed-off-by: Philippe Ma
There are a number of unnecessary trailing whitespaces that have
accumulated over time in the source code. They cause stray changes
in patches if you use tools that automatically remove them.
Tested by doing a `git diff -w` after the change.
This could probably be turned into a pre-commit hook.
flight 151669 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151669/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install
fail REGR. vs. 15106
On Sat, Jul 4, 2020 at 7:56 AM Philippe Mathieu-Daudé wrote:
>
> Only redirect.c consumes the quirks API. Reduce the big "hw/usb.h"
> header by moving the quirks related declaration into their own
> header. As nothing out of hw/usb/ requires it, keep it local.
>
> Signed-off-by: Philippe Mathieu-D
On Sat, Jul 4, 2020 at 7:58 AM Philippe Mathieu-Daudé wrote:
>
> If the device has USB_DEV_FLAG_FULL_PATH set, usb_get_dev_path()
> returns the full port path. Rename the function accordingly.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/usb/bus
On Sat, Jul 4, 2020 at 8:00 AM Philippe Mathieu-Daudé wrote:
>
> Simplify usb_get_dev_path() a bit.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/usb/bus.c | 19 +--
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --gi
Previously, if lock_pages() end up partially mapping pages, it used
to return -ERRNO due to which unlock_pages() have to go through
each pages[i] till *nr_pages* to validate them. This can be avoided
by passing correct number of partially mapped pages & -ERRNO separately,
while returning from lock_
pages need to be marked as dirty before unpinned it in
unlock_pages() which was oversight. This is fixed now.
Signed-off-by: Souptick Joarder
Suggested-by: John Hubbard
Cc: John Hubbard
Cc: Boris Ostrovsky
Cc: Paul Durrant
---
drivers/xen/privcmd.c | 5 -
1 file changed, 4 insertions(+),
This series contains few clean up, minor bug fixes and
Convert get_user_pages() to pin_user_pages().
I'm compile tested this, but unable to run-time test,
so any testing help is much appriciated.
v2:
Addressed few review comments and compile issue.
Patch[1/2] from v1 split into 2
In 2019, we introduced pin_user_pages*() and now we are converting
get_user_pages*() to the new API as appropriate. [1] & [2] could
be referred for more information. This is case 5 as per document [1].
[1] Documentation/core-api/pin_user_pages.rst
[2] "Explicit pinning of user-space pages":
flight 151687 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151687/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
flight 151681 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151681/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl-cubietruckbroken in 151662
build-i386-pvops 6
On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathieu-Daudé
wrote:
> The header "usb/hcd-dwc2.h" doesn't need to include "qemu/timer.h",
> "sysemu/dma.h", "hw/irq.h" (the types required are forward declared).
> Include them in the source file which is the only one requiring the
> function declarations.
On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathieu-Daudé
wrote:
> "qemu/error-report.h" and "qemu/main-loop.h" are not used.
> Remove them.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/usb/hcd-dwc2.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-d
On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathieu-Daudé
wrote:
> We only use these register definitions in files under the
> hw/usb/ directory. Keep that header local by moving it there.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> {include/hw => hw}/usb/dwc2-regs.h | 0
> hw/usb/hcd-dwc2.c
On Sat, Jul 4, 2020 at 7:59 AM Philippe Mathieu-Daudé wrote:
>
> To avoid to access the USBDevice internals, and use the
> recently added usb_get_port_path() helper instead.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/ppc/spapr.c | 6 --
>
On Sat, Jul 4, 2020 at 8:00 AM Philippe Mathieu-Daudé wrote:
>
> Refactor usb_get_full_dev_path() to take a 'want_full_path'
> argument, and add usb_get_port_path() which returns a short
> path.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> include/
flight 151684 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151684/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl-vhd 11 guest-start fail REGR. vs. 151661
Regressions which
68 matches
Mail list logo
