Hi, On 05/07/2020 19:54, Michał Leszczyński wrote:
From: Michal Leszczynski <michal.leszczyn...@cert.pl>Add vmtrace_pt_size domain parameter in live domain and vmtrace_pt_order parameter in xen_domctl_createdomain. Signed-off-by: Michal Leszczynski <michal.leszczyn...@cert.pl> --- xen/common/domain.c | 12 ++++++++++++ xen/include/public/domctl.h | 1 + xen/include/xen/sched.h | 4 ++++ 3 files changed, 17 insertions(+) diff --git a/xen/common/domain.c b/xen/common/domain.c index a45cf023f7..25d3359c5b 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -338,6 +338,12 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config) return -EINVAL; }+ if ( config->vmtrace_pt_order && !vmtrace_supported )
Looking at the rest of the series, vmtrace will only be supported for x86 HVM guest. So don't you want to return -EINVAL for PV guests here?
This could be done in a new helper arch_vmtrace_supported() or possibly in the existing arch_sanitise_domain_config().
Cheers, -- Julien Grall
