Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-17 Thread SeongJae Park
On Tue, 17 Dec 2019 07:23:12 +0100 "Jürgen Groß" wrote: > On 16.12.19 20:48, SeongJae Park wrote: > > On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote: > > > >> On 16.12.19 17:15, SeongJae Park wrote: > >>> On Mon, 16 Dec 2019 15:37:20 +0100 SeongJae Park > >>> wrote: > >>> > On Mon,

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-17 Thread Jürgen Groß
On 17.12.19 08:59, SeongJae Park wrote: On Tue, 17 Dec 2019 07:23:12 +0100 "Jürgen Groß" wrote: On 16.12.19 20:48, SeongJae Park wrote: On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote: On 16.12.19 17:15, SeongJae Park wrote: On Mon, 16 Dec 2019 15:37:20 +0100 SeongJae Park wrote: O

[Xen-devel] [ovmf test] 144892: regressions - FAIL

2019-12-17 Thread osstest service owner
flight 144892 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144892/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-17 Thread SeongJae Park
On Tue, 17 Dec 2019 09:16:47 +0100 "Jürgen Groß" wrote: > On 17.12.19 08:59, SeongJae Park wrote: > > On Tue, 17 Dec 2019 07:23:12 +0100 "Jürgen Groß" wrote: > > > >> On 16.12.19 20:48, SeongJae Park wrote: > >>> On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote: > >>> > On 16.12.19 17:

[Xen-devel] [Bug] panic on xen 4.11.2-pre

2019-12-17 Thread Limitless Green
Hello, I was asked via IRC to post my issue here. I got the following through the debug interface: 0x:0x00:0x1f.0x6: ROM: 0x10400 bytes at 0x7ffc7018 (XEN) Xen version 4.11.2-pre (Debian 4.11.1+92-g6c33308a8d-2) (pkg-xen-de...@lists.alioth.debian.org) (gcc (Debian 8.3.0-7) 8.3.0) debug=n

[Xen-devel] [libvirt test] 144885: tolerable all pass - PUSHED

2019-12-17 Thread osstest service owner
flight 144885 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/144885/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 144853 test-armhf-armhf-libvirt-raw 13 saveresto

[Xen-devel] [ovmf test] 144893: regressions - FAIL

2019-12-17 Thread osstest service owner
flight 144893 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144893/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

[Xen-devel] [XEN PATCH v2 4/6] xen: Move CONFIG_INDIRECT_THUNK to Kconfig

2019-12-17 Thread Anthony PERARD
Now that Kconfig has the capability to run shell command when generating CONFIG_* we can use it in some cases to test CFLAGS. CONFIG_INDIRECT_THUNK is a good example that wants to exist both in Makefile and as a C macro, which Kconfig do. So use Kconfig to generate CONFIG_INDIRECT_THUNK and have t

[Xen-devel] [XEN PATCH v2 2/6] xen: Have Kconfig check $(CC)'s version

2019-12-17 Thread Anthony PERARD
This import several files from Linux v5.3 - scripts/Kconfig.include - scripts/clang-version.sh - scripts/gcc-version.sh and several config values from from Linux's init/Kconfig file. Files are copied into scripts/ directory because that's were the files are found in Linux tree, and also becaus

[Xen-devel] [XEN PATCH v2 5/6] xen: Use $(CONFIG_CC_IS_CLANG) instead of $(clang) in Makefile

2019-12-17 Thread Anthony PERARD
Kconfig can check if $(CC) is clang or not, if it is CONFIG_CC_IS_CLANG will be set. With that patch, the hypervisor can be built using clang by running `make CC=clang CXX=clang++` without needed to provide an extra clang parameter. `make clang=y` still works as Config.mk will set CC and CXX. Si

[Xen-devel] [XEN PATCH v2 0/6] xen: Kconfig update with few extra

2019-12-17 Thread Anthony PERARD
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.build-system-xen-kconfig-v2 v2: nit changes in patch 1 and 2. Hi, This is a update of Kconfig as used to build the hypervisor. This is also in preparation of using Kbuild. The firs

[Xen-devel] [XEN PATCH v2 3/6] xen: Import cc-ifversion from Kbuild

2019-12-17 Thread Anthony PERARD
This is in preparation of importing Kbuild to build Xen. We won't be able to include Config.mk so we will need a replacement for the macro `cc-ifversion'. This patch imports parts of "scripts/Kbuild.include" from Linux v5.4, the macro cc-ifversion. It makes use of CONFIG_GCC_VERSION that Kconfig n

[Xen-devel] [XEN PATCH v2 6/6] xen: Move GCC_HAS_VISIBILITY_ATTRIBUTE to Kconfig and common

2019-12-17 Thread Anthony PERARD
The check for $(CC) -fvisibility=hidden is done by both arm and x86, so the patch also move the check to the common area. The check doesn't check if $(CC) is gcc, and clang can accept that option as well, so s/GCC/CC/ is done to the define name. Signed-off-by: Anthony PERARD Acked-by: Andrew Coo

Re: [Xen-devel] [PATCH v3 17/22] golang/xenlight: implement array C to Go marshaling

2019-12-17 Thread George Dunlap
On 12/10/19 3:47 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Signed-off-by: Nick Rosbrook > --- > tools/golang/xenlight/gengotypes.py | 39 +++- > tools/golang/xenlight/helpers.gen.go | 300 +++ > 2 files changed, 338 insertions(+), 1 deletion(-) > > diff --git

Re: [Xen-devel] Xen ARM Dom0less passthrough without IOMMU

2019-12-17 Thread Julien Grall
On 17/12/2019 01:18, Stefano Stabellini wrote: On Mon, 16 Dec 2019, Julien Grall wrote: On 16/12/2019 23:05, Stefano Stabellini wrote: On Mon, 16 Dec 2019, Julien Grall wrote: On 16/12/2019 18:02, Andrei Cherechesu wrote: But even with this patch, RAM in DomU is not direct mapped (i.e Guest

Re: [Xen-devel] [Bug] panic on xen 4.11.2-pre

2019-12-17 Thread Jan Beulich
On 17.12.2019 11:02, Limitless Green wrote: > Hello, > > I was asked via IRC to post my issue here. I got the following through > the debug interface: > > > 0x:0x00:0x1f.0x6: ROM: 0x10400 bytes at 0x7ffc7018 > (XEN) Xen version 4.11.2-pre (Debian 4.11.1+92-g6c33308a8d-2) > (pkg-xen-de...@l

Re: [Xen-devel] REGRESSION: Xen 4.13 RC5 fails to bootstrap Dom0 on ARM

2019-12-17 Thread Julien Grall
Hi, On 17/12/2019 04:39, Roman Shaposhnik wrote: On Mon, Dec 16, 2019 at 6:55 PM Stefano Stabellini wrote: On Mon, 16 Dec 2019, Roman Shaposhnik wrote: If I sum all the memory sizes together I get 0x3ddfd000 which is 990M. If so, I wonder how you could boot succesfully with dom0_mem=1024M even

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-17 Thread Roger Pau Monné
On Mon, Dec 16, 2019 at 08:48:03PM +0100, SeongJae Park wrote: > On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote: > > > On 16.12.19 17:15, SeongJae Park wrote: > > > On Mon, 16 Dec 2019 15:37:20 +0100 SeongJae Park > > > wrote: > > > > > >> On Mon, 16 Dec 2019 13:45:25 +0100 SeongJae Park

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: > The trampoline has already set up the idle pagetables (which are the correct > ones to use), and sanitised the flags state. I wonder why do we have wakeup.S and wakeup_prot.S, it would be easier to follow if it all was in the same fi

Re: [Xen-devel] [PATCH 3/6] x86/suspend: Don't save unnecessary GPRs

2019-12-17 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 07:04:33PM +, Andrew Cooper wrote: > Only the callee-preserved registers need saving/restoring. Spill them to the > stack like regular functions do. %rsp is now the only GPR which gets stashed > in .data > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Andrew Cooper
On 17/12/2019 11:52, Roger Pau Monné wrote: > On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: >> The trampoline has already set up the idle pagetables (which are the correct >> ones to use), and sanitised the flags state. > I wonder why do we have wakeup.S and wakeup_prot.S, it would

Re: [Xen-devel] [PATCH 3/6] x86/suspend: Don't save unnecessary GPRs

2019-12-17 Thread Andrew Cooper
On 17/12/2019 12:04, Roger Pau Monné wrote: >> diff --git a/xen/arch/x86/acpi/wakeup_prot.S >> b/xen/arch/x86/acpi/wakeup_prot.S >> index 35fd7a5e9f..2f6c8e18ef 100644 >> --- a/xen/arch/x86/acpi/wakeup_prot.S >> +++ b/xen/arch/x86/acpi/wakeup_prot.S >> @@ -11,24 +11,14 @@ >> #define REF(x)

Re: [Xen-devel] [PATCH 3/6] x86/suspend: Don't save unnecessary GPRs

2019-12-17 Thread Roger Pau Monné
On Tue, Dec 17, 2019 at 12:10:55PM +, Andrew Cooper wrote: > On 17/12/2019 12:04, Roger Pau Monné wrote: > >> diff --git a/xen/arch/x86/acpi/wakeup_prot.S > >> b/xen/arch/x86/acpi/wakeup_prot.S > >> index 35fd7a5e9f..2f6c8e18ef 100644 > >> --- a/xen/arch/x86/acpi/wakeup_prot.S > >> +++ b/xen/a

Re: [Xen-devel] [PATCH 4/6] x86/suspend: Restore cr4 later during resume

2019-12-17 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 07:04:34PM +, Andrew Cooper wrote: > Just like the BSP/AP paths, %cr4 is loaded with only PAE. Defer restoring all > of %cr4 (MCE in particular) until all the system structures (IDT/TSS in > particular) have been loaded. > > Signed-off-by: Andrew Cooper Reviewed-by:

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Roger Pau Monné
On Tue, Dec 17, 2019 at 12:06:01PM +, Andrew Cooper wrote: > On 17/12/2019 11:52, Roger Pau Monné wrote: > > On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: > >> The trampoline has already set up the idle pagetables (which are the > >> correct > >> ones to use), and sanitised th

Re: [Xen-devel] [Bug] panic on xen 4.11.2-pre

2019-12-17 Thread Limitless Green
Hello, ty for the reply. I'm using the internal gfx of the Intel i3-8100. I have ECC unbuffered RAM, but I thing this shouldn't be an issue. How can I get these packages? I used the xen-hypervisor-common package from the debian buster repository. If I try to build it (debian too), I run into

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Andrew Cooper
On 17/12/2019 12:18, Roger Pau Monné wrote: > On Tue, Dec 17, 2019 at 12:06:01PM +, Andrew Cooper wrote: >> On 17/12/2019 11:52, Roger Pau Monné wrote: >>> On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: The trampoline has already set up the idle pagetables (which are the >

Re: [Xen-devel] [PATCH 5/6] x86/suspend: Expand macros in wakeup_prot.S

2019-12-17 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 07:04:35PM +, Andrew Cooper wrote: > Most users have been dropped, and they do nothing but obfuscate the assembly. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xe

Re: [Xen-devel] [PATCH 6/6] x86/suspend: Drop save_rest_processor_state() completely

2019-12-17 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 07:04:36PM +, Andrew Cooper wrote: > Construct the system linkage MSRs using percpu_traps_init(), brining the S3 > path in line with the BSP/AP path. Restore xcr0 from the per-cpu shadow copy. > > The FS/GS base values are unused in Xen context, and will be loaded > ap

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-17 Thread SeongJae Park
On Tue, 17 Dec 2019 12:39:15 +0100 "Roger Pau Monné" wrote: > On Mon, Dec 16, 2019 at 08:48:03PM +0100, SeongJae Park wrote: > > On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote: > > > > > On 16.12.19 17:15, SeongJae Park wrote: > > > > On Mon, 16 Dec 2019 15:37:20 +0100 SeongJae Park > >

[Xen-devel] [PATCH net-next 3/3] xen-netback: remove 'hotplug-status' once it has served its purpose

2019-12-17 Thread Paul Durrant
Removing the 'hotplug-status' node in netback_remove() is wrong; the script may not have completed. Only remove the node once the watch has fired and has been unregistered. Signed-off-by: Paul Durrant --- Cc: Wei Liu Cc: Paul Durrant Cc: "David S. Miller" --- drivers/net/xen-netback/xenbus.c

[Xen-devel] [PATCH net-next 1/3] xen-netback: move netback_probe() and netback_remove() to the end...

2019-12-17 Thread Paul Durrant
...of xenbus.c This is a cosmetic function re-ordering to reduce churn in a subsequent patch. Some style fix-up was done to make checkpatch.pl happier. No functional change. Signed-off-by: Paul Durrant --- Cc: Wei Liu Cc: Paul Durrant Cc: "David S. Miller" --- drivers/net/xen-netback/xenbus

[Xen-devel] [PATCH net-next 2/3] xen-netback: switch state to InitWait at the end of netback_probe()...

2019-12-17 Thread Paul Durrant
...as the comment above the function states. The switch to Initialising at the start of the function is somewhat bogus as the toolstack will have set that initial state anyway. To behave correctly, a backend should switch to InitWait once it has set up all xenstore values that may be required by a

[Xen-devel] [PATCH net-next 0/3] xen-netback: clean-up

2019-12-17 Thread Paul Durrant
Paul Durrant (3): xen-netback: move netback_probe() and netback_remove() to the end... xen-netback: switch state to InitWait at the end of netback_probe()... xen-netback: remove 'hotplug-status' once it has served its purpose drivers/net/xen-netback/xenbus.c | 350 +++---

[Xen-devel] [PATCH] libxc/restore: Fix error message for unrecognised stream version

2019-12-17 Thread Andrew Cooper
The Expected and Got values are rendered in the wrong order. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu This wants backporting to the stable trees --- tools/libxc/xc_sr_restore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_sr_restore.c

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-17 Thread Jürgen Groß
On 17.12.19 14:15, SeongJae Park wrote: On Tue, 17 Dec 2019 12:39:15 +0100 "Roger Pau Monné" wrote: On Mon, Dec 16, 2019 at 08:48:03PM +0100, SeongJae Park wrote: On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote: On 16.12.19 17:15, SeongJae Park wrote: On Mon, 16 Dec 2019 15:37:20 +01

Re: [Xen-devel] [PATCH] libxc/restore: Fix error message for unrecognised stream version

2019-12-17 Thread Wei Liu
On Tue, Dec 17, 2019 at 01:49:56PM +, Andrew Cooper wrote: > The Expected and Got values are rendered in the wrong order. > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.x

[Xen-devel] [RFC PATCH 2/3] xen: teach KASAN about grant tables

2019-12-17 Thread Sergey Dyasli
From: Ross Lagerwall Otherwise it produces lots of false positives. Signed-off-by: Ross Lagerwall Signed-off-by: Sergey Dyasli --- drivers/xen/grant-table.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 49b3

[Xen-devel] [RFC PATCH 1/3] x86/xen: add basic KASAN support for PV kernel

2019-12-17 Thread Sergey Dyasli
This enables to use Outline instrumentation for Xen PV kernels. KASAN_INLINE and KASAN_VMALLOC options currently lead to boot crashes and hence disabled. Rough edges in the patch are marked with XXX. Signed-off-by: Sergey Dyasli --- arch/x86/mm/init.c | 14 ++ arch/x86/mm/

[Xen-devel] [RFC PATCH 0/3] basic KASAN support for Xen PV domains

2019-12-17 Thread Sergey Dyasli
This series allows to boot and run Xen PV kernels (Dom0 and DomU) with CONFIG_KASAN=y. It has been used internally for some time now with good results for finding memory corruption issues in Dom0 kernel. Only Outline instrumentation is supported at the moment. Patch 1 is of RFC quality Patches 2-

[Xen-devel] [RFC PATCH 3/3] xen/netback: Fix grant copy across page boundary with KASAN

2019-12-17 Thread Sergey Dyasli
From: Ross Lagerwall When KASAN (or SLUB_DEBUG) is turned on, the normal expectation that allocations are aligned to the next power of 2 of the size does not hold. Therefore, handle grant copies that cross page boundaries. Signed-off-by: Ross Lagerwall Signed-off-by: Sergey Dyasli --- drivers

Re: [Xen-devel] [RFC 6/6] arm64: hyperv: Enable vDSO

2019-12-17 Thread Vitaly Kuznetsov
Boqun Feng writes: > Similar to x86, add a new vclock_mode VCLOCK_HVCLOCK, and reuse the > hv_read_tsc_page() for userspace to read tsc page clocksource. > > Signed-off-by: Boqun Feng (Microsoft) > --- > arch/arm64/include/asm/clocksource.h | 3 ++- > arch/arm64/include/asm/mshyperv.h

Re: [Xen-devel] [PATCH 1/2] Tidy up whitespace and formatting in file to be consistent.

2019-12-17 Thread Wei Liu
On Fri, Dec 13, 2019 at 03:08:34PM +1100, Steven Haigh wrote: > Signed-off-by: Steven Haigh Acked-by: Wei Liu I will need to add tools/hotplug to the subject line and the following commit message: Use 4 spaces for indentation throughout the file. No functional change. Wei.

[Xen-devel] [PATCH] 4.13.0: Update SUPPORT.md

2019-12-17 Thread Ian Jackson
Signed-off-by: Ian Jackson --- SUPPORT.md | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index f7a7a56c29..b24649ef2d 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -9,13 +9,13 @@ for the definitions of the support status levels etc. # Relea

Re: [Xen-devel] [PATCH 2/2] Use ip for bridge related functions where brctl is not present

2019-12-17 Thread Wei Liu
On Fri, Dec 13, 2019 at 03:08:35PM +1100, Steven Haigh wrote: > Signed-off-by: Steven Haigh > --- > tools/hotplug/Linux/colo-proxy-setup | 30 +-- > tools/hotplug/Linux/vif-bridge| 19 -- > tools/hotplug/Linux/vif2 | 12 +++-- >

Re: [Xen-devel] [PATCH] 4.13.0: Update SUPPORT.md

2019-12-17 Thread Lars Kurth
> On 17 Dec 2019, at 14:18, Ian Jackson wrote: > > Signed-off-by: Ian Jackson > --- > SUPPORT.md | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/SUPPORT.md b/SUPPORT.md > index f7a7a56c29..b24649ef2d 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -9,13 +9

Re: [Xen-devel] [PATCH] 4.13.0: Update SUPPORT.md

2019-12-17 Thread Jürgen Groß
On 17.12.19 15:18, Ian Jackson wrote: Signed-off-by: Ian Jackson Reviewed-by: Juergen Gross Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/2] Tidy up whitespace and formatting in file to be consistent.

2019-12-17 Thread Wei Liu
On Tue, Dec 17, 2019 at 02:13:30PM +, Wei Liu wrote: > On Fri, Dec 13, 2019 at 03:08:34PM +1100, Steven Haigh wrote: > > Signed-off-by: Steven Haigh > > Acked-by: Wei Liu > > I will need to add tools/hotplug to the subject line and the following > commit message: > >Use 4 spaces for in

[Xen-devel] [PATCH] xen/page_alloc: statically allocate bootmem_region_list

2019-12-17 Thread Hongyan Xia
The existing code assumes that the first mfn passed to the boot allocator is mapped, which creates problems when, e.g., we do not have a direct map, and may create other bootstrapping problems in the future. Make it static. The size is kept the same as before (1 page). Signed-off-by: Hongyan Xia

[Xen-devel] [XEN PATCH v1 1/1] x86/vm_event: add fast single step

2019-12-17 Thread Sergey Kovalev
On break point event eight context switches occures. With fast single step it is possible to shorten path for two context switches and gain 35% spead-up. Was tested on Debian branch of Xen 4.12. See at: https://github.com/skvl/xen/tree/debian/knorrie/4.12/fast-singlestep Rebased on master: http

Re: [Xen-devel] [XEN PATCH v1 1/1] x86/vm_event: add fast single step

2019-12-17 Thread Andrew Cooper
On 17/12/2019 14:40, Sergey Kovalev wrote: > On break point event eight context switches occures. > > With fast single step it is possible to shorten path for two context > switches > and gain 35% spead-up. > > Was tested on Debian branch of Xen 4.12. See at: > https://github.com/skvl/xen/tree/debi

[Xen-devel] [PATCH] tools: bump library version numbers

2019-12-17 Thread Wei Liu
Signed-off-by: Wei Liu --- Paul: this is based on the assumption that the next version is going to be 4.14. Let me know if you decide otherwise... --- tools/libfsimage/common/Makefile | 2 +- tools/libvchan/Makefile | 2 +- tools/libxc/Makefile | 2 +- tools/libxl/Makefile

Re: [Xen-devel] [PATCH v3 17/22] golang/xenlight: implement array C to Go marshaling

2019-12-17 Thread Nick Rosbrook
On Tue, Dec 17, 2019 at 6:16 AM George Dunlap wrote: > > On 12/10/19 3:47 PM, Nick Rosbrook wrote: > > From: Nick Rosbrook > > > > Signed-off-by: Nick Rosbrook > > --- > > tools/golang/xenlight/gengotypes.py | 39 +++- > > tools/golang/xenlight/helpers.gen.go | 300 +++

Re: [Xen-devel] [XEN PATCH v1 1/1] x86/vm_event: add fast single step

2019-12-17 Thread Sergey Kovalev
On 17.12.2019 17:48, Andrew Cooper wrote: On 17/12/2019 14:40, Sergey Kovalev wrote: On break point event eight context switches occures. With fast single step it is possible to shorten path for two context switches and gain 35% spead-up. Was tested on Debian branch of Xen 4.12. See at: https:

Re: [Xen-devel] [XEN PATCH v1 1/1] x86/vm_event: add fast single step

2019-12-17 Thread Tamas K Lengyel
On Tue, Dec 17, 2019 at 7:48 AM Andrew Cooper wrote: > > On 17/12/2019 14:40, Sergey Kovalev wrote: > > On break point event eight context switches occures. > > > > With fast single step it is possible to shorten path for two context > > switches > > and gain 35% spead-up. > > > > Was tested on De

Re: [Xen-devel] [PATCH 2/6] x86/suspend: Don't bother saving %cr3, %ss or flags

2019-12-17 Thread Roger Pau Monné
On Tue, Dec 17, 2019 at 12:26:24PM +, Andrew Cooper wrote: > On 17/12/2019 12:18, Roger Pau Monné wrote: > > On Tue, Dec 17, 2019 at 12:06:01PM +, Andrew Cooper wrote: > >> On 17/12/2019 11:52, Roger Pau Monné wrote: > >>> On Fri, Dec 13, 2019 at 07:04:32PM +, Andrew Cooper wrote: > >>>

Re: [Xen-devel] [XEN PATCH v1 1/1] x86/vm_event: add fast single step

2019-12-17 Thread Tamas K Lengyel
On Tue, Dec 17, 2019 at 8:08 AM Tamas K Lengyel wrote: > > On Tue, Dec 17, 2019 at 7:48 AM Andrew Cooper > wrote: > > > > On 17/12/2019 14:40, Sergey Kovalev wrote: > > > On break point event eight context switches occures. > > > > > > With fast single step it is possible to shorten path for two

[Xen-devel] [PATCH V4 3/4] x86/mm: Pull out the p2m specifics from p2m_init_altp2m_ept

2019-12-17 Thread Alexandru Stefan ISAILA
Signed-off-by: Alexandru Isaila --- CC: Jun Nakajima CC: Kevin Tian CC: George Dunlap CC: Jan Beulich CC: Andrew Cooper CC: Wei Liu CC: "Roger Pau Monné" --- xen/arch/x86/mm/p2m-ept.c | 6 -- xen/arch/x86/mm/p2m.c | 6 ++ 2 files changed, 6 insertions(+), 6 deletions(-) diff -

[Xen-devel] [PATCH V4 2/4] x86/altp2m: Add hypercall to set a range of sve bits

2019-12-17 Thread Alexandru Stefan ISAILA
By default the sve bits are not set. This patch adds a new hypercall, xc_altp2m_set_supress_ve_multi(), to set a range of sve bits. The core function, p2m_set_suppress_ve_multi(), does not brake in case of a error and it is doing a best effort for setting the bits in the given range. A check for co

[Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-17 Thread Alexandru Stefan ISAILA
This patch aims to sanitize indexes, potentially guest provided values, for altp2m_eptp[] and altp2m_p2m[] arrays. Signed-off-by: Alexandru Isaila --- CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Petre Pircalabu CC: George Dunlap CC: Jan Beulich CC: Andrew Cooper CC: Wei Liu CC: "Roger Pau

Re: [Xen-devel] [XEN PATCH v1 1/1] x86/vm_event: add fast single step

2019-12-17 Thread Andrew Cooper
On 17/12/2019 15:10, Tamas K Lengyel wrote: > On Tue, Dec 17, 2019 at 8:08 AM Tamas K Lengyel wrote: >> On Tue, Dec 17, 2019 at 7:48 AM Andrew Cooper >> wrote: >>> On 17/12/2019 14:40, Sergey Kovalev wrote: On break point event eight context switches occures. With fast single step

[Xen-devel] [PATCH V4 4/4] x86/mm: Make use of the default access param from xc_altp2m_create_view

2019-12-17 Thread Alexandru Stefan ISAILA
At this moment the default_access param from xc_altp2m_create_view is not used. This patch assigns default_access to p2m->default_access at the time of initializing a new altp2m view. Signed-off-by: Alexandru Isaila --- CC: Jan Beulich CC: Andrew Cooper CC: Wei Liu CC: "Roger Pau Monné" CC:

Re: [Xen-devel] [RFC PATCH 3/3] xen/netback: Fix grant copy across page boundary with KASAN

2019-12-17 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of > Sergey Dyasli > Sent: 17 December 2019 14:08 > To: xen-de...@lists.xen.org; kasan-...@googlegroups.com; linux- > ker...@vger.kernel.org > Cc: Juergen Gross ; Sergey Dyasli > ; Stefano Stabellini ; > George Dunlap ; Ross Lagerwall > ; Al

Re: [Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-17 Thread Tamas K Lengyel
On Tue, Dec 17, 2019 at 8:12 AM Alexandru Stefan ISAILA wrote: > > This patch aims to sanitize indexes, potentially guest provided > values, for altp2m_eptp[] and altp2m_p2m[] arrays. > > Signed-off-by: Alexandru Isaila LGTM, thanks! Acked-by: Tamas K Lengyel _

Re: [Xen-devel] [PATCH net-next 3/3] xen-netback: remove 'hotplug-status' once it has served its purpose

2019-12-17 Thread Wei Liu
On Tue, Dec 17, 2019 at 01:32:18PM +, Paul Durrant wrote: > Removing the 'hotplug-status' node in netback_remove() is wrong; the script > may not have completed. Only remove the node once the watch has fired and > has been unregistered. > > Signed-off-by: Paul Durrant Acked-by: Wei Liu ___

Re: [Xen-devel] [PATCH net-next 1/3] xen-netback: move netback_probe() and netback_remove() to the end...

2019-12-17 Thread Wei Liu
On Tue, Dec 17, 2019 at 01:32:16PM +, Paul Durrant wrote: > ...of xenbus.c > > This is a cosmetic function re-ordering to reduce churn in a subsequent > patch. Some style fix-up was done to make checkpatch.pl happier. > > No functional change. > > Signed-off-by: Paul Durrant Acked-by: Wei

Re: [Xen-devel] [PATCH net-next 2/3] xen-netback: switch state to InitWait at the end of netback_probe()...

2019-12-17 Thread Wei Liu
On Tue, Dec 17, 2019 at 01:32:17PM +, Paul Durrant wrote: > ...as the comment above the function states. > > The switch to Initialising at the start of the function is somewhat bogus > as the toolstack will have set that initial state anyway. To behave > correctly, a backend should switch to I

Re: [Xen-devel] [PATCH 1/2] Tidy up whitespace and formatting in file to be consistent.

2019-12-17 Thread Steven Haigh
Ok, if its going to be 4 spaces for each file, I can batch convert & tidy stuff up... The file I changed had both types, so I went with my own preference :) If it might be a better approach, I'll sort out the majority of scripts in that directory - and do no function changes and post a series

[Xen-devel] [PATCH] xsm: hide detailed Xen version from unprivileged guests

2019-12-17 Thread Sergey Dyasli
Hide the following information that can help identify the running Xen binary version: XENVER_extraversion XENVER_compile_info XENVER_capabilities XENVER_changeset XENVER_commandline XENVER_build_id Return a more customer friendly empty string instead of "" which would be s

Re: [Xen-devel] [PATCH 1/2] Tidy up whitespace and formatting in file to be consistent.

2019-12-17 Thread Wei Liu
On Wed, Dec 18, 2019 at 02:44:51AM +1100, Steven Haigh wrote: > Ok, if its going to be 4 spaces for each file, I can batch convert & tidy > stuff up... > > The file I changed had both types, so I went with my own preference :) > > If it might be a better approach, I'll sort out the majority of sc

Re: [Xen-devel] [XEN PATCH v1 1/1] x86/vm_event: add fast single step

2019-12-17 Thread Ковалёв Сергей
Andrew, Tamas thank you very much. I will improve the patch. December 17, 2019 3:13:42 PM UTC, Andrew Cooper пишет: >On 17/12/2019 15:10, Tamas K Lengyel wrote: >> On Tue, Dec 17, 2019 at 8:08 AM Tamas K Lengyel >wrote: >>> On Tue, Dec 17, 2019 at 7:48 AM Andrew Cooper > wrote: On 17/12/20

[Xen-devel] [PATCH v11 1/6] xenbus/backend: Add memory pressure handler callback

2019-12-17 Thread SeongJae Park
From: SeongJae Park Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource uti

[Xen-devel] [PATCH v11 0/6] xenbus/backend: Add a memory pressure handler callback

2019-12-17 Thread SeongJae Park
Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns. Al

[Xen-devel] [PATCH v11 3/6] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-17 Thread SeongJae Park
From: SeongJae Park Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and is increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it chec

[Xen-devel] [PATCH v11 2/6] xenbus/backend: Protect xenbus callback with lock

2019-12-17 Thread SeongJae Park
From: SeongJae Park 'reclaim_memory' callback can race with a driver code as this callback will be called from any memory pressure detected context. To deal with the case, this commit adds a spinlock in the 'xenbus_device'. Whenever 'reclaim_memory' callback is called, the lock of the device wh

[Xen-devel] [PATCH v11 4/6] xen/blkback: Protect 'reclaim_memory()' with 'reclaim_lock'

2019-12-17 Thread SeongJae Park
From: SeongJae Park The 'reclaim_memory()' callback of blkback could race with 'xen_blkbk_probe()' and 'xen_blkbk_remove()'. In the case, incompletely linked 'backend_info' and 'blkif' might be exposed to the callback, thus result in bad results including NULL dereference. This commit fixes the

[Xen-devel] [PATCH v11 5/6] xen/blkback: Remove unnecessary static variable name prefixes

2019-12-17 Thread SeongJae Park
From: SeongJae Park A few of static variables in blkback have 'xen_blkif_' prefix, though it is unnecessary for static variables. This commit removes such prefixes. Reviewed-by: Roger Pau Monné Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/blkback.c | 37 +---

[Xen-devel] [PATCH v11 6/6] xen/blkback: Consistently insert one empty line between functions

2019-12-17 Thread SeongJae Park
From: SeongJae Park The number of empty lines between functions in the xenbus.c is inconsistent. This trivial style cleanup commit fixes the file to consistently place only one empty line. Acked-by: Roger Pau Monné Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/xenbus.c | 7 ++---

Re: [Xen-devel] [PATCH v11 2/6] xenbus/backend: Protect xenbus callback with lock

2019-12-17 Thread Jürgen Groß
On 17.12.19 17:07, SeongJae Park wrote: From: SeongJae Park 'reclaim_memory' callback can race with a driver code as this callback will be called from any memory pressure detected context. To deal with the case, this commit adds a spinlock in the 'xenbus_device'. Whenever 'reclaim_memory' cal

Re: [Xen-devel] [PATCH v11 4/6] xen/blkback: Protect 'reclaim_memory()' with 'reclaim_lock'

2019-12-17 Thread Jürgen Groß
On 17.12.19 17:07, SeongJae Park wrote: From: SeongJae Park The 'reclaim_memory()' callback of blkback could race with 'xen_blkbk_probe()' and 'xen_blkbk_remove()'. In the case, incompletely linked 'backend_info' and 'blkif' might be exposed to the callback, thus result in bad results includin

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-17 Thread SeongJae Park
On Tue, 17 Dec 2019 09:30:32 +0100 SeongJae Park wrote: > On Tue, 17 Dec 2019 09:16:47 +0100 "Jürgen Groß" wrote: > > > On 17.12.19 08:59, SeongJae Park wrote: > > > On Tue, 17 Dec 2019 07:23:12 +0100 "Jürgen Groß" wrote: > > > > > >> On 16.12.19 20:48, SeongJae Park wrote: > > >>> On on, 16

Re: [Xen-devel] [PATCH 0/6] x86/suspend: State cleanup

2019-12-17 Thread Jan Beulich
On 13.12.2019 20:04, Andrew Cooper wrote: > Andrew Cooper (6): > x86/suspend: Clarify and improve the behaviour of do_suspend_lowlevel() > x86/suspend: Don't bother saving %cr3, %ss or flags > x86/suspend: Don't save unnecessary GPRs > x86/suspend: Restore cr4 later during resume > x86/su

Re: [Xen-devel] [PATCH] xen/page_alloc: statically allocate bootmem_region_list

2019-12-17 Thread Julien Grall
Hi Hongyan, On 17/12/2019 14:33, Hongyan Xia wrote: The existing code assumes that the first mfn passed to the boot allocator is mapped, which creates problems when, e.g., we do not have a direct map, and may create other bootstrapping problems in the future. Make it static. The size is kept the

Re: [Xen-devel] [PATCH v11 2/6] xenbus/backend: Protect xenbus callback with lock

2019-12-17 Thread SeongJae Park
On Tue, 17 Dec 2019 17:13:42 +0100 "Jürgen Groß" wrote: > On 17.12.19 17:07, SeongJae Park wrote: > > From: SeongJae Park > > > > 'reclaim_memory' callback can race with a driver code as this callback > > will be called from any memory pressure detected context. To deal with > > the case, this

[Xen-devel] [PATCH 1/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-17 Thread SeongJae Park
From: SeongJae Park I though it would be better to review separated patches, but seems it was my mistake. As Juergen asked, merged them again and post here. Also, dropped Roger's reviewed-by. Thanks, SeongJae Park >8 --- Subjec

Re: [Xen-devel] [PATCH] xen/arm: Basic support for sunxi/sun50i h6 platform.

2019-12-17 Thread Julien Grall
Hi, On 04/12/2019 09:27, Andre Przywara wrote: On Tue, 3 Dec 2019 16:52:45 + Julien Grall wrote: Hi, On 03/12/2019 14:38, Andre Przywara wrote: On Tue, 3 Dec 2019 11:39:58 + Julien Grall wrote: Hi, (+Andre) Hi, @Andre, IIRC you originally added the support for sunxi in Xen.

Re: [Xen-devel] [PATCH 0/6] x86/suspend: State cleanup

2019-12-17 Thread Andrew Cooper
On 17/12/2019 16:17, Jan Beulich wrote: > On 13.12.2019 20:04, Andrew Cooper wrote: >> Andrew Cooper (6): >> x86/suspend: Clarify and improve the behaviour of do_suspend_lowlevel() >> x86/suspend: Don't bother saving %cr3, %ss or flags >> x86/suspend: Don't save unnecessary GPRs >> x86/susp

Re: [Xen-devel] [PATCH] xen/page_alloc: statically allocate bootmem_region_list

2019-12-17 Thread Jan Beulich
I'm sorry for the non-threaded reply, but my mail client has mixed up this mail with another one, so I have nothing to properly reply to. With one stylistic issue taken care of (blanks around the binary operator / ) Reviewed-by: Jan Beulich The change would be easy enough to do while committing, b

Re: [Xen-devel] [PATCH 0/6] x86/suspend: State cleanup

2019-12-17 Thread Jan Beulich
On 17.12.2019 17:33, Andrew Cooper wrote: > On 17/12/2019 16:17, Jan Beulich wrote: >> On 13.12.2019 20:04, Andrew Cooper wrote: >>> Andrew Cooper (6): >>> x86/suspend: Clarify and improve the behaviour of do_suspend_lowlevel() >>> x86/suspend: Don't bother saving %cr3, %ss or flags >>> x86/s

[Xen-devel] [ovmf test] 144895: regressions - FAIL

2019-12-17 Thread osstest service owner
flight 144895 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144895/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH] xen/page_alloc: statically allocate bootmem_region_list

2019-12-17 Thread Julien Grall
Hi, On 17/12/2019 16:37, Jan Beulich wrote: I'm sorry for the non-threaded reply, but my mail client has mixed up this mail with another one, so I have nothing to properly reply to. With one stylistic issue taken care of (blanks around the binary operator / ) Reviewed-by: Jan Beulich The change

Re: [Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-17 Thread Jan Beulich
On 17.12.2019 16:12, Alexandru Stefan ISAILA wrote: > --- a/xen/arch/x86/mm/mem_access.c > +++ b/xen/arch/x86/mm/mem_access.c > @@ -367,10 +367,11 @@ long p2m_set_mem_access(struct domain *d, gfn_t gfn, > uint32_t nr, > if ( altp2m_idx ) > { > if ( altp2m_idx >= MAX_ALTP2M || >

Re: [Xen-devel] [PATCH V4 2/4] x86/altp2m: Add hypercall to set a range of sve bits

2019-12-17 Thread Jan Beulich
On 17.12.2019 16:12, Alexandru Stefan ISAILA wrote: > @@ -4711,6 +4712,20 @@ static int do_altp2m_op( > } > break; > > +case HVMOP_altp2m_set_suppress_ve_multi: > +if ( a.u.suppress_ve_multi.pad1 || > + a.u.suppress_ve_multi.first_error_code || > +

Re: [Xen-devel] [PATCH v11 2/6] xenbus/backend: Protect xenbus callback with lock

2019-12-17 Thread Jürgen Groß
On 17.12.19 17:24, SeongJae Park wrote: On Tue, 17 Dec 2019 17:13:42 +0100 "Jürgen Groß" wrote: On 17.12.19 17:07, SeongJae Park wrote: From: SeongJae Park 'reclaim_memory' callback can race with a driver code as this callback will be called from any memory pressure detected context. To de

Re: [Xen-devel] Xen ARM Dom0less passthrough without IOMMU

2019-12-17 Thread Andrei Cherechesu
> On Mon, 16 Dec 2019, Julien Grall wrote: > > On 16/12/2019 23:05, Stefano Stabellini wrote: > > > On Mon, 16 Dec 2019, Julien Grall wrote: > > > > On 16/12/2019 18:02, Andrei Cherechesu wrote: > > > > But even with this patch, RAM in DomU is not direct mapped (i.e Guest > > > > Physical > > > > A

Re: [Xen-devel] [PATCH v11 2/6] xenbus/backend: Protect xenbus callback with lock

2019-12-17 Thread SeongJae Park
On Tue, 17 Dec 2019 18:10:19 +0100 "Jürgen Groß" wrote: > On 17.12.19 17:24, SeongJae Park wrote: > > On Tue, 17 Dec 2019 17:13:42 +0100 "Jürgen Groß" wrote: > > > >> On 17.12.19 17:07, SeongJae Park wrote: > >>> From: SeongJae Park > >>> > >>> 'reclaim_memory' callback can race with a driver

Re: [Xen-devel] [PATCH v3 21/22] golang/xenlight: revise use of Context type

2019-12-17 Thread George Dunlap
On 12/10/19 3:47 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Remove the exported global context variable, 'Ctx.' Generally, it is > better to not export global variables for use through a Go package. > However, there are some exceptions that can be found in the standard > library. > > Add

Re: [Xen-devel] [PATCH v3 22/22] golang/xenlight: add error return type to Context.Cpupoolinfo

2019-12-17 Thread George Dunlap
On 12/10/19 3:47 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > A previous commit that removed Context.CheckOpen revealed > an ineffectual assignent to err in Context.Cpupoolinfo, as > there is no error return type. > > Since it appears that the intent is to return an error here, > add an er

Re: [Xen-devel] Xen ARM Dom0less passthrough without IOMMU

2019-12-17 Thread Julien Grall
Hi Andrei, On 17/12/2019 17:20, Andrei Cherechesu wrote: On Mon, 16 Dec 2019, Julien Grall wrote: On 16/12/2019 23:05, Stefano Stabellini wrote: On Mon, 16 Dec 2019, Julien Grall wrote: On 16/12/2019 18:02, Andrei Cherechesu wrote: But even with this patch, RAM in DomU is not direct mapped (i

[Xen-devel] [xen-unstable-smoke test] 144898: tolerable all pass - PUSHED

2019-12-17 Thread osstest service owner
flight 144898 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/144898/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

  1   2   >