On 17/12/2019 11:52, Roger Pau Monné wrote:
> On Fri, Dec 13, 2019 at 07:04:32PM +0000, Andrew Cooper wrote:
>> The trampoline has already set up the idle pagetables (which are the correct
>> ones to use), and sanitised the flags state.
> I wonder why do we have wakeup.S and wakeup_prot.S, it would be easier
> to follow if it all was in the same file IMO.

wakeup.S is the 16bit entry point, and lives in the trampoline below 1M.

wakeup_prot.S is a bit of logic which lives in the main hypervisor.

The naming could probably do with some improvement, but they can't
feasibly be part of the same file.

>
>> For %ss, __HYPERVISOR_DS64 is the correct descriptor to restore.
>>
>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> Reviewed-by: Roger Pau Monné <roger....@citrix.com>

Thanks,

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to