[Xen-devel] [linux-4.19 test] 141162: trouble: blocked/broken/starved

2019-09-10 Thread osstest service owner
flight 141162 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/141162/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-i386-pvops

[Xen-devel] [xen-unstable-smoke test] 141169: trouble: blocked/broken

2019-09-10 Thread osstest service owner
flight 141169 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/141169/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-amd64

Re: [Xen-devel] [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks

2019-09-10 Thread Christian Lindig
> On 9 Sep 2019, at 18:12, Ian Jackson wrote: > > > Add build machinery which will check the ABI correspondence. > > This will result in a compile time failure whenever constants get > renumbered/added without a compatible adjustment to the Ocaml ABI. I understand the desire to automate this

Re: [Xen-devel] [PATCH] x86/cpuid: Fix handling of the CPUID.7[0].eax levelling MSR

2019-09-10 Thread Roger Pau Monné
On Mon, Sep 09, 2019 at 04:51:24PM +0100, Andrew Cooper wrote: > 7a0 is an integer field, not a mask - taking the logical and of the hardware > and policy values results in nonsense. Instead, take the policy value > directly. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Wei Li

Re: [Xen-devel] [PATCH] x86/cpuid: Fix handling of the CPUID.7[0].eax levelling MSR

2019-09-10 Thread Andrew Cooper
On 10/09/2019 10:29, Roger Pau Monné wrote: > On Mon, Sep 09, 2019 at 04:51:24PM +0100, Andrew Cooper wrote: >> 7a0 is an integer field, not a mask - taking the logical and of the hardware >> and policy values results in nonsense. Instead, take the policy value >> directly. >> >> Signed-off-by: An

Re: [Xen-devel] [PATCH] xen/pci: try to reserve MCFG areas earlier

2019-09-10 Thread Igor Druzhinin
On 10/09/2019 02:47, Boris Ostrovsky wrote: > On 9/9/19 5:48 PM, Igor Druzhinin wrote: >> On 09/09/2019 20:19, Boris Ostrovsky wrote: >>> On 9/8/19 7:37 PM, Igor Druzhinin wrote: On 09/09/2019 00:30, Boris Ostrovsky wrote: > On 9/8/19 5:11 PM, Igor Druzhinin wrote: >> On 08/09/2019 19:

Re: [Xen-devel] [PATCH] xen/pci: try to reserve MCFG areas earlier

2019-09-10 Thread Jan Beulich
On 10.09.2019 11:46, Igor Druzhinin wrote: > On 10/09/2019 02:47, Boris Ostrovsky wrote: >> On 9/9/19 5:48 PM, Igor Druzhinin wrote: >>> Actually, pci_mmcfg_late_init() that's called out of acpi_init() - >>> that's where MCFG areas are properly sized. >> >> pci_mmcfg_late_init() reads the (static)

Re: [Xen-devel] [PATCH] x86/cpuid: Fix handling of the CPUID.7[0].eax levelling MSR

2019-09-10 Thread Roger Pau Monné
On Tue, Sep 10, 2019 at 10:35:26AM +0100, Andrew Cooper wrote: > On 10/09/2019 10:29, Roger Pau Monné wrote: > > On Mon, Sep 09, 2019 at 04:51:24PM +0100, Andrew Cooper wrote: > >> 7a0 is an integer field, not a mask - taking the logical and of the > >> hardware > >> and policy values results in n

Re: [Xen-devel] [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks

2019-09-10 Thread Ian Jackson
Christian Lindig writes ("Re: [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks"): > I understand the desire to automate this but would have kept the > original proposal for these reasons: changes are rare enough, it is > obvious how to extend the scheme, the approach stayed well wi

Re: [Xen-devel] [PATCH] xen/pci: try to reserve MCFG areas earlier

2019-09-10 Thread Igor Druzhinin
On 10/09/2019 10:55, Jan Beulich wrote: > On 10.09.2019 11:46, Igor Druzhinin wrote: >> On 10/09/2019 02:47, Boris Ostrovsky wrote: >>> On 9/9/19 5:48 PM, Igor Druzhinin wrote: Actually, pci_mmcfg_late_init() that's called out of acpi_init() - that's where MCFG areas are properly sized.

Re: [Xen-devel] [PATCH] x86/cpuid: Fix handling of the CPUID.7[0].eax levelling MSR

2019-09-10 Thread Jan Beulich
On 09.09.2019 17:51, Andrew Cooper wrote: > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -218,11 +218,16 @@ static int update_domain_cpuid_info(struct domain *d, > if ( is_pv_domain(d) && ((levelling_caps & LCAP_7ab0) == LCAP_7ab0) ) > { > uint64_t m

Re: [Xen-devel] [PATCH] x86/cpuid: Fix handling of the CPUID.7[0].eax levelling MSR

2019-09-10 Thread Andrew Cooper
On 10/09/2019 10:57, Roger Pau Monné wrote: > On Tue, Sep 10, 2019 at 10:35:26AM +0100, Andrew Cooper wrote: >> On 10/09/2019 10:29, Roger Pau Monné wrote: >>> On Mon, Sep 09, 2019 at 04:51:24PM +0100, Andrew Cooper wrote: 7a0 is an integer field, not a mask - taking the logical and of the >>

Re: [Xen-devel] [PATCH] x86/cpuid: Fix handling of the CPUID.7[0].eax levelling MSR

2019-09-10 Thread Andrew Cooper
On 10/09/2019 11:24, Jan Beulich wrote: > On 09.09.2019 17:51, Andrew Cooper wrote: >> --- a/xen/arch/x86/domctl.c >> +++ b/xen/arch/x86/domctl.c >> @@ -218,11 +218,16 @@ static int update_domain_cpuid_info(struct domain *d, >> if ( is_pv_domain(d) && ((levelling_caps & LCAP_7ab0) == LCAP_

Re: [Xen-devel] [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail path cleanup

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Wei Liu > > Subject: [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail path > cleanup

Re: [Xen-devel] [PATCH V3 8/8] iommu/arm: Add Renesas IPMMU-VMSA support

2019-09-10 Thread Oleksandr
On 10.09.19 00:24, Julien Grall wrote: Hi Oleksandr, Hi Julien On 8/20/19 7:09 PM, Oleksandr Tyshchenko wrote: diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig index bc0e9cd..c93a6b2 100644 --- a/xen/arch/arm/platforms/Kconfig +++ b/xen/arch/arm/platforms/Kcon

Re: [Xen-devel] [PATCH 4/5] xen/arm: optee: handle share buffer translation error

2019-09-10 Thread Julien Grall
Hi Volodymyr, On 8/23/19 7:48 PM, Volodymyr Babchuk wrote: There is a case possible, when OP-TEE asks guest to allocate shared buffer, but Xen for some reason can't translate buffer's addresses. In this situation we should do two things: 1. Tell guest to free allocated buffer, so there will be

[Xen-devel] [PATCH] freebsd-build: fix building efifat after r351831

2019-09-10 Thread Roger Pau Monne
FreeBSD revisions after r351831 no longer automatically build an efifat partition image, and makefs should be used instead if such file is required. Do this and add logic to build the efifat partition ourselves if it's not present in the output of the build. Signed-off-by: Roger Pau Monné --- Cc

[Xen-devel] [PATCH v3 00/12] ocaml abi fixes

2019-09-10 Thread Ian Jackson
This now has further updates and improvements. Patches 1-3 are as before. Patches 4-12 are new. Thanks to Andy for his work (in particular, some debugging and commentary for my script) which I have incorporated here. This is available as a git branch here https://xenbits.xen.org/gitweb/?p=peo

[Xen-devel] [PATCH v3 01/12] tools/ocaml: Add missing X86_EMU_VPCI

2019-09-10 Thread Ian Jackson
This was missing from x86_arch_emulation_flags. Signed-off-by: Ian Jackson --- tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 35958b94d5..305625cb6c

[Xen-devel] [PATCH v3 02/12] tools/ocaml: Add missing CAP_PV

2019-09-10 Thread Ian Jackson
From: Andrew Cooper c/s f089fddd941 broke the Ocaml ABI by renumering XEN_SYSCTL_PHYSCAP_directio without adjusting the Ocaml physinfo_cap_flag enumeration. Fix this by inserting CAP_PV between CAP_HVM and CAP_DirectIO. Signed-off-by: Andrew Cooper Signed-off-by: Ian Jackson --- tools/ocaml/

[Xen-devel] [PATCH v3 03/12] tools/ocaml: Introduce xenctrl ABI build-time checks

2019-09-10 Thread Ian Jackson
c/s f089fddd941 broke the Ocaml ABI by renumering XEN_SYSCTL_PHYSCAP_directio without adjusting the Ocaml physinfo_cap_flag enumeration. Add build machinery which will check the ABI correspondence. This will result in a compile time failure whenever constants get renumbered/added without a compat

[Xen-devel] [PATCH v3 04/12] xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm

2019-09-10 Thread Ian Jackson
From: Andrew Cooper Signed-off-by: Andrew Cooper --- tools/libxl/libxl_create.c| 2 +- tools/python/xen/lowlevel/xc/xc.c | 2 +- xen/arch/arm/domain.c | 2 +- xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/setup.c | 2 +- xen/arch/x86/domain.c

[Xen-devel] [PATCH v3 08/12] tools/ocaml: abi-check: Cope with multiple conversions of same type

2019-09-10 Thread Ian Jackson
Signed-off-by: Ian Jackson --- tools/ocaml/libs/xc/abi-check | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/ocaml/libs/xc/abi-check b/tools/ocaml/libs/xc/abi-check index 9450676429..abcd6ce6f1 100755 --- a/tools/ocaml/libs/xc/abi-check +++ b/tools/ocaml/libs/xc/abi-check @@ -27,6

[Xen-devel] [PATCH v3 06/12] tools/ocaml: abi handling: Provide ocaml->C conversion/check

2019-09-10 Thread Ian Jackson
From: Andrew Cooper No users of this yet so no overall change. Signed-off-by: Andrew Cooper Signed-off-by: Ian Jackson --- tools/ocaml/libs/xc/abi-check | 3 ++- tools/ocaml/libs/xc/xenctrl_stubs.c | 15 +++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/too

[Xen-devel] [PATCH v3 05/12] tools/ocaml: abi-check: Add comments

2019-09-10 Thread Ian Jackson
Provide interface documentation for this script. Explain why we check .ml not .mli. Signed-off-by: Andrew Cooper Signed-off-by: Ian Jackson --- tools/ocaml/libs/xc/abi-check | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tools/ocaml/libs/xc/abi-check b/tools/ocaml/libs/xc

[Xen-devel] [PATCH v3 07/12] tools/ocaml: abi-check: Improve output and error messages

2019-09-10 Thread Ian Jackson
In the generated C, add some comments saying where we found the ocaml type. This helps with debugging. (I considered emitting #line directives but decided this would be more confusing than helpful.) Improve two dies. Use better-named filehandles (perl prints thier names when it dies). Signed-o

[Xen-devel] [PATCH v3 09/12] tools/ocaml: Reformat domain_create_flag

2019-09-10 Thread Ian Jackson
From: Andrew Cooper This will allow us to apply the abi checker soon. No functional change. Signed-off-by: Andrew Cooper Signed-off-by: Ian Jackson --- tools/ocaml/libs/xc/xenctrl.ml | 4 +++- tools/ocaml/libs/xc/xenctrl.mli | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff -

[Xen-devel] [PATCH v3 10/12] tools/ocaml: abi-check: Check properly.

2019-09-10 Thread Ian Jackson
Fix a broken regexp which would mention `$/' when it ought to have mentioned `$'. The result would be that it would match lines like type some_ocaml_type = Thing | Other_Thing but ignore everything but the type name, giving wrong answers. Check that we check mentioned types. Otherwise if we

[Xen-devel] [PATCH v3 11/12] tools/ocaml: tools/ocaml: Add missing CDF_* values

2019-09-10 Thread Ian Jackson
Signed-off-by: Ian Jackson --- tools/ocaml/libs/xc/xenctrl.ml | 3 +++ tools/ocaml/libs/xc/xenctrl.mli | 3 +++ 2 files changed, 6 insertions(+) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 17174debb8..e544ef84da 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml

[Xen-devel] [PATCH v3 12/12] tools/ocaml: abi: Use formal conversion and check in more places

2019-09-10 Thread Ian Jackson
From: Andrew Cooper Signed-off-by: Andrew Cooper Signed-off-by: Ian Jackson --- tools/ocaml/libs/xc/xenctrl_stubs.c | 15 +-- xen/include/public/domctl.h | 4 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/

[Xen-devel] [qemu-mainline test] 141165: trouble: blocked/broken

2019-09-10 Thread osstest service owner
flight 141165 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/141165/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm broken build-arm64

Re: [Xen-devel] [PATCH v3 03/12] tools/ocaml: Introduce xenctrl ABI build-time checks

2019-09-10 Thread Jan Beulich
On 10.09.2019 14:01, Ian Jackson wrote: > c/s f089fddd941 broke the Ocaml ABI by renumering > XEN_SYSCTL_PHYSCAP_directio without adjusting the Ocaml > physinfo_cap_flag enumeration. > > Add build machinery which will check the ABI correspondence. > > This will result in a compile time failure wh

Re: [Xen-devel] [PATCH v3 12/12] tools/ocaml: abi: Use formal conversion and check in more places

2019-09-10 Thread Jan Beulich
On 10.09.2019 14:02, Ian Jackson wrote: > From: Andrew Cooper > > Signed-off-by: Andrew Cooper > Signed-off-by: Ian Jackson Same as for the sysctl one - if you want it, here you are: Acked-by: Jan Beulich Jan ___ Xen-devel mailing list Xen-devel@l

Re: [Xen-devel] [PATCH v3 03/12] tools/ocaml: Introduce xenctrl ABI build-time checks

2019-09-10 Thread Andrew Cooper
On 10/09/2019 13:17, Jan Beulich wrote: > On 10.09.2019 14:01, Ian Jackson wrote: >> c/s f089fddd941 broke the Ocaml ABI by renumering >> XEN_SYSCTL_PHYSCAP_directio without adjusting the Ocaml >> physinfo_cap_flag enumeration. >> >> Add build machinery which will check the ABI correspondence. >> >

Re: [Xen-devel] [PATCH v3 04/12] xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm

2019-09-10 Thread Andrew Cooper
On 10/09/2019 13:01, Ian Jackson wrote: > From: Andrew Cooper > > Signed-off-by: Andrew Cooper I should probably have finished writing my commit message before handing the branch off. "The suffix is redundant, and dropping it helps to simplify the Ocaml/C ABI checking." or something suitable.

Re: [Xen-devel] [PATCH v3 06/12] tools/ocaml: abi handling: Provide ocaml->C conversion/check

2019-09-10 Thread Andrew Cooper
On 10/09/2019 13:02, Ian Jackson wrote: > From: Andrew Cooper > > No users of this yet so no overall change. > > Signed-off-by: Andrew Cooper > Signed-off-by: Ian Jackson I'm afraid this doesn't bisect.  It needs to be in the same patch as one of its callers. ~Andrew _

Re: [Xen-devel] [PATCH v2 03/11] ioreq: switch selection and forwarding to use ioservid_t

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Jan Beulich ; > Andrew Cooper > ; Wei Liu ; George Dunlap > ; Ian > Jackson ; Julien Grall ; Konrad > Rzeszutek Wilk > ; Stefano Stabellini ; Tim >

Re: [Xen-devel] [PATCH v2 04/11] ioreq: add fields to allow internal ioreq servers

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of Roger > Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Andrew Cooper ; Wei Liu ; Jan > Beulich ; > Roger Pau Monne > Subject: [Xen-devel] [PATCH v2 04/11] ioreq: add fields to allow internal > ior

Re: [Xen-devel] [PATCH v3 04/12] xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm

2019-09-10 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v3 04/12] xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm"): > I should probably have finished writing my commit message before handing > the branch off. No problem. If you had left an XXX in it I would have known to ask you for the rest... > "The suffix

Re: [Xen-devel] [PATCH v3 06/12] tools/ocaml: abi handling: Provide ocaml->C conversion/check

2019-09-10 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v3 06/12] tools/ocaml: abi handling: Provide ocaml->C conversion/check"): > On 10/09/2019 13:02, Ian Jackson wrote: > > From: Andrew Cooper > > > > No users of this yet so no overall change. > > > > Signed-off-by: Andrew Cooper > > Signed-off-by: Ian Jackson >

Re: [Xen-devel] [PATCH 0/3] Remove __online_page_set_limits()

2019-09-10 Thread Souptick Joarder
On Mon, Sep 9, 2019 at 9:12 PM Kirill A. Shutemov wrote: > > On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote: > > __online_page_set_limits() is a dummy function and an extra call > > to this can be avoided. > > > > As both of the callers are now removed, __online_page_set_limits()

Re: [Xen-devel] [PATCH 0/3] Remove __online_page_set_limits()

2019-09-10 Thread David Hildenbrand
On 10.09.19 14:56, Souptick Joarder wrote: > On Mon, Sep 9, 2019 at 9:12 PM Kirill A. Shutemov > wrote: >> >> On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote: >>> __online_page_set_limits() is a dummy function and an extra call >>> to this can be avoided. >>> >>> As both of the c

Re: [Xen-devel] [PATCH v2 05/11] ioreq: add internal ioreq initialization support

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Jan Beulich ; > Andrew Cooper > ; Wei Liu ; Paul Durrant > > Subject: [PATCH v2 05/11] ioreq: add internal ioreq initialization support > > Add supp

Re: [Xen-devel] [PATCH v2 06/11] ioreq: allow dispatching ioreqs to internal servers

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Wei Liu > > Subject: [PATCH v2 06/11] ioreq: allow dispatching ioreqs to internal servers > > Inter

Re: [Xen-devel] [PATCH 2/3] x86/apic: include the LDR when clearing out APIC registers

2019-09-10 Thread Jan Beulich
On 06.09.2019 16:01, Jan Beulich wrote: > Although APIC initialization will typically clear out the LDR before > setting it, the APIC cleanup code should reset the LDR. > > This was discovered with a 32-bit KVM guest jumping into a kdump > kernel. The stale bits in the LDR triggered a bug in the K

Re: [Xen-devel] [PATCH v2 07/11] ioreq: allow registering internal ioreq server handler

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Wei Liu > > Subject: [PATCH v2 07/11] ioreq: allow registering internal ioreq server > handler >

Re: [Xen-devel] [PATCH v3 00/12] ocaml abi fixes

2019-09-10 Thread Ian Jackson
Ian Jackson writes ("[PATCH v3 00/12] ocaml abi fixes"): > This now has further updates and improvements. Patches 1-3 are as > before. Patches 4-12 are new. Thanks to Andy for his work (in > particular, some debugging and commentary for my script) which I have > incorporated here. I have fixed

Re: [Xen-devel] [PATCH v3 00/12] ocaml abi fixes

2019-09-10 Thread Christian Lindig
On 10/09/2019 14:24, Ian Jackson wrote: Christian, are you happy with my other changes in tools/ocaml ? I don't feel I need a formal ocaml ack for the changes to add the missing entries to the enum types (since those are supposed to follow the hypervisor ABI) but I think I need your ack for the

[Xen-devel] [ovmf test] 141168: trouble: blocked/broken

2019-09-10 Thread osstest service owner
flight 141168 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/141168/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvopsbroken build-amd64-xsm

Re: [Xen-devel] [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail path cleanup

2019-09-10 Thread Jan Beulich
On 03.09.2019 18:14, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/ioreq.c > +++ b/xen/arch/x86/hvm/ioreq.c > @@ -1195,7 +1195,7 @@ int hvm_all_ioreq_servers_add_vcpu(struct domain *d, > struct vcpu *v) > return 0; > > fail: > -while ( id-- != 0 ) > +while ( id++ != MAX_NR_IOREQ

Re: [Xen-devel] [PATCH v3 04/12] xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm

2019-09-10 Thread Jan Beulich
On 10.09.2019 14:01, Ian Jackson wrote: > From: Andrew Cooper > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail path cleanup

2019-09-10 Thread Roger Pau Monné
On Tue, Sep 10, 2019 at 03:28:57PM +0200, Jan Beulich wrote: > On 03.09.2019 18:14, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/ioreq.c > > +++ b/xen/arch/x86/hvm/ioreq.c > > @@ -1195,7 +1195,7 @@ int hvm_all_ioreq_servers_add_vcpu(struct domain *d, > > struct vcpu *v) > > return 0; > >

[Xen-devel] [linux-4.4 test] 141147: trouble: blocked/broken

2019-09-10 Thread osstest service owner
flight 141147 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/141147/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64-xsm

Re: [Xen-devel] [PATCH V3 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-10 Thread Oleksandr
Hi, Julien   diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c index 72a30e0..47e4bc6 100644 --- a/xen/drivers/passthrough/arm/iommu.c +++ b/xen/drivers/passthrough/arm/iommu.c @@ -20,6 +20,7 @@   #include     #include +#include     /*    * Deferred p

Re: [Xen-devel] [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail path cleanup

2019-09-10 Thread Jan Beulich
On 10.09.2019 15:33, Roger Pau Monné wrote: > On Tue, Sep 10, 2019 at 03:28:57PM +0200, Jan Beulich wrote: >> On 03.09.2019 18:14, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/ioreq.c >>> +++ b/xen/arch/x86/hvm/ioreq.c >>> @@ -1195,7 +1195,7 @@ int hvm_all_ioreq_servers_add_vcpu(struct domain

Re: [Xen-devel] [PATCH v2 08/11] ioreq: allow decoding accesses to MMCFG regions

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Jan Beulich ; > Andrew Cooper > ; Wei Liu ; Paul Durrant > > Subject: [PATCH v2 08/11] ioreq: allow decoding accesses to MMCFG regions > > Pick up o

Re: [Xen-devel] [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail path cleanup

2019-09-10 Thread Roger Pau Monné
On Tue, Sep 10, 2019 at 03:35:06PM +0200, Jan Beulich wrote: > On 10.09.2019 15:33, Roger Pau Monné wrote: > > On Tue, Sep 10, 2019 at 03:28:57PM +0200, Jan Beulich wrote: > >> On 03.09.2019 18:14, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/hvm/ioreq.c > >>> +++ b/xen/arch/x86/hvm/ioreq.c > >

Re: [Xen-devel] [PATCH v3 04/12] xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm

2019-09-10 Thread Julien Grall
Hi, On 9/10/19 1:20 PM, Andrew Cooper wrote: On 10/09/2019 13:01, Ian Jackson wrote: From: Andrew Cooper Signed-off-by: Andrew Cooper I should probably have finished writing my commit message before handing the branch off. "The suffix is redundant, and dropping it helps to simplify the Oc

Re: [Xen-devel] [PATCH v3 00/12] ocaml abi fixes

2019-09-10 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH v3 00/12] ocaml abi fixes"): > The result is here: > https://xenbits.xen.org/gitweb/?p=people/iwj/xen.git;a=summary > -b wip.ocaml.v3.1 > I can repost it if anyone thinks that would be useful. Thanks for the acks, all. Now pushed. Ian. ___

[Xen-devel] [xen-unstable-smoke test] 141176: trouble: blocked/broken

2019-09-10 Thread osstest service owner
flight 141176 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/141176/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64

Re: [Xen-devel] [PATCH v2 09/11] vpci: register as an internal ioreq server

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Ian Jackson > ; Wei Liu > ; Andrew Cooper ; George Dunlap > ; Jan > Beulich ; Julien Grall ; Konrad > Rzeszutek Wilk > ; Stefano Stabellini ; Tim >

Re: [Xen-devel] [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail path cleanup

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 10 September 2019 14:42 > To: Jan Beulich > Cc: Andrew Cooper ; Paul Durrant > ; xen- > de...@lists.xenproject.org; Wei Liu > Subject: Re: [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail > path cleanup > > On Tue, Se

Re: [Xen-devel] [PATCH v2 26/48] xen/sched: rework and rename vcpu_force_reschedule()

2019-09-10 Thread Jan Beulich
On 09.08.2019 16:58, Juergen Gross wrote: > vcpu_force_reschedule() is only used for modifying the periodic timer > of a vcpu. I don't think this is true prior to this patch, or else ... > @@ -419,8 +419,6 @@ int pv_shim_shutdown(uint8_t reason) > > if ( v != current ) > v

Re: [Xen-devel] [PATCH v2 10/11] ioreq: split the code to detect PCI config space accesses

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Wei Liu > > Subject: [PATCH v2 10/11] ioreq: split the code to detect PCI config space > accesses >

[Xen-devel] [PATCH] tools/ocaml: Fix build error with CentOS 7

2019-09-10 Thread Andrew Cooper
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) complains: xenctrl_stubs.c: In function 'stub_xc_domain_create': xenctrl_stubs.c:216:28: error: 'val' may be used uninitialized in this function [-Werror=maybe-uninitialized] cfg.arch.emulation_flags = ocaml_list_to_c_b

Re: [Xen-devel] [PATCH v2 11/11] ioreq: provide support for long-running operations...

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 03 September 2019 17:14 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Wei Liu > ; George Dunlap > ; Ian Jackson ; Julien > Grall ; > Konrad Rzeszutek Wilk ; Stefano Stabe

Re: [Xen-devel] [PATCH v2 11/11] ioreq: provide support for long-running operations...

2019-09-10 Thread Roger Pau Monné
On Tue, Sep 10, 2019 at 04:14:18PM +0200, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne > > Sent: 03 September 2019 17:14 > > To: xen-devel@lists.xenproject.org > > Cc: Roger Pau Monne ; Paul Durrant > > ; Jan Beulich > > ; Andrew Cooper ; Wei Liu > > ; George Dunl

Re: [Xen-devel] [PATCH V3 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-10 Thread Julien Grall
On 9/10/19 2:34 PM, Oleksandr wrote: Hi, Julien Hi,   diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c index 72a30e0..47e4bc6 100644 --- a/xen/drivers/passthrough/arm/iommu.c +++ b/xen/drivers/passthrough/arm/iommu.c @@ -20,6 +20,7 @@   #include    

Re: [Xen-devel] [PATCH V3 8/8] iommu/arm: Add Renesas IPMMU-VMSA support

2019-09-10 Thread Julien Grall
Hi, On 9/10/19 12:04 PM, Oleksandr wrote: On 10.09.19 00:24, Julien Grall wrote:   ---help---   Enable all the required drivers for Renesas RCar3   diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig index a3c0649..47eadb4 100644 --- a/xen/drivers/passthroug

Re: [Xen-devel] [PATCH v2 11/11] ioreq: provide support for long-running operations...

2019-09-10 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 10 September 2019 15:28 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Jan Beulich ; Andrew > Cooper > ; Wei Liu ; George Dunlap > ; Ian > Jackson ; Julien Grall ; Konrad > Rzeszutek Wilk > ; Stefano Stabellini ; Tim > (Xe

Re: [Xen-devel] [PATCH] fixup sysctl/libxl: choose a sane default for HAP

2019-09-10 Thread Jan Beulich
On 09.09.2019 15:47, Andrew Cooper wrote: > --- a/tools/ocaml/libs/xc/xenctrl_stubs.c > +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c > @@ -690,7 +690,8 @@ CAMLprim value stub_xc_physinfo(value xch) > BUILD_BUG_ON(XEN_SYSCTL_PHYSCAP_hvm != (1u << 0)); > BUILD_BUG_ON(XEN_SYSCTL_PHYSCAP

Re: [Xen-devel] [PATCH] fixup sysctl/libxl: choose a sane default for HAP

2019-09-10 Thread Andrew Cooper
On 10/09/2019 15:43, Jan Beulich wrote: > On 09.09.2019 15:47, Andrew Cooper wrote: >> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c >> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c >> @@ -690,7 +690,8 @@ CAMLprim value stub_xc_physinfo(value xch) >> BUILD_BUG_ON(XEN_SYSCTL_PHYSCAP_hvm != (1u <<

Re: [Xen-devel] [PATCH] [RFC V2] xen/arm: Restrict "p2m_ipa_bits" according to the IOMMU requirements

2019-09-10 Thread Julien Grall
Hi Oleksandr, On 8/23/19 8:34 PM, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko There is a strict requirement for the IOMMU which wants to share the P2M table with the CPU. The IOMMU's Stage-2 input size must be equal to the P2M IPA size. It is not a problem when the IOMMU can support

Re: [Xen-devel] [PATCH v2 27/48] xen/sched: Change vcpu_migrate_*() to operate on schedule unit

2019-09-10 Thread Jan Beulich
On 09.08.2019 16:58, Juergen Gross wrote: > --- a/xen/common/schedule.c > +++ b/xen/common/schedule.c > @@ -733,35 +733,40 @@ void vcpu_unblock(struct vcpu *v) > } > > /* > - * Do the actual movement of a vcpu from old to new CPU. Locks for *both* > + * Do the actual movement of an unit from ol

Re: [Xen-devel] [PATCH v4 1/3] Remove hardcoding from scripts/add_maintainers.pl

2019-09-10 Thread Julien Grall
Hi Lars, On 9/4/19 12:30 PM, Lars Kurth wrote: Instead of using a hardcoded location, inherit the location from $0 Signed-off-by: Lars Kurth Acked-by: Julien Grall Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.or

Re: [Xen-devel] [PATCH v2 28/48] xen/sched: move struct task_slice into struct sched_unit

2019-09-10 Thread Jan Beulich
On 09.08.2019 16:58, Juergen Gross wrote: > In order to prepare for multiple vcpus per schedule unit move struct > task_slice in schedule() from the local stack into struct sched_unit > of the currently running unit. The change looks mechanical enough to be probably fine, but what's the connection

[Xen-devel] [PATCH] tools/ocaml: abi check: #include on x86 only

2019-09-10 Thread Ian Jackson
Reported-by: Andrew Cooper Signed-off-by: Ian Jackson --- tools/ocaml/libs/xc/xenctrl_stubs.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index f86ecc7b7e..3eff6dd8c2 100644 --- a/tools/ocaml/libs/x

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

2019-09-10 Thread Julien Grall
Hi Lars, On 9/4/19 12:30 PM, Lars Kurth wrote: This change provides sufficient information to allow get_maintainer.pl / add_maintainers.pl scripts to be run on xen sister repositories such as mini-os.git, osstest.git, etc A suggested template for sister repositories of Xen is =

Re: [Xen-devel] [PATCH] tools/ocaml: abi check: #include on x86 only

2019-09-10 Thread Andrew Cooper
On 10/09/2019 16:17, Ian Jackson wrote: Subject += Spotted by Gitlab CI. > Reported-by: Andrew Cooper > Signed-off-by: Ian Jackson Acked-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailm

[Xen-devel] [PATCH v4 1/2] sysctl/libxl: choose a sane default for HAP

2019-09-10 Thread Roger Pau Monne
Current libxl code will always enable Hardware Assisted Paging (HAP), expecting that the hypervisor will fallback to shadow if HAP is not available. With the changes to DOMCTL_createdomain that's not the case any longer, and the hypervisor will raise an error if HAP is not available instead of sile

[Xen-devel] [PATCH v4 2/2] sysctl: report shadow paging capability

2019-09-10 Thread Roger Pau Monne
Report whether shadow paging is supported by the hypervisor, since it can be disabled at build time. Requested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- NB: I'm not sure the added check in libxl__domain_create_info_setdefault is that useful, or if it could be better placed somewhere e

Re: [Xen-devel] [PATCH v4 1/2] sysctl/libxl: choose a sane default for HAP

2019-09-10 Thread Christian Lindig
> On 10 Sep 2019, at 16:25, Roger Pau Monne wrote: > > diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml > index e544ef84da..a5e77c943a 100644 > --- a/tools/ocaml/libs/xc/xenctrl.ml > +++ b/tools/ocaml/libs/xc/xenctrl.ml > @@ -107,6 +107,7 @@ type physinfo_cap_flag =

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

2019-09-10 Thread Julien Grall
Hi, Actually, I have one question about the template (my ack still stands). On 9/10/19 4:18 PM, Julien Grall wrote: Hi Lars, On 9/4/19 12:30 PM, Lars Kurth wrote: This change provides sufficient information to allow get_maintainer.pl / add_maintainers.pl scripts to be run on xen sister reposi

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

2019-09-10 Thread Lars Kurth
On 10/09/2019, 16:31, "Julien Grall" wrote: Hi, Actually, I have one question about the template (my ack still stands). On 9/10/19 4:18 PM, Julien Grall wrote: > Hi Lars, > > On 9/4/19 12:30 PM, Lars Kurth wrote: >> This change provides sufficient informati

Re: [Xen-devel] [PATCH v2 29/48] xen/sched: add code to sync scheduling of all vcpus of a sched unit

2019-09-10 Thread Jan Beulich
On 09.08.2019 16:58, Juergen Gross wrote: > +static bool sched_tasklet_check(unsigned int cpu) > +{ > +bool tasklet_work_scheduled = false; > +const cpumask_t *mask = get_sched_res(cpu)->cpus; > +int cpu_iter; unsigned int ? > +static void context_saved(struct vcpu *prev) > +{ > +

Re: [Xen-devel] [PATCH v4 2/2] sysctl: report shadow paging capability

2019-09-10 Thread Jan Beulich
On 10.09.2019 17:25, Roger Pau Monne wrote: > Report whether shadow paging is supported by the hypervisor, since it > can be disabled at build time. > > Requested-by: Andrew Cooper > Signed-off-by: Roger Pau Monné The straightforward hypervisor part Acked-by: Jan Beulich Jan

Re: [Xen-devel] [PATCH v4 1/2] sysctl/libxl: choose a sane default for HAP

2019-09-10 Thread Andrew Cooper
On 10/09/2019 16:25, Roger Pau Monne wrote: > diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml > index e544ef84da..a5e77c943a 100644 > --- a/tools/ocaml/libs/xc/xenctrl.ml > +++ b/tools/ocaml/libs/xc/xenctrl.ml > @@ -107,6 +107,7 @@ type physinfo_cap_flag = > | CAP

Re: [Xen-devel] [PATCH v4 1/2] sysctl/libxl: choose a sane default for HAP

2019-09-10 Thread Roger Pau Monné
On Tue, Sep 10, 2019 at 04:40:39PM +0100, Andrew Cooper wrote: > On 10/09/2019 16:25, Roger Pau Monne wrote: > > diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml > > index e544ef84da..a5e77c943a 100644 > > --- a/tools/ocaml/libs/xc/xenctrl.ml > > +++ b/tools/ocaml/libs/x

Re: [Xen-devel] [PATCH v2 40/48] xen/sched: reject switching smt on/off with core scheduling active

2019-09-10 Thread Jan Beulich
On 09.08.2019 16:58, Juergen Gross wrote: > When core or socket scheduling are active enabling or disabling smt is > not possible as that would require a major host reconfiguration. > > Add a bool sched_disable_smt_switching which will be set for core or > socket scheduling. > > Signed-off-by: Ju

Re: [Xen-devel] [PATCH v4 2/3] Add V section entry to allow identification of Xen MAINTAINERS file

2019-09-10 Thread Julien Grall
Hi Lars, On 9/10/19 4:35 PM, Lars Kurth wrote: On 10/09/2019, 16:31, "Julien Grall" wrote: Hi, Actually, I have one question about the template (my ack still stands). On 9/10/19 4:18 PM, Julien Grall wrote: > Hi Lars, > > On 9/4/19 12:30 PM, Lars Kur

Re: [Xen-devel] [PATCH] [RFC V2] xen/arm: Restrict "p2m_ipa_bits" according to the IOMMU requirements

2019-09-10 Thread Oleksandr
On 10.09.19 18:11, Julien Grall wrote: Hi Oleksandr, Hi, Julien On 8/23/19 8:34 PM, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko There is a strict requirement for the IOMMU which wants to share the P2M table with the CPU. The IOMMU's Stage-2 input size must be equal to the P2M

[Xen-devel] [linux-4.14 test] 141155: trouble: blocked/broken

2019-09-10 Thread osstest service owner
flight 141155 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/141155/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm broken build-arm64

[Xen-devel] [xen-unstable-smoke test] 141182: regressions - FAIL

2019-09-10 Thread osstest service owner
flight 141182 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/141182/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 141097 build-armhf

[Xen-devel] [ovmf test] 141180: regressions - FAIL

2019-09-10 Thread osstest service owner
flight 141180 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/141180/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 141091 Tests which did not succee

Re: [Xen-devel] [PATCH] xen/pci: try to reserve MCFG areas earlier

2019-09-10 Thread Boris Ostrovsky
On 9/10/19 5:46 AM, Igor Druzhinin wrote: > On 10/09/2019 02:47, Boris Ostrovsky wrote: >> On 9/9/19 5:48 PM, Igor Druzhinin wrote: >>> On 09/09/2019 20:19, Boris Ostrovsky wrote: On 9/8/19 7:37 PM, Igor Druzhinin wrote: > On 09/09/2019 00:30, Boris Ostrovsky wrote: >> On 9/8/19 5:11 P

[Xen-devel] [xen-unstable test] 141172: trouble: blocked/broken

2019-09-10 Thread osstest service owner
flight 141172 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/141172/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-prev broken build-amd64-pvops

[Xen-devel] [linux-4.9 test] 141171: trouble: blocked/broken

2019-09-10 Thread osstest service owner
flight 141171 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/141171/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm broken build-i386-pvops

[Xen-devel] [linux-linus test] 141173: trouble: blocked/broken/starved

2019-09-10 Thread osstest service owner
flight 141173 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/141173/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-arm64-xsm

Re: [Xen-devel] [PATCH] [RFC V2] xen/arm: Restrict "p2m_ipa_bits" according to the IOMMU requirements

2019-09-10 Thread Julien Grall
Hi, On 9/10/19 5:24 PM, Oleksandr wrote: On 10.09.19 18:11, Julien Grall wrote: Hi Oleksandr, Hi, Julien On 8/23/19 8:34 PM, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko There is a strict requirement for the IOMMU which wants to share the P2M table with the CPU. The IOMMU's

[Xen-devel] [linux-4.19 test] 141175: trouble: blocked/broken

2019-09-10 Thread osstest service owner
flight 141175 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/141175/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvopsbroken build-armhf-pvops

  1   2   >