Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-27 Thread Julien Grall
Hi, On 11/27/18 7:34 AM, Juergen Gross wrote: On 26/11/2018 17:51, Julien Grall wrote: On 26/11/2018 16:17, Juergen Gross wrote: On 26/11/2018 17:01, Julien Grall wrote: On 26/11/2018 15:29, Juergen Gross wrote: On 26/11/2018 15:58, Jan Beulich wrote: On 26.11.18 at 15:23, wrote: On 2

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 08:37, wrote: > On 26/11/2018 17:50, Jan Beulich wrote: > On 26.11.18 at 17:17, wrote: >>> I really fail to see why it is so bad to not clobber data in a case >>> which normally should never occur. >> >> See Andrew's original reply. You're also clobbering on potential >> s

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-27 Thread Juergen Gross
On 27/11/2018 10:16, Julien Grall wrote: > Hi, > > On 11/27/18 7:34 AM, Juergen Gross wrote: >> On 26/11/2018 17:51, Julien Grall wrote: >>> >>> >>> On 26/11/2018 16:17, Juergen Gross wrote: On 26/11/2018 17:01, Julien Grall wrote: > > > On 26/11/2018 15:29, Juergen Gross wrote: >

Re: [Xen-devel] [PATCH v1] Increase framebuffer size to todays standards

2018-11-27 Thread Julien Grall
Hi Jan, On 11/26/18 4:15 PM, Jan Beulich wrote: On 26.11.18 at 17:03, wrote: Am Mon, 26 Nov 2018 03:31:27 -0700 schrieb "Jan Beulich" : And I think a change like this should (a) address the more general case rather than just your laptop (or laptops in general) and (b) actually add some headr

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-27 Thread Juergen Gross
On 27/11/2018 10:24, Jan Beulich wrote: On 27.11.18 at 08:37, wrote: >> On 26/11/2018 17:50, Jan Beulich wrote: >> On 26.11.18 at 17:17, wrote: I really fail to see why it is so bad to not clobber data in a case which normally should never occur. >>> >>> See Andrew's original r

Re: [Xen-devel] [PATCH 1/4] xen/arch: Switch local_*_is_enabled() predicates to return bool

2018-11-27 Thread Julien Grall
Hi Andrew, On 11/23/18 4:52 PM, Andrew Cooper wrote: No functional change, as the value returned was previously always 0 or 1. While altering these, insert blank lines where appropriate and drop the now-redundant !! from x86's local_irq_is_enabled(). Signed-off-by: Andrew Cooper Reviewed-by:

[Xen-devel] [PATCH for-3.2 v4 15/28] hw: apply accel compat properties without touching globals

2018-11-27 Thread Marc-André Lureau
Introduce object_apply_global_props() function, to apply compatibility properties from a GPtrArray. For accel compatibility properties, apply them during device_post_init(), after accel_register_compat_props() has set them. To populate the compatibility properties, introduce SET_COMPAT(), a more

Re: [Xen-devel] [PATCH 2/4] xen/arch: Switch local_save_flags() to being a static inline helper

2018-11-27 Thread Julien Grall
On 11/23/18 4:52 PM, Andrew Cooper wrote: ... rather than a macro which writes to its parameter by name. A consequence of this change is that the local variables in local_*_is_enabled() can be dropped. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC:

Re: [Xen-devel] [PATCH v1] Increase framebuffer size to todays standards

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 10:26, wrote: > Hi Jan, > > On 11/26/18 4:15 PM, Jan Beulich wrote: > On 26.11.18 at 17:03, wrote: >>> Am Mon, 26 Nov 2018 03:31:27 -0700 >>> schrieb "Jan Beulich" : >>> And I think a change like this should (a) address the more general case rather than just your

[Xen-devel] [PATCH v1 0/2] Fix Broadwell microcode update after idle-scrub was added

2018-11-27 Thread Sergey Dyasli
This issue was discovered during internal testing. Sergey Dyasli (2): system_state: introduce SYS_STATE_smp_booted common/page_alloc: don't idle-scrub before microcode update xen/arch/arm/setup.c | 6 ++ xen/arch/x86/setup.c | 4 xen/common/page_alloc.c | 7 +++ xen/inc

[Xen-devel] [PATCH v1 1/2] system_state: introduce SYS_STATE_smp_booted

2018-11-27 Thread Sergey Dyasli
The new state means that all secondary CPUs are up. On x86 this also means that a microcode was (potentially) updated on all CPUs. On ARM side of things, additionally set system_state to SYS_STATE_smp_boot just before bringing up secondary CPUs. Signed-off-by: Sergey Dyasli --- xen/arch/arm/set

[Xen-devel] [PATCH v1 2/2] common/page_alloc: don't idle-scrub before microcode update

2018-11-27 Thread Sergey Dyasli
Some x86 CPUs has errata regarding microcode updates. The most notorious is Broadwell's BDX90: "Loading Microcode ... May Result in a System Hang". (URL: https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/xeon-e7-v4-spec-update.pdf) CPUs are supposed to be idle dur

Re: [Xen-devel] Invalid OEM Table ID: Length cannot exceed 8 characters

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 00:07, wrote: > I wanted to install Xen from source on Fedora 28. > > I choose the stable-4.11 branch, compiled it, and got an error at > sudo make install > > make[7]: Entering directory > '/home/vagrant/xen/tools/firmware/seabios-dir-remote' > Compiling IASL src/fw/ssdt-m

[Xen-devel] [PATCH v2] xl: free bitmaps on exit

2018-11-27 Thread Olaf Hering
Every invocation of xl via valgrind will show three leaks. Since libxl_bitmap_alloc uses NOGC, the caller has to free the memory after use. And since xl_ctx_free might be called before parse_global_config, also move the libxl_bitmap_init calls into xl_ctx_alloc. Signed-off-by: Olaf Hering --- to

Re: [Xen-devel] [PATCH v1 2/2] common/page_alloc: don't idle-scrub before microcode update

2018-11-27 Thread Julien Grall
Hi, On 11/27/18 10:00 AM, Sergey Dyasli wrote: Some x86 CPUs has errata regarding microcode updates. The most notorious is Broadwell's BDX90: "Loading Microcode ... May Result in a System Hang". (URL: https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/xeon-e7-v4-

Re: [Xen-devel] [PATCH v2] mm: make opt_bootscrub non-init

2018-11-27 Thread Jan Beulich
>>> On 26.11.18 at 18:55, wrote: > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -166,7 +166,14 @@ enum bootscrub_mode { > BOOTSCRUB_ON, > BOOTSCRUB_IDLE, > }; > -static enum bootscrub_mode __initdata opt_bootscrub = BOOTSCRUB_IDLE; > +/* > + * opt_bootscrub should

Re: [Xen-devel] [PATCH v1 2/2] common/page_alloc: don't idle-scrub before microcode update

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 11:10, wrote: > Hi, > > On 11/27/18 10:00 AM, Sergey Dyasli wrote: >> Some x86 CPUs has errata regarding microcode updates. The most notorious >> is Broadwell's BDX90: "Loading Microcode ... May Result in a System Hang". >> (URL: > https://www.intel.com/content/dam/www/public/

Re: [Xen-devel] [PATCH v1 1/2] system_state: introduce SYS_STATE_smp_booted

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 11:00, wrote: > The new state means that all secondary CPUs are up. On x86 this also > means that a microcode was (potentially) updated on all CPUs. I'm slightly concerned by such an x86 specific: Could we settle on a more generic description of the state all CPUs are in at tha

Re: [Xen-devel] [PATCH v1 2/2] common/page_alloc: don't idle-scrub before microcode update

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 11:00, wrote: > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -933,6 +933,8 @@ void __init start_xen(unsigned long boot_phys_offset, > /* TODO: smp_cpus_done(); */ > > system_state = SYS_STATE_smp_booted; > +/* Wake up secondary CPUs to start idle

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-27 Thread Razvan Cojocaru
>> _However_, please picture an instruction that both writes into a page P1 >> we're interested in, _and_ causes a write into a read-only page-walk >> related page P2. Emulating the current instruction, as the upstream >> patch does, does eliminate the vm_event caused by writing into P2, but >> wit

[Xen-devel] [PATCH] drm/xen-front: Make shmem backed display buffer coherent

2018-11-27 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making it possible that the backend sees only partial content of the buffer which may lead to screen artifacts. Make sure that the frontend's memory is coherent and the

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-27 Thread Razvan Cojocaru
On 11/23/18 11:07 AM, Jan Beulich wrote: On 22.11.18 at 19:24, wrote: >> _However_, please picture an instruction that both writes into a page P1 >> we're interested in, _and_ causes a write into a read-only page-walk >> related page P2. Emulating the current instruction, as the upstream >> p

Re: [Xen-devel] Invalid OEM Table ID: Length cannot exceed 8 characters

2018-11-27 Thread Mathieu Tarral
> The "problem" presumably is a newer, more picky iasl. The problem > being with SeaBIOS you'd generally be better off asking the SeaBIOS > folks. Looking at 1.12.0 though I see that they've addressed the > issue already, so you should be able to find a respective commit in > their tree. I have gi

Re: [Xen-devel] [PATCH v1 1/2] system_state: introduce SYS_STATE_smp_booted

2018-11-27 Thread Sergey Dyasli
On 27/11/2018 10:22, Jan Beulich wrote: On 27.11.18 at 11:00, wrote: >> The new state means that all secondary CPUs are up. On x86 this also >> means that a microcode was (potentially) updated on all CPUs. > > I'm slightly concerned by such an x86 specific: Could we settle on > a more generi

Re: [Xen-devel] [PATCH v1 2/2] common/page_alloc: don't idle-scrub before microcode update

2018-11-27 Thread Sergey Dyasli
On 27/11/2018 10:15, Jan Beulich wrote: On 27.11.18 at 11:10, wrote: >> Hi, >> >> On 11/27/18 10:00 AM, Sergey Dyasli wrote: >>> Some x86 CPUs has errata regarding microcode updates. The most notorious >>> is Broadwell's BDX90: "Loading Microcode ... May Result in a System Hang". >>> (URL: >

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 11:49, wrote: > On 11/23/18 11:07 AM, Jan Beulich wrote: > On 22.11.18 at 19:24, wrote: >>> _However_, please picture an instruction that both writes into a page P1 >>> we're interested in, _and_ causes a write into a read-only page-walk >>> related page P2. Emulating the c

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-27 Thread Roger Pau Monné
On Tue, Nov 27, 2018 at 12:31:35PM +0200, Razvan Cojocaru wrote: > >> _However_, please picture an instruction that both writes into a page P1 > >> we're interested in, _and_ causes a write into a read-only page-walk > >> related page P2. Emulating the current instruction, as the upstream > >> patc

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-27 Thread Razvan Cojocaru
>> About the emulator and events: if we could have a toggle for the >> emulator to tell it "emulate the current instruction and send out a >> vm_event only if it touches a protected page that's NOT part of the page >> walk", that would also work - though I can't at this point tell how >> feasible t

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-27 Thread Razvan Cojocaru
On 11/27/18 1:32 PM, Roger Pau Monné wrote: > Would it be possible to add some kind of flag to the emulator to > signal whether p2m restrictions should be enforced/ignored? > hvmemul_acquire_page seems like a suitable place, but I'm not that > familiar with the emulator. > > Then you could generat

[Xen-devel] [linux-linus test] 130787: regressions - trouble: blocked/broken/fail/pass

2018-11-27 Thread osstest service owner
flight 130787 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/130787/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-27 Thread Andrew Cooper
On 27/11/2018 11:45, Razvan Cojocaru wrote: > On 11/27/18 1:32 PM, Roger Pau Monné wrote: >> Would it be possible to add some kind of flag to the emulator to >> signal whether p2m restrictions should be enforced/ignored? >> hvmemul_acquire_page seems like a suitable place, but I'm not that >> famil

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-27 Thread Razvan Cojocaru
On 11/27/18 1:59 PM, Andrew Cooper wrote: > On 27/11/2018 11:45, Razvan Cojocaru wrote: >> On 11/27/18 1:32 PM, Roger Pau Monné wrote: >>> Would it be possible to add some kind of flag to the emulator to >>> signal whether p2m restrictions should be enforced/ignored? >>> hvmemul_acquire_page seems

[Xen-devel] [distros-debian-snapshot test] 75623: tolerable FAIL

2018-11-27 Thread Platform Team regression test user
flight 75623 distros-debian-snapshot real [real] http://osstest.xensource.com/osstest/logs/75623/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-i386-daily-netboot-pygrub 11 guest-start fail blocked in 75615 test-amd64-i386-amd64-weekly-neti

[Xen-devel] [linux-4.19 test] 130789: regressions - trouble: blocked/broken/fail/pass

2018-11-27 Thread osstest service owner
flight 130789 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/130789/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64

[Xen-devel] [PATCH] x86emul: correct 32-bit address handling for AVX2 gathers

2018-11-27 Thread Jan Beulich
As done for other cases by commit 7869e2bafe ("x86emul/fuzz: add rudimentary limit checking"), address calculations should also use truncate_ea() for the AVX2 gather insns. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -84

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 26.11.18 at 18:30, wrote: > The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used > to be specified as ignored. However, bits 5 and 6 are now specified as > 'accessed' and 'dirty' bits and their use only remains safe as long as > the DTE 'Host Access Dirty' bits remai

Re: [Xen-devel] [PATCH v2] xl: free bitmaps on exit

2018-11-27 Thread Wei Liu
On Tue, Nov 27, 2018 at 11:06:08AM +0100, Olaf Hering wrote: > Every invocation of xl via valgrind will show three leaks. > Since libxl_bitmap_alloc uses NOGC, the caller has to free the memory > after use. And since xl_ctx_free might be called before > parse_global_config, also move the libxl_bitm

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 26.11.18 at 18:30, wrote: > The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used > to be specified as ignored. However, bits 5 and 6 are now specified as > 'accessed' and 'dirty' bits and their use only remains safe as long as > the DTE 'Host Access Dirty' bits remai

Re: [Xen-devel] Invalid OEM Table ID: Length cannot exceed 8 characters

2018-11-27 Thread Wei Liu
On Tue, Nov 27, 2018 at 03:04:44AM -0700, Jan Beulich wrote: > >>> On 27.11.18 at 00:07, wrote: > > I wanted to install Xen from source on Fedora 28. > > > > I choose the stable-4.11 branch, compiled it, and got an error at > > sudo make install > > > > make[7]: Entering directory > > '/home/va

Re: [Xen-devel] [PATCH] x86emul: correct 32-bit address handling for AVX2 gathers

2018-11-27 Thread Andrew Cooper
On 27/11/2018 12:49, Jan Beulich wrote: > As done for other cases by commit 7869e2bafe ("x86emul/fuzz: add > rudimentary limit checking"), address calculations should also use > truncate_ea() for the AVX2 gather insns. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper _

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-27 Thread Andrii Anisov
Hello Julien, On 23.11.18 15:27, Julien Grall wrote: But we can't use it, because our system is overcommitted. Can you describe how overcommitted your system is? I did mean that we have a requirement to not limit VCPU number with PCPU number. Also we should not use cpu pinning. I guess I used

Re: [Xen-devel] [Qemu-devel] [PATCH v5 12/24] hw: acpi: Export the MCFG getter

2018-11-27 Thread Igor Mammedov
On Thu, 22 Nov 2018 00:21:06 +0100 Samuel Ortiz wrote: > Hi Igor, > > On Thu, Nov 15, 2018 at 01:36:58PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:35 +0100 > > Samuel Ortiz wrote: > > > > > From: Yang Zhong > > > > > > The ACPI MCFG getter is not x86 specific and could be c

Re: [Xen-devel] [PATCH] xen/x86: add diagnostic printout to xen_mc_flush() in case of error

2018-11-27 Thread Boris Ostrovsky
On 11/27/18 2:46 AM, Juergen Gross wrote: > On 26/11/2018 21:11, Boris Ostrovsky wrote: >> On 11/23/18 11:24 AM, Juergen Gross wrote: >>> Failure of an element of a Xen multicall is signalled via a WARN() >>> only unless the kernel is compiled with MC_DEBUG. It is impossible to >> s/unless/if >> >>

Re: [Xen-devel] [Qemu-devel] [PATCH v5 20/24] hw: acpi: Define ACPI tables builder interface

2018-11-27 Thread Igor Mammedov
On Thu, 22 Nov 2018 00:57:21 +0100 Samuel Ortiz wrote: > On Fri, Nov 16, 2018 at 05:02:26PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:43 +0100 > > Samuel Ortiz wrote: > > > > > In order to decouple ACPI APIs from specific machine types, we are > > > creating an ACPI builder in

Re: [Xen-devel] [Qemu-devel] [PATCH for-3.2 v3 10/14] qdev-props: call object_apply_global_props()

2018-11-27 Thread Igor Mammedov
On Tue, 27 Nov 2018 00:02:35 +0400 Marc-André Lureau wrote: > Hi > On Mon, Nov 26, 2018 at 5:27 PM Igor Mammedov wrote: > > > > On Wed, 7 Nov 2018 16:36:48 +0400 > > Marc-André Lureau wrote: > > > > > It's now possible to use the common function. > > > > > > Teach object_apply_global_props()

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 27 November 2018 13:02 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code > > >>> On 26.1

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Andrew Cooper
On 27/11/2018 13:06, Jan Beulich wrote: On 26.11.18 at 18:30, wrote: >> The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used >> to be specified as ignored. However, bits 5 and 6 are now specified as >> 'accessed' and 'dirty' bits and their use only remains safe as long

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 27 November 2018 13:07 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code > > >>> On 26.1

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 27 November 2018 14:19 > To: Jan Beulich ; Paul Durrant > > Cc: xen-devel ; Brian Woods > ; Suravee Suthikulpanit > > Subject: Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code > > On 27/11/2018 13:06, Jan Beulich wrote: > >>

Re: [Xen-devel] [PATCH v2] mm: make opt_bootscrub non-init

2018-11-27 Thread Roger Pau Monné
On Tue, Nov 27, 2018 at 03:13:27AM -0700, Jan Beulich wrote: > >>> On 26.11.18 at 18:55, wrote: > > --- a/xen/common/page_alloc.c > > +++ b/xen/common/page_alloc.c > > @@ -166,7 +166,14 @@ enum bootscrub_mode { > > BOOTSCRUB_ON, > > BOOTSCRUB_IDLE, > > }; > > -static enum bootscrub_mode

[Xen-devel] [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning

2018-11-27 Thread Srikanth Boddepalli
Add a missing header otherwise compiler warns about missed prototype: drivers/xen/xlate_mmu.c:183:5: warning: no previous prototype for 'xen_xlate_unmap_gfn_range?' [-Wmissing-prototypes] int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma, ^ Signed-off-by: S

[Xen-devel] [linux-4.4 test] 130791: trouble: blocked/broken/fail/pass

2018-11-27 Thread osstest service owner
flight 130791 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/130791/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64-xsm

[Xen-devel] [PATCH v2] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used to be specified as ignored. However, bits 5 and 6 are now specified as 'accessed' and 'dirty' bits and their use only remains safe as long as the DTE 'Host Access Dirty' bits remain unused by Xen. The code was also the sub

Re: [Xen-devel] [PATCH v3] xen/balloon: Mark unallocated host memory as UNUSABLE

2018-11-27 Thread Igor Druzhinin
On 27/11/2018 03:28, Boris Ostrovsky wrote: > On 11/26/18 2:57 PM, Igor Druzhinin wrote: >> On 26/11/2018 19:42, Boris Ostrovsky wrote: >>> On 11/26/18 12:10 PM, Igor Druzhinin wrote: On 26/11/2018 16:25, Boris Ostrovsky wrote: > On 11/25/18 8:00 PM, Igor Druzhinin wrote: >> On 20/12/2

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-27 Thread Julien Grall
On 11/27/18 1:30 PM, Andrii Anisov wrote: Hello Julien, Hi Andrii, On 23.11.18 15:27, Julien Grall wrote: But we can't use it, because our system is overcommitted. Can you describe how overcommitted your system is? I did mean that we have a requirement to not limit VCPU number with PCPU

Re: [Xen-devel] [PATCH] CODING_STYLE: explicitly call out label indentation

2018-11-27 Thread Wei Liu
On Mon, Nov 26, 2018 at 02:04:05AM -0700, Jan Beulich wrote: > Since the behavior of "diff -p" to use an unindented label as context > identifier often makes it harder to review patches, make explicit the > requirement for labels to be indented. > > Signed-off-by: Jan Beulich > > --- a/CODING_ST

[Xen-devel] [PATCH v6 0/2] amd/iommu: fixes for PVH Dom0

2018-11-27 Thread Roger Pau Monne
Hello, This is the remaining of the PVH Dom0 fixes, which now only contains the AMD IOMMU patches. The series can be found at: git://xenbits.xen.org/people/royger/xen.git fixes-pvh-v6 Roger Pau Monne (2): amd/iommu: assign iommu devices to Xen amd/iommu: skip bridge devices when updating IOM

[Xen-devel] [PATCH v6 1/2] amd/iommu: assign iommu devices to Xen

2018-11-27 Thread Roger Pau Monne
AMD IOMMU devices are exposed on the PCI bus, and thus are assigned by default to the hardware domain. This can cause issues because the IOMMU devices themselves are not behind an IOMMU, so update_paging_mode will return an error if Xen tries to expand the page tables of a domain that has assigned

[Xen-devel] [PATCH v6 2/2] amd/iommu: skip bridge devices when updating IOMMU page tables

2018-11-27 Thread Roger Pau Monne
Bridges are not behind an IOMMU, and are already special cased and skipped in amd_iommu_add_device. Apply the same special casing when updating page tables. This is required or else update_paging_mode will fail and return an error to the caller (amd_iommu_{un}map_page) which will destroy the domai

Re: [Xen-devel] [PATCH] CODING_STYLE: explicitly call out label indentation

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 16:23, wrote: > On Mon, Nov 26, 2018 at 02:04:05AM -0700, Jan Beulich wrote: >> Since the behavior of "diff -p" to use an unindented label as context >> identifier often makes it harder to review patches, make explicit the >> requirement for labels to be indented. >> >> Signed-

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 15:19, wrote: > On 27/11/2018 13:06, Jan Beulich wrote: > On 26.11.18 at 18:30, wrote: >>> The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used >>> to be specified as ignored. However, bits 5 and 6 are now specified as >>> 'accessed' and 'dirty' bits

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 15:12, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 27 November 2018 13:02 >> To: Paul Durrant >> Cc: Brian Woods ; Suravee Suthikulpanit >> ; xen-devel > de...@lists.xenproject.org> >> Subject: Re: [Xen-devel] [PATCH] amd-iommu

Re: [Xen-devel] [PATCH] tools/libs: Make xenforeignmemory_unmap_resource() idempotent

2018-11-27 Thread Wei Liu
On Sat, Nov 24, 2018 at 03:09:33PM +, Paul Durrant wrote: > > -Original Message- > > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > > Of Paul Durrant > > Sent: 24 November 2018 15:06 > > To: Andrew Cooper ; Xen-devel > de...@lists.xen.org> > > Cc: Andrew Co

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 15:20, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 27 November 2018 13:07 >> To: Paul Durrant >> Cc: Brian Woods ; Suravee Suthikulpanit >> ; xen-devel > de...@lists.xenproject.org> >> Subject: Re: [Xen-devel] [PATCH] amd-iommu

Re: [Xen-devel] [PATCH] tools/libs: Make xenforeignmemory_unmap_resource() idempotent

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 27 November 2018 15:48 > To: Paul Durrant > Cc: Andrew Cooper ; Xen-devel de...@lists.xen.org>; Wei Liu ; Ian Jackson > > Subject: Re: [PATCH] tools/libs: Make xenforeignmemory_unmap_resource() > idempotent > > On

Re: [Xen-devel] [PATCH v2] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 15:58, wrote: > The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used > to be specified as ignored. However, bits 5 and 6 are now specified as > 'accessed' and 'dirty' bits and their use only remains safe as long as > the DTE 'Host Access Dirty' bits remai

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 27 November 2018 15:50 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [Xen-devel] [PATCH] amd-iommu: remove page merging code > > >>> On 27.1

Re: [Xen-devel] [PATCH v2] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 27 November 2018 15:58 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] [PATCH v2] amd-iommu: remove page merging code > > >>> On 2

Re: [Xen-devel] [PATCH] tools/libs: Make xenforeignmemory_unmap_resource() idempotent

2018-11-27 Thread Andrew Cooper
On 24/11/2018 15:05, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 23 November 2018 15:12 >> To: Xen-devel >> Cc: Andrew Cooper ; Ian Jackson >> ; Wei Liu ; Paul Durrant >> >> Subject: [PATCH] tools/libs: Make xenforeignmemory

Re: [Xen-devel] [PATCH] CODING_STYLE: explicitly call out label indentation

2018-11-27 Thread Ian Jackson
Since there was some confusion about what we are talking about, see below. Obviously the diff output in my `1' test cases is prefereable. Note that `git diff' does the same thing as diff -p (and it doesn't even need a -p option to do it). I also observe that by default, emacs wants to indent th

Re: [Xen-devel] [PATCH] tools/libs: Make xenforeignmemory_unmap_resource() idempotent

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 27 November 2018 16:10 > To: Paul Durrant ; Xen-devel de...@lists.xen.org> > Cc: Ian Jackson ; Wei Liu > Subject: Re: [PATCH] tools/libs: Make xenforeignmemory_unmap_resource() > idempotent > > On 24/11/2018 15:05, Paul Durrant wrote: >

Re: [Xen-devel] [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-11-27 Thread Michal Suchánek
On Mon, 26 Nov 2018 16:59:14 +0100 David Hildenbrand wrote: > On 26.11.18 15:20, Michal Suchánek wrote: > > On Mon, 26 Nov 2018 14:33:29 +0100 > > David Hildenbrand wrote: > > > >> On 26.11.18 13:30, David Hildenbrand wrote: > >>> On 23.11.18 19:06, Michal Suchánek wrote: > > >

Re: [Xen-devel] [PATCH v2] makedumpfile: exclude pages that are logically offline

2018-11-27 Thread Kazuhito Hagio
> Linux marks pages that are logically offline via a page flag (map count). > Such pages e.g. include pages infated as part of a balloon driver or > pages that were not actually onlined when onlining the whole section. > > While the hypervisor usually allows to read such inflated memory, we > basi

[Xen-devel] [linux-4.14 test] 130790: regressions - trouble: blocked/broken/fail/pass

2018-11-27 Thread osstest service owner
flight 130790 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/130790/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-xsm

Re: [Xen-devel] [PATCH v2] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 17:05, wrote: > Well, I could just leave PV-IOMMU unimplemented for AMD h/w if you think the > page merging code is more important since, without the spare ignored bits, I > have no way to track pages added by the hypercall vs. those added at start of > day. I personally thin

[Xen-devel] [PATCH] tools/libs: xenforeignmemory_unmap_resource() should be idempotent...

2018-11-27 Thread Paul Durrant
...and is not because linux osdep_xenforeignmemory_unmap_resource() is not. Reported-by: Andrew Cooper Signed-off-by: Paul Durrant --- Cc: Andrew Cooper Cc: Ian Jackson Cc: Wei Liu This is an alternative to the similarly named patch posted by Andrew. This one fixes the underlying issue in th

Re: [Xen-devel] [PATCH v2] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 27 November 2018 16:38 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [Xen-devel] [PATCH v2] amd-iommu: remove page merging code > > >>> On 2

Re: [Xen-devel] [PATCH] tools/libs: xenforeignmemory_unmap_resource() should be idempotent...

2018-11-27 Thread Wei Liu
On Tue, Nov 27, 2018 at 04:39:17PM +, Paul Durrant wrote: > ...and is not because linux osdep_xenforeignmemory_unmap_resource() is not. > > Reported-by: Andrew Cooper > Signed-off-by: Paul Durrant Acked-by: Wei Liu ___ Xen-devel mailing list Xen

Re: [Xen-devel] [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-11-27 Thread David Hildenbrand
On 27.11.18 17:32, Michal Suchánek wrote: > On Mon, 26 Nov 2018 16:59:14 +0100 > David Hildenbrand wrote: > >> On 26.11.18 15:20, Michal Suchánek wrote: >>> On Mon, 26 Nov 2018 14:33:29 +0100 >>> David Hildenbrand wrote: >>> On 26.11.18 13:30, David Hildenbrand wrote: > On 23.11.18

Re: [Xen-devel] [PATCH] CODING_STYLE: explicitly call out label indentation

2018-11-27 Thread Andrew Cooper
On 27/11/2018 16:22, Ian Jackson wrote: > Since there was some confusion about what we are talking about, see > below. Obviously the diff output in my `1' test cases is > prefereable. Note that `git diff' does the same thing as diff -p > (and it doesn't even need a -p option to do it). After so

Re: [Xen-devel] [PATCH v2] xl: free bitmaps on exit

2018-11-27 Thread Wei Liu
On Tue, Nov 27, 2018 at 11:06:08AM +0100, Olaf Hering wrote: > Every invocation of xl via valgrind will show three leaks. > Since libxl_bitmap_alloc uses NOGC, the caller has to free the memory > after use. And since xl_ctx_free might be called before > parse_global_config, also move the libxl_bitm

Re: [Xen-devel] [PATCH v2] mm: make opt_bootscrub non-init

2018-11-27 Thread Wei Liu
On Tue, Nov 27, 2018 at 03:25:29PM +0100, Roger Pau Monné wrote: > On Tue, Nov 27, 2018 at 03:13:27AM -0700, Jan Beulich wrote: > > >>> On 26.11.18 at 18:55, wrote: > > > --- a/xen/common/page_alloc.c > > > +++ b/xen/common/page_alloc.c > > > @@ -166,7 +166,14 @@ enum bootscrub_mode { > > > B

Re: [Xen-devel] [PATCH] CODING_STYLE: explicitly call out label indentation

2018-11-27 Thread George Dunlap
> On Nov 27, 2018, at 4:48 PM, Andrew Cooper wrote: > > On 27/11/2018 16:22, Ian Jackson wrote: >> Since there was some confusion about what we are talking about, see >> below. Obviously the diff output in my `1' test cases is >> prefereable. Note that `git diff' does the same thing as diff

Re: [Xen-devel] [PATCH v2] xl: free bitmaps on exit

2018-11-27 Thread Olaf Hering
Am Tue, 27 Nov 2018 16:55:38 + schrieb Wei Liu : > Looking more closely into this, these lines should be moved even > earlier before the call to libxl_ctx_alloc -- there is an exit there. Is it required to install the atexit handler before alloc()? To me it looks like atexit(xl_ctx_free) shou

[Xen-devel] [ARM] gvirt_to_maddr fails when DomU is created

2018-11-27 Thread Volodymyr Babchuk
Hello community, After creating domU, I'm seeing lots of this messages from hypervisor: (XEN) p2m.c:1442: d1v0: gvirt_to_maddr failed va=0x8efc7f0f flags=0x1 par=0x809 (XEN) p2m.c:1442: d1v0: gvirt_to_maddr failed va=0x8efc7f00 flags=0x1 par=0x809 (XEN) p2m.c:1442: d1v0: gvirt_to_

Re: [Xen-devel] [PATCH] CODING_STYLE: explicitly call out label indentation

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 18:09, wrote: >> On Nov 27, 2018, at 4:48 PM, Andrew Cooper wrote: >> On 27/11/2018 16:22, Ian Jackson wrote: >>> Since there was some confusion about what we are talking about, see >>> below. Obviously the diff output in my `1' test cases is >>> prefereable. Note that `git

Re: [Xen-devel] [PATCH v2] xl: free bitmaps on exit

2018-11-27 Thread Wei Liu
On Tue, Nov 27, 2018 at 06:09:33PM +0100, Olaf Hering wrote: > Am Tue, 27 Nov 2018 16:55:38 + > schrieb Wei Liu : > > > Looking more closely into this, these lines should be moved even > > earlier before the call to libxl_ctx_alloc -- there is an exit there. > > Is it required to install the

Re: [Xen-devel] [PATCH v1] Increase framebuffer size to todays standards

2018-11-27 Thread Julien Grall
Hi Jan, On 11/27/18 9:44 AM, Jan Beulich wrote: On 27.11.18 at 10:26, wrote: Hi Jan, On 11/26/18 4:15 PM, Jan Beulich wrote: On 26.11.18 at 17:03, wrote: Am Mon, 26 Nov 2018 03:31:27 -0700 schrieb "Jan Beulich" : And I think a change like this should (a) address the more general case rat

Re: [Xen-devel] [PATCH 17/18] xen/arm: Resume Dom0 after Xen resumes

2018-11-27 Thread Julien Grall
On 11/17/18 4:01 PM, Mirela Simonovic wrote: Hi, Hi Mirela, On Sat, Nov 17, 2018 at 12:06 AM Stefano Stabellini wrote: On Sat, 17 Nov 2018, Dario Faggioli wrote: On Fri, 2018-11-16 at 21:58 +, Julien Grall wrote: On 16/11/2018 21:41, Mirela Simonovic wrote: On Fri, Nov 16, 2018 a

[Xen-devel] [PATCH 3/3] docs: remove tmem related text

2018-11-27 Thread Wei Liu
Signed-off-by: Wei Liu --- docs/man/xl.conf.pod.5 | 9 ++--- docs/man/xl.pod.1.in| 68 - docs/misc/xen-command-line.markdown | 6 docs/misc/xsm-flask.txt | 36 4 files changed, 2 insertions(+)

[Xen-devel] [PATCH 0/3] Remove tmem

2018-11-27 Thread Wei Liu
It is agreed that tmem can be removed from xen.git. See the thread starting from . Wei Liu (3): xen: remove tmem from hypervisor tools: remove tmem code and commands docs: remove tmem related text docs/man/xl.conf.pod.5 |9 +- docs/man/xl.pod.1.in

[Xen-devel] [PATCH 2/3] tools: remove tmem code and commands

2018-11-27 Thread Wei Liu
Remove all tmem related code in libxc. Leave some stubs in libxl in case anyone has linked to those functions before the removal. Remove all tmem related commands in xl, all tmem related code in other utilities we ship. Signed-off-by: Wei Liu --- tools/libxc/Makefile|

Re: [Xen-devel] [PATCH 18/18] xen/arm: Suspend/resume console on Xen suspend/resume

2018-11-27 Thread Julien Grall
Hi Mirela, On 11/12/18 11:30 AM, Mirela Simonovic wrote: This is done using generic console_suspend/resume functions that cause uart driver specific suspend/resume handlers to be called for each initialized port (if the port has suspend/resume driver handlers implemented). Signed-off-by: Mirela

Re: [Xen-devel] [PATCH 17/18] MAINTAINERS: add myself as a Xen maintainer

2018-11-27 Thread Stefano Stabellini
On Wed, 21 Nov 2018, Paul Durrant wrote: > I have made many significant contributions to the Xen code in QEMU, > particularly the recent patches introducing a new PV device framework. > I intend to make further significant contributions, porting other PV back- > ends to the new framework with the i

Re: [Xen-devel] [PATCH 0/3] xen/x86: support setting dom0_mem depending on host size

2018-11-27 Thread Stefano Stabellini
Hi Juergen, I don't mean to scope-creep your series, and I think it is fine if you don't want to do it, but it would be fantastic if you took the opportunity to make dom0_mem common across architectures. On ARM, we parse it in xen/arch/arm/domain_build.c:parse_dom0_mem. I think the ARM and x86 im

Re: [Xen-devel] [Qemu-devel] [PATCH for-3.2 v4 15/28] hw: apply accel compat properties without touching globals

2018-11-27 Thread Eduardo Habkost
On Tue, Nov 27, 2018 at 01:27:48PM +0400, Marc-André Lureau wrote: > Introduce object_apply_global_props() function, to apply compatibility > properties from a GPtrArray. > > For accel compatibility properties, apply them during > device_post_init(), after accel_register_compat_props() has set the

Re: [Xen-devel] [ARM] gvirt_to_maddr fails when DomU is created

2018-11-27 Thread Julien Grall
(+ Stefano) On 11/27/18 5:12 PM, Volodymyr Babchuk wrote: Hello community, Hi Volodymyr, After creating domU, I'm seeing lots of this messages from hypervisor: (XEN) p2m.c:1442: d1v0: gvirt_to_maddr failed va=0x8efc7f0f flags=0x1 par=0x809 (XEN) p2m.c:1442: d1v0: gvirt_to_maddr fai

Re: [Xen-devel] [PATCH v5 02/20] loader/linux: support passing rsdp address via boot params

2018-11-27 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 03:28:37PM +0100, Juergen Gross wrote: > Xen PVH guests will have the RSDP at an arbitrary address. Support that > by passing the RSDP address via the boot parameters to Linux. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___

Re: [Xen-devel] [PATCH v5 05/20] xen: add some dummy headers for PVH mode

2018-11-27 Thread Daniel Kiper
On Wed, Nov 21, 2018 at 03:28:40PM +0100, Juergen Gross wrote: > With Xen PVH mode adding a new machine type the machine related headers > need to be present for the build to succeed. Most of the headers just > need to include the related common i386 headers. Add those to the tree. > > Note that xe

Re: [Xen-devel] [Qemu-devel] [PATCH for-3.2 v4 15/28] hw: apply accel compat properties without touching globals

2018-11-27 Thread Marc-André Lureau
Hi On Tue, Nov 27, 2018 at 11:40 PM Eduardo Habkost wrote: > > On Tue, Nov 27, 2018 at 01:27:48PM +0400, Marc-André Lureau wrote: > > Introduce object_apply_global_props() function, to apply compatibility > > properties from a GPtrArray. > > > > For accel compatibility properties, apply them duri

  1   2   >