On 27/11/2018 10:22, Jan Beulich wrote:
>>>> On 27.11.18 at 11:00, <sergey.dya...@citrix.com> wrote:
>> The new state means that all secondary CPUs are up. On x86 this also
>> means that a microcode was (potentially) updated on all CPUs.
>
> I'm slightly concerned by such an x86 specific: Could we settle on
> a more generic description of the state all CPUs are in at that
> point, like "fully functional", and only give ucode loading on x86
> as an example?
According to Julien's comment, I need to make this fix to be x86 only.
So I plan to introduce something like "bool suspend_idle_scrub" instead.
>> @@ -930,6 +932,8 @@ void __init start_xen(unsigned long boot_phys_offset,
>> printk("Brought up %ld CPUs\n", (long)num_online_cpus());
>> /* TODO: smp_cpus_done(); */
>>
>> + system_state = SYS_STATE_smp_booted;
>
> The placement here and ...
>
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -1683,6 +1683,8 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>> }
>> }
>>
>> + system_state = SYS_STATE_smp_booted;
>> +
>> printk("Brought up %ld CPUs\n", (long)num_online_cpus());
>> if ( num_parked )
>> printk(XENLOG_INFO "Parked %u CPUs\n", num_parked);
>
> ... here differ wrt the printk()s - is this intentional, and if so why?
This was not intentional, but it hardly matters now.
--
Thanks,
Sergey
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
