>>> On 19.11.18 at 19:11, wrote:
> On 19/11/2018 10:13, Jan Beulich wrote:
>> @@ -8828,12 +8837,7 @@ x86_emulate(
>> dst.type = OP_NONE;
>> break;
>> default:
>> -if ( (d & DstMask) != DstMem )
>> -{
>> -
On Mon, 19 Nov 2018 13:27:14 -0500
"Michael S. Tsirkin" wrote:
> On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote:
> > On Mon, 5 Nov 2018 02:40:28 +0100
> > Samuel Ortiz wrote:
> >
> > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System
> > > Description Table). RS
On Mon, 19 Nov 2018 18:02:53 +
"Boeuf, Sebastien" wrote:
> On Mon, 2018-11-19 at 16:37 +0100, Igor Mammedov wrote:
> > On Fri, 16 Nov 2018 19:42:08 +
> > "Boeuf, Sebastien" wrote:
> >
> > >
> > > Hi Igor,
> > >
> > > On Fri, 2018-11-16 at 10:39 +0100, Igor Mammedov wrote:
> > > >
>>> On 15.11.18 at 22:47, wrote:
> As noted in c/s 4999bf3e8b "x86/PV: use generic emulator for privileged
> instruction handling", these hoops are jumped through to retain the older
> behaviour, along with a note suggesting that we should reconsider things.
>
> It does not matter exactly when pv
flight 130585 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/130585/
Failures and problems with tests :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-arm64-xsm broken
build-arm64-xs
Hi David,
>
> Mark inflated and never onlined pages PG_offline, to tell the world that
> the content is stale and should not be dumped.
>
> Cc: "K. Y. Srinivasan"
> Cc: Haiyang Zhang
> Cc: Stephen Hemminger
> Cc: Kairui Song
> Cc: Vitaly Kuznetsov
> Cc: Andrew Morton
> Cc: Matthew Wilcox
On 20.11.18 09:45, Pankaj Gupta wrote:
>
> Hi David,
>
>>
>> Mark inflated and never onlined pages PG_offline, to tell the world that
>> the content is stale and should not be dumped.
>>
>> Cc: "K. Y. Srinivasan"
>> Cc: Haiyang Zhang
>> Cc: Stephen Hemminger
>> Cc: Kairui Song
>> Cc: Vitaly K
branch xen-unstable
xenbranch xen-unstable
job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict
testid depriv-audit-qemu/create
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/qemu-xen-trad
>>> On 19.11.18 at 18:26, wrote:
> For now, only do allocation/deallocation; keeping them in sync
> will be done in subsequent patches.
>
> Logdirty synchronization will only be done for active altp2ms;
> so allocate logdirty rangesets (copying the host logdirty
> rangeset) when an altp2m is acti
>>> On 19.11.18 at 18:26, wrote:
> When an new altp2m view is created very early on guest boot, the
> display will freeze (although the guest will run normally). This
> may also happen on resizing the display. The reason is the way
> Xen currently (mis)handles logdirty VGA: it intentionally
> misc
On 15/11/2018 09:33, Roger Pau Monné wrote:
> On Fri, Nov 02, 2018 at 01:37:29PM +0100, Juergen Gross wrote:
>> Add the needed code to setup the hypercall page for calling into the
>> Xen hypervisor.
>>
>> Signed-off-by: Juergen Gross
>
> Thanks, LGTM, just one suggestion and one question.
>
>>
On 09/11/2018 19:12, Daniel Kiper wrote:
> On Fri, Nov 02, 2018 at 01:37:29PM +0100, Juergen Gross wrote:
>> Add the needed code to setup the hypercall page for calling into the
>> Xen hypervisor.
>>
>> Signed-off-by: Juergen Gross
>> ---
>> V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné
On 11/20/18 11:12 AM, Jan Beulich wrote:
On 19.11.18 at 18:26, wrote:
>> When an new altp2m view is created very early on guest boot, the
>> display will freeze (although the guest will run normally). This
>> may also happen on resizing the display. The reason is the way
>> Xen currently (mis
> >> ---
> >> drivers/hv/hv_balloon.c | 14 --
> >> 1 file changed, 12 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> >> index 211f3fe3a038..47719862e57f 100644
> >> --- a/drivers/hv/hv_balloon.c
> >> +++ b/drivers/hv/hv_balloo
> On Nov 20, 2018, at 9:12 AM, Jan Beulich wrote:
>
On 19.11.18 at 18:26, wrote:
>> When an new altp2m view is created very early on guest boot, the
>> display will freeze (although the guest will run normally). This
>> may also happen on resizing the display. The reason is the way
>> Xen
On 11/20/18 11:05 AM, Jan Beulich wrote:
On 19.11.18 at 18:26, wrote:
>> For now, only do allocation/deallocation; keeping them in sync
>> will be done in subsequent patches.
>>
>> Logdirty synchronization will only be done for active altp2ms;
>> so allocate logdirty rangesets (copying the ho
>>> On 20.11.18 at 10:43, wrote:
>
>> On Nov 20, 2018, at 9:12 AM, Jan Beulich wrote:
>>
> On 19.11.18 at 18:26, wrote:
>>> When an new altp2m view is created very early on guest boot, the
>>> display will freeze (although the guest will run normally). This
>>> may also happen on resizing
>>> On 20.11.18 at 11:02, wrote:
> On 11/20/18 11:05 AM, Jan Beulich wrote:
> On 19.11.18 at 18:26, wrote:
>>> For now, only do allocation/deallocation; keeping them in sync
>>> will be done in subsequent patches.
>>>
>>> Logdirty synchronization will only be done for active altp2ms;
>>> so a
On 11/20/18 12:27 PM, Jan Beulich wrote:
On 20.11.18 at 11:02, wrote:
>> On 11/20/18 11:05 AM, Jan Beulich wrote:
>> On 19.11.18 at 18:26, wrote:
For now, only do allocation/deallocation; keeping them in sync
will be done in subsequent patches.
Logdirty synchronizatio
Without this change valgrind can not decide what variant of
xen_domctl_createdomain is provided as input.
Fixes commit 4a83497635 ("xen/domctl: Merge set_max_evtchn into createdomain")
Fixes commit a903bf5233 ("tools: Pass grant table limits to
XEN_DOMCTL_set_gnttab_limits")
Fixes commit ae8b8bc5
>>> On 15.11.18 at 22:47, wrote:
> @@ -1040,7 +1040,10 @@ static int hvm_load_cpu_ctxt(struct domain *d,
> hvm_domain_context_t *h)
> if ( hvm_funcs.tsc_scaling.setup )
> hvm_funcs.tsc_scaling.setup(v);
>
> -v->arch.hvm.msr_tsc_aux = ctxt.msr_tsc_aux;
> +if ( ctxt.msr_tsc_
>>> On 15.11.18 at 22:47, wrote:
> The final remnanat of PVRDTSCP is that we would emulate RDTSCP even on
> hardware which lacked the instruction. RDTSCP is available on almost all
> 64-bit x86 hardware.
>
> Remove this emulation, drop the TSC_MODE_PVRDTSCP constant, and allow RDTSCP
> in a PV g
>>> On 20.11.18 at 11:56, wrote:
> Without this change valgrind can not decide what variant of
> xen_domctl_createdomain is provided as input.
>
> Fixes commit 4a83497635 ("xen/domctl: Merge set_max_evtchn into createdomain")
> Fixes commit a903bf5233 ("tools: Pass grant table limits to
> XEN_DO
Hello Andre,
I'm going to change "gic_raise_guest_irq()" function interface.
Could you please comment my understanding of vgic-v3-its.c code below?
So that I could fix it alongside the function interface change.
On 16.11.18 18:45, Andrii Anisov wrote:
diff --git a/xen/arch/arm/vgic-v3-its.c
On 19/11/2018 15:25, Jan Beulich wrote:
On 15.11.18 at 22:47, wrote:
>> For more historical context, see
>> c/s c17b36d5dc792cfdf59b6de0213b168bec0af8e8
>> c/s 04656384a1b9714e43db850c51431008e23450d8
>>
>> PVRDTSCP was an attempt to provide Xen-aware userspace with a stable
>> monotonic
flight 130591 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/130591/
Failures and problems with tests :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-arm64-xsm broken
build-arm64-xs
On 20/11/2018 11:06, Jan Beulich wrote:
On 15.11.18 at 22:47, wrote:
>> The final remnanat of PVRDTSCP is that we would emulate RDTSCP even on
>> hardware which lacked the instruction. RDTSCP is available on almost all
>> 64-bit x86 hardware.
>>
>> Remove this emulation, drop the TSC_MODE_PV
flight 130527 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/130527/
Failures and problems with tests :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-arm64-xsm broken
build-arm64
Hello Stefano,
On 01.11.18 22:20, Stefano Stabellini wrote:
No, I haven't had any time. Aside from the Xen version, another
difference is the interrupt source. I used the physical timer for
testing.
Could you share your approach for interrupts latency measurement? Are
you using any HW specifi
Deployment note: I have copied this binary to the images directory in
Cambridge and Massachusetts. The corresponding patch to chiark-utils
is on its way to my upstream hat.
CC: George Dunlap
Signed-off-by: Ian Jackson
---
production-config | 2 +-
production-config-cambridge | 2 +-
libxl creates this directory with mode 0. That prevents
fishdescriptor from working. chmod it. This is OK for testing.
CC: George Dunlap
Signed-off-by: Ian Jackson
---
ts-depriv-audit-qemu | 1 +
1 file changed, 1 insertion(+)
diff --git a/ts-depriv-audit-qemu b/ts-depriv-audit-qemu
index d
* Use mkdir -p, rather than trying to only create /run/user/$uid.
That helps if /run and/or /run/user do not exist, as they do in
libxl-made chroots with recent libxl (which gets qemu to chroot).
* Do all of this in the root directory of the qemu process, not our
own root directory. So it w
flight 75615 distros-debian-snapshot real [real]
http://osstest.xensource.com/osstest/logs/75615/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-amd64-current-netinst-pygrub 10 debian-di-install fail like
75591
test-amd64-i386-i386-daily-ne
On Mon, 19 Nov 2018 18:14:26 +0100
Paolo Bonzini wrote:
> On 19/11/18 16:31, Igor Mammedov wrote:
> > I've tried to give suggestions how to restructure series
> > on per patch basis. In my opinion it quite possible to split
> > series in several smaller ones and it should really help with
> > mak
branch xen-unstable
xenbranch xen-unstable
job build-armhf-libvirt
testid libvirt-build
Tree: libvirt git://libvirt.org/libvirt.git
Tree: libvirt_gnulib https://git.savannah.gnu.org/git/gnulib.git/
Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git
Tree: qemuu git://xenbits.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Xen Security Advisory XSA-276
version 2
resource accounting issues in x86 IOREQ server handling
UPDATES IN VERSION 2
Public release.
ISSUE DESCRIPTION
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Xen Security Advisory XSA-275
version 2
insufficient TLB flushing / improper large page mappings with AMD IOMMUs
UPDATES IN VERSION 2
Public release.
ISSUE DESCRIPTION
=
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Xen Security Advisory XSA-277
version 2
x86: incorrect error handling for guest p2m page removals
UPDATES IN VERSION 2
Public release.
ISSUE DESCRIPTION
===
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Xen Security Advisory XSA-279
version 2
x86: DoS from attempting to use INVPCID with a non-canonical addresses
UPDATES IN VERSION 2
Public release.
ISSUE DESCRIPTION
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Xen Security Advisory XSA-280
version 2
Fix for XSA-240 conflicts with shadow paging
UPDATES IN VERSION 2
Public release.
ISSUE DESCRIPTION
=
Th
flight 130601 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/130601/
Failures and problems with tests :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-arm64-xsm broken
build-arm64-xs
They should have used .gcc-x86-32-build-debug in the first place.
Signed-off-by: Wei Liu
---
This patch is trivial so I intend to commit it as soon as possible to
fix Gitlab CI.
---
.gitlab-ci.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci
On 20/11/2018 14:10, Wei Liu wrote:
> They should have used .gcc-x86-32-build-debug in the first place.
>
> Signed-off-by: Wei Liu
Oops yes - Acked-by: Andrew Cooper
> ---
> This patch is trivial so I intend to commit it as soon as possible to
> fix Gitlab CI.
> ---
> .gitlab-ci.yml | 4 ++--
>
Wei Liu writes ("[PATCH 2/3] tools/helpers: make gen_stub_json_config accept an
UUID argument"):
> If that's set, the stub is going to contain that UUID.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xen
Wei Liu writes ("[PATCH 1/3] tools: update examples/README"):
> This file gets installed to the host system.
>
> This patch cleans it up: 1. remove things that don't exist anymore; 2.
> change xm to xl; 3. fix xen-devel list address; 4. add things that are
> missing.
Acked-by: Ian Jackson
_
Wei Liu writes ("[PATCH 3/3] xen-init-dom0: set Dom0 UUID if requested"):
> Read from XEN_CONFIG_DIR/dom0-uuid. If it contains a valid UUID, set
> it for Dom0.
I approve of the basic principle of this change. Thanks.
However, I am not particularly keen on the details of the config
representation
With PVRDTSCP mode removed, handling of MSR_TSC_AUX can move into the common
code. Move its storage into struct vcpu_msrs (dropping the HVM-specific
msr_tsc_aux), and add an RDPID feature check as this bit also enumerates the
presence of the MSR.
Introduce cpu_has_rdpid along with the synthesized
Currently, tsc_set_info() performs no parameter checking, and an invalid
tsc_mode goes largely unnoticed. Fix it to reject invalid tsc_modes with
-EINVAL, and update the callers to check the return value.
Signed-off-by: Andrew Cooper
---
CC: Jan Beulich
CC: Wei Liu
CC: Roger Pau Monné
v2:
*
Boris has confirmed that noone appears to be using PVRDTSCP any more, and in
the decade since it was introduced, guest kernel / hardware support has
provided a better alternative.
For changes, see individual patches.
Andrew Cooper (5):
x86/time: Alter tsc_set_info() to return an error value
x
The final remnanat of PVRDTSCP is that we would emulate RDTSCP even on
hardware which lacked the instruction. RDTSCP is available on almost all
64-bit x86 hardware.
Remove this emulation, drop the TSC_MODE_PVRDTSCP constant, and allow RDTSCP
in a PV guest's CPUID policy.
Signed-off-by: Andrew Co
As noted in c/s 4999bf3e8b "x86/PV: use generic emulator for privileged
instruction handling", these hoops are jumped through to retain the older
behaviour, along with a note suggesting that we should reconsider things.
Part of the reason for retention of the old behaviour was removed by c/s
5b042
For more historical context, see
c/s c17b36d5dc792cfdf59b6de0213b168bec0af8e8
c/s 04656384a1b9714e43db850c51431008e23450d8
PVRDTSCP was an attempt to provide Xen-aware userspace with a stable monotonic
clock, and enough information for said userspace to cope with frequency
changes across migra
On Tue, Nov 20, 2018 at 02:10:02PM +, Wei Liu wrote:
> They should have used .gcc-x86-32-build-debug in the first place.
>
> Signed-off-by: Wei Liu
> ---
> This patch is trivial so I intend to commit it as soon as possible to
> fix Gitlab CI.
Agreed.
Acked-by: Doug Goldstein
_
On Mon, Nov 19, 2018 at 07:56:18AM -0700, Jan Beulich wrote:
> >>> On 14.11.18 at 12:57, wrote:
> > Make sure the MSIX MMIO regions don't have p2m entries setup, so that
> > accesses to them trap into the hypervisor and can be handled by vpci.
> >
> > Commit 042678762 ("x86/iommu: add map-reserve
On 19 November 2018 at 12:08, Mao Zhongyi
wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> xen_sysdev_class_init().
>
> Cc: sstabell...@kernel.org
> Cc: anthony.per...@citrix.com
> Cc: xen-devel@lists.xenproject.org
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
> ---
>
flight 130548 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/130548/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-arm64 broken
build-arm64-pvops
>>> On 20.11.18 at 12:29, wrote:
> On 20/11/2018 11:06, Jan Beulich wrote:
> On 15.11.18 at 22:47, wrote:
>>> The final remnanat of PVRDTSCP is that we would emulate RDTSCP even on
>>> hardware which lacked the instruction. RDTSCP is available on almost all
>>> 64-bit x86 hardware.
>>>
>>> R
Hello Julien,
It is me again.
On 15.11.18 17:05, Julien Grall wrote:
On 11/15/18 1:19 PM, Andrii Anisov wrote:
So I would prefer to stick with _t which is quite common within the p2m
code base so far.
I've found a similar code only in one place - p2m_get_entry()
function. And it is, at leas
Make X86_VENDOR_UNKNOWN have the value 0 so a piece of zeroed memory can't get
confused with X86_VENDOR_INTEL.
No functional change.
Signed-off-by: Andrew Cooper
---
CC: Jan Beulich
CC: Wei Liu
CC: Roger Pau Monné
---
xen/include/asm-x86/x86-vendors.h | 12 ++--
1 file changed, 6 ins
On Wed, 7 Nov 2018 16:36:39 +0400
Marc-André Lureau wrote:
> Instead, it returns 1 if an error was detected, which is the case for:
>
> /qdev/properties/dynamic/global/subprocess:
> warning: global dynamic-prop-type-bad.prop3 has invalid class name
> warning: global nohotplug-type.prop5=105 not
To mitigate Meltdown, Xen has been fixed with a software fix, namely
using retpoline sequences generated by the compiler. This way, indirect
branches are protected against the attack.
However, the retpoline sequence comes with a slow down. To make up for
this, we propose to avoid jump tables in th
>>> On 20.11.18 at 16:30, wrote:
> Make X86_VENDOR_UNKNOWN have the value 0 so a piece of zeroed memory can't get
> confused with X86_VENDOR_INTEL.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper
Acked-by: Jan Beulich
___
Xen-devel mai
>>> On 20.11.18 at 16:37, wrote:
> To mitigate Meltdown, Xen has been fixed with a software fix, namely
> using retpoline sequences generated by the compiler. This way, indirect
> branches are protected against the attack.
>
> However, the retpoline sequence comes with a slow down. To make up for
>>> On 20.11.18 at 16:37, wrote:
> To mitigate Meltdown, Xen has been fixed with a software fix, namely
> using retpoline sequences generated by the compiler. This way, indirect
> branches are protected against the attack.
Actually I was meaning to commit this right away, but then my
attention wa
flight 130607 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/130607/
Failures and problems with tests :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-arm64-xsm broken
build-arm64-xs
In particular sh_oos_audit() has become stale due to changes elsewhere,
and the need for adjustment was not noticed because both "full audit"
flags are off in both release and debug builds. Switch away from pre-
processsor conditionals, thus exposing the code to the compiler at all
times. This obvi
Current logic to handle long running operations is flawed because it
doesn't prevent the guest vcpu from running. Fix this by raising a
scheduler softirq when preemption is required, so that the do_softirq
call in the guest entry path performs a rescheduling. Also move the
call to vpci_process_pend
No functional change expected.
Signed-off-by: Roger Pau Monné
---
Cc: Andrew Cooper
Cc: George Dunlap
Cc: Ian Jackson
Cc: Jan Beulich
Cc: Julien Grall
Cc: Konrad Rzeszutek Wilk
Cc: Stefano Stabellini
Cc: Tim Deegan
Cc: Wei Liu
---
Changes since v4:
- New in this version.
---
xen/driver
Hello,
The following series contain miscellaneous fixes for a PVH Dom0. I've
found out this issues while trying to boot on an AMD EPYC box.
The series can be found on my git repo:
git://xenbits.xen.org/people/royger/xen.git fixes-pvh-v5
Roger Pau Monne (6):
vpci: fix updating the command regi
Bridges are not behind an IOMMU, and are already special cased and
skipped in amd_iommu_add_device. Apply the same special casing when
updating page tables.
This is required or else update_paging_mode will fail and return an
error to the caller (amd_iommu_{un}map_page) which will destroy the
domai
Make sure the MSIX MMIO regions don't have p2m entries setup, so that
accesses to them trap into the hypervisor and can be handled by vpci.
Commit 042678762 ("x86/iommu: add map-reserved dom0-iommu option to
map reserved memory ranges") added mappings for all the reserved
regions into the PVH Dom0
AMD IOMMU devices are exposed on the PCI bus, and thus are assigned by
default to the hardware domain. This can cause issues because the
IOMMU devices themselves are not behind an IOMMU, so update_paging_mode will
return an error if Xen tries to expand the page tables of a domain
that has assigned
When switching the memory decoding bit in the command register the
rest of the changes where dropped, leading to only the memory decoding
bit being updated.
Fix this by writing the command register once the guest physmap
manipulations are done if there are changes to the memory decoding
bit.
Note
On Tue, Nov 20, 2018 at 08:44:31AM -0700, Jan Beulich wrote:
> >>> On 20.11.18 at 16:37, wrote:
> > To mitigate Meltdown, Xen has been fixed with a software fix, namely
> > using retpoline sequences generated by the compiler. This way, indirect
> > branches are protected against the attack.
> >
>
A few things I had run into while working on that issue:
1: mm: disallow MEMF_no_refcount to be passed for domain-owned allocations
2: x86: correct instances of PGC_allocated clearing
3: x86: reduce code duplication in guest_remove_page()
4: make domain_adjust_tot_pages() __must_check
They don't
>>> On 20.11.18 at 17:01, wrote:
> AMD IOMMU devices are exposed on the PCI bus, and thus are assigned by
> default to the hardware domain. This can cause issues because the
> IOMMU devices themselves are not behind an IOMMU, so update_paging_mode will
> return an error if Xen tries to expand the
Both our arm64 boxes are out of commission again.
I have filed a ticket to have the recently failed box investigated.
And I am working on the stretcb upgrade which will bring our
Thunder-X into service.
But for now this is the best we can do to unblock everything.
CC: Julien Grall
Signed-off-by
>>> On 20.11.18 at 16:57, wrote:
> On Tue, Nov 20, 2018 at 08:44:31AM -0700, Jan Beulich wrote:
>> >>> On 20.11.18 at 16:37, wrote:
>> > To mitigate Meltdown, Xen has been fixed with a software fix, namely
>> > using retpoline sequences generated by the compiler. This way, indirect
>> > branches
When such pages get assigned to domains (and hence their ->tot_pages
not incremented accordingly) we would otherwise also need to suppress
decrementing the count when freeing those pages.
Signed-off-by: Jan Beulich
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -2303,6 +2303,8 @@
For domain heap pages assigned to a domain dropping the page reference
tied to PGC_allocated may not drop the last reference, as otherwise the
test_and_clear_bit() might already act on an unowned page.
Work around this where possible, but the need to acquire extra page
references is a fair hint th
Quite a bit of duplicate code has accumulated on the "paging" types
special case path. Re-use what can be re-used from the common path.
Since it needs touching anyway, slightly re-format and extend the
gdprintk() on the common path as well.
Signed-off-by: Jan Beulich
--- a/xen/common/memory.c
+
Even if unlikely, donate_page() should not ignore the possible need to
obtain a domain reference. To make people look more closely when they
add new uses of domain_adjust_tot_pages(), force its return value to be
checked. This in turn requires a benign change to assign_pages().
Signed-off-by: Jan
>>> On 20.11.18 at 15:36, wrote:
> Currently, tsc_set_info() performs no parameter checking, and an invalid
> tsc_mode goes largely unnoticed. Fix it to reject invalid tsc_modes with
> -EINVAL, and update the callers to check the return value.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Jan
>>> On 20.11.18 at 15:36, wrote:
> For more historical context, see
> c/s c17b36d5dc792cfdf59b6de0213b168bec0af8e8
> c/s 04656384a1b9714e43db850c51431008e23450d8
>
> PVRDTSCP was an attempt to provide Xen-aware userspace with a stable monotonic
> clock, and enough information for said userspa
>>> On 20.11.18 at 15:37, wrote:
> With PVRDTSCP mode removed, handling of MSR_TSC_AUX can move into the common
> code. Move its storage into struct vcpu_msrs (dropping the HVM-specific
> msr_tsc_aux), and add an RDPID feature check as this bit also enumerates the
> presence of the MSR.
>
> Intr
On Wed, 7 Nov 2018 16:36:40 +0400
Marc-André Lureau wrote:
> Interfaces don't have instance, let's make the interface type really
> abstract to avoid confusion.
>
> Signed-off-by: Marc-André Lureau
> ---
> include/hw/acpi/acpi_dev_interface.h | 6 +-
> include/hw/arm/linux-boot-if.h
On Mon, Nov 19, 2018 at 09:30:59PM +, Wei Liu wrote:
> Signed-off-by: Wei Liu
> ---
> automation/build/README.md | 3 +++
> automation/scripts/containerize | 8 +---
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/automation/build/README.md b/automation/build/REA
On Mon, Nov 19, 2018 at 09:31:00PM +, Wei Liu wrote:
> Signed-off-by: Wei Liu
> ---
> .gitlab-ci.yml | 2 +-
> automation/scripts/build | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 5678b552c4..28152e906d 100644
On Mon, Nov 19, 2018 at 09:31:01PM +, Wei Liu wrote:
> ... so that it can be passed on to test stage.
>
> Note that xen is only extracted for x86_64 build since others may not
> have that. Use a directory to account for possibly different file
> names on Arm.
>
> Signed-off-by: Wei Liu
Acke
On Wed, 7 Nov 2018 16:36:41 +0400
Marc-André Lureau wrote:
> Instead of accepting any Object*, change user_creatable_complete() to
> require a UserCreatable*. Modify the callers to pass the appropriate
> argument, removing redundant dynamic cast checks in object creation.
Looks like it doesn't
On Wed, 7 Nov 2018 16:36:43 +0400
Marc-André Lureau wrote:
> The function is only used by a test, move it there.
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Eduardo Habkost
Reviewed-by: Igor Mammedov
> ---
> include/hw/qdev-properties.h | 1 -
> hw/core/qdev-properties.c |
On Mon, Nov 19, 2018 at 09:31:02PM +, Wei Liu wrote:
> This patch introduces a new test stage into the pipeline and provides
> a simple QEMU based smoke test.
>
> Signed-off-by: Wei Liu
> ---
> .gitlab-ci.yml | 19 +++
> automation/scripts/qemu-smoke-
On 20/11/2018 15:59, Jan Beulich wrote:
> In particular sh_oos_audit() has become stale due to changes elsewhere,
> and the need for adjustment was not noticed because both "full audit"
> flags are off in both release and debug builds. Switch away from pre-
> processsor conditionals, thus exposing
>>> On 20.11.18 at 17:01, wrote:
> Bridges are not behind an IOMMU, and are already special cased and
> skipped in amd_iommu_add_device. Apply the same special casing when
> updating page tables.
>
> This is required or else update_paging_mode will fail and return an
> error to the caller (amd_io
On Tue, Nov 20, 2018 at 10:41:07AM -0600, Doug Goldstein wrote:
> On Mon, Nov 19, 2018 at 09:31:02PM +, Wei Liu wrote:
> > This patch introduces a new test stage into the pipeline and provides
> > a simple QEMU based smoke test.
> >
> > Signed-off-by: Wei Liu
> > ---
> > .gitlab-ci.yml
On 20/11/2018 16:17, Jan Beulich wrote:
> When such pages get assigned to domains (and hence their ->tot_pages
> not incremented accordingly) we would otherwise also need to suppress
> decrementing the count when freeing those pages.
>
> Signed-off-by: Jan Beulich
>
> --- a/xen/common/page_alloc.c
On 20/11/2018 15:49, Jan Beulich wrote:
On 20.11.18 at 16:37, wrote:
>> To mitigate Meltdown, Xen has been fixed with a software fix, namely
>> using retpoline sequences generated by the compiler. This way, indirect
>> branches are protected against the attack.
> Actually I was meaning to com
Now that idle scrub is the default option, all memory is marked as dirty
and alloc_domheap_pages() will do eager scrubbing by default. This can
lead to longer Dom0 construction and potentially to a watchdog timeout,
especially on older H/W (e.g. Harpertown).
Pass MEMF_no_scrub to optimise this pro
On 20/11/2018 16:18, Jan Beulich wrote:
> For domain heap pages assigned to a domain dropping the page reference
> tied to PGC_allocated may not drop the last reference, as otherwise the
> test_and_clear_bit() might already act on an unowned page.
>
> Work around this where possible, but the need t
>>> On 20.11.18 at 17:59, wrote:
> On 20/11/2018 16:18, Jan Beulich wrote:
>> For domain heap pages assigned to a domain dropping the page reference
>> tied to PGC_allocated may not drop the last reference, as otherwise the
>> test_and_clear_bit() might already act on an unowned page.
>>
>> Work a
1 - 100 of 140 matches
Mail list logo
