On 20/11/2018 16:18, Jan Beulich wrote:
> For domain heap pages assigned to a domain dropping the page reference
> tied to PGC_allocated may not drop the last reference, as otherwise the
> test_and_clear_bit() might already act on an unowned page.
>
> Work around this where possible, but the need to acquire extra page
> references is a fair hint that references should have been acquired in
> other places instead.
>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
> ---
> Compile tested only, as I have neither a mem-sharing nor a mem-paging
> environment set up ready to be used for such testing.

Perhaps we should compile them out by default?  It's clear there are no
production users, given the quality of the code and how many security
issues we spot accidentally.

Either way, the code looks plausible.  Acked-by: Andrew Cooper
<andrew.coop...@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to