Re: [Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

2018-11-09 Thread Jan Beulich
>>> On 08.11.18 at 17:59, wrote: > On Thu, Nov 08, 2018 at 09:25:26AM -0700, Jan Beulich wrote: >> >>> On 08.11.18 at 14:20, wrote: >> > On Thu, Nov 08, 2018 at 06:04:11AM -0700, Jan Beulich wrote: >> >> >>> On 08.11.18 at 13:47, wrote: >> >> > My point would be that on x86 I think the only way

[Xen-devel] [PATCH] xen/pt: fix some pass-thru devices don't work across reboot

2018-11-09 Thread Chao Gao
I find some pass-thru devices don't work any more across guest reboot. Assigning it to another domain also meets the same issue. And the only way to make it work again is un-binding and binding it to pciback. Someone reported this issue one year ago [1]. The root cause is that xen sets the maskall

Re: [Xen-devel] [PATCH] x86/traps: use only one stub function for l/cstar

2018-11-09 Thread Jan Beulich
>>> On 08.11.18 at 18:08, wrote: > --- a/xen/arch/x86/x86_64/traps.c > +++ b/xen/arch/x86/x86_64/traps.c > @@ -298,19 +298,13 @@ static unsigned int write_stub_trampoline( > } > > DEFINE_PER_CPU(struct stubs, stubs); > - > -#ifdef CONFIG_PV > void lstar_enter(void); > void cstar_enter(void);

Re: [Xen-devel] [PATCH] x86/dom0: Use init_xen_pae_l2_slots() rather than opencoding it

2018-11-09 Thread Jan Beulich
>>> On 08.11.18 at 18:59, wrote: > On Thu, Nov 08, 2018 at 05:46:51PM +, Andrew Cooper wrote: >> No functional change. >> >> Signed-off-by: Andrew Cooper > > > Reviewed-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@

Re: [Xen-devel] [PATCH v2] mm/page_alloc: make bootscrub happen in idle-loop

2018-11-09 Thread Sergey Dyasli
On 08/11/2018 15:18, Roger Pau Monné wrote: > On Thu, Nov 08, 2018 at 02:48:40PM +, Sergey Dyasli wrote: >> (CCing Roger) >> >> On 08/11/2018 11:07, Andrew Cooper wrote: >>> On 08/11/18 10:31, Jan Beulich wrote: >>> On 07.11.18 at 19:20, wrote: > On 09/10/18 16:21, Sergey Dyasli wrote:

Re: [Xen-devel] [Qemu-devel] [PATCH v5 13/24] hw: acpi: Do not create hotplug method when handler is not defined

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:36 +0100 Samuel Ortiz wrote: > CPU and memory ACPI hotplug are not necessarily handled through SCI > events. For example, with Hardware-reduced ACPI, the GED device will > manage ACPI hotplug entirely. > As a consequence, we make the CPU and memory specific events AML >

Re: [Xen-devel] [PATCH] xen/pt: fix some pass-thru devices don't work across reboot

2018-11-09 Thread Jan Beulich
>>> On 09.11.18 at 01:11, wrote: > I find some pass-thru devices don't work any more across guest > reboot. Assigning it to another domain also meets the same issue. And > the only way to make it work again is un-binding and binding it to > pciback. Someone reported this issue one year ago [1]. I

[Xen-devel] [xen-4.9-testing test] 129541: regressions - FAIL

2018-11-09 Thread osstest service owner
flight 129541 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/129541/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 12 guest-start/redhat.repeat fail REGR. vs. 129461 test-

[Xen-devel] [ovmf test] 129689: regressions - FAIL

2018-11-09 Thread osstest service owner
flight 129689 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129689/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread Juergen Gross
This email only tracks big items for xen.git tree. Please reply for items you would like to see in 4.12 so that people have an idea what is going on and prioritise accordingly. You're welcome to provide description and use cases of the feature you're working on. = Timeline = We now adopt a fixed

Re: [Xen-devel] [PATCH v2 0/4] x86/HVM: implement memory read caching

2018-11-09 Thread Jan Beulich
>>> On 12.10.18 at 15:55, wrote: While I haven't heard back on my earlier reply, nevertheless a few more thoughts. > First and foremost, I'd like recommend against trying to combine the fix > for repeated PDPTR reading, and repeated PTE reading. While they are > both repeated reading problems,

Re: [Xen-devel] [PATCH v3 3/5] viridian: define type for the 'virtual VP assist page'

2018-11-09 Thread Jan Beulich
>>> On 07.11.18 at 11:52, wrote: > --- a/xen/include/asm-x86/hvm/viridian.h > +++ b/xen/include/asm-x86/hvm/viridian.h > @@ -20,11 +20,13 @@ union viridian_page_msr > } fields; > }; > > +typedef union _HV_VP_ASSIST_PAGE HV_VP_ASSIST_PAGE; > + > struct viridian_vcpu > { > struct { >

Re: [Xen-devel] [Qemu-devel] xen_disk qdevification

2018-11-09 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 08 November 2018 16:44 > To: Paul Durrant ; 'Kevin Wolf' > > Cc: Stefano Stabellini ; qemu-bl...@nongnu.org; > Tim Smith ; qemu-de...@nongnu.org; 'Markus > Armbruster' ; Anthony Perard > ; xen-devel@lists.xenproject.org; Max Reitz > > Subj

Re: [Xen-devel] [PATCH v3 3/5] viridian: define type for the 'virtual VP assist page'

2018-11-09 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 09 November 2018 10:24 > To: Paul Durrant > Cc: Andrew Cooper ; xen-devel de...@lists.xenproject.org> > Subject: Re: [PATCH v3 3/5] viridian: define type for the 'virtual VP > assist page' > > >>> On 07.11.18 at

Re: [Xen-devel] [PATCH V4 3/3] x86/altp2m: fix display frozen when switching to a new view early

2018-11-09 Thread Jan Beulich
>>> On 08.11.18 at 19:37, wrote: > On the first patch of the series: can it go in independently, since Jan > is OK with it and it just got your ack? Or should I just add the ack and > carry it over to the next version of the series? Well, I would have committed it, if only it had a VMX/EPT mainta

Re: [Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread Wei Liu
On Fri, Nov 09, 2018 at 11:16:31AM +0100, Juergen Gross wrote: > > == Completed == * HVM-only hypervisor - Wei Liu Wei. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Qemu-devel] xen_disk qdevification

2018-11-09 Thread Kevin Wolf
Am 09.11.2018 um 11:27 hat Paul Durrant geschrieben: > > -Original Message- > > From: Paul Durrant > > Sent: 08 November 2018 16:44 > > To: Paul Durrant ; 'Kevin Wolf' > > > > Cc: Stefano Stabellini ; qemu-bl...@nongnu.org; > > Tim Smith ; qemu-de...@nongnu.org; 'Markus > > Armbruster' ; A

[Xen-devel] [PATCH v2] x86/traps: use only one stub function for l/cstar

2018-11-09 Thread Wei Liu
And place it into .text.cold. Requested-by: Jan Beulich Signed-off-by: Wei Liu --- v2: use #define --- xen/arch/x86/x86_64/traps.c | 11 --- xen/include/xen/init.h | 1 + 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_

Re: [Xen-devel] [PATCH] xen/netfront: remove unnecessary wmb

2018-11-09 Thread Wei Liu
On Fri, Nov 09, 2018 at 02:53:59PM +0800, Jacob Wen wrote: > RING_PUSH_REQUESTS_AND_CHECK_NOTIFY is already able to make sure backend sees > requests before req_prod is updated. > > Signed-off-by: Jacob Wen Reviewed-by: Wei Liu ___ Xen-devel mailing

Re: [Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread Jan Beulich
>>> On 09.11.18 at 11:16, wrote: > I have started to include the version number of series associated to each > feature. Can each owner send an update on the version number if the series > was posted upstream? Oh, I had assumed you'd maintain this as things get posted. > == Hypervisor == > > *

Re: [Xen-devel] [PATCH v2 7/8] x86/vvmx: correctly report vvmcs size

2018-11-09 Thread Wei Liu
On Thu, Nov 08, 2018 at 10:28:24AM +, Sergey Dyasli wrote: > On 07/11/2018 13:28, Wei Liu wrote: > > On Tue, Nov 06, 2018 at 12:07:58PM +, Sergey Dyasli wrote: > >> The size of Xen's virtual vmcs region is 4096 bytes (see comment about > >> Virtual VMCS layout in include/asm-x86/hvm/vmx/vvm

Re: [Xen-devel] [PATCH v2] x86/traps: use only one stub function for l/cstar

2018-11-09 Thread Jan Beulich
>>> On 09.11.18 at 11:46, wrote: > And place it into .text.cold. > > Requested-by: Jan Beulich > Signed-off-by: Wei Liu Reviewed-by: Jan Beulich Thanks for doing this. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.

Re: [Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread George Dunlap
On 11/9/18 10:16 AM, Juergen Gross wrote: > This email only tracks big items for xen.git tree. Please reply for items you > would like to see in 4.12 so that people have an idea what is going on and > prioritise accordingly. > > You're welcome to provide description and use cases of the feature yo

Re: [Xen-devel] [PATCH V4 3/3] x86/altp2m: fix display frozen when switching to a new view early

2018-11-09 Thread Razvan Cojocaru
On 11/9/18 12:34 PM, Jan Beulich wrote: On 08.11.18 at 19:37, wrote: >> On the first patch of the series: can it go in independently, since Jan >> is OK with it and it just got your ack? Or should I just add the ack and >> carry it over to the next version of the series? > > Well, I would ha

Re: [Xen-devel] [PATCH v8] arch/x86: Add registers to vm_event

2018-11-09 Thread Alexandru Stefan ISAILA
On 08.11.2018 20:02, Wei Liu wrote: > On Thu, Nov 08, 2018 at 07:56:29PM +0200, Razvan Cojocaru wrote: >> On 11/8/18 7:22 PM, Wei Liu wrote: >>> On Thu, Nov 08, 2018 at 05:56:07PM +0200, Razvan Cojocaru wrote: On 11/8/18 5:53 PM, Wei Liu wrote: > On Thu, Nov 08, 2018 at 05:19:48PM +0200,

Re: [Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread Juergen Gross
On 09/11/2018 11:56, George Dunlap wrote: > On 11/9/18 10:16 AM, Juergen Gross wrote: >> This email only tracks big items for xen.git tree. Please reply for items you >> would like to see in 4.12 so that people have an idea what is going on and >> prioritise accordingly. >> >> You're welcome to pro

Re: [Xen-devel] [PATCH v8] arch/x86: Add registers to vm_event

2018-11-09 Thread Wei Liu
On Fri, Nov 09, 2018 at 11:05:23AM +, Alexandru Stefan ISAILA wrote: > > > On 08.11.2018 20:02, Wei Liu wrote: > > On Thu, Nov 08, 2018 at 07:56:29PM +0200, Razvan Cojocaru wrote: > >> On 11/8/18 7:22 PM, Wei Liu wrote: > >>> On Thu, Nov 08, 2018 at 05:56:07PM +0200, Razvan Cojocaru wrote: >

Re: [Xen-devel] [PATCH v8] arch/x86: Add registers to vm_event

2018-11-09 Thread Alexandru Stefan ISAILA
On 09.11.2018 13:05, Alexandru Stefan ISAILA wrote: > > > On 08.11.2018 20:02, Wei Liu wrote: >> On Thu, Nov 08, 2018 at 07:56:29PM +0200, Razvan Cojocaru wrote: >>> On 11/8/18 7:22 PM, Wei Liu wrote: On Thu, Nov 08, 2018 at 05:56:07PM +0200, Razvan Cojocaru wrote: > On 11/8/18 5:53 PM

Re: [Xen-devel] [PATCH v2 01/11] tools/libs/toollog: Provide a default logger

2018-11-09 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2 01/11] tools/libs/toollog: Provide a default logger"): > Although actually, you can't capture stderr in a variable like this at > all.  freopen() at a later point will close the current FILE object and > create a new one, after which this logger wil

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with blkfront_remove()

2018-11-09 Thread Greg KH
On Thu, Nov 08, 2018 at 04:58:28PM -0800, Manjunath Patil wrote: > If a hot-attaching device fails inside domU[ex:negotiate_mq() returns > with ENOMEM] we clear the blkfront_info struct in talk_to_blkback() > > When we try to detach the device, blkfront_remove() tries to access > blkfront_info lea

Re: [Xen-devel] Problems building and running Xen on Hikey960

2018-11-09 Thread Julien Grall
On 08/11/2018 07:07, Matthew Daley wrote: Hi all, Hi Matthew, I'm trying to build and run Linux (Debian) on top of Xen on a Hikey960 ARM board but am having trouble. I've been following Konrad's guide on the Wiki (at https://wiki.xenproject.org/wiki/HiKey960), namely: * I have upgraded th

Re: [Xen-devel] [PATCH v3 1/4] xen/arm: initialize target

2018-11-09 Thread Julien Grall
Hi Stefano, On 06/11/2018 22:05, Stefano Stabellini wrote: Initialize variable target before passing it as a parameter. It makes the code a bit nicer and it is a safety certification requirement. M3CM Rule-9.1: The value of an object with automatic storage duration shall not be read before it h

[Xen-devel] [PATCH v2] xen: report PV capability in sysctl and use it in toolstack

2018-11-09 Thread Wei Liu
0e2c886ef ("xen: decouple HVM and IOMMU capabilities") provided a truth table for what `xl info` would report. In order to make the table work xen will need to report its PV capability. Replace cap_directio with cap_pv in libxl IDL. It is safe to do so because cap_directio has never been released.

Re: [Xen-devel] [PATCH v7 1/7] public / x86: introduce __HYPERCALL_iommu_op

2018-11-09 Thread Jan Beulich
>>> On 15.10.18 at 12:35, wrote: > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -13,6 +13,7 @@ obj-$(CONFIG_CRASH_DEBUG) += gdbstub.o > obj-y += grant_table.o > obj-y += guestcopy.o > obj-bin-y += gunzip.init.o > +obj-$(CONFIG_X86) += iommu_op.o I'm afraid I didn't notice this pl

Re: [Xen-devel] [PATCH v3 2/4] xen/arm: initialize access

2018-11-09 Thread Julien Grall
Hi Stefano, On 06/11/2018 22:05, Stefano Stabellini wrote: Initialize variable *access before returning it back to the caller. It makes the code a bit nicer and it is a safety certification requirement. M3CM Rule-9.1: The value of an object with automatic storage duration shall not be read befo

Re: [Xen-devel] [PATCH v2] xen: report PV capability in sysctl and use it in toolstack

2018-11-09 Thread Andrew Cooper
On 09/11/18 11:23, Wei Liu wrote: > 0e2c886ef ("xen: decouple HVM and IOMMU capabilities") provided a > truth table for what `xl info` would report. In order to make the > table work xen will need to report its PV capability. > > Replace cap_directio with cap_pv in libxl IDL. It is safe to do so >

Re: [Xen-devel] [PATCH v3 3/4] xen: introduce SYMBOL

2018-11-09 Thread Julien Grall
Hi Stefano, On 06/11/2018 22:05, Stefano Stabellini wrote: Introduce a macro, SYMBOL, which is a simple wrapper around RELOC_HIDE to be used everywhere symbols such as _stext and _etext are used in the code. RELOC_HIDE is needed when accessing symbols such as _stext and _etext because the C sta

[Xen-devel] Ping#2: [PATCH] pass-through: adjust pIRQ migration

2018-11-09 Thread Jan Beulich
>>> On 26.10.18 at 12:58, wrote: On 13.09.18 at 18:44, wrote: >> On Mon, Sep 10, 2018 at 07:59:16AM -0600, Jan Beulich wrote: >>> For one it is quite pointless to iterate over all pIRQ-s the domain has >>> when just one is being adjusted. Introduce hvm_migrate_pirq(). >>> >>> Additionally i

Re: [Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread George Dunlap
On 11/9/18 11:07 AM, Juergen Gross wrote: > On 09/11/2018 11:56, George Dunlap wrote: >> On 11/9/18 10:16 AM, Juergen Gross wrote: >>> This email only tracks big items for xen.git tree. Please reply for items >>> you >>> would like to see in 4.12 so that people have an idea what is going on and >>

[Xen-devel] [PATCH v9] arch/x86: Add registers to vm_event

2018-11-09 Thread Alexandru Stefan ISAILA
This patch adds a couple of regs to the vm_event that are used by the introspection. The base, limit and ar bits are compressed into a uint64_t union so as not to enlarge the vm_event. Signed-off-by: Alexandru Isaila Acked-by: Jan Beulich Acked-by: Tamas K Lengyel --- Changes since V8:

Re: [Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread Andrew Cooper
On 09/11/18 10:16, Juergen Gross wrote: > = Projects = > > == Hypervisor == > > * Improvements to domain creation (v2) > - Andrew Cooper There is one known bug which definitely needs resolving before 4.12 goes out.  Attempting to create a VM with 0 vcpus trips over a bad error path when we tr

Re: [Xen-devel] [PATCH] pass-through: adjust pIRQ migration

2018-11-09 Thread Andrew Cooper
On 10/09/18 14:59, Jan Beulich wrote: > For one it is quite pointless to iterate over all pIRQ-s the domain has > when just one is being adjusted. Introduce hvm_migrate_pirq(). > > Additionally it is bogus to migrate the pIRQ to a vCPU different from > the one the event is supposed to be posted to

Re: [Xen-devel] [PATCH v7 2/7] iommu: track reserved ranges using a rangeset

2018-11-09 Thread Jan Beulich
>>> On 15.10.18 at 12:35, wrote: > @@ -1987,28 +1986,35 @@ static int rmrr_identity_mapping(struct domain *d, > bool_t map, > if ( --mrmrr->count ) > return 0; > > -while ( base_pfn < end_pfn ) > +err = rangeset_remove_range(hd->reserved_ran

Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-09 Thread Julien Grall
Hi Stefano, On 06/11/2018 22:05, Stefano Stabellini wrote: Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it is required when comparing and subtracting pointers [1], but use it everywhere to avoid confusion. M3CM: Rule-18.2: Subtraction between pointers shall only be applied

Re: [Xen-devel] [PATCH v3 0/4] misc safety certification fixes

2018-11-09 Thread Julien Grall
On 06/11/2018 22:05, Stefano Stabellini wrote: Hi all, Hi, This short patch series fixes a few issues discovered by the safety certifications code scanner. The first two patches address simple variable initializations concerns. The third patch introduces a new macro that is used throughout

Re: [Xen-devel] [PATCH v7 3/7] x86: add xen_iommu_op to query reserved ranges

2018-11-09 Thread Jan Beulich
>>> On 15.10.18 at 12:35, wrote: > +static int get_reserved(unsigned long s, unsigned long e, void *arg) > +{ > +struct get_reserved_ctxt *ctxt = arg; > + > +if ( ctxt->nr_entries < ctxt->max_entries ) > +{ > +xen_iommu_reserved_range_t range = { > +.start_dfn = s,

[Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Juergen Gross
Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") introduced a regression for Xen guests running fully virtualized (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll hypercall with interrupts disabled in case of an interrupt (for PV guests it does). So instead of disab

Re: [Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread Andrew Cooper
On 09/11/18 11:44, Andrew Cooper wrote: > On 09/11/18 10:16, Juergen Gross wrote: >> = Projects = >> >> == Hypervisor == >> >> * Improvements to domain creation (v2) >> - Andrew Cooper > There is one known bug which definitely needs resolving before 4.12 goes > out.  Attempting to create a VM

Re: [Xen-devel] [PATCH v5 10/15] libxl_exec: Add libxl__spawn_initiate_failure

2018-11-09 Thread Anthony PERARD
On Tue, Oct 16, 2018 at 03:02:37PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v5 10/15] libxl_exec: Add > libxl__spawn_initiate_failure"): > > + * The spawn state must be Attached entry and will be Attached Failed > > + * on return. > > Attached on en

Re: [Xen-devel] [PATCH V4 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-11-09 Thread George Dunlap
On 11/1/18 2:45 PM, Razvan Cojocaru wrote: > This patch is a pre-requisite for the one fixing VGA logdirty > freezes when using altp2m. It only concerns itself with the > ranges allocation / deallocation / initialization part. While > touching the code, I've switched global_logdirty from bool_t > t

Re: [Xen-devel] [PATCH V4 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-11-09 Thread Razvan Cojocaru
On 11/9/18 2:29 PM, George Dunlap wrote: > On 11/1/18 2:45 PM, Razvan Cojocaru wrote: >> This patch is a pre-requisite for the one fixing VGA logdirty >> freezes when using altp2m. It only concerns itself with the >> ranges allocation / deallocation / initialization part. While >> touching the code

[Xen-devel] [xen-unstable-smoke test] 129698: tolerable all pass - PUSHED

2018-11-09 Thread osstest service owner
flight 129698 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129698/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH v5 07/24] hw: acpi: Generalize AML build routines

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:30 +0100 Samuel Ortiz wrote: > From: Yang Zhong > > Most of the AML build routines under acpi-build are not even > architecture specific. They can be moved to the more generic hw/acpi > folder where they could be shared across machine types and > architectures. I'd pr

Re: [Xen-devel] [PATCH v2 01/21] xen/arm: traps: Constify show_*, do_unexpected_trap and do_bug_frame parameters

2018-11-09 Thread Andrii Anisov
Hello Julien, Reviewed-by: Andrii Anisov ps. please reach me by my gmail andrii.ani...@gmail.com further, rather than epam's email. Our infra enabled 2-factor auth, and I didn't manage to make thunderbird functional any more. And outlook's web interface is nearly unusable. ANDRII ANISOV

Re: [Xen-devel] [PATCH v2 03/21] xen/arm: Remove __init from prototype

2018-11-09 Thread Andrii Anisov
Reviewed-by: Andrii Anisov ANDRII ANISOV ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v6 05/26] xen/arm: check for multiboot nodes only under /chosen

2018-11-09 Thread Julien Grall
Hi, On 02/11/2018 23:44, Stefano Stabellini wrote: Make sure to only look for multiboot compatible nodes only under /chosen, not under any other paths (depth <= 3). Signed-off-by: Stefano Stabellini --- Changes in v6: - do not proceed if fdt_get_path returns error != -FDT_ERR_NOSPACE - remov

[Xen-devel] [ovmf test] 129696: regressions - FAIL

2018-11-09 Thread osstest service owner
flight 129696 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129696/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH v6 07/26] xen/arm: don't add duplicate boot modules, introduce domU flag

2018-11-09 Thread Julien Grall
Hi Stefano, On 02/11/2018 23:44, Stefano Stabellini wrote: Don't add duplicate boot modules (same kind and same start address), they are freed later, we don't want to introduce double-free errors. Introduce a domU flag in struct bootmodule and struct bootcmdline. Set it for kernels and ramdisks

Re: [Xen-devel] [PATCH v6 08/26] xen/arm: probe domU kernels and initrds

2018-11-09 Thread Julien Grall
Hi Stefano, On 02/11/2018 23:45, Stefano Stabellini wrote: -info->initrd_bootmodule = boot_module_find_by_kind(BOOTMOD_RAMDISK); +printk("Loading Dom%d kernel from boot module @ %"PRIpaddr"\n", + info->d->domain_id, info->kernel_bootmodule->start); NIT: You probably want to u

Re: [Xen-devel] [PATCH v6 09/26] xen/arm: add start to struct bootcmdline

2018-11-09 Thread Julien Grall
Hi Stefano, On 02/11/2018 23:45, Stefano Stabellini wrote: Add a new start address field to struct bootcmdline to easily match a cmdline to the corresponding bootmodule. This is useful for debugging (not actually needed for functionalities today, but could be.) Instead of printing the index in

Re: [Xen-devel] [PATCH v6 12/26] xen/arm: introduce allocate_memory

2018-11-09 Thread Julien Grall
Hi Stefano, Most of the code is mine, so it is hard to review it :). Although, I have a few comments below. On 02/11/2018 23:45, Stefano Stabellini wrote: Introduce an allocate_memory function able to allocate memory for DomUs and map it at the right guest addresses, according to the guest m

Re: [Xen-devel] [PATCH V4 3/3] x86/altp2m: fix display frozen when switching to a new view early

2018-11-09 Thread Razvan Cojocaru
On 11/8/18 8:14 PM, George Dunlap wrote: > On 11/01/2018 02:45 PM, Razvan Cojocaru wrote: > ...here and... > >> + >> int p2m_set_ioreq_server(struct domain *d, >> unsigned int flags, >> struct hvm_ioreq_server *s) >> @@ -994,12 +1033,12 @@ int p

Re: [Xen-devel] [PATCH v5 01/24] hw: i386: Decouple the ACPI build from the PC machine type

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:24 +0100 Samuel Ortiz wrote: > ACPI tables are platform and machine type and even architecture > agnostic, and as such we want to provide an internal ACPI API that > only depends on platform agnostic information. > > For the x86 architecture, in order to build ACPI tabl

Re: [Xen-devel] [PATCH] xen: remove size limit of privcmd-buf mapping interface

2018-11-09 Thread Boris Ostrovsky
On 11/9/18 2:03 AM, Juergen Gross wrote: > Ping? > > Jan's remark regarding de-privileged qemu is no issue as the hypercall > node is being closed by the de-privilege library function. Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:25 +0100 Samuel Ortiz wrote: > This is going to be needed by the Hardware-reduced ACPI routines. > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Samuel Ortiz the patch is probably misplaced withing series, if there is an e

Re: [Xen-devel] [PATCH v5 09/24] hw: i386: Move PCI host definitions to pci_host.h

2018-11-09 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:32 +0100 Samuel Ortiz wrote: > The PCI hole properties are not pc or i386 specific. They belong to the > PCI host header instead. > > Signed-off-by: Samuel Ortiz > --- > include/hw/i386/pc.h | 5 - > include/hw/pci/pci_host.h | 6 ++ > 2 files changed, 6

Re: [Xen-devel] [PATCH v6 24/26] xen/vpl011: buffer out chars when the backend is xen

2018-11-09 Thread Julien Grall
Hi Stefano, On 02/11/2018 23:45, Stefano Stabellini wrote: To avoid mixing the output of different domains on the console, buffer the output chars and print line by line. Unless the domain has input from the serial, in which case we want to print char by char for a smooth user experience. The s

Re: [Xen-devel] [PATCH v6 26/26] xen/arm: split domain_build.c

2018-11-09 Thread Julien Grall
Hi Stefano, On 02/11/2018 23:45, Stefano Stabellini wrote: domain_build.c is too large. Move all the ACPI specific device tree generating functions from domain_build.c to acpi/domain_build.c. Signed-off-by: Stefano Stabellini --- Changes in v6: - fix license Changes in v4: - rename acpi_dt

[Xen-devel] [PATCH] x86/hvm: Unify hvm_event_pending()'s API with the !CONFIG_HVM version

2018-11-09 Thread Andrew Cooper
No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Jun Nakajima CC: Kevin Tian CC: Boris Ostrovsky CC: Suravee Suthikulpanit CC: Brian Woods --- xen/arch/x86/hvm/svm/svm.c| 5 ++--- xen/arch/x86/hvm/vmx/vmx.c| 2 +- xen/include/asm-x86/hvm/hvm.h

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-09 Thread Andrii Anisov
Hello Julien, I just wonder, do you plan to upstream the patch below? Andrii Anisov On 29/10/2018 10:06, Andrii Anisov wrote: > Hello Julien, Hi, > > Sorry for the previous email sent as html. Don't worry. I didn't notice it :). > > > On 27.10.18 15:14, Andrii Anisov wrote: diff --g

[Xen-devel] [PATCH] x86/badpage: Fix badpage->order overflow

2018-11-09 Thread Andrew Cooper
For order 32 or more, the shift will truncate. Spotted by Coverity. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu --- xen/common/page_alloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 1aec13e.

Re: [Xen-devel] [PATCH] x86/badpage: Fix badpage->order overflow

2018-11-09 Thread Wei Liu
On Fri, Nov 09, 2018 at 02:42:55PM +, Andrew Cooper wrote: > For order 32 or more, the shift will truncate. Spotted by Coverity. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org http

Re: [Xen-devel] [PATCH] x86/hvm: Unify hvm_event_pending()'s API with the !CONFIG_HVM version

2018-11-09 Thread Wei Liu
On Fri, Nov 09, 2018 at 02:42:27PM +, Andrew Cooper wrote: > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-d

Re: [Xen-devel] [PATCH V4 3/3] x86/altp2m: fix display frozen when switching to a new view early

2018-11-09 Thread Razvan Cojocaru
On 11/9/18 4:19 PM, Razvan Cojocaru wrote: > (XEN) Xen call trace: > (XEN)[] vcpu_sleep_sync+0x40/0x71 > (XEN)[] domain.c#do_domain_pause+0x33/0x4f > (XEN)[] domain_pause+0x25/0x27 > (XEN)[] hap_track_dirty_vram+0x2b3/0x491 > (XEN)[] dm.c#dm_op+0x472/0xd46 > (XEN)[] do_dm_op

Re: [Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread Julien Grall
Hi Juergen, On 09/11/2018 10:16, Juergen Gross wrote: This email only tracks big items for xen.git tree. Please reply for items you would like to see in 4.12 so that people have an idea what is going on and prioritise accordingly. You're welcome to provide description and use cases of the featu

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Boris Ostrovsky
On 11/9/18 7:04 AM, Juergen Gross wrote: > Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") > introduced a regression for Xen guests running fully virtualized > (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll > hypercall with interrupts disabled in case of an interr

Re: [Xen-devel] [PATCH] x86/hvm: Unify hvm_event_pending()'s API with the !CONFIG_HVM version

2018-11-09 Thread Boris Ostrovsky
On 11/9/18 9:42 AM, Andrew Cooper wrote: > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Wei Liu > CC: Jun Nakajima > CC: Kevin Tian > CC: Boris Ostrovsky > CC: Suravee Suthikulpanit > CC: Brian Woods > --- Reviewed-by: Boris Ostrovsky ___

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Sander Eikelenboom
On 09/11/18 13:04, Juergen Gross wrote: > Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") > introduced a regression for Xen guests running fully virtualized > (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll > hypercall with interrupts disabled in case of an interru

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Juergen Gross
On 09/11/2018 16:02, Sander Eikelenboom wrote: > On 09/11/18 13:04, Juergen Gross wrote: >> Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") >> introduced a regression for Xen guests running fully virtualized >> (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll >> hyp

[Xen-devel] [PATCH 1/3] x86/dom0: Avoid using 1G superpages if shadowing may be necessary

2018-11-09 Thread Andrew Cooper
The shadow code doesn't support 1G superpages, and will hand #PF[RSVD] back to guests. For dom0's with 512GB of RAM or more (and subject to the P2M alignment), Xen's domain builder might use 1G superpages. Avoid using 1G superpages (falling back to 2M superpages instead) if there is a reasonable

[Xen-devel] [PATCH 2/3 Xen-4.9] x86/dom0: Fix shadowing of PV guests with 2M superpages

2018-11-09 Thread Andrew Cooper
This is a straight backport of c/s 28d9a9a2d41759b9e5163037b759ac557aea767c but with a different justification. Dom0 may have superpages (e.g. initial P2M), and may be shadowed (e.g. PV-L1TF). Because of this incorrect check, when PV superpages are disallowed (which is the security supported conf

[Xen-devel] [PATCH 0/3] x86: Fixes to shadowing dom0

2018-11-09 Thread Andrew Cooper
It turns out there are some real bugs attempting to shadow dom0, and it is because of these that XSA-273 went out with `pv-l1tf=` defaulting to not shadowing dom0. They aren't security issues themselves. Patch 1 is a general problem with dom0 and 1G superpages, and wants to be taken onto all rele

[Xen-devel] [PATCH 3/3 Xen-4.8] x86/dom0: Fix shadowing of PV guests with 2M superpages

2018-11-09 Thread Andrew Cooper
This is a minimal backport of pieces of: c/s 28d9a9a2d41759b9e5163037b759ac557aea767c c/s 4c5d78a10dc89427140a50a1df5a0b8e9f073e82 to fix a PV shadowing problem which I hadn't anticipated at the time these fixes were first accepted. Having opt_allow_superpage disabled causes guest_supports_sup

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Sander Eikelenboom
On 09/11/18 16:20, Juergen Gross wrote: > On 09/11/2018 16:02, Sander Eikelenboom wrote: >> On 09/11/18 13:04, Juergen Gross wrote: >>> Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") >>> introduced a regression for Xen guests running fully virtualized >>> (HVM or PVH mode). The Xen h

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Juergen Gross
On 09/11/2018 16:29, Sander Eikelenboom wrote: > On 09/11/18 16:20, Juergen Gross wrote: >> On 09/11/2018 16:02, Sander Eikelenboom wrote: >>> On 09/11/18 13:04, Juergen Gross wrote: Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") introduced a regression for Xen guests runni

Re: [Xen-devel] [PATCH V4 3/3] x86/altp2m: fix display frozen when switching to a new view early

2018-11-09 Thread Razvan Cojocaru
On 11/9/18 4:19 PM, Razvan Cojocaru wrote: > On 11/8/18 8:14 PM, George Dunlap wrote: >> On 11/01/2018 02:45 PM, Razvan Cojocaru wrote: >> ...here and... >> >>> + >>> int p2m_set_ioreq_server(struct domain *d, >>> unsigned int flags, >>> struct h

[Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

2018-11-09 Thread Andrew Cooper
On 06/11/18 13:44, Jan Beulich wrote: On 05.11.18 at 12:21, wrote: >> --- a/xen/include/xen/lib/x86/cpuid.h >> +++ b/xen/include/xen/lib/x86/cpuid.h >> @@ -20,6 +20,21 @@ struct cpuid_leaf >> uint32_t a, b, c, d; >> }; >> >> +static inline void cpuid_leaf(uint32_t leaf, struct cpuid_l

[Xen-devel] [xen-4.7-testing baseline-only test] 75583: tolerable FAIL

2018-11-09 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75583 xen-4.7-testing real [real] http://osstest.xensource.com/osstest/logs/75583/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 6 xen-install fail baseline unt

Re: [Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

2018-11-09 Thread Andrew Cooper
On 06/11/18 16:31, Roger Pau Monné wrote: > On Mon, Nov 05, 2018 at 11:21:03AM +, Andrew Cooper wrote: >> This will shortly be wanted by the userspace emulator harnesses as well. >> >> Consolidate the cpuid{,_count}_leaf() helpers beside the structure >> definition, >> rather than having them

[Xen-devel] [PATCH] x86: eliminate pv_post_outb_hook

2018-11-09 Thread Wei Liu
Use amd_acpi_c1e_quirk and amd_check_disable_c1e instead. Requested-by: Jan Beulich Signed-off-by: Wei Liu --- xen/arch/x86/cpu/amd.c | 6 +- xen/arch/x86/pv/emul-priv-op.c | 11 +-- xen/include/asm-x86/io.h | 2 -- 3 files changed, 6 insertions(+), 13 deletions(-)

[Xen-devel] [xen-unstable-smoke test] 129702: tolerable all pass - PUSHED

2018-11-09 Thread osstest service owner
flight 129702 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129702/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH] x86: eliminate pv_post_outb_hook

2018-11-09 Thread Andrew Cooper
On 09/11/18 16:29, Wei Liu wrote: > Use amd_acpi_c1e_quirk and amd_check_disable_c1e instead. > > Requested-by: Jan Beulich > Signed-off-by: Wei Liu Acked-by: Andrew Cooper Good riddance to unnecessary function pointers, especially in a retpoline world. ___

[Xen-devel] [distros-debian-jessie test] 75584: regressions - FAIL

2018-11-09 Thread Platform Team regression test user
flight 75584 distros-debian-jessie real [real] http://osstest.xensource.com/osstest/logs/75584/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-i386-jessie-netboot-pvgrub 11 guest-start fail REGR. vs. 75562 Tests which did no

Re: [Xen-devel] [PATCH v3 0/4] misc safety certification fixes

2018-11-09 Thread Stefano Stabellini
On Fri, 9 Nov 2018, Julien Grall wrote: > On 06/11/2018 22:05, Stefano Stabellini wrote: > > Hi all, > > Hi, > > > This short patch series fixes a few issues discovered by the safety > > certifications code scanner. The first two patches address simple > > variable initializations concerns. The t

Re: [Xen-devel] Problems building and running Xen on Hikey960

2018-11-09 Thread Omkar Bolla
HI Mathues, I checked your log and crashes in xen and linux. Do following things to fix or move further. On Fri, Nov 9, 2018 at 4:52 PM Julien Grall wrote: > > > On 08/11/2018 07:07, Matthew Daley wrote: > > Hi all, > > Hi Matthew, > > > > > I'm trying to build and run Linux (Debian) on top of

Re: [Xen-devel] [PATCH v5 15/15] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

2018-11-09 Thread Anthony PERARD
On Tue, Oct 16, 2018 at 04:28:55PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v5 15/15] libxl: Re-implement > domain_suspend_device_model using libxl__ev_qmp"): > > +if (rc) > > +goto error; > > + > > +libxl__carefd_begin(); > > +ev->cfd = libxl__carefd_opened(C

Re: [Xen-devel] [PATCH v5 15/15] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

2018-11-09 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v5 15/15] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp"): > On Tue, Oct 16, 2018 at 04:28:55PM +0100, Ian Jackson wrote: > > Does this statefile fd really need to be a carefd ? Is it a pipe or a > > file ? If it is a file, is it of nontri

Re: [Xen-devel] [PATCH 6/6] x86/emul: dedup hvmemul_cpuid() and pv_emul_cpuid()

2018-11-09 Thread Andrew Cooper
On 06/11/18 16:16, Jan Beulich wrote: On 06.11.18 at 16:52, wrote: >> On 06/11/18 15:38, Jan Beulich wrote: >> On 05.11.18 at 12:21, wrote: They are identical, so provide a single x86emul_cpuid() instead. As x86_emulate() now only uses the ->cpuid() hook for real CPUID >>

[Xen-devel] [PATCH 2/2] guest/pvh: special case the low 1MB

2018-11-09 Thread Roger Pau Monne
When running as a PVH guest Xen only special cases the trampoline code in the low 1MB, without also reserving the space used by the relocated metadata or the trampoline stack. Fix this by always reserving the low 1MB regardless of whether Xen is running as a guest or natively. Reported-by: Sergey

[Xen-devel] [PATCH 0/2] guest/pvh: fixes for idle memory scrubbing

2018-11-09 Thread Roger Pau Monne
Hello, The patch to perform memory scrubbing by the idle CPUs has revealed two latent bugs when running Xen as a PVH guest which this series attempts to fix. This should allow the PV shim to be functional again. The series can be found at: git://xenbits.xen.org/people/royger/xen.git fix_memory_s

  1   2   >