Re: [Xen-devel] null scheduler bug

2018-09-13 Thread Dario Faggioli
On Wed, 2018-09-12 at 16:03 -0700, Stefano Stabellini wrote: > Hi Dario, > > Milan has just found a bug in the null scheduler: apparently it is > not > possible to start a VM again after it has been destroyed. > > My initial suspicion was that the VM wasn't properly destroyed, but I > asked Milan

Re: [Xen-devel] [PATCH v9] new config option vtsc_tolerance_khz to avoid TSC emulation

2018-09-13 Thread Olaf Hering
Andrew, Lars, this patch was not applied yet, even after a few "pings". I think it needs an approval from Andrew before it can go in, unless the bug has to be fixed in some other way. Please take some time to review that change. Thanks, Olaf Am Wed, 1 Aug 2018 18:17:47 +0200 schrieb Olaf Herin

Re: [Xen-devel] [PATCH v4 1/3] x86/msr: Dispatch Xen and Viridian MSRs from guest_{wr, rd}msr()

2018-09-13 Thread Sergey Dyasli
On Wed, 2018-09-12 at 13:00 +0100, Andrew Cooper wrote: > Despite the complicated diff in {svm,vmx}_msr_write_intercept(), it is just > the 0 case losing one level of indentation, as part of removing the call to > wrmsr_hypervisor_regs(). > > The case blocks in guest_{wr,rd}msr() use raw numbers,

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-13 Thread Sergey Dyasli
On Wed, 2018-09-12 at 11:23 +0100, Andrew Cooper wrote: > On 12/09/18 10:46, Sergey Dyasli wrote: > > On Wed, 2018-09-12 at 10:12 +0100, Andrew Cooper wrote: > > > On 12/09/18 09:29, Sergey Dyasli wrote: > > > > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > > > > > Rename them to guest_

Re: [Xen-devel] [PATCH v7 2/6] iommu: make use of type-safe DFN and MFN in exported functions

2018-09-13 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 12:30:24PM +0100, Paul Durrant wrote: > This patch modifies the declaration of the entry points to the IOMMU > sub-system to use dfn_t and mfn_t in place of unsigned long. A subsequent > patch will similarly modify the methods in the iommu_ops structure. > > Signed-off-by:

Re: [Xen-devel] [PATCH v7 3/6] iommu: push use of type-safe DFN and MFN into iommu_ops

2018-09-13 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 12:30:25PM +0100, Paul Durrant wrote: > This patch modifies the methods in struct iommu_ops to use type-safe DFN > and MFN. This follows on from the prior patch that modified the functions > exported in xen/iommu.h. > > Signed-off-by: Paul Durrant > Reviewed-by: Wei Liu >

Re: [Xen-devel] [PATCH v7 4/6] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-13 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 12:30:26PM +0100, Paul Durrant wrote: > This patch removes the implicit domain_crash() from iommu_map(), > unmap_page() and iommu_iotlb_flush() and turns them into straightforward > wrappers that check the existence of the relevant iommu_op and call > through to it. This mak

Re: [Xen-devel] null scheduler bug

2018-09-13 Thread Dario Faggioli
Hi, So, first of all: 1. use plaintext, not HTML 2. don't drop the xen-devel list (and other Cc-s) when replying. :-) That being said... On Thu, 2018-09-13 at 09:38 +0200, Milan Boberic wrote: > Hi Dario, > yes passtrhough is involved. > Ok. > This is everything I did so far: > > I impleme

Re: [Xen-devel] [PATCH v7 4/6] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 13 September 2018 09:22 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Kevin Tian ; > Stefano Stabellini ; Wei Liu ; > Konrad Rzeszutek Wilk ; George Dunlap > ; Andrew Cooper > ; Ian Jackson ; Tim > (Xen.org) ; Julien Grall ; J

Re: [Xen-devel] [PATCH v7 5/6] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-13 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 12:30:27PM +0100, Paul Durrant wrote: > ...for some uses of get_page_from_gfn(). > > There are many occurences of the following pattern in the code: > > q = ? P2M_ALLOC : P2M_UNSHARE; > page = get_page_from_gfn(d, gfn, &p2mt, q); > > if ( p2m_is_paging(p2mt)

Re: [Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Tian, Kevin [mailto:kevin.t...@intel.com] > Sent: 13 September 2018 07:53 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Wei Liu ; Jan Beulich ; George > Dunlap > Subject: RE: [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops > > > From: Paul

Re: [Xen-devel] [PATCH v6 13/14] x86: add iommu_ops to modify and flush IOMMU mappings

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Tian, Kevin [mailto:kevin.t...@intel.com] > Sent: 13 September 2018 07:41 > To: Paul Durrant ; 'Jan Beulich' > > Cc: Stefano Stabellini ; Wei Liu > ; Konrad Rzeszutek Wilk ; > Andrew Cooper ; Tim (Xen.org) > ; George Dunlap ; Julien Grall > ; xen-devel ; Ian >

Re: [Xen-devel] [PATCH v6 09/14] mm / iommu: include need_iommu() test in iommu_use_hap_pt()

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Tian, Kevin [mailto:kevin.t...@intel.com] > Sent: 13 September 2018 07:24 > To: Jan Beulich ; Paul Durrant > > Cc: Suravee Suthikulpanit ; Julien Grall > ; Andrew Cooper ; > George Dunlap ; Nakajima, Jun > ; Stefano Stabellini ; xen- > devel > Subject: RE: [PA

Re: [Xen-devel] [PATCH v7 5/6] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 13 September 2018 09:30 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Stefano Stabellini > ; Wei Liu ; Konrad Rzeszutek > Wilk ; George Dunlap > ; Andrew Cooper > ; Ian Jackson ; Tim > (Xen.org) ; Julien Grall ; Jan Beulich >

[Xen-devel] null scheduler bug

2018-09-13 Thread Milan Boberic
Hi, I implemented Xen Hypervisor 4.9.2 on UltraZed-EG board with carrier card following these steps: 1.) installed petalinux on Ubuntu 16.04 2.) dowloaded UltraZed-EG IO Carrier Card - PetaLinux 2018.2 Standard BSP 3.) created project: petalinux-create -t project –s 4.) copied xen-overlay.dtsi

Re: [Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 12:30:28PM +0100, Paul Durrant wrote: > This patch adds a new method to the VT-d IOMMU implementation to find the > MFN currently mapped by the specified DFN along with a wrapper function > in generic IOMMU code to call the implementation if it exists. > > This patch also c

Re: [Xen-devel] [PATCH v6 13/14] x86: add iommu_ops to modify and flush IOMMU mappings

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 08:41, wrote: >> From: Paul Durrant >> Sent: Wednesday, September 12, 2018 4:02 PM >> >> > I also have another more general concern: Allowing the guest to >> > manipulate its IOMMU page tables means that it can deliberately >> > shatter large pages, growing the overall memory

Re: [Xen-devel] [PATCH] pass-through: adjust pIRQ migration

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 07:56, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Monday, September 10, 2018 9:59 PM >> >> For one it is quite pointless to iterate over all pIRQ-s the domain has >> when just one is being adjusted. Introduce hvm_migrate_pirq(). > > it's migrate_pirq bein

Re: [Xen-devel] [PATCH v2 4/4] x86/HVM: prefill cache with PDPTEs when possible

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 08:30, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, September 11, 2018 9:16 PM >> >> Since strictly speaking it is incorrect for guest_walk_tables() to read >> L3 entries during PAE page walks, try to overcome this where possible by > > can you ela

[Xen-devel] [ovmf test] 127561: all pass - PUSHED

2018-09-13 Thread osstest service owner
flight 127561 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127561/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 52664c525223a36e5cb9b141b11dec413908b1dd baseline version: ovmf 7c41b8135de692ea45334

Re: [Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 13 September 2018 09:50 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Kevin Tian ; Wei > Liu ; George Dunlap ; Jan > Beulich > Subject: Re: [Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to > iommu_ops > > On Wed, Se

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 12 September 2018 13:15 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Kevin Tian ; > Stefano Stabellini ; Wei Liu ; > Suravee Suthikulpanit ; Julien Grall > ; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v7 1/6] iommu: intro

[Xen-devel] Fwd: [CentOS-virt] We need a patch in the kernel for tpm

2018-09-13 Thread George Dunlap
Juergen / Boris -- got this "ping" from someone using CentOS. Looks like the original submitter abandoned it -- do you guys want to pick it up? -George -- Forwarded message - From: Dag Nygren Date: Thu, Sep 13, 2018 at 10:41 AM Subject: [CentOS-virt] We need a patch in the kern

[Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-13 Thread Jan Beulich
The function does two translations in one go for a single guest access. Any failure of the first translation step (guest linear -> guest physical), resulting in #PF, ought to take precedence over any failure of the second step (guest physical -> host physical). Bail out of the loop early solely whe

[Xen-devel] [distros-debian-wheezy test] 75212: trouble: blocked/broken

2018-09-13 Thread Platform Team regression test user
flight 75212 distros-debian-wheezy real [real] http://osstest.xensource.com/osstest/logs/75212/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] [PATCH 1/3] xen/vcpu: Rename the common interfaces for consistency

2018-09-13 Thread Roger Pau Monné
On Thu, Sep 06, 2018 at 08:25:32PM +0100, Andrew Cooper wrote: > The vcpu functions are far less consistent than the domain side of things, and > in particular, has vcpu_destroy() for architecture specific functionality. > > Perform the following renames: > > * alloc_vcpu => vcpu_create >

[Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
This patch adds a new method to the VT-d IOMMU implementation to find the MFN currently mapped by the specified DFN along with a wrapper function in generic IOMMU code to call the implementation if it exists. NOTE: This patch only adds a Xen-internal interface. This will be used by a subsequ

[Xen-devel] [PATCH v8 4/7] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-13 Thread Paul Durrant
This patch removes the implicit domain_crash() from iommu_map(), unmap_page() and iommu_iotlb_flush() and turns them into straightforward wrappers that check the existence of the relevant iommu_op and call through to it. This makes them usable by PV IOMMU code to be delivered in future patches. Thi

[Xen-devel] [PATCH v8 0/6] paravirtual IOMMU pre-requisites and clean-up

2018-09-13 Thread Paul Durrant
This series contains pre-requisites and clean-up needed for paravirtual IOMMU support. I have separated these patches to avoid further delaying their application whilst I re-work the implementation of paravirtual IOMMU after review of v6 of the series. Several of them already have all necessary ac

[Xen-devel] [PATCH v8 2/7] iommu: make use of type-safe DFN and MFN in exported functions

2018-09-13 Thread Paul Durrant
This patch modifies the declaration of the entry points to the IOMMU sub-system to use dfn_t and mfn_t in place of unsigned long. A subsequent patch will similarly modify the methods in the iommu_ops structure. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Reviewed-by

[Xen-devel] [PATCH v8 6/7] vtd: add missing check for shared EPT...

2018-09-13 Thread Paul Durrant
...in intel_iommu_unmap_page(). This patch also includes some non-functional modifications in intel_iommu_map_page(). Signed-off-by: Paul Durrant --- Cc: Wei Liu Cc: Kevin Tian Cc: Jan Beulich Cc: George Dunlap v8: - New in v8. (Split from the next patch in the series as requested by Ke

[Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
...meaning 'device DMA frame number' i.e. a frame number mapped in the IOMMU (rather than the MMU) and hence used for DMA address translation. This patch is a largely cosmetic change that substitutes the terms 'gfn' and 'gaddr' for 'dfn' and 'daddr' in all the places where the frame number or addr

[Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
This patch adds a new method to the VT-d IOMMU implementation to find the MFN currently mapped by the specified DFN along with a wrapper function in generic IOMMU code to call the implementation if it exists. This patch also cleans up the initializers in intel_iommu_map_page() and uses array-style

[Xen-devel] [PATCH v8 3/7] iommu: push use of type-safe DFN and MFN into iommu_ops

2018-09-13 Thread Paul Durrant
This patch modifies the methods in struct iommu_ops to use type-safe DFN and MFN. This follows on from the prior patch that modified the functions exported in xen/iommu.h. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monne Acked-by: Jan Beulic

[Xen-devel] [PATCH v8 5/7] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-13 Thread Paul Durrant
...for some uses of get_page_from_gfn(). There are many occurrences of the following pattern in the code: q = ? P2M_ALLOC : P2M_UNSHARE; page = get_page_from_gfn(d, gfn, &p2mt, q); if ( p2m_is_paging(p2mt) ) { if ( page ) put_page(page); p2m_mem_pagi

Re: [Xen-devel] [PATCH 2/3] xen/vcpu: Introduce vcpu_destroy()

2018-09-13 Thread Roger Pau Monné
On Thu, Sep 06, 2018 at 08:25:33PM +0100, Andrew Cooper wrote: > Like _domain_destroy(), this will eventually idempotently free all parts of a > struct vcpu. > > While breaking apart the failure path of vcpu_create(), rework the codeflow to > be in a line at the end of the function for clarity. >

[Xen-devel] [libvirt test] 127559: regressions - FAIL

2018-09-13 Thread osstest service owner
flight 127559 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/127559/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123814 build-amd64-libvirt

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 11:13 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > > Subject: [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi- > page case > > The function does two translations in one

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 13:06, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 September 2018 11:13 >> >> @@ -544,7 +574,7 @@ static void *hvmemul_map_linear_addr( >> struct hvm_emulate_ctxt *hvmemul_ctxt) >> { >> struct vcpu *curr = current; >> -void *err, *mapping;

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 12:39 > To: Paul Durrant > Cc: Andrew Cooper ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for > multi-page case > > >>> On 13.09.1

Re: [Xen-devel] [PATCH] xentrace: handle sparse cpu ids correctly in xen trace buffer handling

2018-09-13 Thread George Dunlap
On 08/30/2018 10:28 AM, Juergen Gross wrote: > On 30/08/18 10:26, Jan Beulich wrote: > On 30.08.18 at 09:52, wrote: >>> @@ -202,7 +202,7 @@ static int alloc_trace_bufs(unsigned int pages) >>> * Allocate buffers for all of the cpus. >>> * If any fails, deallocate what you have so fa

Re: [Xen-devel] RFE: Detect NUMA misconfigurations and prevent machine freezes

2018-09-13 Thread Dario Faggioli
On Wed, 2018-09-12 at 17:13 +0200, Dario Faggioli wrote: > On Thu, 2018-08-30 at 14:01 +1000, Steven Haigh wrote: > > > > Add the CPUs: > > (XEN) Adding cpu 12 to runqueue 0 > > (XEN) First cpu on runqueue, activating > > (XEN) Removing cpu 12 from runqueue 0 > > (XEN) Adding cpu 13 to runqueue 0

[Xen-devel] [PATCH] xen: sched/Credit2: fix bug when moving CPUs between two Credit2 cpupools

2018-09-13 Thread Dario Faggioli
Whether or not a CPU is assigned to a runqueue (and, if yes, to which one) within a Credit2 scheduler instance must be both a per-cpu and per-scheduler instance one. In fact, when we move a CPU between cpupools, we first setup its per-cpu data in the new pool, and then cleanup its per-cpu data fro

[Xen-devel] [linux-linus test] 127551: regressions - FAIL

2018-09-13 Thread osstest service owner
flight 127551 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127551/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

Re: [Xen-devel] [PATCH v4 1/3] x86/msr: Dispatch Xen and Viridian MSRs from guest_{wr, rd}msr()

2018-09-13 Thread Jan Beulich
>>> On 12.09.18 at 14:00, wrote: > Despite the complicated diff in {svm,vmx}_msr_write_intercept(), it is just > the 0 case losing one level of indentation, as part of removing the call to > wrmsr_hypervisor_regs(). > > The case blocks in guest_{wr,rd}msr() use raw numbers, partly for consistency

Re: [Xen-devel] [PATCH v3 2/3] x86/viridan: Clean up Viridian MSR infrastructure

2018-09-13 Thread Jan Beulich
>>> On 11.09.18 at 20:56, wrote: > Rename the functions to guest_{rd,wr}msr_viridian() for consistency, and > because the _regs() suffix isn't very appropriate. > > Update them to take a vcpu pointer rather than presuming that they act on > current, which is safe for all implemented operations, a

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 09:57, wrote: > With this being rebased on top of v4 1/3: > > Reviewed-by: Sergey Dyasli Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [seabios test] 127565: tolerable FAIL - PUSHED

2018-09-13 Thread osstest service owner
flight 127565 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/127565/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 127226 test-amd64-amd64-xl-qemuu-ws16-amd64 17 g

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 12:31, wrote: > ...meaning 'device DMA frame number' i.e. a frame number mapped in the IOMMU > (rather than the MMU) and hence used for DMA address translation. > > This patch is a largely cosmetic change that substitutes the terms 'gfn' > and 'gaddr' for 'dfn' and 'daddr' in a

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 13:46 > To: Paul Durrant > Cc: Suravee Suthikulpanit ; Julien Grall > ; Wei Liu ; Kevin Tian > ; Stefano Stabellini ; xen- > devel > Subject: Re: [PATCH v8 1/7] iommu: introduce the concept of DF

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 13 September 2018 14:09 > To: 'Jan Beulich' > Cc: Kevin Tian ; Stefano Stabellini > ; Wei Liu ; Julien Grall > ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenpr

Re: [Xen-devel] [PATCH v8 5/7] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 12:31, wrote: > --- a/xen/arch/x86/hvm/emulate.c > +++ b/xen/arch/x86/hvm/emulate.c > @@ -353,33 +353,20 @@ static int hvmemul_do_io_buffer( > > static int hvmemul_acquire_page(unsigned long gmfn, struct page_info **page) > { > -struct domain *curr_d = current->domain; >

Re: [Xen-devel] [PATCH v3] Change timestamps representation for keyhandlers

2018-09-13 Thread Dario Faggioli
On Wed, 2018-09-12 at 20:03 +0300, Andrii Anisov wrote: > From: Andrii Anisov > > For different keyhandlers, replace a hex with delimiter > representation > of time to PRI_stime which is decimal ns currently. > > Signed-off-by: Andrii Anisov > Reviewed-by: Dario Faggioli Regards, Dario -- <>

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 12:31, wrote: > This patch adds a new method to the VT-d IOMMU implementation to find the > MFN currently mapped by the specified DFN along with a wrapper function > in generic IOMMU code to call the implementation if it exists. Would you mind clarifying what the use of this is

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:29 > To: Paul Durrant > Cc: George Dunlap ; Wei Liu > ; Kevin Tian ; xen-devel de...@lists.xenproject.org> > Subject: Re: [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops > > >>> On 13

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 15:09, wrote: > Do you want me to move the page size definitions and re-submit with > the other things fixed up? Irrespective of your subsequent reply, re-submission perhaps wants to wait until you've clarified with ARM folks which of the #define-s need to move, and which ones

Re: [Xen-devel] [PATCH v8 5/7] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:23 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; Wei Liu ; George Dunlap > ; Ian Jackson ; Stefano > Stabellini ; xen-devel de...@lists.xenproject.org>; Konrad Rzeszutek Wilk > ; T

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 15:34, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 September 2018 14:29 >> >> >>> On 13.09.18 at 12:31, wrote: >> > This patch adds a new method to the VT-d IOMMU implementation to find >> the >> > MFN currently mapped by the specified DFN along with a w

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:41 > To: Paul Durrant > Cc: Suravee Suthikulpanit ; Julien Grall > ; Wei Liu ; Kevin Tian > ; Stefano Stabellini ; xen- > devel > Subject: RE: [PATCH v8 1/7] iommu: introduce the concept of DF

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:45 > To: Paul Durrant > Cc: George Dunlap ; Wei Liu > ; Kevin Tian ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops > > >>> On 13

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 15:50, wrote: > Ok. I'll spell it out in the header if you think it is non-obvious. Obvious or not - do we _have_ any such outer locking in place right now? Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lis

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:57 > To: Paul Durrant > Cc: George Dunlap ; Wei Liu > ; Kevin Tian ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops > > >>> On 13

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 13 September 2018 14:47 > To: 'Jan Beulich' ; Julien Grall > Cc: xen-devel ; Kevin Tian > ; Stefano Stabellini ; Wei > Liu ; Suravee Suthikulpanit > > Subject: Re: [X

Re: [Xen-devel] [PATCH v2] x86/mm: Suppresses vm_events caused by page-walks

2018-09-13 Thread Jan Beulich
>>> On 12.09.18 at 11:47, wrote: > The original version of the patch emulated the current instruction > (which, as a side-effect, emulated the page-walk as well), however we > need finer-grained control. We want to emulate the page-walk, but still > get an EPT violation event if the current instru

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 16:04, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 September 2018 14:57 >> To: Paul Durrant >> Cc: George Dunlap ; Wei Liu >> ; Kevin Tian ; xen-devel > de...@lists.xenproject.org> >> Subject: RE: [PATCH v8 7/7] vtd: add loo

[Xen-devel] [ovmf baseline-only test] 75211: trouble: blocked/broken

2018-09-13 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75211 ovmf real [real] http://osstest.xensource.com/osstest/logs/75211/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 15:51 > To: Paul Durrant > Cc: George Dunlap ; Wei Liu > ; Kevin Tian ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops > > >>> On 13

[Xen-devel] [PATCH 1/4] x86_emulator: Add PHONY uninstall target

2018-09-13 Thread Petre Pircalabu
The missing uninstall target breaks the top 'tools' uninstall target. Signed-off-by: Petre Pircalabu --- tools/tests/x86_emulator/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/tests/x86_emulator/Makefile b/tools/tests/x86_emulator/Makefile index e8a3e90..8696a65 100644 -

[Xen-devel] [PATCH 3/4] x86: Add map_domain_pages_global

2018-09-13 Thread Petre Pircalabu
Create a single mapping for multiple domain pages. Signed-off-by: Petre Pircalabu --- tools/libxc/xc_vm_event.c | 2 +- xen/arch/x86/domain_page.c| 22 ++ xen/include/xen/domain_page.h | 9 + 3 files changed, 32 insertions(+), 1 deletion(-) diff --git a/too

[Xen-devel] [PATCH 4/4] vm_event: Add support for multi-page ring buffer

2018-09-13 Thread Petre Pircalabu
In high throughput introspection scenarios where lots of monitor vm_events are generated, the ring buffer can fill up before the monitor application gets a chance to handle all the requests thus blocking other vcpus which will have to wait for a slot to become available. This patch adds support fo

[Xen-devel] [PATCH 0/4] Add support for multi-page vm_event ring buffer

2018-09-13 Thread Petre Pircalabu
This series enables the vm_event ring to use buffers larger than 4K. Petre Pircalabu (4): x86_emulator: Add PHONY uninstall target tools/libxc: Define VM_EVENT type x86: Add map_domain_pages_global vm_event: Add support for multi-page ring buffer tools/libxc/include/xenctrl.h |

[Xen-devel] [PATCH 2/4] tools/libxc: Define VM_EVENT type

2018-09-13 Thread Petre Pircalabu
Define the type for each of the supported vm_event rings (paging, monitor and sharing) and replace the ring param field with this type. Signed-off-by: Petre Pircalabu --- tools/libxc/xc_monitor.c| 2 +- tools/libxc/xc_private.h| 6 +-- tools/libxc/xc_vm_event.c | 90 +

Re: [Xen-devel] [PATCH v3 10/16] x86/mm: put nested p2m code under CONFIG_HVM

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 01:06:38AM -0600, Jan Beulich wrote: > >>> On 04.09.18 at 18:15, wrote: > > @@ -149,6 +149,7 @@ static void p2m_teardown_hostp2m(struct domain *d) > > } > > } > > > > +#ifdef CONFIG_HVM > > static void p2m_teardown_nestedp2m(struct domain *d) > > { > > unsign

Re: [Xen-devel] [DRBD-user] [PATCH] xen-blkback: Switch to closed state after releasing the backing device

2018-09-13 Thread Roger Pau Monné
On Mon, Sep 10, 2018 at 06:18:31PM +0200, Valentin Vidic wrote: > On Mon, Sep 10, 2018 at 05:00:58PM +0200, Roger Pau Monné wrote: > > I can try to take a look at this and attempt to make sure the state is > > only changed to closed in blkback _after_ the device has been > > released, but it might

Re: [Xen-devel] null scheduler bug

2018-09-13 Thread Milan Boberic
I'm sorry for html and dropping xen-devel and dropping other CCs, missed to read the rules. I tried 4.10 version and checked for commits you asked in earlier reply. 2b936ea7b "xen: RCU: avoid busy waiting until the end of grace period." 38ad8151f "xen: RCU: don't let a CPU with a callback go idle.

[Xen-devel] [xen-unstable test] 127557: regressions - trouble: broken/fail/pass

2018-09-13 Thread osstest service owner
flight 127557 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/127557/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm broken test-amd64-amd64-xl-qemuu-dmre

[Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
This patch adds a new method to the VT-d IOMMU implementation to find the MFN currently mapped by the specified DFN along with a wrapper function in generic IOMMU code to call the implementation if it exists. This patch also cleans up the initializers in intel_iommu_map_page() and uses array-style

[Xen-devel] [PATCH v9 3/7] iommu: push use of type-safe DFN and MFN into iommu_ops

2018-09-13 Thread Paul Durrant
This patch modifies the methods in struct iommu_ops to use type-safe DFN and MFN. This follows on from the prior patch that modified the functions exported in xen/iommu.h. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monne Acked-by: Jan Beulic

[Xen-devel] [PATCH v9 4/7] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-13 Thread Paul Durrant
This patch removes the implicit domain_crash() from iommu_map(), unmap_page() and iommu_iotlb_flush() and turns them into straightforward wrappers that check the existence of the relevant iommu_op and call through to it. This makes them usable by PV IOMMU code to be delivered in future patches. Thi

[Xen-devel] [PATCH v9 2/7] iommu: make use of type-safe DFN and MFN in exported functions

2018-09-13 Thread Paul Durrant
This patch modifies the declaration of the entry points to the IOMMU sub-system to use dfn_t and mfn_t in place of unsigned long. A subsequent patch will similarly modify the methods in the iommu_ops structure. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Reviewed-by

[Xen-devel] [PATCH v9 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
...meaning 'device DMA frame number' i.e. a frame number mapped in the IOMMU (rather than the MMU) and hence used for DMA address translation. This patch is a largely cosmetic change that substitutes the terms 'gfn' and 'gaddr' for 'dfn' and 'daddr' in all the places where the frame number or addr

[Xen-devel] [PATCH v9 5/7] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-13 Thread Paul Durrant
...for some uses of get_page_from_gfn(). There are many occurrences of the following pattern in the code: q = ? P2M_ALLOC : P2M_UNSHARE; page = get_page_from_gfn(d, gfn, &p2mt, q); if ( p2m_is_paging(p2mt) ) { if ( page ) put_page(page); p2m_mem_pagi

[Xen-devel] [PATCH v9 6/7] vtd: add missing check for shared EPT...

2018-09-13 Thread Paul Durrant
...in intel_iommu_unmap_page(). This patch also includes some non-functional modifications in intel_iommu_map_page(). Signed-off-by: Paul Durrant --- Cc: Wei Liu Cc: Kevin Tian Cc: Jan Beulich Cc: George Dunlap v8: - New in v8. (Split from the next patch in the series as requested by Ke

[Xen-devel] [PATCH v9 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
This patch adds a new method to the VT-d IOMMU implementation to find the MFN currently mapped by the specified DFN along with a wrapper function in generic IOMMU code to call the implementation if it exists. NOTE: This patch only adds a Xen-internal interface. This will be used by a subsequ

[Xen-devel] [PATCH v9 0/6] paravirtual IOMMU pre-requisites and clean-up

2018-09-13 Thread Paul Durrant
This series contains pre-requisites and clean-up needed for paravirtual IOMMU support. I have separated these patches to avoid further delaying their application whilst I re-work the implementation of paravirtual IOMMU after review of v6 of the series. Several of them already have all necessary ac

Re: [Xen-devel] [PATCH] xen/netfront: don't bug in case of too many frags

2018-09-13 Thread David Miller
From: Juergen Gross Date: Tue, 11 Sep 2018 09:04:48 +0200 > Commit 57f230ab04d291 ("xen/netfront: raise max number of slots in > xennet_get_responses()") raised the max number of allowed slots by one. > This seems to be problematic in some configurations with netback using > a larger MAX_SKB_FRAG

Re: [Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
This patch is stale. Sorry for the noise. Paul > -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 13 September 2018 16:21 > To: xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Wei Liu ; > Kevin Tian ; Jan Beulich ; George > Dunlap > Subject: [PATCH v

Re: [Xen-devel] [PATCH v9 0/6] paravirtual IOMMU pre-requisites and clean-up

2018-09-13 Thread Paul Durrant
This should clearly say 0/7 rather then 0/6. Apologies. Paul > -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 13 September 2018 16:21 > To: xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Andrew Cooper > ; George Dunlap ; Ian > Jackson ; Jan Beulich

Re: [Xen-devel] [PATCH v3 09/16] x86: provide stubs, declarations and macros in hvm.h

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 01:02:02AM -0600, Jan Beulich wrote: > >>> On 04.09.18 at 18:15, wrote: > > @@ -675,6 +678,100 @@ static inline bool altp2m_vcpu_emulate_ve(struct vcpu > > *v) > > d_->arch.hvm.pi_ops.vcpu_block(v_); \ > > }) > > > > +#else /* CONFIG_HVM */

Re: [Xen-devel] [PATCH v3 11/16] x86/mm: put HVM only code under CONFIG_HVM

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 03:27:37PM -0600, Tamas K Lengyel wrote: > On Tue, Sep 4, 2018, 10:29 AM Wei Liu wrote: > > > Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. > > Put these components under CONFIG_HVM. This further requires putting > > one of the vm event under CONFIG_

Re: [Xen-devel] [PATCH v3 10/16] x86/mm: put nested p2m code under CONFIG_HVM

2018-09-13 Thread Wei Liu
On Thu, Sep 06, 2018 at 05:20:53PM +0100, George Dunlap wrote: > On 09/04/2018 05:15 PM, Wei Liu wrote: > > These functions are only useful for nested hvm, which isn't enabled > > when CONFIG_HVM is false. > > > > Enclose relevant code and fields in CONFIG_HVM. Guard np2m_schedule > > with nestedh

Re: [Xen-devel] [PATCH v3 16/16] xen: decouple HVM and IOMMU capabilities

2018-09-13 Thread Ian Jackson
Wei Liu writes ("[PATCH v3 16/16] xen: decouple HVM and IOMMU capabilities"): > HVM and IOMMU are two distinct hardware features, yet they were > bundled together in sysctl and xl's output. > > Decouple them on sysctl level. On toolstack level we still need to > maintain a sensible semantics for `

Re: [Xen-devel] [PATCH v3 14/16] x86: expose CONFIG_HVM

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 01:15:05AM -0600, Jan Beulich wrote: > >>> On 04.09.18 at 18:15, wrote: > > Signed-off-by: Wei Liu > > --- > > v3: longer text > > v2: use tab to indent > > > > Haven't added a dependency on PV_SHIM_EXCLUSIVE because agreement is > > not yet reached. > > Hmm, but then I

Re: [Xen-devel] [PATCH v3 10/16] x86/mm: put nested p2m code under CONFIG_HVM

2018-09-13 Thread George Dunlap
On 09/13/2018 04:46 PM, Wei Liu wrote: > On Thu, Sep 06, 2018 at 05:20:53PM +0100, George Dunlap wrote: >> On 09/04/2018 05:15 PM, Wei Liu wrote: >>> These functions are only useful for nested hvm, which isn't enabled >>> when CONFIG_HVM is false. >>> >>> Enclose relevant code and fields in CONFIG_

Re: [Xen-devel] [PATCH v3 01/16] x86: change name of parameter for various invlpg functions

2018-09-13 Thread George Dunlap
On 09/04/2018 05:15 PM, Wei Liu wrote: > They all incorrectly named a parameter virtual address while it should > have been linear address. > > Requested-by: Andrew Cooper > Signed-off-by: Wei Liu > Acked-by: Jan Beulich > Reviewed-by: Kevin Tian > Acked-by: Boris Ostrovsky Acked-by: George

[Xen-devel] [xen-unstable baseline-only test] 75210: trouble: blocked/broken

2018-09-13 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75210 xen-unstable real [real] http://osstest.xensource.com/osstest/logs/75210/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64

Re: [Xen-devel] [PATCH] tools/tests: allow depriv-fd-checker to build with really old Linux headers

2018-09-13 Thread Wei Liu
On Fri, Aug 31, 2018 at 01:02:42AM -0600, Jan Beulich wrote: > Assuming it was intentional for this test utility, other than most other > ones, to always be built, I think it would be nice if it didn't fail to > build on really old distros just because of the lack of a TUNGETIFF > definition. > >

Re: [Xen-devel] [PATCH] tools: correct tools/tests/depriv/Makefile

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 11:16:54AM +0200, Juergen Gross wrote: > tools/tests/depriv/Makefile directly builds the target program from > its C-source. This is problematic when an incremental build is needed > after a header the program is depending on has been modified: in this > case all headers are

Re: [Xen-devel] [PATCH v3 11/16] x86/mm: put HVM only code under CONFIG_HVM

2018-09-13 Thread Tamas K Lengyel
On Thu, Sep 13, 2018 at 9:43 AM Wei Liu wrote: > > On Fri, Sep 07, 2018 at 03:27:37PM -0600, Tamas K Lengyel wrote: > > On Tue, Sep 4, 2018, 10:29 AM Wei Liu wrote: > > > > > Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. > > > Put these components under CONFIG_HVM. This fur

[Xen-devel] [PATCH v4 2/7] x86: provide stubs, declarations and macros in hvm.h

2018-09-13 Thread Wei Liu
Make sure hvm_enabled evaluate to false then provide necessary things to make xen build when !CONFIG_HVM. Signed-off-by: Wei Liu --- v4: 1. Add more comments. 2. Reshuffle sections a bit. 3. Don't use gcc extension, use comma expression instead. 4. Adjustment to functions prototypes. --- xen/inc

  1   2   >