Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Oleksandr Andrushchenko
Hi, Hans! On 09/09/2018 01:31 PM, Hans Verkuil wrote: Hi Oleksandr, Sorry for the delay in reviewing, I missed this patch until you pinged me, and I was very busy after that as well. I do appreciate you spending time on this! On 07/31/2018 11:31 AM, Oleksandr Andrushchenko wrote: From: Olek

[Xen-devel] [ovmf test] 127461: all pass - PUSHED

2018-09-10 Thread osstest service owner
flight 127461 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127461/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4b2dc555d8a67e715d8fafab4c9131791d31a788 baseline version: ovmf 40a7b235e4359b4e2eb4d

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
Hi Oleksandr, On 09/10/2018 09:16 AM, Oleksandr Andrushchenko wrote: > Hi, Hans! > > On 09/09/2018 01:31 PM, Hans Verkuil wrote: >> Hi Oleksandr, >> >> Sorry for the delay in reviewing, I missed this patch until you pinged me, >> and >> I was very busy after that as well. > I do appreciate you s

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
On 09/10/2018 07:59 AM, Oleksandr Andrushchenko wrote: > Hi, Hans! > > On 09/09/2018 01:42 PM, Hans Verkuil wrote: >> On 09/04/2018 08:56 AM, Oleksandr Andrushchenko wrote: >>> On 09/03/2018 06:25 PM, Hans Verkuil wrote: Hi Oleksandr, On 09/03/2018 12:16 PM, Oleksandr Andrushchenko

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Oleksandr Andrushchenko
On 09/10/2018 10:53 AM, Hans Verkuil wrote: Hi Oleksandr, On 09/10/2018 09:16 AM, Oleksandr Andrushchenko wrote: Hi, Hans! On 09/09/2018 01:31 PM, Hans Verkuil wrote: Hi Oleksandr, Sorry for the delay in reviewing, I missed this patch until you pinged me, and I was very busy after that as we

[Xen-devel] [linux-3.18 test] 127455: regressions - FAIL

2018-09-10 Thread osstest service owner
flight 127455 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/127455/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 16 guest-localmigrate/x10 fail REGR. vs. 12729

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Oleksandr Andrushchenko
On 09/10/2018 11:14 AM, Hans Verkuil wrote: On 09/10/2018 07:59 AM, Oleksandr Andrushchenko wrote: Hi, Hans! On 09/09/2018 01:42 PM, Hans Verkuil wrote: On 09/04/2018 08:56 AM, Oleksandr Andrushchenko wrote: On 09/03/2018 06:25 PM, Hans Verkuil wrote: Hi Oleksandr, On 09/03/2018 12:16 PM, O

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
On 09/10/2018 10:24 AM, Oleksandr Andrushchenko wrote: > On 09/10/2018 10:53 AM, Hans Verkuil wrote: >> Hi Oleksandr, >> >> On 09/10/2018 09:16 AM, Oleksandr Andrushchenko wrote: I suspect that you likely will want to support such sources eventually, so it pays to design this with that

Re: [Xen-devel] [PATCH] xen: Fix inconsistent callers of panic()

2018-09-10 Thread Jan Beulich
>>> On 07.09.18 at 18:42, wrote: > [Merging part of the later conversion] > > Reducing the number of lines printed from a panic/backtrace may be a > good thing, but please can we not conflate it with this which is fix an > API inconsistency. Well, later on in the conversion I've also agreed that

Re: [Xen-devel] [PATCH 1/5] x86/hvm: Switch hvm_allow_get_param() to use a whitelist

2018-09-10 Thread Jan Beulich
>>> On 07.09.18 at 20:18, wrote: > On 07/09/18 09:55, Jan Beulich wrote: > On 06.09.18 at 17:21, wrote: >>> On 06/09/18 09:56, Paul Durrant wrote: > @@ -4390,9 +4411,6 @@ static int hvmop_get_param( > if ( copy_from_guest(&a, arg, 1) ) > return -EFAULT; > > -

Re: [Xen-devel] [PATCH v2 2/5] x86: Handle the Xen MSRs via the new guest_{rd, wr}msr() infrastructure

2018-09-10 Thread Jan Beulich
>>> On 07.09.18 at 18:01, wrote: > On 07/09/18 16:47, Jan Beulich wrote: >>> On 07.03.18 at 19:58, wrote: > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -185,6 +185,10 @@ int guest_rdmsr(const struct vcpu *v, uint32_t msr, > uint64_t *val) > } >

Re: [Xen-devel] [PATCH] xen: remove unnecessary condition check before kfree

2018-09-10 Thread Juergen Gross
On 08/09/18 16:18, zhong jiang wrote: > kfree has taken null pointer into account. So just remove the > condition check before kfree. > > Signed-off-by: zhong jiang > --- > drivers/xen/xen-acpi-processor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/xen-

Re: [Xen-devel] [PATCH V3 1/2] Drivers/PCI: Export pcie_has_flr() interface

2018-09-10 Thread Pasi Kärkkäinen
Hi, On Sun, Sep 09, 2018 at 10:33:02PM -0400, Sinan Kaya wrote: > On 9/9/2018 2:59 PM, Pasi Kärkkäinen wrote: > >I noticed pcie_has_flr() has been recently exported in upstream Linux: > >https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2d2917f7747805a1f4188672f308d82a8

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Oleksandr Andrushchenko
On 09/10/2018 12:04 PM, Hans Verkuil wrote: On 09/10/2018 10:24 AM, Oleksandr Andrushchenko wrote: On 09/10/2018 10:53 AM, Hans Verkuil wrote: Hi Oleksandr, On 09/10/2018 09:16 AM, Oleksandr Andrushchenko wrote: I suspect that you likely will want to support such sources eventually, so it

Re: [Xen-devel] [PATCH v3 2/5] x86: use PDEP/PEXT for maddr/direct-map-offset conversion when available

2018-09-10 Thread Jan Beulich
>>> On 07.09.18 at 18:17, wrote: > On 17/08/18 10:38, Jan Beulich wrote: > On 17.08.18 at 10:59, wrote: >>> On 17/08/2018 08:21, Jan Beulich wrote: --- a/xen/include/asm-x86/asm_defns.h +++ b/xen/include/asm-x86/asm_defns.h @@ -186,6 +186,20 @@ void ret_from_intr(void);

Re: [Xen-devel] [PATCH 2/5] x86/idle: re-arrange dead-idle handling

2018-09-10 Thread Jan Beulich
>>> On 07.09.18 at 19:08, wrote: > On 01/08/18 15:31, Jan Beulich wrote: >> In order to be able to wake parked CPUs from default_dead_idle(), the >> function must not itself loop. Move the loop into play_dead(), and use >> play_dead() as well on the AP boot error path. >> >> Furthermore, not the l

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
On 09/10/2018 11:52 AM, Oleksandr Andrushchenko wrote: > On 09/10/2018 12:04 PM, Hans Verkuil wrote: >> On 09/10/2018 10:24 AM, Oleksandr Andrushchenko wrote: >>> On 09/10/2018 10:53 AM, Hans Verkuil wrote: Hi Oleksandr, On 09/10/2018 09:16 AM, Oleksandr Andrushchenko wrote: >> >> >

[Xen-devel] [distros-debian-sid test] 75189: trouble: blocked/broken

2018-09-10 Thread Platform Team regression test user
flight 75189 distros-debian-sid real [real] http://osstest.xensource.com/osstest/logs/75189/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] [PATCH] xen: Fix inconsistent callers of panic()

2018-09-10 Thread Julien Grall
Hi Andrew, On 30/08/18 13:31, Andrew Cooper wrote: Callers are inconsistent with whether they pass a newline to panic(), including adjacent calls in the same function using different styles. painc() not expecting a newline is inconsistent with most other printing functions, which is most likely

Re: [Xen-devel] [PATCH] xen/sched: Re-position the domain_update_node_affinity() call during vcpu construction

2018-09-10 Thread Julien Grall
Hi Andrew, On 06/09/18 15:01, Andrew Cooper wrote: alloc_vcpu()'s call to domain_update_node_affinity() has existed for a decade, but its effort is mostly wasted. alloc_vcpu() is called in a loop for each vcpu, bringing them into existence. The values of the affinity masks are still default, wh

Re: [Xen-devel] [PATCH v8 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-09-10 Thread Julien Grall
Hi Roger, On 07/09/18 10:07, Roger Pau Monne wrote: Introduce a new dom0-iommu=map-inclusive generic option that supersedes iommu_inclusive_mapping. The previous behavior is preserved and the option should only be enabled by default on Intel hardware. Signed-off-by: Roger Pau Monné Reviewed-by

Re: [Xen-devel] [PATCH v3] xen/balloon: add runtime control for scrubbing ballooned out pages

2018-09-10 Thread Juergen Gross
On 07/09/18 18:49, Marek Marczykowski-Górecki wrote: > Scrubbing pages on initial balloon down can take some time, especially > in nested virtualization case (nested EPT is slow). When HVM/PVH guest is > started with memory= significantly lower than maxmem=, all the extra > pages will be scrubbed b

Re: [Xen-devel] [PATCH v8 6/6] x86/iommu: add map-reserved dom0-iommu option to map reserved memory ranges

2018-09-10 Thread Julien Grall
Hi Roger, On 07/09/18 10:07, Roger Pau Monne wrote: Several people have reported hardware issues (malfunctioning USB controllers) due to iommu page faults on Intel hardware. Those faults are caused by missing RMRR (VTd) entries in the ACPI tables. Those can be worked around on VTd hardware by ma

Re: [Xen-devel] [PATCH] xentrace: handle sparse cpu ids correctly in xen trace buffer handling

2018-09-10 Thread Juergen Gross
On 30/08/18 11:28, Juergen Gross wrote: > On 30/08/18 10:26, Jan Beulich wrote: > On 30.08.18 at 09:52, wrote: >>> @@ -202,7 +202,7 @@ static int alloc_trace_bufs(unsigned int pages) >>> * Allocate buffers for all of the cpus. >>> * If any fails, deallocate what you have so far and

Re: [Xen-devel] [PATCH] xen/ARM+sched: Don't opencode %pv in printk()'s

2018-09-10 Thread Julien Grall
Hi, On 30/08/18 13:50, Andrew Cooper wrote: No functional change. Signed-off-by: Andrew Cooper I have committed the patch. Cheers, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/lis

Re: [Xen-devel] [PATCH] xentrace: handle sparse cpu ids correctly in xen trace buffer handling

2018-09-10 Thread Jan Beulich
>>> On 10.09.18 at 13:34, wrote: > On 30/08/18 11:28, Juergen Gross wrote: >> On 30/08/18 10:26, Jan Beulich wrote: >> On 30.08.18 at 09:52, wrote: @@ -202,7 +202,7 @@ static int alloc_trace_bufs(unsigned int pages) * Allocate buffers for all of the cpus. * If any f

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Oleksandr Andrushchenko
On 09/10/2018 02:09 PM, Hans Verkuil wrote: On 09/10/2018 11:52 AM, Oleksandr Andrushchenko wrote: On 09/10/2018 12:04 PM, Hans Verkuil wrote: On 09/10/2018 10:24 AM, Oleksandr Andrushchenko wrote: On 09/10/2018 10:53 AM, Hans Verkuil wrote: Hi Oleksandr, On 09/10/2018 09:16 AM, Oleksandr An

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Hans Verkuil
On 09/10/2018 01:49 PM, Oleksandr Andrushchenko wrote: > On 09/10/2018 02:09 PM, Hans Verkuil wrote: >> On 09/10/2018 11:52 AM, Oleksandr Andrushchenko wrote: >>> On 09/10/2018 12:04 PM, Hans Verkuil wrote: On 09/10/2018 10:24 AM, Oleksandr Andrushchenko wrote: > On 09/10/2018 10:53 AM, Ha

[Xen-devel] [PATCH v19 03/13] x86/hvm: Introduce hvm_save_cpu_ctxt_one func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V14: - Move all free fields to the initializer - Add blank line to before the return - Move v->pause_flags check to the save_one function. --- xe

[Xen-devel] [PATCH v19 00/13] x86/domctl: Save info for one vcpu instance

2018-09-10 Thread Alexandru Isaila
Hi all, This patch series addresses the ideea of saving data from a single vcpu instance. First it starts by adding *save_one functions, then it introduces a handler for the new save_one* funcs and makes use of it in the hvm_save and hvm_save_one funcs. The final patches are used for clean up an

[Xen-devel] [PATCH v19 08/13] x86/hvm: Introduce lapic_save_hidden_one

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since v15: - Drop struct vlapic *s. --- xen/arch/x86/hvm/vlapic.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/xen/arch/x8

[Xen-devel] [PATCH v19 04/13] x86/hvm: Introduce hvm_save_cpu_xsave_states_one

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V14: - Remove err init - Add blank line ahead of return - Move xsave_enabled() check to the save_one func. --- xen/arch/x86/hvm/hvm.c | 47 ++

[Xen-devel] [PATCH v19 11/13] x86/domctl: Use hvm_save_vcpu_handler

2018-09-10 Thread Alexandru Isaila
This patch is aimed on using the new save_one fuctions in the hvm_save Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V17: - Remove double ; - Move struct vcpu *v to reduce scope - Remove stray lines. --- xen/arch/x86/hvm/save.c | 26

[Xen-devel] [PATCH v19 09/13] x86/hvm: Introduce lapic_save_regs_one func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since v15: - Drop struct vlapic *s. --- xen/arch/x86/hvm/vlapic.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/xen/

[Xen-devel] v4.19-rc3, bug in __gnttab_unmap_refs_async with HVM domU

2018-09-10 Thread Olaf Hering
While preparing another variant of the fix for the bug in disable_hotplug_cpu, this crash happend for me while starting my HVM domU a second time. dom0 runs Xen 4.7.6. I guess it crashed while it did shutdown the domU running a xenlinux based kernel. Olaf [ 8114.320383] BUG: unable to handle k

[Xen-devel] [PATCH v19 02/13] x86/hvm: Introduce hvm_save_tsc_adjust_one() func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V13: - Moved tsc_adjust to the initializer. --- xen/arch/x86/hvm/hvm.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/xen/arc

[Xen-devel] [PATCH v19 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-09-10 Thread Alexandru Isaila
This patch is focused on moving changing hvm_save_one() to save one typecode from one vcpu and now that the save functions get data from a single vcpu we can pause the specific vcpu instead of the domain. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V15: -

[Xen-devel] [PATCH v19 05/13] x86/hvm: Introduce hvm_save_cpu_msrs_one func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Paul Durrant Reviewed-by: Jan Beulich --- Changes since V14: - Remove err init - Add blank line ahead of return. --- xen/arch/x86/hvm/hvm.c | 106 +++-

[Xen-devel] [PATCH v19 12/13] x86/hvm: Remove redundant save functions

2018-09-10 Thread Alexandru Isaila
This patch removes the redundant save functions and renames the save_one* to save. It then changes the domain param to vcpu in the save funcs and adapts print messages in order to match the format of the other save related messages. Signed-off-by: Alexandru Isaila --- Changes since V18:

[Xen-devel] [PATCH v19 07/13] x86/hvm: Introduce viridian_save_vcpu_ctxt_one() func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Paul Durrant --- Changes since V14: - Moved all the operations in the initializer. --- xen/arch/x86/hvm/viridian.c | 30 +++--- 1 file changed, 19 insertions(+), 11 de

[Xen-devel] [PATCH v19 10/13] x86/hvm: Add handler for save_one funcs

2018-09-10 Thread Alexandru Isaila
Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V14: - Change handler name from hvm_save_one_handler to hvm_save_vcpu_handler. --- xen/arch/x86/cpu/mcheck/vmce.c | 1 + xen/arch/x86/emul-i8254.c | 2 +- xen/arch/x86/hvm/hpet.c| 2 +- xen/arch/x86

[Xen-devel] [PATCH v19 06/13] x86/hvm: Introduce hvm_save_mtrr_msr_one func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila i Reviewed-by: Jan Beulich --- Changes since v16: - Address style comments. --- xen/arch/x86/hvm/mtrr.c | 80 ++--- 1 file changed, 43 insertions(+), 37 deletions(-) di

[Xen-devel] [PATCH v19 01/13] x86/cpu: Introduce vmce_save_vcpu_ctxt_one() func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V11: - Removed the memset and added init with {}. --- xen/arch/x86/cpu/mcheck/vmce.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-)

Re: [Xen-devel] [DRBD-user] [PATCH] xen-blkback: Switch to closed state after releasing the backing device

2018-09-10 Thread Lars Ellenberg
On Sat, Sep 08, 2018 at 09:34:32AM +0200, Valentin Vidic wrote: > On Fri, Sep 07, 2018 at 07:14:59PM +0200, Valentin Vidic wrote: > > In fact the first one is the original code path before I modified > > blkback. The problem is it gets executed async from workqueue so > > it might not always run b

[Xen-devel] v4.19-rc3, wrong pageflags in dom0

2018-09-10 Thread Olaf Hering
After reboot I tried to start my HVM domU, this is what I get in dom0: Welcome to SUSE Linux Enterprise Server 12 SP2 (x86_64) - Kernel 4.19.321-default-bug1106594 (hvc0). stein-schneider login: (XEN) HVM1 save: CPU (XEN) HVM1 save: PIC (XEN) HVM1 save: IOAPIC (XEN) HVM1 save: LAPIC (XEN) HV

Re: [Xen-devel] [PATCH v2 08/13] optee: add support for RPC SHM buffers

2018-09-10 Thread Julien Grall
Hi Volodymyr, On 03/09/18 17:54, Volodymyr Babchuk wrote: OP-TEE usually uses the same idea with command buffers (see previous commit) to issue RPC requests. Problem is that initially it has no buffer, where it can write request. So the first RPC request it makes is special: it requests NW to al

Re: [Xen-devel] [PATCH 0/1] cameraif: Add ABI for para-virtualized

2018-09-10 Thread Oleksandr Andrushchenko
Hi, Laurent! On 09/10/2018 03:48 PM, Laurent Pinchart wrote: Hi Oleksandr, Thank you for the patch. On Tuesday, 31 July 2018 12:31:41 EEST Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Hello! At the moment Xen [1] already supports some virtual multimedia features [2] such as

[Xen-devel] [libvirt test] 127467: regressions - FAIL

2018-09-10 Thread osstest service owner
flight 127467 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/127467/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123814 build-amd64-libvirt

[Xen-devel] [PATCH v6 00/16] Add support for Hygon Dhyana Family 18h processor

2018-09-10 Thread Pu Wen
As a new x86 CPU Vendor, Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture between AMD and Haiguang Information Technology Co., Ltd., and aims at providing high performance x86 processor for China server market. The first generation Hygon's processor(Dhyana) originates from AMD techno

Re: [Xen-devel] [PATCH 1/1] cameraif: add ABI for para-virtual camera

2018-09-10 Thread Oleksandr Andrushchenko
On 09/10/2018 03:26 PM, Hans Verkuil wrote: On 09/10/2018 01:49 PM, Oleksandr Andrushchenko wrote: On 09/10/2018 02:09 PM, Hans Verkuil wrote: On 09/10/2018 11:52 AM, Oleksandr Andrushchenko wrote: On 09/10/2018 12:04 PM, Hans Verkuil wrote: On 09/10/2018 10:24 AM, Oleksandr Andrushchenko wro

[Xen-devel] [PATCH v6 12/16] x86/xen: Add Hygon Dhyana support to Xen

2018-09-10 Thread Pu Wen
To make Xen works functionally on Hygon platforms, reuse AMD's Xen support code path for Hygon Dhyana CPU. There are six core performance events counters per thread, so there are six MSRs for these counters(0-5). Also there are four legacy PMC MSRs, they are alias of the counters(0-3). In this ve

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-09-10 Thread Jan Beulich
>>> On 31.08.18 at 10:43, wrote: On 31.08.18 at 10:29, wrote: >> --- a/xen/Kconfig.debug >> +++ b/xen/Kconfig.debug >> @@ -11,6 +11,13 @@ config DEBUG >> >>You probably want to say 'N' here. >> >> +config DEBUG_INFO >> +bool "Compile Xen with debug info" >> +default y >>

Re: [Xen-devel] [DRBD-user] [PATCH] xen-blkback: Switch to closed state after releasing the backing device

2018-09-10 Thread Valentin Vidic
On Mon, Sep 10, 2018 at 02:45:31PM +0200, Lars Ellenberg wrote: > On Sat, Sep 08, 2018 at 09:34:32AM +0200, Valentin Vidic wrote: > > On Fri, Sep 07, 2018 at 07:14:59PM +0200, Valentin Vidic wrote: > > > In fact the first one is the original code path before I modified > > > blkback. The problem i

Re: [Xen-devel] [PATCH 0/1] cameraif: Add ABI for para-virtualized

2018-09-10 Thread Laurent Pinchart
Hi Oleksandr, Thank you for the patch. On Tuesday, 31 July 2018 12:31:41 EEST Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Hello! > > At the moment Xen [1] already supports some virtual multimedia > features [2] such as virtual display, sound. It supports keyboards, > poi

Re: [Xen-devel] [PATCH v19 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-09-10 Thread Jan Beulich
>>> On 10.09.18 at 14:36, wrote: > --- a/xen/arch/x86/hvm/save.c > +++ b/xen/arch/x86/hvm/save.c > @@ -155,6 +155,11 @@ int hvm_save_one(struct domain *d, unsigned int > typecode, unsigned int instance, > if ( !ctxt.data ) > return -ENOMEM; > > +if ( hvm_sr_handlers[typecode].

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-09-10 Thread Jan Beulich
>>> On 10.09.18 at 15:21, wrote: On 31.08.18 at 10:43, wrote: > On 31.08.18 at 10:29, wrote: >>> --- a/xen/Kconfig.debug >>> +++ b/xen/Kconfig.debug >>> @@ -11,6 +11,13 @@ config DEBUG >>> >>> You probably want to say 'N' here. >>> >>> +config DEBUG_INFO >>> + bool "Compile

Re: [Xen-devel] [PATCH v19 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-09-10 Thread Isaila Alexandru
On Mon, 2018-09-10 at 07:25 -0600, Jan Beulich wrote: > > > > On 10.09.18 at 14:36, wrote: > > > > --- a/xen/arch/x86/hvm/save.c > > +++ b/xen/arch/x86/hvm/save.c > > @@ -155,6 +155,11 @@ int hvm_save_one(struct domain *d, unsigned > > int typecode, unsigned int instance, > > if ( !ctxt.data

Re: [Xen-devel] [PATCH v19 12/13] x86/hvm: Remove redundant save functions

2018-09-10 Thread Isaila Alexandru
On Mon, 2018-09-10 at 15:36 +0300, Alexandru Isaila wrote: > This patch removes the redundant save functions and renames the > save_one* to save. It then changes the domain param to vcpu in the > save funcs and adapts print messages in order to match the format of > the > other save related message

Re: [Xen-devel] [PATCH v19 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-09-10 Thread Jan Beulich
>>> On 10.09.18 at 15:29, wrote: > On Mon, 2018-09-10 at 07:25 -0600, Jan Beulich wrote: >> > > > On 10.09.18 at 14:36, wrote: >> > >> > --- a/xen/arch/x86/hvm/save.c >> > +++ b/xen/arch/x86/hvm/save.c >> > @@ -155,6 +155,11 @@ int hvm_save_one(struct domain *d, unsigned >> > int typecode, unsig

Re: [Xen-devel] [PATCH v19 12/13] x86/hvm: Remove redundant save functions

2018-09-10 Thread Jan Beulich
>>> On 10.09.18 at 15:33, wrote: > On Mon, 2018-09-10 at 15:36 +0300, Alexandru Isaila wrote: >> This patch removes the redundant save functions and renames the >> save_one* to save. It then changes the domain param to vcpu in the >> save funcs and adapts print messages in order to match the forma

Re: [Xen-devel] [PATCH] xen: remove unnecessary condition check before kfree

2018-09-10 Thread zhong jiang
On 2018/9/10 17:52, Juergen Gross wrote: > On 08/09/18 16:18, zhong jiang wrote: >> kfree has taken null pointer into account. So just remove the >> condition check before kfree. >> >> Signed-off-by: zhong jiang >> --- >> drivers/xen/xen-acpi-processor.c | 2 +- >> 1 file changed, 1 insertion(+),

Re: [Xen-devel] [PATCH v19 12/13] x86/hvm: Remove redundant save functions

2018-09-10 Thread Isaila Alexandru
On Mon, 2018-09-10 at 07:42 -0600, Jan Beulich wrote: > > > > On 10.09.18 at 15:33, wrote: > > > > On Mon, 2018-09-10 at 15:36 +0300, Alexandru Isaila wrote: > > > This patch removes the redundant save functions and renames the > > > save_one* to save. It then changes the domain param to vcpu in

[Xen-devel] [PATCH] pass-through: adjust pIRQ migration

2018-09-10 Thread Jan Beulich
For one it is quite pointless to iterate over all pIRQ-s the domain has when just one is being adjusted. Introduce hvm_migrate_pirq(). Additionally it is bogus to migrate the pIRQ to a vCPU different from the one the event is supposed to be posted to - if anything, it might be worth considering no

[Xen-devel] [PATCH v4] x86/HVM: don't #GP/#SS on wrapping virt->linear translations

2018-09-10 Thread Jan Beulich
Real hardware wraps silently in most cases, so we should behave the same. Also split real and VM86 mode handling, as the latter really ought to have limit checks applied. Signed-off-by: Jan Beulich --- v4: Re-base. v3: Restore 32-bit wrap check for AMD. v2: Extend to non-64-bit modes. Reduce 64-b

[Xen-devel] [PATCH] x86/mm: re-indent after "re-arrange get_page_from_le() vs pv_l1tf_check_le()"

2018-09-10 Thread Jan Beulich
That earlier change introduced two "else switch ()" constructs which now get converted back to "normal" style (indentation). To limit indentation depth, a conditional gets inverted in ptwr_emulated_update(). No functional change intended. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich

Re: [Xen-devel] Xen 4.10.x and PCI passthrough

2018-09-10 Thread Roger Pau Monné
On Fri, Sep 07, 2018 at 07:23:43PM +0200, Andreas Kinzler wrote: > Hello Roger, > > in August 2017, I reported a problem with PCI passthrough and MSI interrupts > (https://lists.xenproject.org/archives/html/xen-devel/2017-08/msg01433.html). > > That report lead to some patches for Xen and qemu. >

[Xen-devel] [PATCH] x86: improve vCPU selection in pagetable_dying()

2018-09-10 Thread Jan Beulich
Rather than unconditionally using vCPU 0, use the current vCPU if the subject domain is the current one. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -858,7 +858,7 @@ void pagetable_dying(struct domain *d, p ASSERT(paging_mode_shadow(d)); -

Re: [Xen-devel] [PATCH v2 09/13] optee: add support for arbitrary shared memory

2018-09-10 Thread Julien Grall
Hi, On 03/09/18 17:54, Volodymyr Babchuk wrote: Shared memory is widely used by NW to communicate with TAs in OP-TEE. NW can share part of own memory with TA or OP-TEE core, by registering it OP-TEE, or by providing a temporal refernce. Anyways, information about such memory buffers are sent to

[Xen-devel] [PATCH v2] x86: use VMLOAD for PV context switch

2018-09-10 Thread Jan Beulich
Having noticed that VMLOAD alone is about as fast as a single of the involved WRMSRs, I thought it might be a reasonable idea to also use it for PV. Measurements, however, have shown that an actual improvement can be achieved only with an early prefetch of the VMCB (thanks to Andrew for suggesting

Re: [Xen-devel] [PATCH v19 12/13] x86/hvm: Remove redundant save functions

2018-09-10 Thread Jan Beulich
>>> On 10.09.18 at 15:54, wrote: > On Mon, 2018-09-10 at 07:42 -0600, Jan Beulich wrote: >> > > > On 10.09.18 at 15:33, wrote: >> > >> > On Mon, 2018-09-10 at 15:36 +0300, Alexandru Isaila wrote: >> > > This patch removes the redundant save functions and renames the >> > > save_one* to save. It

[Xen-devel] [linux-linus test] 127458: regressions - FAIL

2018-09-10 Thread osstest service owner
flight 127458 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127458/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

[Xen-devel] [PATCH v20 08/13] x86/hvm: Introduce lapic_save_hidden_one

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since v15: - Drop struct vlapic *s. --- xen/arch/x86/hvm/vlapic.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/xen/arch/x8

[Xen-devel] [PATCH v20 09/13] x86/hvm: Introduce lapic_save_regs_one func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since v15: - Drop struct vlapic *s. --- xen/arch/x86/hvm/vlapic.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/xen/

[Xen-devel] [PATCH v20 03/13] x86/hvm: Introduce hvm_save_cpu_ctxt_one func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V14: - Move all free fields to the initializer - Add blank line to before the return - Move v->pause_flags check to the save_one function. --- xe

[Xen-devel] [PATCH v20 06/13] x86/hvm: Introduce hvm_save_mtrr_msr_one func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila i Reviewed-by: Jan Beulich --- Changes since v16: - Address style comments. --- xen/arch/x86/hvm/mtrr.c | 80 ++--- 1 file changed, 43 insertions(+), 37 deletions(-) di

[Xen-devel] [PATCH v20 00/13] x86/domctl: Save info for one vcpu instance

2018-09-10 Thread Alexandru Isaila
Hi all, This patch series addresses the ideea of saving data from a single vcpu instance. First it starts by adding *save_one functions, then it introduces a handler for the new save_one* funcs and makes use of it in the hvm_save and hvm_save_one funcs. The final patches are used for clean up an

[Xen-devel] [PATCH v20 04/13] x86/hvm: Introduce hvm_save_cpu_xsave_states_one

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V14: - Remove err init - Add blank line ahead of return - Move xsave_enabled() check to the save_one func. --- xen/arch/x86/hvm/hvm.c | 47 ++

[Xen-devel] [PATCH v20 01/13] x86/cpu: Introduce vmce_save_vcpu_ctxt_one() func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V11: - Removed the memset and added init with {}. --- xen/arch/x86/cpu/mcheck/vmce.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-)

[Xen-devel] [PATCH v20 05/13] x86/hvm: Introduce hvm_save_cpu_msrs_one func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Paul Durrant Reviewed-by: Jan Beulich --- Changes since V14: - Remove err init - Add blank line ahead of return. --- xen/arch/x86/hvm/hvm.c | 106 +++-

[Xen-devel] [PATCH v20 02/13] x86/hvm: Introduce hvm_save_tsc_adjust_one() func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V13: - Moved tsc_adjust to the initializer. --- xen/arch/x86/hvm/hvm.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/xen/arc

[Xen-devel] [PATCH v20 13/13] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-09-10 Thread Alexandru Isaila
This patch is focused on moving changing hvm_save_one() to save one typecode from one vcpu and now that the save functions get data from a single vcpu we can pause the specific vcpu instead of the domain. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V19: -

[Xen-devel] [PATCH v20 12/13] x86/hvm: Remove redundant save functions

2018-09-10 Thread Alexandru Isaila
This patch removes the redundant save functions and renames the save_one* to save. It then changes the domain param to vcpu in the save funcs and adapts print messages in order to match the format of the other save related messages. Signed-off-by: Alexandru Isaila --- Changes since V19:

[Xen-devel] [PATCH v20 07/13] x86/hvm: Introduce viridian_save_vcpu_ctxt_one() func

2018-09-10 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila Reviewed-by: Paul Durrant --- Changes since V14: - Moved all the operations in the initializer. --- xen/arch/x86/hvm/viridian.c | 30 +++--- 1 file changed, 19 insertions(+), 11 de

[Xen-devel] [PATCH v20 11/13] x86/domctl: Use hvm_save_vcpu_handler

2018-09-10 Thread Alexandru Isaila
This patch is aimed on using the new save_one fuctions in the hvm_save Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V17: - Remove double ; - Move struct vcpu *v to reduce scope - Remove stray lines. --- xen/arch/x86/hvm/save.c | 26

[Xen-devel] [PATCH v20 10/13] x86/hvm: Add handler for save_one funcs

2018-09-10 Thread Alexandru Isaila
Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V14: - Change handler name from hvm_save_one_handler to hvm_save_vcpu_handler. --- xen/arch/x86/cpu/mcheck/vmce.c | 1 + xen/arch/x86/emul-i8254.c | 2 +- xen/arch/x86/hvm/hpet.c| 2 +- xen/arch/x86

Re: [Xen-devel] [PATCH 2/5] x86/hvm: Switch hvm_allow_set_param() to use a whitelist

2018-09-10 Thread Roger Pau Monné
On Fri, Sep 07, 2018 at 07:13:08PM +0100, Andrew Cooper wrote: > On 07/09/18 17:01, Roger Pau Monné wrote: > > On Wed, Sep 05, 2018 at 07:12:01PM +0100, Andrew Cooper wrote: > >> There are holes in the HVM_PARAM space, some of which are from deprecated > >> parameters, but toolstack and device mode

[Xen-devel] [ovmf baseline-only test] 75190: trouble: blocked/broken

2018-09-10 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75190 ovmf real [real] http://osstest.xensource.com/osstest/logs/75190/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

Re: [Xen-devel] [PATCH v2 3/5] x86: Fix APIC MSR constant names

2018-09-10 Thread Roger Pau Monné
On Wed, Mar 07, 2018 at 06:58:34PM +, Andrew Cooper wrote: > We currently have MSR_IA32_APICBASE and MSR_IA32_APICBASE_MSR which are > synonymous from a naming point of view, but refer to very different things. > > Rename the x2APIC MSRs to MSR_X2APIC_*, which are shorter constants and > visua

Re: [Xen-devel] [PATCH v2 4/5] x86/hvm: Handle x2apic MSRs via the new guest_{rd, wr}msr() infrastructure

2018-09-10 Thread Roger Pau Monné
On Wed, Mar 07, 2018 at 06:58:35PM +, Andrew Cooper wrote: > Dispatch from the guest_{rd,wr}msr() functions. The read side should be safe > outside of current context, but the write side is definitely not. As the > toolstack has no legitimate reason to access the APIC registers via this > int

Re: [Xen-devel] [DRBD-user] [PATCH] xen-blkback: Switch to closed state after releasing the backing device

2018-09-10 Thread Roger Pau Monné
On Mon, Sep 10, 2018 at 03:22:52PM +0200, Valentin Vidic wrote: > On Mon, Sep 10, 2018 at 02:45:31PM +0200, Lars Ellenberg wrote: > > On Sat, Sep 08, 2018 at 09:34:32AM +0200, Valentin Vidic wrote: > > > On Fri, Sep 07, 2018 at 07:14:59PM +0200, Valentin Vidic wrote: > > > > In fact the first one i

[Xen-devel] [PATCH] SVM: limit GIF=0 region

2018-09-10 Thread Jan Beulich
Use EFLAGS.IF for most ordinary purposes; there's in particular no need to unduly defer NMI/#MC. Clear GIF only immediately before VMRUN itself. This has the additional advantage that svm_stgi_label now indeed marks the only place where GIF gets set. Note regarding the main STI placement: Quite co

Re: [Xen-devel] v4.19-rc3, wrong pageflags in dom0

2018-09-10 Thread Olaf Hering
Am Mon, 10 Sep 2018 14:49:07 +0200 schrieb Olaf Hering : > After reboot I tried to start my HVM domU, this is what I get in dom0: > [ 223.019451] page:ea007bed9040 count:1 mapcount:-1 > mapping: index:0x0 this also happens with rc2 and xen.git#staging as dom0. v4.18 works.

Re: [Xen-devel] [PATCH v2 10/13] optee: add support for RPC commands

2018-09-10 Thread Julien Grall
Hi Volodymyr, On 03/09/18 17:54, Volodymyr Babchuk wrote: OP-TEE can issue multiple RPC requests. We are interested mostly in request that asks NW to allocate/free shared memory for OP-TEE needs, becuase mediator need to do address translation in the same s/becuase/because/ s/need/needs/ the

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-10 Thread Olaf Hering
Am Fri, 7 Sep 2018 12:56:37 -0400 schrieb Boris Ostrovsky : > I was hoping you'd respond to my question about warning. > > root@haswell> xl vcpu-set 3 0 > and in the guest > > [root@vm-0238 ~]# [   32.866955] [ cut here ] > [   32.866963] spinlock on CPU0 exists on IRQ1

Re: [Xen-devel] [DRBD-user] [PATCH] xen-blkback: Switch to closed state after releasing the backing device

2018-09-10 Thread Valentin Vidic
On Mon, Sep 10, 2018 at 05:00:58PM +0200, Roger Pau Monné wrote: > I can try to take a look at this and attempt to make sure the state is > only changed to closed in blkback _after_ the device has been > released, but it might take me a couple of days to get you a patch. Thanks, I have two test no

Re: [Xen-devel] xpti=dom0=false doesn't seem to work on 4.8.4

2018-09-10 Thread Karl Johnson
On Mon, Jul 16, 2018 at 5:39 AM Jan Beulich wrote: > >>> On 13.07.18 at 20:54, wrote: > > Hello, > > > > I'm currently testing last Xen 4.8.4 build for CentOS > > (http://cbs.centos.org/koji/buildinfo?buildID=23169) and disabling > > XPTI for dom0 doesn't seem to work: > > > > (XEN) Command line

[Xen-devel] [PATCH 5/5] formats: print time values as decimals

2018-09-10 Thread Andrii Anisov
From: Andrii Anisov For convinience, print RTDS budget and deadline values as decimals. Signed-off-by: Andrii Anisov --- tools/xentrace/formats | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xentrace/formats b/tools/xentrace/formats index 7db6d49..cf25ab0 10064

[Xen-devel] [PATCH 2/5] xentrace_format: switch mhz option to float

2018-09-10 Thread Andrii Anisov
From: Andrii Anisov In some systems fraction of the MHz might be a meaningful part of the cycles frequency value. So accept MHz value as float. Signed-off-by: Andrii Anisov --- tools/xentrace/xentrace_format | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xentra

[Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-10 Thread Andrii Anisov
From: Andrii Anisov Signed-off-by: Andrii Anisov --- tools/xentrace/xentrace_format | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/xentrace/xentrace_format b/tools/xentrace/xentrace_format index 5ff85ae..323d0c2 100644 --- a/tools/xentrace/xentrace_format +++

[Xen-devel] [PATCH 4/5] formats: allign trace record format to the current code

2018-09-10 Thread Andrii Anisov
From: Andrii Anisov Allign rtds:repl_budget trace record format to the current code. Signed-off-by: Andrii Anisov --- tools/xentrace/formats | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xentrace/formats b/tools/xentrace/formats index d6e7e3f..7db6d49 100644 --- a/t

  1   2   >