Re: [Xen-devel] Automatic dependencies are out of sync

2018-09-06 Thread Juergen Gross
On 05/09/18 16:05, Juergen Gross wrote: > I think we have a major problem in our build system regarding > automatic dependencies. > > Starting with a new tree (after git clone or make clean) I have > no dependency files (*.d2) anywhere: > > $ make clean > $ find . -name '*.d2' | wc -l > 0 > > Do

[Xen-devel] [linux-next test] 127303: regressions - FAIL

2018-09-06 Thread osstest service owner
flight 127303 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/127303/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 127256 test-amd64-

Re: [Xen-devel] Automatic dependencies are out of sync

2018-09-06 Thread Jan Beulich
>>> On 06.09.18 at 09:34, wrote: > On 05/09/18 16:05, Juergen Gross wrote: >> I think we have a major problem in our build system regarding >> automatic dependencies. >> >> Starting with a new tree (after git clone or make clean) I have >> no dependency files (*.d2) anywhere: >> >> $ make clean

[Xen-devel] [linux-linus bisection] complete test-amd64-amd64-qemuu-nested-intel

2018-09-06 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-nested-intel testid debian-hvm-install Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-x

Re: [Xen-devel] [PATCH OSSTEST] Install GnuTLS for libvirt builds

2018-09-06 Thread Wei Liu
On Wed, Sep 05, 2018 at 03:43:12PM -0600, Jim Fehlig wrote: > Since libvirt commit 60d9ad6f GnuTLS is required to build libvirt. The > various libvirt build tests in osstest began failing after the commit > hit libvirt.git master. Adding libgnutls28-dev to the list of packages > needed to build lib

Re: [Xen-devel] Automatic dependencies are out of sync

2018-09-06 Thread Juergen Gross
On 06/09/18 10:10, Jan Beulich wrote: On 06.09.18 at 09:34, wrote: >> On 05/09/18 16:05, Juergen Gross wrote: >>> I think we have a major problem in our build system regarding >>> automatic dependencies. >>> >>> Starting with a new tree (after git clone or make clean) I have >>> no dependency

Re: [Xen-devel] Automatic dependencies are out of sync

2018-09-06 Thread Andrew Cooper
On 06/09/18 09:27, Juergen Gross wrote: > On 06/09/18 10:10, Jan Beulich wrote: > >>> %: %.o >>> gcc $< -o $@ >>> >>> -include $(DEPS) >>> >>> -->8 snip here 8<-- >>> >>> So the basic ideas are: >>> >>> - add a rule for constructing the .d files >>> - let the build depend on the .d2 files >

Re: [Xen-devel] [PATCH 1/5] x86/hvm: Switch hvm_allow_get_param() to use a whitelist

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 05 September 2018 19:12 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Wei Liu ; Roger Pau Monne > ; Paul Durrant ; Stefano > Stabellini ; Julien Grall > Subject: [PATCH 1/5] x86/hvm: Switch hvm

Re: [Xen-devel] [PATCH 2/5] x86/hvm: Switch hvm_allow_set_param() to use a whitelist

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 05 September 2018 19:12 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Wei Liu ; Roger Pau Monne > ; Paul Durrant ; Stefano > Stabellini ; Julien Grall > Subject: [PATCH 2/5] x86/hvm: Switch hvm_a

Re: [Xen-devel] [PATCH 3/5] x86/hvm: Make HVM_PARAM_{STORE, CONSOLE}_EVTCHN read-only to the guest

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 05 September 2018 19:12 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Wei Liu ; Roger Pau Monne > ; Paul Durrant ; Stefano > Stabellini ; Julien Grall > Subject: [PATCH 3/5] x86/hvm: Make > HVM_P

Re: [Xen-devel] [PATCH 4/5] x86/hvm: Misc non-functional cleanup to the HVM_PARAM infrastructure

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 05 September 2018 19:12 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Wei Liu ; Roger Pau Monne > ; Paul Durrant ; Stefano > Stabellini ; Julien Grall > Subject: [PATCH 4/5] x86/hvm: Misc non-fun

Re: [Xen-devel] [PATCH 5/5] xen/ARM: Restrict access to most HVM_PARAM's

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 05 September 2018 19:12 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Wei Liu ; Roger Pau Monne > ; Paul Durrant ; Stefano > Stabellini ; Julien Grall > Subject: [PATCH 5/5] xen/ARM: Restrict acc

Re: [Xen-devel] [PATCH] xen: remove redundant put_device

2018-09-06 Thread Wei Liu
On Thu, Sep 06, 2018 at 02:33:10PM +0800, Ding Xiang wrote: > device_unregister will put device, do not need to do it one more time > > Signed-off-by: Ding Xiang > --- > drivers/xen/xenbus/xenbus_probe.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/xen/xenbus/xenbus_probe.c

[Xen-devel] [ovmf test] 127318: all pass - PUSHED

2018-09-06 Thread osstest service owner
flight 127318 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127318/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c3d5d800d775095e0bbd0ac8862df234cdd4332d baseline version: ovmf 8a204b2aca5a137651ba0

Re: [Xen-devel] [PATCH] xen/domctl: Drop vcpu_alloc_lock

2018-09-06 Thread George Dunlap
On 09/05/2018 08:15 PM, Andrew Cooper wrote: > Since its introduction in c/s 8cbb5278e "x86/AMD: Add support for AMD's OSVW > feature in guests", the OSVW data has been corrected to be per-domain rather > than per-vcpu, and is initialised during XEN_DOMCTL_createdomain. > > Furthermore, because XE

Re: [Xen-devel] [PATCH v2 01/11] vpci: move lock

2018-09-06 Thread Wei Liu
On Tue, Jul 17, 2018 at 11:48:20AM +0200, Roger Pau Monne wrote: > To the outside of the vpci struct. This way the lock can be used to > check whether vpci is present, and removal can be performed while > holding the lock, in order to make sure there are no accesses to the > contents of the vpci st

Re: [Xen-devel] [PATCH v2 03/11] vpci: add tear down functions

2018-09-06 Thread Wei Liu
On Tue, Jul 17, 2018 at 11:48:22AM +0200, Roger Pau Monne wrote: > Tear down functions are not mandatory. Note that this patch just > implements the framework, but doesn't implement any tear down function > yet. > > The list of vpci init and teardown functions is also moved outside of > the init s

Re: [Xen-devel] [PATCH v2 04/11] vpci/msix: add teardown cleanup

2018-09-06 Thread Wei Liu
On Tue, Jul 17, 2018 at 11:48:23AM +0200, Roger Pau Monne wrote: > So that interrupts are properly freed. > > Signed-off-by: Roger Pau Monné Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/m

Re: [Xen-devel] [PATCH v2 05/11] vpci/msi: add teardown cleanup

2018-09-06 Thread Wei Liu
On Tue, Jul 17, 2018 at 11:48:24AM +0200, Roger Pau Monne wrote: > So that interrupts are properly freed. > > Signed-off-by: Roger Pau Monné Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/m

Re: [Xen-devel] Automatic dependencies are out of sync

2018-09-06 Thread Jan Beulich
>>> On 06.09.18 at 10:27, wrote: > On 06/09/18 10:10, Jan Beulich wrote: > On 06.09.18 at 09:34, wrote: >>> I've setup a little example Makefile solving the problem (just to show >>> the correct dependencies, needs to be adapted for naming the .d and .d2 >>> files and how to build the .d2): >

Re: [Xen-devel] [PATCH 5/5] xen/ARM: Restrict access to most HVM_PARAM's

2018-09-06 Thread Julien Grall
Hi Paul, On 06/09/18 10:29, Paul Durrant wrote: -Original Message- From: Andrew Cooper [mailto:andrew.coop...@citrix.com] Sent: 05 September 2018 19:12 To: Xen-devel Cc: Andrew Cooper ; Jan Beulich ; Wei Liu ; Roger Pau Monne ; Paul Durrant ; Stefano Stabellini ; Julien Grall Subject:

Re: [Xen-devel] [PATCH v6 01/14] iommu: introduce the concept of BFN...

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 September 2018 10:39 > To: Paul Durrant > Cc: Suravee Suthikulpanit ; Julien Grall > ; Kevin Tian ; Stefano > Stabellini ; xen-devel de...@lists.xenproject.org> > Subject: RE: [Xen-devel] [PATCH v6 01/14] iommu

Re: [Xen-devel] [PATCH v2 11/11] vpci/sriov: add support for SR-IOV capability

2018-09-06 Thread Wei Liu
On Tue, Jul 17, 2018 at 11:48:30AM +0200, Roger Pau Monne wrote: > +curr->vpci.wait.callback = enable_callback; > +curr->vpci.wait.data = cb; > +curr->vpci.wait.end = get_cycles() + 100 * cpu_khz; Does this guarantee to give you 100ms? What if the TSC is not con

Re: [Xen-devel] [PATCH 5/5] xen/ARM: Restrict access to most HVM_PARAM's

2018-09-06 Thread Andrew Cooper
On 06/09/18 11:36, Julien Grall wrote: > Hi Paul, > > On 06/09/18 10:29, Paul Durrant wrote: >>> -Original Message- >>> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >>> Sent: 05 September 2018 19:12 >>> To: Xen-devel >>> Cc: Andrew Cooper ; Jan Beulich >>> ; Wei Liu ; Roger Pau M

Re: [Xen-devel] [PATCH 5/5] xen/ARM: Restrict access to most HVM_PARAM's

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: 06 September 2018 11:37 > To: Paul Durrant ; Andrew Cooper > ; Xen-devel > Cc: Jan Beulich ; Wei Liu ; Roger > Pau Monne ; Stefano Stabellini > > Subject: Re: [PATCH 5/5] xen/ARM: Restrict access to most HVM_P

Re: [Xen-devel] [PATCH 5/5] xen/ARM: Restrict access to most HVM_PARAM's

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 06 September 2018 11:40 > To: Julien Grall ; Paul Durrant > ; Xen-devel > Cc: Jan Beulich ; Wei Liu ; Roger > Pau Monne ; Stefano Stabellini > > Subject: Re: [PATCH 5/5] xen/ARM: Restrict access to most HVM_PARAM's > > On 06/09/18 11:36,

Re: [Xen-devel] [PATCH] xen/domctl: Drop vcpu_alloc_lock

2018-09-06 Thread Wei Liu
On Wed, Sep 05, 2018 at 08:15:25PM +0100, Andrew Cooper wrote: > Since its introduction in c/s 8cbb5278e "x86/AMD: Add support for AMD's OSVW > feature in guests", the OSVW data has been corrected to be per-domain rather > than per-vcpu, and is initialised during XEN_DOMCTL_createdomain. > > Furth

Re: [Xen-devel] [PATCH v3 07/16] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-06 Thread Wei Liu
On Tue, Sep 04, 2018 at 06:24:28PM +0100, Julien Grall wrote: > Hi Wei, > > On 09/04/2018 05:15 PM, Wei Liu wrote: > > Populate-on-demand is HVM only. > > > > Provide a bunch of stubs for common p2m code and guard one invocation > > of guest_physmap_mark_populate_on_demand with is_hvm_domain. > >

Re: [Xen-devel] [PATCH v2 11/13] libxc: add xc_dom_tee_enable(...) function

2018-09-06 Thread Wei Liu
On Mon, Sep 03, 2018 at 07:54:35PM +0300, Volodymyr Babchuk wrote: > This function uses XEN_DOMCTL_tee_op domctl to enable TEE > support for a given domain. > > Signed-off-by: Volodymyr Babchuk Take into account Julien's comment to the previous patch, this patch should be dropped. Wei. ___

Re: [Xen-devel] [PATCH v3 01/16] x86: change name of parameter for various invlpg functions

2018-09-06 Thread George Dunlap
On 09/04/2018 05:15 PM, Wei Liu wrote: > They all incorrectly named a parameter virtual address while it should > have been linear address. > > Requested-by: Andrew Cooper > Signed-off-by: Wei Liu > Acked-by: Jan Beulich > Reviewed-by: Kevin Tian > Acked-by: Boris Ostrovsky Acked-by: George

[Xen-devel] [PATCH] xen/manage: don't complain about an empty value in control/sysrq node

2018-09-06 Thread Vitaly Kuznetsov
When guest receives a sysrq request from the host it acknowledges it by writing '\0' to control/sysrq xenstore node. This, however, make xenstore watch fire again but xenbus_scanf() fails to parse empty value with "%c" format string: sysrq: SysRq : Emergency Sync Emergency Sync complete xen:man

[Xen-devel] [PATCH] tools: specifically enable VirtFS in Linux QEMU builds

2018-09-06 Thread Paul Durrant
9pfs support has been a documented feature since Xen 4.9, but QEMU will not be built with backend support unless libcap and libattr dev packages are installed. This patch modifies the README to call out those packages as pre-requisites for Linux builds and specifically enables VirtFS in the config

[Xen-devel] [PATCH 2/6] xen/sched: Use %*pb[l] instead of cpumask_scn{, list}printf()

2018-09-06 Thread Andrew Cooper
This removes all use of keyhandler_scratch as a bounce-buffer for the rendered string. In some cases, collapse combine adjacent printk()'s which are writing parts of the same line. No functional change. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Dario Faggioli CC: Josh Whitehead

[Xen-devel] [PATCH RFC 6/6] xen/keyhandler: Drop keyhandler_scratch

2018-09-06 Thread Andrew Cooper
With almost all users of keyhandler_scratch gone, clean up the 3 remaining users and drop the buffer. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné The NUMA and periodic timer adjustments are definitely improvements. However, this is RFC because of the EFI

[Xen-devel] [PATCH 5/6] xen/bitmap: Drop all bitmap_scn{, list}printf() infrastructure

2018-09-06 Thread Andrew Cooper
All callers have been convered to using %*pb[l]. In the unlikely case that future code wants to retain this functionaly, it can be replicated in a more convenient fashon with snprintf(). Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Stefano Stabellini C

[Xen-devel] [PATCH 0/6] xen: Use %*pb[l] for printing bitmaps

2018-09-06 Thread Andrew Cooper
I was trying to debug a cpumask problem, and got irritated with how awkard it was to render and print the masks. Luckily, the fix is quite simple and far nicer to use. The overall diffstat is to patch 5 is: add/remove: 0/4 grow/shrink: 2/11 up/down: 603/-1191 (-588) Function

[Xen-devel] [PATCH 4/6] xen/x86: Use %*pb[l] instead of cpumask_scn{, list}printf()

2018-09-06 Thread Andrew Cooper
This removes all use of keyhandler_scratch as a bounce-buffer for the rendered string. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/cpu/mcheck/mce.c | 9 ++--- xen/arch/x86/crash.c | 7 ++- xen/arch/x

[Xen-devel] [PATCH 1/6] xen/vsprintf: Introduce %*pb[l] for printing bitmaps

2018-09-06 Thread Andrew Cooper
The format identifier is consistent with Linux. The code is adapted from bitmap_scn{,list}printf() but cleaned up. This change allows all callers to avoid needing a secondary buffer to render a cpumask/nodemask into. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau M

[Xen-devel] [PATCH 3/6] xen/common: Use %*pb[l] instead of {cpu, node}mask_scn{, list}printf()

2018-09-06 Thread Andrew Cooper
This removes all use of keyhandler_scratch as a bounce-buffer for the rendered string. In some cases, collapse combine adjacent printk()'s which are writing parts of the same line. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Stef

Re: [Xen-devel] Automatic dependencies are out of sync

2018-09-06 Thread Juergen Gross
On 06/09/18 12:26, Jan Beulich wrote: On 06.09.18 at 10:27, wrote: >> On 06/09/18 10:10, Jan Beulich wrote: >> On 06.09.18 at 09:34, wrote: I've setup a little example Makefile solving the problem (just to show the correct dependencies, needs to be adapted for naming the .d and

Re: [Xen-devel] [PATCH] tools: specifically enable VirtFS in Linux QEMU builds

2018-09-06 Thread George Dunlap
On 09/06/2018 01:06 PM, Paul Durrant wrote: > 9pfs support has been a documented feature since Xen 4.9, but QEMU will > not be built with backend support unless libcap and libattr dev packages > are installed. > > This patch modifies the README to call out those packages as pre-requisites > for Li

[Xen-devel] [PATCH v3 0/3] x86/HVM: emulation adjustments

2018-09-06 Thread Jan Beulich
1: drop hvm_fetch_from_guest_linear() 2: add known_gla() emulation helper 3: split page straddling emulated accesses in more cases v3: Split patch 2 out from patch 3. v2: Patch 1 now builds cleanly (without other patches in place the up-to- date versions of which are yet to be posted), and patch 2

Re: [Xen-devel] [PATCH] xen/manage: don't complain about an empty value in control/sysrq node

2018-09-06 Thread Wei Liu
On Thu, Sep 06, 2018 at 01:26:08PM +0200, Vitaly Kuznetsov wrote: > When guest receives a sysrq request from the host it acknowledges it by > writing '\0' to control/sysrq xenstore node. This, however, make xenstore > watch fire again but xenbus_scanf() fails to parse empty value with "%c" > format

[Xen-devel] [PATCH v3 1/3] x86/HVM: drop hvm_fetch_from_guest_linear()

2018-09-06 Thread Jan Beulich
It can easily be expressed through hvm_copy_from_guest_linear(), and in two cases this even simplifies callers. Suggested-by: Paul Durrant Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Tested-by: Olaf Hering --- v2: Make sure this compiles standalone. Slightly adjust change in hvm_

[Xen-devel] [PATCH v3 3/3] x86/HVM: split page straddling emulated accesses in more cases

2018-09-06 Thread Jan Beulich
Assuming consecutive linear addresses map to all RAM or all MMIO is not correct. Nor is assuming that a page straddling MMIO access will access the same emulating component for both parts of the access. If a guest RAM read fails with HVMTRANS_bad_gfn_to_mfn and if the access straddles a page bounda

[Xen-devel] [PATCH v3 2/3] x86/HVM: add known_gla() emulation helper

2018-09-06 Thread Jan Beulich
... as a central place to do respective checking for whether the translation for the linear address is available as well as usable. Signed-off-by: Jan Beulich --- v3: Split from subsequent patch. --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -1041,6 +1041,26 @@ static inli

Re: [Xen-devel] [PATCH] tools: specifically enable VirtFS in Linux QEMU builds

2018-09-06 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 06 September 2018 13:52 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Andrew Cooper ; George Dunlap > ; Ian Jackson ; Jan > Beulich ; Julien Grall ; Konrad > Rzeszutek Wilk ; Stefano Stabellini

Re: [Xen-devel] [PATCH v3 2/3] x86/HVM: add known_gla() emulation helper

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 06 September 2018 14:04 > To: xen-devel > Cc: Olaf Hering ; Andrew Cooper > ; Paul Durrant > Subject: [PATCH v3 2/3] x86/HVM: add known_gla() emulation helper > > ... as a central place to do respective checking

Re: [Xen-devel] [PATCH v6 01/14] iommu: introduce the concept of BFN...

2018-09-06 Thread Jan Beulich
>>> On 06.09.18 at 12:36, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 05 September 2018 10:39 >> >> >>> On 05.09.18 at 11:13, wrote: >> > Personally I think 'bus address' is commonly enough used term for >> addresses >> > used by devices for DMA. Indeed we have already 'dev_b

Re: [Xen-devel] [PATCH v3 3/3] x86/HVM: split page straddling emulated accesses in more cases

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 06 September 2018 14:04 > To: xen-devel > Cc: Olaf Hering ; Andrew Cooper > ; Paul Durrant > Subject: [PATCH v3 3/3] x86/HVM: split page straddling emulated accesses in > more cases > > Assuming consecutive linea

Re: [Xen-devel] [PATCH v3 2/3] x86/HVM: add known_gla() emulation helper

2018-09-06 Thread Jan Beulich
>>> On 06.09.18 at 15:12, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 06 September 2018 14:04 >> To: xen-devel >> Cc: Olaf Hering ; Andrew Cooper >> ; Paul Durrant >> Subject: [PATCH v3 2/3] x86/HVM: add known_gla() emulation helper >> >> ... a

Re: [Xen-devel] [PATCH v3 02/16] x86: introduce and use a set of internal emulation flags

2018-09-06 Thread Jan Beulich
>>> On 04.09.18 at 18:15, wrote: > Use these flags in has_* tests and emulation_flags_ok. > > Not using raw flags directly enabling DCE to kick in for has_* tests > while at the same time making sure emulation_flags_ok won't go out of > sync. This is rather hard to read (for me at least). Perhap

Re: [Xen-devel] [PATCH v3 03/16] x86: XENMEM_resource_ioreq_server is HVM only

2018-09-06 Thread Jan Beulich
>>> On 04.09.18 at 18:42, wrote: > On Tue, Sep 04, 2018 at 05:15:20PM +0100, Wei Liu wrote: >> Put the entire case branch under CONFIG_HVM. >> >> Nonetheless check HVM before trying to get ioreq server. > > The wording here is confusing. It should have been written as: > > Lift the check from h

Re: [Xen-devel] [PATCH v3 02/16] x86: introduce and use a set of internal emulation flags

2018-09-06 Thread Wei Liu
On Thu, Sep 06, 2018 at 07:27:47AM -0600, Jan Beulich wrote: > >>> On 04.09.18 at 18:15, wrote: > > Use these flags in has_* tests and emulation_flags_ok. > > > > Not using raw flags directly enabling DCE to kick in for has_* tests > > while at the same time making sure emulation_flags_ok won't g

[Xen-devel] [PATCH] xen/sched: Re-position the domain_update_node_affinity() call during vcpu construction

2018-09-06 Thread Andrew Cooper
alloc_vcpu()'s call to domain_update_node_affinity() has existed for a decade, but its effort is mostly wasted. alloc_vcpu() is called in a loop for each vcpu, bringing them into existence. The values of the affinity masks are still default, which is allcpus in general, or a processor singleton fo

Re: [Xen-devel] ARM: Xen 4.11 + modern dom0 on ODROID-XU4/HC1 (Exynos 5422)

2018-09-06 Thread Julien Grall
On 01/09/18 09:45, Steve Dodd wrote: Hi all, Hello Steve, Having successfully followed the instructions at https://wiki.odroid.com/odroid-xu4/application_note/software/xen_virtualization to get an old Xen and dom0 kernel working on my ODROID HC1 I'd like to get a more modern setup working. I

[Xen-devel] USB pass-through and WiFi access

2018-09-06 Thread Vikram K
Hi, 1. We are using Hikey960 board. 2. Xen version is 4.8 3. Linux kernel version is 4.14 We want to add/pass-through USB devices to DomU. From the below link I understood that there is no USB back and front driver support in latest kernel. But PVUSB support is added to *xl* tools since Xen 4.7.

Re: [Xen-devel] [PATCH v3 05/16] x86: PIT emulation is common to both PV and HVM

2018-09-06 Thread Jan Beulich
>>> On 04.09.18 at 18:15, wrote: > Move the file to x86 common code and change its name to emul-i8254.c. > > Put HVM only code under CONFIG_HVM or is_hvm_domain. > > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-deve

Re: [Xen-devel] [PATCH v3 2/3] x86/HVM: add known_gla() emulation helper

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 06 September 2018 14:22 > To: Paul Durrant > Cc: Olaf Hering ; Andrew Cooper > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v3 2/3] x86/HVM: add known_gla() emulation helper > > >>> On 06.09.18 a

Re: [Xen-devel] [PATCH v3 1/3] x86/HVM: drop hvm_fetch_from_guest_linear()

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 06 September 2018 14:03 > To: xen-devel > Cc: Olaf Hering ; Andrew Cooper > ; Paul Durrant ; > Tim (Xen.org) > Subject: [PATCH v3 1/3] x86/HVM: drop hvm_fetch_from_guest_linear() > > It can easily be expressed th

[Xen-devel] [linux-4.9 test] 127322: tolerable FAIL - PUSHED

2018-09-06 Thread osstest service owner
flight 127322 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/127322/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 127006 test-amd64-i386-xl-qemut-win7-amd64 17

Re: [Xen-devel] [PATCH v6 01/14] iommu: introduce the concept of BFN...

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 06 September 2018 14:13 > To: Paul Durrant > Cc: Suravee Suthikulpanit ; Julien Grall > ; Kevin Tian ; Stefano > Stabellini ; xen-devel de...@lists.xenproject.org> > Subject: RE: [Xen-devel] [PATCH v6 01/14] iommu

[Xen-devel] [PATCH] automation: specify -j$(nproc) in build script

2018-09-06 Thread Wei Liu
Signed-off-by: Wei Liu --- automation/scripts/build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/build b/automation/scripts/build index 054226bd73..c463b060d4 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -30,4 +30,4 @@ fi ./c

Re: [Xen-devel] [PATCH v3 07/16] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-06 Thread Jan Beulich
>>> On 04.09.18 at 18:15, wrote: > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -52,15 +52,20 @@ DEFINE_PERCPU_RWLOCK_GLOBAL(p2m_percpu_rwlock); > /* Init the datastructures for later use by the p2m code */ > static int p2m_initialise(struct domain *d, struct p2m_domain *p2m) >

Re: [Xen-devel] [PATCH 1/5] x86/hvm: Switch hvm_allow_get_param() to use a whitelist

2018-09-06 Thread Andrew Cooper
On 06/09/18 09:56, Paul Durrant wrote: >> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c >> index c22bf0b..96a6323 100644 >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -4350,7 +4350,7 @@ static int hvm_allow_get_param(struct domain *d, >> >> switch ( a->in

Re: [Xen-devel] [PATCH 2/5] x86/hvm: Switch hvm_allow_set_param() to use a whitelist

2018-09-06 Thread Andrew Cooper
On 06/09/18 10:08, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 05 September 2018 19:12 >> To: Xen-devel >> Cc: Andrew Cooper ; Jan Beulich >> ; Wei Liu ; Roger Pau Monne >> ; Paul Durrant ; Stefano >> Stabellini ; Julien Gral

Re: [Xen-devel] [PATCH 3/5] x86/hvm: Make HVM_PARAM_{STORE, CONSOLE}_EVTCHN read-only to the guest

2018-09-06 Thread Andrew Cooper
On 06/09/18 10:16, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 05 September 2018 19:12 >> To: Xen-devel >> Cc: Andrew Cooper ; Jan Beulich >> ; Wei Liu ; Roger Pau Monne >> ; Paul Durrant ; Stefano >> Stabellini ; Julien Gral

Re: [Xen-devel] [PATCH v3 07/16] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-06 Thread George Dunlap
On 09/06/2018 11:57 AM, Wei Liu wrote: > On Tue, Sep 04, 2018 at 06:24:28PM +0100, Julien Grall wrote: >> Hi Wei, >> >> On 09/04/2018 05:15 PM, Wei Liu wrote: >>> Populate-on-demand is HVM only. >>> >>> Provide a bunch of stubs for common p2m code and guard one invocation >>> of guest_physmap_mark_

Re: [Xen-devel] [PATCH] x86/hvm/viridian: set shutdown_code in response to CrashNotify

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 23 August 2018 09:38 > To: Andrew Cooper ; xen- > de...@lists.xenproject.org > Cc: Jan Beulich > Subject: Re: [Xen-devel] [PATCH] x86/hvm/viridian: set shutdown_code i

Re: [Xen-devel] [PATCH] x86/hvm/viridian: set shutdown_code in response to CrashNotify

2018-09-06 Thread Andrew Cooper
On 06/09/18 16:32, Paul Durrant wrote: >> -Original Message- >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Paul Durrant >> Sent: 23 August 2018 09:38 >> To: Andrew Cooper ; xen- >> de...@lists.xenproject.org >> Cc: Jan Beulich >> Subject: Re: [Xen-devel

[Xen-devel] [PATCH] xen/balloon: add runtime control for scrubbing ballooned out pages

2018-09-06 Thread Marek Marczykowski-Górecki
Scrubbing pages on initial balloon down can take some time, especially in nested virtualization case (nested EPT is slow). When HVM/PVH guest is started with memory= significantly lower than maxmem=, all the extra pages will be scrubbed before returning to Xen. But since most of them weren't used a

Re: [Xen-devel] [PATCH] x86/hvm/viridian: set shutdown_code in response to CrashNotify

2018-09-06 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 06 September 2018 16:33 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Jan Beulich > Subject: Re: [PATCH] x86/hvm/viridian: set shutdown_code in response to > CrashNotify > > On 06/09/18 16:32, Paul Durrant wrote: > >> -Ori

[Xen-devel] x86 Community Call - Wed Sept 12, 14:00 - 15:00 UTC - Call for agenda items

2018-09-06 Thread Lars Kurth
Dear community members, please send me agenda items for next week’s community call by next Monday. One suggestion which was made to me recently by Rich, Christopher and Daniel was for Daniel to give an overview of Secure Boot, Measured Launch and TrenchBoot. @Daniel, @Christopher, @Rich: would th

Re: [Xen-devel] [PATCH 0/3] xen/arm: vgic-v3: Bug fixes

2018-09-06 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: 04 September 2018 20:22 > To: xen-devel@lists.xenproject.org > Cc: sstabell...@kernel.org; andre.przyw...@arm.com; Shameerali Kolothum > Thodi ; Julien Grall > > Subject: [PATCH 0/3] xen/arm: vgic-v3: Bug fix

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-06 Thread Wei Liu
On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: > Uses MD5 on the host mac address, vm name and vif index to generate the > last three bytes of the vm mac address (for each vm). > > It uses the vif index to account for multiple vifs. > > MD5 code is originally from the public doma

Re: [Xen-devel] [PATCH] xen/ARM+sched: Don't opencode %pv in printk()'s

2018-09-06 Thread George Dunlap
On 08/30/2018 01:50 PM, Andrew Cooper wrote: > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [linux-linus test] 127315: regressions - FAIL

2018-09-06 Thread osstest service owner
flight 127315 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127315/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

Re: [Xen-devel] [PATCH v3 07/16] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-06 Thread George Dunlap
On 09/06/2018 04:05 PM, Jan Beulich wrote: On 04.09.18 at 18:15, wrote: >> --- a/xen/arch/x86/mm/p2m.c >> +++ b/xen/arch/x86/mm/p2m.c >> @@ -52,15 +52,20 @@ DEFINE_PERCPU_RWLOCK_GLOBAL(p2m_percpu_rwlock); >> /* Init the datastructures for later use by the p2m code */ >> static int p2m_initi

Re: [Xen-devel] [PATCH] xen-blkback: Switch to closed state after releasing the backing device

2018-09-06 Thread Roger Pau Monné
On Wed, Sep 05, 2018 at 06:27:56PM +0200, Valentin Vidic wrote: > On Wed, Sep 05, 2018 at 12:36:49PM +0200, Roger Pau Monné wrote: > > On Wed, Aug 29, 2018 at 08:52:14AM +0200, Valentin Vidic wrote: > > > Switching to closed state earlier can cause the block-drbd > > > script to fail with 'Device i

Re: [Xen-devel] [PATCH] xsm: fix clang build

2018-09-06 Thread Wei Liu
On Wed, Sep 05, 2018 at 04:46:06PM +0200, Roger Pau Monne wrote: > ebitmap.c:244:32: error: invalid conversion specifier 'Z' > [-Werror,-Wformat-invalid-specifier] >"match my size %Zd (high bit was %d)\n", mapunit, > ~^ > ebitmap.c:245:16: error: forma

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] libxl: made vm mac address assignment deterministic"): > On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: > > Uses MD5 on the host mac address, vm name and vif index to generate the > > last three bytes of the vm mac address (for each vm). There is no s

Re: [Xen-devel] [PATCH v3 10/16] x86/mm: put nested p2m code under CONFIG_HVM

2018-09-06 Thread George Dunlap
On 09/04/2018 05:15 PM, Wei Liu wrote: > These functions are only useful for nested hvm, which isn't enabled > when CONFIG_HVM is false. > > Enclose relevant code and fields in CONFIG_HVM. Guard np2m_schedule > with nestedhvm_enabled. > > Signed-off-by: Wei Liu > --- > xen/arch/x86/domain.c

Re: [Xen-devel] [PATCH] xen-blkback: Switch to closed state after releasing the backing device

2018-09-06 Thread Roger Pau Monné
On Wed, Sep 05, 2018 at 06:28:01PM +0200, Valentin Vidic wrote: > On Wed, Sep 05, 2018 at 01:35:15PM +0200, Valentin Vidic wrote: > > > AFAICT, this will cause the backend to never switch to 'Closed' state > > > until the toolstack sets online to 0, which is not good IMO. > > > > > > If for exampl

Re: [Xen-devel] [PATCH 3/6] xen/common: Use %*pb[l] instead of {cpu, node}mask_scn{, list}printf()

2018-09-06 Thread Wei Liu
On Thu, Sep 06, 2018 at 01:08:13PM +0100, Andrew Cooper wrote: > This removes all use of keyhandler_scratch as a bounce-buffer for the rendered > string. In some cases, collapse combine adjacent printk()'s which are writing > parts of the same line. > > No functional change. > > Signed-off-by: A

Re: [Xen-devel] [PATCH RFC 6/6] xen/keyhandler: Drop keyhandler_scratch

2018-09-06 Thread Wei Liu
On Thu, Sep 06, 2018 at 01:08:16PM +0100, Andrew Cooper wrote: > With almost all users of keyhandler_scratch gone, clean up the 3 remaining > users and drop the buffer. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Wei Liu > CC: Roger Pau Monné > > The NUMA and periodic timer

Re: [Xen-devel] [PATCH 1/6] xen/vsprintf: Introduce %*pb[l] for printing bitmaps

2018-09-06 Thread Wei Liu
On Thu, Sep 06, 2018 at 01:08:11PM +0100, Andrew Cooper wrote: > The format identifier is consistent with Linux. The code is adapted from > bitmap_scn{,list}printf() but cleaned up. > > This change allows all callers to avoid needing a secondary buffer to render a > cpumask/nodemask into. > > Si

Re: [Xen-devel] [PATCH 4/6] xen/x86: Use %*pb[l] instead of cpumask_scn{, list}printf()

2018-09-06 Thread Wei Liu
On Thu, Sep 06, 2018 at 01:08:14PM +0100, Andrew Cooper wrote: > This removes all use of keyhandler_scratch as a bounce-buffer for the rendered > string. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel m

Re: [Xen-devel] [PATCH 5/6] xen/bitmap: Drop all bitmap_scn{, list}printf() infrastructure

2018-09-06 Thread Wei Liu
On Thu, Sep 06, 2018 at 01:08:15PM +0100, Andrew Cooper wrote: > All callers have been convered to using %*pb[l]. In the unlikely case that > future code wants to retain this functionaly, it can be replicated in a more > convenient fashon with snprintf(). > > Signed-off-by: Andrew Cooper Acked-

[Xen-devel] [libvirt test] 127329: regressions - FAIL

2018-09-06 Thread osstest service owner
flight 127329 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/127329/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123814 build-amd64-libvirt

Re: [Xen-devel] [PATCH 3/5] x86/hvm: Make HVM_PARAM_{STORE, CONSOLE}_EVTCHN read-only to the guest

2018-09-06 Thread Julien Grall
On 06/09/18 16:29, Andrew Cooper wrote: On 06/09/18 10:16, Paul Durrant wrote: -Original Message- From: Andrew Cooper [mailto:andrew.coop...@citrix.com] Sent: 05 September 2018 19:12 To: Xen-devel Cc: Andrew Cooper ; Jan Beulich ; Wei Liu ; Roger Pau Monne ; Paul Durrant ; Stefano Sta

Re: [Xen-devel] [PATCH] automation: specify -j$(nproc) in build script

2018-09-06 Thread Doug Goldstein
On Thu, Sep 06, 2018 at 03:55:59PM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > automation/scripts/build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/scripts/build b/automation/scripts/build > index 054226bd73..c463b060d4 100755 > --- a/automation

[Xen-devel] [ovmf test] 127335: all pass - PUSHED

2018-09-06 Thread osstest service owner
flight 127335 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127335/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 22cf747fcf75dbfe51e5524ce1f9cf17b19914cd baseline version: ovmf c3d5d800d775095e0bbd0

[Xen-devel] [xen-unstable-smoke test] 127341: tolerable all pass - PUSHED

2018-09-06 Thread osstest service owner
flight 127341 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127341/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH] tools: specifically enable VirtFS in Linux QEMU builds

2018-09-06 Thread Stefano Stabellini
On Thu, 6 Sep 2018, Paul Durrant wrote: > 9pfs support has been a documented feature since Xen 4.9, but QEMU will > not be built with backend support unless libcap and libattr dev packages > are installed. > > This patch modifies the README to call out those packages as pre-requisites > for Linux

Re: [Xen-devel] [PATCH v2] xen: avoid crash in disable_hotplug_cpu

2018-09-06 Thread Boris Ostrovsky
On 09/06/2018 02:37 AM, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga946

[Xen-devel] [PATCH 1/3] xen/vcpu: Rename the common interfaces for consistency

2018-09-06 Thread Andrew Cooper
The vcpu functions are far less consistent than the domain side of things, and in particular, has vcpu_destroy() for architecture specific functionality. Perform the following renames: * alloc_vcpu => vcpu_create * vcpu_initialise => arch_vcpu_create * vcpu_destroy=> arch_vcpu_dest

[Xen-devel] [PATCH 3/3] xen/vcpu: Rework sanity checks in vcpu_create()

2018-09-06 Thread Andrew Cooper
Poisoning idle_vcpu[0] with the sanity debug value isn't actually a clever idea, because it passes a NULL pointer check but isn't a usable vcpu. It is also the reason for the (!is_idle_domain(d) || vcpu_id) part of the existing sanity BUG_ON(). Now that d->max_vcpus is appropriately set up before

[Xen-devel] [PATCH 2/3] xen/vcpu: Introduce vcpu_destroy()

2018-09-06 Thread Andrew Cooper
Like _domain_destroy(), this will eventually idempotently free all parts of a struct vcpu. While breaking apart the failure path of vcpu_create(), rework the codeflow to be in a line at the end of the function for clarity. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger

[Xen-devel] [PATCH 0/3] xen: Improvements to the vcpu create/destroy paths

2018-09-06 Thread Andrew Cooper
This is the start of the work to make the vcpu_destroy() code idempotent, so vcpu construction can be moved into domain_create() and successfully unwound on error. Andrew Cooper (3): xen/vcpu: Rename the common interfaces for consistency xen/vcpu: Introduce vcpu_destroy() xen/vcpu: Rework sa

Re: [Xen-devel] [PATCH] xen/manage: don't complain about an empty value in control/sysrq node

2018-09-06 Thread Boris Ostrovsky
On 09/06/2018 07:26 AM, Vitaly Kuznetsov wrote: > When guest receives a sysrq request from the host it acknowledges it by > writing '\0' to control/sysrq xenstore node. This, however, make xenstore > watch fire again but xenbus_scanf() fails to parse empty value with "%c" > format string: > > sysr

  1   2   >