Re: [Xen-devel] [PATCH v3 5/5] x86: use PDEP for PTE flags insertion when available

2018-08-20 Thread Jan Beulich
>>> On 18.08.18 at 03:08, wrote: > On Aug 17, 2018, at 03:24, Jan Beulich wrote: >> >> This replaces 5 instructions by a single one, further reducing code size, >> cache, and TLB footprint (in particular on systems supporting BMI2). > > This link claims that BMI2 may be less performant/consiste

Re: [Xen-devel] [PATCH v5 4/8] mm: introduce a helper to get the memory type of a page

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 18:37, wrote: > On Fri, Aug 17, 2018 at 04:31:21AM -0600, Jan Beulich wrote: >> >>> On 17.08.18 at 12:17, wrote: >> On 14.08.18 at 15:43, wrote: >> >> +switch ( e820.map[i].type ) >> >> +{ >> >> +case E820_RAM: >> >> +re

Re: [Xen-devel] [PATCH v2 2/2] x86/spec-ctrl: add support for modifying SSBD VIA LS_CFG MSR

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 20:45, wrote: > On Fri, Aug 17, 2018 at 12:59:28AM -0600, Jan Beulich wrote: >> >>> On 16.08.18 at 22:02, wrote: >> > On Wed, Aug 15, 2018 at 10:00:48AM -0600, Jan Beulich wrote: >> >> > +bool __read_mostly ssbd_amd_smt_en = false; >> >> > +bool __read_mostly default_xen_ssbd_a

Re: [Xen-devel] [PATCH v2 2/2] x86/mmcfg/drhd: Move acpi_mmcfg_init() call before calling acpi_parse_dmar()

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 05:38, wrote: > On 2018/8/17 20:28, Jan Beulich wrote: > On 17.08.18 at 09:01, wrote: >>> pci_conf_read8() needs pci mmcfg mapping to work on multiple pci segments >>> system such as HPE Superdome-Flex. >>> >>> Move acpi_mmcfg_init() call in acpi_boot_init() before calling

Re: [Xen-devel] [RFC PATCH 2/2] xen/arm: Add MESON UART driver for Amlogic S905 SoC

2018-08-20 Thread Amit Tomer
Hello, Thanks for having a look at it. > The spec does not seems to provide the offset register. Where did you find > them? Actually, looked at couple of references from u-boot and Linux. These headers are picked from there. > AFAIK, {0} is not necessary. Ok. >> + >> +#define meson_s905_read(

Re: [Xen-devel] [PATCH 1/2] dmar: iommu mem leak fix

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 05:32, wrote: > Release memory allocated for drhd iommu in error path. > > Signed-off-by: Zhenzhong Duan Reviewed-by: Jan Beulich But this needs a maintainer ack, and you didn't Cc him (now done). Jan > --- a/xen/drivers/passthrough/vtd/dmar.c > +++ b/xen/drivers/passthro

Re: [Xen-devel] [PATCH 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 05:32, wrote: > When TBOOT enabled, acpi_parse_dmar() zap a copy of DMAR table rather > than the real table, so make it controled by config option based on the > fact that we already have done the real zapping in tboot_parse_dmar_table(). Is this just a cosmetic change, or is t

Re: [Xen-devel] [PATCH] build: remove tboot make targets

2018-08-20 Thread Jan Beulich
>>> On 19.08.18 at 04:22, wrote: > The tboot targets are woefully out of date. These should really be > retired because setting up tboot is more complex than the build process > for it. > > Signed-off-by: Doug Goldstein Acked-by: Jan Beulich But I think you would better have Cc-ed the TXT/TBO

[Xen-devel] [PATCH] tools/tests: fix an xs-test.c issue

2018-08-20 Thread Wei Liu
The ret variable can be used uninitialised when iters is 0. Initialise ret at the beginning to fix this issue. Reported-by: Steven Haigh Signed-off-by: Wei Liu --- tools/tests/xenstore/xs-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tests/xenstore/xs-test.c b

Re: [Xen-devel] [PATCH] build: remove tboot make targets

2018-08-20 Thread Wei Liu
On Sat, Aug 18, 2018 at 09:22:05PM -0500, Doug Goldstein wrote: > The tboot targets are woefully out of date. These should really be > retired because setting up tboot is more complex than the build process > for it. > > Signed-off-by: Doug Goldstein Acked-by: Wei Liu _

Re: [Xen-devel] [PATCH 1/2] x86/xen: don't write ptes directly in 32-bit PV guests

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 07:14, wrote: > In some cases 32-bit PAE PV guests still write PTEs directly instead of > using hypercalls. This is especially bad when clearing a PTE as this is > done via 32-bit writes which will produce intermediate L1TF attackable > PTEs. > > Change the code to use hypercal

Re: [Xen-devel] [PATCH 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case

2018-08-20 Thread Zhenzhong Duan
On 2018/8/20 16:30, Jan Beulich wrote: On 20.08.18 at 05:32, wrote: When TBOOT enabled, acpi_parse_dmar() zap a copy of DMAR table rather than the real table, so make it controled by config option based on the fact that we already have done the real zapping in tboot_parse_dmar_table(). Is thi

Re: [Xen-devel] [PATCH 2/2] x86/pae: use 64 bit atomic xchg function in native_ptep_get_and_clear

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 07:14, wrote: > @@ -148,14 +150,14 @@ static inline void pud_clear(pud_t *pudp) > #ifdef CONFIG_SMP > static inline pte_t native_ptep_get_and_clear(pte_t *ptep) > { > - pte_t res; > + union { > + pte_t pte; > + long long val; > + } res; Wh

Re: [Xen-devel] [PATCH] libgnttab: Add support for Linux dma-buf

2018-08-20 Thread Oleksandr Andrushchenko
ping On 07/23/2018 03:27 PM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Add support for Linux grant device driver extension which allows converting existing dma-buf's into an array of grant references and vise versa. This is only implemented for Linux as other OSes have no Li

Re: [Xen-devel] [PATCH 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case

2018-08-20 Thread Andrew Cooper
On 20/08/2018 09:30, Jan Beulich wrote: On 20.08.18 at 05:32, wrote: >> When TBOOT enabled, acpi_parse_dmar() zap a copy of DMAR table rather >> than the real table, so make it controled by config option based on the >> fact that we already have done the real zapping in tboot_parse_dmar_table

Re: [Xen-devel] [PATCH 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 10:40, wrote: > On 2018/8/20 16:30, Jan Beulich wrote: > On 20.08.18 at 05:32, wrote: >>> When TBOOT enabled, acpi_parse_dmar() zap a copy of DMAR table rather >>> than the real table, so make it controled by config option based on the >>> fact that we already have done the

[Xen-devel] [qemu-mainline test] 126174: regressions - FAIL

2018-08-20 Thread osstest service owner
flight 126174 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/126174/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-cubietruck 6 xen-installfail REGR. vs. 125959 Tests which did n

Re: [Xen-devel] [PATCH 2/2] x86/pae: use 64 bit atomic xchg function in native_ptep_get_and_clear

2018-08-20 Thread Juergen Gross
On 20/08/18 10:40, Jan Beulich wrote: On 20.08.18 at 07:14, wrote: >> @@ -148,14 +150,14 @@ static inline void pud_clear(pud_t *pudp) >> #ifdef CONFIG_SMP >> static inline pte_t native_ptep_get_and_clear(pte_t *ptep) >> { >> -pte_t res; >> +union { >> +pte_t pte; >> +

Re: [Xen-devel] [PATCH 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case

2018-08-20 Thread Zhenzhong Duan
On 2018/8/20 16:44, Andrew Cooper wrote: On 20/08/2018 09:30, Jan Beulich wrote: On 20.08.18 at 05:32, wrote: When TBOOT enabled, acpi_parse_dmar() zap a copy of DMAR table rather than the real table, so make it controled by config option based on the fact that we already have done the real za

Re: [Xen-devel] [PATCH 05/34] xen: is_hvm_domain should evaluate to 0 when !CONFIG_HVM

2018-08-20 Thread Wei Liu
On Sun, Aug 19, 2018 at 05:48:17PM +0100, Andrew Cooper wrote: > On 17/08/2018 16:12, Wei Liu wrote: > > Since it is defined in common header file, introduce CONFIG_HVM to > > Arm to avoid breakage. > > > > Signed-off-by: Wei Liu > > --- > > xen/arch/arm/Kconfig| 3 +++ > > xen/include/xen/sc

Re: [Xen-devel] [PATCH 00/34] Make CONFIG_HVM work

2018-08-20 Thread Andrew Cooper
On 17/08/2018 16:12, Wei Liu wrote: > This series goes through x86 code to make CONFIG_HVM work. > > With this series, it is possible to build Xen with PV support only. > > Running `xl info` on a host with PV only Xen: > > root@lcy2-dt108:~# xl info > host : lcy2-dt108 > release

Re: [Xen-devel] [PATCH 00/34] Make CONFIG_HVM work

2018-08-20 Thread Wei Liu
On Mon, Aug 20, 2018 at 10:13:07AM +0100, Andrew Cooper wrote: > On 17/08/2018 16:12, Wei Liu wrote: > > This series goes through x86 code to make CONFIG_HVM work. > > > > With this series, it is possible to build Xen with PV support only. > > > > Running `xl info` on a host with PV only Xen: > > >

Re: [Xen-devel] [RFC PATCH 1/2] xen/arm: Add Amlogic S905 SoC early printk support

2018-08-20 Thread Amit Tomer
Hello, > I would prefer if no new alias are added. The same could be achieved with > CONFIG_EARLY_PRINTK=meson,0xc81004c0. > > This could be documented on the wiki. Ok. > I would prefer if we stick with the spec name. So UART_TX_REG should be > renamed UART_WFIFO_REG. Yeah right, got your point

Re: [Xen-devel] [PATCH 15/15] xen/arm: traps: Move the implementation of GUEST_BUG_ON in traps.h

2018-08-20 Thread Julien Grall
Hi Stefano, On Thu, 16 Aug 2018, 19:17 Stefano Stabellini, wrote: > On Thu, 16 Aug 2018, Julien Grall wrote: > > Hi Stefano, > > > > On 08/14/2018 10:43 PM, Stefano Stabellini wrote: > > > On Mon, 16 Jul 2018, Julien Grall wrote: > > > > GUEST_BUG_ON may be used in other files doing guest emulat

Re: [Xen-devel] [PATCH 05/34] xen: is_hvm_domain should evaluate to 0 when !CONFIG_HVM

2018-08-20 Thread Andrew Cooper
On 20/08/2018 10:06, Wei Liu wrote: > On Sun, Aug 19, 2018 at 05:48:17PM +0100, Andrew Cooper wrote: >> On 17/08/2018 16:12, Wei Liu wrote: >>> Since it is defined in common header file, introduce CONFIG_HVM to >>> Arm to avoid breakage. >>> >>> Signed-off-by: Wei Liu >>> --- >>> xen/arch/arm/Kco

[Xen-devel] [ovmf test] 126238: all pass - PUSHED

2018-08-20 Thread osstest service owner
flight 126238 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/126238/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 43fe4c4052922c6baa36cf4664ce63b8699d9176 baseline version: ovmf 0258ba6256ca193e8fd89

Re: [Xen-devel] [PATCH 04/34] x86/mm: don't reference hvm_funcs directly

2018-08-20 Thread Andrew Cooper
On 17/08/2018 16:12, Wei Liu wrote: > diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h > index 4f720ad..146720c 100644 > --- a/xen/include/asm-x86/hvm/hvm.h > +++ b/xen/include/asm-x86/hvm/hvm.h > @@ -454,6 +454,11 @@ static inline int hvm_event_pending(struct vcpu *v) >

Re: [Xen-devel] [PATCH v2 2/2] x86/mmcfg/drhd: Move acpi_mmcfg_init() call before calling acpi_parse_dmar()

2018-08-20 Thread Zhenzhong Duan
On 2018/8/20 15:45, Jan Beulich wrote: On 20.08.18 at 05:38, wrote: On 2018/8/17 20:28, Jan Beulich wrote: On 17.08.18 at 09:01, wrote: pci_conf_read8() needs pci mmcfg mapping to work on multiple pci segments system such as HPE Superdome-Flex. Move acpi_mmcfg_init() call in acpi_boot_init(

Re: [Xen-devel] [PATCH 05/34] xen: is_hvm_domain should evaluate to 0 when !CONFIG_HVM

2018-08-20 Thread Wei Liu
On Mon, Aug 20, 2018 at 10:23:47AM +0100, Andrew Cooper wrote: > > > >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > >> index 51ceebe..fdd18a7 100644 > >> --- a/xen/include/xen/sched.h > >> +++ b/xen/include/xen/sched.h > >> @@ -879,8 +879,17 @@ void watchdog_domain_destroy(stru

Re: [Xen-devel] Armv8-A: Not able to enable secondary CPUs in Hikey960 board

2018-08-20 Thread Omkar Bolla
Hi Julien, I tried today with your patch in xen-4.11 Still has secondary cpus problems, Please find below log after that patch in xen-4.11 Loading driver at 0x000B03B5000 EntryPoint=0x000B044907C Loading driver at 0x000B03B5000 EntryPoint=

[Xen-devel] Xen Security Advisory 270 v3 (CVE-2018-15471) - Linux netback driver OOB access in hash handling

2018-08-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-15471 / XSA-270 version 3 Linux netback driver OOB access in hash handling UPDATES IN VERSION 3 CVE assigned. ISSUE DESCRIPTION =

[Xen-devel] Xen Security Advisory 272 v3 (CVE-2018-15470) - oxenstored does not apply quota-maxentity

2018-08-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-15470 / XSA-272 version 3 oxenstored does not apply quota-maxentity UPDATES IN VERSION 3 CVE assigned. ISSUE DESCRIPTION

[Xen-devel] Xen Security Advisory 269 v3 (CVE-2018-15468) - x86: Incorrect MSR_DEBUGCTL handling lets guests enable BTS

2018-08-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-15468 / XSA-269 version 3 x86: Incorrect MSR_DEBUGCTL handling lets guests enable BTS UPDATES IN VERSION 3 CVE assigned. ISSUE DESCRIPTION ===

[Xen-devel] Xen Security Advisory 268 v3 (CVE-2018-15469) - Use of v2 grant tables may cause crash on ARM

2018-08-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-15469 / XSA-268 version 3 Use of v2 grant tables may cause crash on ARM UPDATES IN VERSION 3 CVE assigned. ISSUE DESCRIPTION ==

Re: [Xen-devel] [PATCH] x86/mm: re-arrange get_page_from_le() vs pv_l1tf_check_le

2018-08-20 Thread Wei Liu
On Fri, Aug 17, 2018 at 12:42:31AM -0600, Jan Beulich wrote: > Restore symmetry between get_page_from_le(): pv_l1tf_check_le is > uniformly invoked from outside of them. They're no longer getting called > for non-present PTEs. This way the slightly odd three-way return value > meaning of the higher

[Xen-devel] [PATCH] osstest: setup git proxy for FreeBSD

2018-08-20 Thread Roger Pau Monne
Make the git proxy setup common by moving it into TestSupport and use it for both Linux and FreeBSD. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson --- Osstest/TestSupport.pm | 20 ts-build-prep-freebsd | 1 + ts-xen-build-prep | 19 --- 3 files c

Re: [Xen-devel] [PATCH] tools: libxl/xl: run NUMA placement even when an hard-affinity is set

2018-08-20 Thread Wei Liu
On Fri, Aug 17, 2018 at 07:03:03PM +0200, Dario Faggioli wrote: > Right now, if either an hard or soft-affinity are explicitly specified > in a domain's config file, automatic NUMA placement is skipped. However, > automatic NUMA placement affects only the soft-affinity of the domain > which is bein

Re: [Xen-devel] [PATCH 04/34] x86/mm: don't reference hvm_funcs directly

2018-08-20 Thread Wei Liu
On Mon, Aug 20, 2018 at 10:28:21AM +0100, Andrew Cooper wrote: > On 17/08/2018 16:12, Wei Liu wrote: > > diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h > > index 4f720ad..146720c 100644 > > --- a/xen/include/asm-x86/hvm/hvm.h > > +++ b/xen/include/asm-x86/hvm/hvm.h > > @

Re: [Xen-devel] [PATCH 2/2] xenpmd: make 32 bit gcc 8.1 non-debug build work

2018-08-20 Thread Ian Jackson
Wei Liu writes ("[PATCH 2/2] xenpmd: make 32 bit gcc 8.1 non-debug build work"): > 32 bit gcc 8.1 non-debug build yields: ... > /* write 9 dwords (so 9*4) + length of 4 strings + 4 null terminators */ > -snprintf(val, 3, "%02x", > - (unsigned int)(9*4 + > -

Re: [Xen-devel] [PATCH 1/2] tools: update ipxe changeset

2018-08-20 Thread Ian Jackson
Wei Liu writes ("[PATCH 1/2] tools: update ipxe changeset"): > This placates gcc 8.1. The commit comes from ipxe master branch as of > July 25, 2018. Fine, whatever. FTR, I don't think it is useful to ask for an ack of this kind of patch, assuming the commit is indeed from ipxe master. (And if so

Re: [Xen-devel] [PATCH] tools/kdd: work around gcc 8.1 bug

2018-08-20 Thread Ian Jackson
Wei Liu writes ("[PATCH] tools/kdd: work around gcc 8.1 bug"): > Gcc 8.1 has a bug that causes kdd fail to build. Rewrite the code to > work around that bug. Acked-by: Ian Jackson Thanks, Ian. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH] tools/tests: fix an xs-test.c issue

2018-08-20 Thread Ian Jackson
Wei Liu writes ("[PATCH] tools/tests: fix an xs-test.c issue"): > The ret variable can be used uninitialised when iters is 0. Initialise > ret at the beginning to fix this issue. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xenproje

Re: [Xen-devel] [PATCH] osstest: setup git proxy for FreeBSD

2018-08-20 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH] osstest: setup git proxy for FreeBSD"): > Make the git proxy setup common by moving it into TestSupport and use > it for both Linux and FreeBSD. Can you please split the code motion from the functional change ? Thanks, Ian. ___

[Xen-devel] [PATCH v2 1/2] dmar: iommu mem leak fix

2018-08-20 Thread Zhenzhong Duan
Release memory allocated for drhd iommu in error path. -v2: fixup wrong parameter hiden due to my removing -Werror Signed-off-by: Zhenzhong Duan --- xen/drivers/passthrough/vtd/dmar.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xen/drivers/passthrough/vtd/dmar.c b/

[Xen-devel] [PATCH v2 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case

2018-08-20 Thread Zhenzhong Duan
When TBOOT enabled, acpi_parse_dmar() zap a copy of DMAR table rather than the real table, so make it controled by config option based on the fact that we already have done the real zapping in tboot_parse_dmar_table(). As said above, acpi_parse_dmar() doesn't zaps APCI DMAR signature in real TXT h

[Xen-devel] [PATCH 2/2] osstest: configure git proxy for FreeBSD

2018-08-20 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson --- ts-build-prep-freebsd | 1 + 1 file changed, 1 insertion(+) diff --git a/ts-build-prep-freebsd b/ts-build-prep-freebsd index e3220fa8..0ed30be4 100755 --- a/ts-build-prep-freebsd +++ b/ts-build-prep-freebsd @@ -38,6 +38,7 @@ sub install_dep

[Xen-devel] [PATCH 1/2] osstest: make git proxy setup common

2018-08-20 Thread Roger Pau Monne
By moving it into TestSupport. No functional change. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson --- Osstest/TestSupport.pm | 20 ts-xen-build-prep | 19 --- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/Osstest/TestSupport.pm

Re: [Xen-devel] [PATCH 1/2] osstest: make git proxy setup common

2018-08-20 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH 1/2] osstest: make git proxy setup common"): > By moving it into TestSupport. No functional change. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/lis

Re: [Xen-devel] [PATCH 2/2] osstest: configure git proxy for FreeBSD

2018-08-20 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH 2/2] osstest: configure git proxy for FreeBSD"): > Signed-off-by: Roger Pau Monné Acked-by: Ian Jackson Thanks. Do you want me to push these to pretest soon ? Ian. ___ Xen-devel mailing list Xen-devel@lists.xenprojec

Re: [Xen-devel] [PATCH 2/2] osstest: configure git proxy for FreeBSD

2018-08-20 Thread Roger Pau Monné
On Mon, Aug 20, 2018 at 11:53:17AM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH 2/2] osstest: configure git proxy for > FreeBSD"): > > Signed-off-by: Roger Pau Monné > > Acked-by: Ian Jackson > > Thanks. > > Do you want me to push these to pretest soon ? If you could, yes plea

[Xen-devel] 答复: [PATCH v2 2/2] x86/dmar: zap DMAR signature for dom0 once in TBOOT case

2018-08-20 Thread Zhenzhong Duan
Please ignore this patch, looks description is wrong, I'll resend, sorry for noise. Zhenzhong - zhenzhong.d...@oracle.com wrote: > When TBOOT enabled, acpi_parse_dmar() zap a copy of DMAR table rather > than the real table, so make it controled by config option based on > the > fact that we

Re: [Xen-devel] [PATCH v2 2/2] x86/mmcfg/drhd: Move acpi_mmcfg_init() call before calling acpi_parse_dmar()

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 11:38, wrote: > On 2018/8/20 15:45, Jan Beulich wrote: > On 20.08.18 at 05:38, wrote: >>> I'm thinking about moving below piece of code earlier too, and I checked >>> pci_mmcfg_check_hostbridge() carefully, it's secure, what do you think >>> about that? >>> >>> mmio_r

Re: [Xen-devel] [PATCH] x86/mm: re-arrange get_page_from_le() vs pv_l1tf_check_le

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 11:59, wrote: > On Fri, Aug 17, 2018 at 12:42:31AM -0600, Jan Beulich wrote: >> Restore symmetry between get_page_from_le(): pv_l1tf_check_le is >> uniformly invoked from outside of them. They're no longer getting called >> for non-present PTEs. This way the slightly odd three-w

Re: [Xen-devel] [PATCH 2/2] osstest: configure git proxy for FreeBSD

2018-08-20 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD"): > On Mon, Aug 20, 2018 at 11:53:17AM +0100, Ian Jackson wrote: > > Do you want me to push these to pretest soon ? > > If you could, yes please. I'm hoping this will unblock the FreeBSD > build, or at least get it

Re: [Xen-devel] [PATCH v2 1/2] dmar: iommu mem leak fix

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 12:42, wrote: > Release memory allocated for drhd iommu in error path. > > -v2: fixup wrong parameter hiden due to my removing -Werror This line belongs ... > Signed-off-by: Zhenzhong Duan > --- ... here, so it won't end up in the commit message. Still Reviewed-by: Jan Beu

Re: [Xen-devel] [PATCH 05/34] xen: is_hvm_domain should evaluate to 0 when !CONFIG_HVM

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > Since it is defined in common header file, introduce CONFIG_HVM to > Arm to avoid breakage. > > Signed-off-by: Wei Liu > --- > xen/arch/arm/Kconfig| 3 +++ > xen/include/xen/sched.h | 6 ++ > 2 files changed, 9 insertions(+) > > diff --git a/xen/arch/

Re: [Xen-devel] [PATCH 07/34] x86: only call memory_type_changed for HVM guests

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -416,7 +416,7 @@ long arch_do_domctl( > ret = ioports_permit_access(d, fp, fp + np - 1); > else > ret = ioports_deny_access(d, fp, fp + np - 1); > -if ( !ret

Re: [Xen-devel] [PATCH 08/34] x86: enclose hvm_op and dm_op in CONFIG_HVM in PV hypercall table

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > --- a/xen/arch/x86/pv/hypercall.c > +++ b/xen/arch/x86/pv/hypercall.c > @@ -68,7 +68,9 @@ const hypercall_table_t pv_hypercall_table[] = { > #endif > HYPERCALL(event_channel_op), > COMPAT_CALL(physdev_op), > +#ifdef CONFIG_HVM > HYPERCALL(hvm_op),

Re: [Xen-devel] [PATCH 09/34] x86: guard HAS_VPCI with CONFIG_HVM

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > VPCI is only useful for PVH / HVM guests. Ideally CONFIG_HVM should > imply !PV_SHIM_EXCLUSIVE, but we still want to build PV_SHIM_EXCLUSIVE > with CONFIG_HVM at this stage because a lot of things are still > entangled. Hmm, yes, this would probably not work thi

Re: [Xen-devel] [PATCH 13/34] x86/pt: split out HVM functions from vtd.c

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > --- /dev/null > +++ b/xen/drivers/passthrough/vtd/x86/hvm.c > @@ -0,0 +1,77 @@ > +/* > + * Copyright (c) 2008, Intel Corporation. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU G

Re: [Xen-devel] [PATCH 10/34] x86: stub out has_* testing for emulation flags

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > Most are all HVM only. Provide stubs for !CONFIG_HVM. > > One exception is PIT emulation, which is available to both PV and HVM. > > Signed-off-by: Wei Liu > --- > xen/include/asm-x86/domain.h | 24 +++- > 1 file changed, 23 insertions(+),

Re: [Xen-devel] [PATCH 11/34] xen/pt: io.c contains HVM only code

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > --- a/xen/drivers/passthrough/Makefile > +++ b/xen/drivers/passthrough/Makefile > @@ -4,6 +4,8 @@ subdir-$(CONFIG_X86) += x86 > subdir-$(CONFIG_ARM) += arm > > obj-y += iommu.o > -obj-$(CONFIG_X86) += io.o > +ifeq ($(CONFIG_X86),y) > +obj-$(CONFIG_HVM) += io.

Re: [Xen-devel] [PATCH 12/34] x86/pt: only call some functions for HVM guests

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: For the subject, do you perhaps mean "call some functions for HVM guests only"? Otherwise, putting emphasis on "some", the sense gets sort of inverted from what I think you mean. > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -561,7 +561,9 @

Re: [Xen-devel] [PATCH 14/34] x86/pt: add HVM check to XEN_DOMCTL_unbind_pt_irq

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > Its counterpart is HVM only. Add the check to help dead code > elimination to figure out the call to pt_irq_destroy_bind is not > needed when HVM is not enabled. > > Signed-off-by: Wei Liu Acked-by: Jan Beulich And strictly speaking this would make more sens

Re: [Xen-devel] [PATCH 15/34] x86/nestedhvm: make it build with !CONFIG_HVM

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: The title isn't very consistent within itself: Nested-HVM code is certainly not to be built without CONFIG_HVM. > @@ -70,7 +74,18 @@ unsigned long *nestedhvm_vcpu_iomap_get(bool_t ioport_80, > bool_t ioport_ed); > > void nestedhvm_vmcx_flushtlb(struct p2m_dom

Re: [Xen-devel] [PATCH 31/34] xen: refuse to create HVM guests when !CONFIG_HVM

2018-08-20 Thread Andrew Cooper
On 17/08/2018 16:12, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > xen/common/domain.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/xen/common/domain.c b/xen/common/domain.c > index 171d25e..a22df12 100644 > --- a/xen/common/domain.c > +++ b/xen/common/domain.

[Xen-devel] [PATCH] x86/xen: remove unused function xen_auto_xlated_memory_setup()

2018-08-20 Thread Juergen Gross
xen_auto_xlated_memory_setup() is a leftover from PVH V1. Remove it. Signed-off-by: Juergen Gross --- arch/x86/xen/setup.c | 31 --- arch/x86/xen/xen-ops.h | 1 - 2 files changed, 32 deletions(-) diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index 6e0d2

Re: [Xen-devel] [PATCH 16/34] x86/hvm: enclose hvm_enabled and hvm_funcs in CONFIG_HVM

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > This helps to take advantage of dead code elimination. Turn > hvm_enabled into proper bool while at it. > > Providing an empty hvm_funcs resolves a lot of undefined references to > it in the header. It is safe to do so because those functions / macros > are not

[Xen-devel] [PATCH] xen: remove unused hypercall functions

2018-08-20 Thread Juergen Gross
Remove Xen hypercall functions which are used nowhere in the kernel. Signed-off-by: Juergen Gross --- arch/x86/include/asm/xen/hypercall.h | 118 --- 1 file changed, 118 deletions(-) diff --git a/arch/x86/include/asm/xen/hypercall.h b/arch/x86/include/asm/xen/hy

Re: [Xen-devel] [PATCH 17/34] x86/vmce: enclose HVM load / save code in CONFIG_HVM

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 18/34] x86/amd: skip OSVW function calls if !CONFIG_HVM

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > The two functions are not needed when HVM is not supported in > hypervisor. > > Note that using hvm_enabled won't work because early_microcode_init > gets to cpu_request_microcode before hvm_enabled is set in presmp init > call stage. > > Signed-off-by: Wei Liu

Re: [Xen-devel] [PATCH] x86/mm: re-arrange get_page_from_le() vs pv_l1tf_check_le

2018-08-20 Thread Wei Liu
On Mon, Aug 20, 2018 at 05:37:32AM -0600, Jan Beulich wrote: > >>> On 20.08.18 at 11:59, wrote: > > On Fri, Aug 17, 2018 at 12:42:31AM -0600, Jan Beulich wrote: > >> Restore symmetry between get_page_from_le(): pv_l1tf_check_le is > >> uniformly invoked from outside of them. They're no longer gett

Re: [Xen-devel] [PATCH 19/34] x86: check HVM before trying to get ioreq server

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 17:12, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -4382,6 +4382,10 @@ int arch_acquire_resource(struct domain *d, unsigned > int type, > unsigned int i; > > rc = -EINVAL; > +if ( !is_hvm_domain(d) ) > +break; > + > +

Re: [Xen-devel] [PATCH 08/34] x86: enclose hvm_op and dm_op in CONFIG_HVM in PV hypercall table

2018-08-20 Thread Wei Liu
On Mon, Aug 20, 2018 at 05:59:38AM -0600, Jan Beulich wrote: > >>> On 17.08.18 at 17:12, wrote: > > --- a/xen/arch/x86/pv/hypercall.c > > +++ b/xen/arch/x86/pv/hypercall.c > > @@ -68,7 +68,9 @@ const hypercall_table_t pv_hypercall_table[] = { > > #endif > > HYPERCALL(event_channel_op), > >

[Xen-devel] [xen-unstable baseline-only test] 75091: regressions - FAIL

2018-08-20 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75091 xen-unstable real [real] http://osstest.xensource.com/osstest/logs/75091/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-i386-pvgrub 10 debian-di-install

Re: [Xen-devel] [PATCH] x86/xen: enable early use of set_fixmap in 32-bit Xen PV guest

2018-08-20 Thread Thomas Gleixner
On Fri, 17 Aug 2018, Juergen Gross wrote: > Commit 7b25b9cb0dad83 ("x86/xen/time: Initialize pv xen time in > init_hypervisor_platform()") moved the mapping of the shared info area > before pagetable_init(). This breaks booting as 32-bit PV guest as the > use of set_fixmap isn't possible at this t

Re: [Xen-devel] [PATCH 2/2] x86/pae: use 64 bit atomic xchg function in native_ptep_get_and_clear

2018-08-20 Thread Thomas Gleixner
On Mon, 20 Aug 2018, Juergen Gross wrote: > In case adding about 6 cycles for native_ptep_get_and_clear() is believed > to be too bad I can modify the patch to add a paravirt function for that > purpose in order to add the overhead for Xen guests only (in fact the > overhead for Xen guests will be

Re: [Xen-devel] [PATCH 2/2] osstest: configure git proxy for FreeBSD

2018-08-20 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH 2/2] osstest: configure git proxy for FreeBSD"): > On Mon, Aug 20, 2018 at 11:53:17AM +0100, Ian Jackson wrote: > > Roger Pau Monne writes ("[PATCH 2/2] osstest: configure git proxy for > > FreeBSD"): > > > Signed-off-by: Roger Pau Monné > > > > Acked-by: Ian

Re: [Xen-devel] [PATCH] xenpmd: prevent format-truncation warning with gcc 8.2 + ARM 32-bit

2018-08-20 Thread Wei Liu
On Fri, Aug 17, 2018 at 06:22:16PM -0700, Christopher Clark wrote: > xenpmd writes battery information to xenstore, including a string with a > formatted hex value calculated from summing the lengths of four strings, > plus some constants. > > Each of the four strings has a maximum length of 31 by

Re: [Xen-devel] [PATCH] tools: libxl/xl: run NUMA placement even when an hard-affinity is set

2018-08-20 Thread Dario Faggioli
On Mon, 2018-08-20 at 11:14 +0100, Wei Liu wrote: > On Fri, Aug 17, 2018 at 07:03:03PM +0200, Dario Faggioli wrote: > > @@ -27,6 +27,8 @@ > > > > #include "_paths.h" > > > > +//#define DEBUG 1 > > + > > Stray changes here? > > You can use NDEBUG instead. > I found this in one other place in

[Xen-devel] [freebsd-master test] 126247: tolerable FAIL - PUSHED

2018-08-20 Thread osstest service owner
flight 126247 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/126247/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-amd64-xen-freebsd 7 xen-build-freebsdfail never pass version targeted for testing: fre

Re: [Xen-devel] [PATCH] libxl: Handle deprecation of QEMU's -usbdevice

2018-08-20 Thread Wei Liu
On Wed, Jul 25, 2018 at 11:43:29AM +0100, Anthony PERARD wrote: > On Wed, Jul 25, 2018 at 09:38:20AM +0100, Wei Liu wrote: > > On Thu, Jul 19, 2018 at 06:29:29PM +0100, Anthony PERARD wrote: > > > -usbdevice is deprecated as of QEMU 2.10. > > > > > > This patch replace the few options documented i

Re: [Xen-devel] [PATCH 2/2] osstest: configure git proxy for FreeBSD

2018-08-20 Thread Roger Pau Monné
On Mon, Aug 20, 2018 at 03:04:37PM +0100, Ian Jackson wrote: > Roger Pau Monné writes ("Re: [PATCH 2/2] osstest: configure git proxy for > FreeBSD"): > > On Mon, Aug 20, 2018 at 11:53:17AM +0100, Ian Jackson wrote: > > > Roger Pau Monne writes ("[PATCH 2/2] osstest: configure git proxy for > > >

Re: [Xen-devel] [PATCH] libgnttab: Add support for Linux dma-buf

2018-08-20 Thread Wei Liu
On Mon, Jul 23, 2018 at 03:27:25PM +0300, Oleksandr Andrushchenko wrote: [...] > diff --git a/tools/libs/gnttab/linux.c b/tools/libs/gnttab/linux.c > index 8347ddd3d9cf..9765146f7eb6 100644 > --- a/tools/libs/gnttab/linux.c > +++ b/tools/libs/gnttab/linux.c > @@ -1,5 +1,6 @@ > /* > * Copyright (

[Xen-devel] [xen-unstable-smoke test] 126253: tolerable all pass - PUSHED

2018-08-20 Thread osstest service owner
flight 126253 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/126253/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[Xen-devel] [linux-4.9 test] 126187: regressions - FAIL

2018-08-20 Thread osstest service owner
flight 126187 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/126187/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-rumprun-amd64 12 guest-startfail REGR. vs. 125183 test-amd64-amd64-libv

Re: [Xen-devel] [PATCH v4 07/32] libxl_qmp: Move struct sockaddr_un variable to qmp_open()

2018-08-20 Thread Wei Liu
On Fri, Jul 27, 2018 at 03:05:49PM +0100, Anthony PERARD wrote: > This variable is only used once, no need to keep it in the handler. > > Also fix coding style (remove space after sizeof). > And allow strncpy to use all the space in sun_path. > > Signed-off-by: Anthony PERARD Acked-by: Wei Liu

[Xen-devel] [ovmf test] 126250: all pass - PUSHED

2018-08-20 Thread osstest service owner
flight 126250 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/126250/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 131818ba5a83d1e8f3f1b4c041200755fff64abb baseline version: ovmf 43fe4c4052922c6baa36c

Re: [Xen-devel] [PATCH v4 08/32] libxl: Add libxl__prepare_sockaddr_un() helper

2018-08-20 Thread Wei Liu
On Fri, Jul 27, 2018 at 03:05:50PM +0100, Anthony PERARD wrote: > There is going to be a few more users that want to use UNIX socket, this > helper is to prepare the `struct sockaddr_un` and check that the path > isn't too long. > > Also start to use it in libxl_qmp.c. > > Signed-off-by: Anthony

Re: [Xen-devel] [PATCH 2/2] x86/pae: use 64 bit atomic xchg function in native_ptep_get_and_clear

2018-08-20 Thread Juergen Gross
On 20/08/18 15:26, Thomas Gleixner wrote: > On Mon, 20 Aug 2018, Juergen Gross wrote: >> In case adding about 6 cycles for native_ptep_get_and_clear() is believed >> to be too bad I can modify the patch to add a paravirt function for that >> purpose in order to add the overhead for Xen guests only

Re: [Xen-devel] [PATCH v4 09/32] libxl_qmp: Remove unused yajl_ctx from handler

2018-08-20 Thread Wei Liu
On Fri, Jul 27, 2018 at 03:05:51PM +0100, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > Acked-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-deve

Re: [Xen-devel] [PATCH v4 11/32] libxl_dm: Add libxl__qemu_qmp_path()

2018-08-20 Thread Wei Liu
On Fri, Jul 27, 2018 at 03:05:53PM +0100, Anthony PERARD wrote: > ... which generate the path to a QMP socket that libxl uses. > > Signed-off-by: Anthony PERARD Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists

Re: [Xen-devel] [PATCH] libxl: Handle deprecation of QEMU's -usbdevice

2018-08-20 Thread Anthony PERARD
On Mon, Aug 20, 2018 at 03:32:58PM +0100, Wei Liu wrote: > On Wed, Jul 25, 2018 at 11:43:29AM +0100, Anthony PERARD wrote: > > On Wed, Jul 25, 2018 at 09:38:20AM +0100, Wei Liu wrote: > > > How does libvirt handle QEMU option deprecation? > > > > I don't think they handle it very well. I think it'

[Xen-devel] [PATCH RESEND] x86/xen: enable early use of set_fixmap in 32-bit Xen PV guest

2018-08-20 Thread Juergen Gross
Commit 7b25b9cb0dad83 ("x86/xen/time: Initialize pv xen time in init_hypervisor_platform()") moved the mapping of the shared info area before pagetable_init(). This breaks booting as 32-bit PV guest as the use of set_fixmap isn't possible at this time on 32-bit. This can be worked around by popula

[Xen-devel] [PATCH] MAINTAINERS: add myself as a reviewer for x86 patches

2018-08-20 Thread Wei Liu
Signed-off-by: Wei Liu --- Since I'm changing x86 code all over the place, I'd better keep up with what's going on. --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f28d0e1ee0..1970100b37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -440,6 +440,

[Xen-devel] [PATCH] MAINTAINERS: add myself as a reviewer for x86 patches

2018-08-20 Thread Wei Liu
Signed-off-by: Wei Liu --- Since I'm changing x86 code all over the place, I'd better keep up with what's going on. --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f28d0e1ee0..1970100b37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -440,6 +440,

Re: [Xen-devel] Future of 32-bit PV support

2018-08-20 Thread Manuel Bouyer
On Thu, Aug 16, 2018 at 08:17:13AM +0200, Juergen Gross wrote: > In the Xen x86 community call we have been discussing whether anyone > really is depending on 32-bit PV guests. We'd like to evaluate whether > anyone would see problems with: > > - deprecating 32-bit PV guest support in Xen, meaning

Re: [Xen-devel] Future of 32-bit PV support

2018-08-20 Thread Juergen Gross
On 20/08/18 17:31, Manuel Bouyer wrote: > On Thu, Aug 16, 2018 at 08:17:13AM +0200, Juergen Gross wrote: >> In the Xen x86 community call we have been discussing whether anyone >> really is depending on 32-bit PV guests. We'd like to evaluate whether >> anyone would see problems with: >> >> - depre

Re: [Xen-devel] [PATCH] MAINTAINERS: add myself as a reviewer for x86 patches

2018-08-20 Thread Jan Beulich
>>> On 20.08.18 at 17:25, wrote: > Signed-off-by: Wei Liu Acked-by: Jan Beulich And thanks for all the help you've provided here already, plus all the reviews to come. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xe

Re: [Xen-devel] [Xen-users] Future of 32-bit PV support

2018-08-20 Thread Hans van Kranenburg
On 08/17/2018 06:09 AM, Juergen Gross wrote: > On 17/08/18 00:33, Andy Smith wrote: >> Hi Juergen, >> >> [...] >> If so, could the final removal of 32-bit PV in the Linux kernel be >> held off until there is: >> >> 1) a kernel shipping in Debian stable, Ubuntu LTS and CentOS that >>boots under

  1   2   >