[Xen-devel] [ovmf baseline-only test] 74952: all pass

2018-07-11 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74952 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74952/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e4e314b1b6b74c46da3c0493e7a807df28cb9aed baseline v

Re: [Xen-devel] [PATCH] automation: fix builds with clang

2018-07-11 Thread Wei Liu
On Tue, Jul 10, 2018 at 05:58:58PM -0500, Doug Goldstein wrote: > a75703b2f0f585a2fc6a7bcdb7d16a61bcf5e6b0 unconditionally enabled > building of rombios and stubdoms but unfortunately these two pieces do > not build successfully with clang. rombios unconditionally depends on > the build of iPXE and

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Jan Beulich
>>> On 10.07.18 at 17:35, wrote: > On Tue, Jul 10, 2018 at 08:09:06AM -0600, Jan Beulich wrote: >> >>> On 10.07.18 at 15:49, wrote: >> > On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: >> >> >>> On 10.07.18 at 13:00, wrote: >> >> > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau

Re: [Xen-devel] [PATCH] mm/page_alloc: correct first_dirty calculations during block merging

2018-07-11 Thread Sergey Dyasli
On Tue, 2018-07-10 at 11:34 -0400, Boris Ostrovsky wrote: > On 07/10/2018 11:15 AM, Jan Beulich wrote: > > > > > On 10.07.18 at 16:49, wrote: > > > > > > Currently it's possible to hit an assertion in alloc_heap_pages(): > > > > > > Assertion 'first_dirty != INVALID_DIRTY_IDX || !(pg[i].count_in

Re: [Xen-devel] [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-11 Thread Jan Beulich
>>> On 10.07.18 at 18:18, wrote: >> From: George Dunlap [mailto:george.dun...@citrix.com] >> Sent: 10 July 2018 17:13 >> On 07/07/2018 12:05 PM, Paul Durrant wrote: >> > @@ -1144,14 +1146,13 @@ map_grant_ref( >> > !(old_pin & (GNTPIN_hstw_mask|GNTPIN_devw_mask)) ) >> > { >>

Re: [Xen-devel] [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions

2018-07-11 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 11 July 2018 08:57 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Wei Liu > ; Jun Nakajima ; Kevin Tian > ; Stefano Stabellini ; xen- > devel ; Konrad Rzeszutek Wilk > ; T

[Xen-devel] [distros-debian-squeeze test] 74953: tolerable FAIL

2018-07-11 Thread Platform Team regression test user
flight 74953 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74953/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-i386-squeeze-netboot-pygrub 10 debian-di-install fail like 74934 test-amd64-amd64-amd

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monné
On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 17:35, wrote: > > On Tue, Jul 10, 2018 at 08:09:06AM -0600, Jan Beulich wrote: > >> >>> On 10.07.18 at 15:49, wrote: > >> > On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote: > >> >> >>> On 10.07.18 at 13:

Re: [Xen-devel] [PATCH v2 01/13] grant_table: use term 'mfn' for machine frame numbers...

2018-07-11 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 10 July 2018 14:20 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Andrew Cooper ; George Dunlap > ; Ian Jackson ; Jan > Beulich ; Julien Grall ; Konrad > Rzeszutek Wilk ; Stefano Stabellini > ; T

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Jan Beulich
>>> On 11.07.18 at 10:29, wrote: > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: >> Another possible thing to try might be to make the extern declaration >> of the symbol weak, and drop the offending line altogether. > > Oh, that didn't occur to me, and does seem to work. Below is

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: > >>> On 11.07.18 at 10:29, wrote: > > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: > >> Another possible thing to try might be to make the extern declaration > >> of the symbol weak, and drop the offending line altogethe

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monné
On Wed, Jul 11, 2018 at 10:55:56AM +0200, Daniel Kiper wrote: > On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: > > >>> On 11.07.18 at 10:29, wrote: > > > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: > > >> Another possible thing to try might be to make the extern decl

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monné
On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: > >>> On 11.07.18 at 10:29, wrote: > > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: > >> Another possible thing to try might be to make the extern declaration > >> of the symbol weak, and drop the offending line altogethe

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-11 Thread Michal Hocko
On Tue 10-07-18 19:20:20, Leon Romanovsky wrote: > On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > > > T

Re: [Xen-devel] [PATCH v2 06/13] public / x86: introduce __HYPERCALL_iommu_op

2018-07-11 Thread George Dunlap
On 07/07/2018 12:05 PM, Paul Durrant wrote: > +long do_iommu_op(unsigned int nr_bufs, > + XEN_GUEST_HANDLE_PARAM(xen_iommu_op_buf_t) bufs) > +{ > +unsigned int i; > +long rc; > + > +rc = xsm_iommu_op(XSM_PRIV, current->domain); My only comment here is, doesn't this mean

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 10:59:20AM +0200, Roger Pau Monné wrote: > On Wed, Jul 11, 2018 at 10:55:56AM +0200, Daniel Kiper wrote: > > On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: > > > >>> On 11.07.18 at 10:29, wrote: > > > > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wro

Re: [Xen-devel] [PATCH 2/3] xen: set cpu capabilities from xen_start_kernel()

2018-07-11 Thread Woodhouse, David
On Wed, 2018-05-30 at 13:09 +0200, Juergen Gross wrote: > There is no need to set the same capabilities for each cpu > individually. This can easily be done for all cpus when starting the > kernel. > > Upstream commit: 0808e80cb760de2733c0527d2090ed2205a1eef8 ("xen: set > cpu capabilities from xen

Re: [Xen-devel] [PATCH v2 07/13] iommu: track reserved ranges using a rangeset

2018-07-11 Thread George Dunlap
On Sat, Jul 7, 2018 at 12:05 PM, Paul Durrant wrote: > Ranges that should be considered reserved in the IOMMU are not necessarily > limited to RMRRs. If iommu_inclusive_mapping is set then any frame number > falling within an E820 reserved region should also be considered as > reserved in the IOMM

[Xen-devel] [ovmf test] 125100: all pass - PUSHED

2018-07-11 Thread osstest service owner
flight 125100 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/125100/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 99fd30431d565412707f7a1e1a23461d10d07e85 baseline version: ovmf e4e314b1b6b74c46da3c0

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Jan Beulich
>>> On 11.07.18 at 11:02, wrote: > On Wed, Jul 11, 2018 at 02:48:25AM -0600, Jan Beulich wrote: >> >>> On 11.07.18 at 10:29, wrote: >> > On Wed, Jul 11, 2018 at 01:09:30AM -0600, Jan Beulich wrote: >> >> Another possible thing to try might be to make the extern declaration >> >> of the symbol wea

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monné
On Wed, Jul 11, 2018 at 11:11:05AM +0200, Daniel Kiper wrote: > On Wed, Jul 11, 2018 at 10:59:20AM +0200, Roger Pau Monné wrote: > > On Wed, Jul 11, 2018 at 10:55:56AM +0200, Daniel Kiper wrote: > > > If this works in all cases (build with tools with and without PE support, > > > xen.efi and xen.gz

Re: [Xen-devel] [PATCH 2/3] xen: set cpu capabilities from xen_start_kernel()

2018-07-11 Thread Juergen Gross
On 11/07/18 11:15, Woodhouse, David wrote: > On Wed, 2018-05-30 at 13:09 +0200, Juergen Gross wrote: >> There is no need to set the same capabilities for each cpu >> individually. This can easily be done for all cpus when starting the >> kernel. >> >> Upstream commit: 0808e80cb760de2733c0527d2090ed

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-07-11 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 11:36:40AM +0200, Roger Pau Monné wrote: > On Wed, Jul 11, 2018 at 11:11:05AM +0200, Daniel Kiper wrote: > > On Wed, Jul 11, 2018 at 10:59:20AM +0200, Roger Pau Monné wrote: > > > On Wed, Jul 11, 2018 at 10:55:56AM +0200, Daniel Kiper wrote: > > > > If this works in all case

Re: [Xen-devel] [PATCH 2/3] xen: set cpu capabilities from xen_start_kernel()

2018-07-11 Thread Woodhouse, David
On Wed, 2018-07-11 at 11:46 +0200, Juergen Gross wrote: > On 11/07/18 11:15, Woodhouse, David wrote: > > > > On Wed, 2018-05-30 at 13:09 +0200, Juergen Gross wrote: > > > > > > There is no need to set the same capabilities for each cpu > > > individually. This can easily be done for all cpus wh

[Xen-devel] 答复: 答复: 答复: 答复: 答复: Help: a xen crash of 4.8.2 version/////答复: Is there a faster way to restore Virtual machine status in Xen?

2018-07-11 Thread Chenjia (C)
Dear xen expert: From the blocked information, we found that the CPU 14 and CPU 19 is blocked, and the call trace is mainly about: [68915.792526] [] on_each_cpu+0x28/0x60 [68915.792540] [] decrease_reservation+0x261/0x2f0 [68915.792555] [] alloc_xenballooned_pages+0xe6/0x180 [68915.7925

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-11 Thread Leon Romanovsky
On Wed, Jul 11, 2018 at 11:03:53AM +0200, Michal Hocko wrote: > On Tue 10-07-18 19:20:20, Leon Romanovsky wrote: > > On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > > > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > > > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wr

[Xen-devel] [PATCH v2] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monne
lld (the llvm linker) has some issues with Xen linker script. It doesn't understand '||' in assert expressions: ld-melf_x86_64_fbsd -T xen.lds -N prelink.o --build-id=sha1 \ /root/src/xen/xen/common/symbols-dummy.o -o /root/src/xen/xen/.xen-syms.0 ld: error: xen.lds:260: malformed number:

[Xen-devel] [xen-unstable-smoke test] 125101: tolerable all pass - PUSHED

2018-07-11 Thread osstest service owner
flight 125101 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/125101/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH v2 08/13] x86: add iommu_op to query reserved ranges

2018-07-11 Thread George Dunlap
On 07/07/2018 12:05 PM, Paul Durrant wrote: > @@ -35,17 +93,33 @@ static void iommu_op(xen_iommu_op_t *op) > > int do_one_iommu_op(xen_iommu_op_buf_t *buf) > { > -xen_iommu_op_t op; > +xen_iommu_op_t op = {}; > +size_t offset; > +static const size_t op_size[] = { > +[XEN

[Xen-devel] [xen-unstable-coverity test] 125103: all pass - PUSHED

2018-07-11 Thread osstest service owner
flight 125103 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/125103/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen f5d10dc2909c84e4ffc7240e542c513ed480aa04 baseline version: xen 2ddf

Re: [Xen-devel] [PATCH v2] xen/x86: fix linker script to work with lld

2018-07-11 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 12:25:21PM +0200, Roger Pau Monne wrote: > lld (the llvm linker) has some issues with Xen linker script. It > doesn't understand '||' in assert expressions: > > ld-melf_x86_64_fbsd -T xen.lds -N prelink.o --build-id=sha1 \ > /root/src/xen/xen/common/symbols-dummy.o

Re: [Xen-devel] [PATCH v2 09/13] vtd: add lookup_page method to iommu_ops

2018-07-11 Thread George Dunlap
On Sat, Jul 7, 2018 at 12:05 PM, Paul Durrant wrote: > This patch adds a new method to the VT-d IOMMU implementation to find the > MFN currently mapped by the specified BFN along with a wrapper function in > generic IOMMU code to call the implementation if it exists. > > This functionality will be

[Xen-devel] [xen-4.7-testing test] 125057: tolerable FAIL - PUSHED

2018-07-11 Thread osstest service owner
flight 125057 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/125057/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-xtf-amd64-amd64-1 50 xtf/test-hvm64-lbr-tsx-vmentry fail like 124880 test-xtf-amd64-amd64-2 50 xt

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-11 Thread Michal Hocko
On Wed 11-07-18 13:14:47, Leon Romanovsky wrote: > On Wed, Jul 11, 2018 at 11:03:53AM +0200, Michal Hocko wrote: > > On Tue 10-07-18 19:20:20, Leon Romanovsky wrote: > > > On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > > > > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > > >

Re: [Xen-devel] [PATCH v2 11/13] memory: add get_paged_gfn() as a wrapper...

2018-07-11 Thread George Dunlap
On 07/07/2018 12:05 PM, Paul Durrant wrote: > ...for some uses of get_page_from_gfn(). > > There are many occurences of the following pattern in the code: > > q = ? P2M_ALLOC : P2M_UNSHARE; > page = get_page_from_gfn(d, gfn, &p2mt, q); > > if ( p2m_is_paging(p2mt) ) > { >

Re: [Xen-devel] [PATCH v2 3/8] xen/x86: manually build xen.mb.efi binary

2018-07-11 Thread Daniel Kiper
On Tue, Jul 10, 2018 at 07:54:51AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 12:48, wrote: > > On Fri, Jul 06, 2018 at 09:08:29AM -0600, Jan Beulich wrote: > >> >>> On 06.07.18 at 16:02, wrote: > >> > On Thu, Jul 05, 2018 at 02:18:03AM -0600, Jan Beulich wrote: > >> >> >>> On 04.07.18 at 18:

[Xen-devel] [ovmf baseline-only test] 74954: regressions - FAIL

2018-07-11 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74954 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74954/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-build

Re: [Xen-devel] [PATCH v2 12/13] x86: add iommu_ops to modify and flush IOMMU mappings

2018-07-11 Thread George Dunlap
On 07/07/2018 12:05 PM, Paul Durrant wrote: > This patch adds iommu_ops to add (map) or remove (unmap) frames in the > domain's IOMMU mappings, and an iommu_op to synchronize (flush) those > manipulations with the hardware. > > Mappings added by the map operation are tracked and only those mapping

Re: [Xen-devel] [PATCH v2] xen/x86: fix linker script to work with lld

2018-07-11 Thread Roger Pau Monné
On Wed, Jul 11, 2018 at 12:42:48PM +0200, Daniel Kiper wrote: > On Wed, Jul 11, 2018 at 12:25:21PM +0200, Roger Pau Monne wrote: > > lld (the llvm linker) has some issues with Xen linker script. It > > doesn't understand '||' in assert expressions: > > > > ld-melf_x86_64_fbsd -T xen.lds -N pre

[Xen-devel] [ovmf test] 125105: all pass - PUSHED

2018-07-11 Thread osstest service owner
flight 125105 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/125105/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c6a14de3ef30291918f3b15436cf6a75db413eea baseline version: ovmf 99fd30431d565412707f7

[Xen-devel] [PATCH 0/8] x86: (allow to) suppress use of hyper-threading

2018-07-11 Thread Jan Beulich
I've been considering to add a respective command line option for quite a long time, but never got around to. Now that the TLBleed information is public[1], we're at point where we not only want, but need this, and where perhaps it needs to be the default on affected systems. The first 5 patches ar

Re: [Xen-devel] [PATCH v2 8/8] efi: drop original xen.efi code and build mechanism

2018-07-11 Thread Daniel Kiper
On Tue, Jul 10, 2018 at 08:05:56AM -0600, Jan Beulich wrote: > >>> On 10.07.18 at 13:35, wrote: > > On Fri, Jul 06, 2018 at 09:16:38AM -0600, Jan Beulich wrote: > >> >>> On 06.07.18 at 16:46, wrote: > >> > OK, xen.mb.efi does not need relocs because: > >> > - we generate PE file from xen-syms f

Re: [Xen-devel] [PATCH v2] xen/x86: fix linker script to work with lld

2018-07-11 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 01:46:56PM +0200, Roger Pau Monné wrote: > On Wed, Jul 11, 2018 at 12:42:48PM +0200, Daniel Kiper wrote: > > On Wed, Jul 11, 2018 at 12:25:21PM +0200, Roger Pau Monne wrote: > > > lld (the llvm linker) has some issues with Xen linker script. It > > > doesn't understand '||'

[Xen-devel] [PATCH 1/8] cpupools: fix state when downing a CPU failed

2018-07-11 Thread Jan Beulich
While I've run into the issue with further patches in place which no longer guarantee the per-CPU area to start out as all zeros, the CPU_DOWN_FAILED processing looks to have the same issue: By not zapping the per-CPU cpupool pointer, cpupool_cpu_add()'s (indirect) invocation of schedule_cpu_switch

[Xen-devel] [PATCH 2/8] x86: distinguish CPU offlining from CPU removal

2018-07-11 Thread Jan Beulich
In order to be able to service #MC on offlined CPUs, GDT, IDT, stack, and per-CPU data (which includes the TSS) need to be kept allocated. They should only be freed upon CPU removal (which we currently don't support, so some code is becoming effectively dead for the moment). Signed-off-by: Jan Beu

[Xen-devel] [PATCH 3/8] allow cpu_down() to be called earlier

2018-07-11 Thread Jan Beulich
The function's use of the stop-machine logic has so far prevented its use ahead of the processing of the "ordinary" initcalls. Since at this early time we're in a controlled environment anyway, there's no need for such a heavy tool. Additionally this ought to have less of a performance impact espec

[Xen-devel] [PATCH 4/8] x86/AMD: distinguish compute units from hyper-threads

2018-07-11 Thread Jan Beulich
Fam17 replaces CUs by HTs, which we should reflect accordingly, even if the difference is not very big. The most relevant change (requiring some code restructuring) is that the topoext feature no longer means there is a valid CU ID. Take the opportunity and convert wrongly plain int variables in s

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-11 Thread Leon Romanovsky
On Wed, Jul 11, 2018 at 01:13:18PM +0200, Michal Hocko wrote: > On Wed 11-07-18 13:14:47, Leon Romanovsky wrote: > > On Wed, Jul 11, 2018 at 11:03:53AM +0200, Michal Hocko wrote: > > > On Tue 10-07-18 19:20:20, Leon Romanovsky wrote: > > > > On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wr

[Xen-devel] [PATCH 5/8] x86: bring up all CPUs even if not all are supposed to be used

2018-07-11 Thread Jan Beulich
Reportedly Intel CPUs which can't broadcast #MC to all targeted cores/threads because some have CR4.MCE clear will shut down. Therefore we want to keep CR4.MCE enabled when offlining a CPU, and we need to bring up all CPUs in order to be able to set CR4.MCE in the first place. The use of clear_in_

[Xen-devel] [PATCH 6/8] x86: (command line option to) avoid use of secondary hyper-threads

2018-07-11 Thread Jan Beulich
Shared resources (L1 cache and TLB in particular) present a risk of information leak via side channels. Don't use hyperthreads in such cases, but allow independent control of their use at the same time. Signed-off-by: Jan Beulich --- An option to avoid the up/down cycle would be to avoid clearing

[Xen-devel] [PATCH 7/8] x86/shim: fully ignore "nosmp" and "maxcpus="

2018-07-11 Thread Jan Beulich
In the shim case, the number of CPUs should be solely controlled by the guest configuration file. Make sure the command line options are fully (and not just partially) ignored. Signed-off-by: Jan Beulich --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1498,6 +1498,15 @@ void __init nor

[Xen-devel] [PATCH 8/8] cpumask: tidy {,z}alloc_cpumask_var()

2018-07-11 Thread Jan Beulich
Drop unnecessary casts and use bool in favor of bool_t. Signed-off-by: Jan Beulich --- a/xen/include/xen/cpumask.h +++ b/xen/include/xen/cpumask.h @@ -345,9 +345,9 @@ static inline int cpulist_scnprintf(char typedef cpumask_t *cpumask_var_t; -static inline bool_t alloc_cpumask_var(cpumask_v

Re: [Xen-devel] [PATCH 8/8] cpumask: tidy {,z}alloc_cpumask_var()

2018-07-11 Thread Andrew Cooper
On 11/07/18 13:12, Jan Beulich wrote: > Drop unnecessary casts and use bool in favor of bool_t. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/li

Re: [Xen-devel] [PATCH v2 08/13] x86: add iommu_op to query reserved ranges

2018-07-11 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 11 July 2018 11:34 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Konrad > Rzeszutek Wilk ; Stefano Stabellini > ; Tim (Xen.org) ;

Re: [Xen-devel] [PATCH 7/8] x86/shim: fully ignore "nosmp" and "maxcpus="

2018-07-11 Thread Andrew Cooper
On 11/07/18 13:11, Jan Beulich wrote: > In the shim case, the number of CPUs should be solely controlled by the > guest configuration file. Make sure the command line options are fully > (and not just partially) ignored. > > Signed-off-by: Jan Beulich Ideally with "This option is ignored in **pv-

Re: [Xen-devel] [PATCH v2 09/13] vtd: add lookup_page method to iommu_ops

2018-07-11 Thread Paul Durrant
> -Original Message- > From: dunl...@gmail.com [mailto:dunl...@gmail.com] On Behalf Of > George Dunlap > Sent: 11 July 2018 11:52 > To: Paul Durrant > Cc: xen-devel ; Kevin Tian > ; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v2 09/13] vtd: add lookup_page method to > iommu_ops > > On

Re: [Xen-devel] [PATCH v2 3/8] xen/x86: manually build xen.mb.efi binary

2018-07-11 Thread Jan Beulich
>>> On 11.07.18 at 13:41, wrote: > On Tue, Jul 10, 2018 at 07:54:51AM -0600, Jan Beulich wrote: >> >>> On 10.07.18 at 12:48, wrote: >> > On Fri, Jul 06, 2018 at 09:08:29AM -0600, Jan Beulich wrote: >> >> >>> On 06.07.18 at 16:02, wrote: >> >> > On Thu, Jul 05, 2018 at 02:18:03AM -0600, Jan Beuli

Re: [Xen-devel] [PATCH v2 11/13] memory: add get_paged_gfn() as a wrapper...

2018-07-11 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 11 July 2018 12:24 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Julien > Grall ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; T

Re: [Xen-devel] [PATCH v2 8/8] efi: drop original xen.efi code and build mechanism

2018-07-11 Thread Jan Beulich
>>> On 11.07.18 at 13:57, wrote: > On Tue, Jul 10, 2018 at 08:05:56AM -0600, Jan Beulich wrote: >> >>> On 10.07.18 at 13:35, wrote: >> > On Fri, Jul 06, 2018 at 09:16:38AM -0600, Jan Beulich wrote: >> >> >>> On 06.07.18 at 16:46, wrote: >> >> > OK, xen.mb.efi does not need relocs because: >> >>

Re: [Xen-devel] [PATCH v2 12/13] x86: add iommu_ops to modify and flush IOMMU mappings

2018-07-11 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 11 July 2018 12:46 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Julien > Grall ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; T

[Xen-devel] [linux-next test] 125059: regressions - FAIL

2018-07-11 Thread osstest service owner
flight 125059 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/125059/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 16 guest-localmigrate/x10 fail REGR. vs. 124994 Regressi

Re: [Xen-devel] [PATCH] xen/Makefile: Bump version to 4.11.1-pre for ongoing 4.11 stable branch

2018-07-11 Thread Ian Jackson
Ian Jackson writes ("[PATCH] xen/Makefile: Bump version to 4.11.1-pre for ongoing 4.11 stable branch"): > I will push this change on Wednesday, after 4.11 is released, and then > 4.11 can be handed over to the stable maintainers. Now done. staging-4.11 is open for business. Ian. __

Re: [Xen-devel] [PATCH v2 11/13] memory: add get_paged_gfn() as a wrapper...

2018-07-11 Thread George Dunlap
On 07/11/2018 01:31 PM, Paul Durrant wrote: >>> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c >>> index c6b99c4116..510f37f100 100644 >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -375,39 +375,23 @@ static int get_paged_frame(unsigned long gfn, >> m

Re: [Xen-devel] [PATCH v2 11/13] memory: add get_paged_gfn() as a wrapper...

2018-07-11 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 11 July 2018 14:05 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; Ian Jackson ; > Julien Grall ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; Tim > (Xen.org) ; W

[Xen-devel] [PATCH] automation/build: build ovmf

2018-07-11 Thread Wei Liu
Install nasm and build ovmf with gcc on x86. Signed-off-by: Wei Liu --- I have tested stretch 64 bit and 32 bit containers. I haven't tested the build script itself. --- automation/build/centos/7.2.dockerfile | 1 + automation/build/debian/jessie.dockerfile | 1 + automation/buil

[Xen-devel] [PATCH 00/16] x86: indirect call overhead reduction

2018-07-11 Thread Jan Beulich
While indirect calls have always been more expensive than direct ones, their cost has further increased with the Spectre v2 mitigations. In a number of cases we simply pointlessly use them in the first place. In many other cases the indirection solely exists to abstract from e.g. vendor specific ha

[Xen-devel] [freebsd-master test] 125104: all pass - PUSHED

2018-07-11 Thread osstest service owner
flight 125104 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/125104/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd 784d607328d1205ced136be9f87c76ee51bcac5e baseline version: freebsd 22dad49e0cc

[Xen-devel] [PATCH 01/16] VMX: reduce number of posted-interrupt hooks

2018-07-11 Thread Jan Beulich
Three of the four hooks are not exposed outside of vmx.c, and all of them have only a single possible non-NULL value. So there's no reason to use hooks here - a simple set of flag indicators is sufficient (and we don't even need a flag for the VM entry one, as it's always (de-)activated together th

[Xen-devel] [PATCH 02/16] VMX: don't unconditionally set the tsc_scaling.setup hook

2018-07-11 Thread Jan Beulich
Instead of checking hvm_tsc_scaling_supported inside the hook function, install the hook only when setting state such that said predicate becomes true. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1283,7 +1283,7 @@ static void vmx_handle_cd(str

[Xen-devel] [PATCH 03/16] x86/HVM: switch virtual_intr_delivery_enabled() hook to simple boolean

2018-07-11 Thread Jan Beulich
From: Suravee Suthikulpanit This patch modifies the hvm_funcs.virtual_intr_delivery_enabled() to become a bool variable as VMX does and SVM will simply return a static value. Signed-off-by: Suravee Suthikulpanit Signed-off-by: Jan Beulich --- Extracted from an SVM/AVIC series patch. --- a/xen

[Xen-devel] [PATCH 04/16] x86/HVM: drop vmfunc_intercept

2018-07-11 Thread Jan Beulich
Commit a1b1572833 ("VMX: add VMFUNC leaf 0 (EPTP switching) to emulator") needlessly introduced it, and no user has appeared since. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -76,7 +76,6 @@ static void vmx_fpu_dirty_intercept(void static int

[Xen-devel] [PATCH 05/16] x86/HVM: add wrapper for hvm_funcs.set_tsc_offset()

2018-07-11 Thread Jan Beulich
It's used in quite a few places, and hence doing so eases subsequent adjustment to how these (indirect) calls are carried out. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/domain.c +++ b/xen/arch/x86/hvm/domain.c @@ -317,9 +317,9 @@ int arch_set_info_hvm_guest(struct vcpu /* Sync AP'

[Xen-devel] [PATCH 06/16] x86: allow producing .i or .s for multiply compiled files

2018-07-11 Thread Jan Beulich
Since the generic pattern rules don't match those, explicit rules need to be put in place for this to work. Signed-off-by: Jan Beulich --- a/xen/Makefile +++ b/xen/Makefile @@ -249,6 +249,17 @@ FORCE: %/: FORCE $(MAKE) -f $(BASEDIR)/Rules.mk -C $* built_in.o built_in_bin.o +build-inte

[Xen-devel] [PATCH 07/16] x86/shadow: fetch CPL just once in sh_page_fault()

2018-07-11 Thread Jan Beulich
This isn't as much of an optimization than to avoid triggering a gcc bug affecting 5.x ... 7.x, triggered by any asm() put inside the ad hoc "rewalk" loop and taking as an (output?) operand a register variable tied to %rdx (an "rdx" clobber is fine). The issue is due to an apparent collision in reg

[Xen-devel] [PATCH 08/16] x86/alternatives: allow using assembler macros in favor of C ones

2018-07-11 Thread Jan Beulich
As was validly pointed out as motivation for similar Linux side changes (https://lkml.org/lkml/2018/6/22/677), using long sequences of directives and auxiliary instructions, like is commonly the case when setting up an alternative patch site, gcc can be mislead into believing an asm() to be more he

[Xen-devel] [PATCH 09/16] x86: infrastructure to allow converting certain indirect calls to direct ones

2018-07-11 Thread Jan Beulich
In a number of cases the targets of indirect calls get determined once at boot time. In such cases we can replace those calls with direct ones via our alternative instruction patching mechanism. Some of the targets (in particular the hvm_funcs ones) get established only in pre-SMP initcalls, makin

Re: [Xen-devel] [PATCH 07/16] x86/shadow: fetch CPL just once in sh_page_fault()

2018-07-11 Thread Andrew Cooper
On 11/07/18 14:29, Jan Beulich wrote: > This isn't as much of an optimization than to avoid triggering a gcc bug > affecting 5.x ... 7.x, triggered by any asm() put inside the ad hoc > "rewalk" loop and taking as an (output?) operand a register variable > tied to %rdx (an "rdx" clobber is fine). Th

[Xen-devel] [PATCH 10/16] x86/HVM: patch indirect calls through hvm_funcs to direct ones

2018-07-11 Thread Jan Beulich
This is intentionally not touching hooks used rarely (or not at all) during the lifetime of a VM, like {domain,vcpu}_initialise or cpu_up, as well as nested, VM event, and altp2m ones (they can all be done later, if so desired). Virtual Interrupt delivery ones will be dealt with in a subsequent pat

[Xen-devel] [PATCH 11/16] x86/HVM: patch vINTR indirect calls through hvm_funcs to direct ones

2018-07-11 Thread Jan Beulich
While not strictly necessary, change the VMX initialization logic to update the function table in start_vmx() from NULL rather than to NULL, to make more obvious that we won't ever change an already (explictly) initialized function pointer. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vlapi

[Xen-devel] [PATCH 12/16] x86: patch ctxt_switch_masking() indirect call to direct one

2018-07-11 Thread Jan Beulich
Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -196,7 +196,7 @@ void ctxt_switch_levelling(const struct } if (ctxt_switch_masking) - ctxt_switch_masking(next); + alternative_vcall1(ctxt_switch_masking, ne

[Xen-devel] [PATCH 13/16] x86/genapic: drop .target_cpus() hook

2018-07-11 Thread Jan Beulich
All flavors specify target_cpus_all() anyway - replace use of the hook by &cpu_online_map. Signed-off-by: Jan Beulich --- a/xen/arch/x86/genapic/delivery.c +++ b/xen/arch/x86/genapic/delivery.c @@ -5,12 +5,6 @@ #include #include - -const cpumask_t *target_cpus_all(void) -{ - return &

[Xen-devel] [PATCH 14/16] x86/genapic: remove indirection from genapic hook accesses

2018-07-11 Thread Jan Beulich
Instead of loading a pointer at each use site, have a single runtime instance of struct genapic, copying into it from the individual instances. The individual instances can this way also be moved to .init (also adjust apic_probe[] at this occasion). Signed-off-by: Jan Beulich --- a/xen/arch/x86/

[Xen-devel] [PATCH 15/16] x86/genapic: patch indirect calls to direct ones

2018-07-11 Thread Jan Beulich
For (I hope) obvious reasons only the ones used at runtime get converted. Signed-off-by: Jan Beulich --- a/xen/arch/x86/smp.c +++ b/xen/arch/x86/smp.c @@ -29,12 +29,12 @@ void send_IPI_mask(const cpumask_t *mask, int vector) { -genapic.send_IPI_mask(mask, vector); +alternative_vcall2

[Xen-devel] [PATCH 16/16] x86/cpuidle: patch some indirect calls to direct ones

2018-07-11 Thread Jan Beulich
For now only the ones used during entering/exiting of idle states are converted. Additionally pm_idle{,_save} and lapic_timer_{on,off} can't be converted, as they may get established rather late (when Dom0 is already active). Note that for patching to be deferred until after the pre-SMP initcalls

Re: [Xen-devel] [PATCH 07/16] x86/shadow: fetch CPL just once in sh_page_fault()

2018-07-11 Thread Tim Deegan
At 07:29 -0600 on 11 Jul (1531294179), Jan Beulich wrote: > This isn't as much of an optimization than to avoid triggering a gcc bug > affecting 5.x ... 7.x, triggered by any asm() put inside the ad hoc > "rewalk" loop and taking as an (output?) operand a register variable > tied to %rdx (an "rdx"

Re: [Xen-devel] [PATCH 10/16] x86/HVM: patch indirect calls through hvm_funcs to direct ones

2018-07-11 Thread Jan Beulich
>>> On 11.07.18 at 15:42, wrote: > This is intentionally not touching hooks used rarely (or not at all) > during the lifetime of a VM, like {domain,vcpu}_initialise or cpu_up, > as well as nested, VM event, and altp2m ones (they can all be done > later, if so desired). Virtual Interrupt delivery o

Re: [Xen-devel] [PATCH 07/16] x86/shadow: fetch CPL just once in sh_page_fault()

2018-07-11 Thread Jan Beulich
>>> On 11.07.18 at 15:46, wrote: > At 07:29 -0600 on 11 Jul (1531294179), Jan Beulich wrote: >> This isn't as much of an optimization than to avoid triggering a gcc bug >> affecting 5.x ... 7.x, triggered by any asm() put inside the ad hoc >> "rewalk" loop and taking as an (output?) operand a regi

Re: [Xen-devel] [Notes for xen summit 2018 design session] Process changes: is the 6 monthly release Cadence too short, Security Process, ...

2018-07-11 Thread Rich Persaud
On Jul 5, 2018, at 22:54, Tamas K Lengyel wrote: > >> On Thu, Jul 5, 2018 at 12:52 PM George Dunlap >> wrote: >> >>> Again, there was a sense that some of the issues we are seeing could be solved if we had better CI capability: in other words, some of the issues we were seeing

[Xen-devel] [OSSTEST PATCH 3/8] cr-publish-flight-logs: Refactor copydir args

2018-07-11 Thread Ian Jackson
Have it take $cfgbase and $subdir instead. This allows us to lift the config test into it. And it will be even more useful in a moment. No functional change. Signed-off-by: Ian Jackson --- cr-publish-flight-logs | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/cr

[Xen-devel] [OSSTEST PATCH 7/8] Publish: Cambridge: Publish to new public host

2018-07-11 Thread Ian Jackson
Signed-off-by: Ian Jackson --- production-config-cambridge | 3 +++ 1 file changed, 3 insertions(+) diff --git a/production-config-cambridge b/production-config-cambridge index f557614..b1360ba 100644 --- a/production-config-cambridge +++ b/production-config-cambridge @@ -41,6 +41,9 @@ OverlayLo

[Xen-devel] [OSSTEST PATCH 1/8] cr-ensure-disk-space: With -D, print check_space command

2018-07-11 Thread Ian Jackson
Signed-off-by: Ian Jackson --- cr-ensure-disk-space | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cr-ensure-disk-space b/cr-ensure-disk-space index 7091314..3e0288f 100755 --- a/cr-ensure-disk-space +++ b/cr-ensure-disk-space @@ -25,6 +25,7 @@ BEGIN { unshift @INC, qw(.)

[Xen-devel] [OSSTEST PATCH 6/8] Publish: Introduce {Logs, Results}PublishSshOpts

2018-07-11 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest.pm| 1 + Osstest/Management.pm | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest.pm b/Osstest.pm index 738ed4f..85a6e78 100644 --- a/Osstest.pm +++ b/Osstest.pm @@ -257,6 +257,7 @@ END my $u = ucfirst $l;

[Xen-devel] [OSSTEST PATCH 5/8] Publish: Introduce publish_ssh_opts

2018-07-11 Thread Ian Jackson
We need to pass it $cfgbase because this will soon be configurable. No functional change right now. Signed-off-by: Ian Jackson --- Osstest/Management.pm | 10 -- cr-publish-flight-logs | 3 ++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/Osstest/Management.pm b/Oss

[Xen-devel] [OSSTEST PATCH 0/8] Log publication from Citrix Cambridge

2018-07-11 Thread Ian Jackson
From: Ian Jackson We finally have a VM host for publishing the test logs from the Citrix instance of osstest. It needs an ssh bounce to get to the actual public webserver, so we add support for that. With this, and appropriate ssh keys, osst...@osstest.xs can run cr-publish-flight-logs, cr-ensu

[Xen-devel] [OSSTEST PATCH 8/8] Publish: Cambridge: Get the public URL right

2018-07-11 Thread Ian Jackson
This URL is now accessible, although there are some webserver tweaks remaining to do. Signed-off-by: Ian Jackson --- production-config-cambridge | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/production-config-cambridge b/production-config-cambridge index b1360ba..8647feb 10

[Xen-devel] [OSSTEST PATCH 2/8] Publish: Default LogsPublish and ResultsPublish from Publish

2018-07-11 Thread Ian Jackson
And delete the explicit settings from production-config. No functional change. Signed-off-by: Ian Jackson --- Osstest.pm| 4 ++-- production-config | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Osstest.pm b/Osstest.pm index 3377ea3..738ed4f 100644 --- a/Osstest

[Xen-devel] [OSSTEST PATCH 4/8] cr-publish-flight-logs: Refactor rsync -e option construction

2018-07-11 Thread Ian Jackson
Previously this was hardcoded. Now we make a variable @ssh, and use rsync's quoting scheme to transform it into a value suitable for -e. No overall functional change, although now the rsync command contains additional quotes in the -e option. Signed-off-by: Ian Jackson --- cr-publish-flight-lo

[Xen-devel] [OSSTEST PATCH 2/4] PDU: pause: Honour OSSTEST_PDU_NOPAUSE

2018-07-11 Thread Ian Jackson
For debugging. Signed-off-by: Ian Jackson --- Osstest/PDU/pause.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/Osstest/PDU/pause.pm b/Osstest/PDU/pause.pm index 9e839c6..b5f0322 100644 --- a/Osstest/PDU/pause.pm +++ b/Osstest/PDU/pause.pm @@ -46,6 +46,7 @@ sub new { sub pdu_power_stat

[Xen-devel] [OSSTEST PATCH 1/4] PDU: ipmi: Use arrays rather than strings for cmd

2018-07-11 Thread Ian Jackson
This allows arguments with spaces, etc. No functional change with the existing configurations I know about. It would be good to fix this before any configurations are created where this would make a difference... Signed-off-by: Ian Jackson --- Osstest/PDU/ipmi.pm | 14 ++ 1 file cha

[Xen-devel] [OSSTEST PATCH 4/4] PDU: ipmi: Pass further options to ipmitool

2018-07-11 Thread Ian Jackson
This is useful, for example, for passing `-I lanplus'. Signed-off-by: Ian Jackson --- Osstest/PDU/ipmi.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Osstest/PDU/ipmi.pm b/Osstest/PDU/ipmi.pm index b6621db..d411d97 100644 --- a/Osstest/PDU/ipmi.pm +++ b/Osstest/PDU/ipmi.pm @@ -50,6 +50

  1   2   >