[Xen-devel] [PATCH v3 1/5] sndif: Introduce protocol version

2018-03-19 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Protocol version was referenced in the protocol description, but missed its definition. Fix this by adding a constant for current protocol version. Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Konrad Rzeszutek Wilk --- xen/include/public/io/sndif.h | 7 +++

[Xen-devel] [PATCH v3 0/5] sndif: add explicit back and front synchronization

2018-03-19 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hello, all! In order to provide explicit synchronization between backend and frontend the following changes are introduced in the protocol: - bump protocol version to 2 - add new ring buffer for sending asynchronous events from backend to frontend to report num

[Xen-devel] [PATCH v3 3/5] sndif: Make requests and responses 64 octets long

2018-03-19 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Extend the size of the requests and responses to 64 octets. Bump protocol version to 2. Signed-off-by: Oleksandr Andrushchenko --- xen/include/public/io/sndif.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/xen/includ

[Xen-devel] [PATCH v3 5/5] sndif: Add explicit back and front parameter negotiation

2018-03-19 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko In order to provide explicit stream parameter negotiation between backend and frontend the following change is introduced to the protocol: - add XENSND_OP_HW_PARAM_QUERY request to read/update stream configuration space: request passes desired intervals/formats f

[Xen-devel] [PATCH v3 2/5] sndif: Fix missed "reserved" fields in comments

2018-03-19 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Some of the request descriptions have "reserved" fields missed: fix this by adding corresponidng entries. Signed-off-by: Oleksandr Andrushchenko --- xen/include/public/io/sndif.h | 4 1 file changed, 4 insertions(+) diff --git a/xen/include/public/io/sndif.h

[Xen-devel] [PATCH v3 4/5] sndif: Add explicit back and front synchronization

2018-03-19 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko In order to provide explicit synchronization between backend and frontend the following changes are introduced in the protocol: - add new ring buffer for sending asynchronous events from backend to frontend to report number of bytes played by the frontend (XEN

Re: [Xen-devel] [PATCH 1/5] tools/firmware: Build ipxe as a standalone ROM

2018-03-19 Thread Jan Beulich
>>> On 18.03.18 at 02:30, wrote: > On 3/16/18 6:18 AM, Jan Beulich wrote: > On 15.03.18 at 18:31, wrote: >>> @@ -71,7 +72,7 @@ all: acpi subdirs-all >>> acpi: >>> $(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) >>> DSDT_FILES="$(DSDT_FILES)" >>> >>> -rombios.o: roms.inc >>> +rombios

Re: [Xen-devel] [PATCH v2 21/45] ARM: new VGIC: Implement vgic_vcpu_pending_irq

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: Tell Xen whether a particular VCPU has an IRQ that needs handling in the guest. This is used to decide whether a VCPU is runnable or if a hypercall should be preempted to let the guest handle the IRQ. This is based on Linux commit 90eee56c

Re: [Xen-devel] [PATCH v2 22/45] ARM: new VGIC: Add MMIO handling framework

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: Add an MMIO handling framework to the VGIC emulation: Each register is described by its offset, size (or number of bits per IRQ, if applicable) and the read/write handler functions. We provide initialization macros to describe each GIC regi

Re: [Xen-devel] [PATCH v10 09/11] vpci/msi: add MSI handlers

2018-03-19 Thread Jan Beulich
>>> On 16.03.18 at 18:51, wrote: > On Fri, Mar 16, 2018 at 10:24:04AM -0600, Jan Beulich wrote: >> >>> On 16.03.18 at 16:38, wrote: >> > On Fri, Mar 16, 2018 at 09:05:44AM -0600, Jan Beulich wrote: >> >> >>> On 16.03.18 at 15:34, wrote: >> >> > vpci_remove_device is never called from the user-sp

Re: [Xen-devel] [PATCH v2 24/45] ARM: new VGIC: Add CTLR, TYPER and IIDR handlers

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: diff --git a/xen/arch/arm/vgic/vgic.h b/xen/arch/arm/vgic/vgic.h index 7f221fd195..e2d0f04440 100644 --- a/xen/arch/arm/vgic/vgic.h +++ b/xen/arch/arm/vgic/vgic.h @@ -17,6 +17,10 @@ #ifndef __XEN_ARM_VGIC_VGIC_H__ #define __XEN_ARM_VGIC

Re: [Xen-devel] [PATCH v2 25/45] ARM: new VGIC: Add ENABLE registers handlers

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: +void vgic_mmio_write_cenable(struct vcpu *vcpu, + paddr_t addr, unsigned int len, + unsigned long val) NIT: Indentation. [...] diff --git a/xen/arch/arm/vgic/vgic-mmio.h b/xen/arch/arm/vgic/vgic-mmio.h

Re: [Xen-devel] [PATCH v2 26/45] ARM: new VGIC: Add PENDING registers handlers

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: The pending register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. For level triggered interrupts the real line level is unaf

Re: [Xen-devel] [PATCH v2 27/45] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: The active register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. Since activation/deactivation of an interrupt may happen en

Re: [Xen-devel] [PATCH] x86/entry: Fix passing 6th argument for compat hypercalls

2018-03-19 Thread Jan Beulich
>>> On 16.03.18 at 21:08, wrote: > On 16/03/18 19:55, Jason Andryuk wrote: >> Commit ec05090403ef4d760fbe701e31afd0f0edc414d5 ("x86/entry: Erase guest >> GPR state on entry to Xen") zero-ed %rbp, compat arg 6, but it is not >> restored before passing to hypercalls. We need to pass the saved compa

Re: [Xen-devel] [PATCH v2 06/45] xen/arm: gic: Split the field state in gic_lr in 2 fields active and pending

2018-03-19 Thread Andre Przywara
Hi, On 16/03/18 22:52, Stefano Stabellini wrote: > On Fri, 16 Mar 2018, Julien Grall wrote: >> On 16/03/2018 21:34, Stefano Stabellini wrote: >>> On Thu, 15 Mar 2018, Andre Przywara wrote: From: Julien Grall diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h index d

[Xen-devel] [xen-4.8-testing test] 120885: regressions - FAIL

2018-03-19 Thread osstest service owner
flight 120885 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120885/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-1 50 xtf/test-hvm64-lbr-tsx-vmentry fail REGR. vs. 120116 test-xtf-amd64-

Re: [Xen-devel] [PATCH v2 28/45] ARM: new VGIC: Add PRIORITY registers handlers

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: The priority register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. This is based on Linux commit 055658bf48fc, written by A

Re: [Xen-devel] [PATCH] xen: fix null sched build with debug=n

2018-03-19 Thread Jan Beulich
>>> On 19.03.18 at 03:20, wrote: > The null_dom() static inline is just used when debug=y so it results in > a error with the default CFLAGS and debug=n. > > Signed-off-by: Doug Goldstein > --- > sched_null.c:123:32: error: unused function 'null_dom' > [-Werror,-Wunused-function] Since general

Re: [Xen-devel] [PATCH v2 30/45] ARM: new VGIC: Add TARGET registers handlers

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: The target register handlers are v2 emulation specific, so their implementation lives entirely in vgic-mmio-v2.c. We copy the old VGIC behaviour of assigning an IRQ to the first VCPU set in the target mask instead of making it possibly pend

Re: [Xen-devel] [PATCH v2 31/45] ARM: new VGIC: Add SGIR register handler

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: Triggering an IPI via this register is v2 specific, so the implementation lives entirely in vgic-mmio-v2.c. This is based on Linux commit 55cc01fb9004, written by Andre Przywara. Signed-off-by: Andre Przywara --- Changelog v1 ... v2: - r

Re: [Xen-devel] [PATCH v2 38/45] ARM: new VGIC: Implement arch_move_irqs()

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: When a VCPU moves to another CPU, we need to adjust the target affinity of any hardware mapped vIRQs, to observe our "physical-follows-virtual" policy. Implement arch_move_irqs() to adjust the physical affinity of all hardware mapped vIRQs

Re: [Xen-devel] [PATCH v2 39/45] ARM: new VGIC: Add preliminary stub implementation

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: The ARM arch code requires an interrupt controller emulation to implement vgic_clear_pending_irqs(), although it is suspected that it is actually not necessary. Go with a stub for now to make the linker happy. Signed-off-by: Andre Przywara

Re: [Xen-devel] [PATCH v2 41/45] ARM: new VGIC: Add vgic_v2_enable

2018-03-19 Thread Julien Grall
Hi Andre, On 03/15/2018 08:30 PM, Andre Przywara wrote: Enable the VGIC operation by properly initialising the registers in the hypervisor GIC interface. This is based on Linux commit f7b6985cc3d0, written by Eric Auger. Signed-off-by: Andre Przywara Acked-by: Julien Grall Cheers, --- C

Re: [Xen-devel] [PATCH v2 44/45] ARM: new VGIC: Allocate two pages for struct vcpu

2018-03-19 Thread Julien Grall
Hi Andre, Title: Please update it. On 03/15/2018 08:30 PM, Andre Przywara wrote: At the moment we allocate exactly one page for struct vcpu on ARM, also have a check in place to prevent it growing beyond 4KB. As the struct includes the state of all 32 private (per-VCPU) interrupts, we are at 38

Re: [Xen-devel] [PATCH v2 44/45] ARM: new VGIC: Allocate two pages for struct vcpu

2018-03-19 Thread Julien Grall
Hi Andre, On 03/19/2018 10:00 AM, Julien Grall wrote: Hi Andre, Title: Please update it. On 03/15/2018 08:30 PM, Andre Przywara wrote: At the moment we allocate exactly one page for struct vcpu on ARM, also have a check in place to prevent it growing beyond 4KB. As the struct includes the sta

Re: [Xen-devel] [PATCH v10 07/11] vpci/bars: add handlers to map the BARs

2018-03-19 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 16 March 2018 13:30 > To: xen-devel@lists.xenproject.org > Cc: Boris Ostrovsky ; Konrad Rzeszutek Wilk > ; Roger Pau Monne ; Ian > Jackson ; Wei Liu ; Andrew > Cooper ; George Dunlap > ; Jan Beulich ; Julien

Re: [Xen-devel] Xen ARM Community Call Wednesday 4th April 4PM UTC

2018-03-19 Thread Artem Mygaiev
Works for me From: Julien Grall Sent: Friday, March 16, 2018 11:57:22 AM To: Stefano Stabellini; Lars Kurth; Edgar E. Iglesias; Stewart Hildebrand; anastassios.na...@onapp.com; vfac...@de.adit-jv.com; Jarvis Roach; Volodymyr Babchuk; Artem Mygaiev; mirela.simono

Re: [Xen-devel] [PATCH] xen: fix null sched build with debug=n

2018-03-19 Thread Dario Faggioli
On Mon, 2018-03-19 at 03:40 -0600, Jan Beulich wrote: > > > > On 19.03.18 at 03:20, wrote: > > > > The null_dom() static inline is just used when debug=y so it > > results in > > a error with the default CFLAGS and debug=n. > > > > Signed-off-by: Doug Goldstein > > --- > > sched_null.c:123:32:

[Xen-devel] [xen-4.10-testing test] 120890: trouble: broken/fail/pass

2018-03-19 Thread osstest service owner
flight 120890 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120890/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-win7-amd64 broken test-amd6

Re: [Xen-devel] [PATCH v6 3/9] x86/mm: add disallow_mask parameter to get_page_from_l1e

2018-03-19 Thread Tim Deegan
At 09:54 -0600 on 13 Mar (1520934871), Jan Beulich wrote: > >>> On 13.02.18 at 21:04, wrote: > > --- a/xen/arch/x86/mm/shadow/multi.c > > +++ b/xen/arch/x86/mm/shadow/multi.c > > @@ -858,13 +858,21 @@ shadow_get_page_from_l1e(shadow_l1e_t sl1e, struct > > domain *d, p2m_type_t type) > > int

Re: [Xen-devel] Xen ARM Community Call Wednesday 4th April 4PM UTC

2018-03-19 Thread Ajmal M Ali
Hi I would like to attend the call too. How can I join? Regards Ajmal On Mon 19 Mar, 2018, 4:17 PM Artem Mygaiev, wrote: > Works for me > -- > *From:* Julien Grall > *Sent:* Friday, March 16, 2018 11:57:22 AM > *To:* Stefano Stabellini; Lars Kurth; Edgar E. Iglesia

Re: [Xen-devel] [RFC PATCH 01/12] libacpi: new DSDT ACPI table for Q35

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:46AM +1000, Alexey Gerasimenko wrote: > This patch adds the DSDT table for Q35 (new tools/libacpi/dsdt_q35.asl > file). There are not many differences with dsdt.asl (for i440) at the > moment, namely: > > - BDF location of LPC Controller > - Minor changes related to F

Re: [Xen-devel] [RFC PATCH 02/12] Makefile: build and use new DSDT table for Q35

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:47AM +1000, Alexey Gerasimenko wrote: > Provide building for newly added dsdt_q35.asl file, in a way similar > to dsdt.asl. > > Note that '15cpu' ACPI tables are only applicable to qemu-traditional > (which have no support for Q35), so we need to use 'anycpu' version

Re: [Xen-devel] [PATCH] x86/vtx: Introduce a typed union for CR access exit information

2018-03-19 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, March 15, 2018 8:08 PM > > This reduces code volume, and has a minor improvement on compiled size, > probably due to the removal of several temporary variables. > > add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-50 (-50) >

Re: [Xen-devel] [PATCH v5 12/14] x86/HVM: use x86emul_write_xcr()

2018-03-19 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, March 15, 2018 9:12 PM > > ... instead of directly calling handle_xsetbv(), to make use of the > additional checking there. > > Also don't call hvm_monitor_crX(XCR0, ...) for indexes other than zero > anymore. > > Signed-off-by: J

Re: [Xen-devel] [RFC PATCH 03/12] hvmloader: add function to query an emulated machine type (i440/Q35)

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:48AM +1000, Alexey Gerasimenko wrote: > This adds a new function get_pc_machine_type() which allows to determine > the emulated chipset type. Supported return values: > > - MACHINE_TYPE_I440 > - MACHINE_TYPE_Q35 > - MACHINE_TYPE_UNKNOWN, results in the error message b

Re: [Xen-devel] [RFC PATCH 04/12] hvmloader: add ACPI enabling for Q35

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:49AM +1000, Alexey Gerasimenko wrote: > In order to turn on ACPI for OS, we need to write a chipset-specific value > to SMI_CMD register (sort of imitation of the APM->ACPI switch on real > systems). Modify acpi_enable_sci() function to support both i440 and Q35 > emul

Re: [Xen-devel] [RFC PATCH 02/12] Makefile: build and use new DSDT table for Q35

2018-03-19 Thread Jan Beulich
>>> On 12.03.18 at 19:33, wrote: > --- a/tools/firmware/hvmloader/Makefile > +++ b/tools/firmware/hvmloader/Makefile > @@ -75,7 +75,7 @@ rombios.o: roms.inc > smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(SMBIOS_REL_DATE)\"" > > ACPI_PATH = ../../libacpi > -DSDT_FILES = dsdt_anycpu.c dsdt_15cpu.c

[Xen-devel] [PATCH v4 0/8] x86: Meltdown band-aid overhead reduction

2018-03-19 Thread Jan Beulich
1: NOP out most XPTI entry/exit code when it's not in use 2: disable XPTI when RDCL_NO 3: x86: log XPTI enabled status 4: use %r12 to write zero into xen_cr3 5: reduce .text.entry 6: enable interrupts earlier with XPTI disabled 7: also NOP out xen_cr3 restores of XPTI 8: avoid double CR3 reload whe

[Xen-devel] [PATCH v4 1/8] x86: NOP out XPTI entry/exit code when it's not in use

2018-03-19 Thread Jan Beulich
Introduce a synthetic feature flag to use alternative instruction patching to NOP out all code on entry/exit paths. Having NOPs here is generally better than using conditional branches. Also change the limit on the number of bytes we can patch in one go to that resulting from the encoding in struc

[Xen-devel] [PATCH v4 2/8] x86: disable XPTI when RDCL_NO

2018-03-19 Thread Jan Beulich
Use the respective ARCH_CAPABILITIES MSR bit, but don't expose the MSR to guests yet. Signed-off-by: Jan Beulich Tested-by: Juergen Gross Reviewed-by: Juergen Gross Reviewed-by: Andrew Cooper --- v3: Re-base. v2: New. --- a/tools/libxl/libxl_cpuid.c +++ b/tools/libxl/libxl_cpuid.c @@ -204,6 +

[Xen-devel] [PATCH v4 3/8] x86: log XPTI enabled status

2018-03-19 Thread Jan Beulich
At the same time also report the state of the two defined ARCH_CAPABILITIES MSR bits. To avoid further complicating the conditional around that printk(), drop it (it's a debug level one only anyway). Issue the main message without any XENLOG_*, and also drop XENLOG_INFO from the respective BTI mes

[Xen-devel] [PATCH v4 4/8] x86/XPTI: use %r12 to write zero into xen_cr3

2018-03-19 Thread Jan Beulich
Now that we zero all registers early on all entry paths, use that to avoid a couple of immediates here. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v4: Add comments about the %r12 being zero --- We may want to consider eliminating a few more $0 this way. But especially for byte ones I

[Xen-devel] [PATCH v4 7/8] x86: also NOP out xen_cr3 restores of XPTI

2018-03-19 Thread Jan Beulich
... despite quite likely the gain being rather limited. Signed-off-by: Jan Beulich --- v4: Split off from earlier patch. --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -583,7 +583,8 @@ ENTRY(common_interrupt) CR4_PV32_RESTORE movq %rsp,%rdi call

[Xen-devel] [PATCH v4 5/8] x86/XPTI: reduce .text.entry

2018-03-19 Thread Jan Beulich
This exposes less code pieces and at the same time reduces the range covered from slightly above 3 pages to a little below 2 of them. The code being moved is unchanged, except for the removal of trailing blanks, insertion of blanks between operands, and a pointless q suffix from "retq". A few mor

[Xen-devel] [PATCH v4 6/8] x86: enable interrupts earlier with XPTI disabled

2018-03-19 Thread Jan Beulich
The STI instances were moved (or added in the INT80 case) to meet TLB flush requirements. When XPTI is disabled, they can be put back where they were (or omitted in the INT80 case). Signed-off-by: Jan Beulich --- v4: Split off from earlier patch. --- TBD: It is questionable whether having two bac

[Xen-devel] [PATCH v4 8/8] x86: avoid double CR3 reload when switching to guest user mode

2018-03-19 Thread Jan Beulich
When XPTI is active, the CR3 load in restore_all_guest is sufficient when switching to user mode, improving in particular system call and page fault exit paths for the guest. Signed-off-by: Jan Beulich Tested-by: Juergen Gross Reviewed-by: Juergen Gross --- v2: Add ASSERT(!in_irq()). --- a/xen

Re: [Xen-devel] [PATCH v4 2/8] x86: disable XPTI when RDCL_NO

2018-03-19 Thread Jan Beulich
>>> On 19.03.18 at 14:38, wrote: > Use the respective ARCH_CAPABILITIES MSR bit, but don't expose the MSR > to guests yet. > > Signed-off-by: Jan Beulich > Tested-by: Juergen Gross > Reviewed-by: Juergen Gross > Reviewed-by: Andrew Cooper > --- > v3: Re-base. > v2: New. And I realize I've on

Re: [Xen-devel] [PATCH RESEND v2 1/2] drm/xen-front: Add support for Xen PV display frontend

2018-03-19 Thread Daniel Vetter
On Fri, Mar 16, 2018 at 12:52:09PM +0200, Oleksandr Andrushchenko wrote: > Hi, Daniel! > Sorry, if I strip the patch too much below. > > On 03/16/2018 10:23 AM, Daniel Vetter wrote: > > > > S-o-b line went missing here :-) > will restore it back ;) > > > > I've read through it, 2 actual review c

Re: [Xen-devel] [PATCH 1/5] tools/firmware: Build ipxe as a standalone ROM

2018-03-19 Thread Doug Goldstein
On 3/19/18 2:48 AM, Jan Beulich wrote: On 18.03.18 at 02:30, wrote: >> On 3/16/18 6:18 AM, Jan Beulich wrote: >> On 15.03.18 at 18:31, wrote: @@ -71,7 +72,7 @@ all: acpi subdirs-all acpi: $(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) DSDT_FILES="$(DSDT_FILES)

Re: [Xen-devel] [PATCH] xen: fix null sched build with debug=n

2018-03-19 Thread Doug Goldstein
On 3/19/18 4:40 AM, Jan Beulich wrote: On 19.03.18 at 03:20, wrote: >> The null_dom() static inline is just used when debug=y so it results in >> a error with the default CFLAGS and debug=n. >> >> Signed-off-by: Doug Goldstein >> --- >> sched_null.c:123:32: error: unused function 'null_dom'

Re: [Xen-devel] [PATCH v5 03/14] x86emul: abstract out XCRn accesses

2018-03-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 15 March 2018 13:04 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > ; George Dunlap > Subject: [PATCH v5 03/14] x86emul: abstract out XCRn accesses > > Use hooks, just like done for other special purpose reg

Re: [Xen-devel] [RFC PATCH 01/12] libacpi: new DSDT ACPI table for Q35

2018-03-19 Thread Alexey G
On Mon, 19 Mar 2018 12:43:05 + Roger Pau Monné wrote: >On Tue, Mar 13, 2018 at 04:33:46AM +1000, Alexey Gerasimenko wrote: >> This patch adds the DSDT table for Q35 (new >> tools/libacpi/dsdt_q35.asl file). There are not many differences >> with dsdt.asl (for i440) at the moment, namely: >>

[Xen-devel] [qemu-mainline bisection] complete test-amd64-amd64-qemuu-nested-amd

2018-03-19 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-nested-amd testid xen-boot/l1 Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git

[Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Alexandru Isaila
At this moment the Debug events for the AMD architecture are not forwarded to the monitor layer. This patch adds the Debug event to the common capabilities, adds the VMEXIT_ICEBP then forwards the event to the monitor layer. Chapter 2: SVM Processor and Platform Extensions: "Note: A vector 1 exce

Re: [Xen-devel] [RFC PATCH 02/12] Makefile: build and use new DSDT table for Q35

2018-03-19 Thread Alexey G
On Mon, 19 Mar 2018 07:07:34 -0600 "Jan Beulich" wrote: On 12.03.18 at 19:33, wrote: >> --- a/tools/firmware/hvmloader/Makefile >> +++ b/tools/firmware/hvmloader/Makefile >> @@ -75,7 +75,7 @@ rombios.o: roms.inc >> smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(SMBIOS_REL_DATE)\"" >> >> A

Re: [Xen-devel] [PATCH 6/7] x86: add iommu_op to query reserved ranges

2018-03-19 Thread Jan Beulich
>>> On 12.02.18 at 11:47, wrote: > --- a/xen/arch/x86/iommu_op.c > +++ b/xen/arch/x86/iommu_op.c > @@ -22,6 +22,58 @@ > #include > #include > #include > +#include > + > +struct get_rdm_ctxt { > +unsigned int max_entries; > +unsigned int nr_entries; > +XEN_GUEST_HANDLE(xen_iommu_

Re: [Xen-devel] [RFC PATCH 02/12] Makefile: build and use new DSDT table for Q35

2018-03-19 Thread Alexey G
On Mon, 19 Mar 2018 12:46:05 + Roger Pau Monné wrote: >On Tue, Mar 13, 2018 at 04:33:47AM +1000, Alexey Gerasimenko wrote: >> Provide building for newly added dsdt_q35.asl file, in a way similar >> to dsdt.asl. >> >> Note that '15cpu' ACPI tables are only applicable to qemu-traditional >> (w

Re: [Xen-devel] [PATCH RESEND v2 1/2] drm/xen-front: Add support for Xen PV display frontend

2018-03-19 Thread Oleksandr Andrushchenko
On 03/19/2018 03:51 PM, Daniel Vetter wrote: On Fri, Mar 16, 2018 at 12:52:09PM +0200, Oleksandr Andrushchenko wrote: Hi, Daniel! Sorry, if I strip the patch too much below. On 03/16/2018 10:23 AM, Daniel Vetter wrote: S-o-b line went missing here :-) will restore it back ;) I've read throug

Re: [Xen-devel] [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file

2018-03-19 Thread Anoob Soman
On 16/03/18 11:26, Jan Beulich wrote: +/* Physical address of iPXE ROM, loaded by domain builder + * when using ROMBIOS + */ +unsigned int *ipxe_rom_addresss; Comment style. And can the pointer be to const? I will fixup the comment style and but making ipxe_rom_address a point

Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Andrew Cooper
On 19/03/18 14:07, Alexandru Isaila wrote: > -case VMEXIT_EXCEPTION_BP: > -inst_len = __get_instruction_length(v, INSTR_INT3); > +case VMEXIT_EXCEPTION_BP:; > +inst_len = vmcb->nextrip - vmcb->rip; Sorry, but no.  This will break on older AMD hardware.  You must retain the

Re: [Xen-devel] [PATCH 3/5] libxc: Allow loading of firmware modules for HVM guest

2018-03-19 Thread Anoob Soman
On 18/03/18 01:32, Doug Goldstein wrote: On 3/15/18 12:31 PM, Anoob Soman wrote: This allows to load iPXE rom as a firmware module, instead of requiring it to be embedded into hvmloader. Signed-off-by: Anoob Soman --- tools/libxc/xc_dom_x86.c | 13 + 1 file changed, 13 insertion

Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Tamas K Lengyel
On Mon, Mar 19, 2018 at 8:07 AM, Alexandru Isaila wrote: > At this moment the Debug events for the AMD architecture are not > forwarded to the monitor layer. > > This patch adds the Debug event to the common capabilities, adds > the VMEXIT_ICEBP then forwards the event to the monitor layer. > > Ch

Re: [Xen-devel] [RFC PATCH 05/12] hvmloader: add Q35 DSDT table loading

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:50AM +1000, Alexey Gerasimenko wrote: > Allows to select Q35 DSDT table in hvmloader_acpi_build_tables(). Function > get_pc_machine_type() is used to select a proper table (i440/q35). > > As we are bound to the qemu-xen device model for Q35, no need > to initialize co

Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Razvan Cojocaru
On 03/19/2018 04:48 PM, Tamas K Lengyel wrote: > On Mon, Mar 19, 2018 at 8:07 AM, Alexandru Isaila > wrote: >> At this moment the Debug events for the AMD architecture are not >> forwarded to the monitor layer. >> >> This patch adds the Debug event to the common capabilities, adds >> the VMEXIT_IC

Re: [Xen-devel] [RFC PATCH 09/12] libxl: Xen Platform device support for Q35

2018-03-19 Thread Alexey G
On Tue, 13 Mar 2018 04:33:54 +1000 Alexey Gerasimenko wrote: >Current Xen/QEMU method to control Xen Platform device is a bit odd -- >changing 'xen_platform_device' option value actually modifies QEMU >emulated machine type, namely xenfv <--> pc. > >In order to avoid multiplying machine types, us

Re: [Xen-devel] [PATCH 7/7] x86: add iommu_ops to map and unmap pages, and also to flush the IOTLB

2018-03-19 Thread Jan Beulich
>>> On 12.02.18 at 11:47, wrote: > This patch adds iommu_ops to allow a domain with control_iommu privilege > to map and unmap pages from any guest over which it has mapping privilege > in the IOMMU. > These operations implicitly disable IOTLB flushing so that the caller can > batch operations and

Re: [Xen-devel] [PATCH 6/7] x86: add iommu_op to query reserved ranges

2018-03-19 Thread Jan Beulich
>>> On 12.02.18 at 11:47, wrote: > --- a/xen/arch/x86/iommu_op.c > +++ b/xen/arch/x86/iommu_op.c > @@ -22,6 +22,58 @@ > #include > #include > #include > +#include > + > +struct get_rdm_ctxt { > +unsigned int max_entries; > +unsigned int nr_entries; > +XEN_GUEST_HANDLE(xen_iommu_

Re: [Xen-devel] [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file

2018-03-19 Thread Jan Beulich
>>> On 19.03.18 at 15:24, wrote: > On 16/03/18 11:26, Jan Beulich wrote: >>> >>> +/* Physical address of iPXE ROM, loaded by domain builder >>> + * when using ROMBIOS >>> + */ >>> +unsigned int *ipxe_rom_addresss; >> Comment style. And can the pointer be to const? > > I will fixup

Re: [Xen-devel] [PATCH RESEND v2 1/2] drm/xen-front: Add support for Xen PV display frontend

2018-03-19 Thread Daniel Vetter
On Mon, Mar 19, 2018 at 3:19 PM, Oleksandr Andrushchenko wrote: > On 03/19/2018 03:51 PM, Daniel Vetter wrote: >> >> On Fri, Mar 16, 2018 at 12:52:09PM +0200, Oleksandr Andrushchenko wrote: >>> >>> Hi, Daniel! >>> Sorry, if I strip the patch too much below. >>> >>> On 03/16/2018 10:23 AM, Daniel V

Re: [Xen-devel] [PATCH 6/7] x86: add iommu_op to query reserved ranges

2018-03-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 19 March 2018 14:10 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; George Dunlap ; Ian > Jackson ; Stefano Stabellini > ; xen-devel@lists.xenproject.org; Konrad Rzeszutek > Wilk ; Tim (Xen.org) > Subject: Re

Re: [Xen-devel] Xen ARM Community Call Wednesday 4th April 4PM UTC

2018-03-19 Thread Stefano Stabellini
Hello Ajmal, I was planning to send a remider few days before the call with the call details, but let me paste them also here: Join the call: https://www.uberconference.com/stefano-stabellini Optional dial in number: 669-999-0613 No PIN needed International call-in numbers are available on the w

Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Alexandru Stefan ISAILA
On Lu, 2018-03-19 at 14:22 +, Andrew Cooper wrote: > On 19/03/18 14:07, Alexandru Isaila wrote: > > > > -case VMEXIT_EXCEPTION_BP: > > -inst_len = __get_instruction_length(v, INSTR_INT3); > > +case VMEXIT_EXCEPTION_BP:; > > +inst_len = vmcb->nextrip - vmcb->rip; > Sorry

Re: [Xen-devel] [RFC PATCH 06/12] hvmloader: add basic Q35 support

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:51AM +1000, Alexey Gerasimenko wrote: > This patch does following: > > 1. Move PCI-device specific initialization out of pci_setup function > to the newly created class_specific_pci_device_setup function to simplify > code. > > 2. PCI-device specific initialization e

Re: [Xen-devel] [PATCH 7/7] x86: add iommu_ops to map and unmap pages, and also to flush the IOTLB

2018-03-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 19 March 2018 15:12 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; George Dunlap ; Ian > Jackson ; Stefano Stabellini > ; xen-devel@lists.xenproject.org; Konrad Rzeszutek > Wilk ; Tim (Xen.org) > Subject: Re

Re: [Xen-devel] [PATCH 6/7] x86: add iommu_op to query reserved ranges

2018-03-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 19 March 2018 15:14 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; George Dunlap ; Ian > Jackson ; Stefano Stabellini > ; xen-devel@lists.xenproject.org; Konrad Rzeszutek > Wilk ; Tim (Xen.org) > Subject: Re

Re: [Xen-devel] [PATCH v10 07/11] vpci/bars: add handlers to map the BARs

2018-03-19 Thread Jan Beulich
>>> On 16.03.18 at 14:30, wrote: > +static int map_range(unsigned long s, unsigned long e, void *data, > + unsigned long *c) > +{ > +const struct map_data *map = data; > +int rc; > + > +for ( ; ; ) > +{ > +unsigned long size = e - s + 1; > + > +/

[Xen-devel] [RFC Patch] Make Security Policy Doc ready to become a CNA

2018-03-19 Thread Lars Kurth
This contains a proposal to change https://xenproject.org/security-policy.html such that it points to SUPPORT.md. Having scope and process information is necessary to become a CNA. This is the last piece, before formally asking to become a CNA. To make the review of this easier, I based it on xe

Re: [Xen-devel] [PATCH v2 31/45] ARM: new VGIC: Add SGIR register handler

2018-03-19 Thread Andre Przywara
Hi, On 19/03/18 09:47, Julien Grall wrote: > Hi Andre, > > On 03/15/2018 08:30 PM, Andre Przywara wrote: >> Triggering an IPI via this register is v2 specific, so the >> implementation lives entirely in vgic-mmio-v2.c. >> >> This is based on Linux commit 55cc01fb9004, written by Andre Przywara. >

[Xen-devel] [xen-4.6-testing test] 120897: regressions - FAIL

2018-03-19 Thread osstest service owner
flight 120897 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120897/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm broken in 120734 test-amd64-amd64-qemuu-n

Re: [Xen-devel] [RFC PATCH 07/12] hvmloader: allocate MMCONFIG area in the MMIO hole + minor code refactoring

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:52AM +1000, Alexey Gerasimenko wrote: > Much like normal PCI BARs or other chipset-specific memory-mapped > resources, MMCONFIG area needs space in MMIO hole, so we must allocate > it manually. > > The actual MMCONFIG size depends on a number of PCI buses available wh

Re: [Xen-devel] [RFC PATCH 03/12] hvmloader: add function to query an emulated machine type (i440/Q35)

2018-03-19 Thread Alexey G
On Mon, 19 Mar 2018 12:56:51 + Roger Pau Monné wrote: >On Tue, Mar 13, 2018 at 04:33:48AM +1000, Alexey Gerasimenko wrote: >> This adds a new function get_pc_machine_type() which allows to >> determine the emulated chipset type. Supported return values: >> >> - MACHINE_TYPE_I440 >> - MACHINE

Re: [Xen-devel] [PATCH 6/7] x86: add iommu_op to query reserved ranges

2018-03-19 Thread Jan Beulich
>>> On 19.03.18 at 16:13, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 19 March 2018 14:10 >> >> >>> On 12.02.18 at 11:47, wrote: >> > +for ( j = 0; \ >> > + j < min_t(unsigned int, (_d_)->nr_entries, \ >> > +

Re: [Xen-devel] [PATCH 6/7] x86: add iommu_op to query reserved ranges

2018-03-19 Thread Jan Beulich
>>> On 19.03.18 at 16:36, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 19 March 2018 15:14 >> >> >>> On 12.02.18 at 11:47, wrote: >> > --- a/xen/arch/x86/iommu_op.c >> > +++ b/xen/arch/x86/iommu_op.c >> > @@ -22,6 +22,58 @@ >> > #include >> > #include >> > #include >> >

Re: [Xen-devel] What is the option 'e' used for in 'xl create' command

2018-03-19 Thread Stefano Stabellini
On Mon, 19 Mar 2018, Dongli Zhang wrote: > Hi, > > There is an 'e' option when running the following xl command: > > - xl create > - xl restore > - xl migrate > - xl remus > > The 'e' option is used to "Do not wait in the background (on ) for the > death of the domain". This option dates back to

Re: [Xen-devel] [PATCH 7/7] x86: add iommu_ops to map and unmap pages, and also to flush the IOTLB

2018-03-19 Thread Jan Beulich
>>> On 19.03.18 at 16:34, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 19 March 2018 15:12 >> >> >>> On 12.02.18 at 11:47, wrote: >> > This patch adds iommu_ops to allow a domain with control_iommu >> privilege >> > to map and unmap pages from any guest over which it has mappi

[Xen-devel] [PATCH] x86/xen: Delay get_cpu_cap until stack canary is established

2018-03-19 Thread Jason Andryuk
Commit 2cc42bac1c79 ("x86-64/Xen: eliminate W+X mappings") introduced a call to get_cpu_cap, which is fstack-protected. This is works on x86-64 as commit 4f277295e54c ("x86/xen: init %gs very early to avoid page faults with stack protector") ensures the stack protector is configured, but it it did

[Xen-devel] [RFC PATCH] Make Security Policy Doc ready to become a CNA

2018-03-19 Thread Lars Kurth
And this time with patch: note to myself - never try sendmail with --compose again (-; This patch contains a proposal to change https://xenproject.org/security-policy.html such that it points to SUPPORT.md. Having scope and process information is necessary to become a CNA. This is the last pie

Re: [Xen-devel] [PATCH 1/3] x86/pv: Avoid locked bit manipulation in register_guest_callback()

2018-03-19 Thread Jan Beulich
>>> On 15.03.18 at 12:58, wrote: > Changes to arch.vgc_flags are made to current in syncrhonous context only, and > don't need to be locked. (The only other changes are via > arch_set_info_guest(), which operates on descheduled vcpus only). > > Replace the {set,clear}_bit() calls with compiler-v

Re: [Xen-devel] [PATCH 2/3] x86/pv: Fold {compat_}unregister_guest_callback() into its non-compat counterpart

2018-03-19 Thread Jan Beulich
>>> On 15.03.18 at 12:58, wrote: > These functions are almost identical. They differ only in the error emitted > for the use of CALLBACKTYPE_syscall (which is inconsequential to guests), I'm not entirely convinced - so far there's been a match here between map and unmap, i.e. with the change it

Re: [Xen-devel] [PATCH 7/7] x86: add iommu_ops to map and unmap pages, and also to flush the IOTLB

2018-03-19 Thread Paul Durrant
> -Original Message- [snip] > >> How are you making sure this is a mapping that was established via > >> the map op? Without that this can be (ab)used to ... > >> > >> > +put_page(page); > >> > >> ... underflow the refcount of a page. > >> > > > > Yes, I guess I need to ensure that only

Re: [Xen-devel] [RFC PATCH 08/12] libxl: Q35 support (new option device_model_machine)

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:53AM +1000, Alexey Gerasimenko wrote: > Provide a new domain config option to select the emulated machine type, > device_model_machine. It has following possible values: > - "i440" - i440 emulation (default) > - "q35" - emulate a Q35 machine. By default, the storage in

Re: [Xen-devel] [PATCH v2 19/45] ARM: new VGIC: Add IRQ sync/flush framework

2018-03-19 Thread Andre Przywara
Hi, On 19/03/18 14:17, Julien Grall wrote: > Hi, > > On 03/15/2018 08:30 PM, Andre Przywara wrote: >> Implement the framework for syncing IRQs between our emulation and the >> list registers, which represent the guest's view of IRQs. >> This is done in vgic_sync_from_lrs() and vgic_sync_to_lrs(),

Re: [Xen-devel] [PATCH 28/57] ARM: new VGIC: Add acccessor to new struct vgic_irq instance

2018-03-19 Thread Andre Przywara
Hi, On 06/03/18 18:13, Julien Grall wrote: > Hi Andre, > > On 05/03/18 16:03, Andre Przywara wrote: >> The new VGIC implementation centers around a struct vgic_irq instance >> per virtual IRQ. >> Provide a function to retrieve the right instance for a given IRQ >> number and (in case of private i

Re: [Xen-devel] [RFC PATCH 10/12] libacpi: build ACPI MCFG table if requested

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:55AM +1000, Alexey Gerasimenko wrote: > This adds construct_mcfg() function to libacpi which allows to build MCFG > table for a given mmconfig_addr/mmconfig_len pair if the ACPI_HAS_MCFG > flag was specified in acpi_config struct. > > The maximum bus number is calcula

Re: [Xen-devel] [PATCH v2 09/45] ARM: GIC: Allow tweaking the active and pending state of an IRQ

2018-03-19 Thread Andre Przywara
Hi, On 19/03/18 09:30, Julien Grall wrote: > > > On 03/16/2018 04:05 PM, Andre Przywara wrote: >> Hi, > > Hi Andre, > >> On 15/03/18 20:30, Andre Przywara wrote: >>> +    } >>> +} >>> + >>> +static void gicv2_set_pending_state(struct irq_desc *irqd, bool >>> pending) >>> +{ >>> +    ASSERT(spi

Re: [Xen-devel] [RFC PATCH 11/12] hvmloader: use libacpi to build MCFG table

2018-03-19 Thread Roger Pau Monné
On Tue, Mar 13, 2018 at 04:33:56AM +1000, Alexey Gerasimenko wrote: > This patch extends hvmloader_acpi_build_tables() with code which detects > if MMCONFIG is available -- i.e. initialized and enabled (+we're running > on Q35), obtains its base address and size and asks libacpi to build MCFG > tab

[Xen-devel] [PATCH v2] xen: fix null sched build with debug=n

2018-03-19 Thread Doug Goldstein
The null_dom() static inline is just used when debug=y so it results in a error with the default CFLAGS and debug=n. This function is used in only one place and it a one line helper so remove it until we actually need it. Signed-off-by: Doug Goldstein --- environment: Debian stretch compiler: cla

[Xen-devel] broken build: 448c03b3cbe14873ee637755a29ea26ee7ca9ef9

2018-03-19 Thread Doug Goldstein
commit 448c03b3cbe14873ee637755a29ea26ee7ca9ef9 Author: Juergen Gross Date: Mon Feb 26 09:46:12 2018 +0100 This commit breaks the build of qemu-xen-traditional for: Ubuntu 14.04: https://gitlab.com/cardoe/xen/-/jobs/58266170 Ubuntu 16.04: https://gitlab.com/cardoe/xen/-/jobs/58266174 A short

  1   2   >