On 3/19/18 2:48 AM, Jan Beulich wrote: >>>> On 18.03.18 at 02:30, <car...@cardoe.com> wrote: >> On 3/16/18 6:18 AM, Jan Beulich wrote: >>>>>> On 15.03.18 at 18:31, <anoob.so...@citrix.com> wrote: >>>> @@ -71,7 +72,7 @@ all: acpi subdirs-all >>>> acpi: >>>> $(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) >>>> DSDT_FILES="$(DSDT_FILES)" >>>> >>>> -rombios.o: roms.inc >>>> +rombios.o: $(ETHERBOOT_ROM) roms.inc >>> >>> Please don't introduce dead dependencies: If a need for this arises >>> in a later patch, add the dependency there. >> >> Well this is what's creating the ipxe.bin that's being installed in the >> section you snipped out. > > I don't understand: The question isn't what is being generated, but > whether rombios.o really depends on that binary blob, and nothing > in the patch here suggests it does. If the goal is simply to have a > dependency triggering the creation of the blob, then this should be > done via e.g. TARGET, and the whole logic should rather sit in > firmware/Makefile (matching the installation of it done there). > > Jan >
Oh, 100% agreement there. -- Doug Goldstein _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
