[Xen-devel] [ovmf test] 120573: all pass - PUSHED

2018-03-14 Thread osstest service owner
flight 120573 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/120573/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 87a1f65e80cf183a87072df04d749b0aa12171d9 baseline version: ovmf 7548947d040edfa915dbc

Re: [Xen-devel] [alsa-devel] [PATCH 0/2] sndif: add explicit back and front synchronization

2018-03-14 Thread Oleksandr Andrushchenko
On 03/13/2018 08:48 PM, Takashi Iwai wrote: On Tue, 13 Mar 2018 18:31:55 +0100, Oleksandr Andrushchenko wrote: On 03/13/2018 06:31 PM, Takashi Iwai wrote: On Tue, 13 Mar 2018 12:49:00 +0100, Oleksandr Andrushchenko wrote: So, I tried to make a POC to stress the protocol changes and see what im

Re: [Xen-devel] [PATCH 1/1] x86/PVHv2: Add memory map pointer to hvm_start_info struct

2018-03-14 Thread Jan Beulich
>>> On 13.03.18 at 17:55, wrote: > On 3/13/2018 9:34 AM, Jan Beulich wrote: > On 13.03.18 at 17:20, wrote: >>> On 3/13/2018 3:50 AM, Roger Pau Monné wrote: On Fri, Mar 02, 2018 at 12:54:29PM -0800, Maran Wilson wrote: > @@ -62,10 +72,34 @@ > *| reserved | >

Re: [Xen-devel] [PATCH v2 1/4] x86/PVHv2: Add memory map pointer to hvm_start_info struct

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 00:31, wrote: > + * For x86 implementations at least, the values used in the type field will > + * match the Address Range Types as defined in section 15 (System Address > + * Map Interfaces) of the ACPI Specification (http://uefi.org/specifications) > + * where: > + * Addre

Re: [Xen-devel] [xen-unstable-smoke bisection] complete build-arm64-xsm

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 03:29, wrote: > branch xen-unstable-smoke > xenbranch xen-unstable-smoke > job build-arm64-xsm > testid xen-build > > Tree: qemuu git://xenbits.xen.org/qemu-xen.git > Tree: xen git://xenbits.xen.org/xen.git > > *** Found and reproduced problem changeset *** > > Bug is in tr

Re: [Xen-devel] [xen-4.8-testing test] 120544: regressions - FAIL

2018-03-14 Thread Jan Beulich
>>> On 13.03.18 at 22:24, wrote: > flight 120544 xen-4.8-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/120544/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-xtf-amd64-amd64-5 50 xtf/test-hvm64-lbr

[Xen-devel] [xen-unstable-smoke test] 120721: regressions - FAIL

2018-03-14 Thread osstest service owner
flight 120721 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120721/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 120679 build-armhf

[Xen-devel] [PATCH 0/3] x86: assorted assembly related cleanup

2018-03-14 Thread Jan Beulich
1: alternatives: fully leverage automatic NOP filling 2: move quoting of __ASM_{STAC,CLAC} 3: reduce "visibility" of spec_ctrl_asm.h Signed-off-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mail

[Xen-devel] [PATCH] tools: xenalyze.c fix format-truncation

2018-03-14 Thread John Thomson
With gcc optimization enabled by: tools: detect appropriate debug optimization level b43501451733193b265de30fd79a764363a2a473 -Wformat-truncation throws warnings gcc version 7.3.0 xenalyze.c: In function 'find_symbol': xenalyze.c:382:36: error: 'snprintf' output may be truncated before the last

[Xen-devel] [PATCH 2/3] x86: move quoting of __ASM_{STAC,CLAC}

2018-03-14 Thread Jan Beulich
Both consumers want them quoted, so quote them right away instead of using __stringify() upon use. In the spirit of other recent additions also make the assembly forms assembler macros, allowing the helper #define-s to be #undef-ed subsequently. Signed-off-by: Jan Beulich --- a/xen/include/asm-x

[Xen-devel] [PATCH 1/3] x86/alternatives: fully leverage automatic NOP filling

2018-03-14 Thread Jan Beulich
As of commit 4008c71d7a ("x86/alt: Support for automatic padding calculations") there's no point having explict ASM_NOPn instances in alternatives anymore - drop them. As a result also drop the asm/nops.h inclusion from alternative.h, adding explicit inclusions in the two remaining C files needing

[Xen-devel] [PATCH 3/3] x86: reduce "visibility" of spec_ctrl_asm.h

2018-03-14 Thread Jan Beulich
Other than indirect_thunk_asm.h, spec_ctrl_asm.h is a header needed by assembly source files only. Avoid having all C sources have a dependency on that header. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/asm_defns.h +++ b/xen/include/asm-x86/asm_defns.h @@ -328,6 +328,8 @@ static always

Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-03-14 Thread Jan Beulich
>>> On 26.02.18 at 15:08, wrote: > @@ -35,6 +40,9 @@ void xen_arch_post_suspend(int cancelled) > > static void xen_vcpu_notify_restore(void *data) > { > + if (xen_pv_domain() && boot_cpu_has(X86_FEATURE_SPEC_CTRL)) > + wrmsrl(MSR_IA32_SPEC_CTRL, this_cpu_read(spec_ctrl)); > + >

Re: [Xen-devel] [xen-unstable-smoke bisection] complete build-arm64-xsm

2018-03-14 Thread Andrew Cooper
On 14/03/2018 07:59, Jan Beulich wrote: On 14.03.18 at 03:29, wrote: >> branch xen-unstable-smoke >> xenbranch xen-unstable-smoke >> job build-arm64-xsm >> testid xen-build >> >> Tree: qemuu git://xenbits.xen.org/qemu-xen.git >> Tree: xen git://xenbits.xen.org/xen.git >> >> *** Found and repr

Re: [Xen-devel] [PATCH v2] xen/arm: p2m: Prevent deadlock when using memaccess

2018-03-14 Thread Sergej Proskurin
Hi Julien, On 03/12/2018 04:34 PM, julien.gr...@arm.com wrote: > From: Julien Grall > > Commit 7d623b358a4 "arm/mem_access: Add long-descriptor based gpt" > assumed the read-write lock can be taken recursively. However, this > assumption is wrong and will lead to deadlock when the lock is > cont

Re: [Xen-devel] [RFC PATCH 0/6] Using GitLab CI for build testing

2018-03-14 Thread George Dunlap
On Tue, Mar 13, 2018 at 3:31 AM, Doug Goldstein wrote: > Really early work on switching over to using GitLab CI over > Travis CI. GitLab is a competitor to GitHub with some advantages > such as an integrated CI system with a lot more flexibility > and control. It additionally is fully open sourced

Re: [Xen-devel] [RFC PATCH 0/6] Using GitLab CI for build testing

2018-03-14 Thread George Dunlap
On Tue, Mar 13, 2018 at 3:31 AM, Doug Goldstein wrote: > Really early work on switching over to using GitLab CI over > Travis CI. GitLab is a competitor to GitHub with some advantages > such as an integrated CI system with a lot more flexibility > and control. It additionally is fully open sourced

Re: [Xen-devel] [PATCH] tools: xenalyze.c fix format-truncation

2018-03-14 Thread George Dunlap
On 03/14/2018 08:21 AM, John Thomson wrote: > With gcc optimization enabled by: > tools: detect appropriate debug optimization level > b43501451733193b265de30fd79a764363a2a473 > > -Wformat-truncation throws warnings > > gcc version 7.3.0 > > xenalyze.c: In function 'find_symbol': > xenalyze.c:38

[Xen-devel] [xen-4.6-testing test] 120569: regressions - FAIL

2018-03-14 Thread osstest service owner
flight 120569 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120569/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-rumprun-i386 broken in 120364 build-i386-prev

Re: [Xen-devel] [PATCH v2 06/27] x86/entry/64: Adapt assembly for PIE support

2018-03-14 Thread Peter Zijlstra
On Tue, Mar 13, 2018 at 01:59:24PM -0700, Thomas Garnier wrote: > @@ -1576,7 +1578,9 @@ first_nmi: > addq$8, (%rsp) /* Fix up RSP */ > pushfq /* RFLAGS */ > pushq $__KERNEL_CS/* CS */ > - pushq $1f /* RIP */ > + pushq %rax

Re: [Xen-devel] [PATCH v2 21/27] x86/ftrace: Adapt function tracing for PIE support

2018-03-14 Thread Peter Zijlstra
On Tue, Mar 13, 2018 at 01:59:39PM -0700, Thomas Garnier wrote: > + /* > + * If PIE is not enabled or no GOT call was found, default to the > + * original approach to code modification. > + */ > + if (!IS_ENABLED(CONFIG_X86_PIE) > + || probe_kernel_read(replaced, (voi

Re: [Xen-devel] [RFC PATCH 13/30] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

2018-03-14 Thread Paolo Bonzini
On 12/03/2018 19:33, Alexey Gerasimenko wrote: > xen_pci_slot_get_pirq --> xen_cmn_pci_slot_get_pirq > xen_piix3_set_irq --> xen_cmn_set_irq Don't abbrvt names, xen_hvm_ is a better prefix. > > +fprintf(stderr, "WARNING: guest domain attempted to use > PIRQ%c " > +

Re: [Xen-devel] [xen-unstable-smoke bisection] complete build-arm64-xsm

2018-03-14 Thread Wei Liu
On Wed, Mar 14, 2018 at 09:01:10AM +, Andrew Cooper wrote: > On 14/03/2018 07:59, Jan Beulich wrote: > On 14.03.18 at 03:29, wrote: > >> branch xen-unstable-smoke > >> xenbranch xen-unstable-smoke > >> job build-arm64-xsm > >> testid xen-build > >> > >> Tree: qemuu git://xenbits.xen.org/q

Re: [Xen-devel] [PATCH] xenbaked.c: Avoid divide by zero issue on dump_stats()

2018-03-14 Thread George Dunlap
On Wed, Mar 14, 2018 at 2:24 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 13, 2018 at 06:38:24PM -0700, Joe Jin wrote: >> run_time on dump_stats() maybe zero if break xenmon.py immediately after it > > s/maybe/can be/ >> started, then xenbaked hit divide by zero fault. > > And: > > "Note that ru

Re: [Xen-devel] [RFC PATCH 1/6] ci: add Dockerfile for CentOS 7.2

2018-03-14 Thread Julien Grall
Hi Doug, On 03/13/2018 03:48 PM, Doug Goldstein wrote: On 3/13/18 9:52 AM, Julien Grall wrote: Hi Doug, On 13/03/18 03:31, Doug Goldstein wrote: +# work around https://github.com/moby/moby/issues/10180 +# and install Xen depends +RUN rpm --rebuilddb && \ +    yum -y install \ +    yum-plu

[Xen-devel] [PATCH] libxc/arm: remove useless conditional in meminit

2018-03-14 Thread Wei Liu
The variable named ramsize is always non-zero at that point because there is a check for zero a few lines before. Signed-off-by: Wei Liu --- tools/libxc/xc_dom_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c index 5b9e

Re: [Xen-devel] [PATCH] libxc/arm: remove useless conditional in meminit

2018-03-14 Thread Julien Grall
On 03/14/2018 10:58 AM, Wei Liu wrote: The variable named ramsize is always non-zero at that point because there is a check for zero a few lines before. The body of the loop has: ramsize -= ... We want to exit the loop either when we have no more banks left or we fulfilled all the RAM requ

Re: [Xen-devel] [PATCH] libxc/arm: remove useless conditional in meminit

2018-03-14 Thread George Dunlap
On Wed, Mar 14, 2018 at 10:58 AM, Wei Liu wrote: > The variable named ramsize is always non-zero at that point because > there is a check for zero a few lines before. But this is a loop, and ramsize is modified during the loop. if bankmax[i] > ramsize, then banksize is set to ramsize, and the lo

[Xen-devel] [PATCH] gitignore: ignore wrappers.c link for fuzzer

2018-03-14 Thread Wei Liu
At the same time reorder the entries alphabetically. Signed-off-by: Wei Liu --- .gitignore | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index b0191bf91f..9f5e9aed15 100644 --- a/.gitignore +++ b/.gitignore @@ -168,10 +168,11 @@ tools/flask/util

Re: [Xen-devel] [PATCH] libxc/arm: remove useless conditional in meminit

2018-03-14 Thread Wei Liu
On Wed, Mar 14, 2018 at 11:01:45AM +, Julien Grall wrote: > > > On 03/14/2018 10:58 AM, Wei Liu wrote: > > The variable named ramsize is always non-zero at that point because > > there is a check for zero a few lines before. > > The body of the loop has: > > ramsize -= ... > > We want to e

[Xen-devel] [PATCH] SUPPORT.md: Multiple IOREQ servers are experimental

2018-03-14 Thread George Dunlap
The code has been there in the hypervisor for several releases, but there is no toolstack support. While we're here delete some trailing whitespace. Signed-off-by: George Dunlap --- This is a backport candidate to 4.10. Wasn't clear exactly what section to put it in, but I figured it had to do

Re: [Xen-devel] [PATCH v4] new config option vtsc_tolerance_khz to avoid TSC emulation

2018-03-14 Thread Olaf Hering
Am Tue, 13 Mar 2018 17:04:25 + schrieb Wei Liu : > There were questions on previous patches as to why this approach is > better than what we already have. Are those comments addressed? Which questions? I do not see any. What we have is tsc_mode=native, which avoids emulation on the same class

[Xen-devel] [PATCH v2] xl: remove apic option for PVH guests

2018-03-14 Thread Roger Pau Monne
XSA-256 forces the local APIC to always be enabled for PVH guests, so ignore any apic option for PVH guests. Update the documentation accordingly. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc:

Re: [Xen-devel] [PATCH] SUPPORT.md: Multiple IOREQ servers are experimental

2018-03-14 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 14 March 2018 11:06 > To: xen-devel@lists.xenproject.org > Cc: George Dunlap ; Ian Jackson > ; Wei Liu ; Andrew Cooper > ; Jan Beulich ; Tim > (Xen.org) ; Konrad Wilk ; Stefano > Stabellini ; Julien Grall ;

Re: [Xen-devel] [PATCH] SUPPORT.md: Multiple IOREQ servers are experimental

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 12:16, wrote: >> -Original Message- >> From: George Dunlap [mailto:george.dun...@citrix.com] >> Sent: 14 March 2018 11:06 >> To: xen-devel@lists.xenproject.org >> Cc: George Dunlap ; Ian Jackson >> ; Wei Liu ; Andrew Cooper >> ; Jan Beulich ; Tim >> (Xen.org) ; Konrad

Re: [Xen-devel] [RFC PATCH 13/30] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

2018-03-14 Thread Alexey G
On Wed, 14 Mar 2018 11:48:46 +0100 Paolo Bonzini wrote: >On 12/03/2018 19:33, Alexey Gerasimenko wrote: >> xen_pci_slot_get_pirq --> xen_cmn_pci_slot_get_pirq >> xen_piix3_set_irq --> xen_cmn_set_irq > >Don't abbrvt names, xen_hvm_ is a better prefix. Agree, will rename xen_cmn_* to xen_hv

[Xen-devel] [PATCH] gitignore: ignore wrappers.c link for fuzzer

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 12:02, wrote: > At the same time reorder the entries alphabetically. > > Signed-off-by: Wei Liu Acked-by: Jan Beulich I'm sorry, I should have remembered adding this right away. Jan ___ Xen-devel mailing list Xen-devel@lists.xe

[Xen-devel] [linux-next test] 120564: regressions - FAIL

2018-03-14 Thread osstest service owner
flight 120564 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/120564/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt broken in 120363 test-armhf-armhf-xl-xsm 10

[Xen-devel] xl.cfg error in usbdev, doc and code are different

2018-03-14 Thread Anthony PERARD
Hi, I followed `man xl.cfg` to add an usbdev property to my guest config, and xl rejected it. # xl create "usbdev=['devtype=hostdev,hostbus=1,hostaddr=2',]" ~/arch.hvm Unknown string `devtype=hostdev' in usbdev spec In xl_parse.c, the expected string seems to be "type=hostdev", not "devtype".

Re: [Xen-devel] xl.cfg error in usbdev, doc and code are different

2018-03-14 Thread Wei Liu
Cc George and Juergen On Wed, Mar 14, 2018 at 11:43:46AM +, Anthony PERARD wrote: > Hi, > > I followed `man xl.cfg` to add an usbdev property to my guest config, > and xl rejected it. > > # xl create "usbdev=['devtype=hostdev,hostbus=1,hostaddr=2',]" ~/arch.hvm > Unknown string `devtype=host

[Xen-devel] [PATCH] x86/pv: Fix guest crashes following f75b1a5247b "x86/pv: Drop int80_bounce from struct pv_vcpu"

2018-03-14 Thread Andrew Cooper
The original init_int80_direct_trap() was in fact buggy; `int $0x80` is not an exception. This went unnoticed for years because int80_bounce and trap_bounce were separate structures, but were combined by this change. Exception handling is different to interrupt handling for PV guests. By reusing

[Xen-devel] [PATCH] x86/entry: Trivial nonfunctional fixes

2018-03-14 Thread Andrew Cooper
* Drop unnecessary size suffixes * The C pseudocode refers to a trap_info object, not trap_bounce. Signed-off-by: Andrew Cooper --- CC: Jan Beulich --- xen/arch/x86/x86_64/entry.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/

[Xen-devel] [xen-unstable-coverity test] 120732: regressions - ALL FAIL

2018-03-14 Thread osstest service owner
flight 120732 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/120732/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: coverity-amd647 coverity-upload fail REGR. vs. 119558 version t

[Xen-devel] [PATCH] libxc/arm: initialise p2m_size to make gcc happy

2018-03-14 Thread Wei Liu
Gcc with -O3 failed to spot the loop to initialise p2m_size runs at least once. Signed-off-by: Wei Liu --- tools/libxc/xc_dom_arm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c index 5b9eca6087..97d08f055a 100644 --- a/

[Xen-devel] [xen-unstable-smoke test] 120733: regressions - FAIL

2018-03-14 Thread osstest service owner
flight 120733 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120733/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 120679 build-armhf

Re: [Xen-devel] [PATCH] libxc/arm: initialise p2m_size to make gcc happy

2018-03-14 Thread Andrew Cooper
On 14/03/18 12:32, Wei Liu wrote: > Gcc with -O3 failed to spot the loop to initialise p2m_size runs at > least once. It is -Og in this case, rather than -O3.  My -O3 comment on the thread was for the more generic cases. ~Andrew > > Signed-off-by: Wei Liu > --- > tools/libxc/xc_dom_arm.c | 3 +

Re: [Xen-devel] xl.cfg error in usbdev, doc and code are different

2018-03-14 Thread George Dunlap
On 03/14/2018 11:45 AM, Wei Liu wrote: > Cc George and Juergen > > On Wed, Mar 14, 2018 at 11:43:46AM +, Anthony PERARD wrote: >> Hi, >> >> I followed `man xl.cfg` to add an usbdev property to my guest config, >> and xl rejected it. >> >> # xl create "usbdev=['devtype=hostdev,hostbus=1,hostadd

Re: [Xen-devel] [PATCH] libxc/arm: initialise p2m_size to make gcc happy

2018-03-14 Thread Wei Liu
On Wed, Mar 14, 2018 at 12:35:48PM +, Andrew Cooper wrote: > On 14/03/18 12:32, Wei Liu wrote: > > Gcc with -O3 failed to spot the loop to initialise p2m_size runs at > > least once. > > It is -Og in this case, rather than -O3.  My -O3 comment on the thread > was for the more generic cases. O

[Xen-devel] [xen-unstable bisection] complete test-amd64-i386-xl-qemuu-debianhvm-amd64

2018-03-14 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-debianhvm-amd64 testid xen-boot Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git:/

Re: [Xen-devel] xl.cfg error in usbdev, doc and code are different

2018-03-14 Thread Wei Liu
On Wed, Mar 14, 2018 at 12:36:18PM +, George Dunlap wrote: > On 03/14/2018 11:45 AM, Wei Liu wrote: > > Cc George and Juergen > > > > On Wed, Mar 14, 2018 at 11:43:46AM +, Anthony PERARD wrote: > >> Hi, > >> > >> I followed `man xl.cfg` to add an usbdev property to my guest config, > >> an

Re: [Xen-devel] xl.cfg error in usbdev, doc and code are different

2018-03-14 Thread Juergen Gross
On 14/03/18 13:46, Wei Liu wrote: > On Wed, Mar 14, 2018 at 12:36:18PM +, George Dunlap wrote: >> On 03/14/2018 11:45 AM, Wei Liu wrote: >>> Cc George and Juergen >>> >>> On Wed, Mar 14, 2018 at 11:43:46AM +, Anthony PERARD wrote: Hi, I followed `man xl.cfg` to add an usbdev

Re: [Xen-devel] [PATCH] libxc/arm: initialise p2m_size to make gcc happy

2018-03-14 Thread Julien Grall
Hi, On 03/14/2018 12:32 PM, Wei Liu wrote: Gcc with -O3 failed to spot the loop to initialise p2m_size runs at least once. Aside, Andrew's comment the patch looks okay. But I am wondering why we need to allocate p2m_host for Arm? From a quick look I have seen no real user except xc_dom_upd

Re: [Xen-devel] [RFC PATCH 0/6] Using GitLab CI for build testing

2018-03-14 Thread Doug Goldstein
On 3/14/18 4:45 AM, George Dunlap wrote: > On Tue, Mar 13, 2018 at 3:31 AM, Doug Goldstein wrote: >> Really early work on switching over to using GitLab CI over >> Travis CI. GitLab is a competitor to GitHub with some advantages >> such as an integrated CI system with a lot more flexibility >> and

Re: [Xen-devel] [PATCH 51/57] ARM: new VGIC: Add preliminary stub implementation

2018-03-14 Thread Julien Grall
Hi, On 03/13/2018 03:55 PM, Andre Przywara wrote: Hi, On 09/03/18 18:18, Julien Grall wrote: Hi Andre, On 05/03/18 16:04, Andre Przywara wrote: The ARM arch code requires an interrupt controller emulation to implement vgic_clear_pending_irqs(), although it is suspected that it is actually no

Re: [Xen-devel] [xen-unstable-smoke bisection] complete build-arm64-xsm

2018-03-14 Thread Doug Goldstein
On 3/14/18 5:54 AM, Wei Liu wrote: > On Wed, Mar 14, 2018 at 09:01:10AM +, Andrew Cooper wrote: >> On 14/03/2018 07:59, Jan Beulich wrote: >> On 14.03.18 at 03:29, wrote: branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-arm64-xsm testid xen-build >>

Re: [Xen-devel] [PATCH] libxc/arm: initialise p2m_size to make gcc happy

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 13:35, wrote: > On 14/03/18 12:32, Wei Liu wrote: >> Gcc with -O3 failed to spot the loop to initialise p2m_size runs at >> least once. > > It is -Og in this case, rather than -O3. My -O3 comment on the thread > was for the more generic cases. Yeah, it is likely the fact that

Re: [Xen-devel] [PATCH] x86/pv: Fix guest crashes following f75b1a5247b "x86/pv: Drop int80_bounce from struct pv_vcpu"

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 12:51, wrote: > The original init_int80_direct_trap() was in fact buggy; `int $0x80` is not > an > exception. This went unnoticed for years because int80_bounce and > trap_bounce > were separate structures, but were combined by this change. > > Exception handling is differen

Re: [Xen-devel] [PATCH] x86/entry: Trivial nonfunctional fixes

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 12:55, wrote: > * Drop unnecessary size suffixes > * The C pseudocode refers to a trap_info object, not trap_bounce. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproje

Re: [Xen-devel] [PATCH] xenbaked.c: Avoid divide by zero issue on dump_stats()

2018-03-14 Thread Konrad Rzeszutek Wilk
On Wed, Mar 14, 2018 at 10:54:42AM +, George Dunlap wrote: > On Wed, Mar 14, 2018 at 2:24 AM, Konrad Rzeszutek Wilk > wrote: > > On Tue, Mar 13, 2018 at 06:38:24PM -0700, Joe Jin wrote: > >> run_time on dump_stats() maybe zero if break xenmon.py immediately after it > > > > s/maybe/can be/ > >

Re: [Xen-devel] [PATCH] x86/pv: Fix guest crashes following f75b1a5247b "x86/pv: Drop int80_bounce from struct pv_vcpu"

2018-03-14 Thread Andrew Cooper
On 14/03/18 13:58, Jan Beulich wrote: On 14.03.18 at 12:51, wrote: >> The original init_int80_direct_trap() was in fact buggy; `int $0x80` is not >> an >> exception. This went unnoticed for years because int80_bounce and >> trap_bounce >> were separate structures, but were combined by this

[Xen-devel] [PATCH v9 03/11] x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved for PVH Dom0

2018-03-14 Thread Roger Pau Monne
So that MMCFG regions not present in the MCFG ACPI table can be added at run time by the hardware domain. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Reviewed-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Paul Durrant --- Changes since v7: - Add newline in hvm_physd

[Xen-devel] [PATCH v9 11/11] vpci/msix: add MSI-X handlers

2018-03-14 Thread Roger Pau Monne
Add handlers for accesses to the MSI-X message control field on the PCI configuration space, and traps for accesses to the memory region that contains the MSI-X table and PBA. This traps detect attempts from the guest to configure MSI-X interrupts and properly sets them up. Note that accesses to t

[Xen-devel] [PATCH v9 07/11] vpci/bars: add handlers to map the BARs

2018-03-14 Thread Roger Pau Monne
Introduce a set of handlers that trap accesses to the PCI BARs and the command register, in order to snoop BAR sizing and BAR relocation. The command handler is used to detect changes to bit 2 (response to memory space accesses), and maps/unmaps the BARs of the device into the guest p2m. A rangese

[Xen-devel] [PATCH v9 09/11] vpci/msi: add MSI handlers

2018-03-14 Thread Roger Pau Monne
Add handlers for the MSI control, address, data and mask fields in order to detect accesses to them and setup the interrupts as requested by the guest. Note that the pending register is not trapped, and the guest can freely read/write to it. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc

[Xen-devel] [PATCH v9 01/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2018-03-14 Thread Roger Pau Monne
This functionality is going to reside in vpci.c (and the corresponding vpci.h header), and should be arch-agnostic. The handlers introduced in this patch setup the basic functionality required in order to trap accesses to the PCI config space, and allow decoding the address and finding the correspo

[Xen-devel] [PATCH v9 05/11] pci: add support to size ROM BARs to pci_size_mem_bar

2018-03-14 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Julien Grall Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu --- Changes since v6: - Remove the rom local variable. Changes si

[Xen-devel] [PATCH v9 10/11] vpci: add a priority parameter to the vPCI register initializer

2018-03-14 Thread Roger Pau Monne
This is needed for MSI-X, since MSI-X will need to be initialized before parsing the BARs, so that the header BAR handlers are aware of the MSI-X related holes and make sure they are not mapped in order for the trap handlers to work properly. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulic

[Xen-devel] [PATCH v9 04/11] pci: split code to size BARs from pci_add_device

2018-03-14 Thread Roger Pau Monne
So that it can be called from outside in order to get the size of regular PCI BARs. This will be required in order to map the BARs from PCI devices into PVH Dom0 p2m. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackso

[Xen-devel] [PATCH v9 02/11] x86/mmcfg: add handlers for the PVH Dom0 MMCFG areas

2018-03-14 Thread Roger Pau Monne
Introduce a set of handlers for the accesses to the MMCFG areas. Those areas are setup based on the contents of the hardware MMCFG tables, and the list of handled MMCFG areas is stored inside of the hvm_domain struct. The read/writes are forwarded to the generic vpci handlers once the address is d

[Xen-devel] [PATCH v9 00/11] vpci: PCI config space emulation

2018-03-14 Thread Roger Pau Monne
Hello, The following series contain an implementation of handlers for the PCI configuration space inside of Xen. This allows Xen to detect accesses to the PCI configuration space and react accordingly. Why is this needed? IMHO, there are two main points of doing all this emulation inside of Xen,

[Xen-devel] [PATCH v9 08/11] x86/pt: mask MSI vectors on unbind

2018-03-14 Thread Roger Pau Monne
When a MSI device with per-vector masking capabilities is detected or added to Xen all the vectors are masked when initializing it. This implies that the first time the interrupt is bound to a domain it's masked. This however only applies to the first time the interrupt is bound because neither th

[Xen-devel] [PATCH v9 06/11] xen: introduce rangeset_consume_ranges

2018-03-14 Thread Roger Pau Monne
This function allows to iterate over a rangeset while removing the processed regions. This will be used in order to split processing of large memory areas when mapping them into the guest p2m. Signed-off-by: Roger Pau Monné Reviewed-by: Wei Liu --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian

Re: [Xen-devel] [PATCH v4] tools: detect appropriate debug optimization level

2018-03-14 Thread Wei Liu
On Wed, Mar 14, 2018 at 02:16:31PM +, Wei Liu wrote: > On Mon, Mar 12, 2018 at 11:06:51PM -0500, Doug Goldstein wrote: > > When building debug use -Og as the optimization level if its available, > > otherwise retain the use of -O0. -Og has been added by GCC to enable all > > optimizations that

[Xen-devel] [xen-4.7-testing test] 120594: regressions - FAIL

2018-03-14 Thread osstest service owner
flight 120594 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120594/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-ws16-amd64 10 windows-install fail REGR. vs. 119780 Tests which are

Re: [Xen-devel] [PATCH v4] tools: detect appropriate debug optimization level

2018-03-14 Thread Wei Liu
On Mon, Mar 12, 2018 at 11:06:51PM -0500, Doug Goldstein wrote: > When building debug use -Og as the optimization level if its available, > otherwise retain the use of -O0. -Og has been added by GCC to enable all > optimizations that to not affect debugging while retaining full > debugability. > >

Re: [Xen-devel] [RFC PATCH 0/6] Using GitLab CI for build testing

2018-03-14 Thread George Dunlap
On 03/14/2018 01:28 PM, Doug Goldstein wrote: > On 3/14/18 4:45 AM, George Dunlap wrote: >> On Tue, Mar 13, 2018 at 3:31 AM, Doug Goldstein wrote: >>> Really early work on switching over to using GitLab CI over >>> Travis CI. GitLab is a competitor to GitHub with some advantages >>> such as an int

[Xen-devel] Deprecated option -usbdevice in QEMU

2018-03-14 Thread Anthony PERARD
Hi, In an xl guest config, we have the "usbdevice" option. It is just passthrough to QEMU "-usbdevice" without parsing. The QEMU option is now deprecated. v2.11 (to be released with Xen 4.11) is the last version of QEMU to have the option. Unfortunatly, our documentation relie on QEMU's documenta

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-14 Thread Andre Przywara
Hi, On 13/03/18 17:42, Julien Grall wrote: > Hi, > > On 13/03/18 17:34, Andre Przywara wrote: >> On 13/03/18 17:14, Julien Grall wrote: >>> On 13/03/18 17:02, Andre Przywara wrote: On 08/03/18 15:39, Julien Grall wrote: > On 05/03/18 16:03, Andre Przywara wrote: >>> I can't see how a kno

Re: [Xen-devel] [PATCH v9 01/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 15:03, wrote: > --- a/xen/drivers/Kconfig > +++ b/xen/drivers/Kconfig > @@ -12,4 +12,6 @@ source "drivers/pci/Kconfig" > > source "drivers/video/Kconfig" > > +source "drivers/vpci/Kconfig" Are there more things to appear in that new file? If not, what the point of introduc

[Xen-devel] [PATCH v2] libxl: allow libxl_domain_suspend to simply suspend a domain, without saving it

2018-03-14 Thread Marek Marczykowski-Górecki
When LIBXL_SUSPEND_NO_SAVE flag is set, no savefile will be written, but the domain will still be suspended (but not destroyed). The main reason for this functionality is to suspend the host while some domains are running, potentially holding PCI devices. This will give a chance to a driver in such

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-14 Thread Julien Grall
Hi, On 03/14/2018 02:30 PM, Andre Przywara wrote: Hi, On 13/03/18 17:42, Julien Grall wrote: Hi, On 13/03/18 17:34, Andre Przywara wrote: On 13/03/18 17:14, Julien Grall wrote: On 13/03/18 17:02, Andre Przywara wrote: On 08/03/18 15:39, Julien Grall wrote: On 05/03/18 16:03, Andre Przywar

Re: [Xen-devel] [PATCH v10] run QEMU as non-root

2018-03-14 Thread George Dunlap
On Thu, Nov 5, 2015 at 12:47 PM, Stefano Stabellini wrote: > diff --git a/docs/misc/qemu-deprivilege.txt b/docs/misc/qemu-deprivilege.txt > new file mode 100644 > index 000..dde74ab > --- /dev/null > +++ b/docs/misc/qemu-deprivilege.txt > @@ -0,0 +1,31 @@ > +For security reasons, libxl tries t

[Xen-devel] [SVM] Getting the length of the current instruction in svm_vmexit_handler()

2018-03-14 Thread Razvan Cojocaru
Hello, We'd like to retrieve the length of the current instruction in svm_vmexit_handler(), specifically for the VMEXIT_EXCEPTION_DB and VMEXIT_EXCEPTION_BP cases. We've combed the vmcb to no avail. Everything we've thought to check (exitinfo1, exitinfo2, exitintinfo) turns out to be zero there w

Re: [Xen-devel] xl.cfg error in usbdev, doc and code are different

2018-03-14 Thread Anthony PERARD
On Wed, Mar 14, 2018 at 12:46:35PM +, Wei Liu wrote: > On Wed, Mar 14, 2018 at 12:36:18PM +, George Dunlap wrote: > > On 03/14/2018 11:45 AM, Wei Liu wrote: > > > Cc George and Juergen > > > > > > On Wed, Mar 14, 2018 at 11:43:46AM +, Anthony PERARD wrote: > > >> Hi, > > >> > > >> I fo

[Xen-devel] [PATCH] docs: Fix entry for the "usbdev" option

2018-03-14 Thread Anthony PERARD
The man for xl.cfg have the "devtype=hostdev" option, but xl only understand "type=hostdev", fix the manual to reflect actual implementation. Signed-off-by: Anthony PERARD --- docs/man/xl.cfg.pod.5.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/man/xl.cfg.pod.5.in b/

Re: [Xen-devel] [PATCH v4 08/16] xen/mm: Drop the parameter mfn from populate_pt_range

2018-03-14 Thread Julien Grall
Hi Jan, On 03/12/2018 06:36 AM, Jan Beulich wrote: Wei Liu 03/09/18 6:30 PM >>> On Mon, Mar 05, 2018 at 07:38:36AM -0700, Jan Beulich wrote: On 05.03.18 at 15:11, wrote: On 05/03/18 14:00, Jan Beulich wrote: On 05.03.18 at 14:43, wrote: Anyway, I don't have much knowledge on the x86 to m

[Xen-devel] [xen-unstable-smoke test] 120745: regressions - FAIL

2018-03-14 Thread osstest service owner
flight 120745 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120745/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 120679 build-armhf

Re: [Xen-devel] [SVM] Getting the length of the current instruction in svm_vmexit_handler()

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 15:56, wrote: > We'd like to retrieve the length of the current instruction in > svm_vmexit_handler(), specifically for the VMEXIT_EXCEPTION_DB and > VMEXIT_EXCEPTION_BP cases. > > We've combed the vmcb to no avail. Everything we've thought to check > (exitinfo1, exitinfo2, exi

Re: [Xen-devel] [PATCH v2 06/27] x86/entry/64: Adapt assembly for PIE support

2018-03-14 Thread Christopher Lameter
On Wed, 14 Mar 2018, Peter Zijlstra wrote: > On Tue, Mar 13, 2018 at 01:59:24PM -0700, Thomas Garnier wrote: > > @@ -1576,7 +1578,9 @@ first_nmi: > > addq$8, (%rsp) /* Fix up RSP */ > > pushfq /* RFLAGS */ > > pushq $__KERNEL_CS/* CS */ > > - pushq

[Xen-devel] [PATCH v2 0/3] sndif: add explicit back and front synchronization

2018-03-14 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hello, all! In order to provide explicit synchronization between backend and frontend the following changes are introduced in the protocol: - bump protocol version to 2 - add new ring buffer for sending asynchronous events from backend to frontend to report num

[Xen-devel] [PATCH v2 2/3] sndif: Add explicit back and front synchronization

2018-03-14 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko In order to provide explicit synchronization between backend and frontend the following changes are introduced in the protocol: - bump protocol version to 2 - add new ring buffer for sending asynchronous events from backend to frontend to report number of bytes

[Xen-devel] [PATCH v2 1/3] sndif: Introduce protocol version

2018-03-14 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Protocol version was referenced in the protocol description, but missed its definition. Fix this by adding a constant for current protocol version. Signed-off-by: Oleksandr Andrushchenko --- xen/include/public/io/sndif.h | 7 +++ 1 file changed, 7 insertions(+

[Xen-devel] [PATCH v2 3/3] sndif: Add explicit back and front parameter negotiation

2018-03-14 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko In order to provide explicit stream parameter negotiation between backend and frontend the following changes are introduced in the protocol: add XENSND_OP_HW_PARAM_QUERY request to read/update configuration space for the parameter given: request passes desired parame

Re: [Xen-devel] [PATCH v4 12/16] xen/mm: Switch common/memory.c to use typesafe MFN

2018-03-14 Thread Julien Grall
Hi Jan, On 03/12/2018 06:39 AM, Jan Beulich wrote: Julien Grall 03/11/18 8:44 PM >>> On 03/09/2018 05:33 PM, Wei Liu wrote: On Mon, Mar 05, 2018 at 07:41:54AM -0700, Jan Beulich wrote: On 05.03.18 at 15:18, wrote: Also, do you have an opinion on Wei's suggestion: "What I meant was to make

Re: [Xen-devel] [PATCH v9 07/11] vpci/bars: add handlers to map the BARs

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 15:04, wrote: > +static void modify_decoding(const struct pci_dev *pdev, bool map, bool > rom_only) > +{ > +struct vpci_header *header = &pdev->vpci->header; > +uint8_t slot = PCI_SLOT(pdev->devfn), func = PCI_FUNC(pdev->devfn); > +unsigned int i; > + > +for ( i

Re: [Xen-devel] [PATCH v10] run QEMU as non-root

2018-03-14 Thread Anthony PERARD
On Wed, Mar 14, 2018 at 02:49:37PM +, George Dunlap wrote: > On Thu, Nov 5, 2015 at 12:47 PM, Stefano Stabellini > wrote: > > diff --git a/docs/misc/qemu-deprivilege.txt b/docs/misc/qemu-deprivilege.txt > > new file mode 100644 > > index 000..dde74ab > > --- /dev/null > > +++ b/docs/misc/q

Re: [Xen-devel] [PATCH v9 09/11] vpci/msi: add MSI handlers

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 15:04, wrote: > --- a/xen/drivers/vpci/vpci.c > +++ b/xen/drivers/vpci/vpci.c > @@ -47,6 +47,10 @@ void vpci_remove_device(struct pci_dev *pdev) > xfree(r); > } > spin_unlock(&pdev->vpci->lock); > +#ifdef __XEN__ > +/* NB: fields below are not exposed to t

Re: [Xen-devel] [PATCH v4 16/16] xen: Convert page_to_mfn and mfn_to_page to use typesafe MFN

2018-03-14 Thread Julien Grall
Hi Jan, On 03/02/2018 04:08 PM, Jan Beulich wrote: On 21.02.18 at 15:02, wrote: --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -43,16 +43,6 @@ #include "emulate.h" #include "mm.h" -/* Override macros from asm/page.h to make them work with mfn_t */ -#undef

Re: [Xen-devel] [PATCH v9 11/11] vpci/msix: add MSI-X handlers

2018-03-14 Thread Jan Beulich
>>> On 14.03.18 at 15:04, wrote: > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -1117,7 +1117,7 @@ int __init dom0_construct_pvh(struct domain *d, const > module_t *image, > > pvh_setup_mmcfg(d); > > -panic("Building a PVHv2 Dom0 is not yet supported

Re: [Xen-devel] [PATCH] docs: Fix entry for the "usbdev" option

2018-03-14 Thread George Dunlap
On 03/14/2018 03:00 PM, Anthony PERARD wrote: > The man for xl.cfg have the "devtype=hostdev" option, but xl only > understand "type=hostdev", fix the manual to reflect actual > implementation. > > Signed-off-by: Anthony PERARD Reviewed-by: George Dunlap ___

  1   2   >